Re: [Mesa-dev] [PATCH 15/15] radv: dump the list of enabled options when a hang occured

Okay, if you fix the few comments I sent, this series is Reviewed-by: Bas Nieuwenhuizen On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: > Useful to know which debug/perftest options were enabled when > a hang report is generated. >

Re: [Mesa-dev] [RFC] NIR serialization

On 12.09.2017 06:25, Ian Romanick wrote: On 09/07/2017 04:26 PM, Jordan Justen wrote: On 2017-09-06 14:12:41, Daniel Schürmann wrote: Hello together! Recently, we had a small discussion (off the list) about the NIR serialization, which was previously discussed in [RFC] ARB_gl_spirv and NIR

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

On Tue, Sep 12, 2017 at 9:13 PM, Samuel Pitoiset wrote: > > > On 09/12/2017 09:07 PM, Bas Nieuwenhuizen wrote: >> >> On Tue, Sep 12, 2017 at 8:57 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 09/12/2017 08:12 PM, Bas Nieuwenhuizen wrote:

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

On 09/12/2017 11:37 AM, Christian König wrote: Am 12.09.2017 um 17:32 schrieb Leo Liu: On 09/12/2017 11:23 AM, Christian König wrote: I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Since this change only

[Mesa-dev] [Bug 102677] [OpenGL CTS] KHR-GL45.CommonBugs.CommonBug_PerVertexValidation fails

https://bugs.freedesktop.org/show_bug.cgi?id=102677 Bug ID: 102677 Summary: [OpenGL CTS] KHR-GL45.CommonBugs.CommonBug_PerVertexValidation fails Product: Mesa Version: unspecified Hardware: Other

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

https://bugs.freedesktop.org/show_bug.cgi?id=102682 Bug ID: 102682 Summary: vblank_mode ignored from ~/.drirc Product: Mesa Version: 17.2 Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH 3/3] glsl: Unify ir_constant::const_elements and ::components

From: Ian Romanick There was no reason to treat array types and record types differently. Unifying them saves a bunch of code and saves a few bytes in every ir_constant. Signed-off-by: Ian Romanick --- src/compiler/glsl/glsl_to_nir.cpp

[Mesa-dev] [PATCH 2/3] glsl: Rename ir_constant::array_elements to ::const_elements

From: Ian Romanick The next patch will unify ::array_elements and ::components, so the name ::array_elements wouldn't be appropriate. A lot of things use the names array_elements and components, so grepping for either is pretty useless. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 1/3] glsl: Silence unused parameter warnings

From: Ian Romanick glsl/ast_type.cpp: In function ‘void merge_bindless_qualifier(YYLTYPE*, _mesa_glsl_parse_state*, const ast_type_qualifier&, const ast_type_qualifier&)’: glsl/ast_type.cpp:189:35: warning: unused parameter ‘loc’ [-Wunused-parameter]

Re: [Mesa-dev] [RFC] NIR serialization

On 09/11/2017 09:44 PM, Timothy Arceri wrote: > On 12/09/17 14:23, Ian Romanick wrote: >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: >>> On Thursday, September 7, 2017 4:26:04 PM PDT Jordan Justen wrote: On 2017-09-06 14:12:41, Daniel Schürmann wrote: > Hello together! > Recently,

Re: [Mesa-dev] [RFC] NIR serialization

On Tue, Sep 12, 2017 at 10:12 AM, Ian Romanick wrote: > On 09/11/2017 11:17 PM, Kenneth Graunke wrote: > > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick wrote: > >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: > >>> On Thursday, September 7, 2017 4:26:04 PM

Re: [Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format

Thank you, i have sent new patch version. Current call sequence in backward order: r600 => * r600_state_common.c::r600_translate_texformat and r600_state_common.c::r600_translate_colorformat is called from evergreen_state::r600_is_colorbuffer_format_supported and

[Mesa-dev] [PATCH 2/3] winsys/amdgpu: implement sync_file import/export

From: Marek Olšák syncobj is used internally for interactions with command submission. --- src/gallium/drivers/radeon/radeon_winsys.h | 12 +++ src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 115 +++-- src/gallium/winsys/amdgpu/drm/amdgpu_cs.h | 18

[Mesa-dev] [PATCH 1/3] ac: add radeon_info::has_sync_file

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c

[Mesa-dev] [PATCH 0/3] RadeonSI sync_file fences

Hi, This series adds support for sync_file fences, enabling EGL_ANDROID_native_fence_sync. Dependencies: Kernel patches (based on drm-next): drm/syncobj: extract two helpers from drm_syncobj_create drm/syncobj: add a new helper drm_syncobj_get_fd drm/amdgpu: add FENCE_TO_HANDLE

[Mesa-dev] [PATCH 3/3] radeonsi: implement sync_file import/export

From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 77 ++- src/gallium/drivers/radeonsi/si_pipe.c| 4 +- 2 files changed, 79 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_pipe_common.c

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids

Em Seg, 2017-09-11 às 10:10 -0700, Rodrigo Vivi escreveu: > On Mon, Sep 11, 2017 at 04:11:33PM +, Anuj Phogat wrote: > > See Mesa commits: ebc5ccf and b2dae9f > > I believe we need to be in sync between multiple gfx stack > components, > but I  don't believe we should remove ids. > > In the

[Mesa-dev] [PATCH] (UNTESTED) virgl: filter out 2D constant file accesses and declarations

From: Nicolai Hähnle Sorry for the mess. I suspect something like this patch is needed. Is this sufficient to fix the problem? Cheers, Nicolai --- src/gallium/drivers/virgl/virgl_tgsi.c | 24 1 file changed, 24 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] (UNTESTED) virgl: filter out 2D constant file accesses and declarations

FWIW, this patch should be a no-op without the offending "tgsi/ureg: always emit constants (and their decls) as 2D" commit. On 12.09.2017 22:34, Nicolai Hähnle wrote: From: Nicolai Hähnle Sorry for the mess. I suspect something like this patch is needed. Is this

[Mesa-dev] [PATCH] gallium/{r600, radeonsi}: Fix segfault with color format (v2)

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102552 v2: Patch cleanup proposed by Nicolai Hähnle. * deleted changes in si_translate_texformat. Cc: Nicolai Hähnle Cc: Ilia Mirkin --- src/gallium/auxiliary/util/u_format.c| 4

Re: [Mesa-dev] [RFC] NIR serialization

On Tue, Sep 12, 2017 at 11:09 AM, Jason Ekstrand wrote: > On Tue, Sep 12, 2017 at 10:12 AM, Ian Romanick > wrote: > >> On 09/11/2017 11:17 PM, Kenneth Graunke wrote: >> > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick wrote: >> >> On

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

On Tue, Sep 12, 2017 at 9:30 PM, Samuel Pitoiset wrote: > > > On 09/12/2017 09:16 PM, Bas Nieuwenhuizen wrote: >> >> On Tue, Sep 12, 2017 at 9:13 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 09/12/2017 09:07 PM, Bas Nieuwenhuizen wrote:

Re: [Mesa-dev] [PATCH 05/15] radv: dump the active shaders when a hang occured

On 09/12/2017 09:36 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 9:30 PM, Samuel Pitoiset wrote: On 09/12/2017 09:16 PM, Bas Nieuwenhuizen wrote: On Tue, Sep 12, 2017 at 9:13 PM, Samuel Pitoiset wrote: On 09/12/2017 09:07

Re: [Mesa-dev] [PATCH v2 02/12] tgsi/ureg: always emit constants (and their decls) as 2D

On Mon, Aug 28, 2017 at 3:58 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Acked-by: Roland Scheidegger > Tested-by: Dieter Nützel > --- > src/gallium/auxiliary/tgsi/tgsi_ureg.c | 22

[Mesa-dev] [PATCH 1/3] ac: add radeon_info::has_sync_file

From: Marek Olšák --- src/amd/common/ac_gpu_info.c | 1 + src/amd/common/ac_gpu_info.h | 1 + src/gallium/drivers/radeon/r600_pipe_common.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/amd/common/ac_gpu_info.c

[Mesa-dev] [Bug 102665] test_glsl_to_tgsi_lifetime.cpp:53:67: error: ‘?=>>=?UTF-8?Q?’ should be ‘?=> >=?UTF-8?Q?’ within a nested template argument list

https://bugs.freedesktop.org/show_bug.cgi?id=102665 --- Comment #4 from Vinson Lee --- In the travis build, the -std=c++11 option comes from LLVM_CXXFLAGS with llvm-3.9. Older llvm versions or builds without llvm will not have -std=c++11. -- You are receiving this mail

Re: [Mesa-dev] [PATCH 3/3] radv: clear push_constant_stages when resetting a command buffer

The series is Reviewed-by: Bas Nieuwenhuizen On Tue, Sep 12, 2017 at 7:08 PM, Samuel Pitoiset wrote: > Per the spec: > >"Resetting a command buffer is an operation that discards any >previously recorded commands and puts a command

Re: [Mesa-dev] [PATCH 02/15] radv: save the bound pipeline pointers into the trace BO

On Tue, Sep 12, 2017 at 12:35 PM, Samuel Pitoiset wrote: > When a GPU hang is detected in radv_gpu_hang_occured() we know > which command buffer is faulty but the bound pipelines might > have been updated during the execution. > > The pointers to the radv_pipeline

Re: [Mesa-dev] [PATCH] r600/sb: remove superfluos assert

On Tue, 12 Sep 2017 19:25:18 +0200, Vadim Girlin wrote: On 09/12/2017 12:49 PM, Gert Wollny wrote: Am Dienstag, den 12.09.2017, 09:56 +0300 schrieb Vadim Girlin: On 09/11/2017 07:09 PM, Emil Velikov wrote: Anyway, if num_arrays is 0 there, I suspect it can be a

Re: [Mesa-dev] [PATCH 22/23] HACK: anv: Fix query of ELF build-id on ARC++

On Mon 04 Sep 2017, Tapani Pälli wrote: > > > On 09/04/2017 08:37 AM, Tapani Pälli wrote: > > > > > > On 09/02/2017 11:17 AM, Chad Versace wrote: > > > NOT FOR UPSTREAM. > > > > > > To get the driver's build-id, anv_physical_device_init_uuids() searches > > > the current process for an ELF

[Mesa-dev] [Bug 102665] test_glsl_to_tgsi_lifetime.cpp:53:67: error: ‘?=>>=?UTF-8?Q?’ should be ‘?=> >=?UTF-8?Q?’ within a nested template argument list

https://bugs.freedesktop.org/show_bug.cgi?id=102665 --- Comment #3 from Gert Wollny --- @Vinson: on Travis with the exact same version of g++ you reported (gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 [1] the build runs through without modifying the source (I had to enable

[Mesa-dev] [PATCH mesa] docs/egl: remove reference to EGL_DRIVERS_PATH

Support for external egl drivers was dropped a few years ago. Fixes: 209360bbb91bb10346eb "egl/main: drop support for external egl drivers" Signed-off-by: Eric Engestrom --- docs/egl.html | 21 - 1 file changed, 21 deletions(-) diff --git

[Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

In code: template.height = align(tmpl->height / array_size, VL_MACROBLOCK_HEIGHT); ... template.height *= array_size; It turns out the height will be aligned with 2*VL_MACROBLOCK_HEIGHT. The problematic case for example is when VA-API postproc scaling with blit between

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

Hi Leo, On 12 September 2017 at 14:56, Leo Liu wrote: > In code: > template.height = align(tmpl->height / array_size, > VL_MACROBLOCK_HEIGHT); > ... > template.height *= array_size; > > It turns out the height will be aligned with 2*VL_MACROBLOCK_HEIGHT.

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

On 09/12/2017 10:24 AM, Emil Velikov wrote: Hi Leo, On 12 September 2017 at 14:56, Leo Liu wrote: In code: template.height = align(tmpl->height / array_size, VL_MACROBLOCK_HEIGHT); ... template.height *= array_size; It turns out the height will

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Instead we should rather fix the scaler to use the original width/height of the video buffer and not the adjusted width/height of the resources. Regards,

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

On Tue, Sep 12, 2017 at 2:40 AM, Marathe, Yogesh wrote: > Hi Jason, > > > > On the asserts you’ve mentioned below, I assume we need to add them after > ‘bufmgr->num_buckets++’ in add_bucket() as num_buckets could be 0 initially. > Yes, because otherwise bucket_for_size

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

On 09/12/2017 11:23 AM, Christian König wrote: I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Since this change only affects 720p video, so I did quite a bit tests on 720p video dec/enc, and haven't see any

Re: [Mesa-dev] [PATCH] radeonsi/uvd: fix interlaced video buffer height alignment

Am 12.09.2017 um 17:32 schrieb Leo Liu: On 09/12/2017 11:23 AM, Christian König wrote: I don't think this is correct. A long long time ago I've came up with this because the firmware didn't liked what you proposed below. Since this change only affects 720p video, so I did quite a bit tests

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

On Tuesday, 2017-09-12 17:26:43 +0200, Gert Wollny wrote: > Am Dienstag, den 12.09.2017, 12:26 +0100 schrieb Emil Velikov: > > On 12 September 2017 at 11:17, Gert Wollny > > wrote: > > > > > > > > > Is there a docker image available that resembles the travis-ci > > > build

Re: [Mesa-dev] [PATCH mesa] radv: compile out unused code

Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is there a mesa Docker image available like on travis-ci? (was Re: [PATCH 1/2] gallium/targets/dri: Add libunwind to linker flags)

Am Dienstag, den 12.09.2017, 12:26 +0100 schrieb Emil Velikov: > On 12 September 2017 at 11:17, Gert Wollny > wrote: > > > > > > Is there a docker image available that resembles the travis-ci > > build environment as it is set up in mesa/.travis.yml (i.e. > > Ubuntu/Trusty

[Mesa-dev] [PATCH 3/3] radv: clear push_constant_stages when resetting a command buffer

Per the spec: "Resetting a command buffer is an operation that discards any previously recorded commands and puts a command buffer in the initial state." As far I'm concerned, that flag can be changed by calling VkCmdPushConstants() (or any other functions which update it), so it should

[Mesa-dev] [PATCH 2/3] radv: add more radv_emit_XXX() helpers for the dynamic state

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 117 ++- 1 file changed, 77 insertions(+), 40 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index

[Mesa-dev] [PATCH 1/3] radv: remove useless 'cmd_buffer' param from radv_buffer_view_init()

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_image.c | 5 ++--- src/amd/vulkan/radv_meta_blit2d.c | 2 +- src/amd/vulkan/radv_meta_bufimage.c | 2 +- src/amd/vulkan/radv_private.h | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-) diff

Re: [Mesa-dev] [RFC] NIR serialization

On 09/11/2017 11:17 PM, Kenneth Graunke wrote: > On Monday, September 11, 2017 9:23:05 PM PDT Ian Romanick wrote: >> On 09/08/2017 01:59 AM, Kenneth Graunke wrote: >>> On Thursday, September 7, 2017 4:26:04 PM PDT Jordan Justen wrote: On 2017-09-06 14:12:41, Daniel Schürmann wrote: >

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

On 09/08/2017 08:38 AM, Jason Ekstrand wrote: > In general, I'm very concerned about how this handles rounding > behavior. Almost everywhere, you round down when what you want to do is > round up. Also, as I said on IRC, I'd like to see some asserts in > add_bucket so that we are sure this

Re: [Mesa-dev] [PATCH] i965 : optimized bucket index calculation

On 09/12/2017 02:40 AM, Marathe, Yogesh wrote: > Hi Jason, > > > > On the asserts you’ve mentioned below, I assume we need to add them > after ‘bufmgr->num_buckets++’ in add_bucket() as num_buckets could be 0 > initially. Another clarification on ~1%, we meant approx. 1% there, > that’s an

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/2] drm/i915/kbl: Remove unused Kabylake pci ids

On Mon, Sep 11, 2017 at 10:10 AM, Rodrigo Vivi wrote: > On Mon, Sep 11, 2017 at 04:11:33PM +, Anuj Phogat wrote: >> See Mesa commits: ebc5ccf and b2dae9f > > I believe we need to be in sync between multiple gfx stack components, > but I don't believe we should remove

Re: [Mesa-dev] [PATCH mesa] radv: compile out unused code

Reviewed-by: Bas Nieuwenhuizen On 12 Sep 2017 5:11 PM, "Eric Engestrom" wrote: Signed-off-by: Eric Engestrom --- src/amd/vulkan/radv_wsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] r600/sb: remove superfluos assert

On 09/12/2017 12:49 PM, Gert Wollny wrote: Am Dienstag, den 12.09.2017, 09:56 +0300 schrieb Vadim Girlin: On 09/11/2017 07:09 PM, Emil Velikov wrote: Anyway, if num_arrays is 0 there, I suspect it can be a result of some other issue. At the very least it looks like a potential performance 

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

https://bugs.freedesktop.org/show_bug.cgi?id=102682 --- Comment #1 from Gustaw Smolarczyk --- Hi, The problem seems to be with the `driver="radeonsi"' part (the screen attribute is not used when driver is present). It seems that there is a bug and an incorrect driver name

Re: [Mesa-dev] [PATCH mesa] glsl: compile unused function out

On Tue, Sep 12, 2017 at 8:01 AM, Eric Engestrom wrote: > The function is only called from one place, which is hidden behind > the same `#ifdef DEBUG`. > > Fixes: ca73c3358c91434e68ab "glsl: Mark functions static" > Signed-off-by: Eric Engestrom

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

https://bugs.freedesktop.org/show_bug.cgi?id=102682 --- Comment #2 from Niklas Haas --- Verifying that your work-around does, indeed, work around the issue. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 102682] vblank_mode ignored from ~/.drirc

https://bugs.freedesktop.org/show_bug.cgi?id=102682 --- Comment #3 from Gustaw Smolarczyk --- Was too fast. The passed driver name is not "loader" but "dri2". And I think it's intentional, since vblank_mode is not an option of a device driver but of the dri infrastructure.

<    1   2