Re: [Mesa-dev] [PATCH] etnaviv: Fix point sprite issue on HALTI0

2017-11-18 Thread Wladimir J. van der Laan
On Thu, Nov 16, 2017 at 01:38:32PM -0500, Ilia Mirkin wrote: > > Which is annoying as it means that shader state now depends on either the > > kind > > of primitive (which is per-draw), or the shading model (which is part of > > rasterizer state). > > I take it your hardware doesn't support

[Mesa-dev] [PATCH v2 13/17] etnaviv: GC7000: Make point sprites work on HALTI5

2017-11-18 Thread Wladimir J. van der Laan
Track varying component offset of the point size output, as well as provide the offset of the point coord input. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_compiler.c | 21

[Mesa-dev] [PATCH v2 09/17] etnaviv: GC7000: No RS align when using BLT

2017-11-18 Thread Wladimir J. van der Laan
RS align is not necessary and might even be harmful when using the BLT engine for blitting. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 15 +

[Mesa-dev] [PATCH v2 14/17] etnaviv: GC7000: Track dirty sampler views

2017-11-18 Thread Wladimir J. van der Laan
Need this to efficiently emit texture descriptor invalidations. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.c | 1 + src/gallium/drivers/etnaviv/etnaviv_context.h | 1 +

[Mesa-dev] [PATCH v2 08/17] etnaviv: GC7000: BLT engine blitting support

2017-11-18 Thread Wladimir J. van der Laan
Add an implemenation of key clear_blit functions using the BLT engine that replaced the RS on GC7000. Also set level->size correctly for imported resources. This is important for the BLT resolve-in-place path to work for them. Signed-off-by: Wladimir J. van der Laan ---

[Mesa-dev] [PATCH v2 11/17] etnaviv: GC7000: Update screen specs for HALTI5

2017-11-18 Thread Wladimir J. van der Laan
- This core must load shaders from memory (AFAIK) - Yet another new location for UNIFORMS Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_screen.c | 19 +++ 1 file

[Mesa-dev] [PATCH v2 17/17] etnaviv: GC7000: Factor out state based texture functionality

2017-11-18 Thread Wladimir J. van der Laan
Prepare for two texture handling paths, the descriptor-based path will be added in a future commit. These are structured so that the texture implementation handles its own state emission. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner

[Mesa-dev] [PATCH v2 16/17] etnaviv: GC7000: Move active_samplers_bits to texture

2017-11-18 Thread Wladimir J. van der Laan
This needs to be shared between texture_plain and texture_desc. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c| 12

[Mesa-dev] [PATCH v2 12/17] etnaviv: GC7000: State changes for HALTI3..5

2017-11-18 Thread Wladimir J. van der Laan
Update state objects to add new state, and emit function to emit new state. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 246 +++--

[Mesa-dev] [PATCH v2 05/17] etnaviv: GC7000: Support BLT as recipient for etna_stall

2017-11-18 Thread Wladimir J. van der Laan
When the BLT is involved as source or target, add an extra BLT enable/disable sequence around the sync sequence. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-)

[Mesa-dev] [PATCH v2 15/17] etnaviv: GC7000: Factor out incompatible texture handling logic

2017-11-18 Thread Wladimir J. van der Laan
This will be shared with the texture descriptor path. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_texture.c | 42 +--

[Mesa-dev] [PATCH v2 10/17] etnaviv: GC7000: Update context reset for ..HALTI5

2017-11-18 Thread Wladimir J. van der Laan
Update context reset for HALTI3..HALTI5, sorting states for the HALTI version that has them. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_context.c | 37 +++

[Mesa-dev] [PATCH v2 02/17] etnaviv: Put HALTI level in specs

2017-11-18 Thread Wladimir J. van der Laan
The HALTI level is an indication of the gross architecture of the GPU. It determines for significant part what feature level the GPU has, what state (especially frontend state) is there, and where it is located. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian

[Mesa-dev] [PATCH v2 03/17] etnaviv: Emit SCALE for vertex attributes

2017-11-18 Thread Wladimir J. van der Laan
This is used by HALTI2+ (GC3000+) when drawing with DRAW_INSTANCED. It is also necessary when switching between integer and floating point vertex element formats. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner ---

[Mesa-dev] [PATCH v2 07/17] etnaviv: GC7000: Factor out RS blit functionality

2017-11-18 Thread Wladimir J. van der Laan
Prepare for BLT-based blitting path by moving RS-based blitting to the RS implementation file, making this self-contained. Signed-off-by: Wladimir J. van der Laan --- src/gallium/drivers/etnaviv/etnaviv_clear_blit.c | 558 +--

[Mesa-dev] [PATCH v2 06/17] etnaviv: GC7000: Move etna_coalesce to emit header file

2017-11-18 Thread Wladimir J. van der Laan
Want to be able to emit state from the texture implementation, and the blitter implementation. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.c | 83

[Mesa-dev] [PATCH v2 00/17] etnaviv: GC7000 preparation

2017-11-18 Thread Wladimir J. van der Laan
This is the entire patch set needed for GC7000 support in Mesa, except for implementation of texture descriptors. There is a DRM kernel interface issue to resolve there [1]. I'm sending this early to get some eyes on it, and because it is quite a large patch-set and will be challenging to keep

[Mesa-dev] [PATCH v2 01/17] etnaviv: Const-correctness etnaviv_emit.h

2017-11-18 Thread Wladimir J. van der Laan
The relocation structure is never changed by submitting it. Signed-off-by: Wladimir J. van der Laan Reviewed-by: Philipp Zabel Reviewed-by: Christian Gmeiner --- src/gallium/drivers/etnaviv/etnaviv_emit.h | 2 +- 1 file

[Mesa-dev] [PATCH v2 04/17] etnaviv: Use only DRAW_INSTANCED on GC3000+

2017-11-18 Thread Wladimir J. van der Laan
The blob does this, as DRAW_INSTANCED can replace fully all the other draw commands. It is also required to handle integer vertex formats. The other path is only there for compatibility and might go away (or at least rot to become buggy due to dis-use) in newer hardware. As a by-effect this

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-18 Thread Jason Ekstrand
On Sat, Nov 18, 2017 at 9:02 AM, Grazvydas Ignotas wrote: > On Sat, Nov 18, 2017 at 3:06 AM, Jason Ekstrand > wrote: > > On Fri, Nov 17, 2017 at 2:18 PM, Grazvydas Ignotas > > wrote: > >> > >> I've tested this branch (rx470 + hd530)

[Mesa-dev] [Bug 103586] OpenCL/Clover: AMD Turks: corrupt output buffer (depending on dimension order?)

2017-11-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103586 --- Comment #15 from Dave Gilbert --- Hi Jan, Yes, doing: --- a/ocl.cpp +++ b/ocl.cpp @@ -65,6 +65,7 @@ static int got_dev(cl::Platform , std::vector , cl::Dev events.push_back(event); cl::Event eventMap;

Re: [Mesa-dev] [PATCH 00/28] vulkan/wsi: Rework WSI to look a lot more like a layer

2017-11-18 Thread Grazvydas Ignotas
On Sat, Nov 18, 2017 at 3:06 AM, Jason Ekstrand wrote: > On Fri, Nov 17, 2017 at 2:18 PM, Grazvydas Ignotas > wrote: >> >> I've tested this branch (rx470 + hd530) and it's only partially working: >> - display on amd, radv: always fails with "offscreen: >>