Re: [Mesa-dev] [PATCH] anv: Restrict the nuber of color regions to those actually written

2018-07-12 Thread Jason Ekstrand
On Thu, Jul 12, 2018 at 10:28 AM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > > > Question: earlier in the code we call > > > > > >populate_wm_prog_key(pipeline, info, ); > > > > > > which does > > > > > >key->nr_color_regions = pipeline->subpass->color_count; > > >

[Mesa-dev] [PATCH] util/hash_table: add helper to remove entry by key

2018-07-12 Thread Caio Marcelo de Oliveira Filho
And the corresponding test case. --- src/util/hash_table.c | 9 src/util/hash_table.h | 2 + src/util/tests/hash_table/.gitignore | 1 + src/util/tests/hash_table/Makefile.am | 1 + src/util/tests/hash_table/meson.build | 3 +-

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #35 from erhar...@mailbox.org --- Created attachment 140612 --> https://bugs.freedesktop.org/attachment.cgi?id=140612=edit output from lp_test_* (ppc64) Here's the ouptut from my other G5's ppc64 BE setup. I will certainly try

[Mesa-dev] [PATCH] intel: tools: Fix uninitialized variable warnings in intel_dump_gpu.

2018-07-12 Thread Eric Anholt
--- src/intel/tools/intel_dump_gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/tools/intel_dump_gpu.c b/src/intel/tools/intel_dump_gpu.c index 1201fa35ae0c..766ba662d910 100644 --- a/src/intel/tools/intel_dump_gpu.c +++ b/src/intel/tools/intel_dump_gpu.c @@ -728,6 +728,8 @@

Re: [Mesa-dev] [PATCH v2] vulkan: Fix compilation on older platforms

2018-07-12 Thread Dylan Baker
Quoting Danylo Piliaiev (2018-07-12 06:09:57) > Make xlease automatically enabled only if xcb-randr >= 1.13, > check its version if manually enabled. > > Enable VK_EXT_display_control only when libdrm >= 2.4.89 > > Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. > > Add

Re: [Mesa-dev] [PATCH] meson: Move xvmc test tools from unit tests to installed tools.

2018-07-12 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Eric Anholt (2018-07-12 11:44:45) > These are not unit tests, as they rely on the host's XVMC and some user > configuration. Switch them over to being general installed tools, to fix > unit testing. > > Fixes: 22a817af8a89 ("meson: build gallium xvmc state

Re: [Mesa-dev] [PATCH] anv: Restrict the nuber of color regions to those actually written

2018-07-12 Thread Jason Ekstrand
On Thu, Jul 12, 2018 at 10:29 AM Caio Marcelo de Oliveira Filho < caio.olive...@intel.com> wrote: > On Sat, Jul 07, 2018 at 09:35:52AM -0700, Jason Ekstrand wrote: > > On Thu, Jul 5, 2018 at 6:34 PM Caio Marcelo de Oliveira Filho < > > caio.olive...@intel.com> wrote: > > > > > On Wed, Jun 27,

Re: [Mesa-dev] [PATCH 3/3] i965/miptree: Use the correct BLT pitch

2018-07-12 Thread Nanley Chery
On Thu, Jul 12, 2018 at 06:35:06PM +0100, Chris Wilson wrote: > Quoting Nanley Chery (2018-07-12 18:28:16) > > Retile miptrees to a linear tiling less often. Retiling can cause issues > > with imported BOs. > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106738 > > Suggested-by:

Re: [Mesa-dev] [PATCH 2/2] u_blitter: Add an option to draw the triangles using an index buffer.

2018-07-12 Thread Eric Anholt
Roland Scheidegger writes: > Am 12.07.2018 um 00:05 schrieb Eric Anholt: >> For V3D, the HW will interpolate slightly differently along the shared >> edge of the trifan. The conformance tests manage to catch this in the >> nearest_consistency_* group. To get interpolation to match, we need the

Re: [Mesa-dev] [PATCH 7/9] radeonsi: rework RADEON_PRIO flags to be <= 31

2018-07-12 Thread Marek Olšák
On Thu, Jul 12, 2018 at 2:24 AM, Timothy Arceri wrote: > Two suggestions below. > > > On 12/07/18 15:26, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This decreases sizeof(struct amdgpu_cs_buffer) from 24 to 16 bytes. >> --- >> src/gallium/drivers/radeon/radeon_winsys.h| 39

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-12 Thread Marek Olšák
On Thu, Jul 12, 2018 at 7:07 AM, Michel Dänzer wrote: > On 2018-07-12 12:12 PM, Timothy Arceri wrote: >> >> >> On 12/07/18 19:00, Michel Dänzer wrote: >>> On 2018-07-12 07:26 AM, Marek Olšák wrote: From: Marek Olšák TODO: requires latest libdrm for

[Mesa-dev] [PATCH] meson: Move xvmc test tools from unit tests to installed tools.

2018-07-12 Thread Eric Anholt
These are not unit tests, as they rely on the host's XVMC and some user configuration. Switch them over to being general installed tools, to fix unit testing. Fixes: 22a817af8a89 ("meson: build gallium xvmc state tracker") --- meson.build | 2 +-

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: emit a dummy ZPASS_DONE to prevent GPU hangs on GFX9

2018-07-12 Thread Dylan Baker
Quoting Samuel Pitoiset (2018-07-11 02:55:55) > A ZPASS_DONE or PIXEL_STAT_DUMP_EVENT (of the DB occlusion > counters) must immediately precede every timestamp event to > prevent a GPU hang on GFX9. > > Signed-off-by: Samuel Pitoiset > Cc: 18.1 > --- > src/amd/vulkan/radv_cmd_buffer.c | 15

Re: [Mesa-dev] [PATCH] anv: Restrict the nuber of color regions to those actually written

2018-07-12 Thread Caio Marcelo de Oliveira Filho
On Thu, Jul 12, 2018 at 12:54:54PM -0700, Jason Ekstrand wrote: > On Thu, Jul 12, 2018 at 10:28 AM Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > > > > > Question: earlier in the code we call > > > > > > > >populate_wm_prog_key(pipeline, info, ); > > > > > > > > which

[Mesa-dev] [Bug 107211] Write access request: Mesa

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107211 Jason Ekstrand changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] nir: cleanup oversized arrays in nir_swizzle calls

2018-07-12 Thread Karol Herbst
There are no fixed sized array arguments in C, those are simply pointers to unsized arrays and as the size is passed in anyway, just rely on that. where possible calls are replaced by nir_channel and nir_channels. Signed-off-by: Karol Herbst --- src/amd/vulkan/radv_meta_blit2d.c | 9

Re: [Mesa-dev] [PATCH] nir: cleanup oversized arrays in nir_swizzle calls

2018-07-12 Thread Karol Herbst
On Fri, Jul 13, 2018 at 4:04 AM, Jason Ekstrand wrote: > On Thu, Jul 12, 2018 at 6:48 PM Karol Herbst wrote: >> >> There are no fixed sized array arguments in C, those are simply pointers >> to unsized arrays and as the size is passed in anyway, just rely on that. >> >> where possible calls are

Re: [Mesa-dev] [PATCH] nir: cleanup oversized arrays in nir_swizzle calls

2018-07-12 Thread Jason Ekstrand
On Thu, Jul 12, 2018 at 7:20 PM Karol Herbst wrote: > On Fri, Jul 13, 2018 at 4:04 AM, Jason Ekstrand > wrote: > > On Thu, Jul 12, 2018 at 6:48 PM Karol Herbst wrote: > >> > >> There are no fixed sized array arguments in C, those are simply pointers > >> to unsized arrays and as the size is

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 --- Comment #8 from Timothy Arceri --- (In reply to Samuel Pitoiset from comment #7) > Really nice, thanks! Closing. I don't think that's right. I don't think the bug was even in the 18.1 release to begin with going by the dates given in the

[Mesa-dev] [PATCH 2/2] intel/blorp: Handle 3-component formats in clears

2018-07-12 Thread Jason Ekstrand
This fixes a nasty hang in Batman: Arkham City which apparently calls vkCmdClearColorImage on a linear RGB image. cc: mesa-sta...@lists.freedesktop.org --- src/intel/blorp/blorp_blit.c | 2 +- src/intel/blorp/blorp_clear.c | 98 +++ src/intel/blorp/blorp_priv.h

[Mesa-dev] [PATCH 1/2] intel/blorp: Fix blits to R8G8B8_UNORM_SRGB

2018-07-12 Thread Jason Ekstrand
In this case, the surface faking will give us a R8_UNORM surface and we need to do an sRGB conversion in the shader. cc: mesa-sta...@lists.freedesktop.org --- src/intel/blorp/blorp_blit.c | 4 1 file changed, 4 insertions(+) diff --git a/src/intel/blorp/blorp_blit.c

Re: [Mesa-dev] [PATCH] nir: cleanup oversized arrays in nir_swizzle calls

2018-07-12 Thread Jason Ekstrand
On Thu, Jul 12, 2018 at 6:48 PM Karol Herbst wrote: > There are no fixed sized array arguments in C, those are simply pointers > to unsized arrays and as the size is passed in anyway, just rely on that. > > where possible calls are replaced by nir_channel and nir_channels. > > Signed-off-by:

Re: [Mesa-dev] [PATCH] util/hash_table: add helper to remove entry by key

2018-07-12 Thread Eric Anholt
Caio Marcelo de Oliveira Filho writes: > And the corresponding test case. Reviewed-by: Eric Anholt signature.asc Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 107211] Write access request: Mesa

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107211 Bug ID: 107211 Summary: Write access request: Mesa Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority:

[Mesa-dev] [Bug 107211] Write access request: Mesa

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107211 Caio Marcelo de Oliveira Filho changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |ja...@jlekstrand.net

[Mesa-dev] [PATCH 1/2] egl/surfaceless: Define DRI_SWRastLoader extension when using swrast.

2018-07-12 Thread David Riley
Signed-off-by: David Riley --- src/egl/drivers/dri2/platform_surfaceless.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri2/platform_surfaceless.c b/src/egl/drivers/dri2/platform_surfaceless.c index a0348a5..f5fe711 100644

[Mesa-dev] [PATCH 2/2] egl/surfaceless: Allow DRMless fallback.

2018-07-12 Thread David Riley
Allow platform_surfaceless to use swrast even if DRM is not available. To be used to allow a fuzzer for virgl to be run on a jailed VM without hardware GL or DRM support. Signed-off-by: David Riley --- src/egl/drivers/dri2/platform_surfaceless.c | 20 1 file changed, 20

Re: [Mesa-dev] [PATCH] nir/lower_tex: Use nir_format_srgb_to_linear

2018-07-12 Thread Jason Ekstrand
Eric, I can't test this patch because it only affects your driver. On Thu, Jul 12, 2018 at 6:23 PM Jason Ekstrand wrote: > A while ago, we added a bunch of format conversion helpers; we should > use them instead of hand-rolling sRGB conversions. > --- > src/compiler/nir/nir_lower_tex.c | 21

[Mesa-dev] [PATCH] nir/lower_tex: Use nir_format_srgb_to_linear

2018-07-12 Thread Jason Ekstrand
A while ago, we added a bunch of format conversion helpers; we should use them instead of hand-rolling sRGB conversions. --- src/compiler/nir/nir_lower_tex.c | 21 +++-- 1 file changed, 3 insertions(+), 18 deletions(-) diff --git a/src/compiler/nir/nir_lower_tex.c

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-12 Thread Samuel Pitoiset
On 07/12/2018 08:21 AM, Timothy Arceri wrote: On 12/07/18 15:26, Marek Olšák wrote: From: Marek Olšák TODO: requires latest libdrm for amdgpu_bo_handle_type_kms_noimport Forgot to bump this? libdrm doesn't seem to contain the required function. I guess Marek has some local patches and

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-12 Thread Timothy Arceri
On 12/07/18 15:26, Marek Olšák wrote: From: Marek Olšák TODO: requires latest libdrm for amdgpu_bo_handle_type_kms_noimport Forgot to bump this? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 5/5] radv: simplify the logic in radv_set_descriptor_set()

2018-07-12 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Tue, Jul 10, 2018 at 4:13 PM, Samuel Pitoiset wrote: > Now that 'set' can't be NULL because the meta operations no > longer bind a NULL descriptor, the logic can be simplified > a little bit. > > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH 2/3] docs/features: Move the Vulkan 1.1 extensions to the 1.1 section

2018-07-12 Thread Bas Nieuwenhuizen
On Thu, Jul 12, 2018 at 1:03 AM, Jason Ekstrand wrote: > While we're at it, add some extensions we missed along the way like the > VK_KHR_maintenanceN extensions. > --- > docs/features.txt | 39 +-- > 1 file changed, 25 insertions(+), 14 deletions(-) > > diff

Re: [Mesa-dev] [PATCH] vulkan: Fix compilation on older platforms

2018-07-12 Thread Danylo Piliaiev
On 11.07.18 20:43, Dylan Baker wrote: Quoting Danylo Piliaiev (2018-07-11 04:26:03) diff --git a/meson.build b/meson.build index 7d12af3d51..2683060827 100644 --- a/meson.build +++ b/meson.build @@ -1088,6 +1088,8 @@ _drm_freedreno_ver = '2.4.92' _drm_intel_ver = '2.4.75' _drm_ver =

[Mesa-dev] [Bug 107169] [regression] Upgrade from 18.0.4 to 18.1.0 causes severe stuttering in games

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107169 --- Comment #4 from Denis --- >GPU: Ati Radeon HD3000 oh... my bad, yesterday I was sure that I saw here Intel HD3000 :( And I had exactly that GPU... Do you have any intel card to check the issue (whether it actual or not on it?) -- You are

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-12 Thread Michel Dänzer
On 2018-07-12 07:26 AM, Marek Olšák wrote: > From: Marek Olšák > > TODO: requires latest libdrm for amdgpu_bo_handle_type_kms_noimport > --- > src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 +++ > src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 2 + > src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 54

Re: [Mesa-dev] [PATCH 7/9] radeonsi: rework RADEON_PRIO flags to be <= 31

2018-07-12 Thread Timothy Arceri
Two suggestions below. On 12/07/18 15:26, Marek Olšák wrote: From: Marek Olšák This decreases sizeof(struct amdgpu_cs_buffer) from 24 to 16 bytes. --- src/gallium/drivers/radeon/radeon_winsys.h| 39 ++- src/gallium/drivers/radeonsi/si_debug.c | 2 +-

Re: [Mesa-dev] [Mesa-stable] [PATCH v3] radv: make sure to wait for CP DMA when needed

2018-07-12 Thread Samuel Pitoiset
On 07/11/2018 06:52 PM, Dylan Baker wrote: Quoting Samuel Pitoiset (2018-07-09 09:02:58) This might fix some synchronization issues. I don't know if that will affect performance but it's required for correctness. v3: - wait for CP DMA in CmdPipelineBarrier() - clear the busy value when

Re: [Mesa-dev] [PATCH 8/9] winsys/amdgpu: clean up error handling in amdgpu_cs_submit_ib

2018-07-12 Thread Samuel Pitoiset
With Timothy suggestions applied, patches 1-8 are: Reviewed-by: Samuel Pitoiset On 07/12/2018 07:26 AM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-12 Thread Michel Dänzer
On 2018-07-12 12:12 PM, Timothy Arceri wrote: > > > On 12/07/18 19:00, Michel Dänzer wrote: >> On 2018-07-12 07:26 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> TODO: requires latest libdrm for amdgpu_bo_handle_type_kms_noimport >>> --- >>>   src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 

[Mesa-dev] [PATCH 2/6] nir/spirv: implement BuiltInWorkDim

2018-07-12 Thread Karol Herbst
From: Rob Clark Signed-off-by: Karol Herbst --- src/compiler/nir/nir.c | 2 ++ src/compiler/nir/nir_intrinsics.py | 1 + src/compiler/shader_enums.c| 1 + src/compiler/shader_enums.h| 1 + src/compiler/spirv/vtn_variables.c | 4 5 files changed, 9 insertions(+)

[Mesa-dev] [PATCH 6/6] nir/spirv: handle functions with scalar and vector params

2018-07-12 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/spirv/vtn_cfg.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c index ed1ab5d1c2c..2b01ede6f81 100644 --- a/src/compiler/spirv/vtn_cfg.c +++

[Mesa-dev] [PATCH 0/6] More OpenCL preparation for nir

2018-07-12 Thread Karol Herbst
This time all of the patches can be reviewed independently. Karol Herbst (5): nir/spirv: print id for unsupported builtins nir: add builtin builder nir: fix printing of vec16 type nir: prepare for bumping up max components to 16 nir/spirv: handle functions with scalar and vector params

[Mesa-dev] [PATCH 1/6] nir/spirv: print id for unsupported builtins

2018-07-12 Thread Karol Herbst
Signed-off-by: Karol Herbst --- src/compiler/spirv/vtn_variables.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index c86416495b6..67b4d59b9fe 100644 --- a/src/compiler/spirv/vtn_variables.c +++

[Mesa-dev] [PATCH 4/6] nir: fix printing of vec16 type

2018-07-12 Thread Karol Herbst
Fixes: 2f181c8c183cc8b4d0450789bb20c2be48d32db3 "glsl_types: vec8/vec16 support" Signed-off-by: Karol Herbst --- src/compiler/nir/nir_print.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index 18860db0058..4fa12d2d207

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEEDINFO

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 --- Comment #6 from ximik --- after installing a stable version of this bug disappeared. mesa 18.1.3-1 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [PATCH v2] intel/batch_decoder: decoding of 3DSTATE_CONSTANT_BODY.

2018-07-12 Thread Sergii Romantsov
SNB doesn't have a definition of 3DSTATE_CONSTANT_BODY, thats why we got segmentation fault when used INTEL_DEBUG=bat. Fixed by adding of 3DSTATE_CONSTANT_BODY into 3DSTATE_CONSTANT of VS, GS and PS structures. v2: added definition of 3DSTATE_CONSTANT_BODY to the gen6.xml Fixes: 169d8e011ae

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #5 from ximik --- After installing a stable driver version, this bug is gone. maybe you help too mesa 18.1.3-1 archlinux -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [PATCH v2] vulkan: Fix compilation on older platforms

2018-07-12 Thread Danylo Piliaiev
Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. Add support for 'protect' attribute to anv_entrypoints_gen. Bugzilla:

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 zefkerri...@gmail.com changed: What|Removed |Added Status|RESOLVED|REOPENED

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #8 from Samuel Pitoiset --- Yeah sorry, I took the decision too quickly... Can you upload the savegame where you recorded the video please? -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 107116] [OpenCL] [llvm-svn] [meson] build failure C++ library 'clangCodeGen' not found

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107116 LoneVVolf changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 1/3] docs/features: Mark some Vulkan extensions as done

2018-07-12 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Jul 12, 2018 at 1:03 AM, Jason Ekstrand wrote: > --- > docs/features.txt | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/docs/features.txt b/docs/features.txt > index 81fe8d0e751..0705ff9974b 100644 > ---

Re: [Mesa-dev] [PATCH 3/3] docs/features: Add the missing KHR extensions

2018-07-12 Thread Bas Nieuwenhuizen
On Thu, Jul 12, 2018 at 1:03 AM, Jason Ekstrand wrote: > --- > docs/features.txt | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/docs/features.txt b/docs/features.txt > index 61ca4d2da65..a70e1d1cc68 100644 > --- a/docs/features.txt > +++ b/docs/features.txt > @@ -381,16 +381,21 @@

Re: [Mesa-dev] [PATCH 9/9] winsys/amdgpu: pass the BO list via the CS ioctl on DRM >= 3.27.0

2018-07-12 Thread Timothy Arceri
On 12/07/18 19:00, Michel Dänzer wrote: On 2018-07-12 07:26 AM, Marek Olšák wrote: From: Marek Olšák TODO: requires latest libdrm for amdgpu_bo_handle_type_kms_noimport --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 6 +++ src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 2 +

[Mesa-dev] [PATCH] virgl: Allow RGB32* textures only as buffer objects

2018-07-12 Thread Gert Wollny
When requesting a texture of the internal format GL_RGB32F Gallium will try to allocate a renderable texture and returns RGBA32F or RGBX32F, but when one requests GL_RGB32I or GL_RGB32UI the according 3-component texture will be returned. This leads to problems later, when one wants to use

[Mesa-dev] [PATCH 5/6] nir: prepare for bumping up max components to 16

2018-07-12 Thread Karol Herbst
OpenCL knows vector of size 8 and 16. Signed-off-by: Karol Herbst --- src/compiler/nir/nir.c| 14 src/compiler/nir/nir.h| 34 ++- src/compiler/nir/nir_builder.h| 18 ++

[Mesa-dev] [PATCH 3/6] nir: add builtin builder

2018-07-12 Thread Karol Herbst
also move some of the GLSL builtins over we will need for implementing some OpenCL builtins Signed-off-by: Karol Herbst --- src/compiler/Makefile.sources | 2 + src/compiler/nir/meson.build | 2 + src/compiler/nir/nir_builtin_builder.c | 67 ++

Re: [Mesa-dev] [PATCH] i965/fs: unspills shoudn't use grf127 as dest since Gen8+

2018-07-12 Thread Chema Casanova
El 12/07/18 a las 03:23, Caio Marcelo de Oliveira Filho escribió: > On Wed, Jul 11, 2018 at 06:03:05PM +0200, Jose Maria Casanova Crespo wrote: >> At 232ed8980217dd65ab0925df28156f565b94b2e5 "i965/fs: Register allocator >> shoudn't use grf127 for sends dest" we didn't take into account the case >>

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: use alloca() when creating the buffer object list

2018-07-12 Thread Bas Nieuwenhuizen
Not really a fan of this one, we can literally have thousands of entries which seems largish when considering the stacks for heavily threaded stuff are often much smaller. On Thu, Jul 12, 2018 at 4:26 PM, Samuel Pitoiset wrote: > Signed-off-by: Samuel Pitoiset > --- >

Re: [Mesa-dev] [PATCH] radeonsi: add support for Vega20

2018-07-12 Thread Alex Deucher
On Wed, Jul 11, 2018 at 4:11 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > include/pci_ids/radeonsi_pci_ids.h | 7 +++ > src/amd/addrlib/amdgpu_asic_addr.h | 2 ++ > src/amd/addrlib/gfx9/gfx9addrlib.cpp| 3 ++- >

Re: [Mesa-dev] [PATCH] gallium: Check pipe_screen::resource_changed before dereferencing it

2018-07-12 Thread Lucas Stach
Am Donnerstag, den 12.07.2018, 16:33 +0200 schrieb Michel Dänzer: > > From: Michel Dänzer > > It's optional, only implemented by the etnaviv driver so far. > > Fixes: 501d0edeca32 "st/mesa: call resource_changed when binding a >  EGLImage to a texture" > Fixes: a37cf630b4d1

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #12 from Samuel Pitoiset --- Bisecting the issue can help. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___ mesa-dev

[Mesa-dev] [PATCH 2/2] radv/winsys: use alloca() when creating the buffer object list

2018-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c index c94c0f339f..e7ad9d7f6b

[Mesa-dev] [PATCH 1/2] radv/winsys: use alloca() for semaphore dependencies

2018-07-12 Thread Samuel Pitoiset
Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c index 5824a29b9e..c94c0f339f 100644 ---

Re: [Mesa-dev] [PATCH 2/3] docs/features: Move the Vulkan 1.1 extensions to the 1.1 section

2018-07-12 Thread Jason Ekstrand
On Thu, Jul 12, 2018 at 2:30 AM Bas Nieuwenhuizen wrote: > On Thu, Jul 12, 2018 at 1:03 AM, Jason Ekstrand > wrote: > > While we're at it, add some extensions we missed along the way like the > > VK_KHR_maintenanceN extensions. > > --- > > docs/features.txt | 39

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #9 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #8) > Yeah sorry, I took the decision too quickly... Can you upload the savegame > where you recorded the video please? I already did this before I created

[Mesa-dev] [PATCH] gallium: Check pipe_screen::resource_changed before dereferencing it

2018-07-12 Thread Michel Dänzer
From: Michel Dänzer It's optional, only implemented by the etnaviv driver so far. Fixes: 501d0edeca32 "st/mesa: call resource_changed when binding a EGLImage to a texture" Fixes: a37cf630b4d1 "gallium: add pipe_screen::resource_changed callback

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #10 from Samuel Pitoiset --- Definitely not enough of caffeine today. Apparently, the issue is SI-specific which means I can't do anything because I don't have the hardware. It works fine on Polaris/Vega. -- You are receiving this

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #11 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #10) > Definitely not enough of caffeine today. Apparently, the issue is > SI-specific which means I can't do anything because I don't have the > hardware.

Re: [Mesa-dev] [PATCH 2/3] docs/features: Move the Vulkan 1.1 extensions to the 1.1 section

2018-07-12 Thread Bas Nieuwenhuizen
On Thu, Jul 12, 2018 at 5:26 PM, Jason Ekstrand wrote: > On Thu, Jul 12, 2018 at 2:30 AM Bas Nieuwenhuizen > wrote: >> >> On Thu, Jul 12, 2018 at 1:03 AM, Jason Ekstrand >> wrote: >> > While we're at it, add some extensions we missed along the way like the >> > VK_KHR_maintenanceN extensions.

Re: [Mesa-dev] [PATCH 1/2] intel/blorp: Add a blorp_filter enum for use in blorp_blit

2018-07-12 Thread Jason Ekstrand
On Wed, Jun 27, 2018 at 5:55 PM Chad Versace wrote: > On Tue 26 Jun 2018, Jason Ekstrand wrote: > > At the moment, this is entirely internal but we'll expose it to clients > > of the BLORP API in the next commit. > > --- > > src/intel/blorp/blorp.h | 8 ++ > >

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #13 from zefkerri...@gmail.com --- (In reply to Samuel Pitoiset from comment #12) > Bisecting the issue can help. And what do we need to do for this? -- You are receiving this mail because: You are the QA Contact for the bug. You

Re: [Mesa-dev] [PATCH 2/2] intel/blorp: Take an explicit filter parameter in blorp_blit

2018-07-12 Thread Jason Ekstrand
On Wed, Jun 27, 2018 at 6:08 PM Chad Versace wrote: > On Tue 26 Jun 2018, Jason Ekstrand wrote: > > This lets us move the glBlitFramebuffer nonsense into the GL driver and > > make the usage of BLORP mutch more explicit and obvious as to what it's > > doing. > > --- > > src/intel/blorp/blorp.h

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

2018-07-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107022 --- Comment #14 from Samuel Pitoiset --- See https://bugs.freedesktop.org/show_bug.cgi?id=107156#c5 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [PATCH] util/rb_tree: Fix a compiler warning

2018-07-12 Thread Caio Marcelo de Oliveira Filho
Reviewed-by: Caio Marcelo de Oliveira Filho On Wed, Jul 11, 2018 at 10:49:49PM -0700, Jason Ekstrand wrote: > Gcc 8 warns "cast to pointer from integer of different size" in 32-bit > builds. > --- > src/util/rb_tree.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/3] egl/android: Delete set_damage_region from egl dri vtbl

2018-07-12 Thread Harish Krupo
Eric Anholt writes: > Harish Krupo writes: > >> Hi Eric, >> >> Eric Anholt writes: >> >>> Harish Krupo writes: >>> The intension of the KHR_partial_update was not to send the damage back to the platform but to send the damage to the driver to ensure that the following

[Mesa-dev] [PATCH 1/3] i965: Make blt_pitch public

2018-07-12 Thread Nanley Chery
We'd like to reuse this helper. Cc: --- src/mesa/drivers/dri/i965/intel_blit.c| 12 ++-- src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 10 ++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c

[Mesa-dev] [PATCH 2/3] i965/miptree: Drop an if case from retile_as_linear

2018-07-12 Thread Nanley Chery
Drop an if statement whose predicate never evaluates to true. row_pitch belongs to a surface with non-linear tiling. According to isl_calc_tiled_min_row_pitch, the pitch is a multiple of the tile width. By looking at isl_tiling_get_info, we see that non-linear tilings have widths greater than or

[Mesa-dev] [PATCH 3/3] i965/miptree: Use the correct BLT pitch

2018-07-12 Thread Nanley Chery
Retile miptrees to a linear tiling less often. Retiling can cause issues with imported BOs. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106738 Suggested-by: Chris Wilson Cc: --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12 ++-- 1 file changed, 6 insertions(+), 6

Re: [Mesa-dev] [PATCH] anv: Restrict the nuber of color regions to those actually written

2018-07-12 Thread Caio Marcelo de Oliveira Filho
> > Question: earlier in the code we call > > > >populate_wm_prog_key(pipeline, info, ); > > > > which does > > > >key->nr_color_regions = pipeline->subpass->color_count; > > > >key->replicate_alpha = key->nr_color_regions > 1 && > > info->pMultisampleState &&

Re: [Mesa-dev] [PATCH] anv: Restrict the nuber of color regions to those actually written

2018-07-12 Thread Caio Marcelo de Oliveira Filho
On Sat, Jul 07, 2018 at 09:35:52AM -0700, Jason Ekstrand wrote: > On Thu, Jul 5, 2018 at 6:34 PM Caio Marcelo de Oliveira Filho < > caio.olive...@intel.com> wrote: > > > On Wed, Jun 27, 2018 at 07:00:56PM -0700, Jason Ekstrand wrote: > > > The back-end compiler emits the number of color writes

Re: [Mesa-dev] [PATCH 1/3] i965: Make blt_pitch public

2018-07-12 Thread Chris Wilson
Quoting Nanley Chery (2018-07-12 18:28:14) > We'd like to reuse this helper. > > Cc: Reviewed-by: Chris Wilson -Chris ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 3/3] i965/miptree: Use the correct BLT pitch

2018-07-12 Thread Chris Wilson
Quoting Nanley Chery (2018-07-12 18:28:16) > Retile miptrees to a linear tiling less often. Retiling can cause issues > with imported BOs. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106738 > Suggested-by: Chris Wilson > Cc: Reviewed-by: Chris Wilson -Chris

Re: [Mesa-dev] [PATCH 2/3] i965/miptree: Drop an if case from retile_as_linear

2018-07-12 Thread Chris Wilson
Quoting Nanley Chery (2018-07-12 18:28:15) > Drop an if statement whose predicate never evaluates to true. row_pitch > belongs to a surface with non-linear tiling. According to > isl_calc_tiled_min_row_pitch, the pitch is a multiple of the tile width. > By looking at isl_tiling_get_info, we see