[Mesa-dev] [PATCH] mesa: avoid _mesa_problem invocation when running on drivers without glsl

2019-07-04 Thread Ilia Mirkin
For example wine might query GL_SHADING_LANGUAGE_VERSION on a driver that doesn't support GLSL. This is not a problem in itself, we can just return a INVALID_ENUM error. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109524 Signed-off-by: Ilia Mirkin --- src/mesa/main/getstring.c | 2 ++

[Mesa-dev] [Bug 110735] Meson can't find 32-bit libXvMCW in non-standard path

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110735 --- Comment #3 from charlie --- I can wait. Setting "-Dc_link_args" in a config file results in: meson: error: unrecognized arguments: .. So I set it in a meson crossfile like: [properties] c_link_args = ['-L /home/a/lib32'] Results in

Re: [Mesa-dev] [PATCH] gallium: remove boolean from state tracker APIs

2019-07-04 Thread Timothy Arceri
Looks good to me. Reviewed-by: Timothy Arceri On 5/7/19 5:36 am, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin --- It's actually a bit tricky to compile all the bits involved, so some of this is untested. However if it so happens that I missed a spot, it should be trivial to fix.

Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-04 Thread Kenneth Graunke
On Thursday, July 4, 2019 5:23:44 AM PDT Boris Brezillon wrote: > Hello, > > Alyssa recently proposed that I push my own panfrost-related > submissions once they received proper review and are considered > ready to merged (meaning that received enough A-b/R-b tags). > > In order to do that, I'd

[Mesa-dev] [PATCH] gallium: remove boolean from state tracker APIs

2019-07-04 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- It's actually a bit tricky to compile all the bits involved, so some of this is untested. However if it so happens that I missed a spot, it should be trivial to fix. src/gallium/include/state_tracker/graw.h | 8 +- src/gallium/include/state_tracker/st_api.h

[Mesa-dev] [PATCH] dma-buf: Update docs to discourage use of dma_buf_mmap()

2019-07-04 Thread Steven Price
dma_buf_mmap() allows a device driver to forward a mmap() call to the dma_buf exporter. However this mechanism provides no way for userspace to use the DMA_BUF_IOCTL_SYNC mechanism to ensure coherency with the mapped buffer. Because of this it is wise to migrate away from providing this mmap()

Re: [Mesa-dev] [PATCH kmscube] Search for a suitable config

2019-07-04 Thread Emil Velikov
On Wed, 3 Jul 2019 at 08:16, Drew DeVault wrote: > > Instead of assuming the first will be suitable. kmscube fails to start > for me without this change. Yes please. Picking the first one is rarely the correct thing to do. Especially when we have platform specific attributes which are exempt

[Mesa-dev] [Bug 110735] Meson can't find 32-bit libXvMCW in non-standard path

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110735 --- Comment #2 from Dylan Baker --- I'm not at my computer right now (its a holiday here), but you might be able to fix this by seeing -Dc_link_args="-L /path/with/xvmc" I'm on mobile, please excuse autocorrect fail. On Thu, Jul 4, 2019,

Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-04 Thread Emil Velikov
On Thu, 4 Jul 2019 at 13:23, Boris Brezillon wrote: > > Hello, > > Alyssa recently proposed that I push my own panfrost-related > submissions once they received proper review and are considered > ready to merged (meaning that received enough A-b/R-b tags). > > In order to do that, I'd need to

[Mesa-dev] [Bug 111051] Mesa crashed on KDE Plasma Wayland session

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111051 --- Comment #2 from Strangiato --- Created attachment 144703 --> https://bugs.freedesktop.org/attachment.cgi?id=144703=edit kwin settings (In reply to Denis from comment #1) > hi Strangiato. Provide please your GPU (or CPU) version, if I

[Mesa-dev] [PATCH] mesa: Set minimum possible GLSL version

2019-07-04 Thread Ian Romanick
From: Ian Romanick Set the absolute minimum possible GLSL version. API_OPENGL_CORE can mean an OpenGL 3.0 forward-compatible context, so that implies a minimum possible version of 1.30. Otherwise, the minimum possible version 1.20. Since Mesa unconditionally advertises

Re: [Mesa-dev] [PATCH] mesa: Set minimum possible GLSL version

2019-07-04 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Fri, Jul 5, 2019 at 12:59 AM Ian Romanick wrote: > > From: Ian Romanick > > Set the absolute minimum possible GLSL version. API_OPENGL_CORE can > mean an OpenGL 3.0 forward-compatible context, so that implies a minimum > possible version of 1.30. Otherwise, the

Re: [Mesa-dev] [PATCH] mesa: avoid _mesa_problem invocation when running on drivers without glsl

2019-07-04 Thread Ilia Mirkin
On Fri, Jul 5, 2019 at 12:56 AM Ian Romanick wrote: > > On 7/4/19 4:21 PM, Ilia Mirkin wrote: > > For example wine might query GL_SHADING_LANGUAGE_VERSION on a driver > > that doesn't support GLSL. This is not a problem in itself, we can just > > return a INVALID_ENUM error. > > > > Bugzilla:

Re: [Mesa-dev] [PATCH] mesa: avoid _mesa_problem invocation when running on drivers without glsl

2019-07-04 Thread Ian Romanick
On 7/4/19 4:21 PM, Ilia Mirkin wrote: > For example wine might query GL_SHADING_LANGUAGE_VERSION on a driver > that doesn't support GLSL. This is not a problem in itself, we can just > return a INVALID_ENUM error. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109524 > Signed-off-by:

Re: [Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-04 Thread Boris Brezillon
On Thu, 04 Jul 2019 20:49:32 -0700 Kenneth Graunke wrote: > On Thursday, July 4, 2019 5:23:44 AM PDT Boris Brezillon wrote: > > Hello, > > > > Alyssa recently proposed that I push my own panfrost-related > > submissions once they received proper review and are considered > > ready to merged

[Mesa-dev] [Bug 106875] The game Anima Gate of Memories has artefects

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106875 --- Comment #3 from Timothy Arceri --- Seems the work around suggested but the games devs is to set the following launch option: -force-opengl Not sure what it does but this worked for me. -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 106875] The game Anima Gate of Memories has artefects

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106875 --- Comment #4 from Timothy Arceri --- According to the Unity manual it force the legacy OpenGL code path. The launch options as documented in the manual: OpenGL core profile command line arguments --

Re: [Mesa-dev] [PATCH] panfrost: Take into account off-screen FBOs

2019-07-04 Thread Erik Faye-Lund
On Thu, 2019-07-04 at 10:02 +0200, Tomeu Vizoso wrote: > In that case, ctx->pipe_framebuffer.cbufs[0] can be NULL. > > Signed-off-by: Tomeu Vizoso > Cc: Boris Brezillon > Fixes: 5375d009be18 ("panfrost: Pass referenced BOs to the SUBMIT > ioctls") Nit: this isn't really about off-screen vs

[Mesa-dev] Getting write permissions on the mesa repo to push panfrost stuff

2019-07-04 Thread Boris Brezillon
Hello, Alyssa recently proposed that I push my own panfrost-related submissions once they received proper review and are considered ready to merged (meaning that received enough A-b/R-b tags). In order to do that, I'd need to obtain write permissions on the git repo. Note that I already have an

[Mesa-dev] [PATCH 2/2] radv: do not crash when generating binning state for unknown chips

2019-07-04 Thread Samuel Pitoiset
These values are only useful if binning is disabled. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 44 +- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index

[Mesa-dev] [PATCH 1/2] radv: fix potential crash in the compute resolve path

2019-07-04 Thread Samuel Pitoiset
If the destination attachment is UNUSED. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_resolve_cs.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/amd/vulkan/radv_meta_resolve_cs.c b/src/amd/vulkan/radv_meta_resolve_cs.c index

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #5 from Lionel Landwerlin --- Running with VK_LOADER_DEBUG=all might help figuring out what's going wrong. -- You are receiving this mail because: You are the assignee for the bug.___

[Mesa-dev] [Bug 110735] Meson can't find 32-bit libXvMCW in non-standard path

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110735 charlie changed: What|Removed |Added CC||baker.dyla...@gmail.com -- You are

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #6 from Shmerl --- I see a strange difference. I placed my built layer in /opt/mesa-master. For vkcube when it works, I run it like this: VK_LOADER_DEBUG=all VK_LAYER_PATH=/opt/mesa-master/share/vulkan/explicit_layer.d

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #7 from Shmerl --- This part looks weird (i.e. vulkan/linux there) DEBUG: ReadDataFilesInSearchPaths: Searching the following paths for manifest files: vulkan/linux -- You are receiving this mail because: You are the assignee for

[Mesa-dev] [Bug 110735] Meson can't find 32-bit libXvMCW in non-standard path

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110735 --- Comment #1 from charlie --- As a temporary work around--link to code from non-standard directory to the 32-bit /usr/lib directory, for example: if [[ $ARCH == *86 ]]; then sudo find ${HOME}/lib32/ -name "libXvMC*" -type f -maxdepth 1 -exec

[Mesa-dev] [PATCH 1/3] panfrost: Cache BO imports

2019-07-04 Thread Tomeu Vizoso
If two jobs use the same GEM object at the same time, the job that finishes first will (previous to this commit) close the GEM object, even if there's a job still referencing it. To prevent this, have all jobs use the same panfrost_bo for a given GEM object, so it's only closed once the last job

[Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-04 Thread Tomeu Vizoso
In preparation for using AFBC for BOs that could be scanned out (though they are likely to be only shared with the compositor for now), use the buffer allocation UABI of the GPU driver, as dumb buffers cannot be allocated for AFBC. Signed-off-by: Tomeu Vizoso ---

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #9 from Shmerl --- The game and layer are both 64-bit. -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #10 from Lionel Landwerlin --- Are you using the %command% trick in steam or some other mean? It looks like something is stripping your VK_LAYER_PATH environment variable. -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #11 from Shmerl --- I'm using GOG version, and actually launch the binary directly with those env variables prefixed for a test (X4 is a binary). I.e. VK_LOADER_DEBUG=all

[Mesa-dev] All-black X windows on glamor with etnaviv

2019-07-04 Thread Jiaxun Yang
Hi folks, We had some reports that glamor is not working correctly with etnaviv mesa driver for long time. Previously Lukas Hartmann wad proposed a patch [1] replacing linear rendering buffer with a tiled buffer and it do works but giving scrambled output. We just dig the issue deeper and

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #12 from Lionel Landwerlin --- (In reply to Shmerl from comment #11) > I'm using GOG version, and actually launch the binary directly with those > env variables prefixed for a test (X4 is a binary). > > I.e. > >

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #13 from Shmerl --- OK, I run it now also to match mesa-master Vulkan driver with the loader. I.e. using not the system ICD, but the one built with mesa-master (though that doesn't change the outcome, but at least reduces potential

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-04 Thread Daniel Vetter
On Thu, Jul 4, 2019 at 11:26 AM Steven Price wrote: > > On 03/07/2019 17:18, Daniel Vetter wrote: > > On Wed, Jul 3, 2019 at 6:11 PM Steven Price wrote: > [...] > >> In theory the exporter should do whatever is required to ensure that the > >> CPU is synchronised when a user space mapping

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #8 from Eero Tamminen --- Have you checked it's not 32-bit vs. 64-bit issue? ("file" command tells you which arch given library/binary is using, and you can see where the game binary / libraries are from /proc/PID/maps file.) --

Re: [Mesa-dev] radeonsi: glmark2 - regression (GL_INVALID_OPERATION in glFramebufferTexture2D) - bisected

2019-07-04 Thread Michel Dänzer
On 2019-07-03 8:49 p.m., Marek Olšák wrote: > NDEBUG is set = release > NDEBUG is not set = debugoptimized > NDEBUG is not set and DEBUG is set = debug > > NDEBUG is not set ---> enable assertions and cheap debug code, NIR enables > expensive validations > DEBUG is set ---> enable possibly very

[Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

2019-07-04 Thread Tomeu Vizoso
Implement query_dmabuf_modifiers and resource_create_with_modifiers so Wayland clients can share AFBC buffers with the compositor. For now this is guarded behind the PAN_MESA_DEBUG=modifiers env var because implementing those callbacks causes Weston to try to pass modifiers to the Rockchip KMS

Re: [Mesa-dev] [PATCH] panfrost: Take into account off-screen FBOs

2019-07-04 Thread Boris Brezillon
On Thu, 4 Jul 2019 10:02:54 +0200 Tomeu Vizoso wrote: > In that case, ctx->pipe_framebuffer.cbufs[0] can be NULL. > > Signed-off-by: Tomeu Vizoso > Cc: Boris Brezillon Reviewed-by: Boris Brezillon > Fixes: 5375d009be18 ("panfrost: Pass referenced BOs to the SUBMIT ioctls") > --- >

Re: [Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

2019-07-04 Thread Tomeu Vizoso
On Thu, 4 Jul 2019 at 10:05, Tomeu Vizoso wrote: > > Implement query_dmabuf_modifiers and resource_create_with_modifiers so > Wayland clients can share AFBC buffers with the compositor. > > For now this is guarded behind the PAN_MESA_DEBUG=modifiers env var > because implementing those callbacks

Re: [Mesa-dev] [PATCH 1/3] panfrost: Cache BO imports

2019-07-04 Thread Boris Brezillon
Hi Tomeu, On Thu, 4 Jul 2019 10:04:41 +0200 Tomeu Vizoso wrote: > If two jobs use the same GEM object at the same time, the job that > finishes first will (previous to this commit) close the GEM object, even > if there's a job still referencing it. > > To prevent this, have all jobs use the

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #16 from Shmerl --- OK, I'll try to strace it to get some details and will also ping developers of the game with this question. -- You are receiving this mail because: You are the assignee for the

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #17 from Shmerl --- Oh, this is something already: strings X4 | grep 'vulkan/linux' VK_LAYER_PATH=vulkan/linux The game is doing something fishy, that's why above you can also see it looking for that weird "vulkan/linux" location.

Re: [Mesa-dev] [PATCH 2/3] panfrost: Allocate scanout BOs in panfrost device

2019-07-04 Thread Boris Brezillon
On Thu, 4 Jul 2019 10:04:42 +0200 Tomeu Vizoso wrote: > @@ -382,11 +362,14 @@ panfrost_resource_create_bo(struct panfrost_screen > *screen, struct panfrost_reso > > /* Tiling textures is almost always faster, unless we only use it > once */ > > +#define SCANOUT (PIPE_BIND_SCANOUT

[Mesa-dev] [PATCH] panfrost: Take into account off-screen FBOs

2019-07-04 Thread Tomeu Vizoso
In that case, ctx->pipe_framebuffer.cbufs[0] can be NULL. Signed-off-by: Tomeu Vizoso Cc: Boris Brezillon Fixes: 5375d009be18 ("panfrost: Pass referenced BOs to the SUBMIT ioctls") --- src/gallium/drivers/panfrost/pan_drm.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #14 from Shmerl --- May be something is statically compiled into it? -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 --- Comment #15 from Lionel Landwerlin --- (In reply to Shmerl from comment #13) > OK, I run it now also to match mesa-master Vulkan driver with the loader. > I.e. using not the system ICD, but the one built with mesa-master (though > that

Re: [Mesa-dev] [RFC PATCH] mesa: Export BOs in RW mode

2019-07-04 Thread Steven Price
On 03/07/2019 17:18, Daniel Vetter wrote: > On Wed, Jul 3, 2019 at 6:11 PM Steven Price wrote: [...] >> In theory the exporter should do whatever is required to ensure that the >> CPU is synchronised when a user space mapping exists. There are some >> issues here though: >> >> * In theory the

Re: [Mesa-dev] All-black X windows on glamor with etnaviv

2019-07-04 Thread Michel Dänzer
On 2019-07-04 5:28 a.m., Jiaxun Yang wrote: > Hi folks, > > We had some reports that glamor is not working correctly with etnaviv > mesa driver for long time. Previously Lukas Hartmann wad proposed a > patch [1] replacing linear rendering buffer with a tiled buffer and it > do works but giving

[Mesa-dev] [Bug 111054] Vulkan overlay doesn't work with X4: Foundations

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111054 Lionel Landwerlin changed: What|Removed |Added Resolution|--- |NOTOURBUG Status|NEW

Re: [Mesa-dev] [PATCH 2/2] radv: do not crash when generating binning state for unknown chips

2019-07-04 Thread Bas Nieuwenhuizen
r-b On Thu, Jul 4, 2019 at 8:51 AM Samuel Pitoiset wrote: > > These values are only useful if binning is disabled. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 44 +- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff

[Mesa-dev] [Bug 111051] Mesa crashed on KDE Plasma Wayland session

2019-07-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111051 Denis changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Denis --- hi

Re: [Mesa-dev] [PATCH 1/2] radv: fix potential crash in the compute resolve path

2019-07-04 Thread Bas Nieuwenhuizen
r-b On Thu, Jul 4, 2019 at 8:51 AM Samuel Pitoiset wrote: > > If the destination attachment is UNUSED. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_meta_resolve_cs.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

2019-07-04 Thread Daniel Stone
Hi Tomeu, On Thu, 4 Jul 2019 at 09:05, Tomeu Vizoso wrote: > @@ -362,14 +392,19 @@ panfrost_resource_create_bo(struct panfrost_screen > *screen, struct panfrost_reso > > /* Tiling textures is almost always faster, unless we only use it > once */ > > +bool can_afbc =

Re: [Mesa-dev] [PATCH 3/3] panfrost: Add support for modifiers

2019-07-04 Thread Daniel Stone
Hi, On Thu, 4 Jul 2019 at 09:47, Tomeu Vizoso wrote: > On Thu, 4 Jul 2019 at 10:05, Tomeu Vizoso wrote: > > -pres->layout = should_tile ? PAN_TILED : PAN_LINEAR; > > + if (want_afbc || (is_renderable && can_afbc && !is_texture)) > > +pres->layout = PAN_AFBC; > > We