[Mesa-dev] [Bug 42128] Crash when visiting a site with Firefox

2011-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42128 --- Comment #4 from Brian Paul bri...@vmware.com 2011-10-26 07:23:43 PDT --- Posting the output of 'glxinfo' would be a good start. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail

[Mesa-dev] [PATCH 2/3] mesa: improve EXT_transform_feedback display list support

2011-10-26 Thread Marek Olšák
--- src/mesa/main/dlist.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index d901bdd..52548fd 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -69,6 +69,9 @@ #if

[Mesa-dev] [PATCH 3/3] mesa: initialize ARB_transform_feedback2 dispatch

2011-10-26 Thread Marek Olšák
--- src/mesa/main/api_exec.c |1 + src/mesa/main/transformfeedback.c | 10 +- 2 files changed, 10 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index 93214dd..1bc39db 100644 --- a/src/mesa/main/api_exec.c +++

Re: [Mesa-dev] [PATCH] ralloc: Add new [v]asprintf_rewrite_tail functions.

2011-10-26 Thread Eugeni Dodonov
On Tue, Oct 25, 2011 at 00:33, Kenneth Graunke kenn...@whitecape.orgwrote: This can be useful if you want to create a bunch of temporary strings with a common prefix. For example, when iterating over uniform structure fields, one might want to create temporary strings like pallete.primary,

Re: [Mesa-dev] [PATCH 14/33] i965/gen4: Fold WM surface state prepare()/emit() together.

2011-10-26 Thread Paul Berry
On 24 October 2011 14:17, Eric Anholt e...@anholt.net wrote: These produce BRW_NEW_SURFACES (used by binding table emit()) and BRW_NEW_NR_WM_SURFACES (used by WM unit emit()). Fixes a bug where with no texturing and no color buffer, we wouldn't consider the null renderbuffer in nr_surfaces.

[Mesa-dev] mis-counting varying vars in the linker

2011-10-26 Thread Brian Paul
I think the linker is mis-counting gl_TexCoord[] varying vars when linking. For example, if we have this vertex/fragment shader combination: // vs void main() { gl_Position = ftransform(); gl_TexCoord[6] = gl_MultiTexCoord[0]; } // fs void main() { gl_Color = gl_TexCoord[6]; }

Re: [Mesa-dev] [PATCH 1/3] mesa: fix GL error checking in TransformFeedbackVaryings

2011-10-26 Thread Kenneth Graunke
On 10/26/2011 09:00 AM, Marek Olšák wrote: --- src/mesa/main/transformfeedback.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index 47efad1..86fff88 100644 ---

Re: [Mesa-dev] [PATCH 1/3] mesa: fix GL error checking in TransformFeedbackVaryings

2011-10-26 Thread Eric Anholt
On Wed, 26 Oct 2011 18:00:12 +0200, Marek Olšák mar...@gmail.com wrote: --- src/mesa/main/transformfeedback.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) This series is Reviewed-by: Eric Anholt e...@anholt.net pgpsTCAYY8KKE.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH 14/33] i965/gen4: Fold WM surface state prepare()/emit() together.

2011-10-26 Thread Eric Anholt
On Wed, 26 Oct 2011 10:11:15 -0700, Paul Berry stereotype...@gmail.com wrote: Non-text part: multipart/alternative On 24 October 2011 14:17, Eric Anholt e...@anholt.net wrote: These produce BRW_NEW_SURFACES (used by binding table emit()) and BRW_NEW_NR_WM_SURFACES (used by WM unit emit()).

Re: [Mesa-dev] [PATCH v2 1/8] mesa: Expose GLSL interpolation qualifiers in gl_fragment_program.

2011-10-26 Thread Kenneth Graunke
On 10/25/2011 08:38 PM, Paul Berry wrote: This patch makes GLSL interpolation qualifiers visible to drivers via the array InterpQualifier[] in gl_fragment_program, so that they can easily be used by driver back-ends to select the correct interpolation mode. Previous to this patch, the GLSL

Re: [Mesa-dev] [PATCH 14/33] i965/gen4: Fold WM surface state prepare()/emit() together.

2011-10-26 Thread Paul Berry
On 26 October 2011 11:45, Eric Anholt e...@anholt.net wrote: On Wed, 26 Oct 2011 10:11:15 -0700, Paul Berry stereotype...@gmail.com wrote: Non-text part: multipart/alternative On 24 October 2011 14:17, Eric Anholt e...@anholt.net wrote: These produce BRW_NEW_SURFACES (used by binding

Re: [Mesa-dev] [PATCH v2 2/8] glsl: Distinguish between no interpolation qualifier and 'smooth'

2011-10-26 Thread Kenneth Graunke
On 10/25/2011 08:38 PM, Paul Berry wrote: Previously, we treated the 'smooth' qualifier as equivalent to no qualifier at all. However, this is incorrect for the built-in color variables (gl_FrontColor, gl_BackColor, gl_FrontSecondaryColor, and gl_BackSecondaryColor). For those variables, if

Re: [Mesa-dev] [PATCH v2 8/8] i965/gen6+: Add support for noperspective interpolation.

2011-10-26 Thread Eric Anholt
On Tue, 25 Oct 2011 20:38:26 -0700, Paul Berry stereotype...@gmail.com wrote: This required the following changes: - WM setup now makes the appropriate set of barycentric coordinates (perspective vs. noperspective) available to the fragment shader, based on whether the shader requires

Re: [Mesa-dev] [PATCH 1/5] mesa: Skip texstore for 0-sized texture data.

2011-10-26 Thread Eric Anholt
On Tue, 25 Oct 2011 16:29:53 -0600, Brian Paul bri...@vmware.com wrote: On 10/25/2011 03:58 PM, Eric Anholt wrote: The intel driver (and gallium, it looks like, though it doesn't use these texstore functions at this point) doesn't bother making storage for textures with 0 width, height, or

Re: [Mesa-dev] [PATCH 2/4 v2] mesa/image: assert on bad format

2011-10-26 Thread Eric Anholt
On Wed, 19 Oct 2011 19:45:15 -0600, Brian Paul brian.e.p...@gmail.com wrote: On Wed, Oct 19, 2011 at 6:10 PM, nobled nob...@dreamwidth.org wrote: NULL as an error indicator is meaningless, since it will return NULL on success anyway if the caller passes in zero as the image's address and

[Mesa-dev] [PATCH] glsl: Implement GLSL 1.30's literal integer range restrictions.

2011-10-26 Thread Eric Anholt
From page 22 (28 of PDF) of GLSL 1.30 spec: It is an error to provide a literal integer whose magnitude is too large to store in a variable of matching signed or unsigned type. Unsigned integers have exactly 32 bits of precision. Signed integers use 32 bits, including a sign bit,

[Mesa-dev] [PATCH 1/2] glsl: Generate an error for array-of-array declarations

2011-10-26 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Other parts of the code already caught things like 'float x[4][2]'. However, nothing caught 'float [4] x[2]'. Fixes piglit test array-multidimensional-new-syntax.vert. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/ast_to_hir.cpp |

[Mesa-dev] [PATCH 2/2] glsl: Clean-up spurious error message on bad structure definitions

2011-10-26 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously a shader like int X; struct X { int i; }; void main() { gl_Position = vec4(0.0); } would generate two error message: 0:2(19): error: struct `X' previously defined 0:2(20): error: incomplete declaration The first one is the real error,

Re: [Mesa-dev] [PATCH v2 8/8] i965/gen6+: Add support for noperspective interpolation.

2011-10-26 Thread Paul Berry
On 26 October 2011 12:17, Eric Anholt e...@anholt.net wrote: On Tue, 25 Oct 2011 20:38:26 -0700, Paul Berry stereotype...@gmail.com wrote: This required the following changes: - WM setup now makes the appropriate set of barycentric coordinates (perspective vs. noperspective) available

[Mesa-dev] [PATCH] glsl: translate transform feedback varyings into low-level representation

2011-10-26 Thread Marek Olšák
This adds a function that takes an array of varyings from glTranformFeedbackVaryingsEXT and generates gl_transform_feedback_info, which is supposed to be consumed by drivers. Useful for ir_to_mesa and glsl_to_tgsi. With Dan McCabe's patch, I think this is all that's needed for transform feedback

Re: [Mesa-dev] [PATCH] glsl: translate transform feedback varyings into low-level representation

2011-10-26 Thread Brian Paul
On 10/26/2011 04:28 PM, Marek Olšák wrote: This adds a function that takes an array of varyings from glTranformFeedbackVaryingsEXT and generates gl_transform_feedback_info, which is supposed to be consumed by drivers. Useful for ir_to_mesa and glsl_to_tgsi. With Dan McCabe's patch, I think this

[Mesa-dev] [PATCH 2/5] u_format: Fix bitshifting for unpacking from 10F.

2011-10-26 Thread Eric Anholt
This code was copy and pasted from the 11F unpacking, but not updated for actually being 10 bits instead of 11. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=41206 --- src/gallium/auxiliary/util/u_format_r11g11b10f.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 1/5] u_format: Fix bit definition of UF10_MANTISSA_BITS.

2011-10-26 Thread Eric Anholt
This is only used in the code for packing to INF, and resulted in an extra bit set that was set anyway, so it was harmless except for the confusion caused. --- src/gallium/auxiliary/util/u_format_r11g11b10f.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] u_format: Fix clamping of overflow in 10F_11F_11F_REV to match GL specs.

2011-10-26 Thread Eric Anholt
Fixes the 100.0 overflow cases of piglit GL_EXT_packed_float/pack.c --- src/gallium/auxiliary/util/u_format_r11g11b10f.h | 22 ++ 1 files changed, 18 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_r11g11b10f.h

[Mesa-dev] [PATCH 5/5] u_format: Fix -NaN handling for packing of 10F_11F_11F_REV to match GL specs.

2011-10-26 Thread Eric Anholt
Fixes the remainder of piglit GL_EXT_packed_float/pack.c --- src/gallium/auxiliary/util/u_format_r11g11b10f.h | 42 -- 1 files changed, 31 insertions(+), 11 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_r11g11b10f.h

[Mesa-dev] [PATCH 3/5] mesa: Don't do [0, 1] clamping on glGetTexImage() of packed float formats.

2011-10-26 Thread Eric Anholt
From the GL_EXT_packed_float spec: For an RGBA color, if type is not one of FLOAT, UNSIGNED_INT_5_9_9_9_REV_EXT, or UNSIGNED_INT_10F_11F_11F_REV_EXT, or if the CLAMP_READ_COLOR_ARB is TRUE, or CLAMP_READ_COLOR_ARB is FIXED_ONLY_ARB and the selected color (or texture) buffer is

[Mesa-dev] [PATCH] ext_packed_float/pack: New test for GL's conversion of float to packed float.

2011-10-26 Thread Eric Anholt
--- tests/all.tests|1 + tests/spec/CMakeLists.txt |1 + tests/spec/ext_packed_float/pack.c | 263 3 files changed, 265 insertions(+), 0 deletions(-) create mode 100644 tests/spec/ext_packed_float/pack.c diff --git

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-26 Thread Eric Anholt
On Fri, 21 Oct 2011 09:04:58 -0400, Alex Deucher alexdeuc...@gmail.com wrote: 2011/10/20 Eric Anholt e...@anholt.net: On Thu, 20 Oct 2011 10:35:31 +0200, Michel Dänzer mic...@daenzer.net wrote: On Mit, 2011-10-19 at 17:50 -0700, Eric Anholt wrote: So, Radeon maintainers, what do you

Re: [Mesa-dev] [PATCH 1/5] u_format: Fix bit definition of UF10_MANTISSA_BITS.

2011-10-26 Thread Marek Olšák
This series is: Reviewed-by: Marek Olšák mar...@gmail.com Thanks. Marek On Thu, Oct 27, 2011 at 1:46 AM, Eric Anholt e...@anholt.net wrote: This is only used in the code for packing to INF, and resulted in an extra bit set that was set anyway, so it was harmless except for the confusion

[Mesa-dev] [PATCH 01/15] mesa: add new fields for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/main/mtypes.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index d02bc16..b4b1df5 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -1334,6 +1334,7 @@

[Mesa-dev] [PATCH 02/15] mesa: add new driver hook for AllocTextureStorage()

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/main/dd.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 8607008..86a547d 100644 --- a/src/mesa/main/dd.h +++ b/src/mesa/main/dd.h @@ -514,6 +514,15 @@ struct

[Mesa-dev] [PATCH 03/15] glapi: new API specs for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mapi/glapi/gen/ARB_texture_storage.xml | 67 src/mapi/glapi/gen/Makefile|1 + src/mapi/glapi/gen/gl_API.xml |2 + 3 files changed, 70 insertions(+), 0 deletions(-) create mode 100644

[Mesa-dev] [PATCH 05/15] mesa: implement new functions for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com This is the glTexStorage1D/2D/3D() functions. Basically do error checking then call the driver hook to actually allocate memory. --- src/mesa/main/texstorage.c | 387 src/mesa/main/texstorage.h | 61 +++ 2

[Mesa-dev] [PATCH 06/15] mesa: glGetTexParameter support for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/main/texparam.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texparam.c b/src/mesa/main/texparam.c index dc5ee33..a242448 100644 --- a/src/mesa/main/texparam.c +++ b/src/mesa/main/texparam.c @@

[Mesa-dev] [PATCH 07/15] mesa: new glTexImage error checks for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com If the texture memory was allocated with glTexStorage1/2/3D() we can only change the image data with glTexSubImage calls. --- src/mesa/main/teximage.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git

[Mesa-dev] [PATCH 08/15] mesa: display list dispatch for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/main/dlist.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index d901bdd..4660fd6 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -61,6 +61,7 @@

[Mesa-dev] [PATCH 09/15] mesa: init extension entry for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/main/extensions.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 52b928e..14f6f1f 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@

[Mesa-dev] [PATCH 10/15] mesa: compile new texstore.c file

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/SConscript |1 + src/mesa/sources.mak |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/SConscript b/src/mesa/SConscript index 45414bc..7688ce9 100644 --- a/src/mesa/SConscript +++ b/src/mesa/SConscript @@

[Mesa-dev] [PATCH 11/15] mesa: plug in dispatch functions for GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/main/api_exec.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index 93214dd..f7e8b5c 100644 --- a/src/mesa/main/api_exec.c +++ b/src/mesa/main/api_exec.c @@

[Mesa-dev] [PATCH 12/15] st/mesa: implement GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/state_tracker/st_cb_texture.c | 62 src/mesa/state_tracker/st_extensions.c |1 + 2 files changed, 63 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c

[Mesa-dev] [PATCH 13/15] swrast: implement GL_ARB_texture_storage

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/drivers/common/driverfuncs.c |3 +++ src/mesa/main/extensions.c|1 + src/mesa/swrast/s_texture.c | 32 src/mesa/swrast/swrast.h |7 +++ 4 files changed, 43

[Mesa-dev] [PATCH 14/15] mesa: add note about immutable textures for _mesa_test_texobj_completeness()

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- src/mesa/main/texobj.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 4d9942b..a8c0b8e 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -406,6 +406,10 @@

[Mesa-dev] [PATCH 15/15] docs: list GL_ARB_texture_storage in 7.12 release notes

2011-10-26 Thread Brian Paul
From: Brian Paul bri...@vmware.com --- docs/relnotes-7.12.html |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/relnotes-7.12.html b/docs/relnotes-7.12.html index 4077dac..815f1e0 100644 --- a/docs/relnotes-7.12.html +++ b/docs/relnotes-7.12.html @@ -39,6 +39,7 @@

[Mesa-dev] [PATCH 0/15] GL_ARB_texture storage

2011-10-26 Thread Brian Paul
This series implements the GL_ARB_texture storage extension. It's supported for the gallium state tracker and swrast. It should be pretty simple for the intel driver. I'm omitting the patch with the auto-generated API changes. A new piglit test for this has been posted to the piglit list

[Mesa-dev] [PATCH 1/5] glsl: Fix copy-paste error in constant_expression_value(ir_binop_nequal)

2011-10-26 Thread Paul Berry
The implementation of ir_binop_nequal in constant_expression_value() appears to have been copy-and-pasted from the implementation of ir_binop_equal, but with all instances of '==' changed to '!='. This is correct except for one minor flaw: one of those '==' operators was in an assertion checking

[Mesa-dev] [PATCH 2/5] glsl: Extend s-expression parsing to handle infinity.

2011-10-26 Thread Paul Berry
In order to implement the GLSL 1.30 isinf() function, it will be necessary to be able to represent infinity in the GLSL IR s-expression format. This patch extends the s-expression parser so that it treats the string #inf as a floating point value representing positive infinity. ---

[Mesa-dev] [PATCH 4/5] glsl: Add isinf() and isnan() builtins.

2011-10-26 Thread Paul Berry
The implementations are as follows: isinf(x) = (abs(x) == +infinity) isnan(x) = (x != x) Note: the latter formula is not necessarily obvious. It works because NaN is the only floating point number that does not equal itself. Fixes piglit tests isinf-and-isnan fs_basic and isinf-and-isnan

[Mesa-dev] [PATCH 5/5] i965/gen6+: Switch GLSL from ALT to IEEE floating point mode

2011-10-26 Thread Paul Berry
i965 graphics hardware has two floating point modes: ALT and IEEE. In ALT mode, floating-point operations never generate infinities or NaNs, and MOV instructions translate infinities and NaNs to finite values. In IEEE mode, infinities and NaNs behave as specified in the IEEE 754 spec.

[Mesa-dev] [PATCH 3/5] glsl: Add '.ir' extension to builtin IR files

2011-10-26 Thread Paul Berry
This patch adds the extension '.ir' to all the files in src/glsl/builtins/ir/, and changes generate_builtins.py so that it no longer globs on '*' to find the files to build. This prevents spurious files (such as EMACS' infamous *~ backup files) from breaking the build. ---

Re: [Mesa-dev] [PATCH] state_trackers/vdpau: Implement VdpGenerateCSCMatrix partially

2011-10-26 Thread Christian König
On 25.10.2011 20:57, Maarten Lankhorst wrote: On 10/25/2011 08:00 PM, Younes Manton wrote: On Tue, Oct 25, 2011 at 1:35 PM, Maarten Lankhorst m.b.lankho...@gmail.com wrote: Is there a reason not to use/add to the code in vl_csc.c in this case? It supports 601 and 709, wider gamut, and

[Mesa-dev] [Bug 42128] Crash when visiting a site with Firefox

2011-10-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=42128 --- Comment #3 from Thor t01...@yahoo.com 2011-10-26 03:12:54 UTC --- @ Kenneth Graunke Hmm, this is not really critical, but, perhaps the site in question uses features (stuff) that makes Firefox trip, somehow. What do I enter where so you can

Re: [Mesa-dev] [PATCH v2 1/8] mesa: Expose GLSL interpolation qualifiers in gl_fragment_program.

2011-10-26 Thread Brian Paul
On 10/25/2011 09:38 PM, Paul Berry wrote: This patch makes GLSL interpolation qualifiers visible to drivers via the array InterpQualifier[] in gl_fragment_program, so that they can easily be used by driver back-ends to select the correct interpolation mode. Previous to this patch, the GLSL