[Mesa-dev] [PATCH] Add mismatch check for glGetTexImage or it will return -1 and may lead to segment fault.

2011-12-12 Thread jian . j . zhao
From: Jian Zhao --- src/mesa/main/texgetimage.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index ae0d51f..3f24187 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimage.c @@ -708,6 +7

Re: [Mesa-dev] [PATCH 01/13] st/mesa: stop using _DepthBuffer, _StencilBuffer fields

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 11:58:27 -0700, Brian Paul wrote: > We never want to use the depth/stencil buffer wrappers so always just > use the attachment renderbuffers. This is a step toward removing the > _DepthBuffer, _StencilBuffer fields. Looks good. This series is Reviewed-by: Eric Anholt pgp

[Mesa-dev] [PATCH] gallivm: Fix build with llvm-3.1svn.

2011-12-12 Thread Vinson Lee
llvm-3.1svn r145714 moved global variables into a new TargetOptions class. TargetMachine constructor now needs a TargetOptions object as well. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_debug.cpp | 14 +- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp |2

Re: [Mesa-dev] [PATCH] mesa: add const flags to skip MaxVarying and MaxUniform linker checks (v2)

2011-12-12 Thread Kenneth Graunke
On 12/11/2011 11:07 PM, Marek Olšák wrote: > This is only temporary until a better solution is available. > > v2: print warnings and add gallium CAPs Thanks, Marek---this looks good to me. Reviewed-by: Kenneth Graunke ___ mesa-dev mailing list mesa-d

Re: [Mesa-dev] [PATCH] mesa: add const flags to skip MaxVarying and MaxUniform linker checks (v2)

2011-12-12 Thread Ian Romanick
On 12/11/2011 11:07 PM, Marek Olšák wrote: This is only temporary until a better solution is available. v2: print warnings and add gallium CAPs Reviewed-by: Ian Romanick --- src/gallium/drivers/r300/r300_screen.c |2 + src/gallium/include/pipe/p_defines.h |4 ++- src/glsl/link

Re: [Mesa-dev] [PATCH 3/3] mesa: remove gl_renderbufer::PutMonoRow() and PutMonoValues()

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 12:00:54 -0700, Brian Paul wrote: > The former was only used for clearing buffers. The later wasn't used > anywhere! Remove them and all implementations of those functions. Reviewed-by: Eric Anholt pgpeKarsJcUw7.pgp Description: PGP signature _

Re: [Mesa-dev] R600g LLVM shader backend

2011-12-12 Thread Tom Stellard
On Mon, 2011-12-12 at 07:05 -0800, Jose Fonseca wrote: > - Original Message - > > Hi, > > > > I have just pushed a branch containing an LLVM shader backend for > > r600g to my > > personal git repo: > > > > http://cgit.freedesktop.org/~tstellar/mesa/ r600g-llvm-shader > > Hi Tom, > > Th

Re: [Mesa-dev] [PATCH 2/3] swrast: rewrite color buffer clearing to use Map/UnmapRenderbuffer()

2011-12-12 Thread Brian Paul
On Mon, Dec 12, 2011 at 10:38 AM, Eric Anholt wrote: > On Sat, 10 Dec 2011 12:00:53 -0700, Brian Paul wrote: >> -   /* Note that masking will change the color values, but only the >> -    * channels for which the write mask is GL_FALSE.  The channels >> -    * which which are write-enabled won't

Re: [Mesa-dev] [PATCH 1/3] swrast: do depth/stencil clearing with Map/UnmapRenderbuffer()

2011-12-12 Thread Brian Paul
On Mon, Dec 12, 2011 at 10:28 AM, Eric Anholt wrote: > On Sat, 10 Dec 2011 12:00:52 -0700, Brian Paul wrote: >> Another step toward getting rid of the renderbuffer PutRow/etc functions. > >> +   if (buffers & BUFFER_DS) { >> +      struct gl_renderbuffer *rb = >> +         ctx->DrawBuffer->Attach

Re: [Mesa-dev] shaders for g3dvl compositor (was vdpau: Handle destination rectangles correctly)

2011-12-12 Thread Andy Furniss
Christian König wrote: @Andy: Could you please confirm that they are also working? (They should apply ontop of current master). Yes - they are working OK for me. One thing I noticed while messing with mplayer subs/OSD is that vdpau in full screen positions them relative to the screen rather

Re: [Mesa-dev] [PATCH 1/3] swrast: do depth/stencil clearing with Map/UnmapRenderbuffer()

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 12:00:52 -0700, Brian Paul wrote: > Another step toward getting rid of the renderbuffer PutRow/etc functions. > + if (buffers & BUFFER_DS) { > + struct gl_renderbuffer *rb = > + ctx->DrawBuffer->Attachment[BUFFER_DEPTH].Renderbuffer; > + > + if ((buffers &

Re: [Mesa-dev] [PATCH 2/3] swrast: rewrite color buffer clearing to use Map/UnmapRenderbuffer()

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 12:00:53 -0700, Brian Paul wrote: > - /* Note that masking will change the color values, but only the > -* channels for which the write mask is GL_FALSE. The channels > -* which which are write-enabled won't get modified. > -*/ > - for (i = 0; i < height; i++)

Re: [Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 12:00:27 -0700, Brian Paul wrote: > This fixes two things: > 1. If the texture object was created with glTexStorage2D, the call >to _mesa_TexImage2D() would generate INVALID_OPERATION since the >texture is marked as immutable. > 2. _mesa_TexImage2D() always frees any ex

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: make sure copied instructions don't lose texture target.

2011-12-12 Thread Brian Paul
On Sat, Dec 10, 2011 at 2:47 PM, Dave Airlie wrote: >>> >>> The piglit draw-pixel-with-texture was asserting in the glsl->tgsi code, >>> due to 0 texture target, this makes sure the texture target is copied over >>> correctly when we copy instructions around. >> >> Oh so it looks like this could b

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: make sure copied instructions don't lose texture target.

2011-12-12 Thread Brian Paul
On Sat, Dec 10, 2011 at 11:34 AM, Dave Airlie wrote: > From: Dave Airlie > > The piglit draw-pixel-with-texture was asserting in the glsl->tgsi code, > due to 0 texture target, this makes sure the texture target is copied over > correctly when we copy instructions around. > > Signed-off-by: Dave

Re: [Mesa-dev] [PATCH 01/11] mesa: implement DrawTransformFeedback from ARB_transform_feedback2

2011-12-12 Thread Jose Fonseca
- Original Message - > On 12/12/2011 02:49 PM, Jose Fonseca wrote: > > - Original Message - > >> From: Marek Olšák > >> > >> It's like DrawArrays, but the count is taken from a transform > >> feedback > >> object. > >> > >> This removes DrawTransformFeedback from dd_function_table

Re: [Mesa-dev] [PATCH] meta: rework dest image allocation in mipmap generation code

2011-12-12 Thread Eric Anholt
On Sat, 10 Dec 2011 12:00:27 -0700, Brian Paul wrote: > This fixes two things: > 1. If the texture object was created with glTexStorage2D, the call >to _mesa_TexImage2D() would generate INVALID_OPERATION since the >texture is marked as immutable. > 2. _mesa_TexImage2D() always frees any ex

Re: [Mesa-dev] shaders for g3dvl compositor (was vdpau: Handle destination rectangles correctly)

2011-12-12 Thread Christian König
Hi Maarten, On 12.12.2011 13:25, Maarten Lankhorst wrote: The problem is destination rectangle can be different for video and subpictures, this breaks mplayer OSD if you handle it incorrectly. ftp://download.nvidia.com/XFree86/vdpau/doxygen/html/group___vdp_video_mixer.html#ga62bf3bf8c5f01322a0

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-12-12 Thread Jose Fonseca
- Original Message - > On Mon, Dec 12, 2011 at 8:20 AM, Jose Fonseca > wrote: > > - Original Message - > >> On Mon, Dec 12, 2011 at 2:10 PM, Jose Fonseca > >> > >> wrote: > >> > > >> > > >> > - Original Message - > >> >> On Mon, Dec 12, 2011 at 1:24 PM, Jose Fonseca > >>

Re: [Mesa-dev] [PATCH 01/11] mesa: implement DrawTransformFeedback from ARB_transform_feedback2

2011-12-12 Thread Christoph Bumiller
On 12/12/2011 02:49 PM, Jose Fonseca wrote: > - Original Message - >> From: Marek Olšák >> >> It's like DrawArrays, but the count is taken from a transform >> feedback >> object. >> >> This removes DrawTransformFeedback from dd_function_table and adds >> the same >> function to GLvertexfor

Re: [Mesa-dev] R600g LLVM shader backend

2011-12-12 Thread Tom Stellard
On Sat, 2011-12-10 at 03:16 -0800, Stéphane Marchesin wrote: > On Fri, Dec 9, 2011 at 14:15, Tom Stellard wrote: > > Hi, > > > > I have just pushed a branch containing an LLVM shader backend for r600g to > > my > > personal git repo: > > > > http://cgit.freedesktop.org/~tstellar/mesa/ r600g-llvm-

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-12-12 Thread Brian Paul
On Mon, Dec 12, 2011 at 8:20 AM, Jose Fonseca wrote: > - Original Message - >> On Mon, Dec 12, 2011 at 2:10 PM, Jose Fonseca >> wrote: >> > >> > >> > - Original Message - >> >> On Mon, Dec 12, 2011 at 1:24 PM, Jose Fonseca >> >> >> >> wrote: >> >> > I saw this email yesterday, bu

Re: [Mesa-dev] [PATCH] mesa: fix an out-of-bounds access in prog_print.c

2011-12-12 Thread Brian Paul
On Sun, Dec 11, 2011 at 10:30 PM, Marek Olšák wrote: > --- >  src/mesa/program/prog_print.c |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/program/prog_print.c b/src/mesa/program/prog_print.c > index e9bf3aa..b4d142f 100644 > --- a/src/mesa/program/prog_prin

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-12-12 Thread Jose Fonseca
- Original Message - > On Mon, Dec 12, 2011 at 2:10 PM, Jose Fonseca > wrote: > > > > > > - Original Message - > >> On Mon, Dec 12, 2011 at 1:24 PM, Jose Fonseca > >> > >> wrote: > >> > I saw this email yesterday, but did not have time to reply. > >> > > >> > - Original Messag

Re: [Mesa-dev] [PATCH 13/15] gallivm: Move tgsi_soa helper macros to header file

2011-12-12 Thread Jose Fonseca
- Original Message - > --- > src/gallium/auxiliary/gallivm/lp_bld_tgsi.h | 12 > src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 14 > -- > 2 files changed, 12 insertions(+), 14 deletions(-) > > diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.h

Re: [Mesa-dev] R600g LLVM shader backend

2011-12-12 Thread Jose Fonseca
- Original Message - > Hi, > > I have just pushed a branch containing an LLVM shader backend for > r600g to my > personal git repo: > > http://cgit.freedesktop.org/~tstellar/mesa/ r600g-llvm-shader Hi Tom, This is pretty cool stuff. The fact that you have a similar passing rate to the

Re: [Mesa-dev] [PATCH 01/11] mesa: implement DrawTransformFeedback from ARB_transform_feedback2

2011-12-12 Thread Jose Fonseca
- Original Message - > From: Marek Olšák > > It's like DrawArrays, but the count is taken from a transform > feedback > object. > > This removes DrawTransformFeedback from dd_function_table and adds > the same > function to GLvertexformat (with the function parameters matching > GL). >

Re: [Mesa-dev] [PATCH 03/11] gallium: interface changes necessary to implement transform feedback (v5)

2011-12-12 Thread Jose Fonseca
- Original Message - > From: Marek Olšák > > Namely: > - EXT_transform_feedback > - ARB_transform_feedback2 > - ARB_transform_feedback_instanced > > The old interface was not useful for OpenGL and had to be reworked. > > This interface was originally designed for OpenGL, but additional

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-12-12 Thread Marek Olšák
On Mon, Dec 12, 2011 at 2:10 PM, Jose Fonseca wrote: > > > - Original Message - >> On Mon, Dec 12, 2011 at 1:24 PM, Jose Fonseca >> wrote: >> > I saw this email yesterday, but did not have time to reply. >> > >> > - Original Message - >> >> On Mon, Nov 21, 2011 at 6:52 PM, Eric An

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-12-12 Thread Jose Fonseca
- Original Message - > On Mon, Dec 12, 2011 at 1:24 PM, Jose Fonseca > wrote: > > I saw this email yesterday, but did not have time to reply. > > > > - Original Message - > >> On Mon, Nov 21, 2011 at 6:52 PM, Eric Anholt > >> wrote: > >> > On Sun, 20 Nov 2011 15:08:55 +0100, Mar

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-12-12 Thread Marek Olšák
On Mon, Dec 12, 2011 at 1:24 PM, Jose Fonseca wrote: > I saw this email yesterday, but did not have time to reply. > > - Original Message - >> On Mon, Nov 21, 2011 at 6:52 PM, Eric Anholt wrote: >> > On Sun, 20 Nov 2011 15:08:55 +0100, Marek Olšák >> > wrote: >> >> unpack_float_z_Z24_X8

Re: [Mesa-dev] [PATCH 1/2] mesa: remove buggy assertions in unpack Z24

2011-12-12 Thread Jose Fonseca
I saw this email yesterday, but did not have time to reply. - Original Message - > On Mon, Nov 21, 2011 at 6:52 PM, Eric Anholt wrote: > > On Sun, 20 Nov 2011 15:08:55 +0100, Marek Olšák > > wrote: > >> unpack_float_z_Z24_X8 fails with -O2 in: > >> - fbo-blit-d24s8 > >> - fbo-depth-sampl

Re: [Mesa-dev] [PATCH 2/2] vdpau: Handle destination rectangles correctly

2011-12-12 Thread Christian König
On 11.12.2011 07:13, Younes Manton wrote: On Tue, Dec 6, 2011 at 4:51 PM, Andy Furniss wrote: Maarten Lankhorst wrote: The brokenness in vlVdpVideoMixerRender was compensating for brokenness in vlVdpPresentationQueueDisplay, so fix both at the same time. These fix the two remaining issues (a