[Mesa-dev] [PATCH] scons: Add instrumentation component libraries to linking on llvm-3.2.

2012-07-21 Thread Vinson Lee
llvm-3.2svn r160587 moved createBoundsCheckingPass from lib/Transforms/Scalar to lib/Transforms/Instrumentation. Signed-off-by: Vinson Lee v...@freedesktop.org --- scons/llvm.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scons/llvm.py b/scons/llvm.py index f87766a..2fb82f0 100644 ---

[Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-21 Thread Dave Airlie
Hi guys LLVM 2.8 doesn't appear to have mcjit, so we end up with no llvm libs defined, look at the recent build failures in tinderbox.x.org. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] scons: Add instrumentation component libraries to linking on llvm-3.2.

2012-07-21 Thread Jose Fonseca
Sounds good. Thanks Vinson. Jose - Original Message - llvm-3.2svn r160587 moved createBoundsCheckingPass from lib/Transforms/Scalar to lib/Transforms/Instrumentation. Signed-off-by: Vinson Lee v...@freedesktop.org --- scons/llvm.py | 3 +++ 1 file changed, 3 insertions(+)

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-21 Thread Jose Fonseca
- Original Message - Hi guys LLVM 2.8 doesn't appear to have mcjit, so we end up with no llvm libs defined, Yes, mcjit is only used/necessary from llvm-3.1 onwards, so the autoconf code should check conditiionally. BTW, I'll soon commit a change that will stop using mcjit from 3.2

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-21 Thread Dave Airlie
Yes, mcjit is only used/necessary from llvm-3.1 onwards, so the autoconf code should check conditiionally. BTW, I'll soon commit a change that will stop using mcjit from 3.2 onwards (as with the current LLVM 3.2 trunk, AVX is supported by the old jit, which is more stable/polished).

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-21 Thread Jose Fonseca
The attached patch should fix, but I don't have a machine with old llvm now. Jose - Original Message - - Original Message - Hi guys LLVM 2.8 doesn't appear to have mcjit, so we end up with no llvm libs defined, Yes, mcjit is only used/necessary from llvm-3.1

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-21 Thread Jose Fonseca
- Original Message - Yes, mcjit is only used/necessary from llvm-3.1 onwards, so the autoconf code should check conditiionally. BTW, I'll soon commit a change that will stop using mcjit from 3.2 onwards (as with the current LLVM 3.2 trunk, AVX is supported by the old jit, which

Re: [Mesa-dev] 761131ce4591e5f55f38d13f2c4d2194bc9cb0fd build regression with llvm 2.8

2012-07-21 Thread Jose Fonseca
I went ahead and pushed it. Hopefully it should fix it. Jose - Original Message - The attached patch should fix, but I don't have a machine with old llvm now. Jose - Original Message - - Original Message - Hi guys LLVM 2.8 doesn't appear to have mcjit,

Re: [Mesa-dev] [PATCH 2/2] glxgears: Add support for multisample visuals

2012-07-21 Thread Brian Paul
On Fri, Jul 20, 2012 at 6:29 PM, Chad Versace chad.vers...@linux.intel.com wrote: Add a command line parameter, `-sample N`, which selects a visual with at least N samples. For the series, Reviewed-by: Brian Paul bri...@vmware.com ___ mesa-dev mailing

[Mesa-dev] [PATCH] mesa: fix format checking when doing a multisample resolve

2012-07-21 Thread Marek Olšák
Check the internal format instead of gl_format. Sometimes a driver may allocate two textures of formats e.g. RGBA and ARGB from internalformat GL_RGBA8, and doing a resolve between those 2 GL_RGBA8 formats results in a GL error. Technically speaking, a user getting the error has done

[Mesa-dev] [PATCH] imports.h: Correct ceilf typo.

2012-07-21 Thread Matt Turner
--- src/mesa/main/imports.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index 0fc8f55..73913b5 100644 --- a/src/mesa/main/imports.h +++ b/src/mesa/main/imports.h @@ -119,7 +119,7 @@ typedef union { GLfloat f; GLint i;

Re: [Mesa-dev] [PATCH] imports.h: Correct ceilf typo.

2012-07-21 Thread Brian Paul
On Sat, Jul 21, 2012 at 10:07 AM, Matt Turner matts...@gmail.com wrote: --- src/mesa/main/imports.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/imports.h b/src/mesa/main/imports.h index 0fc8f55..73913b5 100644 --- a/src/mesa/main/imports.h +++

[Mesa-dev] [Bug 52346] New: libxcb version not specified (correctly) in dependency check

2012-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52346 Bug #: 52346 Summary: libxcb version not specified (correctly) in dependency check Classification: Unclassified Product: Mesa Version: git Platform: Other

[Mesa-dev] [Bug 48338] Building OpenGL ES 1 and 2 with make -j fails with fresh repo

2012-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=48338 Alexandre Demers alexandre.f.dem...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 52347] New: mklib: Error: no object files specified for d3d1x state tracker

2012-07-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52347 Bug #: 52347 Summary: mklib: Error: no object files specified for d3d1x state tracker Classification: Unclassified Product: Mesa Version: git Platform: Other

[Mesa-dev] [PATCH] mesa: fix format checking when doing a multisample resolve

2012-07-21 Thread Marek Olšák
v2: make it more bullet-proof --- src/mesa/main/fbobject.c | 112 +- 1 file changed, 111 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 4370c72..ca43f81 100644 --- a/src/mesa/main/fbobject.c +++

Re: [Mesa-dev] [PATCH] automake: add ARCH_FLAGS, OPT_FLAGS, PIC_FLAGS into AM_CFLAGS and AM_CXXFLAGS

2012-07-21 Thread Eric Anholt
Marek Olšák mar...@gmail.com writes: This fixes a build system regression after Makefile conversions to automake. I need only OPT_FLAGS to set -fno-omit-frame-pointer. ARCH_FLAGS is for --enable-32-bit. I am not sure what PIC_FLAGS is good for, but r600g uses it. VISIBILITY_CFLAGS might

Re: [Mesa-dev] [PATCH] automake: add ARCH_FLAGS, OPT_FLAGS, PIC_FLAGS into AM_CFLAGS and AM_CXXFLAGS

2012-07-21 Thread Marek Olšák
On Sat, Jul 21, 2012 at 9:40 PM, Eric Anholt e...@anholt.net wrote: Marek Olšák mar...@gmail.com writes: This fixes a build system regression after Makefile conversions to automake. I need only OPT_FLAGS to set -fno-omit-frame-pointer. ARCH_FLAGS is for --enable-32-bit. I am not sure what

[Mesa-dev] [PATCH] st/mesa: set the correct window renderbuffer internal format

2012-07-21 Thread Marek Olšák
The multisample-resolve blit relies on this being correct. --- src/mesa/state_tracker/st_cb_fbo.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index e1818ab..7eef5c6 100644 ---

[Mesa-dev] [PATCH 00/15] i965: Enable window system multisampling

2012-07-21 Thread Chad Versace
No Piglit regressions on Ivybridge. Tested with `glxgears -samples 1`. Passes 53/70 of oglconform's winsys multisample tests. The failing tests mostly consist of those that call glDrawPixels on the depth and stencil buffer (which fail due to a swrast fallback) or do fancy things with the msaa

[Mesa-dev] [PATCH 01/15] intel: Remove dead code in intelAllocateBuffer

2012-07-21 Thread Chad Versace
After commit intel: Convert to using private depth/stencil buffers, we request from DRI2GetBuffersWithFormat only the front left and back left buffers. We no longer request depth and stencil buffers. Assert that in intelAllocateBuffer and remove the related dead code. CC: Eric Anholt

[Mesa-dev] [PATCH 02/15] intel: Decrease nesting level in intelCreateBuffer

2012-07-21 Thread Chad Versace
Nearly the whole function body was contained in the 'else' branch. The 'if' branch did one thing: return early with an error. Clean things up by moving all the code out of the 'else' branch. Decreases max nesting level from 4 to 3. CC: Eric Anholt e...@anholt.net Signed-off-by: Chad Versace

[Mesa-dev] [PATCH 03/15] intel: Use consistent pattern in intelCreateBuffer

2012-07-21 Thread Chad Versace
The 16-bit depth case did not follow the function's prevalent pattern. CC: Eric Anholt e...@anholt.net Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/intel/intel_screen.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 04/15] intel: Refactor quantize_num_samples

2012-07-21 Thread Chad Versace
Rename quantize_num_samples to intel_quantize_num_samples and change the first param from struct intel_context* to struct intel_screen*. The function will later be used by intelCreateBuffer, which is not bound to any context but is bound to a screen. Since the function now depends on the screen,

[Mesa-dev] [PATCH 05/15] intel: Set num samples for winsys renderbuffers

2012-07-21 Thread Chad Versace
Add a new param, num_samples, to intel_create_renderbuffer and intel_create_private_renderbuffer. The caller, intelCreateBuffer, passes in the value of gl_config::NumSamples. No multisample GL config is yet advertised, so the value of num_samples is currently 0. For server-owned winsys buffers,

[Mesa-dev] [PATCH 06/15] intel: Add intel_mipmap_tree::singlesample_mt

2012-07-21 Thread Chad Versace
This miptree will be used only for storing the singlesample data of multisample window system buffers. CC: Eric Anholt e...@anholt.net CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c | 1 +

[Mesa-dev] [PATCH 07/15] intel: Refactor creation of hiz and mcs miptrees

2012-07-21 Thread Chad Versace
Move the logic for creating the ancillary hiz and mcs miptress for winsys and non-texture renderbuffers from intel_alloc_renderbuffer_storage to intel_miptree_create_for_renderbuffer. Let's try to isolate complex miptree logic to intel_mipmap_tree.c. Without this refactor, code duplication would

[Mesa-dev] [PATCH 08/15] intel: Allocate miptree for multisample DRI2 buffers

2012-07-21 Thread Chad Versace
Immediately after obtaining, with DRI2GetBuffersWithFormat, the DRM buffer handle for a DRI2 buffer, we wrap that DRM buffer handle with a region and a miptre. This patch additionally allocates an accompanying multisample miptree if the DRI2 buffer is multisampled. Since we do not yet advertise

[Mesa-dev] [PATCH 09/15] i965: Add function intel_miptree_downsample

2012-07-21 Thread Chad Versace
This function does a downsample from mt to mt-singlesample_mt. Conceptually, this function belongs in intel_mipmap_tree.c. However, it needs to interact with blorp, which is C++. So I created a new file, brw_blorp_orphands.cpp, for this and other functions that fall into the same category. CC:

[Mesa-dev] [PATCH 10/15] i965: Mark winsys MSAA color buffer as needing resolve postdraw

2012-07-21 Thread Chad Versace
Do this immediately after drawing is complete and at the same time that we mark the depth buffer as needing a depth resolve. CC: Eric Anholt e...@anholt.net CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/i965/brw_draw.c |

[Mesa-dev] [PATCH 11/15] intel: Downsample during glReadPixels

2012-07-21 Thread Chad Versace
Actually, this patch forces an automatic downsample during intel_miptree_map. And this should occur only due to glReadPixels. CC: Eric Anholt e...@anholt.net CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com ---

[Mesa-dev] [PATCH 12/15] intel: Downsample on DRI2 flush

2012-07-21 Thread Chad Versace
CC: Eric Anholt e...@anholt.net CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/intel/intel_screen.c | 31 +++ 1 file changed, 31 insertions(+) diff --git

[Mesa-dev] [PATCH 13/15] intel: Refactor creation of DRI2 configs

2012-07-21 Thread Chad Versace
DRI2 configs were constructed in intelInitScreen2. That function already does too much, so move verbatim the code for creating configs to a new function, intel_screen_make_configs. CC: Eric Anholt e...@anholt.net CC: Paul Berry stereotype...@gmail.com Signed-off-by: Chad Versace

[Mesa-dev] [PATCH 14/15] intel: Refactor intel_screen_make_configs

2012-07-21 Thread Chad Versace
Transform the code from clever, obfuscated, and imperative to straight-forward and table-driven. CC: Ian Romanick i...@freedesktop.org Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- src/mesa/drivers/dri/intel/intel_screen.c | 167 +- 1 file changed, 97

Re: [Mesa-dev] [PATCH 01/15] intel: Remove dead code in intelAllocateBuffer

2012-07-21 Thread Chris Wilson
On Sat, 21 Jul 2012 17:36:40 -0700, Chad Versace chad.vers...@linux.intel.com wrote: After commit intel: Convert to using private depth/stencil buffers, we request from DRI2GetBuffersWithFormat only the front left and back left buffers. We no longer request depth and stencil buffers. Assert

[Mesa-dev] [PATCH] st/mesa: flush the glBitmap cache before changing framebuffer state

2012-07-21 Thread Marek Olšák
This fixes the piglit EXT_framebuffer_multisample/bitmap tests. Note that we must not rely on ctx-DrawBuffer when flushing the cache, because that's already updated with a new framebuffer. We want to draw into the old framebuffer where glBitmap was called. ---