Re: [Mesa-dev] [PATCH 11/14] R600/SI: add OMOD patterns

2013-02-21 Thread Michel Dänzer
On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 833e6cd..7c157e9 100644 --- a/lib/Target/R600/SIInstructions.td +++ b/lib/Target/R600/SIInstructions.td @@ -1232,6 +1232,24 @@ def : Pat

Re: [Mesa-dev] [PATCH 09/14] R600/SI: add all the other missing asm operands

2013-02-21 Thread Michel Dänzer
On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 700b8f8..866c7cb 100644 --- a/lib/Target/R600/SIInstructions.td +++ b/lib/Target/R600/SIInstructions.td @@ -620,7 +620,7 @@ def

Re: [Mesa-dev] [PATCH 11/14] R600/SI: add OMOD patterns

2013-02-21 Thread Christian König
Am 21.02.2013 09:26, schrieb Michel Dänzer: On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 833e6cd..7c157e9 100644 --- a/lib/Target/R600/SIInstructions.td +++

Re: [Mesa-dev] [PATCH 11/14] R600/SI: add OMOD patterns

2013-02-21 Thread Michel Dänzer
On Don, 2013-02-21 at 09:44 +0100, Christian König wrote: Am 21.02.2013 09:26, schrieb Michel Dänzer: On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 833e6cd..7c157e9 100644 ---

[Mesa-dev] [Bug 61200] insufficient linking of libxatracker.so

2013-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61200 --- Comment #1 from Andreas Boll andreas.boll@gmail.com --- Created attachment 75240 -- https://bugs.freedesktop.org/attachment.cgi?id=75240action=edit possible fix Does this patch help? -- You are receiving this mail because: You are

Re: [Mesa-dev] [PATCH] r600g: don't enable ReZ mode on evergreen

2013-02-21 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Wed, Feb 20, 2013 at 10:20 PM, alexdeuc...@gmail.com wrote: From: Alex Deucher alexander.deuc...@amd.com Can cause lockups in certain cases when zfunc/zenable/zwrite change without a flush in between. Fixes:

Re: [Mesa-dev] [PATCH] r600g: Fix memory leak in r600_shader_select.

2013-02-21 Thread Marek Olšák
Reviewed-by: Marek Olšák mar...@gmail.com Marek On Thu, Feb 21, 2013 at 8:43 AM, Vinson Lee v...@freedesktop.org wrote: Signed-off-by: Vinson Lee v...@freedesktop.org Reported-by: Michel Dänzer mic...@daenzer.net --- src/gallium/drivers/r600/r600_state_common.c | 1 + 1 file changed, 1

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-21 Thread Michel Dänzer
On Mit, 2013-02-20 at 17:56 +0100, Michel Dänzer wrote: On Don, 2013-02-14 at 11:32 +0100, Christian König wrote: Am 13.02.2013 18:22, schrieb Michel Dänzer: On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: Am 13.02.2013 18:11, schrieb Michel Dänzer: On Mit, 2013-02-13 at

Re: [Mesa-dev] [PATCH 09/14] R600/SI: add all the other missing asm operands

2013-02-21 Thread Christian König
Am 21.02.2013 09:39, schrieb Michel Dänzer: On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 700b8f8..866c7cb 100644 --- a/lib/Target/R600/SIInstructions.td +++ b/lib/Target/R600/SIInstructions.td

Re: [Mesa-dev] [PATCH 09/14] R600/SI: add all the other missing asm operands

2013-02-21 Thread Michel Dänzer
On Don, 2013-02-21 at 10:38 +0100, Christian König wrote: Am 21.02.2013 09:39, schrieb Michel Dänzer: On Mit, 2013-02-20 at 18:46 +0100, Christian König wrote: diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 700b8f8..866c7cb 100644 ---

Re: [Mesa-dev] [PATCH] draw: make sure key size is calculated consistently.

2013-02-21 Thread Jose Fonseca
Looks perfect. Thanks Roland. Jose - Original Message - From: Roland Scheidegger srol...@vmware.com Some parts calculated key size by using shader information, others by using the pipe_vertex_element information. Since it is perfectly valid to have more vertex_elements set than

Re: [Mesa-dev] [PATCH] clover: Fix build with LLVM 3.3

2013-02-21 Thread Francisco Jerez
Tom Stellard t...@stellard.net writes: From: Tom Stellard thomas.stell...@amd.com Acked-by: Francisco Jerez curroje...@riseup.net --- .../state_trackers/clover/llvm/invocation.cpp | 47 --- 1 files changed, 39 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [Bug 61200] insufficient linking of libxatracker.so

2013-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61200 --- Comment #2 from Rafał Mużyło galtge...@o2.pl --- (In reply to comment #1) Created attachment 75240 [details] [review] possible fix Does this patch help? Well, it should help - that's exactly the solution I've proposed. On the other

Re: [Mesa-dev] [PATCH 1/8] R600/SI: cleanup SIInstrInfo.td and SIInstrFormat.td

2013-02-21 Thread Tom Stellard
With the changes Michel suggested, this series is: Reviewed-by: Tom Stellard thomas.stell...@amd.com Are any of these candidates for the stable branch? -Tom On Tue, Feb 19, 2013 at 02:54:23PM +0100, Christian König wrote: From: Christian König christian.koe...@amd.com Those two files got

Re: [Mesa-dev] [PATCH 1/8] R600/SI: cleanup SIInstrInfo.td and SIInstrFormat.td

2013-02-21 Thread Tom Stellard
On Thu, Feb 21, 2013 at 09:06:36AM -0500, Tom Stellard wrote: With the changes Michel suggested, this series is: Reviewed-by: Tom Stellard thomas.stell...@amd.com Are any of these candidates for the stable branch? Please ignore this, I overlooked v2 of this series. I will review the new

Re: [Mesa-dev] [PATCH 14/14] R600/SI: inline V_ADD|SUB_F32 patterns

2013-02-21 Thread Tom Stellard
On Wed, Feb 20, 2013 at 06:47:00PM +0100, Christian König wrote: From: Christian König christian.koe...@amd.com Signed-off-by: Christian König christian.koe...@amd.com --- lib/Target/R600/SIInstructions.td | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 01/14] R600/SI: cleanup SIInstrInfo.td and SIInstrFormat.td

2013-02-21 Thread Tom Stellard
For the series: Reviewed-by: Tom Stellard thomas.stell...@amd.com On Wed, Feb 20, 2013 at 06:46:47PM +0100, Christian König wrote: From: Christian König christian.koe...@amd.com Those two files got mixed up. Signed-off-by: Christian König christian.koe...@amd.com ---

Re: [Mesa-dev] [PATCH] clover: Fix build with LLVM 3.3

2013-02-21 Thread Aaron Watry
Hi Tom, Mesa+Clover does indeed build against master llvm/clang, but I'm having trouble building against it when I try to do a clean build of Piglit. Error received: [ 18%] Built target piglitutil_cl Linking C executable ../../../../../bin/cl-custom-run-simple-kernel

Re: [Mesa-dev] [PATCH] clover: Fix build with LLVM 3.3

2013-02-21 Thread Tom Stellard
On Thu, Feb 21, 2013 at 08:25:20AM -0600, Aaron Watry wrote: Hi Tom, Mesa+Clover does indeed build against master llvm/clang, but I'm having trouble building against it when I try to do a clean build of Piglit. Error received: [ 18%] Built target piglitutil_cl Linking C executable

Re: [Mesa-dev] [PATCH 1/2] i965: Disable point coords when not rendering points.

2013-02-21 Thread Paul Berry
On 16 February 2013 15:16, Paul Berry stereotype...@gmail.com wrote: On 16 February 2013 13:52, Kenneth Graunke kenn...@whitecape.org wrote: On 02/16/2013 07:29 AM, Paul Berry wrote: From the Ivy Bridge PRM, p268 (3DSTATE_SBE), in the description of Point Sprite Texture Coordinate Enable:

Re: [Mesa-dev] [PATCH 4/6] R600: Fix for Unigine when MachineSched is enabled

2013-02-21 Thread Tom Stellard
On Mon, Feb 18, 2013 at 05:27:28PM +0100, Vincent Lejeune wrote: --- This fixes the for-loop.cl piglit test, so I've pushed this patch and backported it to the stable branch. -Tom lib/Target/R600/R600Instructions.td | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH 1/4] st/mesa: fix polygon offset state translation bug

2013-02-21 Thread Brian Paul
The conditionals were testing the wrong state. Just get rid of the conditionals since they really don't buy us anything. Note: This is a candidate for the stable branches. --- src/mesa/state_tracker/st_atom_rasterizer.c | 17 + 1 files changed, 5 insertions(+), 12 deletions(-)

[Mesa-dev] [PATCH 2/4] draw: fix broken polygon offset stage

2013-02-21 Thread Brian Paul
There were several issues. We weren't handling different front/back polygon fill modes. We weren't checking whether the offset applied to fill mode vs. line mode vs. point mode. Fixes problems found with the Visualization Toolkit (VTK) test suite. Note: This is a candidate for the stable

[Mesa-dev] [PATCH 3/4] llvmpipe: add missing checks for polygon offset point/line modes

2013-02-21 Thread Brian Paul
The llvm pipeline handles regular filled triangle offsets, but it doesn't handle offsets for triangles drawn in point or line mode. Fixes failures found with new piglit polygon-mode-offset test. Note: This is a candidate for the stable branches. ---

[Mesa-dev] [PATCH 4/4] llvmpipe: rename polygon offset fields to something more specific

2013-02-21 Thread Brian Paul
--- src/gallium/drivers/llvmpipe/lp_state_setup.c | 15 +-- src/gallium/drivers/llvmpipe/lp_state_setup.h |4 ++-- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_state_setup.c b/src/gallium/drivers/llvmpipe/lp_state_setup.c index

[Mesa-dev] Performance difference between driver egl_glx and egl_gallium

2013-02-21 Thread Yannick Meyer
Hi all, I am currently wondering why I have a big difference in performance between 2 Mesa drivers: egl_glx and egl_gallium. I have already posted a mesasge 2 weeks ago on the mesa user list, but I did not receive any answer. Please find below my previous mail I am currently working on an ARM

Re: [Mesa-dev] [PATCH] clover: Fix build with LLVM 3.3

2013-02-21 Thread Aaron Watry
On Thu, Feb 21, 2013 at 8:33 AM, Tom Stellard t...@stellard.net wrote: On Thu, Feb 21, 2013 at 08:25:20AM -0600, Aaron Watry wrote: Hi Tom, Mesa+Clover does indeed build against master llvm/clang, but I'm having trouble building against it when I try to do a clean build of Piglit.

Re: [Mesa-dev] [PATCH] clover: Fix build with LLVM 3.3

2013-02-21 Thread Tom Stellard
On Thu, Feb 21, 2013 at 10:02:34AM -0600, Aaron Watry wrote: On Thu, Feb 21, 2013 at 8:33 AM, Tom Stellard t...@stellard.net wrote: On Thu, Feb 21, 2013 at 08:25:20AM -0600, Aaron Watry wrote: Hi Tom, Mesa+Clover does indeed build against master llvm/clang, but I'm having trouble

[Mesa-dev] Mesa 9.0.3 release

2013-02-21 Thread Andreas Boll
Mesa 9.0.3 has been released. Mesa 9.0.3 is a bug fix release which fixes bugs found since the 9.0.2 release. The tag in the GIT repository for Mesa 9.0.3 is 'mesa-9.0.3'. Mesa 9.0.3 is available for download at ftp://freedesktop.org/pub/mesa/9.0.3/ md5sums: 168384ac0101f4600a15edd3561acdc7

[Mesa-dev] [PATCH 1/2] gallium/docs: improve text about resources a bit.

2013-02-21 Thread sroland
From: Roland Scheidegger srol...@vmware.com This clarifies some things and gets rid of some old stuff. The most significant one is probably that buffers cannot have formats (nearly all drivers completely ignored format and used width0 as byte size already in any case). There seems to be no use

[Mesa-dev] [PATCH 2/2] llvmpipe: simplify buffer allocation logic.

2013-02-21 Thread sroland
From: Roland Scheidegger srol...@vmware.com Now with buffer formats clarification don't need all that logic any longer. (Note that it never would have worked in any case, because blockwidth and blockheight were swapped any allocation with multi-byte format would have had zero size.) ---

[Mesa-dev] [PATCH] targets/xa-vmwgfx: Force c++ linker to fix undefined symbols

2013-02-21 Thread Andreas Boll
NOTE: This is a candidate for the 9.1 branch. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61200 --- src/gallium/targets/xa-vmwgfx/Makefile.am |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/targets/xa-vmwgfx/Makefile.am b/src/gallium/targets/xa-vmwgfx/Makefile.am

Re: [Mesa-dev] [PATCH] i965/gen[45]: Do point coord logic whenever gl_PointCoord is asked for.

2013-02-21 Thread Eric Anholt
Ian Romanick i...@freedesktop.org writes: On 02/15/2013 10:46 PM, Eric Anholt wrote: The desktop spec asks for gl_PointCoord to be defined only when GL_POINT_SPRITE is enabled, and it's undefined otherwise (why?!). The ES spec doesn't have GL_POINT_SPRITE and gl_PointCoord is always

Re: [Mesa-dev] [PATCH] targets/xa-vmwgfx: Force c++ linker to fix undefined symbols

2013-02-21 Thread Matt Turner
On Thu, Feb 21, 2013 at 8:41 AM, Andreas Boll andreas.boll@gmail.com wrote: NOTE: This is a candidate for the 9.1 branch. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=61200 --- src/gallium/targets/xa-vmwgfx/Makefile.am |2 ++ 1 file changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 1/2] gallium/docs: improve text about resources a bit.

2013-02-21 Thread Jose Fonseca
- Original Message - From: Roland Scheidegger srol...@vmware.com This clarifies some things and gets rid of some old stuff. The most significant one is probably that buffers cannot have formats (nearly all drivers completely ignored format and used width0 as byte size already in any

[Mesa-dev] [PATCH] gallium/build: Fix visibility CFLAGS in automake

2013-02-21 Thread Andreas Boll
From: Maarten Lankhorst m.b.lankho...@gmail.com v2: Andreas Boll andreas.boll@gmail.com - Fix formatting - use one CFLAG per line NOTE: This is a candidate for the 9.1 branch. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59238 Reviewed-by: Andreas Boll

Re: [Mesa-dev] [PATCH] clover: Fix build with LLVM 3.3

2013-02-21 Thread Aaron Watry
On Thu, Feb 21, 2013 at 10:06 AM, Tom Stellard t...@stellard.net wrote: On Thu, Feb 21, 2013 at 10:02:34AM -0600, Aaron Watry wrote: On Thu, Feb 21, 2013 at 8:33 AM, Tom Stellard t...@stellard.net wrote: On Thu, Feb 21, 2013 at 08:25:20AM -0600, Aaron Watry wrote: Hi Tom,

[Mesa-dev] [Bug 61052] [llvmpipe] mesa/src/gallium/auxiliary/util/u_dl.c:48: undefined reference to `dlopen'

2013-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61052 --- Comment #2 from Andreas Boll andreas.boll@gmail.com --- Created attachment 75266 -- https://bugs.freedesktop.org/attachment.cgi?id=75266action=edit possible fix Does this patch help? -- You are receiving this mail because: You are

Re: [Mesa-dev] [RFC] New EGL extension: EGL_EXT_platform_display

2013-02-21 Thread Chad Versace
On 02/20/2013 05:44 PM, Eric Anholt wrote: Chad Versace chad.vers...@linux.intel.com writes: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm seeking feedback on an EGL extension that I'm drafting. The ideas have already been discussed at Khronos meetings to a good reception, but I want

Re: [Mesa-dev] [PATCH 4/4] llvmpipe: rename polygon offset fields to something more specific

2013-02-21 Thread Jose Fonseca
Series is Reviewed-by: Jose Fonseca jfons...@vmware.com - Original Message - --- src/gallium/drivers/llvmpipe/lp_state_setup.c | 15 +-- src/gallium/drivers/llvmpipe/lp_state_setup.h |4 ++-- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git

[Mesa-dev] [PATCH] llvmpipe: Fix rendering into PIPE_FORMAT_X8B8G8R8_UNORM.

2013-02-21 Thread jfonseca
From: José Fonseca jose.r.fons...@gmail.com Weird format, which Mesa state tracker recently started using. Fixes segfault in ./bin/texture-packed-formats -auto because swizzle[foo] was 0xff for padding channel (X). It still fails though. I believe the only reason this doesn't BGRX doesn't

[Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-02-21 Thread Vadim Girlin
v4: implement exact computation taking into account wavefront size Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/r600_asm.c| 44 +-- src/gallium/drivers/r600/r600_asm.h| 24 -- src/gallium/drivers/r600/r600_shader.c | 131

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-02-21 Thread Alex Deucher
On Thu, Feb 21, 2013 at 6:52 PM, Vadim Girlin vadimgir...@gmail.com wrote: v4: implement exact computation taking into account wavefront size Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/r600_asm.c| 44 +-- src/gallium/drivers/r600/r600_asm.h

Re: [Mesa-dev] [PATCH] r600g: don't reserve more stack space than required v4

2013-02-21 Thread Vadim Girlin
On 02/22/2013 04:23 AM, Alex Deucher wrote: On Thu, Feb 21, 2013 at 6:52 PM, Vadim Girlin vadimgir...@gmail.com wrote: v4: implement exact computation taking into account wavefront size Signed-off-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/r600_asm.c| 44

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-21 Thread Vadim Girlin
On 02/19/2013 08:39 PM, Andy Furniss wrote: Vadim Girlin wrote: Could you please test glxgears and other simple mesa demos? It's easier to spot the problems with small apps that don't use a lot of complex shaders. If some of them don't work correctly, please send me the dumps with

[Mesa-dev] [Bug 61199] mapi/glapi/glprocs.h:2573:5: error: ‘glDiscardFramebufferEXT’ undeclared here (not in a function)

2013-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61199 --- Comment #4 from Vinson Lee v...@freedesktop.org --- Comment on attachment 75234 -- https://bugs.freedesktop.org/attachment.cgi?id=75234 fix without typos included Review of attachment 75234:

[Mesa-dev] [Bug 61052] [llvmpipe] mesa/src/gallium/auxiliary/util/u_dl.c:48: undefined reference to `dlopen'

2013-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=61052 --- Comment #3 from Vinson Lee v...@freedesktop.org --- Comment on attachment 75266 -- https://bugs.freedesktop.org/attachment.cgi?id=75266 possible fix Review of attachment 75266:

[Mesa-dev] [Bug 46376] render error when run glsl demo or mesa demo with X

2013-02-21 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=46376 --- Comment #4 from ye.tian yex.t...@intel.com --- The issue still exists with the follow commits: - Kernel_version: 3.8 Libdrm: 2.4.42 Mesa: (9.1)9.1-rc2 Xserver:

[Mesa-dev] [PATCH] st/xvmc/tests: Ensure colorkey is initialized.

2013-02-21 Thread Vinson Lee
Fixes uninitialized scalar variable defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/state_trackers/xvmc/tests/xvmc_bench.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/xvmc/tests/xvmc_bench.c

[Mesa-dev] [PATCH 2/2] st/vdpau: Fix memory leak in vlVdpBitmapSurfaceCreate.

2013-02-21 Thread Vinson Lee
Fixes resource leak defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/state_trackers/vdpau/bitmap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/vdpau/bitmap.c b/src/gallium/state_trackers/vdpau/bitmap.c index

[Mesa-dev] [PATCH 1/2] st/vdpau: Fix memory leak in vlVdpOutputSurfaceCreate.

2013-02-21 Thread Vinson Lee
Fixes resource leak defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/state_trackers/vdpau/output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/vdpau/output.c b/src/gallium/state_trackers/vdpau/output.c index