On 30 July 2013 15:16, Kenneth Graunke wrote:
> On 07/28/2013 11:03 PM, Paul Berry wrote:
>
>> + /* The 'varying in' and 'varying out' qualifiers can only be used
>> with
>> + * ARB_geometry_shader4 and EXT_geometry_shader4, which we don't
>> support
>> + * yet.
>> + */
>>
On 07/30/2013 07:30 PM, Paul Berry wrote:
On 29 July 2013 11:17, Kenneth Graunke mailto:kenn...@whitecape.org>> wrote:
On 07/28/2013 11:03 PM, Paul Berry wrote:
+/**
+ * Checks if the context supports geometry shaders.
+ */
+static inline GLboolean
+_
> From: Roland Scheidegger
>
> llvm shifts are undefined for shift counts exceeding (or matching) bit width,
> so need to apply a mask for the tgsi shift instructions.
>
> v2: only use mask for the tgsi shift instructions, not for the build shift
> helpers. None of the internal callers need this
On 30 July 2013 15:41, Kenneth Graunke wrote:
> On 07/28/2013 11:03 PM, Paul Berry wrote:
>
>> From: Fabian Bieler
>>
>> Reviewed-by: Paul Berry
>> ---
>> src/mesa/main/api_validate.c | 68 ++**
>> ++
>> 1 file changed, 68 insertions(+)
>>
>> diff --gi
On 30 July 2013 11:13, Kenneth Graunke wrote:
> On 07/28/2013 11:03 PM, Paul Berry wrote:
>
>> From: Bryan Cain
>>
>> v2 (Paul Berry ): Account for rework of
>> builtin_variables.cpp. Use INTERP_QUALIFIER_FLAT for gl_PrimitiveID
>> so that it will obey provoking vertex conventions. Convert to
On Tue, Jul 30, 2013 at 8:46 PM, Paul Berry wrote:
> On 29 July 2013 11:09, Zack Rusin wrote:
>>
>> That looks wrong to me. We already account for the "other fields" in the
>> vertex_size.
>
>
> This patch came from Bryan Cain's original geometry shader patch series--I
> admit I'm not familiar en
On 30 July 2013 11:08, Kenneth Graunke wrote:
> On 07/28/2013 11:03 PM, Paul Berry wrote:
>
>> From: Bryan Cain
>>
>> These correspond to the EmitVertex and EndPrimitive functions in GLSL.
>>
>> v2 (Paul Berry ): Add stub implementations of
>> new pure visitor functions to i965's vec4_visitor an
On 29 July 2013 11:09, Zack Rusin wrote:
> That looks wrong to me. We already account for the "other fields" in the
> vertex_size.
>
This patch came from Bryan Cain's original geometry shader patch series--I
admit I'm not familiar enough with Gallium code to know how to fix it.
Anyone want to st
On 29 July 2013 11:17, Kenneth Graunke wrote:
> On 07/28/2013 11:03 PM, Paul Berry wrote:
>
>> +/**
>> + * Checks if the context supports geometry shaders.
>> + */
>> +static inline GLboolean
>> +_mesa_has_geometry_shaders(const struct gl_context *ctx)
>> +{
>> + return _mesa_is_desktop_gl(ctx)
On 29 July 2013 11:17, Kenneth Graunke wrote:
> On 07/28/2013 11:03 PM, Paul Berry wrote:
>
>> +
>> + /**
>> +* True if the implementation supports GLSL 1.50 style geometry
>> shaders.
>> +* This boolean is distinct from gl_extensions::ARB_geometry_**shader4
>> so
>> +* that we can
On 07/28/2013 11:03 PM, Paul Berry wrote:
From: Fabian Bieler
Reviewed-by: Paul Berry
---
src/mesa/main/api_validate.c | 68
1 file changed, 68 insertions(+)
diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
index 8a2ec7b.
I like that. It also provides a sensible type to pass to the new `is
there any flat shading?` helper.
On Wed, Jul 31, 2013 at 9:52 AM, Paul Berry wrote:
> On 23 July 2013 01:16, Chris Forbes wrote:
>>
>> The program keys are updated accordingly, but the values are not used
>> yet.
>>
>> [V1-2]:
On 07/28/2013 11:03 PM, Paul Berry wrote:
From: Bryan Cain
This commit adds all of the parsing and semantics for GLSL 150 style
geometry shaders.
v2 (Paul Berry ): Adjust i965's
brw_link_shader() to pass the new is_geometry_shader argument to
do_set_program_inouts. Add a few missing calls to
On 07/30/2013 12:13 PM, Carl Worth wrote:
Hi Ken,
In the last stable-release cycle you argued for not cherry picking
commit fcaa48d9cc8937e0ceb59dfd22ef5b6e6fd1a273 on the grounds that
we shouldn't change mesa to be strictly more strict in a stable release.
That is, adding a new error case to t
On 07/30/2013 02:11 PM, Marek Olšák wrote:
Hi Kenneth,
Sorry I haven't had time to test Heaven 4.0 and I'm currently using
the radeonsi driver, which only supports GL 2.1, GLSL 1.30, and it
isn't in good shape to run Heaven at the moment. Besides that, Heaven
4.0 throws an error ("X Error of fai
On 22 July 2013 23:04, Kenneth Graunke wrote:
> On 07/14/2013 02:39 AM, Chris Forbes wrote:
>
>> This series adds support for GLSL 1.30 / EXT_gpu_shader4's 'flat' and
>> 'noperspective' varying interpolation qualifiers on Gen4/5.
>>
>> Based on Olivier Galibert's series from July 2012, with some
On 23 July 2013 01:16, Chris Forbes wrote:
> The program keys are updated accordingly, but the values are not used
> yet.
>
> [V1-2]: Signed-off-by: Olivier Galibert
>
> V3: Updated for vue_map changes, intel -> brw merge, etc. (Chris Forbes)
> V4: Compute interpolation map as a new state atom r
Oops, yes.
On Wed, Jul 31, 2013 at 9:45 AM, Paul Berry wrote:
> On 14 July 2013 02:39, Chris Forbes wrote:
>>
>> This patch ensures that integers will pass through unscathed. Doing
>> (useless) computations on them is risky, especially when their bit
>> patterns correspond to values like inf or
On 14 July 2013 02:39, Chris Forbes wrote:
> This patch ensures that integers will pass through unscathed. Doing
> (useless) computations on them is risky, especially when their bit
> patterns correspond to values like inf or nan.
>
> [V1-2]: Signed-off-by: Olivier Galibert
> Signed-off-by: Chr
On 14 July 2013 02:39, Chris Forbes wrote:
> Adds support for interpolating noperspective varyings linearly in screen
> space when clipping.
>
> Based on Olivier Galibert's patch from last year:
> http://lists.freedesktop.org/archives/mesa-dev/2012-July/024341.html
>
> At this point all -fixed an
On 14 July 2013 02:39, Chris Forbes wrote:
> Previously we only gave special treatment to the builtin color varyings.
> This patch adds support for arbitrary flat-shaded varyings, which is
> required for GLSL 1.30.
>
> Based on Olivier Galibert's patch from last year:
> http://lists.freedesktop.o
On 30 July 2013 14:24, Chris Forbes wrote:
> > It seems a shame to lose this optimization. Can we move the call to
> count_flatshaded_attributes() up to the declaration of nr, and then we can
> keep this?
>
> This function isn't even called if there is no flat-shading to do.
>
Ok, I see. Sorry
On 30 July 2013 14:06, Chris Forbes wrote:
> On Wed, Jul 31, 2013 at 8:53 AM, Paul Berry
> wrote:
> >Can you point me to some VS code that does this? I thought that if the
> VS wrote only to gl_BackColor, then the VUE map would only contain a slot
> for gl_BackColor.
>
> The VS now does this:
>
> It seems a shame to lose this optimization. Can we move the call to
> count_flatshaded_attributes() up to the declaration of nr, and then we can
> keep this?
This function isn't even called if there is no flat-shading to do.
___
mesa-dev mailing lis
Ian Romanick writes:
> Foo. This is an issue that Tom pointed out before we started doing the
> mesa-stable list, and it seems that it does need solving.
Right. I had disregarded the concern because I hadn't realized that
there was a large stabilization phase for a major release that happens
on
Hi Kenneth,
Sorry I haven't had time to test Heaven 4.0 and I'm currently using
the radeonsi driver, which only supports GL 2.1, GLSL 1.30, and it
isn't in good shape to run Heaven at the moment. Besides that, Heaven
4.0 throws an error ("X Error of failed request: GLXBadFBConfig"),
while Heaven
On Wed, Jul 31, 2013 at 8:53 AM, Paul Berry wrote:
>Can you point me to some VS code that does this? I thought that if the VS
>wrote only to gl_BackColor, then the VUE map would only contain a slot for
>gl_BackColor.
The VS now does this:
diff --git a/src/mesa/drivers/dri/i965/
brw_vs.c b/src
On 07/30/2013 12:13 PM, Carl Worth wrote:
Hi Ken,
In the last stable-release cycle you argued for not cherry picking
commit fcaa48d9cc8937e0ceb59dfd22ef5b6e6fd1a273 on the grounds that
we shouldn't change mesa to be strictly more strict in a stable release.
That is, adding a new error case to t
On 14 July 2013 02:39, Chris Forbes wrote:
> Previously the SF only handled the builtin color varying specially.
> This patch generalizes that support to cover user-defined varyings,
> driven by the interpolation mode array set up alongside the VUE map.
>
> Based on the following patches from Oli
Matt Turner writes:
> I think that this patch /should/ go in, since it was a fix for a new
> extension.
>
> 9.2 will be the first version of Mesa to ship with support for
> ARB_shading_language_420pack, so the branch should contain bug fixes
> for the extension.
Thanks. And yes, that reasoning m
From: Roland Scheidegger
llvm shifts are undefined for shift counts exceeding (or matching) bit width,
so need to apply a mask for the tgsi shift instructions.
v2: only use mask for the tgsi shift instructions, not for the build shift
helpers. None of the internal callers need this behavior, and
Am 30.07.2013 22:12, schrieb Zack Rusin:
> we forgot to add ucmp to the list of opcodes, so it was never
> generated for ureg.
>
> Signed-off-by: Zack Rusin
> ---
> src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/gallium/auxiliary/t
On Tue, Jul 30, 2013 at 12:13 PM, Carl Worth wrote:
> Hi Ken,
>
> In the last stable-release cycle you argued for not cherry picking
> commit fcaa48d9cc8937e0ceb59dfd22ef5b6e6fd1a273 on the grounds that
> we shouldn't change mesa to be strictly more strict in a stable release.
>
> That is, adding
we forgot to add ucmp to the list of opcodes, so it was never
generated for ureg.
Signed-off-by: Zack Rusin
---
src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h |2 ++
1 file changed, 2 insertions(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_opcode_tmp.h
b/src/gallium/auxiliary/tgsi/tgsi_op
Thank you. Sorry for not replying earlier.
Marek
On Tue, Jul 30, 2013 at 12:54 AM, Carl Worth wrote:
> Carl Worth writes:
>> I looked closer at the patch and it seems that it's fairly easy to
>> backport to the 9.1 branch as seen below.
>
> And looking at the mesa-stable@ list, I see that you a
Hi Ken,
In the last stable-release cycle you argued for not cherry picking
commit fcaa48d9cc8937e0ceb59dfd22ef5b6e6fd1a273 on the grounds that
we shouldn't change mesa to be strictly more strict in a stable release.
That is, adding a new error case to the compiler cannot actually cause a
valid pr
Kenneth Graunke writes:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64087
..
> Cc: mesa-sta...@lists.freedesktop.org
Picked for 9.1. Thanks.
-Carl
--
carl.d.wo...@intel.com
pgpn3imSF9FUf.pgp
Description: PGP signature
___
mesa-dev mail
Chris Forbes writes:
> NOTE: This is a candidate for stable branches.
Thanks. I've now picked this to a 9.1 branch which I plan to push out
soon.
-Carl
--
carl.d.wo...@intel.com
pgp6AduBOvuys.pgp
Description: PGP signature
___
mesa-dev mailing list
Paul Berry writes:
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=64330
> CC: mesa-sta...@lists.freedesktop.org
Thanks. I've now picked this over to a 9.1 branch which I plan to push
out soon.
-Carl
--
carl.d.wo...@intel.com
pgpr06gKPpBHA.pgp
Description: PGP signature
Brian Paul writes:
> If we call glGetTexImage() for a compressed 2D texture array we need
> to loop over all the slices.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=66850
>
> NOTE: This is a candidate for the 9.x branches.
> Cc: mesa-sta...@lists.freedesktop.org
Thanks. I've now pi
On 07/28/2013 11:03 PM, Paul Berry wrote:
From: Bryan Cain
v2 (Paul Berry ): Account for rework of
builtin_variables.cpp. Use INTERP_QUALIFIER_FLAT for gl_PrimitiveID
so that it will obey provoking vertex conventions. Convert to GLSL
1.50 style geometry shaders.
---
src/glsl/builtin_variabl
On 07/28/2013 11:03 PM, Paul Berry wrote:
From: Bryan Cain
These correspond to the EmitVertex and EndPrimitive functions in GLSL.
v2 (Paul Berry ): Add stub implementations of
new pure visitor functions to i965's vec4_visitor and fs_visitor
classes.
I would prefer to see these called:
ir_em
https://bugs.freedesktop.org/show_bug.cgi?id=67516
--- Comment #6 from Mikko Juola ---
Created attachment 83319
--> https://bugs.freedesktop.org/attachment.cgi?id=83319&action=edit
patch 1/1
I discovered another proxy texture related bug with multisampling textures.
glGetTexLevelParameteriv()
On 07/23/2013 03:50 PM, Matt Turner wrote:
On Mon, Jul 15, 2013 at 6:37 AM, Fredrik Höglund wrote:
On Monday 15 July 2013, Kenneth Graunke wrote:
Fixes Piglit's ARB_vertex_attrib_bgra/api-errors test.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/varray.c | 10 ++
1 file change
https://bugs.freedesktop.org/show_bug.cgi?id=63435
Ian Romanick changed:
What|Removed |Added
Status|NEW |NEEDINFO
Assignee|mesa-dev@list
The series is
Reviewed-by: Ian Romanick
On 07/27/2013 03:59 PM, Paul Berry wrote:
I recently discovered a bug in my geometry shader branch wherein we
were responding to certain kinds of link errors by calling
linker_error(), but the program was still linking successfully. The
root cause turne
---
src/mesa/main/texobj.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c
index d0fcb12..28b8130 100644
--- a/src/mesa/main/texobj.c
+++ b/src/mesa/main/texobj.c
@@ -548,10 +548,11 @@ _mesa_test_texobj_completeness( cons
Old GL 1.x specs used 'b' but newer specs use 'p'. The line immediately
above the second hunk also uses 'p'.
---
src/mesa/main/mtypes.h | 2 +-
src/mesa/main/texobj.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 008f68
Am 30.07.2013 18:13, schrieb srol...@vmware.com:
> From: Roland Scheidegger
>
> Previously, nothing was said what happens with shift counts exceeding
> bit width of the values to shift. In theory 3 behaviors are possible:
> 1) undefined (classic c definition)
> 2) just shift out all bits (so resu
From: Roland Scheidegger
c shifts are undefined for shift counts exceeding (or matching) bit width,
so need to apply a mask (on x86 it actually would usually probably work as
shifts do masking on int domain shifts - unless some auto-vectorizer would
come along at last as simd domain does not mask
From: Roland Scheidegger
llvm shifts are undefined for shift counts exceeding (or matching) bit width,
so need to apply a mask.
NOTE: there's internal callers using this which guarantee the shift count
is smaller than the type width. However, all of these use constant shift
counts hence the addit
From: Roland Scheidegger
Previously, nothing was said what happens with shift counts exceeding
bit width of the values to shift. In theory 3 behaviors are possible:
1) undefined (classic c definition)
2) just shift out all bits (so result is zero, or -1 potentially for ashr)
3) mask the shift cou
On Tue, Jul 30, 2013 at 05:54:58PM +0200, Michel Dänzer wrote:
> On Die, 2013-07-30 at 07:47 -0700, Tom Stellard wrote:
> >
> > You will need to include a lit test with this patch.
>
> Ah yes, this occurred to me after my review. :)
>
>
> > Also, if you try to run piglit with a debug version of
On 29.07.2013 08:03, Paul Berry wrote:
> From: Bryan Cain
>
> v2 (Paul Berry : Split out to separate patch
> (previously this was part of "glsl: add builtins for geometry
> shaders.")
> ---
> src/mesa/state_tracker/st_program.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/m
On Die, 2013-07-30 at 07:47 -0700, Tom Stellard wrote:
>
> You will need to include a lit test with this patch.
Ah yes, this occurred to me after my review. :)
> Also, if you try to run piglit with a debug version of LLVM, it will
> take forever. I always install a release version of llvm for
https://bugs.freedesktop.org/show_bug.cgi?id=58734
Kenneth Graunke changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Wed, Jul 24, 2013 at 09:29:49AM -0400, Jonathan Charest wrote:
> Here is an updated patch with no line wrapping and respecting 80-column limit
> (for my changes).
>
Hi,
I've pushed a modified version of this patch that uses global arguments
for constant buffers so it doesn't break r600g, and
On Tue, Jul 30, 2013 at 03:45:13AM +0200, Marek Olšák wrote:
> This fixes the F2U opcode for the Mesa driver.
>
> Signed-off-by: Marek Olšák
Hi Marek,
You will need to include a lit test with this patch. lit tests are
located in test/CodeGen/R600. You can reuse the existing fp_to_uint.ll
test
https://bugs.freedesktop.org/show_bug.cgi?id=67516
--- Comment #5 from Mikko Juola ---
Yeah, I think so. This is the first time I've ever submitted any patches to
mesa.
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa
https://bugs.freedesktop.org/show_bug.cgi?id=67516
--- Comment #4 from Brian Paul ---
The patches look good to me.
Reviewed-by: Brian Paul
Do you need me to commit them for you?
--
You are receiving this mail because:
You are the assignee for the bug.
__
https://bugs.freedesktop.org/show_bug.cgi?id=58734
ruthubuntu changed:
What|Removed |Added
CC||ruthubu...@gmx.cn
--
You are receiving thi
No, I don't. This is a git patch.
Marek
On Tue, Jul 30, 2013 at 7:53 AM, Michel Dänzer wrote:
> On Die, 2013-07-30 at 03:45 +0200, Marek Olšák wrote:
>> This fixes the F2U opcode for the Mesa driver.
>>
>> Signed-off-by: Marek Olšák
>
> Reviewed-by: Michel Dänzer
>
> Do you have LLVM SVN write
62 matches
Mail list logo
