Re: [Mesa-dev] [PATCH] i965/gen7: always lower textureGrad() on gen7

2013-09-10 Thread Chia-I Wu
On Tue, Sep 10, 2013 at 4:05 AM, Ian Romanick i...@freedesktop.org wrote: On 09/05/2013 03:35 AM, Chia-I Wu wrote: sample_d is slower than the lowered version on gen7. For gen7, this improves Xonotic benchmark with Ultimate effects by as much as 25%: before the change:

Re: [Mesa-dev] [PATCH] glsl: Initialize builtin_builder member variables.

2013-09-10 Thread Kenneth Graunke
On 09/09/2013 08:48 PM, Vinson Lee wrote: Fixes Uninitialized pointer field defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/glsl/builtin_functions.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/builtin_functions.cpp

Re: [Mesa-dev] [PATCH] glsl: Add missing va_end in builtin_builder::add_function.

2013-09-10 Thread Kenneth Graunke
On 09/09/2013 08:34 PM, Vinson Lee wrote: Fixes Missing varargs init or cleanup defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/glsl/builtin_functions.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/builtin_functions.cpp

Re: [Mesa-dev] [PATCH 7/9] i965/gs: Add opcodes needed for EndPrimitive().

2013-09-10 Thread Kenneth Graunke
On 09/09/2013 08:20 AM, Paul Berry wrote: --- src/mesa/drivers/dri/i965/brw_defines.h | 21 src/mesa/drivers/dri/i965/brw_shader.cpp| 4 ++ src/mesa/drivers/dri/i965/brw_vec4.h| 2 + src/mesa/drivers/dri/i965/brw_vec4_emit.cpp | 81 +

Re: [Mesa-dev] [PATCH 0/9] i965/gen7 geometry shader support, series 4

2013-09-10 Thread Kenneth Graunke
On 09/09/2013 08:20 AM, Paul Berry wrote: This is the next installment of geometry shader support for i965 gen7. Patches 1-2 are a rewrite of patches 21-22 of series 3 (confusingly called Initial geometry shader support, part 2 on the mailing list--sorry about that), modified according to

Re: [Mesa-dev] [PATCH] radeonsi: Add parentheses around '|' operands.

2013-09-10 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Sep 10, 2013 at 5:19 AM, Vinson Lee v...@freedesktop.org wrote: Fixes GCC parentheses warning. r600_texture.c: In function 'si_texture_create': r600_texture.c:518:20: warning: suggest parentheses around arithmetic in operand of '|'

Re: [Mesa-dev] regression on nvc0 since floating point compare instructions

2013-09-10 Thread Christoph Bumiller
On 10.09.2013 06:55, Dave Airlie wrote: On Tue, Sep 10, 2013 at 12:04 PM, Dave Airlie airl...@gmail.com wrote: On Tue, Sep 10, 2013 at 11:59 AM, Dave Airlie airl...@gmail.com wrote: Hey, so virgl stopped working on nouveau the other day and I bisected it to the enable of the floating point

Re: [Mesa-dev] regression on nvc0 since floating point compare instructions

2013-09-10 Thread Roland Scheidegger
Am 10.09.2013 04:04, schrieb Dave Airlie: On Tue, Sep 10, 2013 at 11:59 AM, Dave Airlie airl...@gmail.com wrote: Hey, so virgl stopped working on nouveau the other day and I bisected it to the enable of the floating point compare instructions in the state tracker, I've attached a shader

Re: [Mesa-dev] regression on nvc0 since floating point compare instructions

2013-09-10 Thread Roland Scheidegger
Am 10.09.2013 06:55, schrieb Dave Airlie: On Tue, Sep 10, 2013 at 12:04 PM, Dave Airlie airl...@gmail.com wrote: On Tue, Sep 10, 2013 at 11:59 AM, Dave Airlie airl...@gmail.com wrote: Hey, so virgl stopped working on nouveau the other day and I bisected it to the enable of the floating point

Re: [Mesa-dev] [PATCH] mesa: Ensure gl_sync_object is fully initialized.

2013-09-10 Thread Brian Paul
On 09/09/2013 06:34 PM, Vinson Lee wrote: 278372b47e4db8a022d57f60302eec74819e9341 added the uninitialized pointer field gl_sync_object:Label. A free of this pointer, added in commit 6d8dd59cf53d2f47b817d79204a52bb3a46e8c77, resulted in a crash. This patch fixes piglit ARB_sync regressions with

Re: [Mesa-dev] [PATCH] mesa: Use correct enum conversion function.

2013-09-10 Thread Brian Paul
On 09/09/2013 07:57 PM, Vinson Lee wrote: Fixes Mixing enum types defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/mesa/main/errors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/errors.c b/src/mesa/main/errors.c index

Re: [Mesa-dev] [Mesa-stable] [PATCH] docs: Clean up autoconf.html.

2013-09-10 Thread Brian Paul
On 09/09/2013 05:29 PM, Matt Turner wrote: Remove long dead options and clarify some things. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69148 --- docs/autoconf.html | 37 ++--- 1 file changed, 10 insertions(+), 27 deletions(-) diff --git

[Mesa-dev] [PATCH 02/17] mesa: Track per-stage shader input and output limits independently

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com In OpenGL 3.2 these are independently queryable. In addition, the spec has different minimum-maximums for various values. GL_MAX_VERTEX_OUTPUT_COMPONENTS is 64, but GL_MAX_GEOMETRY_OUTPUT_COMPONENTS (and GL_MAX_FRAGMENT_INPUT_COMPONENTS) is 128. In

[Mesa-dev] [PATCH 03/17] mesa: Use correct data for MAX_{VERTEX, GEOMETRY}_VARYING_COMPONENTS_ARB queries

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Previously gl_constants::MaxVaryingComponents was used. Now gl_constants::VertexProgram::MaxOutputs and gl_constants::GeometryProgram::MaxOutputs are used. This means that st_extensions.c had to be updated to set these fields instead of o

[Mesa-dev] [PATCH 04/17] mesa: Remove gl_constants::MaxVaryingComponents

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There are no longer any users. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Paul Berry stereotype...@gmail.com Cc: Marek Olšák mar...@gmail.com Cc: Brian Paul bri...@vmware.com Cc: Zack Rusin za...@vmware.com --- src/mesa/main/mtypes.h | 1

[Mesa-dev] [PATCH 05/17] mesa: Set default values for Max{Input, Output}Components in init_program_limits

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/context.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index d726d11..58f42cc 100644 --- a/src/mesa/main/context.c +++

[Mesa-dev] [PATCH 06/17] i915: Set VertexProgram.MaxOutputComponents and FragmentProgram.MaxInputComponents

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com This was the only remaining place in Mesa that sets MaxVaryings withtout also setting these values. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/drivers/dri/i915/i915_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 07/17] mesa: Get GL_MAX_VERTEX_OUTPUT_COMPONENTS from VertexProgram.MaxOutputComponents

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com In OpenGL ES 3.0 the minimum-maximum for GL_MAX_VERTEX_OUTPUT_VECTORS is 16, but the minimum-maximum for GL_MAX_FRAGMENT_INTPUT_VECTORS is 15. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/get.c | 1 -

[Mesa-dev] [PATCH 08/17] mesa: Get GL_MAX_FRAGMENT_INPUT_COMPONENTS from FragmentProgram.MaxInputComponents

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com In OpenGL ES 3.0 the minimum-maximum for GL_MAX_VERTEX_OUTPUT_VECTORS is 16, but the minimum-maximum for GL_MAX_FRAGMENT_INTPUT_VECTORS is 15. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/get.c | 1 -

[Mesa-dev] [PATCH 09/17] mesa: Expose MAX_GEOMETRY_{INPUT, OUTPUT}_COMPONENTS on OpenGL 3.2

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Paul Berry stereotype...@gmail.com --- src/mesa/main/get_hash_params.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/get_hash_params.py

[Mesa-dev] [PATCH 11/17] mesa: Get GL_MAX_VARYING_FLOATS_ARB from VertexProgram.MaxOutputComponents

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/get.c | 4 src/mesa/main/get_hash_params.py | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index

[Mesa-dev] [PATCH 14/17] mesa: Silence GCC warning 'comparison between signed and unsigned integer expressions'

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/mesa/main/get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 2f3d352..1f6201b 100644 --- a/src/mesa/main/get.c +++

[Mesa-dev] [PATCH 10/17] mesa: Allow several ARB_geometry_shader4 queries in OpenGL 3.2

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com GL_MAX_GEOMETRY_TEXTURE_IMAGE_UNITS, GL_MAX_GEOMETRY_OUTPUT_VERTICES, GL_MAX_GEOMETRY_TOTAL_OUTPUT_COMPONENTS, and GL_MAX_GEOMETRY_UNIFORM_COMPONENTS all have the same enum value and meaning as their _ARB counterparts. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 15/17] glsl: Count shader inputs and outputs separately

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Starting with OpenGL 3.2 input limits and output limits for stages may not match. This means they need to be accounted separately. No piglit regressions. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: Paul Berry stereotype...@gmail.com ---

[Mesa-dev] [PATCH 17/17] glsl: Remove glsl_parser_state MaxVaryingFloats field

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com It is no longer used anywhere. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/glsl_parser_extras.cpp | 1 - src/glsl/glsl_parser_extras.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/glsl/glsl_parser_extras.cpp

[Mesa-dev] [PATCH 12/17] glsl: Set VertexProgram.MaxOutputComponents and FragmentProgram.MaxInputComponents in standalone scaffolding

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- src/glsl/standalone_scaffolding.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/standalone_scaffolding.cpp b/src/glsl/standalone_scaffolding.cpp index 11cd6cd..6dec205 100644

[Mesa-dev] [PATCH 01/17] mesa: Support GL_MAX_VERTEX_OUTPUT_COMPONENTS query with ES3

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: 9.1 9.2 mesa-sta...@lists.freedesktop.org --- src/mesa/main/get.c | 1 + src/mesa/main/get_hash_params.py | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/get.c

Re: [Mesa-dev] [PATCH 9/9] i965/gs: implement EndPrimitive() functionality in the visitor.

2013-09-10 Thread Kenneth Graunke
On 09/09/2013 08:20 AM, Paul Berry wrote: According to GLSL, the shader may call EndPrimitive() at any point during its execution, causing the line or triangle strip currently being output to be terminated and a new strip to be begun. This is implemented in gen7 hardware by using one control

Re: [Mesa-dev] [PATCH 16/17] glsl: Set gl_MaxVaryingFloats et al. from VertexProgram.MaxOutputComponents and FragmentProgram.MaxInputComponents

2013-09-10 Thread Ian Romanick
On 09/10/2013 03:47 PM, Brian Paul wrote: On 09/10/2013 01:11 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Some language versions have the vertex output components minimum-maximum lower (GLSL 1.50), and some have the fragment input components minimum-maximum lower

Re: [Mesa-dev] Mesa (master): util: Fix unmatched parenthesis.

2013-09-10 Thread Brian Paul
On 09/10/2013 11:34 AM, Vinson Lee wrote: Module: Mesa Branch: master Commit: d93e23ba25cbfd8f77a4b3a113ca7ed3dece1e68 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d93e23ba25cbfd8f77a4b3a113ca7ed3dece1e68 Author: Vinson Lee v...@freedesktop.org Date: Tue Sep 10 10:31:29 2013

Re: [Mesa-dev] [PATCH 16/17] glsl: Set gl_MaxVaryingFloats et al. from VertexProgram.MaxOutputComponents and FragmentProgram.MaxInputComponents

2013-09-10 Thread Brian Paul
On 09/10/2013 01:11 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Some language versions have the vertex output components minimum-maximum lower (GLSL 1.50), and some have the fragment input components minimum-maximum lower (GLSL ES 3.0). Use whichever value is lower, and

Re: [Mesa-dev] [PATCH 01/17] mesa: Support GL_MAX_VERTEX_OUTPUT_COMPONENTS query with ES3

2013-09-10 Thread Brian Paul
On 09/10/2013 01:10 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Signed-off-by: Ian Romanick ian.d.roman...@intel.com Cc: 9.1 9.2 mesa-sta...@lists.freedesktop.org For the series, Reviewed-by: Brian Paul bri...@vmware.com

Re: [Mesa-dev] [PATCH 2/2] wayland-egl.pc requires wayland.pc.

2013-09-10 Thread Kenneth Graunke
On 09/10/2013 02:36 PM, Johannes Obermayr wrote: From: Torsten Duwe d...@suse.de Mesa provides the wayland-egl libs and the pkgconfig file, but the headers originate from the wayland package. Ensure everything matches, by requiring application builds to look at the wayland headers as well.

[Mesa-dev] [PATCH 1/2] st/gbm: Add $(WAYLAND_CFLAGS) for HAVE_EGL_PLATFORM_WAYLAND.

2013-09-10 Thread Johannes Obermayr
--- src/gallium/state_trackers/gbm/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/gbm/Makefile.am b/src/gallium/state_trackers/gbm/Makefile.am index 70c5f77..b113d0d 100644 --- a/src/gallium/state_trackers/gbm/Makefile.am +++

[Mesa-dev] [PATCH 2/2] wayland-egl.pc requires wayland.pc.

2013-09-10 Thread Johannes Obermayr
From: Torsten Duwe d...@suse.de Mesa provides the wayland-egl libs and the pkgconfig file, but the headers originate from the wayland package. Ensure everything matches, by requiring application builds to look at the wayland headers as well. Signed-off-by: Torsten Duwe d...@suse.de

[Mesa-dev] [PATCH 16/17] glsl: Set gl_MaxVaryingFloats et al. from VertexProgram.MaxOutputComponents and FragmentProgram.MaxInputComponents

2013-09-10 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Some language versions have the vertex output components minimum-maximum lower (GLSL 1.50), and some have the fragment input components minimum-maximum lower (GLSL ES 3.0). Use whichever value is lower, and call it done. Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH 05/15] i965/sf: Consolidate common code for setting up gen6-7 attribute overrides.

2013-09-10 Thread Paul Berry
On 9 September 2013 13:05, Ian Romanick i...@freedesktop.org wrote: @@ -123,21 +123,98 @@ get_attr_override(const struct brw_vue_map *vue_map, int urb_entry_read_offset, return source_attr; } + +/** + * Create the mapping from the FS inputs we produce to the VS outputs they

[Mesa-dev] [PATCH v2 3/3] r600g: fast color clears for single-sample buffers

2013-09-10 Thread Grigori Goronzy
Allocate a CMASK on demand and use it to fast clear single-sample colorbuffers. Both FBOs and window system colorbuffers are fast cleared. Expand as needed when colorbuffers are mapped or displayed on screen. v2: cosmetics, move transfer expansion into dma_blit ---

[Mesa-dev] [PATCH v2 2/3] r600g: add support for separately allocated CMASKs

2013-09-10 Thread Grigori Goronzy
v2: check for NULL cbufs --- src/gallium/drivers/r600/evergreen_state.c | 24 +++- src/gallium/drivers/r600/r600_hw_context.c | 18 ++ src/gallium/drivers/r600/r600_resource.h | 3 +++ src/gallium/drivers/r600/r600_texture.c| 25 -

[Mesa-dev] [PATCH v2 1/3] gallium: add flush_resource context function

2013-09-10 Thread Grigori Goronzy
From: Marek Olšák mar...@gmail.com r600g needs explicit flushing before DRI2 buffers are presented on the screen. v2: add (stub) implementations for all drivers, fix frontbuffer flushing v3: fix galahad --- src/gallium/docs/source/context.rst | 13 +

Re: [Mesa-dev] [PATCH 08/15] i965/gen6+: Remove VUE map dependency on userclip_active.

2013-09-10 Thread Paul Berry
On 9 September 2013 13:24, Ian Romanick i...@freedesktop.org wrote: On 09/03/2013 06:18 PM, Paul Berry wrote: Previously, on Gen6+, we laid out the vertex (or geometry) shader VUE map differently depending whether user clipping was active. If it was active, we put the clip distances in

[Mesa-dev] [Bug 69148] configure does not accept --with-driver

2013-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69148 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Mesa-dev] [PATCH 1/3] i965/vec4: Simplify the computation of coord_mask and zero_mask.

2013-09-10 Thread Chris Forbes
This is a fair bit saner :) For the series: Reviewed-by: Chris Forbes chr...@ijw.co.nz On Tue, Sep 10, 2013 at 11:00 AM, Kenneth Graunke kenn...@whitecape.org wrote: We can easily compute these without loops, resulting in simpler and shorter code. Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 2/9] i965/gs: Add a state atom to set up geometry shader state.

2013-09-10 Thread Paul Berry
On 9 September 2013 16:31, Kenneth Graunke kenn...@whitecape.org wrote: On 09/09/2013 08:20 AM, Paul Berry wrote: +const struct brw_tracked_state gen7_gs_state = { + .dirty = { + .mesa = _NEW_PROGRAM_CONSTANTS, I'm pretty sure you need _NEW_TRANSFORM here. The atom earlier in

[Mesa-dev] [Bug 69202] New: piglit fs-mix-float-float-bool regression

2013-09-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69202 Priority: medium Bug ID: 69202 Keywords: regression CC: matts...@gmail.com Assignee: mesa-dev@lists.freedesktop.org Summary: piglit fs-mix-float-float-bool regression

Re: [Mesa-dev] [PATCH 4/9] i965/gs: Set control data header size/format appropriately for EndPrimitive().

2013-09-10 Thread Paul Berry
On 9 September 2013 14:30, Chris Forbes chr...@ijw.co.nz wrote: In the commit message: Fortunately, OpenGL only requires separate streams to be supported when the output type is points, and EndPrimitive() only has an effect when the input type is line_strip or triangle_strip, so it's not

Re: [Mesa-dev] [PATCH 4/9] i965/gs: Set control data header size/format appropriately for EndPrimitive().

2013-09-10 Thread Paul Berry
On 9 September 2013 17:56, Kenneth Graunke kenn...@whitecape.org wrote: On 09/09/2013 08:20 AM, Paul Berry wrote: diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index 0406c4d..6db2570 100644 --- a/src/mesa/drivers/dri/i965/brw_defines.h

Re: [Mesa-dev] [PATCH 7/9] i965/gs: Add opcodes needed for EndPrimitive().

2013-09-10 Thread Paul Berry
On 9 September 2013 23:39, Kenneth Graunke kenn...@whitecape.org wrote: On 09/09/2013 08:20 AM, Paul Berry wrote: +void +vec4_generator::generate_gs_set_channel_masks(struct brw_reg dst, + struct brw_reg src) +{ + /* From p21 of volume 4

Re: [Mesa-dev] [PATCH 7/9] i965/gs: Add opcodes needed for EndPrimitive().

2013-09-10 Thread Kenneth Graunke
On 09/10/2013 09:07 PM, Paul Berry wrote: On 9 September 2013 23:39, Kenneth Graunke kenn...@whitecape.org mailto:kenn...@whitecape.org wrote: On 09/09/2013 08:20 AM, Paul Berry wrote: +void +vec4_generator::generate_gs_set_channel_masks(struct brw_reg dst, +

Re: [Mesa-dev] [PATCH 7/9] i965/gs: Add opcodes needed for EndPrimitive().

2013-09-10 Thread Paul Berry
On 10 September 2013 21:23, Kenneth Graunke kenn...@whitecape.org wrote: On 09/10/2013 09:07 PM, Paul Berry wrote: Good point. I've added a comment that says: * Note: this relies on the source register having zeros in (a) bits 7:4 of * DWORD 0 and (b) bits 3:0 of DWORD 4. We

Re: [Mesa-dev] [PATCH 9/9] i965/gs: implement EndPrimitive() functionality in the visitor.

2013-09-10 Thread Paul Berry
On 10 September 2013 12:44, Kenneth Graunke kenn...@whitecape.org wrote: On 09/09/2013 08:20 AM, Paul Berry wrote: +void +vec4_gs_visitor::emit_control_data_bits() +{ + assert(c-control_data_bits_per_vertex != 0); + + /* Since the URB_WRITE_OWORD message operates with 128-bit

Re: [Mesa-dev] [PATCH 9/9] i965/gs: implement EndPrimitive() functionality in the visitor.

2013-09-10 Thread Kenneth Graunke
On 09/10/2013 09:56 PM, Paul Berry wrote: On 10 September 2013 12:44, Kenneth Graunke wrote: [snip] Maybe shorten this to: urb_write_flags |= BRW_URB_WRITE_USE_CHANNEL_MASKS; + if (c-control_data_header_size_bits 128) + urb_write_flags = urb_write_flags |