Re: [Mesa-dev] [PATCH 4/4] i965: Refactor Gen4-6 SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Paul Berry
On 13 September 2013 23:10, Kenneth Graunke wrote: > This was an embarassingly large amount of copy and pasted code, > and it wasn't particularly simple code either. By factoring it out > into a helper function, we consolidate the complexity. > I believe the off-by-one error with buffer_size th

Re: [Mesa-dev] [PATCH 3/4] i965: Remove MIPLAYOUT_BELOW from Gen4-6 constant buffer surface state.

2013-09-16 Thread Paul Berry
On 13 September 2013 23:10, Kenneth Graunke wrote: > Specifying a miptree layout makes no sense for constant buffers. > You might want to mention in the commit message that there's no functional change since BRW_SURFACE_MIPMAPLAYOUT_BELOW == 0. In any case, the patch is: Reviewed-by: Paul Berr

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Paul Berry
On 16 September 2013 09:38, Eric Anholt wrote: > Kenneth Graunke writes: > > > This was an embarassingly large amount of copy and pasted code, > > and it wasn't particularly simple code either. By factoring it out > > into a helper function, we consolidate the complexity. > > > > Signed-off-by:

Re: [Mesa-dev] [PATCH 2/4] i965: Share Gen7+ SURFACE_STATE setup for textures and renderbuffers.

2013-09-16 Thread Paul Berry
On 13 September 2013 23:10, Kenneth Graunke wrote: > The SURFACE_STATE entries for textures and renderbuffers share almost > all of the same fields. Only a couple are specific to one or the other. > > Thus, it makes sense to have a single shared function that takes care of > all the bit-shifting

[Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69437 U. Artie Eoff changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |wayland-bugs@lists.freedesk

[Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69437 --- Comment #1 from Kristian Høgsberg --- Created attachment 85941 --> https://bugs.freedesktop.org/attachment.cgi?id=85941&action=edit Best fix so far Here's the best fix so far. Not entirely happy with it, but it's not terrible. -- You ar

Re: [Mesa-dev] [PATCH 3/3] i965: Use gen7_upload_constant_state for 3DSTATE_CONSTANT_PS as well.

2013-09-16 Thread Paul Berry
On 13 September 2013 16:05, Kenneth Graunke wrote: > Now we use gen7_upload_constant_state() for all three shader stages. > > Signed-off-by: Kenneth Graunke > Cc: Paul Berry > Series is: Reviewed-by: Paul Berry ___ mesa-dev mailing list mesa-dev@li

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Paul Berry
On 13 September 2013 23:10, Kenneth Graunke wrote: > This was an embarassingly large amount of copy and pasted code, > and it wasn't particularly simple code either. By factoring it out > into a helper function, we consolidate the complexity. > > Signed-off-by: Kenneth Graunke > I really like

Re: [Mesa-dev] [PATCH 3/3] glsl: Drop shader_bit_encoding version checks.

2013-09-16 Thread Paul Berry
On 13 September 2013 11:25, Kenneth Graunke wrote: > We now set the ARB_shader_bit_encoding flag for versions that support > this functionality, so we don't need to double check it here. > > Signed-off-by: Kenneth Graunke > Cc: Ian Romanick > --- > src/glsl/builtin_functions.cpp | 3 +-- > 1 f

[Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-09-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69437 U. Artie Eoff changed: What|Removed |Added Assignee|wayland-bugs@lists.freedesk |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] gallium-bind-sampler-states branch

2013-09-16 Thread Brian Paul
On 09/16/2013 08:56 AM, Roland Scheidegger wrote: Am 14.09.2013 18:24, schrieb Brian Paul: On 09/12/2013 09:06 PM, Chia-I Wu wrote: Hi Brian, On Fri, Sep 13, 2013 at 8:46 AM, Brian Paul wrote: I just pushed a gallium-bind-sampler-states branch to my git repo at git://people.freedesktop.org/

Re: [Mesa-dev] Could use your help with a bug involving piglit, waffle, and egl.

2013-09-16 Thread Paul Berry
(CC'ing Mesa-dev since this is a Mesa bug). On 16 September 2013 11:00, Chad Versace wrote: > CC'ing Piglit. > > > On 09/14/2013 08:54 AM, Paul Berry wrote: > >> I'm investigating a failure in spec/OES_fixed_point/**attribute-arrays, >> specifically the command line >> "/home/pberry/.platform/**p

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Kenneth Graunke
On 09/16/2013 09:38 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> This was an embarassingly large amount of copy and pasted code, >> and it wasn't particularly simple code either. By factoring it out >> into a helper function, we consolidate the complexity. >> >> Signed-off-by: Kenneth G

Re: [Mesa-dev] [PATCH 11/15] i965/fs: When >64 input components, order them to match prev pipeline stage.

2013-09-16 Thread Paul Berry
On 15 September 2013 21:16, Kenneth Graunke wrote: > On 09/03/2013 04:18 PM, Paul Berry wrote: > > Since the SF/SBE stage is only capable of performing arbitrary > > reorderings of 16 varying slots, we can't arrange the fragment shader > > inputs in an arbitrary order if there are more than 16 in

Re: [Mesa-dev] [PATCH 1/4] i965: Refactor Gen7+ SURFACE_STATE setup for buffer surfaces.

2013-09-16 Thread Eric Anholt
Kenneth Graunke writes: > This was an embarassingly large amount of copy and pasted code, > and it wasn't particularly simple code either. By factoring it out > into a helper function, we consolidate the complexity. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen7_wm_s

Re: [Mesa-dev] gallium-bind-sampler-states branch

2013-09-16 Thread Roland Scheidegger
Am 16.09.2013 18:18, schrieb Brian Paul: > On 09/16/2013 08:56 AM, Roland Scheidegger wrote: >> Am 14.09.2013 18:24, schrieb Brian Paul: >>> On 09/12/2013 09:06 PM, Chia-I Wu wrote: Hi Brian, On Fri, Sep 13, 2013 at 8:46 AM, Brian Paul wrote: > > I just pushed a gallium-bind

Re: [Mesa-dev] gallium-bind-sampler-states branch

2013-09-16 Thread Chia-I Wu
On Tue, Sep 17, 2013 at 12:09 AM, Brian Paul wrote: > On 09/15/2013 09:31 AM, Chia-I Wu wrote: >> >> On Sun, Sep 15, 2013 at 12:24 AM, Brian Paul wrote: >>> >>> On 09/12/2013 09:06 PM, Chia-I Wu wrote: Hi Brian, On Fri, Sep 13, 2013 at 8:46 AM, Brian Paul wrote: > >>

Re: [Mesa-dev] gallium-bind-sampler-states branch

2013-09-16 Thread Brian Paul
On 09/15/2013 09:31 AM, Chia-I Wu wrote: On Sun, Sep 15, 2013 at 12:24 AM, Brian Paul wrote: On 09/12/2013 09:06 PM, Chia-I Wu wrote: Hi Brian, On Fri, Sep 13, 2013 at 8:46 AM, Brian Paul wrote: I just pushed a gallium-bind-sampler-states branch to my git repo at git://people.freedesktop

Re: [Mesa-dev] a newbie asking newbie questions

2013-09-16 Thread Eric Anholt
"Rogovin, Kevin" writes: > Hello all, > > I am new to Mesa development (and in particular the i965 driver). I am > currently trying to gain an understanding of Mesa's implementation > with mostly an eye on (just) the i965 driver. Some questions: > > There are some docs in docs, how up to date are

Re: [Mesa-dev] [PATCH 3/3] mesa: add missing error checks in _mesa_GetObject[Ptr]Label()

2013-09-16 Thread Brian Paul
Hmm, check out the man page at http://www.opengl.org/sdk/docs/man/xhtml In the description it basically says that bufSize can be zero, but in the "Errors" section is says bufSize=0 is a GL_INVALID_VALUE. I think you're right about bufSize=0 being OK since one might want to just query the leng

Re: [Mesa-dev] gallium-bind-sampler-states branch

2013-09-16 Thread Roland Scheidegger
Am 14.09.2013 18:24, schrieb Brian Paul: > On 09/12/2013 09:06 PM, Chia-I Wu wrote: >> Hi Brian, >> >> On Fri, Sep 13, 2013 at 8:46 AM, Brian Paul wrote: >>> >>> I just pushed a gallium-bind-sampler-states branch to my git repo at >>> git://people.freedesktop.org/~brianp/mesa >>> >>> It replaces t

[Mesa-dev] a newbie asking newbie questions

2013-09-16 Thread Rogovin, Kevin
Hello all, I am new to Mesa development (and in particular the i965 driver). I am currently trying to gain an understanding of Mesa's implementation with mostly an eye on (just) the i965 driver. Some questions: There are some docs in docs, how up to date are those documents? In particular I sa

Re: [Mesa-dev] [PATCH 3/3] mesa: add missing error checks in _mesa_GetObject[Ptr]Label()

2013-09-16 Thread Timothy Arceri
I tested on Catalyst and it allows both negative and 0 buf size without a GL_INVALID_VALUE error. I'm not sure if I'm allowed to review patches but for whats its worth for the other two patches. Reviewed-by: Timothy Arceri On 16/09/13 15:37, Timothy Arceri wrote: Hi Brian, Maybe its just

Re: [Mesa-dev] [PATCH v3] wayland: Add support for eglSwapInterval

2013-09-16 Thread Pekka Paalanen
On Fri, 13 Sep 2013 17:04:38 +0100 Neil Roberts wrote: > Here is another version of the patch which brings back the blocking > when there are no buffers available to cope with the situation where > the compositor isn't immediately releasing buffers. Maybe we could > leave the decision about wheth

[Mesa-dev] [PATCH] egl: add EGL_WAYLAND_Y_INVERTED_WL attribute

2013-09-16 Thread Stanislav Vorobiov
This enables querying of wl_buffer's orientation --- docs/specs/WL_bind_wayland_display.spec | 17 + include/EGL/eglmesaext.h|2 ++ 2 files changed, 19 insertions(+) diff --git a/docs/specs/WL_bind_wayland_display.spec b/docs/specs/WL_bind_wayland_display.sp

[Mesa-dev] [PATCH] egl: add EGL_WAYLAND_Y_INVERTED_WL attribute

2013-09-16 Thread Stanislav Vorobiov
This patch enables querying of wl_buffer's orientation, it's associated with weston commit bfbb8e59fadda112fcdb0bf0a0ed2c0b6c1e1923 gl_renderer: Use EGL_WAYLAND_Y_INVERTED_WL to query wl_buffer's orientation Stanislav Vorobiov (1): egl: add EGL_WAYLAND_Y_INVERTED_WL attribute docs/specs/WL_bin

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-16 Thread Chia-I Wu
On Mon, Sep 16, 2013 at 4:12 PM, Chia-I Wu wrote: > On Mon, Sep 16, 2013 at 3:50 AM, Mark Mueller wrote: >> >> >> >> On Fri, Sep 13, 2013 at 2:15 PM, Paul Berry wrote: >>> >>> On 12 September 2013 22:06, Chia-I Wu wrote: From: Chia-I Wu Consider only the top-left and top-ri

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-16 Thread Chia-I Wu
On Mon, Sep 16, 2013 at 3:50 AM, Mark Mueller wrote: > > > > On Fri, Sep 13, 2013 at 2:15 PM, Paul Berry wrote: >> >> On 12 September 2013 22:06, Chia-I Wu wrote: >>> >>> From: Chia-I Wu >>> >>> Consider only the top-left and top-right pixels to approximate DDX in a >>> 2x2 >>> subspan, unless

Re: [Mesa-dev] [PATCH] i965/hsw: compute DDX in a subspan based only on top row

2013-09-16 Thread Chia-I Wu
On Sat, Sep 14, 2013 at 5:15 AM, Paul Berry wrote: > On 12 September 2013 22:06, Chia-I Wu wrote: >> >> From: Chia-I Wu >> >> Consider only the top-left and top-right pixels to approximate DDX in a >> 2x2 >> subspan, unless the application or the user requests a more accurate >> approximation.

Re: [Mesa-dev] [PATCH 0/6] Support for 10 bpc EGLSurface

2013-09-16 Thread Daniel Vetter
On Sun, Sep 15, 2013 at 12:16:42AM -0700, Kristian Høgsberg wrote: > This little series adds support for creating EGLSurfaces with color buffers > using the ARGB2101010 pixel format. We the new KMS addFB2 ioctl we can > create KMS framebuffers with that format and this series ends up adding > the