[Mesa-dev] [PATCH] r600g/sb: Move variable dereference after null check.

2013-09-28 Thread Vinson Lee
Fixes Deference before null check defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/r600/sb/sb_ra_init.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/sb/sb_ra_init.cpp

[Mesa-dev] [PATCH] r600g: Prevent by invalid op overflows in release builds.

2013-09-28 Thread Vinson Lee
Fixes Overflowed return value defects reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/r600/r600_isa.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/drivers/r600/r600_isa.h b/src/gallium/drivers/r600/r600_isa.h index

Re: [Mesa-dev] [PATCH] r600g/sb: Move variable dereference after null check.

2013-09-28 Thread Vadim Girlin
On 09/28/2013 10:08 AM, Vinson Lee wrote: Fixes Deference before null check defect reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org Reviewed-by: Vadim Girlin vadimgir...@gmail.com --- src/gallium/drivers/r600/sb/sb_ra_init.cpp | 3 ++- 1 file changed, 2 insertions(+),

[Mesa-dev] Choosing texture internal format in GLES

2013-09-28 Thread Wladimir
Hello, Mareko and me had a small discussion about this on IRC. Basically with GLES (1.0, 2.0 at least) the application has no way to control the exact internal format [1]. This is intentional give the hardware more leeway. See http://www.khronos.org/opengles/sdk/docs/man/xhtml/glTexImage2D.xml

[Mesa-dev] [PATCH] r600g: Add missing break for callstack_push FC_PUSH_WQM case.

2013-09-28 Thread Vinson Lee
Fixes Missing break in switch reported by Coverity. Signed-off-by: Vinson Lee v...@freedesktop.org --- src/gallium/drivers/r600/r600_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index

Re: [Mesa-dev] [PATCH] i965: Update the comment about viewport hacks.

2013-09-28 Thread Eric Anholt
Kenneth Graunke kenn...@whitecape.org writes: It wasn't clear that this was necessary for EGL, or why. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Reviewed-by: Eric Anholt e...@anholt.net pgp3FARJn7IFg.pgp Description: PGP signature ___

Re: [Mesa-dev] [PATCH] Use -Bsymbolic when linking libEGL.so

2013-09-28 Thread Eric Anholt
Carl Worth cwo...@cworth.org writes: For some reason that I don't yet fully understand, Glaze does not work with libEGL unless libEGL is linked with -Bsymbolic.[*] Beyond that specific reason, all of the reasons for which libGL.so is linked with -Bsymbolic, (see the commit history), should

Re: [Mesa-dev] [PATCH] i965: Remove the ARF register file.

2013-09-28 Thread Kenneth Graunke
On 09/27/2013 06:18 PM, Matt Turner wrote: The registers in the architecture register file don't share much in common, so there's no point in grouping them together. Use the HW_REG class instead. The vec4 backend already does this. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 6

Re: [Mesa-dev] [PATCH 05/29] softpipe: consolidate C sources list into Makefile.sources

2013-09-28 Thread Emil Velikov
On 28/09/13 04:48, Tom Stellard wrote: On Sun, Sep 22, 2013 at 09:29:28PM +0100, Emil Velikov wrote: Signed-off-by: Emil Velikov emil.l.veli...@gmail.com As long as you have build tested these with both automake and scons and are prepared to deal with any fallout once they are committed.

[Mesa-dev] st/xorg targets/xorg cleanups v2

2013-09-28 Thread Emil Velikov
Slight extension over the previous two patches, removing unused variables and headers. Last two patches do not strictly below in this series, as they provide more consistent automake/configure usage of pkg-config (PKG_CHECK_MODULES). Please comment and review. Cheers, Emil [PATCH 1/7] st/xorg:

[Mesa-dev] [PATCH 1/7] st/xorg: remove unnecessary headers

2013-09-28 Thread Emil Velikov
v2: Remove xf86PciInfo.h, all drivers provide their own PCI ID list Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/state_trackers/xorg/xorg_driver.c | 1 - src/gallium/state_trackers/xorg/xorg_output.c | 7 --- 2 files changed, 8 deletions(-) diff --git

[Mesa-dev] [PATCH 2/7] st/xorg: add sanity checks after malloc

2013-09-28 Thread Emil Velikov
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/state_trackers/xorg/xorg_driver.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/state_trackers/xorg/xorg_driver.c b/src/gallium/state_trackers/xorg/xorg_driver.c index dd243bc..097c354 100644 ---

[Mesa-dev] [PATCH 3/7] st/xorg: drop set but unsused variables dxo, dyo

2013-09-28 Thread Emil Velikov
Commit a9f8baf00b264 removed the first and only use of the variables but forgot to remove them. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/state_trackers/xorg/xorg_xv.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/state_trackers/xorg/xorg_xv.c

[Mesa-dev] [PATCH 4/7] gallium/targets/xorg: drop set but unused variable entity

2013-09-28 Thread Emil Velikov
The function xf86GetEntityInfo() retrieves the entity rather than doing any changes. Remove this no-op code. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- src/gallium/targets/r600/xorg/xorg.c| 3 --- src/gallium/targets/radeonsi/xorg/xorg.c| 3 ---

[Mesa-dev] [PATCH 5/7] targets/xorg-nouveau: drop usage of dri1 function DRICreatePCIBusID

2013-09-28 Thread Emil Velikov
The function should have never used it in the first place as it was a left over from the DRI1 days of the nouveau ddx. While we're around check if KMS is supported before opening the nouveau device, and add support for Fermi Kepler cards. Compile tested only due to the lack of a Fermi/Kepler

[Mesa-dev] [PATCH 6/7] configure: use PKG_CONFIG variable over hardcoded pkg-config

2013-09-28 Thread Emil Velikov
Already available and used in other places of configure.ac. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 1f0a646..1dd0087 100644 --- a/configure.ac +++

[Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-09-28 Thread Emil Velikov
Use PKG_CHECK_MODULE over requesting the user to setup the option at configure time. Drop unused EXPAT_INCLUDE and add EXPAT_CFLAGS to all classic/dri and gallium/dri targets. Signed-off-by: Emil Velikov emil.l.veli...@gmail.com --- configure.ac | 23

[Mesa-dev] [PATCH] egl/main: remove undefined X11_LIBS automake variable

2013-09-28 Thread Gaetan Nadon
The EGL library has some references to x11 but it gets the link flags from the XCB_DRI2_LIBS iff HAVE_EGL_PLATFORM_X11 is true. The X11_LIBS variable was probably coming from a PKG_CHECK_MODULES (x11) earlier in history. If it is possible to have HAVE_EGL_DRIVER_GLX without HAVE_EGL_PLATFORM_X11

Re: [Mesa-dev] Choosing texture internal format in GLES

2013-09-28 Thread Marek Olšák
No, I said it would be better to use st_choose_matching_format in st_ChooseTextureFormat, because st_choose_matching_format does exactly what you're trying to do. I have gone ahead and implemented what I had in mind. See the attached patch. Marek On Sat, Sep 28, 2013 at 8:45 AM, Wladimir

Re: [Mesa-dev] [PATCH] egl/main: remove undefined X11_LIBS automake variable

2013-09-28 Thread Emil Velikov
On 28/09/13 20:00, Gaetan Nadon wrote: The EGL library has some references to x11 but it gets the link flags from the XCB_DRI2_LIBS iff HAVE_EGL_PLATFORM_X11 is true. s/iff/if/ The X11_LIBS variable was probably coming from a PKG_CHECK_MODULES (x11) earlier in history. If it is possible

Re: [Mesa-dev] [PATCH 3/4] glsl/gs: handle gl_ClipDistance geometry input in lower_clip_distance.

2013-09-28 Thread Paul Berry
On 27 September 2013 14:32, Ian Romanick i...@freedesktop.org wrote: There are some bits of this patch I'm trying to understand. I think they can be cleared up by one question below... On 09/14/2013 01:00 PM, Paul Berry wrote: From: Bryan Cain bryanca...@gmail.com This corresponds to