[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 --- Comment #4 from Alexander von Gluck kallis...@unixzen.com --- hm.. do you get the same results using the ./configure and a make? -- You are receiving this mail because: You are the assignee for the bug.

[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 --- Comment #5 from Vinson Lee v...@freedesktop.org --- (In reply to comment #4) hm.. do you get the same results using the ./configure and a make? configure and make passes for me. -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 --- Comment #6 from Alexander von Gluck kallis...@unixzen.com --- Created attachment 87648 -- https://bugs.freedesktop.org/attachment.cgi?id=87648action=edit fix revision 1 It's now the wee hours of the morning. Please try the fix attached.

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #11 from Fabio Pedretti fabio@libero.it --- (In reply to comment #9) I cannot test it until few days, if it works for you commit it. Confirmed fixing the issue, thanks. -- You are receiving this mail because: You are the

[Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Dave Airlie
Hi, I pulled Brian's patches and then hacked llvmpipe locally to claim GL 3.2, and ran piglit, fixed some of the obviously missing pieces and crashes. These aren't immediately going to expose any new functionality, but it might help if someone doing r600g or nouveau support can concentrate on

[Mesa-dev] [PATCH 1/5] mesa/st: Add VARYING_SLOT_TEX[1-7] to st_translate_geometry_program().

2013-10-15 Thread Dave Airlie
From: Bryan Cain bryanca...@gmail.com v2 (Paul Berry stereotype...@gmail.com: Split out to separate patch (previously this was part of glsl: add builtins for geometry shaders.) Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_program.c | 7 +++ 1 file changed, 7

[Mesa-dev] [PATCH 2/5] st/mesa, glsl_to_tgsi: add support for geometry shaders

2013-10-15 Thread Dave Airlie
From: Bryan Cain bryanca...@gmail.com v2 (Bryan Cain bryanca...@gmail.com): fix 2D array indexing order. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 101 ++- src/mesa/state_tracker/st_program.c| 107

[Mesa-dev] [PATCH 3/5] mesa/st: Allow geometry shaders without gl_Position export.

2013-10-15 Thread Dave Airlie
From: Fabian Bieler fabianbie...@fastmail.fm From the ARB_geometry_shader4 spec (section Geometry Shader outputs): The built-in special variable gl_Position is intended to hold the homogeneous vertex position. Writing gl_Position is optional. Signed-off-by: Dave Airlie airl...@redhat.com ---

[Mesa-dev] [PATCH 4/5] st/mesa: add geometry shader ubo support

2013-10-15 Thread Dave Airlie
This just adds the missing bits so the ubo tests don't crash. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_atom.c | 1 + src/mesa/state_tracker/st_atom.h | 1 + src/mesa/state_tracker/st_atom_constbuf.c | 17 + 3 files changed,

[Mesa-dev] [PATCH 5/5] st/mesa: handle layer and primitive id output and point size input

2013-10-15 Thread Dave Airlie
This fixes a number of piglit crashes when running on a hacked up llvmpipe. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_program.c | 12 1 file changed, 12 insertions(+) diff --git a/src/mesa/state_tracker/st_program.c

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-15 Thread Abdiel Janulgue
On Monday, October 14, 2013 10:50:24 AM Eric Anholt wrote: Abdiel Janulgue abdiel.janul...@linux.intel.com writes: One optimization idea that I had in mind a few months ago was to find a way to reduce emission of surface state objects. Currently, we rebuild surface states every time we

[Mesa-dev] [Bug 70123] Freeze caused by 'winsys/radeon: remove cs_queue_empty' commit

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70123 Christian König deathsim...@vodafone.de changed: What|Removed |Added Attachment #87341|0 |1 is

[Mesa-dev] Mesa drivers/GLX and fork

2013-10-15 Thread Christian König
Hi Marek, for the past few days I've been working on solving https://bugs.freedesktop.org/show_bug.cgi?id=70123. The basic problem is that compton forks itself into the background after initializing the X server connection and GLX context. What happens now is that only comptons main thread

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Johannes Obermayr
Am Montag, 14. Oktober 2013, 16:57:20 schrieb Francisco Jerez: Alexander von Gluck IV kallis...@unixzen.com writes: * As discussed on the mailing list, forced no-rtti breaks C++ public API's such as the Haiku C++ libGL.so * -fno-rtti *can* be still set however instead of blindly

Re: [Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Brian Paul
On 10/15/2013 02:38 AM, Dave Airlie wrote: Hi, I pulled Brian's patches and then hacked llvmpipe locally to claim GL 3.2, and ran piglit, fixed some of the obviously missing pieces and crashes. These aren't immediately going to expose any new functionality, but it might help if someone doing

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Alexander von Gluck IV
On Tue, 15 Oct 2013 17:04:26 +0200 Johannes Obermayr johannesoberm...@gmx.de wrote: Am Montag, 14. Oktober 2013, 16:57:20 schrieb Francisco Jerez: Alexander von Gluck IV kallis...@unixzen.com writes: * As discussed on the mailing list, forced no-rtti breaks C++ public API's such

Re: [Mesa-dev] Mesa drivers/GLX and fork

2013-10-15 Thread James Jones
In case it helps, we have always interpreted the spec as follows: -Forking duplicates process memory and FDs, including the display connection and the GLX context client-side state (and GL server state if direct rendering, but not X server state, such as the context XID), as messy as that is.

Re: [Mesa-dev] [PATCH 2/8] mesa: Add new functions and enums required by GL_ARB_sample_shading

2013-10-15 Thread Ian Romanick
On 10/14/2013 10:12 AM, Anuj Phogat wrote: New functions added by GL_ARB_sample_shading: glMinSampleShadingARB() New enums: GL_SAMPLE_SHADING_ARB GL_MIN_SAMPLE_SHADING_VALUE_ARB Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mapi/glapi/gen/ARB_sample_shading.xml | 19

[Mesa-dev] PATCH: R600: Fix handling of kernel arguments

2013-10-15 Thread Tom Stellard
Hi, The attached patches fix various bugs in the handling of kernel arguments in the R600 backend. The main problem with the old implementations was that it disagreed with clover on type size and alignment, so vector arguments were not being loaded correctly into the kernel. This series depends

Re: [Mesa-dev] [PATCH 3/8] mesa: Pass number of samples as a program state variable

2013-10-15 Thread Ian Romanick
On 10/14/2013 10:12 AM, Anuj Phogat wrote: Number of samples will be required in fragment shader program by new GLSL builtin uniform gl_NumSamples. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mesa/program/prog_statevars.c | 11 +++ src/mesa/program/prog_statevars.h |

[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 --- Comment #7 from Vinson Lee v...@freedesktop.org --- attachment 87648 fixes the build. Tested-by: Vinson Lee v...@freedesktop.org -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Ian Romanick
On 10/14/2013 10:12 AM, Anuj Phogat wrote: New builtins added by GL_ARB_sample_shading: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/glsl/builtin_variables.cpp | 11 +++

Re: [Mesa-dev] [PATCH 2/8] mesa: Add new functions and enums required by GL_ARB_sample_shading

2013-10-15 Thread Ian Romanick
On 10/14/2013 10:12 AM, Anuj Phogat wrote: diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 48fce36..8919852 100644 --- a/src/mapi/glapi/gen/gl_API.xml +++ b/src/mapi/glapi/gen/gl_API.xml @@ -8187,7 +8187,7 @@ xi:include href=ARB_draw_buffers_blend.xml

Re: [Mesa-dev] [PATCH 0/8] Implement GL_ARB_sample_shading on Intel hardware

2013-10-15 Thread Ian Romanick
On 10/14/2013 10:12 AM, Anuj Phogat wrote: Patches listed below implement the GL_ARB_sample_shading extension on Intel hardware = gen6. I verified the implementation with a number of piglit tests, currently under review on piglit mailing list. Observed no piglit, gles3 CTS regressions with

[Mesa-dev] [PATCH] scons: Fix build when rtti is disabled

2013-10-15 Thread Alexander von Gluck IV
* The rtti fix actually dug up a bug in the scons build scripts. * Autotools took the LLVM cpp and cxx flags, while scons only took the cpp flags. * This grabs the cxx flags and applies them where needed. * I'm going to run over this and clean things up further, however this fixes the build

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Alexander von Gluck IV
On Tue, 15 Oct 2013 17:04:26 +0200 Johannes Obermayr johannesoberm...@gmx.de wrote: Am Montag, 14. Oktober 2013, 16:57:20 schrieb Francisco Jerez: Alexander von Gluck IV kallis...@unixzen.com writes: * As discussed on the mailing list, forced no-rtti breaks C++ public API's such

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-15 Thread Eric Anholt
Abdiel Janulgue abdiel.janul...@linux.intel.com writes: On Monday, October 14, 2013 10:50:24 AM Eric Anholt wrote: Abdiel Janulgue abdiel.janul...@linux.intel.com writes: One optimization idea that I had in mind a few months ago was to find a way to reduce emission of surface state

Re: [Mesa-dev] [PATCH 7/7] i965: Move the common binding table offset code to brw_shader.cpp.

2013-10-15 Thread Eric Anholt
Paul Berry stereotype...@gmail.com writes: On 4 October 2013 15:44, Eric Anholt e...@anholt.net wrote: Now that both vec4 and fs are dynamically assigning offsets, a lot of the code is the same. --- Since next_binding_table_offset is only used to into

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Johannes Obermayr
Am Dienstag, 15. Oktober 2013, 12:19:40 schrieben Sie: On Tue, 15 Oct 2013 17:04:26 +0200 Johannes Obermayr johannesoberm...@gmx.de wrote: Am Montag, 14. Oktober 2013, 16:57:20 schrieb Francisco Jerez: Alexander von Gluck IV kallis...@unixzen.com writes: * As discussed on the

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Francisco Jerez
Johannes Obermayr johannesoberm...@gmx.de writes: Am Montag, 14. Oktober 2013, 16:57:20 schrieb Francisco Jerez: Alexander von Gluck IV kallis...@unixzen.com writes: * As discussed on the mailing list, forced no-rtti breaks C++ public API's such as the Haiku C++ libGL.so *

Re: [Mesa-dev] Mesa drivers/GLX and fork

2013-10-15 Thread Ian Romanick
On 10/15/2013 03:45 AM, Christian König wrote: Hi Marek, for the past few days I've been working on solving https://bugs.freedesktop.org/show_bug.cgi?id=70123. The basic problem is that compton forks itself into the background after initializing the X server connection and GLX context.

Re: [Mesa-dev] PATCH: R600: Fix handling of kernel arguments

2013-10-15 Thread Alex Deucher
Did you forget the attachments? On Tue, Oct 15, 2013 at 12:40 PM, Tom Stellard t...@stellard.net wrote: Hi, The attached patches fix various bugs in the handling of kernel arguments in the R600 backend. The main problem with the old implementations was that it disagreed with clover on type

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: New builtins added by GL_ARB_sample_shading: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/glsl/builtin_variables.cpp | 11 +++

Re: [Mesa-dev] [PATCH 2/8] mesa: Add new functions and enums required by GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: New functions added by GL_ARB_sample_shading: glMinSampleShadingARB() New enums: GL_SAMPLE_SHADING_ARB GL_MIN_SAMPLE_SHADING_VALUE_ARB Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/mapi/glapi/gen/ARB_sample_shading.xml | 19

[Mesa-dev] [PATCH] glsl: In update_max_array_access, fix interface instance check.

2013-10-15 Thread Paul Berry
In commit f878d20 (glsl: Update ir_variable::max_ifc_array_access properly), I accidentally used the wrong kind of check to determine whether the variable being accessed was an interface instance (I used var-get_interface_type() != NULL when I should have used var-is_interface_instance()). As a

Re: [Mesa-dev] [PATCH v2 1/3] i965: add FS_OPCODE_OVERWRITE_DST

2013-10-15 Thread Ian Romanick
On 10/09/2013 12:06 AM, Chia-I Wu wrote: From: Chia-I Wu o...@lunarg.com FS_OPCODE_OVERWRITE_DST is used to indicate that the destination register is (completely) overwritten. No code is emitted, but the liveness analysis can use it as a hint to add the destination register to DEF bitset.

Re: [Mesa-dev] [PATCH] i965/fs: Remove bogus field prog_data-dispatch_width.

2013-10-15 Thread Paul Berry
On 11 October 2013 16:18, Eric Anholt e...@anholt.net wrote: Paul Berry stereotype...@gmail.com writes: Despite the name, this field wasn't being set to the dispatch width at all; it was always 8. The only place it was used was that the constant buffer read length was aligned to it, and

Re: [Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Jose Fonseca
- Original Message - Hi, I pulled Brian's patches and then hacked llvmpipe locally to claim GL 3.2, and ran piglit, fixed some of the obviously missing pieces and crashes. These aren't immediately going to expose any new functionality, but it might help if someone doing r600g or

Re: [Mesa-dev] [PATCH] vbo: access VBO memory more efficiently when building display lists

2013-10-15 Thread Jose Fonseca
The change looks good as far as as I can tell. Jose - Original Message - Use GL_MAP_INVALIDATE_RANGE, UNSYNCHRONIZED and FLUSH_EXPLICIT flags when mapping VBOs during display list compilation. This mirrors what we do for immediate-mode VBO building in vbo_exec_vtx_map(). This

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Alexander von Gluck IV
On Tue, 15 Oct 2013 19:51:19 +0200 Johannes Obermayr johannesoberm...@gmx.de wrote: Am Dienstag, 15. Oktober 2013, 12:19:40 schrieben Sie: On Tue, 15 Oct 2013 17:04:26 +0200 Johannes Obermayr johannesoberm...@gmx.de wrote: Am Montag, 14. Oktober 2013, 16:57:20 schrieb Francisco Jerez:

Re: [Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Dave Airlie
On Tue, Oct 15, 2013 at 7:58 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Hi, I pulled Brian's patches and then hacked llvmpipe locally to claim GL 3.2, and ran piglit, fixed some of the obviously missing pieces and crashes. These aren't immediately going to

[Mesa-dev] [Bug 70435] [regression] Fast Texture Upload optimization results in corrupt rendering.

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70435 Chad Versace chad.vers...@linux.intel.com changed: What|Removed |Added CC|mesa-dev@lists.freedesktop. |

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: Implement the FS backend for new builtins added by the extension: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Anuj Phogat
On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick i...@freedesktop.org wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: New builtins added by GL_ARB_sample_shading: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH 3/8] mesa: Pass number of samples as a program state variable

2013-10-15 Thread Ian Romanick
On 10/15/2013 09:53 AM, Ian Romanick wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: @@ -852,6 +858,9 @@ append_token(char *dst, gl_state_index k) case STATE_TEXENV_COLOR: append(dst, texenv); break; + case STATE_NUM_SAMPLES: + append(dst, num.samples); +

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Ian Romanick
On 10/15/2013 01:50 PM, Anuj Phogat wrote: On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick i...@freedesktop.org wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: @@ -789,6 +794,12 @@ builtin_variable_generator::generate_fs_special_vars() if (state-AMD_shader_stencil_export_warn)

[Mesa-dev] [PATCH] mesa/tests: Add simple, dumb test for _mesa_program_state_string

2013-10-15 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com After some discussions about the correct way to update _mesa_program_state_string, I decided to make a unit test for the function. It turns out that the function didn't work quite the way I thought. The unit test proves that the code was already

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 Andreas Boll andreas.boll@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] FOSDEM14: Graphics DevRoom: call for speakers.

2013-10-15 Thread Luc Verhaegen
Hi, At FOSDEM on the 1st and 2nd of February 2014, there will be a graphics DevRoom. URL https://fosdem.org/2014/ The focus of this DevRoom is the same as the X.org DevRooms of yore; anything to do with graphics on open source software goes. This includes: * Graphics drivers: from display to

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 10:02 AM, Ian Romanick wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: New builtins added by GL_ARB_sample_shading: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Francisco Jerez
Johannes Obermayr johannesoberm...@gmx.de writes: Am Dienstag, 15. Oktober 2013, 12:19:40 schrieben Sie: On Tue, 15 Oct 2013 17:04:26 +0200 Johannes Obermayr johannesoberm...@gmx.de wrote: Am Montag, 14. Oktober 2013, 16:57:20 schrieb Francisco Jerez: Alexander von Gluck IV

Re: [Mesa-dev] [PATCH] build: remove forced -fno-rtti

2013-10-15 Thread Alexander von Gluck
On Tue, 2013-10-15 at 15:05 -0700, Francisco Jerez wrote: Johannes Obermayr johannesoberm...@gmx.de writes: Am Dienstag, 15. Oktober 2013, 12:19:40 schrieben Sie: On Tue, 15 Oct 2013 17:04:26 +0200 Johannes Obermayr johannesoberm...@gmx.de wrote: Am Montag, 14. Oktober 2013, 16:57:20

Re: [Mesa-dev] [RFC PATCH 0/5] Safer way to ralloc C++ objects.

2013-10-15 Thread Francisco Jerez
Francisco Jerez curroje...@riseup.net writes: This patch series tries out a different approach to allocating C++ objects from an ralloc context. It's independent to the last series I sent earlier today [1] -- which probably makes sense on its own because it's a more incremental improvement

Re: [Mesa-dev] [PATCH v2 1/3] i965: add FS_OPCODE_OVERWRITE_DST

2013-10-15 Thread Eric Anholt
Chia-I Wu olva...@gmail.com writes: From: Chia-I Wu o...@lunarg.com FS_OPCODE_OVERWRITE_DST is used to indicate that the destination register is (completely) overwritten. No code is emitted, but the liveness analysis can use it as a hint to add the destination register to DEF bitset. This

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: Implement the FS backend for new builtins added by the extension: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[] Signed-off-by: Anuj Phogat anuj.pho...@gmail.com ---

Re: [Mesa-dev] [PATCH 6/8] i965/gen6: Enable the features required for GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: - Enable GEN6_WM_MSDISPMODE_PERSAMPLE, GEN6_WM_POSOFFSET_SAMPLE, GEN6_WM_OMASK_TO_RENDER_TARGET as per extension's specification. - Don't enable GEN6_WM_16_DISPATCH_ENABLE when GEN6_WM_MSDISPMODE_PERSAMPLE is enabled. Refer SNB PRM Vol. 2, Part 1,

Re: [Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Roland Scheidegger
Am 15.10.2013 21:15, schrieb Dave Airlie: On Tue, Oct 15, 2013 at 7:58 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Hi, I pulled Brian's patches and then hacked llvmpipe locally to claim GL 3.2, and ran piglit, fixed some of the obviously missing pieces and

Re: [Mesa-dev] PATCH: R600: Fix handling of kernel arguments

2013-10-15 Thread Tom Stellard
On Tue, Oct 15, 2013 at 01:59:55PM -0400, Alex Deucher wrote: Did you forget the attachments? Yes I did. Here they are. -Tom On Tue, Oct 15, 2013 at 12:40 PM, Tom Stellard t...@stellard.net wrote: Hi, The attached patches fix various bugs in the handling of kernel arguments in the

Re: [Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Marek Olšák
GL_ARB_depth_clamp seems to be implemented in Draw and llvmpipe even passes the tests. Marek On Tue, Oct 15, 2013 at 9:15 PM, Dave Airlie airl...@gmail.com wrote: On Tue, Oct 15, 2013 at 7:58 PM, Jose Fonseca jfons...@vmware.com wrote: - Original Message - Hi, I pulled Brian's

Re: [Mesa-dev] [PATCH 7/8] i965/gen7: Enable the features required for GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/14/2013 10:12 AM, Anuj Phogat wrote: - Enable GEN7_WM_MSDISPMODE_PERSAMPLE, GEN7_WM_POSOFFSET_SAMPLE, GEN7_WM_OMASK_TO_RENDER_TARGET as per extension's specification. - Don't enable GEN7_WM_16_DISPATCH_ENABLE when GEN7_WM_MSDISPMODE_PERSAMPLE is enabled. Refer IVB PRM Vol. 2, Part 1,

Re: [Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Jose Fonseca
I'm pretty sure that depth clip disable is implemted too (pipe_rasterizer_state::depth_clip, in draw_context.c update_clip_flag() ). We merely forgot to advertise PIPE_CAP_DEPTH_CLIP_DISABLE flag on llvmpipe/softpipe/any-draw-based-driver. Roland started working on seamless cubemaps, so it's

[Mesa-dev] [PATCH] glsl: When disabling gl_PerVertex variables, check that mode matches.

2013-10-15 Thread Paul Berry
In commit 1b4a737 (glsl: Support redeclaration of VS and GS gl_PerVertex output), I added code to ensure that when an unnamed gl_PerVertex interface block is redeclared, any ir_variables that weren't included in the redeclaration are removed from the IR (and the symbol table). This ensures that

Re: [Mesa-dev] [PATCH] glsl: In update_max_array_access, fix interface instance check.

2013-10-15 Thread Matt Turner
On Tue, Oct 15, 2013 at 11:08 AM, Paul Berry stereotype...@gmail.com wrote: In commit f878d20 (glsl: Update ir_variable::max_ifc_array_access properly), I accidentally used the wrong kind of check to determine whether the variable being accessed was an interface instance (I used

[Mesa-dev] [PATCH] cso: fix incorrect sampler view count in cso_restore_sampler_views()

2013-10-15 Thread Brian Paul
During the recent bind_sampler_states() interface change in gallium we changed the CSO single_sampler_done() function so that if we were decreasing the number of sampler states bound in the driver, we'd null-out the extra/old sampler states to unbind them. See commit 1e2fbf265. However, we

[Mesa-dev] [PATCH 1/2] glsl: Call check_builtin_array_max_size when redeclaring gl_in.

2013-10-15 Thread Paul Berry
Normally when a built-in array (such as gl_ClipDistance) is redeclared, we call get_variable_being_redeclared() to do the redeclaration, and it in turn calls check_builtin_array_max_size() to make sure that the redeclared array size isn't too large. However when a built-in array is redeclared as

[Mesa-dev] [PATCH 2/2] glsl: Remove unused gl_PerVertex interface blocks.

2013-10-15 Thread Paul Berry
The GLSL 4.10 rules for redeclaration of built-in interface blocks (which we've chosen to regard as clarifications of GLSL 1.50) only require gl_PerVertex blocks to match in shaders that actually use those blocks. The easiest way to implement this is to detect situations where a compiled shader

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Anuj Phogat
On Tue, Oct 15, 2013 at 1:49 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: Implement the FS backend for new builtins added by the extension: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[]

[Mesa-dev] [PATCH] glsl: Treat layout-qualifier-id's as case-insensitive in desktop GLSL.

2013-10-15 Thread Paul Berry
In desktop GLSL, location qualifiers are case-insensitive. In GLSL ES, they are case-sensitive. This patch handles the difference by using a new function to match layout qualifiers, match_layout_qualifier(), which calls either strcmp() or strcasecmp() as appropriate. Fixes piglit tests: -

[Mesa-dev] [PATCH 1/2] i965: Print instructions' children during scheduling debugging.

2013-10-15 Thread Matt Turner
Useful for tracking down problems in dependency calculations. Scheduling debugging now prints: clock2, scheduled: linterp vgrf5, hw_reg2, hw_reg3, hw_reg0, child 0, 53 parents: fb_write (null), (null), (null), (null), child 1, 2 parents: tex vgrf4, vgrf5, (null), (null),

[Mesa-dev] [PATCH 2/2] i965/fs: Handle printing HW_REGS in dump_instruction().

2013-10-15 Thread Matt Turner
Scheduling debugging now prints: Instructions before scheduling (reg_alloc 1) 0: linterp vgrf20, hw_reg2, hw_reg3, hw_reg4, 1: linterp vgrf21, hw_reg2, hw_reg3, hw_reg4+16, --- src/mesa/drivers/dri/i965/brw_fs.cpp | 16 1 file changed, 16 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] cso: fix incorrect sampler view count in cso_restore_sampler_views()

2013-10-15 Thread Jose Fonseca
Looks good to me. Thanks for looking into this. Reviewed-by: Jose Fonseca jfons...@vmware.com Jose - Original Message - During the recent bind_sampler_states() interface change in gallium we changed the CSO single_sampler_done() function so that if we were decreasing the number of

Re: [Mesa-dev] mesa state tracker geometry shader bits

2013-10-15 Thread Jose Fonseca
Yep, as Marek said, llvmpipe passes all piglit's ARB_depth_clamp tests if PIPE_CAP_DEPTH_CLIP_DISABLE to 1. So I'll push this change soon. softpipe passes depth_clamp, but fails depth-clamp-range. No idea why. Jose - Original Message - I'm pretty sure that depth clip disable is

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Anuj Phogat
On Tue, Oct 15, 2013 at 3:28 PM, Kenneth Graunke kenn...@whitecape.org wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: Implement the FS backend for new builtins added by the extension: in vec2 gl_SamplePosition in int gl_SampleID in int gl_NumSamples out int gl_SampleMask[]

Re: [Mesa-dev] [PATCH 5/8] i965: Implement FS backend for ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 05:42 PM, Anuj Phogat wrote: [snip] + /* WM will be run in MSDISPMODE_PERSAMPLE. So, only SIMD8 mode will be Looking at the docs for 3DSTATE_PS, I believe that SIMD16 is allowed in some cases... SNB: Must be SIMD8 only. IVB: - 4x MSAA: Either SIMD8 or SIMD16 should work.

Re: [Mesa-dev] [PATCH] glsl: Treat layout-qualifier-id's as case-insensitive in desktop GLSL.

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 05:50 PM, Paul Berry wrote: In desktop GLSL, location qualifiers are case-insensitive. In GLSL ES, they are case-sensitive. This patch handles the difference by using a new function to match layout qualifiers, match_layout_qualifier(), which calls either strcmp() or

[Mesa-dev] [PATCH 6/6] i965: Fold brwInitVtbl() into brwCreateContext().

2013-10-15 Thread Kenneth Graunke
With most of the virtual functions gone, brwInitVtbl() is now tiny. Merging it into the caller allows us to delete the entire file. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/Makefile.sources | 1 - src/mesa/drivers/dri/i965/brw_context.c| 10 -

[Mesa-dev] [PATCH 1/6] i965: Un-virtualize brw_finish_batch().

2013-10-15 Thread Kenneth Graunke
Since the i915/i965 split, there's only one implementation of this virtual function. We may as well just call it directly. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/brw_vtbl.c | 22

[Mesa-dev] [PATCH 2/6] i965: Un-virtualize brw_new_batch().

2013-10-15 Thread Kenneth Graunke
Since the i915/i965 split, there's only one implementation of this virtual function. We may as well just call it directly. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_context.h | 1 - src/mesa/drivers/dri/i965/brw_vtbl.c | 42

[Mesa-dev] [PATCH 3/6] i965: Unindent the body of intelDestroyContext.

2013-10-15 Thread Kenneth Graunke
Having almost the entire body of the function indented one level for a check that should never happen seems silly. Just early return. Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- src/mesa/drivers/dri/i965/brw_context.c | 49 + 1 file changed, 25

[Mesa-dev] [PATCH 4/6] i965: Replace dri_bo_release with drm_intel_bo_unreference.

2013-10-15 Thread Kenneth Graunke
dri_bo_release is a helper function that calls drm_intel_bo_unreference but then also sets the pointer to NULL. This is unnecessary, since brw_destroy_context is called from intelDestroyContext, which also frees brw completely. If you're still trying to access them, you've got bigger problems.

[Mesa-dev] [PATCH 5/6] i965: Merge brw_destroy_context() into intelDestroyContext().

2013-10-15 Thread Kenneth Graunke
Now that i915 and i965 have been split, the separation between intelDestroyContext and brw_destroy_context is kind of arbitrary. This patch replaces the only brw-vtbl.destroy() call with the body of brw_destroy_context (the only implementation of that virtual function). Signed-off-by: Kenneth

Re: [Mesa-dev] [PATCH] gallium: new, unified pipe_context::set_sampler_views() function

2013-10-15 Thread Emil Velikov
On 08/10/13 01:23, Brian Paul wrote: The new function replaces four old functions: set_fragment/vertex/ geometry/compute_sampler_views(). Note: at this time, it's expected that the 'start' parameter will always be zero. --- Hello Brian, A couple of trivial questions Would you mind

Re: [Mesa-dev] [PATCH 4/8] glsl: Add new builtins required by GL_ARB_sample_shading

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 01:58 PM, Ian Romanick wrote: On 10/15/2013 01:50 PM, Anuj Phogat wrote: On Tue, Oct 15, 2013 at 10:02 AM, Ian Romanick i...@freedesktop.org wrote: On 10/14/2013 10:12 AM, Anuj Phogat wrote: @@ -789,6 +794,12 @@ builtin_variable_generator::generate_fs_special_vars() if

Re: [Mesa-dev] [PATCH] mesa/tests: Add simple, dumb test for _mesa_program_state_string

2013-10-15 Thread Kenneth Graunke
On 10/15/2013 02:04 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com After some discussions about the correct way to update _mesa_program_state_string, I decided to make a unit test for the function. It turns out that the function didn't work quite the way I thought.

[Mesa-dev] [Bug 70471] undefined reference to `typeinfo for llvm::format_object_base'

2013-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70471 Alexander von Gluck kallis...@unixzen.com changed: What|Removed |Added Status|NEW |RESOLVED