[Mesa-dev] [PATCH] i965/fs: Make the first pre-allocation heuristic be the post heuristic.

2013-11-19 Thread Eric Anholt
I recently made us try two different things that tried to reduce register pressure so that we would be more likely to allocate successfully. But now that we have the logic for trying two, we can make the first thing we try be the normal, not-prioritizing-register-pressure heuristic. This means on

[Mesa-dev] [PATCH] glsl: Use more portable bash invocation construct.

2013-11-19 Thread Vinson Lee
Fixes 'make check' on distros where bash is not at /bin/bash. Signed-off-by: Vinson Lee --- src/glsl/tests/lower_jumps/create_test_cases.py | 2 +- src/glsl/tests/lower_jumps/lower_breaks_1.opt_test | 2 +- src/glsl/tests/lower_jumps/lower_breaks_2.op

[Mesa-dev] [PATCH] glapi: Do not include dlfcn.h on Windows.

2013-11-19 Thread Vinson Lee
This patch fixes this MinGW build error. CC glapi_gentable.lo glapi_gentable.c:47:19: fatal error: dlfcn.h: No such file or directory Signed-off-by: Vinson Lee --- src/mapi/glapi/gen/gl_gentable.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/glapi/gen/gl_gentable.py b/

[Mesa-dev] [PATCH] glsl: Link glcpp with math library.

2013-11-19 Thread Vinson Lee
This patch fixes this build error with Oracle Solaris Studio. libtool: link: /opt/solarisstudio12.3/bin/cc -g -o glcpp/glcpp glcpp.o prog_hash_table.o ./.libs/libglcpp.a Undefined first referenced symbol in file sqrt

[Mesa-dev] [PATCH] gallivm: Ignore unknown file type in non-debug builds.

2013-11-19 Thread Vinson Lee
Fixes "Uninitialized pointer read" defect reported by Coverity. Signed-off-by: Vinson Lee --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c ind

[Mesa-dev] [PATCH 1/2] mesa: Fix texture target validation for glFramebufferTexture()

2013-11-19 Thread Paul Berry
Previously we were using the code path for validating glFramebufferTextureLayer(). But glFramebufferTexture() allows additional texture types. Fixes piglit tests: - spec/!OpenGL 3.2/layered-rendering/gl-layer-cube-map - spec/!OpenGL 3.2/layered-rendering/framebuffertexture Cc: "10.0" --- src/m

[Mesa-dev] [PATCH 2/2] mesa: Implement GL_FRAMEBUFFER_ATTACHMENT_LAYERED query.

2013-11-19 Thread Paul Berry
>From section 6.1.18 (Renderbuffer Object Queries) of the GL 3.2 spec, under the heading "If the value of FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE is TEXTURE, then": If pname is FRAMEBUFFER_ATTACHMENT_LAYERED, then params will contain TRUE if an entire level of a three-dimesional texture, cu

Re: [Mesa-dev] [PATCH 1/5] mesa: Track number of layers in layered framebuffers.

2013-11-19 Thread Chris Forbes
+ if (layer_count > 0) { + fb->NumLayers = layer_count; It seems like in the nonlayered case there will just be junk left in fb->NumLayers, which might trip people up in future? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists

[Mesa-dev] [PATCH 4/5] i965: Fix blorp clear of layered framebuffers.

2013-11-19 Thread Paul Berry
>From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec: When the Clear or ClearBuffer* commands are used to clear a layered framebuffer attachment, all layers of the attachment are cleared. This patch fixes the blorp clear path for color buffers. Fixes piglit test "spec/!Ope

[Mesa-dev] [PATCH 3/5] i965: refactor blorp clear code in preparation for layered clears.

2013-11-19 Thread Paul Berry
Cc: "10.0" --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 119 ++ 1 file changed, 66 insertions(+), 53 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp b/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp index d1933ce..c7f485e 100644 --- a/src/mes

[Mesa-dev] [PATCH 1/5] mesa: Track number of layers in layered framebuffers.

2013-11-19 Thread Paul Berry
In order to properly clear layered framebuffers, we need to know how many layers they have. The easiest way to do this is to record it in the gl_framebuffer struct when we check framebuffer completeness, just like we do for the Layered boolean. Cc: "10.0" --- src/mesa/main/fbobject.c | 21 +

[Mesa-dev] [PATCH 0/5] i965: Fix glClear of layered framebuffers.

2013-11-19 Thread Paul Berry
>From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec: When the Clear or ClearBuffer* commands are used to clear a layered framebuffer attachment, all layers of the attachment are cleared. Patch 1 adds logic to the framebuffer completeness check to record the number of layer

[Mesa-dev] [PATCH 2/5] meta: fix meta clear of layered framebuffers

2013-11-19 Thread Paul Berry
>From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec: When the Clear or ClearBuffer* commands are used to clear a layered framebuffer attachment, all layers of the attachment are cleared. This patch fixes meta clears to properly clear all layers of a layered framebuffer att

[Mesa-dev] [PATCH 5/5] i965: Fix fast clear of depth buffers.

2013-11-19 Thread Paul Berry
>From section 4.4.7 (Layered Framebuffers) of the GLSL 3.2 spec: When the Clear or ClearBuffer* commands are used to clear a layered framebuffer attachment, all layers of the attachment are cleared. This patch fixes the fast depth clear path. Fixes piglit test "spec/!OpenGL 3.2/layer

[Mesa-dev] [PATCH] r600g/compute: Add a work-around for flushing issues on Cayman

2013-11-19 Thread Tom Stellard
From: Tom Stellard https://bugs.freedesktop.org/show_bug.cgi?id=69321 CC: "10.0" --- src/gallium/drivers/r600/evergreen_compute.c | 4 src/gallium/drivers/r600/r600_hw_context.c | 4 +++- src/gallium/drivers/r600/r600_pipe.h | 10 ++ 3 files changed, 17 insertions(+),

[Mesa-dev] [PATCH] glsl: Fix cross-version linking between VS and GS.

2013-11-19 Thread Paul Berry
Previously, when attempting to link a vertex shader and a geometry shader that use different GLSL versions, we would sometimes generate a link error due to the implicit declaration of gl_PerVertex being different between the two GLSL versions. This patch fixes that problem by only requiring interf

[Mesa-dev] [PATCH v2] glsl: Prohibit illegal mixing of redeclarations inside/outside gl_PerVertex.

2013-11-19 Thread Paul Berry
>From section 7.1 (Built-In Language Variables) of the GLSL 4.10 spec: Also, if a built-in interface block is redeclared, no member of the built-in declaration can be redeclared outside the block redeclaration. We have been regarding this text as a clarification to the behaviour estab

[Mesa-dev] [PATCH] glsl: Prohibit illegal mixing of redeclarations inside/outside gl_PerVertex.

2013-11-19 Thread Paul Berry
>From section 7.1 (Built-In Language Variables) of the GLSL 4.10 spec: Also, if a built-in interface block is redeclared, no member of the built-in declaration can be redeclared outside the block redeclaration. We have been regarding this text as a clarification to the behaviour estab

Re: [Mesa-dev] [PATCH 0/1]: Preparing for ARB_viewport_array

2013-11-19 Thread Ian Romanick
On 10/31/2013 08:55 AM, Courtney Goeltzenleuchter wrote: > The following patch will begin the process of adding ARB_viewport_array > to Mesa. Next will be to extend the gl_context Scissor and Viewport > attributes to hold multiple viewport, scissor and scissor enables. > Then the DI side of ARB_vie

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-19 Thread Marek Olšák
st_viewport has nothing to do with the viewport. It's used if libGL doesn't expose __DRI_USE_INVALIDATE, so I don't think it's safe to remove it. If Driver::Viewport is about to removed, the code of st_viewport should be moved somewhere else. Marek On Wed, Nov 20, 2013 at 12:53 AM, Courtney Goel

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-19 Thread Brian Paul
On 11/19/2013 04:53 PM, Courtney Goeltzenleuchter wrote: The Gallium state tracker has a st_viewport that it puts into driver->Viewport function table. It's not clear to me how _NEW_VIEWPORT replaces the function of the Driver->Viewport call. Is it really safe to remove the driver->Viewport cal

Re: [Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-19 Thread Courtney Goeltzenleuchter
My apologies, I was distracted by other maters - updated commit follows. On Mon, Nov 11, 2013 at 2:21 PM, Chad Versace wrote: > On 11/08/2013 08:13 AM, Courtney Goeltzenleuchter wrote: > >> Support all levels of a supported texture format. >> >> Using 1024x1024, RGBA source, mipmap >>

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

2013-11-19 Thread Courtney Goeltzenleuchter
Support all levels of a supported texture format. Using 1024x1024, RGBA source, mipmap internal-format Before (MB/sec) mipmap (MB/sec) GL_RGBA 627.15 615.90 GL_RGB 456.35 611.53 512x512 GL_RGBA 597.00 619.95 GL_RGB 440.62

[Mesa-dev] [PATCH 1/2] i965: add XRGB to tiled_memcpy

2013-11-19 Thread Courtney Goeltzenleuchter
MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. This series builds on work from Frank Henigman to optimize the process of uploading a texture to the GPU. This series adds support for MESA_XRGB_ and full m

Re: [Mesa-dev] [PATCH] mesa: Change driver interface for ARB_viewport_array

2013-11-19 Thread Courtney Goeltzenleuchter
The Gallium state tracker has a st_viewport that it puts into driver->Viewport function table. It's not clear to me how _NEW_VIEWPORT replaces the function of the Driver->Viewport call. Is it really safe to remove the driver->Viewport call for Gallium? Courtney On Mon, Nov 4, 2013 at 12:31 PM,

[Mesa-dev] [v3 8/8] mesa: Update TexStorage to support ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Call TextureView helper function to set TextureView state appropriately for the TexStorage calls. Misc updates from review feedback. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/teximage.c | 6 ++ src/mesa/main/texstorage.c | 5 +++-- 2 files changed, 9 insertions(+), 2 dele

[Mesa-dev] [v3 2/8] mesa: Tracking for ARB_texture_view extension

2013-11-19 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..b7da884 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/ma

[Mesa-dev] [v3 6/8] mesa: Fill out ARB_texture_view entry points

2013-11-19 Thread Courtney Goeltzenleuchter
Add Mesa TextureView logic. Incorporate feedback on ARB_texture_view Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/textureview.c | 562 +++- 1 file changed, 561 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/textureview.c b/src/mesa/

[Mesa-dev] [v3 5/8] mesa: Add driver entry point for ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/drivers/common/driverfuncs.c | 3 +++ src/mesa/main/dd.h| 5 + 2 files changed, 8 insertions(+) diff --git a/src/mesa/drivers/common/driverfuncs.c b/src/mesa/drivers/common/driverfuncs.c index 5faa98a..f185688 100644

[Mesa-dev] [v3 0/8] Add ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
The following patches add the necessary functions to Mesa to support ARB_texture_view. These patches do not include the actual driver elements, just the device independent portion. This extension requires ARB_texture_storage. The extension supports one new API call, glTextureView and a handful of

[Mesa-dev] [v3 7/8] mesa: add texture_view helper function for TexStorage

2013-11-19 Thread Courtney Goeltzenleuchter
Add helper function to set texture_view state from TexStorage calls. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/textureview.c | 59 + src/mesa/main/textureview.h | 4 +++ 2 files changed, 63 insertions(+) diff --git a/src/mesa/main/te

[Mesa-dev] [v3 3/8] mesa: update texture object for ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Add state needed by glTextureView to the gl_texture_object. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/mtypes.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index f6ce6d0..82fcd61 100644 --- a/src/mesa/main/mtypes.h +++

[Mesa-dev] [v3 1/8] mesa: Add API definitions for ARB_texture_view

2013-11-19 Thread Courtney Goeltzenleuchter
Stub in glTextureView API call to go with the glTextureView API xml definition. Includes dispatch test for glTextureView Signed-off-by: Courtney Goeltzenleuchter --- src/mapi/glapi/gen/ARB_texture_view.xml | 23 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_A

[Mesa-dev] [v3 4/8] mesa: ARB_texture_view get parameters

2013-11-19 Thread Courtney Goeltzenleuchter
Add support for ARB_texture_view get parameters: GL_TEXTURE_VIEW_MIN_LEVEL GL_TEXTURE_VIEW_NUM_LEVELS GL_TEXTURE_VIEW_MIN_LAYER GL_TEXTURE_VIEW_NUM_LAYERS Incorporate feedback regarding when to allow query of GL_TEXTURE_IMMUTABLE_LEVELS. Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/mai

Re: [Mesa-dev] [PATCH] mapi: Add better visibility checks

2013-11-19 Thread Emil Velikov
On 19/11/13 21:27, Alexander von Gluck IV wrote: > On Tue, Nov 19, 2013 at 2:55 PM, Emil Velikov > wrote: >> On 17/11/13 18:11, Alexander von Gluck IV wrote: >>> * gl.h ensures gcc is 4.x or later before using >>>hidden visibility. This change matches that behaviour >>>and ensures better

[Mesa-dev] [PATCH V2] glsl: Improve error message when attemping assignment to unsized array

2013-11-19 Thread Timothy Arceri
V2: Return after error to avoid cascading error messages and removed redundant "to" from error message Signed-off-by: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index

Re: [Mesa-dev] [PATCH] mapi: Add better visibility checks

2013-11-19 Thread Alexander von Gluck IV
On Tue, Nov 19, 2013 at 2:55 PM, Emil Velikov wrote: On 17/11/13 18:11, Alexander von Gluck IV wrote: * gl.h ensures gcc is 4.x or later before using hidden visibility. This change matches that behaviour and ensures better compatibility for older gcc versions. Hi Alexander, AFAICS the

[Mesa-dev] [Bug 70920] [PIGLIT, radeonsi] SIGSEGV for shaders/glsl-fs-inline-explosion

2013-11-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70920 --- Comment #3 from Ian Romanick --- The cause has been known since the tests were added in 2010: commit 656cc65b2d3782c078d36342d0deec9886514520 Author: Luca Barbieri Date: Mon Sep 6 04:56:05 2010 +0200 add GLSL inlining/unroll limit te

Re: [Mesa-dev] [PATCH] mapi: Add better visibility checks

2013-11-19 Thread Emil Velikov
On 17/11/13 18:11, Alexander von Gluck IV wrote: > * gl.h ensures gcc is 4.x or later before using > hidden visibility. This change matches that behaviour > and ensures better compatibility for older gcc versions. Hi Alexander, AFAICS there are, currently, 11 cases of such ifdef spaghetti in m

Re: [Mesa-dev] [PATCH V3 06/13] vbo: Flesh out implementation of indirect draws

2013-11-19 Thread Chris Forbes
I've inherited a fair amount of sillyness from the original patches... sorry, I'll clean that up. On Wed, Nov 20, 2013 at 9:15 AM, Ian Romanick wrote: > With the issues below fixed, > > Reviewed-by: Ian Romanick > > On 11/09/2013 01:02 AM, Chris Forbes wrote: >> Based on part of Patch 2 of Chris

Re: [Mesa-dev] [PATCH] mesa: enable GL_TEXTURE_LOD_BIAS set/get

2013-11-19 Thread Ian Romanick
On 11/19/2013 01:05 AM, Tapani Pälli wrote: > Earlier comments suggest this was removed from GL core spec but it is > still there. Enabling makes 'texture_lod_bias_getter' Khronos > conformance tests pass, also removes some errors from Metro Last Light > game which is using this API. D'oh! > Sign

Re: [Mesa-dev] [PATCH] glsl: Improve error message when attemping assignment to unsized array

2013-11-19 Thread Ian Romanick
Other than the tiny nit below, Reviewed-by: Ian Romanick On 11/19/2013 03:13 AM, Timothy Arceri wrote: > Signed-off-by: Timothy Arceri > --- > src/glsl/ast_to_hir.cpp | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hi

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-11-19 Thread Eric Anholt
Keith Packard writes: > Eric Anholt writes: > >> Keith Packard writes: >> >>> libudev doesn't have a stable API/ABI, and if the application wants to use >>> one >>> version, we'd best not load another into libGL. >>> >>> Signed-off-by: Keith Packard >> >> This looks so simple it's definitely

Re: [Mesa-dev] [PATCH] st/mesa: fix GL_FEEDBACK mode inverted Y coordinate bug

2013-11-19 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Nov 19, 2013 at 9:11 PM, Brian Paul wrote: > We need to check the drawbuffer's orientation before inverting Y > coordinates. Fixes piglit feedback tests when running with the > -fbo option. > > Cc: "9.2" "10.0" > --- > src/mesa/state_tracker/st_cb_feedb

Re: [Mesa-dev] [PATCH] mesa: enable GL_TEXTURE_LOD_BIAS set/get

2013-11-19 Thread Eric Anholt
Eric Anholt writes: > Tapani Pälli writes: > >> Earlier comments suggest this was removed from GL core spec but it is >> still there. Enabling makes 'texture_lod_bias_getter' Khronos >> conformance tests pass, also removes some errors from Metro Last Light >> game which is using this API. > > Lo

Re: [Mesa-dev] [PATCH] mesa: enable GL_TEXTURE_LOD_BIAS set/get

2013-11-19 Thread Eric Anholt
Tapani Pälli writes: > Earlier comments suggest this was removed from GL core spec but it is > still there. Enabling makes 'texture_lod_bias_getter' Khronos > conformance tests pass, also removes some errors from Metro Last Light > game which is using this API. Looks to me like this makes things

Re: [Mesa-dev] [PATCH 15/15] i965/vs: Don't copy propagate into SEND-from-GRF messages.

2013-11-19 Thread Eric Anholt
Kenneth Graunke writes: > SEND can't deal with swizzles, source modifiers, and so on. This should > avoid problems with VS pull constant loads on Broadwell. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 3 +++ > 1 file changed, 3 insertion

Re: [Mesa-dev] [PATCH V3 06/13] vbo: Flesh out implementation of indirect draws

2013-11-19 Thread Ian Romanick
With the issues below fixed, Reviewed-by: Ian Romanick On 11/09/2013 01:02 AM, Chris Forbes wrote: > Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. > > Signed-off-by: Chris Forbes > --- > src/mesa/vbo/vbo_exec_array.c | 216 > ++

[Mesa-dev] [PATCH] st/mesa: fix GL_FEEDBACK mode inverted Y coordinate bug

2013-11-19 Thread Brian Paul
We need to check the drawbuffer's orientation before inverting Y coordinates. Fixes piglit feedback tests when running with the -fbo option. Cc: "9.2" "10.0" --- src/mesa/state_tracker/st_cb_feedback.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_t

Re: [Mesa-dev] [PATCH] u_gen_mipmap: Use untampered cubemap texture coords when generating mipmaps.

2013-11-19 Thread Brian Paul
On 11/19/2013 11:54 AM, jfons...@vmware.com wrote: From: José Fonseca It's not necessary to scale down cubemap texture coords when generating mipmaps: we are doing a 2x minification therefore it's guaranteed that the texture coords will always be at least 1 texel away of the edges. Scaling dow

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-11-19 Thread Keith Packard
Eric Anholt writes: > Keith Packard writes: > >> libudev doesn't have a stable API/ABI, and if the application wants to use >> one >> version, we'd best not load another into libGL. >> >> Signed-off-by: Keith Packard > > This looks so simple it's definitely worth dropping udev, but I'd like >

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-19 Thread Chris Forbes
OK, I'll go back to allowing zero. It's silly but harmless. On Wed, Nov 20, 2013 at 8:29 AM, Ian Romanick wrote: > On 11/09/2013 01:02 AM, Chris Forbes wrote: >> Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. >> >> V3: - Disallow primcount==0 for DrawMulti*Indirect. Th

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-19 Thread Ian Romanick
On 11/09/2013 01:02 AM, Chris Forbes wrote: > Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. > > V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec > contradicts itself on this, but the GL4.3 spec disallows it. > > - Make it clear that the

Re: [Mesa-dev] [PATCH V3 01/13] mesa: add indirect drawing buffer parameter to draw functions

2013-11-19 Thread Ian Romanick
Patches 1, 3, and 4 are Reviewed-by: Ian Romanick I sent a separate reply to patch 2. On 11/09/2013 01:02 AM, Chris Forbes wrote: > From: Christoph Bumiller > > Split from patch implementing ARB_draw_indirect. > > v2: Const-qualify the struct gl_buffer_object *indirect argument. > v3: Fix up

Re: [Mesa-dev] [PATCH V3 02/13] glapi: add plumbing for GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2013-11-19 Thread Ian Romanick
On 11/09/2013 01:02 AM, Chris Forbes wrote: > Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. > > Signed-off-by: Chris Forbes I assume 'make check' actually passes? :) With the change below, Reviewed-by: Ian Romanick . > --- > src/mapi/glapi/gen/ARB_draw_indirect.x

Re: [Mesa-dev] [PATCH V3 05/13] mesa: Add validation helpers for new indirect draws

2013-11-19 Thread Ian Romanick
On 11/12/2013 12:13 PM, Kenneth Graunke wrote: > On 11/09/2013 01:02 AM, Chris Forbes wrote: >> Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. >> >> V3: - Disallow primcount==0 for DrawMulti*Indirect. The extension spec >> contradicts itself on this, but the GL4.3

Re: [Mesa-dev] [PATCH] mesa: enable GL_TEXTURE_LOD_BIAS set/get

2013-11-19 Thread Kenneth Graunke
On 11/19/2013 01:05 AM, Tapani Pälli wrote: > Earlier comments suggest this was removed from GL core spec but it is > still there. Enabling makes 'texture_lod_bias_getter' Khronos > conformance tests pass, also removes some errors from Metro Last Light > game which is using this API. > > Signed-of

[Mesa-dev] [Bug 71506] indirect_glx.c:350: multiple definition of `indirect_create_context'

2013-11-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71506 --- Comment #14 from Emil Velikov --- Might be a good idea to pick this up for the 10.0 branch ? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mes

[Mesa-dev] [PATCH] u_gen_mipmap: Use untampered cubemap texture coords when generating mipmaps.

2013-11-19 Thread jfonseca
From: José Fonseca It's not necessary to scale down cubemap texture coords when generating mipmaps: we are doing a 2x minification therefore it's guaranteed that the texture coords will always be at least 1 texel away of the edges. Scaling down can actually be harmful, as it may cause artefacts

Re: [Mesa-dev] [PATCH] Don't use libudev for glx/dri3

2013-11-19 Thread Eric Anholt
Keith Packard writes: > libudev doesn't have a stable API/ABI, and if the application wants to use one > version, we'd best not load another into libGL. > > Signed-off-by: Keith Packard This looks so simple it's definitely worth dropping udev, but I'd like to see the udev code actually dropped

Re: [Mesa-dev] sampler arrays indexed with non-constant expressions

2013-11-19 Thread Ian Romanick
On 11/19/2013 01:16 AM, Erik Faye-Lund wrote: > On Mon, Nov 18, 2013 at 9:04 PM, Paul Berry wrote: >> On 17 November 2013 00:24, Victor Luchitz wrote: >>> If compiler actually attempted to unroll the loop above, it would notice >>> that the does compile correctly. Instead it just emits and error

Re: [Mesa-dev] [PATCH 09/15] i965: Add a new representation for Broadwell shader instructions.

2013-11-19 Thread Eric Anholt
Kenneth Graunke writes: > On 11/18/2013 03:22 PM, Kenneth Graunke wrote: >> On 11/18/2013 12:27 PM, Eric Anholt wrote: >>> Kenneth Graunke writes: >>> Broadwell significantly changes the EU instruction encoding. Many of the fields got moved to different bit positions; some even got sp

Re: [Mesa-dev] [PATCH] mapi: Add better visibility checks

2013-11-19 Thread Alexander von Gluck IV
On Sun, 17 Nov 2013 12:11:41 -0600 Alexander von Gluck IV wrote: > * gl.h ensures gcc is 4.x or later before using > hidden visibility. This change matches that behaviour > and ensures better compatibility for older gcc versions. > --- > src/mapi/glapi/glapi.h |2 +- > src/mapi/u_compile

Re: [Mesa-dev] [PATCH] svga: improve check for 3D compressed textures

2013-11-19 Thread Jose Fonseca
- Original Message - > This is basically a a respin of f1dfcf4bce35e6796f873d9a00103b280da81e4c > per Jose's suggestion. > > Just set the SVGA3dSurfaceFormatCaps flags for 3D and cube textures > when checking the texture format capabilities. This will filter out > unsupported combinatio

[Mesa-dev] [PATCH] glXCreatePbuffer and glXCreateGLXPbufferSGIX set drawable to None instead of create pixmap. dri2GetBuffersWithFormat allocates resource for a pbuffer.

2013-11-19 Thread Daniel Czarnowski
--- src/glx/dri2_glx.c| 99 +++-- src/glx/glx_pbuffer.c |8 ++-- 2 files changed, 98 insertions(+), 9 deletions(-) diff --git a/src/glx/dri2_glx.c b/src/glx/dri2_glx.c index 7ce5775..d0f284d 100644 --- a/src/glx/dri2_glx.c +++ b/src/glx/dri2_g

[Mesa-dev] [PATCH] svga: improve check for 3D compressed textures

2013-11-19 Thread Brian Paul
This is basically a a respin of f1dfcf4bce35e6796f873d9a00103b280da81e4c per Jose's suggestion. Just set the SVGA3dSurfaceFormatCaps flags for 3D and cube textures when checking the texture format capabilities. This will filter out unsupported combinations like 3D+DXT. --- src/gallium/drivers/sv

[Mesa-dev] [Bug 70766] Run-time link error in swrast_dri.so

2013-11-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70766 --- Comment #3 from Jan Vesely --- (In reply to comment #2) > did you use cmake to compile llvm? check this patch: http://www.mail-archive.com/mesa-dev@lists.freedesktop.org/msg45916.html -- You are receiving this mail because: You are the ass

[Mesa-dev] [Bug 70766] Run-time link error in swrast_dri.so

2013-11-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70766 --- Comment #2 from Jan Vesely --- did you use cmake to compile llvm? -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Christian König
Am 19.11.2013 16:19, schrieb Alex Deucher: On Tue, Nov 19, 2013 at 5:05 AM, Christian König wrote: From: Christian König The alignment of a virtual memory area must always be at least 4096 bytes. It only worked because size was aligned to 4096 outside of the function. Signed-off-by: Christi

[Mesa-dev] [Bug 71506] indirect_glx.c:350: multiple definition of `indirect_create_context'

2013-11-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71506 Jon TURNEY changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Alex Deucher
On Tue, Nov 19, 2013 at 5:05 AM, Christian König wrote: > From: Christian König > > The alignment of a virtual memory area must always be at least 4096 bytes. > > It only worked because size was aligned to 4096 outside of the function. > > Signed-off-by: Christian König CC the 9.2 and 10.0 bran

Re: [Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Christian König
Am 19.11.2013 14:41, schrieb Marek Olšák: On Tue, Nov 19, 2013 at 11:05 AM, Christian König wrote: From: Christian König The alignment of a virtual memory area must always be at least 4096 bytes. It only worked because size was aligned to 4096 outside of the function. Signed-off-by: Christi

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-19 Thread Christian König
For merging the patches for new hardware and/or features I agree on the process of merging things bottom up. (e.g kernel first, then libdrm, mesa last). But to give reasons for the merge into Linus tree it's usually better to have a "big picture" you can validate the code against. So I think t

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-19 Thread Marek Olšák
Having patches on a mailing list is good enough, but generally if people *trust* you that you will have an open userspace, that's good enough too if you have people's trust. In my opinion, the required kernel code must land in Linus's tree first. If it's not there, it's like it didn't exist at all

[Mesa-dev] [Bug 70920] [PIGLIT, radeonsi] SIGSEGV for shaders/glsl-fs-inline-explosion

2013-11-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70920 Kai changed: What|Removed |Added CC||mesa-dev@lists.freedesktop. |

Re: [Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Marek Olšák
On Tue, Nov 19, 2013 at 11:05 AM, Christian König wrote: > From: Christian König > > The alignment of a virtual memory area must always be at least 4096 bytes. > > It only worked because size was aligned to 4096 outside of the function. > > Signed-off-by: Christian König > --- > src/gallium/win

Re: [Mesa-dev] [PATCH] tests: Fix make check for out of tree builds.

2013-11-19 Thread Jon TURNEY
On 11/11/2013 22:06, Matt Turner wrote: > On Mon, Nov 11, 2013 at 12:18 PM, Rico Schüller wrote: >> Signed-off-by: Rico Schüller >> --- >> src/mapi/shared-glapi/tests/Makefile.am | 1 + >> src/mesa/main/tests/Makefile.am | 1 + >> 2 Dateien geändert, 2 Zeilen hinzugefügt(+) >> >> diff --

[Mesa-dev] [PATCH] glsl: Improve error message when attemping assignment to unsized array

2013-11-19 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- src/glsl/ast_to_hir.cpp | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 76b256c..73be274 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -696,9 +696,14 @@ v

[Mesa-dev] [PATCH] winsys/radeon: cleanup virtual memory nonsense

2013-11-19 Thread Christian König
From: Christian König The alignment of a virtual memory area must always be at least 4096 bytes. It only worked because size was aligned to 4096 outside of the function. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 37 +-- src/gall

Re: [Mesa-dev] sampler arrays indexed with non-constant expressions

2013-11-19 Thread Erik Faye-Lund
On Mon, Nov 18, 2013 at 9:04 PM, Paul Berry wrote: > On 17 November 2013 00:24, Victor Luchitz wrote: >> If compiler actually attempted to unroll the loop above, it would notice >> that the does compile correctly. Instead it just emits and error and in my >> opinion, contradicts the comment above

[Mesa-dev] [Bug 70766] Run-time link error in swrast_dri.so

2013-11-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70766 --- Comment #1 from octoploid --- Similar thing here: (EE) AIGLX error: dlopen of /usr/lib64/dri/r600_dri.so failed (/usr/lib64/dri/r600_dri.so: undefined symbol: _ZTIN4llvm18format_object_baseE) (EE) AIGLX error: dlopen of /usr/lib64/dri/swras

[Mesa-dev] [PATCH] mesa: enable GL_TEXTURE_LOD_BIAS set/get

2013-11-19 Thread Tapani Pälli
Earlier comments suggest this was removed from GL core spec but it is still there. Enabling makes 'texture_lod_bias_getter' Khronos conformance tests pass, also removes some errors from Metro Last Light game which is using this API. Signed-off-by: Tapani Pälli --- src/mesa/main/texparam.c | 15 +

Re: [Mesa-dev] rules for merging patches to libdrm

2013-11-19 Thread Thierry Reding
On Mon, Nov 18, 2013 at 01:38:55PM -0500, Jerome Glisse wrote: > On Mon, Nov 18, 2013 at 05:41:50PM +0100, Thierry Reding wrote: > > On Mon, Nov 18, 2013 at 11:21:36AM -0500, Rob Clark wrote: > > > On Mon, Nov 18, 2013 at 10:23 AM, Thierry Reding > > > wrote: > > > > On Mon, Nov 18, 2013 at 10:17: