Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-04 Thread Timothy Arceri
On Fri, 2014-04-04 at 17:40 -0700, Ian Romanick wrote: > On 04/03/2014 05:31 PM, Dieter Nützel wrote: > > Am 03.04.2014 22:53, schrieb Ian Romanick: > >> On 04/03/2014 07:35 AM, Dieter Nützel wrote: > >>> Am 03.04.2014 04:16, schrieb Ian Romanick: > On 04/02/2014 06:13 PM, Dieter Nützel wrote:

Re: [Mesa-dev] libxatracker: automake and spurious symbols

2014-04-04 Thread Emil Velikov
On 01/04/14 01:32, Emil Velikov wrote: > On 29/03/14 14:24, Kai Wasserbäch wrote: >> Hi Emil, >> Emil Velikov schrieb am 29.03.2014 14:21: >>> On 29/03/14 12:37, Kai Wasserbäch wrote: I saw one of your patches currently in review touching the Makefile.am of libxatracker. Can you squeeze i

[Mesa-dev] [PATCH 00/16] Yet another round of exported symbols cleanup

2014-04-04 Thread Emil Velikov
Hi all, This is the final round cleaning up the exported symbols mayhem for gallium. IIRC the only place in mesa that needs some love is src/mapi. Highlights: - Drops __dri2ConfigOptions for both classic and gallium drivers. Previously done for gallium drivers (by Maarten), and after going throu

[Mesa-dev] [PATCH 15/16] targets/omx: use GALLIUM_VIDEO_CFLAGS

2014-04-04 Thread Emil Velikov
Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/targets/r600/omx/Makefile.am | 8 +--- src/gallium/targets/radeonsi/omx/Makefile.am | 8 +--- 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/src/gallium/targets/r600/omx/Makefile.am b/src/gallium/target

[Mesa-dev] [PATCH 02/16] targets/pipe-loader: drop driver_descriptor symbol from swrast

2014-04-04 Thread Emil Velikov
The symbol is used for hardware only drivers. For swrast the loader uses swrast_create_screen. Add VISIBILITY_CFLAGS while we're here. Cc: Francisco Jerez Signed-off-by: Emil Velikov --- src/gallium/targets/pipe-loader/Makefile.am | 3 ++- src/gallium/targets/pipe-loader/pipe_swrast.c | 3 ---

[Mesa-dev] [PATCH 04/16] targets/xa: limit the amount of exported symbols

2014-04-04 Thread Emil Velikov
In the presence of LLVM the final library exports every symbol from the llvm namespace. Resolve this by using a version script (w/o the version/name tag). Considering that there are only ~35 symbols, explicitly list them to minimize the chances of rogue symbols sneaking in. Signed-off-by: Emil Ve

[Mesa-dev] [PATCH 11/16] targets/egl-static: freshen up the version script

2014-04-04 Thread Emil Velikov
Namely drop the version/name tag of the exported symbol, and rename the filename to egl.sym. Signed-off-by: Emil Velikov --- src/gallium/targets/egl-static/Makefile.am | 4 ++-- src/gallium/targets/egl-static/egl.link| 3 --- src/gallium/targets/egl-static/egl.sym | 6 ++ 3 files cha

[Mesa-dev] [PATCH 14/16] targets/pipe-loader: cleanup version-script

2014-04-04 Thread Emil Velikov
Drop the version/name tag from the script as it was never meant to be there. Add swrast_create_screen as it is used when loading swrast. Rename the file to pipe.sym. Cc: Francisco Jerez Signed-off-by: Emil Velikov --- src/gallium/targets/pipe-loader/Makefile.am | 4 ++-- src/gallium/targets/pip

[Mesa-dev] [PATCH 06/16] targets/dri: use a single version script to restict exported symbols

2014-04-04 Thread Emil Velikov
Rather than having multiple (almost) identical version scripts use a single one. Cc: Maarten Lankhorst Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/Automake.inc | 6 ++ src/gallium/state_trackers/dri/dri.link | 5 - src/gallium/target

[Mesa-dev] [PATCH 08/16] targets/vdpau: use version script to limit the exported symbols

2014-04-04 Thread Emil Velikov
Using export-symbols-regex is the least desirable method of restricting the exported symbols, as is completely messes up with the symbol table. Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/Automake.inc | 2 +- src/gallium/targets/r600/vdpau/Makefile.am

[Mesa-dev] [PATCH 16/16] targets/omx: add nouveau target

2014-04-04 Thread Emil Velikov
Signed-off-by: Emil Velikov --- configure.ac| 3 +- src/gallium/targets/Makefile.am | 4 +++ src/gallium/targets/omx-nouveau/Makefile.am | 43 + src/gallium/targets/omx-nouveau/target.c| 18 4 files changed

[Mesa-dev] [PATCH 13/16] targets/opencl: hide all the exported llvm/clang mayhem... hopefully

2014-04-04 Thread Emil Velikov
Both llvm and clang polute the exported symbol table, as soon as we try to link with either one. Other than those two everything else looks good (clean). Cc: Tom Stellard Cc: Francisco Jerez Signed-off-by: Emil Velikov --- src/gallium/targets/opencl/Makefile.am | 1 + src/gallium/targets/openc

[Mesa-dev] [PATCH 05/16] targets/xvmc: limit the amount of exported symbols

2014-04-04 Thread Emil Velikov
In the presence of LLVM the final library exports every symbol from the llvm namespace. Resolve this by using a version script (w/o the version/name tag). Considering that there are only ~25 symbols, explicitly list them to minimize the chances of rogue symbols sneaking in. Drop the *winsys_creat

[Mesa-dev] [PATCH 07/16] targets/omx: use version script to limit amount of exported symbols

2014-04-04 Thread Emil Velikov
Using export-symbols-regex is the least desirable method of restricting the exported symbols, as is completely messes up with the symbol table. radeon_drm_winsys_create is not needed, avoid exporting it. Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/Automake.inc

[Mesa-dev] [PATCH 09/16] targets/gbm: add version-script to limit exported symbols

2014-04-04 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/targets/gbm/Makefile.am | 1 + src/gallium/targets/gbm/gbm.sym | 6 ++ 2 files changed, 7 insertions(+) create mode 100644 src/gallium/targets/gbm/gbm.sym diff --git a/src/gallium/targets/gbm/Makefile.am b/src/gallium/targets/gbm/Makefile.am

[Mesa-dev] [PATCH 03/16] targets/osmesa: hide osmesa_create_screen

2014-04-04 Thread Emil Velikov
The symbol is not meant to be exported, and its presence was only a side effect due to the missing visibility flags. Signed-off-by: Emil Velikov --- src/gallium/targets/osmesa/Makefile.am | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/targets/osmesa/Makefile.a

[Mesa-dev] [PATCH 10/16] targets/osmesa: limit the amount of exported symbols

2014-04-04 Thread Emil Velikov
Explicitly list all the OSMesa* symbols and wildcast the gl* ones. Cc: Brian Paul Signed-off-by: Emil Velikov --- src/gallium/targets/osmesa/Makefile.am | 1 + src/gallium/targets/osmesa/osmesa.sym | 18 ++ 2 files changed, 19 insertions(+) create mode 100644 src/gallium/targ

[Mesa-dev] [PATCH 12/16] targets/libgl-xlib: hide all the exported symbol mayhem

2014-04-04 Thread Emil Velikov
TODO: - properly cleanup all the _glapi* symbols - XMesa* -- no sign of the header even being distributed -- mesa-demos uses it to the point that the relevant code is not compiled -- the classic driver (x11) exibits the same issues Brian, Do you know of any users of the XMesa* functions outs

[Mesa-dev] [PATCH 01/16] dri_util: keep __dri2ConfigOptions symbol private

2014-04-04 Thread Emil Velikov
The symbol was added with commit 45e2b51c853(DRI2/GLX: check for vblank_mode in DRI2 GLX code) but was never used as such according to git log. Possibly it was marked as public due to confusion with __driConfigOptions which was used for dri1 drivers. Cc: Jesse Barnes Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe->blit (v2)

2014-04-04 Thread Roland Scheidegger
Am 05.04.2014 03:10, schrieb Marek Olšák: > From: Marek Olšák > > This replaces u_gen_mipmap with an extremely simple implementation based > on pipe->blit. st/mesa is also cleaned up. > > Pros: > - less code > - correct mipmap generation for NPOT 3D textures (u_blitter uses a better > formula)

[Mesa-dev] [PATCH 2/2] gallium/u_gen_mipmap: rewrite using pipe->blit (v2)

2014-04-04 Thread Marek Olšák
From: Marek Olšák This replaces u_gen_mipmap with an extremely simple implementation based on pipe->blit. st/mesa is also cleaned up. Pros: - less code - correct mipmap generation for NPOT 3D textures (u_blitter uses a better formula) - queries are not affected by mipmap generation if drivers

[Mesa-dev] [PATCH 1/2] st/mesa: properly implement MapTextureImage with multiple mapped slices (v2)

2014-04-04 Thread Marek Olšák
From: Marek Olšák This is needed by _mesa_generate_mipmap. This adds an array of pipe_transfers to st_texture_image. Each transfer is for mapping a single layer. v2: allocate the array of transfers on demand --- src/mesa/state_tracker/st_cb_texture.c | 28 --- src/mesa/

Re: [Mesa-dev] Mesa 10.2 release plan strawman

2014-04-04 Thread Matt Turner
On Fri, Apr 4, 2014 at 5:18 PM, Ian Romanick wrote: > Fast forwarding 3 months from the 10.1 release (March 4th, planned for > February 28th) is May 30th. I'd like to propose the following set of dates: > > May 2nd: Feature freeze / 10.2 branch created. > > May 16th: RC1 Same comment as last tim

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Fix off-by-one in saturate propagation.

2014-04-04 Thread Matt Turner
On Fri, Apr 4, 2014 at 5:32 PM, Ian Romanick wrote: > Series is > > Reviewed-by: Ian Romanick > > Two questions... > > Are there piglit tests that exhibit the problems fixed by this series? Nope. It's the problem of figuring out how to write GLSL to generate just the right set of instructions, w

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-04 Thread Ian Romanick
On 04/03/2014 05:31 PM, Dieter Nützel wrote: > Am 03.04.2014 22:53, schrieb Ian Romanick: >> On 04/03/2014 07:35 AM, Dieter Nützel wrote: >>> Am 03.04.2014 04:16, schrieb Ian Romanick: On 04/02/2014 06:13 PM, Dieter Nützel wrote: > Am 03.04.2014 01:19, schrieb Ian Romanick: >> On 04/02

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Fix off-by-one in saturate propagation.

2014-04-04 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick Two questions... Are there piglit tests that exhibit the problems fixed by this series? Do any of these need to go back to stable? (I'm assuming not...) On 04/03/2014 05:30 PM, Matt Turner wrote: > ip needs to be initialized to start_ip - 1, since the first

[Mesa-dev] Mesa 10.2 release plan strawman

2014-04-04 Thread Ian Romanick
Fast forwarding 3 months from the 10.1 release (March 4th, planned for February 28th) is May 30th. I'd like to propose the following set of dates: May 2nd: Feature freeze / 10.2 branch created. May 16th: RC1 May 23rd: RC2 May 30th: 10.2 final release Does this plan sound reasonable? _

Re: [Mesa-dev] [PATCH] glsl: Optimize (x + y cmp 0) into (x cmp -y).

2014-04-04 Thread Ian Romanick
And we don't need to explicitly handle (x - y cmp 0) becuase we've already converted x - y into x + -y. Reviewed-by: Ian Romanick On 04/04/2014 03:27 PM, Matt Turner wrote: > Cuts a small handful of instructions in Serious Sam 3: > > instructions in affected programs: 4692 -> 4666 (-0.55%)

Re: [Mesa-dev] [PATCH 00/16] DRI*extension cleanups v3

2014-04-04 Thread Ian Romanick
On 03/16/2014 06:48 AM, Emil Velikov wrote: > Hi all, > > Here is the third iteration of some DRI*extension cleanup patches. > > This revision adds some minor updates and squashes the patches into > a shorter patchset. > > The previous revision can be found at > http://lists.freedesktop.org/arch

Re: [Mesa-dev] [PATCH 07/16] glx/tests: explicitly set __DRI2rendererQueryExtension members

2014-04-04 Thread Ian Romanick
Vinson: Does this build on C++ compilers you use to build GLX bits? On 03/16/2014 06:48 AM, Emil Velikov wrote: > While we're here use the typcast'ed name and constify. > > Signed-off-by: Emil Velikov > --- > src/glx/tests/query_renderer_implementation_unittest.cpp | 8 > 1 file chang

[Mesa-dev] [PATCH 2/2] i965/vec4: Let DCE eliminate dead writes in other basic blocks.

2014-04-04 Thread Matt Turner
We previously stopped searching for unread writes after encountering control flow, but we can instead just search backwards until we hit control flow. instructions in affected programs: 22854 -> 22194 (-2.89%) --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 8 1 file changed, 4 insertio

[Mesa-dev] [PATCH 1/2] i965/gs: Add dummy source to prepare_channel_masks instruction.

2014-04-04 Thread Matt Turner
The generator uses its destination as a source implicitly, which breaks some assumptions in dead code elimination. Giving the instruction a source allows us to reason about it better. --- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[Mesa-dev] [PATCH] glsl: Optimize (x + y cmp 0) into (x cmp -y).

2014-04-04 Thread Matt Turner
Cuts a small handful of instructions in Serious Sam 3: instructions in affected programs: 4692 -> 4666 (-0.55%) --- src/glsl/opt_algebraic.cpp | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/glsl/opt_algebraic.cpp b/src/glsl/opt_algebraic.cpp index 8494bd9..2db

Re: [Mesa-dev] [PATCH 2/4] glapi: Fix build break in 'make check' on non-shared-glapi builds

2014-04-04 Thread Dieter Nützel
Am 04.04.2014 04:06, schrieb Timothy Arceri: On Friday, 4 April 2014 11:31 AM, Dieter Nützel wrote: Mesa 10.2.0-devel (git-c6050ce) /opt/ogl-samples> ./build/release/gl-320-primitive-sprite Mesa warning: failed to remap glDebugMessageCallbackARB Mesa warning: failed to remap glDebugMessageCont

Re: [Mesa-dev] [WIP 08/13] glsl/linker: GL_ARB_explicit_uniform_location support

2014-04-04 Thread Ian Romanick
On 03/27/2014 11:45 PM, Tapani Pälli wrote: > Patch refactors the existing uniform processing so explicit locations > are taken in to account during variable processing. These locations > are temporarily stored in gl_uniform_storage before actual locations > are set. > > The 'remap_location' varia

Re: [Mesa-dev] [WIP 04/13] mesa: add a storage for inactive/removed uniform variables

2014-04-04 Thread Ian Romanick
I've been thinking about this a bit, and I think this is more complex than it needs to be. I don't have a complete design, but here are some thoughts on the matter. When linking is all done, we just want the UniformRemapTable. It's entires should have one of three kinds of values: - NULL: Inva

Re: [Mesa-dev] [WIP 11/13] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-04-04 Thread Ian Romanick
On 04/04/2014 02:42 PM, Ian Romanick wrote: > On 03/27/2014 11:45 PM, Tapani Pälli wrote: >> Patch adds a preprocessor define for the extension and stores >> explicit location data for uniforms during AST->HIR conversion. >> It also sets layout token to be available when having the >> extension in

Re: [Mesa-dev] [WIP 11/13] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-04-04 Thread Ian Romanick
On 04/04/2014 02:51 PM, Matt Turner wrote: > On Fri, Apr 4, 2014 at 2:42 PM, Ian Romanick wrote: >> On 03/27/2014 11:45 PM, Tapani Pälli wrote: >>> Patch adds a preprocessor define for the extension and stores >>> explicit location data for uniforms during AST->HIR conversion. >>> It also sets lay

Re: [Mesa-dev] [WIP 11/13] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-04-04 Thread Matt Turner
On Fri, Apr 4, 2014 at 2:42 PM, Ian Romanick wrote: > On 03/27/2014 11:45 PM, Tapani Pälli wrote: >> Patch adds a preprocessor define for the extension and stores >> explicit location data for uniforms during AST->HIR conversion. >> It also sets layout token to be available when having the >> exte

Re: [Mesa-dev] [WIP 11/13] glsl: parser changes for GL_ARB_explicit_uniform_location

2014-04-04 Thread Ian Romanick
On 03/27/2014 11:45 PM, Tapani Pälli wrote: > Patch adds a preprocessor define for the extension and stores > explicit location data for uniforms during AST->HIR conversion. > It also sets layout token to be available when having the > extension in place. > > Signed-off-by: Tapani Pälli > --- >

Re: [Mesa-dev] [WIP 00/13] GL_ARB_explicit_uniform_location extension

2014-04-04 Thread Ian Romanick
On 03/27/2014 11:45 PM, Tapani Pälli wrote: > Hi; > > Patches implement the extension, no Piglit regressions and all the tests > for the extension pass (I've planned some more tests which are not yet > in though). > > Changes shortly: > >- opt_dead_code optimization is modifed to build a lis

[Mesa-dev] [PATCH 1/7] linker: Split set_uniform_binding into separate functions for blocks and samplers

2014-04-04 Thread Ian Romanick
From: Ian Romanick The two code paths are quite different, and there are some problems in the handling of uniform blocks. Future changes will cause these paths to diverge further. Ultimately, selecting between the two functions will happen at the set_uniform_binding call site, and set_uniform_b

[Mesa-dev] [PATCH 3/7] linker: Fold set_uniform_binding into call site

2014-04-04 Thread Ian Romanick
From: Ian Romanick In the next patch, we'll see that using gl_shader_program::UniformStorage is not correct for uniform blocks. That means we can't use ::UniformStorage to select between the sampler path and the block path. Instead we want to just use the type of the variable. That's never pass

[Mesa-dev] [PATCH 5/7] linker: Set block bindings based on UniformBlocks rather than UniformStorage

2014-04-04 Thread Ian Romanick
From: Ian Romanick For blocks, gl_shader_program::UniformStorage isn't very useful. The names stored there are the names of the elements of the block, so finding blocks with an instance name is hard. There is also only one entry in ::UniformStorage for each element of a block array, and that is

[Mesa-dev] [PATCH 4/7] linker: Clean up "unused parameter" warnings

2014-04-04 Thread Ian Romanick
From: Ian Romanick ../../src/glsl/link_uniform_initializers.cpp:87:1: warning: unused parameter 'mem_ctx' [-Wunused-parameter] ../../src/glsl/link_uniform_initializers.cpp:87:1: warning: unused parameter 'type' [-Wunused-parameter] ../../src/glsl/link_uniform_initializers.cpp:127:1: warning: un

[Mesa-dev] [PATCH 7/7] glsl: Propagate explicit binding information from the AST all the way to the linker

2014-04-04 Thread Ian Romanick
From: Ian Romanick Information about the binding was not being properly communicated from the front-end compiler to the linker. As a result, the linker never knew that any UBOs had explicit bindings! Fixes the piglit test arb_shading_language_420pack-binding-layout. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 2/7] linker: Various trivial clean-ups in set_sampler_binding

2014-04-04 Thread Ian Romanick
From: Ian Romanick - Remove the spurious block left from the previous commit and re-indent. - Constify elements. - Make the spec reference in the code look like other spec references in the compiler. Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76323 Cc

[Mesa-dev] [PATCH 6/7] linker: Set binding for all elements of UBO array

2014-04-04 Thread Ian Romanick
From: Ian Romanick Previously, a UBO like layout(binding=2) uniform U { ... } my_constants[4]; wouldn't get any bindings set. The code would try to set the binding of U, but that would fail. It should instead set the bindings for U[0], U[1], ... Signed-off-by: Ian Romanick B

Re: [Mesa-dev] [PATCH] i965: Mark SNB GT1 as a GT1.

2014-04-04 Thread Ian Romanick
On 04/04/2014 12:17 PM, Matt Turner wrote: > brw->gt only seems to be used on gen >= 7, so this shouldn't have any > effect. Based on a cursory skim of the code (with the aid of 'grep -r [^n]gt[^t] src/mesa/drivers/dri/i965/'), that appears to be true. Reviewed-by: Ian Romanick > --- > src/mes

Re: [Mesa-dev] [PATCH 10/11] glsl: Add null check in loop_analysis.cpp

2014-04-04 Thread Ian Romanick
On 04/04/2014 03:28 AM, Juha-Pekka Heikkila wrote: > Check return value from hash_table_find before using it as a pointer > > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/loop_analysis.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/glsl/loop_analysis.cpp

Re: [Mesa-dev] [PATCH 11/11] glsl: check _mesa_hash_table_create return value in link_uniform_blocks

2014-04-04 Thread Ian Romanick
On 04/04/2014 03:28 AM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/link_uniform_blocks.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/glsl/link_uniform_blocks.cpp > b/src/glsl/link_uniform_blocks.cpp > index 72d6c53..8f10a97 10064

Re: [Mesa-dev] [PATCH 09/11] mesa: add null checks in symbol_table.c

2014-04-04 Thread Ian Romanick
On 04/04/2014 03:28 AM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/program/symbol_table.c | 33 ++--- > 1 file changed, 30 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_ta

Re: [Mesa-dev] [PATCH 02/11] mesa: add missing null checks in _tnl_register_fastpath()

2014-04-04 Thread Ian Romanick
On 04/04/2014 03:27 AM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > Reviewed-by: Matt Turner > --- > src/mesa/tnl/t_vertex.c | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c > index b

[Mesa-dev] [PATCH] i965: Mark SNB GT1 as a GT1.

2014-04-04 Thread Matt Turner
brw->gt only seems to be used on gen >= 7, so this shouldn't have any effect. --- src/mesa/drivers/dri/i965/brw_device_info.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_device_info.c b/src/mesa/drivers/dri/i965/brw_device_info.c index e4c110d

Re: [Mesa-dev] [PATCH 2/2] docs: mark ARB_texture_gather as done on nvc0

2014-04-04 Thread Ilia Mirkin
On Fri, Apr 4, 2014 at 1:01 PM, Ian Romanick wrote: > On 04/03/2014 10:35 PM, Ilia Mirkin wrote: >> Signed-off-by: Ilia Mirkin >> --- >> docs/GL3.txt | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/docs/GL3.txt b/docs/GL3.txt >> index d9cc708..bf51e3a 100644 >> --- a/

Re: [Mesa-dev] [PATCH 2/2] docs: mark ARB_texture_gather as done on nvc0

2014-04-04 Thread Ian Romanick
On 04/03/2014 10:35 PM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > docs/GL3.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index d9cc708..bf51e3a 100644 > --- a/docs/GL3.txt > +++ b/docs/GL3.txt > @@ -107,7 +107,7 @@ GL 4.0

Re: [Mesa-dev] [PATCH] svga: replace sampler assertion with conditional

2014-04-04 Thread Thomas Hellstrom
On 04/04/2014 01:19 AM, Brian Paul wrote: > For TEX instructions, the set of samplers and sampler views should > be consistent. The XA state tracker sometimes passes an inconsistent > set of samplers and sampler views. I might be wrong, but I don't think the XA tracker sends an inconsistent set h

Re: [Mesa-dev] [PATCH] st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-04 Thread Thomas Hellstrom
On 04/04/2014 12:13 PM, Emil Velikov wrote: > On 03/04/14 07:05, Thomas Hellstrom wrote: >> The xa version number had to be set in two places. In configure.ac and in >> xa_tracker.h. Furthermore, xa_tracker.h is an installed header so we can't >> use mesa internal defines. So therefore, at configur

[Mesa-dev] [PATCH 1/5] i965: Add writes_accumulator flag

2014-04-04 Thread Juha-Pekka Heikkila
Our hardware has an "accumulator" register, which can be used to store intermediate results across multiple instructions. Many instructions can implicitly write a value to the accumulator in addition to their normal destination register. This is enabled by the "AccWrEn" flag. This patch introduc

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/clover: Don't segfault on clCreateBuffer with null context

2014-04-04 Thread Aaron Watry
Yeah, that looks good to me. Several of the function headers already mention similar validation, but it's nice to see it in plain language. Hopefully it's not a mistake I'll make again. --Aaron On Fri, Apr 4, 2014 at 7:12 AM, Francisco Jerez wrote: > Aaron Watry writes: > >> I guess I misunde

[Mesa-dev] [PATCH] glsl: Properly handle blocks that define the same field name.

2014-04-04 Thread Iago Toral Quiroga
Currently we can have name space collisions between blocks that define the same fields. For example: in block { vec4 Color; } In[]; out block { vec4 Color; } Out; These two blocks will assign the same interface name (block.Color) to the Color field in flatten_named_interface_blocks_decla

Re: [Mesa-dev] [PATCH] Add xa_tracker.h to .gitignore

2014-04-04 Thread Emil Velikov
On 04/04/14 13:37, Christian König wrote: > Am 04.04.2014 14:37, schrieb Emil Velikov: >> On 04/04/14 13:21, Christian König wrote: >>> From: Christian König >>> >> Please don't. Let just revert the commit and do things properly. > > Also an option, I don't really care. But it's annoying that thi

Re: [Mesa-dev] [PATCH] Add xa_tracker.h to .gitignore

2014-04-04 Thread Christian König
Am 04.04.2014 14:37, schrieb Emil Velikov: On 04/04/14 13:21, Christian König wrote: From: Christian König Please don't. Let just revert the commit and do things properly. Also an option, I don't really care. But it's annoying that this always shows up when I run "git status". Christian.

Re: [Mesa-dev] [PATCH] Add xa_tracker.h to .gitignore

2014-04-04 Thread Emil Velikov
On 04/04/14 13:21, Christian König wrote: > From: Christian König > Please don't. Let just revert the commit and do things properly. > Signed-off-by: Christian König > --- > src/gallium/state_trackers/xa/.gitignore | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 src/gallium/state

[Mesa-dev] [PATCH] Add xa_tracker.h to .gitignore

2014-04-04 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/state_trackers/xa/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 src/gallium/state_trackers/xa/.gitignore diff --git a/src/gallium/state_trackers/xa/.gitignore b/src/gallium/state_trackers/xa/.gitignore

Re: [Mesa-dev] [Mesa-stable] [PATCH] st/clover: Don't segfault on clCreateBuffer with null context

2014-04-04 Thread Francisco Jerez
Aaron Watry writes: > I guess I misunderstood that obj() call (my IDE is misbehaving on the > machine I was doing that work on which limited my ability to easily > find function definitions outside of the current file). C++ is pretty > unfamiliar to me and I guess that I figured that the obj() w

Re: [Mesa-dev] [PATCH v2 00/10] Map support for GBM bos

2014-04-04 Thread Emil Velikov
On 04/04/14 09:36, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Changes from previous version: > > - removed the extra gbm egl platform; > > - set errno to ENOSYS when the map/unmap capability is not implemented. > > Thanks, > Ander > Hi Ander, Considering Tho

Re: [Mesa-dev] [PATCH 09/10] egl/drm: Add support for native gbm backends

2014-04-04 Thread Emil Velikov
On 04/04/14 09:36, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > --- > src/egl/drivers/dri2/egl_dri2.c | 9 +- > src/egl/drivers/dri2/egl_dri2.h | 3 +- > src/egl/drivers/dri2/platform_drm.c | 217 > ++-- > src/gbm/main/co

[Mesa-dev] [PATCH] glapi: Add KHR_debug functions to check_table test

2014-04-04 Thread Timothy Arceri
Signed-off-by: Timothy Arceri --- src/mapi/glapi/tests/check_table.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mapi/glapi/tests/check_table.cpp b/src/mapi/glapi/tests/check_table.cpp index 89d9073..27a9d12 100644 --- a/src/mapi/glapi/tests/check_table.cpp +++ b/src/mapi/gla

Re: [Mesa-dev] [PATCH 05/10] gbm: Add a native intel backend

2014-04-04 Thread Emil Velikov
On 04/04/14 09:36, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > A few minor nits inline. > --- > src/gbm/Makefile.am| 14 +- > src/gbm/backends/intel/gbm_intel.c | 258 > + > src/gbm/backends/intel/gbm_intel.h |

Re: [Mesa-dev] [PATCH 04/10] egl: Protect use of gbm_dri with ifdef HAVE_DRM_PLATFORM

2014-04-04 Thread Emil Velikov
On 04/04/14 09:36, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > Otherwise it fails to compile if the drm egl platform is disabled. Similar note to patch 2 - independent of the series, stable material. Cc: "10.0" "10.1" Reviewed-by: Emil Velikov > --- > src/egl/d

Re: [Mesa-dev] [PATCH 02/10] wayland: Fix the logic in disabling the prime capability

2014-04-04 Thread Emil Velikov
On 04/04/14 09:36, Ander Conselvan de Oliveira wrote: > From: Neil Roberts > > It looks like this bit of code is trying to disable the prime capability if > the driver doesn't support createImageFromFds. However the logic looks a bit > broken and what it would actually do is disable all other cap

[Mesa-dev] [PATCH] radeon/vce: cleanup cpb handling

2014-04-04 Thread Christian König
From: Leo Liu v2: fix whitespace errors, minor coding style changes Signed-off-by: Leo Liu Signed-off-by: Christian König --- src/gallium/drivers/radeon/radeon_vce.c| 22 +++--- src/gallium/drivers/radeon/radeon_vce.h| 3 +++ src/gallium/drivers/radeon/radeon_

Re: [Mesa-dev] [PATCH 01/10] gbm: Set errno on errors

2014-04-04 Thread Emil Velikov
On 04/04/14 09:36, Ander Conselvan de Oliveira wrote: > From: Ander Conselvan de Oliveira > > This should give the caller some information of what called the error. > For the gbm_bo_import() case, for instance, it is possible to know if > the import is not supported or the error was caused by an

[Mesa-dev] [PATCH 08/11] i965: check malloc return value in intel_resolve_map_set()

2014-04-04 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/drivers/dri/i965/intel_resolve_map.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_resolve_map.c b/src/mesa/drivers/dri/i965/intel_resolve_map.c index 04b5c94..a338c5e 100644 --- a/src/mesa/drivers/dri/i

[Mesa-dev] [PATCH 11/11] glsl: check _mesa_hash_table_create return value in link_uniform_blocks

2014-04-04 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_uniform_blocks.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/link_uniform_blocks.cpp b/src/glsl/link_uniform_blocks.cpp index 72d6c53..8f10a97 100644 --- a/src/glsl/link_uniform_blocks.cpp +++ b/src/glsl/link_uniform

[Mesa-dev] [PATCH 01/11] mesa: Add _mesa_error_no_memory for logging out-of-memory messages

2014-04-04 Thread Juha-Pekka Heikkila
From: Ian Romanick This can be called from locations that don't have a context pointer handy. This patch also adds enough infrastructure so that the unit tests for the GLSL compiler and the stand-alone compiler will build and function. This patch was originally signed off by Ian Romanick, now v

[Mesa-dev] [PATCH 05/11] mesa: Add missing null checks into prog_hash_table.c

2014-04-04 Thread Juha-Pekka Heikkila
Check calloc return values in hash_table_insert() and hash_table_replace() Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/prog_hash_table.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/program/prog_hash_table.c b/src/mesa/program/prog_hash_table.c index f45e

[Mesa-dev] [PATCH 06/11] glsl: add missing null check in tfeedback_decl::init()

2014-04-04 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glsl/link_varyings.cpp | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index c925c00..d0a9d75 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@ -278,6 +278,12 @@

[Mesa-dev] [PATCH 10/11] glsl: Add null check in loop_analysis.cpp

2014-04-04 Thread Juha-Pekka Heikkila
Check return value from hash_table_find before using it as a pointer Signed-off-by: Juha-Pekka Heikkila --- src/glsl/loop_analysis.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/loop_analysis.cpp b/src/glsl/loop_analysis.cpp index d6a9ac7..5e4eaa1 100644 --- a/s

[Mesa-dev] [PATCH 04/11] mesa: In emit_texenv() type mismatch was forced with typecast

2014-04-04 Thread Juha-Pekka Heikkila
Type mismatch caused random memory to be copied when casted memory area was smaller than expected type. Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/ff_fragment_shader.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/ff_fragment_shad

[Mesa-dev] [PATCH 07/11] mesa: add missing null check in _mesa_NewHashTable()

2014-04-04 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/main/hash.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c index 4c92005..21da652 100644 --- a/src/mesa/main/hash.c +++ b/src/mesa/main/hash.c @@ -115,10 +115,20 @@ _mesa_NewHashTable(void

[Mesa-dev] [PATCH 02/11] mesa: add missing null checks in _tnl_register_fastpath()

2014-04-04 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/tnl/t_vertex.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..5cdf743 100644 --- a/src/mesa/tnl/t_vertex.c +++ b/src/mesa

[Mesa-dev] [PATCH 03/11] mesa: add extra null checks in vbo_rebase_prims()

2014-04-04 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila Reviewed-by: Matt Turner --- src/mesa/vbo/vbo_rebase.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index f3fe5f7..7aa8d08 100644 --- a/src/mesa/vbo/vbo_reba

[Mesa-dev] [PATCH 09/11] mesa: add null checks in symbol_table.c

2014-04-04 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/symbol_table.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/symbol_table.c b/src/mesa/program/symbol_table.c index 9462978..9c3556a 100644 --- a/src/mesa/program/symb

[Mesa-dev] [PATCH 00/11] Klocwork patches

2014-04-04 Thread Juha-Pekka Heikkila
Set of patches which mostly were here earlier. #10 and #11 are new to the set. These pass Piglit quick tests with no regression on my Ivybridge. /Juha-Pekka Ian Romanick (1): mesa: Add _mesa_error_no_memory for logging out-of-memory messages Juha-Pekka Heikkila (10): mesa: add missing null c

Re: [Mesa-dev] [PATCH v2 00/10] Map support for GBM bos

2014-04-04 Thread Thomas Hellstrom
NAK! No generic mmap() APIs of GBM bos, please. The reason is that this impossible to implement in an efficient way on non-coherent architectures, and once the interface is there, people will start using it and ignore the non-coherent architectures. And these will, in the end, have to implement a

Re: [Mesa-dev] [PATCH] st/xa: Fix advertized version number and try to avoid future discrepancies

2014-04-04 Thread Emil Velikov
On 03/04/14 07:05, Thomas Hellstrom wrote: > The xa version number had to be set in two places. In configure.ac and in > xa_tracker.h. Furthermore, xa_tracker.h is an installed header so we can't > use mesa internal defines. So therefore, at configure time, modify the > xa_tracker.h header to use t

Re: [Mesa-dev] [PATCH 1/5] gallium: add support for LODQ opcodes.

2014-04-04 Thread Marek Olšák
Patch 1 & 2: Reviewed-by: Marek Olšák Marek On Fri, Apr 4, 2014 at 4:14 AM, Ilia Mirkin wrote: > From: Dave Airlie > > This opcode provide support for GL_ARB_texture_query_lod, > > Signed-off-by: Dave Airlie > [imirkin: rebase, docs update] > Signed-off-by: Ilia Mirkin > --- > src/gallium/

[Mesa-dev] [PATCH 08/10] dri, i965: Add entry point for creating image from native handle

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira The native handle is a pointer to drm_intel_bo for the i965 driver. --- include/GL/internal/dri_interface.h | 13 +++- src/mesa/drivers/dri/i965/intel_regions.c | 50 ++- src/mesa/drivers/dri/i965/intel_regions.h | 6

[Mesa-dev] [PATCH 07/10] dri, i965: Add an extension for sharing the drm bufmgr

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira If the fd used by the DRI driver is going to be shared with something else, like gbm, this lets the loader pass the bufmgr struct so it is shared too. --- include/GL/internal/dri_interface.h | 11 +++ src/egl/drivers/dri2/egl_dri2.h | 3 ++

[Mesa-dev] [PATCH 10/10] gbm: Add entry points for mapping and unmapping bos

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Add gbm_bo_map() and gbm_bo_unmap(). This lets a user access the contents of a bo using the CPU. --- src/gbm/backends/dri/gbm_dri.c | 3 +++ src/gbm/backends/intel/gbm_intel.c | 24 src/gbm/backends/intel/gbm_intel.h | 2 ++ src/gb

[Mesa-dev] [PATCH 09/10] egl/drm: Add support for native gbm backends

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira --- src/egl/drivers/dri2/egl_dri2.c | 9 +- src/egl/drivers/dri2/egl_dri2.h | 3 +- src/egl/drivers/dri2/platform_drm.c | 217 ++-- src/gbm/main/common_drm.h | 6 + 4 files changed, 200 insertions(+), 35 de

[Mesa-dev] [PATCH 06/10] gbm_drm: Keep a reference to drm native objects

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Add bo and bufmgr fields to gbm_drm_bo and gbm_drm_device respectively. --- src/gbm/backends/intel/gbm_intel.c | 4 src/gbm/main/common_drm.h | 6 ++ 2 files changed, 10 insertions(+) diff --git a/src/gbm/backends/intel/gbm_intel.c b/src/gbm/

[Mesa-dev] [PATCH 04/10] egl: Protect use of gbm_dri with ifdef HAVE_DRM_PLATFORM

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Otherwise it fails to compile if the drm egl platform is disabled. --- src/egl/drivers/dri2/egl_dri2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 8abe8ac..a5ba048 100644 --- a/src

[Mesa-dev] [PATCH 05/10] gbm: Add a native intel backend

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira --- src/gbm/Makefile.am| 14 +- src/gbm/backends/intel/gbm_intel.c | 258 + src/gbm/backends/intel/gbm_intel.h | 74 +++ src/gbm/main/backend.c | 2 + src/gbm/main/common_drm.h

[Mesa-dev] [PATCH v2 00/10] Map support for GBM bos

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira Changes from previous version: - removed the extra gbm egl platform; - set errno to ENOSYS when the map/unmap capability is not implemented. Thanks, Ander Ander Conselvan de Oliveira (9): gbm: Set errno on errors gbm: Move private pointer from gbm_dri_s

[Mesa-dev] [PATCH 01/10] gbm: Set errno on errors

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira This should give the caller some information of what called the error. For the gbm_bo_import() case, for instance, it is possible to know if the import is not supported or the error was caused by an invalid parameter. --- src/gbm/backends/dri/gbm_dri.c | 38

[Mesa-dev] [PATCH 03/10] gbm: Move private pointer from gbm_dri_surface to gbm_surface

2014-04-04 Thread Ander Conselvan de Oliveira
From: Ander Conselvan de Oliveira This allows the pointer stored in dri2_surf in the EGL platform to be changed to a generic gbm_surface pointer. --- src/egl/drivers/dri2/egl_dri2.h | 2 +- src/egl/drivers/dri2/platform_drm.c | 37 - src/gbm/backends/dri/

[Mesa-dev] [PATCH 02/10] wayland: Fix the logic in disabling the prime capability

2014-04-04 Thread Ander Conselvan de Oliveira
From: Neil Roberts It looks like this bit of code is trying to disable the prime capability if the driver doesn't support createImageFromFds. However the logic looks a bit broken and what it would actually do is disable all other capabilities apart from prime. This patch fixes it to actually disa

  1   2   >