Re: [Mesa-dev] [PATCH 5/6] glsl: Allow int - uint implicit conversions on function parameters

2014-05-04 Thread Chris Forbes
This doesn't actually work -- call_link_visitor::find_matching_signature passes a NULL state pointer in here. On Sun, Apr 27, 2014 at 9:44 PM, Chris Forbes chr...@ijw.co.nz wrote: Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/glsl_types.cpp | 16 +--- 1 file changed,

[Mesa-dev] [PATCH V2 4/9] glsl: Pass parse state to can_implicitly_convert_to()

2014-05-04 Thread Chris Forbes
Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/ast_function.cpp | 4 ++-- src/glsl/glsl_types.cpp | 3 ++- src/glsl/glsl_types.h | 3 ++- src/glsl/ir_function.cpp | 4 ++-- 4 files changed, 8 insertions(+), 6 deletions(-) diff --git a/src/glsl/ast_function.cpp

[Mesa-dev] [PATCH V2 5/9] glsl: Allow int - uint implicit conversions on function parameters

2014-05-04 Thread Chris Forbes
V2: Fix crashes during linking, where the parse state is NULL. In this case, all required checks have already been done, so we assume the extension is enabled. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/glsl_types.cpp | 19 --- 1 file changed, 16 insertions(+), 3

[Mesa-dev] [PATCH V2 3/9] glsl: Pass parse state to parameter_lists_match()

2014-05-04 Thread Chris Forbes
The available implicit conversions depend on the GLSL version we're compiling. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/ir_function.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp index

[Mesa-dev] [PATCH V2 8/9] glsl: Implement overload resolution for ARB_gpu_shader5

2014-05-04 Thread Chris Forbes
The ARB_gpu_shader5 spec says: A function definition A is considered a better match than function definition B if: * for at least one function argument, the conversion for that argument in A is better than the corresponding conversion in B; and * there is no function argument for which

[Mesa-dev] [PATCH V2 1/9] glsl: Clean up apply_implicit_conversion

2014-05-04 Thread Chris Forbes
We're about to add new implicit conversions, first for ARB_gpu_shader5, and then later for ARB_gpu_shader_fp64. Pull out the opcode determination into its own function, and get rid of the bool - float case that could never be hit anyway [since it fails the is_numeric() check]. V2: Retain the

[Mesa-dev] [PATCH V2 2/9] glsl: Add support for int - uint implicit conversions

2014-05-04 Thread Chris Forbes
This is required for ARB_gpu_shader5. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/ast_to_hir.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index b695132..f6c7409 100644 --- a/src/glsl/ast_to_hir.cpp +++

[Mesa-dev] [PATCH V2 6/9] glsl: Build a list of inexact function matches

2014-05-04 Thread Chris Forbes
This will facilitate GLSL 4.0 / ARB_gpu_shader5's enhanced overload resolution rules, and also possibly better error reporting for ambiguous function calls. Signed-off-by: Chris Forbes chr...@ijw.co.nz --- src/glsl/ir_function.cpp | 43 --- 1 file changed,

[Mesa-dev] [PATCH V2 0/9] ARB_gpu_shader5 implicit conversions and overloading

2014-05-04 Thread Chris Forbes
This series adds support for implicit conversions and overload resolution from ARB_gpu_shader5 / GLSL 4.0. The first 5 patches (and half of the 9th) were previously sent out on their own, but had some serious issues I had overlooked, as I hadn't done a full piglit run. Notable changes in this

[Mesa-dev] [PATCH V2 7/9] glsl: Add support for comparing function parameter conversions

2014-05-04 Thread Chris Forbes
The ARB_gpu_shader5 spec says: To determine whether the conversion for a single argument in one match is better than that for another match, the following rules are applied, in order: 1. An exact match is better than a match involving any implicit conversion. 2. A match involving an

Re: [Mesa-dev] [PATCH 1/3] gallium: add support for sampling from stencil of depth_stencil texture

2014-05-04 Thread Marek Olšák
Gallium already supports stencil texturing and st/mesa has been using it for glDrawPixels for quite a while. The pipe_sampler_view bit is unnecessary. You can create a stencil sampler view by specifying one of these formats: PIPE_FORMAT_S8_UINT PIPE_FORMAT_X24S8_UINT PIPE_FORMAT_S8X24_UINT

Re: [Mesa-dev] [PATCH 1/3] gallium: add support for sampling from stencil of depth_stencil texture

2014-05-04 Thread Ilia Mirkin
Yeah, I actually sent a follow-up patch which does this in a totally different and much simpler way. On Sun, May 4, 2014 at 6:47 AM, Marek Olšák mar...@gmail.com wrote: Gallium already supports stencil texturing and st/mesa has been using it for glDrawPixels for quite a while. The

Re: [Mesa-dev] [PATCH] st/egl: Flush resources before presentation (android - bug 77966)

2014-05-04 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Fri, May 2, 2014 at 5:00 PM, pstglia pstg...@gmail.com wrote: --- src/gallium/state_trackers/egl/android/native_android.cpp | 7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [Mesa-dev] [PATCH V2 9/9] docs: Update GL3.txt

2014-05-04 Thread Marek Olšák
One question: Should we have a list of drivers supporting a gpu_shader5 feature after DONE like the other extensions have? For features without driver changes, that would be DONE (all drivers). Marek On Sun, May 4, 2014 at 10:24 AM, Chris Forbes chr...@ijw.co.nz wrote: Signed-off-by: Chris

Re: [Mesa-dev] [PATCH V2 9/9] docs: Update GL3.txt

2014-05-04 Thread Chris Forbes
Yes, we probably should. Some of the other features require a significant amount of hardware-specific work. On Sun, May 4, 2014 at 11:11 PM, Marek Olšák mar...@gmail.com wrote: One question: Should we have a list of drivers supporting a gpu_shader5 feature after DONE like the other extensions

Re: [Mesa-dev] [PATCH 3/3] mesa/st: implement ARB_stencil_texturing

2014-05-04 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Sat, May 3, 2014 at 11:25 AM, Ilia Mirkin imir...@alum.mit.edu wrote: If StencilSampling is enabled on the texture object, pass in an equivalent stencil-only format. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This replaces my

Re: [Mesa-dev] gallium: conditional rendering and glBlitFramebuffer

2014-05-04 Thread Marek Olšák
I think the plan was to add struct pipe_query *render_condition to pipe_blit_info. The value of NULL would mean the conditional rendering is disabled. Marek On Sat, May 3, 2014 at 10:42 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Hello, I've noticed that nv50 fails the latest version of the

[Mesa-dev] [Bug 78258] New: make check link_varyings.gl_ClipDistance failure

2014-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78258 Priority: medium Bug ID: 78258 Keywords: regression Assignee: mesa-dev@lists.freedesktop.org Summary: make check link_varyings.gl_ClipDistance failure Severity: major

Re: [Mesa-dev] [PATCH 3/3] mesa/st: implement ARB_stencil_texturing

2014-05-04 Thread Roland Scheidegger
Am 03.05.2014 11:25, schrieb Ilia Mirkin: If StencilSampling is enabled on the texture object, pass in an equivalent stencil-only format. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This replaces my earlier series, based on a suggestion from Michel Dänzer on IRC. Much simpler,

Re: [Mesa-dev] gallium: conditional rendering and glBlitFramebuffer

2014-05-04 Thread Roland Scheidegger
Why would you need the whole query? A boolean if it should honor the currently set render condition sounds simpler and good enough to me. Roland Am 04.05.2014 13:17, schrieb Marek Olšák: I think the plan was to add struct pipe_query *render_condition to pipe_blit_info. The value of NULL would

[Mesa-dev] [Bug 78258] make check link_varyings.gl_ClipDistance failure

2014-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78258 Vinson Lee v...@freedesktop.org changed: What|Removed |Added CC||i...@freedesktop.org

Re: [Mesa-dev] gallium: conditional rendering and glBlitFramebuffer

2014-05-04 Thread Marek Olšák
Yes, you are right, a boolean flag would be simpler. Marek On Sun, May 4, 2014 at 6:06 PM, Roland Scheidegger srol...@vmware.com wrote: Why would you need the whole query? A boolean if it should honor the currently set render condition sounds simpler and good enough to me. Roland Am

Re: [Mesa-dev] [PATCH 02/21] glsl: protect locale_t with a mutex

2014-05-04 Thread Chia-I Wu
On Sat, May 3, 2014 at 1:52 AM, Ian Romanick i...@freedesktop.org wrote: On 04/22/2014 01:58 AM, Chia-I Wu wrote: There may be two contexts compiling shaders at the same time. locale_t needs to be protected. Rather than calling glsl_initialize_strtod from other places in the compiler, it

Re: [Mesa-dev] [PATCH 03/21] glsl: protect anonymous struct id with a mutex

2014-05-04 Thread Chia-I Wu
On Sat, May 3, 2014 at 1:33 AM, Ian Romanick i...@freedesktop.org wrote: On 04/22/2014 01:58 AM, Chia-I Wu wrote: There may be two contexts compiling shaders at the same time, and we want the anonymous struct id to be globally unique. I am not very excited about this. Is there any chance of

Re: [Mesa-dev] [PATCH 20/21] mesa: add support for threaded glCompileShader

2014-05-04 Thread Chia-I Wu
On Sat, May 3, 2014 at 1:59 AM, Ian Romanick i...@freedesktop.org wrote: On 04/22/2014 01:58 AM, Chia-I Wu wrote: From: Chia-I Wu o...@lunarg.com Threaded glCompileShader can be enabled for a context by calling _mesa_enable_glsl_threadpool. It will initialize the singleton GLSL thread pool

Re: [Mesa-dev] [PATCH] st/egl: Flush resources before presentation (android - bug 77966)

2014-05-04 Thread Chia-I Wu
On Sun, May 4, 2014 at 7:02 PM, Marek Olšák mar...@gmail.com wrote: Reviewed-by: Marek Olšák marek.ol...@amd.com Looks good to me too, except please use your real name. Marek On Fri, May 2, 2014 at 5:00 PM, pstglia pstg...@gmail.com wrote: ---

Re: [Mesa-dev] [PATCH 03/21] glsl: protect anonymous struct id with a mutex

2014-05-04 Thread Matt Turner
On Fri, May 2, 2014 at 10:33 AM, Ian Romanick i...@freedesktop.org wrote: On 04/22/2014 01:58 AM, Chia-I Wu wrote: There may be two contexts compiling shaders at the same time, and we want the anonymous struct id to be globally unique. I am not very excited about this. Is there any chance

Re: [Mesa-dev] [PATCH 3/3] mesa/st: implement ARB_stencil_texturing

2014-05-04 Thread Ilia Mirkin
On Sun, May 4, 2014 at 11:59 AM, Roland Scheidegger srol...@vmware.com wrote: Am 03.05.2014 11:25, schrieb Ilia Mirkin: If StencilSampling is enabled on the texture object, pass in an equivalent stencil-only format. Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This replaces my

Re: [Mesa-dev] [PATCH] st/egl: Flush resources before presentation (android - bug 77966)

2014-05-04 Thread Chia-I Wu
On Mon, May 5, 2014 at 6:12 AM, Paulo Sergio pstg...@gmail.com wrote: Ok. Name is Paulo Sergio Travaglia. Shall I resend the patch? I've committed it. Thanks. Thanks Em 04/05/2014 18:40, Chia-I Wu olva...@gmail.com escreveu: On Sun, May 4, 2014 at 7:02 PM, Marek Olšák mar...@gmail.com

[Mesa-dev] [v2 03/10] mesa: add new enum MAX_UNIFORM_LOCATIONS

2014-05-04 Thread Tapani Pälli
Patch adds new implementation dependent value required by the GL_ARB_explicit_uniform_location extension. Default value for user assignable locations is calculated as sum of MaxUniformComponents for each stage. v2: fix descriptor in get_hash_params.py (Petri) Signed-off-by: Tapani Pälli

[Mesa-dev] [PATCH] glsl: fix bogus layout qualifier warnings

2014-05-04 Thread Tapani Pälli
Print out GL_ARB_explicit_attrib_location warnings only when parsing attribute that uses location qualifier. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77245 Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/glsl/glsl_parser.yy | 11 +++ 1 file changed, 7

[Mesa-dev] [PATCH] drawtex: resolve glDrawTexfOES extension function

2014-05-04 Thread Tapani Pälli
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78101 Signed-off-by: Tapani Pälli tapani.pa...@intel.com --- src/egl/opengles1/drawtex.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/egl/opengles1/drawtex.c b/src/egl/opengles1/drawtex.c index

[Mesa-dev] [Bug 78101] [bisected] Mesa demos fails to link with drawtex.c:34: undefined reference to `glDrawTexfOES'

2014-05-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=78101 Tapani Pälli lem...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED