Re: [Mesa-dev] [PATCH] glx: Add an error message when a direct renderer's createScreen() routine fails because no matching fbConfigs or visuals could be found.

2014-06-18 Thread Kenneth Graunke
On Tuesday, June 10, 2014 10:51:40 AM Jon TURNEY wrote: Nearly all the error cases in *createScreen() issue an error message to diagnose the failure to initialize before branching to handle_error. The few remaining error cases which don't should probably do the same. (At the moment, it

Re: [Mesa-dev] [PATCH 5/7] main/extensions: Create extra extensions override string

2014-06-18 Thread Kenneth Graunke
On Monday, June 09, 2014 05:50:21 PM Ian Romanick wrote: On 06/08/2014 03:17 PM, Jordan Justen wrote: This will allow us to utilize the early MESA_EXTENSION_OVERRIDE parsing at the later extension string initialization step. Signed-off-by: Jordan Justen jordan.l.jus...@intel.com ---

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-18 Thread Chia-I Wu
Hi Emil, On Fri, Jun 13, 2014 at 3:56 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi all, These patches add support for building (grouping) the various targets per API, meaning that only one library will be created for e.g. vdpau (libvdpau_gallium) with individual ones (libvdpau_r600)

[Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Eric Anholt
To those who have been curious what I was up to: I wasn't sure when I could announce my new projecct, I just got the ack day before yesterday, and I've been a little busy. I'm working toward building a Mesa driver for Broadcom VC4 (aka Raspberry Pi). At the moment I'm still bringing up the DRM

Re: [Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Peter Hanzel
Hello. Can you provide a code that you already have? I am very interested to see DRM/KMS/Mesa on RPi. On Wed, Jun 18, 2014 at 9:28 AM, Eric Anholt e...@anholt.net wrote: To those who have been curious what I was up to: I wasn't sure when I could announce my new projecct, I just got the ack day

Re: [Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Eric Anholt
Peter Hanzel hanzelpe...@gmail.com writes: Hello. Can you provide a code that you already have? I am very interested to see DRM/KMS/Mesa on RPi. The code that doesn't do anything yet is on https://github.com/anholt/linux on the vc4 branch. It doesn't do anything useful. Really.

[Mesa-dev] [PATCH v2 10/23] i965/gs: Set number of control data bits for stream mode.

2014-06-18 Thread Iago Toral Quiroga
If the geometry shader is indeed using streams then we need 2 control data bits per vertex for the StreamID. If the shader is not using streams then we don't need control data bits. --- src/mesa/drivers/dri/i965/brw_vec4_gs.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH v2 06/23] glsl: Add methods to retrive a varying's name and streamId.

2014-06-18 Thread Iago Toral Quiroga
--- src/glsl/link_varyings.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/link_varyings.h b/src/glsl/link_varyings.h index 4e485c3..167363e 100644 --- a/src/glsl/link_varyings.h +++ b/src/glsl/link_varyings.h @@ -112,6 +112,16 @@ public: return

[Mesa-dev] [PATCH v2 02/23] mesa: add StreamId information to transform feedback outputs.

2014-06-18 Thread Iago Toral Quiroga
For now initialized to the default stream 0. --- src/glsl/link_varyings.cpp | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 6863298..f765d37 100644 --- a/src/glsl/link_varyings.cpp +++

[Mesa-dev] [PATCH v2 00/23] Multi-stream support for geometry shaders

2014-06-18 Thread Iago Toral Quiroga
This series addresses review comments of the previous version and adds a few things. Summary of the changes in version 2: Patch 1: - Ian: multiple layout(location=) qualifiers + This was not a problem in the end. - Chris: s/explicitely/explicitly/ - Chris: Remove 'Id' suffix in

[Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

2014-06-18 Thread Iago Toral Quiroga
From: Samuel Iglesias Gonsalvez sigles...@igalia.com This implements parsing requirements for multi-stream support in geometry shaders as defined in ARB_gpu_shader5. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- src/glsl/ast.h| 5 +

[Mesa-dev] [PATCH v2 07/23] glsl: Two varyings can't write to the same buffer from different streams.

2014-06-18 Thread Iago Toral Quiroga
If this is detected, fail to link. --- src/glsl/link_varyings.cpp | 17 + 1 file changed, 17 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 3b20594..3d5a680 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp @@

[Mesa-dev] [PATCH v2 22/23] mesa: Init Geom.UsesEndPrimitive in shader programs.

2014-06-18 Thread Iago Toral Quiroga
--- src/mesa/main/shaderobj.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/shaderobj.c b/src/mesa/main/shaderobj.c index 03db862..b3d428c 100644 --- a/src/mesa/main/shaderobj.c +++ b/src/mesa/main/shaderobj.c @@ -248,6 +248,7 @@ _mesa_init_shader_program(struct gl_context

[Mesa-dev] [PATCH v2 14/23] glsl: include streamId when reading/printing emit-vertex and end-primitive IR.

2014-06-18 Thread Iago Toral Quiroga
--- src/glsl/ir_print_visitor.cpp | 13 + src/glsl/ir_reader.cpp| 22 ++ 2 files changed, 27 insertions(+), 8 deletions(-) diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visitor.cpp index c4a6f9c..dcb53b3 100644 ---

[Mesa-dev] [PATCH v2 15/23] glsl: include streamId when reading/printing ir_variable IR.

2014-06-18 Thread Iago Toral Quiroga
From: Samuel Iglesias Gonsalvez sigles...@igalia.com Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- src/glsl/ir_print_visitor.cpp | 7 +-- src/glsl/ir_reader.cpp| 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-18 Thread Iago Toral Quiroga
--- src/glsl/builtin_functions.cpp | 52 ++-- src/glsl/ir.h| 34 +-- src/glsl/ir_hierarchical_visitor.cpp | 50 +- src/glsl/ir_hierarchical_visitor.h | 6 +++--

[Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-18 Thread Iago Toral Quiroga
Check if non-zero streams are used. Fail to link if emitting to unsupported streams or emitting to non-zero streams with output type other than GL_POINTS. --- src/glsl/linker.cpp | 148 +++- 1 file changed, 134 insertions(+), 14 deletions(-) diff

[Mesa-dev] [PATCH v2 23/23] mesa: Copy Geom.UsesEndPrimitive when cloning a geometry program.

2014-06-18 Thread Iago Toral Quiroga
--- src/mesa/program/program.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/program/program.c b/src/mesa/program/program.c index 1263cea..aedce3e 100644 --- a/src/mesa/program/program.c +++ b/src/mesa/program/program.c @@ -552,6 +552,7 @@ _mesa_clone_program(struct gl_context

[Mesa-dev] [PATCH v2 04/23] glsl: Assign GLSL StreamIds to transform feedback outputs.

2014-06-18 Thread Iago Toral Quiroga
Inter-shader outputs must be on stream 0, which is the default. --- src/glsl/link_varyings.cpp | 12 +--- src/glsl/link_varyings.h | 7 +++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index f765d37..9725a43

[Mesa-dev] [PATCH v2 03/23] i965: Enable transform feedback for streams 0

2014-06-18 Thread Iago Toral Quiroga
Configure hardware to read vertex data for all streams and have all streams write their varyings to the corresponsing output buffers. --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 67 +++--- 1 file changed, 43 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [PATCH v2 19/23] mesa: Enable simultaneous queries on different streams.

2014-06-18 Thread Iago Toral Quiroga
It should be possible to query the number of primitives written to each individual stream by a geometry shader in a single draw call. For that we need to have up to MAX_VERTEX_STREAM separate query objects. --- src/mesa/main/mtypes.h | 4 ++-- src/mesa/main/queryobj.c | 17 + 2

[Mesa-dev] [PATCH v2 08/23] glsl: Only geometry shader outputs can be associated with non-zero streams.

2014-06-18 Thread Iago Toral Quiroga
This should be ensured by the parser, so assert on that. --- src/glsl/link_varyings.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 3d5a680..520a51a 100644 --- a/src/glsl/link_varyings.cpp +++ b/src/glsl/link_varyings.cpp

[Mesa-dev] [PATCH v2 18/23] i965: Implement GL_PRIMITIVES_GENERATED with non-zero streams.

2014-06-18 Thread Iago Toral Quiroga
So far we have been using CL_INVOCATION_COUNT to resolve this query but this is no good with streams, as only stream 0 reaches the clipping stage. From ARB_transform_feedback3: When a generated primitive query for a vertex stream is active, the primitives-generated count is incremented every

[Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

2014-06-18 Thread Iago Toral Quiroga
On Intel hardware when a geometry shader outputs GL_POINTS primitives we only need to emit vertex control bits if it emits vertices to non-zero streams, so use a flag to track this. This flag will be set to TRUE when a geometry shader calls EmitStreamVertex() or EndStreamPrimitive() with a

[Mesa-dev] [PATCH v2 16/23] mesa: Include stream information in indexed queries.

2014-06-18 Thread Iago Toral Quiroga
--- src/mesa/main/mtypes.h | 1 + src/mesa/main/queryobj.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 5bc710e..2eaf2f5 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -2895,6 +2895,7 @@ struct gl_query_object

[Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2014-06-18 Thread Iago Toral Quiroga
Outputs that are linked to inputs in the next stage must be output to stream 0, otherwise we should fail to link. --- src/glsl/link_varyings.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp index 9725a43..3b20594 100644 ---

[Mesa-dev] [PATCH v2 20/23] i965: Enable vertex streams up to MAX_VERTEX_STREAMS.

2014-06-18 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/brw_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index cfb0be0..6ba58d3 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++

[Mesa-dev] [PATCH v2 17/23] i965: Implement GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN with non-zero streams.

2014-06-18 Thread Iago Toral Quiroga
--- src/mesa/drivers/dri/i965/gen6_queryobj.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_queryobj.c b/src/mesa/drivers/dri/i965/gen6_queryobj.c index 06ac645..0cb64ca 100644 --- a/src/mesa/drivers/dri/i965/gen6_queryobj.c +++

[Mesa-dev] [PATCH v2 13/23] i965/gs: Set control data bits for vertices emitted in stream mode.

2014-06-18 Thread Iago Toral Quiroga
In stream mode we have to set control data bits with the StreamID information for every vertex. --- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.cpp | 51 ++- src/mesa/drivers/dri/i965/brw_vec4_gs_visitor.h | 1 + 2 files changed, 51 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v2 21/23] docs: mark Geometry shader multiple streams as done for i965

2014-06-18 Thread Iago Toral Quiroga
From: Samuel Iglesias Gonsalvez sigles...@igalia.com Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index a073562..a696e10 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt

Re: [Mesa-dev] [PATCHv2] targets/radeonsi/vdpau: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Hi Emil, This patch is Reviewed-by: Christian König christian.koe...@amd.com But there is still something looking odd: if NEED_RADEON_DRM_WINSYS if !HAVE_GALLIUM_R300 -if !HAVE_GALLIUM_RADEONSI STATIC_TARGET_LIB_DEPS += \

Re: [Mesa-dev] [PATCHv2] targets/r600/xvmc: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:02, schrieb Emil Velikov: The r600 equivalent of previous commit. v2: - Correctly include the radeon winsys/radeon_common. Cc: Christian König christian.koe...@amd.com Signed-off-by: Emil Velikov emil.l.veli...@gmail.com Reviewed-by: Christian König

Re: [Mesa-dev] [PATCHv2] targets/r600/omx: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:04, schrieb Emil Velikov: The r600 counterpart of previous commit - now the libomx-r600 is built into the libomx-mesa library. Providing a single library per API. v2: - Include the radeon winsys only when there is a user for it. Cc: Leo Liu leo@amd.com Cc: Christian

Re: [Mesa-dev] [PATCHv2] targets/radeonsi/omx: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:05, schrieb Emil Velikov: The radeonsi counterpart of previous commit - now libomx-radeonsi is built into the libomx-mesa library. Providing a single library per API. v2: - Include the radeon winsys only when there is a user for it. Cc: Leo Liu leo@amd.com Cc: Christian

Re: [Mesa-dev] [PATCHv2] targets/r600/vdpau: convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:06, schrieb Emil Velikov: Similar to previous commit, this allows us to minimise some of the duplication by compacting all vdpau targets into a single library. v2: - Include the radeon winsys only when there is a user for it. Cc: Christian König christian.koe...@amd.com

Re: [Mesa-dev] [PATCH 05/23] targets/(r300|r600|radeonsi)/dri: Convert to static/shared pipe-drivers

2014-06-18 Thread Christian König
Am 17.06.2014 20:38, schrieb Emil Velikov: Related to previous commit, merge the separate dri targets to a single one. This is essentially all the buildsystem mayhem required for megaradeon. Cc: Marek Olšák marek.ol...@amd.com Cc: Michel Dänzer michel.daen...@amd.com Cc: Christian König

[Mesa-dev] [PATCH] Remove unneeded stall calls from batches on Baytrail.

2014-06-18 Thread Gregory Hunt
From: Greg Hunt greg.h...@mobica.com These cause a small slowdown when we are sending a large number of small batches to the GPU. Signed-off-by: Gregory Hunt greg.h...@mobica.com --- src/mesa/drivers/dri/i965/gen6_vs_state.c | 2 +- src/mesa/drivers/dri/i965/gen7_blorp.cpp | 2 +-

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-06-18 Thread Christian König
@Grigori: Should I push it or did you got your account in the meantime? Christian. Am 17.06.2014 22:26, schrieb Marek Olšák: This looks good to me. Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Wed, Jun 4, 2014 at 6:54 PM, Grigori Goronzy g...@chown.ath.cx wrote: This makes 4:2:2

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-06-18 Thread Grigori Goronzy
On 18.06.2014 13:11, Christian König wrote: @Grigori: Should I push it or did you got your account in the meantime? No account yet. I wonder what's going on. Please push. Best regards Grigori Christian. Am 17.06.2014 22:26, schrieb Marek Olšák: This looks good to me. Reviewed-by: Marek

[Mesa-dev] [Bug 80183] New: [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 Priority: medium Bug ID: 80183 Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not

[Mesa-dev] [PATCH v2] glsl: Expand matrix flip optimization pass to cover more cases.

2014-06-18 Thread Iago Toral Quiroga
Also, as suggested by Ian Romanick, make it so we don't need a bunch of individual handles to flippable matrices, instead we register matrix/transpose_matrix pairs in a hash table for all built-in matrices using the non-transpose matrix name as key. --- src/glsl/opt_flip_matrices.cpp | 145

Re: [Mesa-dev] [PATCH 2/3] radeonsi: add sampling of 4:2:2 subsampled textures

2014-06-18 Thread Christian König
Ok, pushed the patches. Account requests usually take a while to complete, that's nothing to worry about. Regards, Christian. Am 18.06.2014 13:14, schrieb Grigori Goronzy: On 18.06.2014 13:11, Christian König wrote: @Grigori: Should I push it or did you got your account in the meantime?

Re: [Mesa-dev] [PATCH 1/5] st/st/omx: fix switch-case indentation in vid_enc.c

2014-06-18 Thread Christian König
Am 12.06.2014 18:27, schrieb Leo Liu: Signed-off-by: Leo Liu leo@amd.com I've pushed everything upstream. Thanks for the help, Christian. --- src/gallium/state_trackers/omx/vid_enc.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-18 Thread Emil Velikov
On 18 June 2014 08:21, Chia-I Wu olva...@gmail.com wrote: Hi Emil, On Fri, Jun 13, 2014 at 3:56 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi all, These patches add support for building (grouping) the various targets per API, meaning that only one library will be created for e.g.

[Mesa-dev] [Bug 80185] New: Please do not hardcode SELinux identifiers in the code

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80185 Priority: medium Bug ID: 80185 Assignee: mesa-dev@lists.freedesktop.org Summary: Please do not hardcode SELinux identifiers in the code Severity: normal Classification: Unclassified

[Mesa-dev] [Bug 80185] Please do not hardcode SELinux identifiers in the code

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80185 Laurent Bigonville l.bigonvi...@edpnet.be changed: What|Removed |Added CC|

[Mesa-dev] [Bug 80185] Please do not hardcode SELinux identifiers in the code

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80185 --- Comment #2 from Laurent Bigonville l.bigonvi...@edpnet.be --- An other question might also arise is why would a failure of the mmap() function considered as an error in one case and not in the case where SELinux would prevent it to succeed?

[Mesa-dev] [Bug 80185] Please do not hardcode SELinux identifiers in the code

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80185 --- Comment #3 from rhatdan dwa...@redhat.com --- In Fedora the allow_exemem boolean is not set, and this boolean would only effect user space. getsebool -a | grep execmem boinc_execmem -- on cluster_use_execmem -- off cups_execmem -- off

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-18 Thread Tom Stellard
On Tue, Jun 17, 2014 at 07:38:16PM +0100, Emil Velikov wrote: Hi all, As a follow up to the static/shared pipe-drivers series here is the final series (if anyone is interested I may take a look at egl + opencl) of refactoring the gallium dri targets into a single library/provider. Hi

Re: [Mesa-dev] [PATCH 4/5] gallium: Add PIPE_SHADER_CAP_DOUBLES

2014-06-18 Thread Roland Scheidegger
Am 18.06.2014 01:54, schrieb Dave Airlie: On 18 June 2014 05:08, Roland Scheidegger srol...@vmware.com wrote: This looks ok to me though since tgsi currently doesn't have any double opcodes (well the docs have them...) it doesn't really apply to most drivers (at least I assume you don't want

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-18 Thread Chia-I Wu
On Wed, Jun 18, 2014 at 8:14 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 18 June 2014 08:21, Chia-I Wu olva...@gmail.com wrote: Hi Emil, On Fri, Jun 13, 2014 at 3:56 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Hi all, These patches add support for building (grouping) the

Re: [Mesa-dev] [PATCH 4/5] gallium: Add PIPE_SHADER_CAP_DOUBLES

2014-06-18 Thread Tom Stellard
On Wed, Jun 18, 2014 at 09:54:28AM +1000, Dave Airlie wrote: On 18 June 2014 05:08, Roland Scheidegger srol...@vmware.com wrote: This looks ok to me though since tgsi currently doesn't have any double opcodes (well the docs have them...) it doesn't really apply to most drivers (at least I

[Mesa-dev] [Bug 80183] [llvmpipe] triangles with vertices that map to raster positions viewport width/height are not displayed

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80183 Roland Scheidegger srol...@vmware.com changed: What|Removed |Added Attachment #101296|text/plain |application/zip

[Mesa-dev] [PATCH 09/11] r600g/compute: Use gallium util functions for double lists

2014-06-18 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 147 +++-- src/gallium/drivers/r600/compute_memory_pool.h | 10 +- 2 files changed, 46 insertions(+), 111 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c

[Mesa-dev] [PATCH 02/11] r600g/compute: Add an util function to know if an item is in the pool

2014-06-18 Thread Bruno Jiménez
Every item that has been placed in the pool must have start_in_dw different from -1. --- src/gallium/drivers/r600/compute_memory_pool.h | 5 + 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.h b/src/gallium/drivers/r600/compute_memory_pool.h index

[Mesa-dev] [PATCH 05/11] r600g/compute: Only move to the pool the buffers marked for promoting

2014-06-18 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 146 +++-- src/gallium/drivers/r600/compute_memory_pool.h | 5 + 2 files changed, 91 insertions(+), 60 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c

[Mesa-dev] [PATCH 10/11] r600g/compute: Map directly the pool in some cases

2014-06-18 Thread Bruno Jiménez
All the *Enqueue* functions that read/write buffers (except clEnqueueCopyBuffer) would map the associated resource, making it to be demoted if it was in the pool. But we possitively know that this transfer will end before any kernel is launched, so there's no need to demote it. ---

[Mesa-dev] [PATCH 07/11] r600g/compute: Implement compute_memory_demote_item

2014-06-18 Thread Bruno Jiménez
This function will be used when we want to map an item that it's already in the pool. v2: Use temporary variables to avoid so many castings in functions, as suggested by Tom Stellard --- src/gallium/drivers/r600/compute_memory_pool.c | 51 ++

[Mesa-dev] [PATCH 04/11] r600g/compute: divide the item list in two

2014-06-18 Thread Bruno Jiménez
Now we will have a list with the items that are in the pool (item_list) and the items that are outside it (unallocated_list) --- src/gallium/drivers/r600/compute_memory_pool.c | 99 +- src/gallium/drivers/r600/compute_memory_pool.h | 1 + 2 files changed, 49

[Mesa-dev] [PATCH 06/11] r600g/compute: Avoid problems when promoting items mapped for reading

2014-06-18 Thread Bruno Jiménez
Acording to the OpenCL spec, it is possible to have a buffer mapped for reading and at read from it using commands or buffers. With this we can keep the mapping (that exists against the temporary item) and read with a kernel (from the item we have just added to the pool) without problems. ---

[Mesa-dev] [PATCH 11/11] clover: Use PIPE_TRANSFER_MAP_DIRECTLY when writing/reading buffers

2014-06-18 Thread Bruno Jiménez
Note: This is just a proof of concept. --- src/gallium/state_trackers/clover/api/transfer.cpp | 4 ++-- src/gallium/state_trackers/clover/core/object.hpp | 4 src/gallium/state_trackers/clover/core/resource.cpp | 2 ++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 08/11] r600g/compute: Map only against intermediate buffers

2014-06-18 Thread Bruno Jiménez
With this we can assure that mapped buffers will never change its position when relocating the pool. This patch should finally solve the mapping bug. v2: Use the new is_item_in_pool util function, as suggested by Tom Stellard --- src/gallium/drivers/r600/evergreen_compute.c | 10 --

[Mesa-dev] [PATCH 00/11] [RFC v2] Solve the mapping bug

2014-06-18 Thread Bruno Jiménez
Hi, This is my second attempt to fix the mapping bug adding all the suggestions that Tom Stellard sent, and, so far, it seems that it is resolved. This series changes completely how OpenCL buffers are handled by the r600g driver. Before this, we would add them directly to a pool, and this pool

[Mesa-dev] [PATCH 01/11] r600g/compute: Add an intermediate resource for OpenCL buffers

2014-06-18 Thread Bruno Jiménez
This patch changes completely the way buffers are added to the compute_memory_pool. Before this, whenever we were going to map a buffer or write to or read from it, it would get placed into the pool. Now, every unallocated buffer has its own r600_resource until it is allocated in the pool. NOTE:

[Mesa-dev] [PATCH 03/11] r600g/compute: Add statuses to the compute_memory_items

2014-06-18 Thread Bruno Jiménez
These statuses will help track whether the items are mapped or if they should be promoted to or demoted from the pool v2: Use the new is_item_in_pool util function, as suggested by Tom Stellard --- src/gallium/drivers/r600/compute_memory_pool.h | 7 ++-

Re: [Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Emil Velikov
On 18/06/14 08:28, Eric Anholt wrote: To those who have been curious what I was up to: I wasn't sure when I could announce my new projecct, I just got the ack day before yesterday, and I've been a little busy. I'm working toward building a Mesa driver for Broadcom VC4 (aka Raspberry Pi).

[Mesa-dev] [Bug 73846] [llvmpipe] lp_test_format fails with llvm-3.5svn = r199602

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73846 Roland Scheidegger srol...@vmware.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 73846] [llvmpipe] lp_test_format fails with llvm-3.5svn = r199602

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73846 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] Static/shared pipe-drivers (was megadriver/pipe-loader-to-all)

2014-06-18 Thread Emil Velikov
On 18/06/14 15:07, Chia-I Wu wrote: On Wed, Jun 18, 2014 at 8:14 PM, Emil Velikov emil.l.veli...@gmail.com wrote: [...] Interesting, I do not see this as an attempt to define an API, but to cleanup all the mayhem that our targets currently are: * Cleanup the build system - drop symlinks,

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

2014-06-18 Thread Ian Romanick
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com This implements parsing requirements for multi-stream support in geometry shaders as defined in ARB_gpu_shader5. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com A few minor

Re: [Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Stéphane Marchesin
On Wed, Jun 18, 2014 at 10:47 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 18/06/14 08:28, Eric Anholt wrote: To those who have been curious what I was up to: I wasn't sure when I could announce my new projecct, I just got the ack day before yesterday, and I've been a little busy. I'm

[Mesa-dev] [Bug 73846] [llvmpipe] lp_test_format fails with llvm-3.5svn = r199602

2014-06-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73846 Roland Scheidegger srol...@vmware.com changed: What|Removed |Added Status|REOPENED|RESOLVED

Re: [Mesa-dev] [PATCH 00/23] Megadrivers galore

2014-06-18 Thread Emil Velikov
On 18/06/14 14:09, Tom Stellard wrote: On Tue, Jun 17, 2014 at 07:38:16PM +0100, Emil Velikov wrote: Hi all, As a follow up to the static/shared pipe-drivers series here is the final series (if anyone is interested I may take a look at egl + opencl) of refactoring the gallium dri targets

Re: [Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Marek Olšák
It would be more precise to say that i915 uses the Draw module, which can do these per-vertex operations on the CPU (some of them use LLVM): - vertex fetching - vertex shader - geometry shader - culling and clipping - viewport transformation - translates all primitives to either point, line, or

Re: [Mesa-dev] [PATCH v2 02/23] mesa: add StreamId information to transform feedback outputs.

2014-06-18 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: For now initialized to the default stream 0. --- src/glsl/link_varyings.cpp | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git

Re: [Mesa-dev] [PATCH v2 03/23] i965: Enable transform feedback for streams 0

2014-06-18 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: Configure hardware to read vertex data for all streams and have all streams write their varyings to the corresponsing output buffers. --- src/mesa/drivers/dri/i965/gen7_sol_state.c | 67

Re: [Mesa-dev] [PATCH v2 04/23] glsl: Assign GLSL StreamIds to transform feedback outputs.

2014-06-18 Thread Ian Romanick
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: Inter-shader outputs must be on stream 0, which is the default. --- src/glsl/link_varyings.cpp | 12 +--- src/glsl/link_varyings.h | 7 +++ 2 files changed, 16 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 05/23] glsl: Fail to link if inter-stage input/outputs are not assigned to stream 0

2014-06-18 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: Outputs that are linked to inputs in the next stage must be output to stream 0, otherwise we should fail to link. --- src/glsl/link_varyings.cpp | 8 1 file changed, 8

Re: [Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

2014-06-18 Thread Ian Romanick
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: On Intel hardware when a geometry shader outputs GL_POINTS primitives we only need to emit vertex control bits if it emits vertices to non-zero streams, so use a flag to track this. This flag will be set to TRUE when a geometry shader calls

Re: [Mesa-dev] [PATCH v2 11/23] glsl: Add support for EmitStreamVertex() and EndStreamPrimitive().

2014-06-18 Thread Ian Romanick
This patch should be split into several patches: 1. Modify ir_emit_vertex to have a stream. This patch also needs to update ir_to_mesa.cpp and st_glsl_to_tgsi.cpp. 2. Modify ir_end_primitive to have a stream. This patch also needs to update ir_to_mesa.cpp and st_glsl_to_tgsi.cpp. 3. Add the

Re: [Mesa-dev] [PATCH v2 06/23] glsl: Add methods to retrive a varying's name and streamId.

2014-06-18 Thread Ian Romanick
Patches 6, 7, 8, 9, and 10 are Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/glsl/link_varyings.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/link_varyings.h b/src/glsl/link_varyings.h index

Re: [Mesa-dev] [PATCH v2 12/23] glsl: Validate vertex emission in geometry shaders.

2014-06-18 Thread Ian Romanick
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: Check if non-zero streams are used. Fail to link if emitting to unsupported streams or emitting to non-zero streams with output type other than GL_POINTS. --- src/glsl/linker.cpp | 148 +++- 1

Re: [Mesa-dev] [PATCH v2 14/23] glsl: include streamId when reading/printing emit-vertex and end-primitive IR.

2014-06-18 Thread Ian Romanick
Patches 14, 15, and 16 are Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/glsl/ir_print_visitor.cpp | 13 + src/glsl/ir_reader.cpp| 22 ++ 2 files changed, 27 insertions(+), 8 deletions(-)

Re: [Mesa-dev] [PATCH v2 19/23] mesa: Enable simultaneous queries on different streams.

2014-06-18 Thread Ian Romanick
Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: It should be possible to query the number of primitives written to each individual stream by a geometry shader in a single draw call. For that we need to have up to MAX_VERTEX_STREAM separate

Re: [Mesa-dev] [PATCH v2 01/23] glsl: Add parsing support for multi-stream output in geometry shaders.

2014-06-18 Thread Kenneth Graunke
On Wednesday, June 18, 2014 11:16:47 AM Ian Romanick wrote: On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: From: Samuel Iglesias Gonsalvez sigles...@igalia.com This implements parsing requirements for multi-stream support in geometry shaders as defined in ARB_gpu_shader5.

Re: [Mesa-dev] [PATCH v2 20/23] i965: Enable vertex streams up to MAX_VERTEX_STREAMS.

2014-06-18 Thread Ian Romanick
On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/mesa/drivers/dri/i965/brw_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index cfb0be0..6ba58d3 100644 ---

Re: [Mesa-dev] [PATCH v2 22/23] mesa: Init Geom.UsesEndPrimitive in shader programs.

2014-06-18 Thread Ian Romanick
I think this patch and 23 should be moved first in the series... the can certainly land before the other patches in the series. This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/mesa/main/shaderobj.c | 1 + 1 file

Re: [Mesa-dev] [PATCH v2 23/23] mesa: Copy Geom.UsesEndPrimitive when cloning a geometry program.

2014-06-18 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick ian.d.roman...@intel.com Cc: 10.1 10.2 mesa-sta...@lists.freedesktop.org Clearly this field should have been copied as long as it has existed. Right? On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/mesa/program/program.c | 1 + 1 file

[Mesa-dev] [PATCH] gallium/radeon: Only print a message for LLVM diagnostic errors

2014-06-18 Thread Tom Stellard
We were printing messages for all diagnostic types, which was spamming the console for some OpenCL programs. --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c

Re: [Mesa-dev] [PATCH v2 20/23] i965: Enable vertex streams up to MAX_VERTEX_STREAMS.

2014-06-18 Thread Kenneth Graunke
On Wednesday, June 18, 2014 01:45:52 PM Ian Romanick wrote: On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: --- src/mesa/drivers/dri/i965/brw_context.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c

Re: [Mesa-dev] [PATCH v2 09/23] glsl: Store info about geometry shaders that emit vertices to non-zero streams.

2014-06-18 Thread Brian Paul
On 06/18/2014 02:05 PM, Ian Romanick wrote: On 06/18/2014 02:51 AM, Iago Toral Quiroga wrote: On Intel hardware when a geometry shader outputs GL_POINTS primitives we only need to emit vertex control bits if it emits vertices to non-zero streams, so use a flag to track this. This flag will be

Re: [Mesa-dev] [PATCH v2] glsl: Expand matrix flip optimization pass to cover more cases.

2014-06-18 Thread Ian Romanick
On 06/18/2014 05:03 AM, Iago Toral Quiroga wrote: Also, as suggested by Ian Romanick, make it so we don't need a bunch of individual handles to flippable matrices, instead we register matrix/transpose_matrix pairs in a hash table for all built-in matrices using the non-transpose matrix name as

[Mesa-dev] [PATCH 3/3 v2] mesa: Don't allow GL_TEXTURE_{LUMINANCE, INTENSITY}_* queries outside compat profile

2014-06-18 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There are no queries for GL_TEXTURE_LUMINANCE_SIZE, GL_TEXTURE_INTENSITY_SIZE, GL_TEXTURE_LUMINANCE_TYPE, or GL_TEXTURE_INTENSITY_TYPE in any version of OpenGL ES or desktop OpenGL core profile. NOTE: Without changes to piglit, this regresses

[Mesa-dev] [PATCH 2/3 v2] mesa: Don't allow GL_TEXTURE_BORDER queries outside compat profile

2014-06-18 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com There are no texture borders in any version of OpenGL ES or desktop OpenGL core profile. Fixes piglit's gl-3.2-texture-border-deprecated. v2: Rebase on different initial change. Signed-off-by: Ian Romanick ian.d.roman...@intel.com Reviewed-by: Brian

[Mesa-dev] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-06-18 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Instead of catching the special case early, handle it by constructing a fake gl_texture_image that will cause the values required by the OpenGL 4.0 spec to be returned. Previously, calling glGenTextures(1, t); glBindTexture(GL_TEXTURE_2D, t);

Re: [Mesa-dev] [v8 9/9] i965: enable image external sampling for imported dma-buffers

2014-06-18 Thread Anuj Phogat
On Wed, Jul 24, 2013 at 5:06 PM, Chad Versace chad.vers...@linux.intel.com wrote: This patch is Reviewed-by: Chad Versace chad.vers...@linux.intel.com with the understanding that it depends on previous patches. I'll begin reviewing your Piglit tests now. On 07/24/2013 03:23 AM, Topi

Re: [Mesa-dev] [PATCH 1/3 v2] mesa: Handle uninitialized textures like other textures in get_tex_level_parameter_image

2014-06-18 Thread Brian Paul
On 06/18/2014 04:11 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Instead of catching the special case early, handle it by constructing a fake gl_texture_image that will cause the values required by the OpenGL 4.0 spec to be returned. Previously, calling

Re: [Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Dave Airlie
I'm working toward building a Mesa driver for Broadcom VC4 (aka Raspberry Pi). At the moment I'm still bringing up the DRM side of things, but I hope to be doing bits of userspace in the next few days. Current status is I have a skeleton DRM KMS driver that's going to talk to the firmware

Re: [Mesa-dev] Broadcom VC4 project

2014-06-18 Thread Michel Dänzer
On 18.06.2014 16:28, Eric Anholt wrote: I'm probably going to start out doing a gallium driver for simplicity, to avoid having to do all the DRI crap we've got in brw_context.c and texture miptree validation and getting user data into VBOs and all that other almost-boilerplate. Long term I

[Mesa-dev] [PATCH] egl: Fix OpenGL ES version checks in _eglParseContextAttribList()

2014-06-18 Thread Anuj Phogat
Fixes gles3 Khronos CTS test: egl_create_context.egl_create_context Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- src/egl/main/eglcontext.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/egl/main/eglcontext.c

  1   2   >