[Mesa-dev] GL_OES_standard_derivatives define

2014-07-31 Thread Rogovin, Kevin
Hi, A long time back in May, I made a very small patch to the GLSL pre-processor to define the symbol GL_OES_standard_derivatives (as 1), if the extension is supported. Without that patch, shaders that detect if they can use dFdx, dFdy and fwidth via #ifdef's do not function correctly (namely the

[Mesa-dev] GL_OES_texture_float and GL_OES_texture_half_float support

2014-07-31 Thread Rogovin, Kevin
Hi, A long time ago back in the beginning of May I submitted a patch to add to Mesa's support for the GLES2 extensions: GL_OES_texture_float, GL_OES_texture_half_float, GL_OES_texture_float_linear and GL_OES_texture_half_float_linear A linky to the post is here: http://lists.freedeskto

[Mesa-dev] [Bug 81992] New: mapi_stub->name points to caller memory leads heap-use-after-free bug

2014-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=81992 Priority: medium Bug ID: 81992 Assignee: mesa-dev@lists.freedesktop.org Summary: mapi_stub->name points to caller memory leads heap-use-after-free bug Severity: normal Cl

Re: [Mesa-dev] Question regarding dri2_egl_display conversion

2014-07-31 Thread Jaeyong Yoo
> > I'm trying to find the definition of "function" dri2_egl_display but failed. > > > Hi Jaeyong, > > The function is wrapped with a help of _EGL_DRIVER_STANDARD_TYPECASTS and > _EGL_DRIVER_TYPECAST macros as defined in src/egl/main/egldriver.h > Thanks, it is exactly what I want :-) Jaeyong

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. v2: Fix a typo in ARB_copy_image.xml and add it to the makefile v3: Put ARB_copy_image.xml in the right place alphebetically in the makefile and update the commit message Signed-off-by: Jason

Re: [Mesa-dev] [PATCH] RFC: glsl/glcpp: Allow for '#' characters to appear in shader body

2014-07-31 Thread Michel Dänzer
On 01.08.2014 03:22, Carl Worth wrote: > Strictly speaking, the GLSL specification only allows for the '#' to appear in > a shader in two places: > > 1. To introduce a pre-processing directive > > In this case, the '#' must be the first character on a line after > ignoring

Re: [Mesa-dev] Question regarding dri2_egl_display conversion

2014-07-31 Thread Emil Velikov
On 01/08/14 03:01, Jaeyong Yoo wrote: > Hello Mesa :-) > > I'm reading the source code and I've got a simple question. > > In egl_dri2.c, I saw the following code: > > dri2_dpy = disp->DriverData; > > > which is casting _EGLDisplay->DriverData to dri2_egl_display *. > > Also, I saw the fo

[Mesa-dev] Question regarding dri2_egl_display conversion

2014-07-31 Thread Jaeyong Yoo
Title: Samsung Enterprise Portal mySingle Hello Mesa :-) I'm reading the source code and I've got a simple question.   In egl_dri2.c, I saw the following code:      dri2_dpy = disp->DriverData; which is casting _EGLDisplay->DriverData to dri2_egl_display *.   Also, I saw the following code:     

[Mesa-dev] [PATCH v3 2/4] ra: make the p, q test more efficient

2014-07-31 Thread Connor Abbott
We can store the q total that pq_test() would've calculated in the node itself, updating it when we add a node to the stack. This way, we only have to walk the adjacency list when we push a node on the stack (i.e. when the p, q test succeeds) instead of every time we do the p, q test. No differenc

[Mesa-dev] [PATCH v3 1/4] ra: cleanup the public API

2014-07-31 Thread Connor Abbott
Previously, there were 3 entrypoints into parts of the actual allocator, and an API called ra_allocate_no_spills() that called all 3. Nobody would ever want to call any of the 3 entrypoints by themselves, so everybody just used ra_allocate_no_spills(). So just make them static functions, and while

[Mesa-dev] [PATCH v3 3/4] ra: don't consider nodes for spilling we don't need to

2014-07-31 Thread Connor Abbott
Previously, we would consider any optimistically colored nodes for spilling. However, spilling any optimistically colored nodes below the node that we failed to color on the stack wouldn't help us make progress, since it wouldn't help with allowing us to find a color for the node currently failing

[Mesa-dev] [PATCH v3 4/4] ra: optimistically color only one node at a time

2014-07-31 Thread Connor Abbott
Before, when we encountered a situation where we had to optimistically color a node, we would immediately give up and push all the remaining nodes on the stack in the order of their index - which is a random, and potentially not optimal, order. Instead, choose one node to optimistically color in ra

[Mesa-dev] [PATCH v3 0/4] Some register allocator cleanups and optimizations

2014-07-31 Thread Connor Abbott
This patch series contains some improvements to the register allocator used by the i965 fs and vec4 backends and r300g. The most important patch is the last one, which causes many fragment shaders to gain SIMD16 as we make smarter decisions in the allocator. Full shader-db results are reproduced in

Re: [Mesa-dev] [RFC] i965: Attempt to merge some surface state setup logic

2014-07-31 Thread Ben Widawsky
On Wed, Jul 30, 2014 at 08:03:56PM +0300, Topi Pohjolainen wrote: > First five patches refactor common decision making found in depth, > texture and renderbuffer surface setup logic. > > In principle, there is opportunity to share code between texture and > renderbuffer setup logic (Kenneth has ex

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Matt Arsenault
On 07/31/2014 03:58 PM, Jan Vesely wrote: Would that work with things like one kernel calling another kernel? If we had a function called from two kernels how would it know where to look? I don't think this case can be handled as 2 separate kernels with the same calling convention. If a kernel i

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Marek Olšák
Hi Jason, The prefix of the commit message should be "mesa: ", because it modifies mesa/main. Marek On Fri, Aug 1, 2014 at 1:47 AM, Jason Ekstrand wrote: > This adds the API entrypoint, error checking logic, and a driver hook for > the ARB_copy_image extension. > > v2: Fix a typo in ARB_copy_im

Re: [Mesa-dev] [Mesa-stable] Patches queued up for upcoming 10.2.5 release

2014-07-31 Thread Emil Velikov
On 31/07/14 06:39, Carl Worth wrote: > I've just pushed some updates to the 10.2 branch in preparation for an > upcoming stable release. The patches that are queued (as well as those > that have been nominated but aren't yet on master) can be seen here: > > http://cworth.org/~cworth/mesa-sta

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Matt Turner
On Thu, Jul 31, 2014 at 4:47 PM, Jason Ekstrand wrote: > diff --git a/src/mapi/glapi/gen/Makefile.am b/src/mapi/glapi/gen/Makefile.am > index 212731f..f0bf34a 100644 > --- a/src/mapi/glapi/gen/Makefile.am > +++ b/src/mapi/glapi/gen/Makefile.am > @@ -114,6 +114,7 @@ API_XML = \ > ARB_clear_

Re: [Mesa-dev] [PATCH 4/6] gallium: Add a dumb drm/kms winsys backed swrast provider

2014-07-31 Thread Emil Velikov
On 31/07/14 17:53, Jon TURNEY wrote: > On 24/07/2014 01:43, Emil Velikov wrote: >> From: Giovanni Campagna >> >> Add a new winsys and target that can be used with a dri2 state tracker >> and loader instead of drisw. This allows to use gbm as a dri2/image >> loader and avoid the extra copy from the

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. v2: Fix a typo in ARB_copy_image.xml and add it to the makefile Signed-off-by: Jason Ekstrand --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen/Makefile.am| 1

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
On Thu, Jul 31, 2014 at 11:38 AM, Ilia Mirkin wrote: > On Thu, Jul 31, 2014 at 2:27 PM, Jason Ekstrand > wrote: > > This adds the API entrypoint, error checking logic, and a driver hook for > > the ARB_copy_image extension. > > > > Signed-off-by: Jason Ekstrand > > --- > > src/mapi/glapi/gen/A

Re: [Mesa-dev] [PATCH V2] mesa: Add utility function _mesa_is_enum_format_unorm()

2014-07-31 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Thu, Jul 31, 2014 at 1:49 PM, Anuj Phogat wrote: > V2: Add missing formats. > > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/glformats.c | 71 > +++ > src/mesa/main/glformats.h | 3 ++ > 2 files changed, 7

Re: [Mesa-dev] [PATCH V2] mesa: Add a helper function _mesa_is_enum_format_unsized()

2014-07-31 Thread Jason Ekstrand
Yeah, that looks better. Reviewed-by: Jason Ekstrand On Thu, Jul 31, 2014 at 4:30 PM, Anuj Phogat wrote: > Function is utilized by next patch in the series. > > V2: Add missing formats. > > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/glformats.c | 56 > +++

[Mesa-dev] [PATCH V2] mesa: Add a helper function _mesa_is_enum_format_unsized()

2014-07-31 Thread Anuj Phogat
Function is utilized by next patch in the series. V2: Add missing formats. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 56 +++ src/mesa/main/glformats.h | 3 +++ 2 files changed, 59 insertions(+) diff --git a/src/mesa/main/glform

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Jan Vesely
On Thu, 2014-07-31 at 14:58 -0400, Tom Stellard wrote: > On Thu, Jul 31, 2014 at 01:28:45PM -0400, Jan Vesely wrote: > > On Thu, 2014-07-31 at 11:02 -0400, Tom Stellard wrote: > > > On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: > > > > Make the function static. > > > > > > > > > > N

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-31 Thread Connor Abbott
On Thu, Jul 31, 2014 at 1:05 PM, Eric Anholt wrote: > Connor Abbott writes: >> That's not necessarily true - you could want to spill a trivially >> colored register that interferes with a non trivially colored >> register, especially if the spill cost of the non trivially colored >> register is h

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: don't store number of layers per level

2014-07-31 Thread Jose Fonseca
Series looks good to me too. Seems a nice cleanup. Jose From: srol...@vmware.com Sent: 31 July 2014 19:26 To: Jose Fonseca; mesa-dev@lists.freedesktop.org Cc: Roland Scheidegger Subject: [PATCH 3/3] llvmpipe: don't store number of layers per level From:

Re: [Mesa-dev] [PATCH 12/15] mesa: Add a gles3 error condition for sized internalformat in glCopyTexImage*()

2014-07-31 Thread Anuj Phogat
Courtney, Should I consider this r-b you? On Wed, Jun 11, 2014 at 11:34 AM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > Very good. I thought there might be something limiting the inputs but > wasn't immediately obvious. > > > On Wed, Jun 11, 2014 at 12:09 PM, Anuj Phogat > wrote:

Re: [Mesa-dev] [PATCH 13/15] mesa: Add gles3 error condition for GL_RGBA10_A2 buffer format in glCopyTexImage*()

2014-07-31 Thread Anuj Phogat
On Tue, Jul 29, 2014 at 5:05 PM, Jason Ekstrand wrote: > > > > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat wrote: >> >> Fixes many failures in gles3 Khronos CTS test: packed_pixels >> >> Khronos bug# 9807 >> Cc: >> Signed-off-by: Anuj Phogat >> >> Signed-off-by: Anuj Phogat >> --- >> src/mesa

[Mesa-dev] [PATCH V2] mesa: Add utility function _mesa_is_enum_format_unorm()

2014-07-31 Thread Anuj Phogat
V2: Add missing formats. Cc: Signed-off-by: Anuj Phogat --- src/mesa/main/glformats.c | 71 +++ src/mesa/main/glformats.h | 3 ++ 2 files changed, 74 insertions(+) diff --git a/src/mesa/main/glformats.c b/src/mesa/main/glformats.c index 77eee4f..0fb

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-31 Thread Eric Anholt
Connor Abbott writes: > That's not necessarily true - you could want to spill a trivially > colored register that interferes with a non trivially colored > register, especially if the spill cost of the non trivially colored > register is higher than that of the trivially colored register because >

Re: [Mesa-dev] [PATCH 3/3] llvmpipe: don't store number of layers per level

2014-07-31 Thread Brian Paul
On 07/31/2014 12:26 PM, srol...@vmware.com wrote: From: Roland Scheidegger This could be recalculated, though it turns out the only use of it after resource allocation is for calculating whole resource size (for scene size accounting though that isn't quite ideal neither). Thus, instead just st

Re: [Mesa-dev] Patches queued up for upcoming 10.2.5 release

2014-07-31 Thread Marek Olšák
Hi Carl, I have a few things. 1) Please apply the first attached patch, which fixes is a build failure caused by one of the recent fixes in the branch. (that driver is not built by default) 2) Please cherry-pick this. It's a fix that should have been nominated but wasn't. commit c8011c1885003b7

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Tom Stellard
On Thu, Jul 31, 2014 at 01:28:45PM -0400, Jan Vesely wrote: > On Thu, 2014-07-31 at 11:02 -0400, Tom Stellard wrote: > > On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: > > > Make the function static. > > > > > > > No need to cc llvm-commits on these mesa patches. Reviewers follow bo

Re: [Mesa-dev] [PATCH 10/15] mesa: Don't allow snorm internal formats in glCopyTexImage*() in GLES3

2014-07-31 Thread Jason Ekstrand
On Wed, Jul 30, 2014 at 8:51 PM, Anuj Phogat wrote: > On Tue, Jul 29, 2014 at 5:04 PM, Jason Ekstrand > wrote: > > > > On Fri, Jun 6, 2014 at 4:57 PM, Anuj Phogat > wrote: > >> > >> Fixes few failures in gles3 Khronos CTS test: packed_pixels > >> > >> Cc: "10.2" > >> Signed-off-by: Anuj Phogat

Re: [Mesa-dev] [PATCH 1/2] drm/radeon: s/ioctl_wait_idle/mmio_hpd_flush/

2014-07-31 Thread Alex Deucher
On Thu, Jul 31, 2014 at 5:43 AM, Michel Dänzer wrote: > From: Michel Dänzer > > And clean up the function comment a little. > > Signed-off-by: Michel Dänzer Applied the series to my 3.17 tree. Alex > --- > drivers/gpu/drm/radeon/r600.c| 13 +-- > drivers/gpu/drm/radeon/radeon

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Ilia Mirkin
On Thu, Jul 31, 2014 at 2:27 PM, Jason Ekstrand wrote: > This adds the API entrypoint, error checking logic, and a driver hook for > the ARB_copy_image extension. > > Signed-off-by: Jason Ekstrand > --- > src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ > src/mapi/glapi/gen/gl_API.xml |

[Mesa-dev] [PATCH 5/5] i965: Add support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This, together with the meta path, provides a almost-complete implemetation of ARB_copy_image. The only case that won't work is if one of the textures is compressed and has a pitch greater than INT16_MAX. I think that's good enough to justify turning on the extension. Signed-off-by: Jason Ekstra

[Mesa-dev] [PATCH 4/5] mesa/meta: Add a partial implementation of CopyImageSubData

2014-07-31 Thread Jason Ekstrand
This provides an implementation of CopyImageSubData that works if both textures are uncompressed. This implementation works by using a combination of texture views and BlitFramebuffer. If one of the textures is compressed, it returns false and the driver is expected to provide a fallback. --- sr

[Mesa-dev] [PATCH 3/5] mesa/meta: Add support for storing the current read buffer

2014-07-31 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/mesa/drivers/common/meta.c | 13 + src/mesa/drivers/common/meta.h | 4 src/mesa/drivers/common/meta_blit.c | 3 ++- 3 files changed, 19 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/c

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. Signed-off-by: Jason Ekstrand --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen/gl_API.xml | 2 +- src/mapi/glapi/gen/gl_genexec.py | 1 + src/mesa/Makef

[Mesa-dev] [PATCH 2/5] mesa/meta: Make _mesa_meta_bind_fbo_image also take a framebuffer target

2014-07-31 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/mesa/drivers/common/meta.c | 38 +++--- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_generate_mipmap.c | 4 +-- 3 files changed, 25 insertions(+), 19 deletions(-) diff --git a/src/m

[Mesa-dev] [PATCH 0/5] Implement ARB_copy_image on i965

2014-07-31 Thread Jason Ekstrand
This series implements ARB_copy_image in i965 in two steps: First, we provide a meta implementation that handles the cases when both textures are uncompressed and we can leverage the already-existing code for BlitFramebuffers. The other case, when at least one texture is compressed, is handled by

[Mesa-dev] [PATCH 3/3] llvmpipe: don't store number of layers per level

2014-07-31 Thread sroland
From: Roland Scheidegger This could be recalculated, though it turns out the only use of it after resource allocation is for calculating whole resource size (for scene size accounting though that isn't quite ideal neither). Thus, instead just store the whole resource size and drop it (saving a co

[Mesa-dev] [PATCH 2/3] llvmpipe: integrate memory allocation into llvmpipe_texture_layout

2014-07-31 Thread sroland
From: Roland Scheidegger Seems pointless to just duplicate some of the calculations (the calculation of actual memory used compared to what was predicted in llvmpipe_texture_layout actually could have differed slightly in some cases due to different alignment rules used though this should have be

[Mesa-dev] [PATCH 1/3] llvmpipe: get rid of impossible code in alloc_image_data

2014-07-31 Thread sroland
From: Roland Scheidegger Only used for non display target resources. --- src/gallium/drivers/llvmpipe/lp_texture.c | 39 +++ 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c b/src/gallium/drivers/llvmpipe/lp_te

[Mesa-dev] [PATCH] RFC: glsl/glcpp: Allow for '#' characters to appear in shader body

2014-07-31 Thread Carl Worth
Strictly speaking, the GLSL specification only allows for the '#' to appear in a shader in two places: 1. To introduce a pre-processing directive In this case, the '#' must be the first character on a line after ignoring any comments and horizontal whitespace.

Re: [Mesa-dev] [PATCH V2] mesa: Turn target_can_be_compressed() in to a utility function

2014-07-31 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Wed, Jul 30, 2014 at 6:28 PM, Anuj Phogat wrote: > V2: Declare the function in teximage.h > > Cc: > Signed-off-by: Anuj Phogat > --- > src/mesa/main/teximage.c | 12 ++-- > src/mesa/main/teximage.h | 3 +++ > 2 files changed, 9 insertions(+), 6 delet

Re: [Mesa-dev] [PATCH 0/6] Add support for BPTC texture compression

2014-07-31 Thread Neil Roberts
Hi, I had a quick look at using libsquish and FasTC. I didn't manage to build the libsquish repo¹ that Matt Turner pointed to before giving up. It looks like the SSE version of the compressor is using some MSVC-specific intrinsics which don't build with GCC. It seems to be using members of __m128

[Mesa-dev] Bogus use of '#' in a macro definition (was: Re: Mesa (master): 29 new commits)

2014-07-31 Thread Carl Worth
Ian Romanick writes: > On 07/31/2014 12:14 AM, Michel Dänzer wrote: >> >> FYI, this change broke the game Reaction Quake, see the failure output >> below. I don't know if this is a bug in this change or in the game, so >> I'm reporting it here. Hi Michel, Thanks very much for reporting this fai

Re: [Mesa-dev] [PATCH 2/2] r600g/radeonsi: Prefer VRAM for CPU -> GPU streaming buffers

2014-07-31 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 31, 2014 at 11:43 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/radeon/r600_buffer_common.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH 1/2] r600g/radeonsi: Reduce or even drop special treatment of persistent mappings

2014-07-31 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jul 31, 2014 at 11:43 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/radeon/r600_buffer_common.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/src/galli

Re: [Mesa-dev] [PATCH v2 3/4] ra: consider all spillable nodes for spilling

2014-07-31 Thread Connor Abbott
On Wed, Jul 30, 2014 at 10:50 PM, Eric Anholt wrote: > Connor Abbott writes: > >> Before, we would only consider nodes for spilling if they were >> optimistically pushed onto the stack. But the logic for this was >> complicated, and duplicated some things; also, we might want to spill >> nodes th

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Jan Vesely
On Thu, 2014-07-31 at 11:02 -0400, Tom Stellard wrote: > On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: > > Make the function static. > > > > No need to cc llvm-commits on these mesa patches. Reviewers follow both > lists. sorry about that > > > This needs corresponding change in

Re: [Mesa-dev] [PATCH] i965: Fix 1D Array Shadow miptree layout issue (leading to assert or hang)

2014-07-31 Thread Ben Widawsky
On Thu, Jul 31, 2014 at 12:42:11AM -0700, Jordan Justen wrote: > Fixes assertion failure in piglit (gen6, gen8): > spec/glsl-1.30/execution/tex-miplevel-selection textureOffset 1DArrayShadow > > In release builds of Mesa, this was observed to cause a GPU hang on > gen8. > > Signed-off-by: Jordan

Re: [Mesa-dev] [PATCH 4/6] gallium: Add a dumb drm/kms winsys backed swrast provider

2014-07-31 Thread Jon TURNEY
On 24/07/2014 01:43, Emil Velikov wrote: From: Giovanni Campagna Add a new winsys and target that can be used with a dri2 state tracker and loader instead of drisw. This allows to use gbm as a dri2/image loader and avoid the extra copy from the backbuffer to the shadow frontbuffer. The new dri

Re: [Mesa-dev] Mesa (master): 29 new commits

2014-07-31 Thread Ian Romanick
On 07/31/2014 12:14 AM, Michel Dänzer wrote: > On 30.07.2014 07:11, Carl Worth wrote: >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=f062f0506a5b827667b7eb52136d8420b7e8113b >> Author: Carl Worth >> Date: Wed Jun 25 12:20:22 2014 -0700 >> >> glsl/glcpp: Correctly parse direc

[Mesa-dev] [Bug 79858] Artifacts/Glitches in Blender menu

2014-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79858 Sven Arvidsson changed: What|Removed |Added CC||s...@whiz.se --- Comment #4 from Sven A

Re: [Mesa-dev] [PATCH 2/2] r600g: Pass dimension parameter to compute shader.

2014-07-31 Thread Tom Stellard
On Wed, Jul 30, 2014 at 07:11:35PM -0400, Jan Vesely wrote: > Make the function static. > No need to cc llvm-commits on these mesa patches. Reviewers follow both lists. > This needs corresponding change in LLVM otherwise it breaks parameter passing > > CC: Tom Stellard > CC: Matt Arsenault >

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_query_lod

2014-07-31 Thread Andreas Boll
2014-07-23 18:49 GMT+02:00 Ilia Mirkin : > On Wed, Jul 23, 2014 at 12:45 PM, Matt Turner wrote: >> On Wed, Jul 23, 2014 at 1:48 AM, Glenn Kennard >> wrote: >>> Requires Evergreen or later >>> --- >>> Passes ARB_texture_query_lod piglits, no other regressions, >>> tested on radeon 6670. >> >> Oh,

Re: [Mesa-dev] [PATCH 2/2] r600g/radeonsi: Prefer VRAM for CPU -> GPU streaming buffers

2014-07-31 Thread Christian König
Am 31.07.2014 um 11:57 schrieb Michel Dänzer: On 31.07.2014 18:52, Christian König wrote: Am 31.07.2014 um 11:43 schrieb Michel Dänzer: From: Michel Dänzer Signed-off-by: Michel Dänzer At least for PIPE_USAGE_STREAM buffers that's a bad idea, cause they are used by VDPAU to read back to dat

Re: [Mesa-dev] [PATCH] r600g: gpu_shader5 gl_SampleMaskIn support

2014-07-31 Thread Andreas Boll
Thanks! Pushed. 2014-07-23 18:32 GMT+02:00 Alex Deucher : > On Wed, Jul 23, 2014 at 5:57 AM, Glenn Kennard > wrote: >> Map TGSI_SEMANTIC_SAMPLEMASK to register/component. >> Enable face register when sample mask is needed by shader. >> Requires Evergreen/Cayman >> --- >> I think the rest of the

Re: [Mesa-dev] [PATCH] r600g: Implement gpu_shader5 integer ops

2014-07-31 Thread Andreas Boll
Thanks! Pushed. 2014-07-23 18:29 GMT+02:00 Alex Deucher : > On Wed, Jul 23, 2014 at 5:36 AM, Glenn Kennard > wrote: >> --- >> Together with separate MUL_HI/UMUL_HI patch this passes piglit >> ARB_gpu_shader5 integer tests. >> >> This patch trivially depends on r600g-Implement-GL_ARB_texture_quer

Re: [Mesa-dev] [PATCH] r600g: Add IMUL_HI/UMUL_HI support

2014-07-31 Thread Andreas Boll
Thanks! Pushed. 2014-07-23 18:26 GMT+02:00 Alex Deucher : > On Wed, Jul 23, 2014 at 5:10 AM, Glenn Kennard > wrote: >> Fixes fs-imulExtended, fs-imulExtended-only-msb, fs-umulExtended, >> fs-umulExtended-only-msb piglit tests. >> --- >> Tested on radeon 6670 > > Reviewed-by: Alex Deucher > >> >

Re: [Mesa-dev] [PATCH] r600g: Implement GL_ARB_texture_query_lod

2014-07-31 Thread Andreas Boll
Thanks! Pushed. 2014-07-23 18:26 GMT+02:00 Alex Deucher : > On Wed, Jul 23, 2014 at 4:48 AM, Glenn Kennard > wrote: >> Requires Evergreen or later > > Reviewed-by: Alex Deucher > >> --- >> Passes ARB_texture_query_lod piglits, no other regressions, >> tested on radeon 6670. >> >> docs/GL3.txt

Re: [Mesa-dev] [PATCH 2/2] r600g/radeonsi: Prefer VRAM for CPU -> GPU streaming buffers

2014-07-31 Thread Michel Dänzer
On 31.07.2014 18:52, Christian König wrote: > Am 31.07.2014 um 11:43 schrieb Michel Dänzer: >> From: Michel Dänzer >> >> Signed-off-by: Michel Dänzer > > At least for PIPE_USAGE_STREAM buffers that's a bad idea, cause they are > used by VDPAU to read back to data to a CPU buffer and that's reall

Re: [Mesa-dev] [PATCH 2/2] r600g/radeonsi: Prefer VRAM for CPU -> GPU streaming buffers

2014-07-31 Thread Christian König
Am 31.07.2014 um 11:43 schrieb Michel Dänzer: From: Michel Dänzer Signed-off-by: Michel Dänzer At least for PIPE_USAGE_STREAM buffers that's a bad idea, cause they are used by VDPAU to read back to data to a CPU buffer and that's really slow from VRAM. Christian. --- src/gallium/driv

[Mesa-dev] [PATCH 2/2] r600g/radeonsi: Prefer VRAM for CPU -> GPU streaming buffers

2014-07-31 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeon/r600_buffer_common.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r600_buffer_common.c index 154c

[Mesa-dev] [PATCH 1/2] r600g/radeonsi: Reduce or even drop special treatment of persistent mappings

2014-07-31 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeon/r600_buffer_common.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/r600_buffer_common.c b/src/gallium/drivers/radeon/r600_buffer_common.c index 4e6b897.

[Mesa-dev] [PATCH 2/2] drm/radeon: Always flush the HDP cache before submitting a CS to the GPU

2014-07-31 Thread Michel Dänzer
From: Michel Dänzer This ensures the GPU sees all previous CPU writes to VRAM, which makes it safe: * For userspace to stream data from CPU to GPU via VRAM instead of GTT * For IBs to be stored in VRAM instead of GTT * For ring buffers to be stored in VRAM instead of GTT, if the HPD flush is p

[Mesa-dev] [PATCH 1/2] drm/radeon: s/ioctl_wait_idle/mmio_hpd_flush/

2014-07-31 Thread Michel Dänzer
From: Michel Dänzer And clean up the function comment a little. Signed-off-by: Michel Dänzer --- drivers/gpu/drm/radeon/r600.c| 13 +-- drivers/gpu/drm/radeon/radeon.h | 9 ++-- drivers/gpu/drm/radeon/radeon_asic.c | 44 ++-- drivers/gp

[Mesa-dev] [PATCH 0/2] radeon: Allow streaming data from CPU to GPU via VRAM

2014-07-31 Thread Michel Dänzer
On my Kaveri system, streaming data from CPU to GPU via VRAM is faster than via GTT both with the integrated GPU and with discrete GPUs. The following kernel patches make this safe by always flushing the HDP cache before submitting a command stream to the GPU, and bump the radeon DRM minor version

Re: [Mesa-dev] [PATCH 11/17] i965/gen6 depth surface: program 3DSTATE_DEPTH_BUFFER to top of surface

2014-07-31 Thread Jordan Justen
On Tue, Jul 22, 2014 at 3:09 AM, Pohjolainen, Topi wrote: > On Fri, Jul 18, 2014 at 02:16:46PM -0700, Jordan Justen wrote: >> (bf25ee2 for gen6) >> >> Previously we would always find the 2D sub-surface of interest, >> and then program the surface to this location. Now we always >> program the 3DST

[Mesa-dev] [PATCH] i965: Fix 1D Array Shadow miptree layout issue (leading to assert or hang)

2014-07-31 Thread Jordan Justen
Fixes assertion failure in piglit (gen6, gen8): spec/glsl-1.30/execution/tex-miplevel-selection textureOffset 1DArrayShadow In release builds of Mesa, this was observed to cause a GPU hang on gen8. Signed-off-by: Jordan Justen Cc: Ben Widawsky Cc: Jason Ekstrand Cc: "10.2" --- On a gen6 pigl

Re: [Mesa-dev] Mesa (master): 29 new commits

2014-07-31 Thread Michel Dänzer
On 30.07.2014 07:11, Carl Worth wrote: > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=f062f0506a5b827667b7eb52136d8420b7e8113b > Author: Carl Worth > Date: Wed Jun 25 12:20:22 2014 -0700 > > glsl/glcpp: Correctly parse directives with intervening comments FYI, this change br

Re: [Mesa-dev] [RFC 5/7] i965: Refactor array type resolving

2014-07-31 Thread Pohjolainen, Topi
On Wed, Jul 30, 2014 at 07:38:00PM +0200, Roland Scheidegger wrote: > Am 30.07.2014 19:04, schrieb Topi Pohjolainen: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/brw_state.h | 9 + > > src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 14 +--