Re: [Mesa-dev] [PATCH 2/6] i965/fs: Silence unused parameter warning

2015-03-04 Thread Ian Romanick
On 03/01/2015 05:19 PM, Jason Ekstrand wrote: Not sure why you Cc'd me, but whatever. Seems obvious enough. Because b18fd23 was your commit. Sometimes left over, unused parameters are the result of a mistake. I just wanted to be sure. Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On

[Mesa-dev] [PATCH] glx/tests: add -I src/ to fix make check

2015-03-04 Thread Brian Paul
--- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/tests/Makefile.am b/src/glx/tests/Makefile.am index dd82449..b02a9e3 100644 --- a/src/glx/tests/Makefile.am +++ b/src/glx/tests/Makefile.am @@ -2,6 +2,7 @@ if HAVE_SHARED_GLAPI AM_CFLAGS = $(PTHREAD_CFLAGS)

Re: [Mesa-dev] [PATCH 2/2] common: Correct PBO 2D_ARRAY handling.

2015-03-04 Thread Laura Ekstrand
The Meta PBO upload path does not exist in 10.4, so we don't need to worry about a backport. On Tue, Mar 3, 2015 at 6:01 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 24 February 2015 at 23:20, Laura Ekstrand la...@jlekstrand.net wrote: Changes PBO uploads and downloads to use a tall

[Mesa-dev] [PATCH 3/3] meta: Fix the y offset for 1D_ARRAY in _mesa_meta_pbo_TexSubImage

2015-03-04 Thread Neil Roberts
The yoffset needs to be interpreted as a slice offset for 1D array textures. This patch implements that by moving the yoffset into zoffset similar to how it moves the height into depth. --- src/mesa/drivers/common/meta_tex_subimage.c | 8 1 file changed, 8 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-04 Thread Chad Versace
On 02/26/2015 05:24 AM, Chris Wilson wrote: When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame boundary. Conventionally we use SwapBuffers and glFinish, but potential

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-04 Thread Chris Wilson
On Wed, Mar 04, 2015 at 09:41:56AM -0800, Chad Versace wrote: On 02/26/2015 05:24 AM, Chris Wilson wrote: When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to an fbo, there is no natural frame

Re: [Mesa-dev] [PATCH] glx/tests: add -I src/ to fix make check

2015-03-04 Thread Brian Paul
Right. -Brian On 03/04/2015 10:56 AM, Ian Romanick wrote: Due to 0339e7db, right? If so, Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 03/04/2015 09:03 AM, Brian Paul wrote: --- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] clover: Enable cl_khr_fp64 for devices that support doubles v4

2015-03-04 Thread Tom Stellard
v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from extension string. - Rename device query function from cl_khr_fp86() to

[Mesa-dev] [PATCH v2] i965/skl: Disable SIMD16 when 3-source instructions are used

2015-03-04 Thread Neil Roberts
Steppings C0 and D0 of Skylake fail when using SIMD16 with 3-source instructions (such as MAD). This patch just makes it disable SIMD16 in those cases. This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit tests. v2: Also apply on stepping D0 --- Damien Lespiau pointed out that the

Re: [Mesa-dev] [PATCH] gallivm: init MM = NULL to silence warning

2015-03-04 Thread Mark Janes
Hi Brian, Did you try to `make check` in mesa with these patches? I get errors compiling glx-test: src/glx/glxclient.h:59:25: fatal error: util/macros.h: No such file or directory -Mark Brian Paul bri...@vmware.com writes: --- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 2 +- 1 file

Re: [Mesa-dev] [PATCH 1/2] i965: Store the GPU revision number in brw_context

2015-03-04 Thread Kristian Høgsberg
On Wed, Mar 4, 2015 at 6:32 AM, Neil Roberts n...@linux.intel.com wrote: brwContextInit now queries the GPU revision number via a new parameter for DRM_I915_GETPARAM. This new parameter requires a kernel patch and a patch to libdrm. If the kernel doesn't support it then it will continue but

[Mesa-dev] [PATCH v2 6/6] i965: Don't write past the end of the application supplied buffer

2015-03-04 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com Both the AMD and Intel APIs provide a dataSize parameter, and this function would merrily ignore it. Neither API specifies what to do when the buffer isn't big enough. I take the easy route of writing all the complete bits of data that will fit. With

[Mesa-dev] [PATCH 2/3] meta: Allow GL_UN/PACK_IMAGE_HEIGHT in _mesa_meta_pbo_Get/TexSubImage

2015-03-04 Thread Neil Roberts
Now that a layered source PBO is interpreted as a single tall 2D image it's quite easy to accept the image height packing option by just creating an image that is tall enough to include the image padding. I'm not sure whether the image height property should affect 1D_ARRAY textures. My intuition

Re: [Mesa-dev] [PATCH] glx/tests: add -I src/ to fix make check

2015-03-04 Thread Ian Romanick
Due to 0339e7db, right? If so, Reviewed-by: Ian Romanick ian.d.roman...@intel.com On 03/04/2015 09:03 AM, Brian Paul wrote: --- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glx/tests/Makefile.am b/src/glx/tests/Makefile.am index dd82449..b02a9e3

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptrRTDyldMemoryManager'

2015-03-04 Thread Roland Scheidegger
Am 04.03.2015 um 12:38 schrieb Jose Fonseca: On 04/03/15 02:00, Emil Velikov wrote: On 27 February 2015 at 23:28, Sedat Dilek sedat.di...@gmail.com wrote: On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 07/02/15 21:44, Sedat Dilek wrote: Hi, I was building

Re: [Mesa-dev] [PATCH 5/6] i965: Silence unused parameter warning

2015-03-04 Thread Ian Romanick
On 02/28/2015 10:33 AM, Ilia Mirkin wrote: On Sat, Feb 28, 2015 at 1:26 PM, Carl Worth cwo...@cworth.org wrote: On Fri, Feb 27 2015, Ian Romanick wrote: All dd functions take a gl_context as the first parameter. Instead of removing it, just silence the warning. For code using gcc, I really

Re: [Mesa-dev] [PATCH] mapi: fix build after 8aa9191878a5608fc6e4e8c72bea1d25cd821dec

2015-03-04 Thread Ian Romanick
Brian also sent this patch, and I sent his a R-b because I saw it first. :) On 03/04/2015 09:49 AM, Mark Janes wrote: Due to recent #include changes, `make check` fails on glx-test. The target requires a standard include path to find util/macros.h. --- src/glx/tests/Makefile.am | 1 + 1

Re: [Mesa-dev] [PATCH v2] i965/skl: Disable SIMD16 when 3-source instructions are used

2015-03-04 Thread Kristian Høgsberg
On Wed, Mar 4, 2015 at 9:20 AM, Neil Roberts n...@linux.intel.com wrote: Steppings C0 and D0 of Skylake fail when using SIMD16 with 3-source instructions (such as MAD). This patch just makes it disable SIMD16 in those cases. This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit

Re: [Mesa-dev] [PATCH 5/6] main: Refactor Tex[ture]Buffer[Range].

2015-03-04 Thread Anuj Phogat
On Fri, Feb 27, 2015 at 4:07 PM, Laura Ekstrand la...@jlekstrand.net wrote: Uses _mesa_lookup_bufferobj_err to clean up buffer object retrieval. Moves error checking statements into separate functions to allow code sharing between traditional and ARB_direct_state_access entry points. It's

Re: [Mesa-dev] [PATCH 4/6] main: Add utility function _mesa_lookup_bufferobj_err.

2015-03-04 Thread Anuj Phogat
On Tue, Mar 3, 2015 at 5:39 PM, Laura Ekstrand la...@jlekstrand.net wrote: I also need it in teximage.c for Texture Buffer objects. Right. That's just one file in this series. Mention it in the commit message If you're aware of future use of this function in multiple files. On Tue, Mar 3, 2015

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-04 Thread Chris Wilson
On Wed, Mar 04, 2015 at 10:28:16AM -0800, Chad Versace wrote: On 03/04/2015 09:52 AM, Chris Wilson wrote: The manpage for glFlush says glFlush can return at any time. It does not wait until the execution of *all* previously issued GL commands is complete. Emphasis mine. In

Re: [Mesa-dev] [PATCH] i965: Throttle rendering to an fbo

2015-03-04 Thread Chad Versace
On 03/04/2015 09:52 AM, Chris Wilson wrote: On Wed, Mar 04, 2015 at 09:41:56AM -0800, Chad Versace wrote: On 02/26/2015 05:24 AM, Chris Wilson wrote: When rendering to an fbo, even though it may be acting as a winsys frontbuffer or just generally, we never throttle. However, when rendering to

Re: [Mesa-dev] [PATCH] mapi: fix build after 8aa9191878a5608fc6e4e8c72bea1d25cd821dec

2015-03-04 Thread Jose Fonseca
Reviewed-by: Jose Fonseca jfons...@vmware.com On 04/03/15 17:49, Mark Janes wrote: Due to recent #include changes, `make check` fails on glx-test. The target requires a standard include path to find util/macros.h. --- src/glx/tests/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

2015-03-04 Thread Mark Janes
Jose Fonseca jfons...@vmware.com writes: From: José Fonseca jfons...@vmware.com This is just to help repro and fixing these issues with any C++ compiler -- commiting this will of course wait until all issues are addressed. Hi Jose, I have a patch which trivially fixes extern C in the 14

Re: [Mesa-dev] [PATCH 1/2] i965: Refactor SIMD16-to-2xSIMD8 checks.

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 12:53 PM, Kenneth Graunke kenn...@whitecape.org wrote: Gathering all the checks into a single place makes it easier to add new workarounds. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Neil Roberts n...@linux.intel.com Cc: Matt Turner matts...@gmail.com

Re: [Mesa-dev] [PATCH 2/6] i965/fs: Silence unused parameter warning

2015-03-04 Thread Jason Ekstrand
On Wed, Mar 4, 2015 at 8:45 AM, Ian Romanick i...@freedesktop.org wrote: On 03/01/2015 05:19 PM, Jason Ekstrand wrote: Not sure why you Cc'd me, but whatever. Seems obvious enough. Because b18fd23 was your commit. Sometimes left over, unused parameters are the result of a mistake. I just

[Mesa-dev] [PATCH 1/2] i965: Refactor SIMD16-to-2xSIMD8 checks.

2015-03-04 Thread Kenneth Graunke
Gathering all the checks into a single place makes it easier to add new workarounds. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Neil Roberts n...@linux.intel.com Cc: Matt Turner matts...@gmail.com --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 28 +--

[Mesa-dev] [PATCH 2/2] i965/skl: Break down SIMD16 3-source instructions when required.

2015-03-04 Thread Kenneth Graunke
Several steppings of Skylake fail when using SIMD16 with 3-source instructions (such as MAD). This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit tests. Based on a patch by Neil Roberts. Signed-off-by: Kenneth Graunke kenn...@whitecape.org Cc: Neil Roberts n...@linux.intel.com Cc:

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Break down SIMD16 3-source instructions when required.

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 12:53 PM, Kenneth Graunke kenn...@whitecape.org wrote: Several steppings of Skylake fail when using SIMD16 with 3-source instructions (such as MAD). This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit tests. Based on a patch by Neil Roberts.

Re: [Mesa-dev] [PATCH] clover: Enable cl_khr_fp64 for devices that support doubles v4

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 7:47 AM, Tom Stellard thomas.stell...@amd.com wrote: v2: - Report correct values for CL_DEVICE_NATIVE_VECTOR_WIDTH_DOUBLE and CL_DEVICE_PREFERRED_VECTOR_WIDTH_DOUBLE. - Only define cl_khr_fp64 if the extension is supported. - Remove trailing space from

Re: [Mesa-dev] [PATCH 2/2] i965/skl: Disable SIMD16 when 3-source instructions are used

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 6:33 AM, Neil Roberts n...@linux.intel.com wrote: Stepping C0 of Skylake fails when using SIMD16 with 3-source instructions (such as MAD). This patch just makes it disable SIMD16 in that case. This implements WaDisableSIMD16On3SrcInstr and fixes ~190 Piglit tests. ---

[Mesa-dev] [PATCH] mesa/st: remove unused TexData

2015-03-04 Thread Dave Airlie
this isn't hooked up to anything at all from what I can see. Signed-off-by: Dave Airlie airl...@redhat.com --- src/mesa/state_tracker/st_cb_texture.c | 21 - src/mesa/state_tracker/st_texture.h| 6 -- 2 files changed, 27 deletions(-) diff --git

[Mesa-dev] [PATCH 0/6] v2 of Compressed Textures Cube Map Support

2015-03-04 Thread Laura Ekstrand
This cleans up ARB_direct_state_access texture cube map functions (mostly in response to reviews from Anuj Phogat). Laura Ekstrand (6): main: _mesa_cube_level_complete checks NumLayers. main: Remove redundant NumLayers checks. main: Remove redundant copy of cube map block comment in

[Mesa-dev] [PATCH 6/6] main: Checking for cube completeness in GetCompressedTextureImage.

2015-03-04 Thread Laura Ekstrand
v2: Review from Anuj Phogat - Remove redundant copies of the cube map block comment - Replace redundant if (!texImage) return; statements with assert(texImage) --- src/mesa/main/texgetimage.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 1/6] main: _mesa_cube_level_complete checks NumLayers.

2015-03-04 Thread Laura Ekstrand
_mesa_cube_level_complete now verifies that a cube map texture object actually has six texture images before proceeding. --- src/mesa/main/texobj.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index d5aa620..0b200a1 100644 ---

[Mesa-dev] [PATCH 2/6] main: Remove redundant NumLayers checks.

2015-03-04 Thread Laura Ekstrand
ARB_direct_state_access texture functions that operate on cube maps no longer need to verify that cube map texture objects contain six texture images because _mesa_cube_level_complete now does that for them. --- src/mesa/main/texgetimage.c | 13 - src/mesa/main/teximage.c| 14

[Mesa-dev] [PATCH] i965: Reserve more batch space to accomodate Gen6 perfmonitors.

2015-03-04 Thread Kenneth Graunke
Ben noticed that I said each PIPE_CONTROL was 4 DWords, but it's actually 5 DWords on Gen6-7. We've been reserving insufficient space for performance monitoring on Sandybridge, which means it would likely break if you used that functionality. (Thankfully, no one does...) Signed-off-by: Kenneth

Re: [Mesa-dev] [PATCH v2 6/6] i965: Don't write past the end of the application supplied buffer

2015-03-04 Thread Jan Vesely
On Wed, 2015-03-04 at 09:55 -0800, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Both the AMD and Intel APIs provide a dataSize parameter, and this function would merrily ignore it. Neither API specifies what to do when the buffer isn't big enough. I take the easy route

Re: [Mesa-dev] State of Geometry shader instancing on radeonsi

2015-03-04 Thread Alexandre Demers
Then you can count me as working on ARB_viewport_array. Alexandre Demers On 2015-02-25 14:25, Marek Olšák wrote: Nobody is working on ARB_gpu_shader5 for radeonsi. Marek On Wed, Feb 25, 2015 at 6:41 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Feb 25, 2015 at 11:24 AM, Alexandre

Re: [Mesa-dev] [PATCH 1/3] Revert common: Fix PBOs for 1D_ARRAY.

2015-03-04 Thread Jason Ekstrand
Series is Reviewed-by: Jason Ekstrand jason.ekstr...@intel.com On Wed, Mar 4, 2015 at 3:15 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 4 March 2015 at 17:22, Neil Roberts n...@linux.intel.com wrote: This reverts commit 546aba143d13ba3f993ead4cc30b2404abfc0202. I think the changes

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

2015-03-04 Thread Jason Ekstrand
On Wed, Mar 4, 2015 at 5:28 PM, Matt Turner matts...@gmail.com wrote: On Wed, Mar 4, 2015 at 5:07 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Mar 4, 2015 at 4:56 PM, Matt Turner matts...@gmail.com wrote: @@ -357,16 +394,22 @@ linear_to_xtiled_faster(uint32_t x0, uint32_t x1,

Re: [Mesa-dev] [PATCH] i965: Reserve more batch space to accomodate Gen6 perfmonitors.

2015-03-04 Thread Anuj Phogat
On Wed, Mar 4, 2015 at 3:46 PM, Kenneth Graunke kenn...@whitecape.org wrote: Ben noticed that I said each PIPE_CONTROL was 4 DWords, but it's actually 5 DWords on Gen6-7. We've been reserving insufficient space for performance monitoring on Sandybridge, which means it would likely break if

[Mesa-dev] [Bug 89433] GCC 4.2 does not support -Wvla

2015-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89433 --- Comment #1 from Jonathan Gray j...@openbsd.org --- Created attachment 114016 -- https://bugs.freedesktop.org/attachment.cgi?id=114016action=edit make -Wvla conditional How about the attached patch to make it conditional on the GCC version?

[Mesa-dev] [Bug 89433] GCC 4.2 does not support -Wvla

2015-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89433 Bug ID: 89433 Summary: GCC 4.2 does not support -Wvla Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords:

[Mesa-dev] [PATCH 1/7] main: Add utility function _mesa_lookup_bufferobj_err.

2015-03-04 Thread Laura Ekstrand
This function is exposed to mesa driver internals so that texture buffer objects and array objects can use it. --- src/mesa/main/bufferobj.c | 19 +++ src/mesa/main/bufferobj.h | 4 2 files changed, 23 insertions(+) diff --git a/src/mesa/main/bufferobj.c

Re: [Mesa-dev] [PATCH] include: Add helper header to help trap includes inside extern C.

2015-03-04 Thread Mark Janes
Assuming my patch to fix 'extern C' issues is pushed before this one, Reviewed-by: Mark Janes mark.a.ja...@intel.com Jose Fonseca jfons...@vmware.com writes: From: José Fonseca jfons...@vmware.com This is just to help repro and fixing these issues with any C++ compiler -- commiting this

Re: [Mesa-dev] New stable-branch 10.4 candidate pushed

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 4:53 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Trivial merge conflicts --- Here are the commits where I manually merged conflicts, so these might merit additional review: commit a598a9bdfe9f5d0ed35ca89a55cf74a2b678e8e1 Author: Matt Turner

Re: [Mesa-dev] [PATCH 2/3] meta: Allow GL_UN/PACK_IMAGE_HEIGHT in _mesa_meta_pbo_Get/TexSubImage

2015-03-04 Thread Laura Ekstrand
I have a new texturing/getteximage-targets test on the Piglit ML that cleans up the test considerably and causes it to hit these Meta PBO paths. It just hasn't been given R-B's yet. http://patchwork.freedesktop.org/patch/42864/ On Wed, Mar 4, 2015 at 9:22 AM, Neil Roberts n...@linux.intel.com

[Mesa-dev] [PATCH 12/12] osmesa: include stdio.h

2015-03-04 Thread Brian Paul
--- src/mesa/drivers/osmesa/osmesa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/osmesa/osmesa.c b/src/mesa/drivers/osmesa/osmesa.c index 9f1a5a8..022523e 100644 --- a/src/mesa/drivers/osmesa/osmesa.c +++ b/src/mesa/drivers/osmesa/osmesa.c @@ -33,6 +33,7 @@ */

[Mesa-dev] [PATCH 5/7] mapi: THREADS was always defined, remove it

2015-03-04 Thread Brian Paul
THREADS was defined if HAVE_PTHREADS or _WIN32 was defined. That's always the case. The build would die in c11/threads.h otherwise. --- src/mapi/glapi/gen/gl_x86-64_asm.py | 6 +- src/mapi/glapi/gen/gl_x86_asm.py| 14 ++ src/mapi/glapi/glapi.h | 13

[Mesa-dev] [PATCH 1/7] mapi: remove u_macros.h

2015-03-04 Thread Brian Paul
Only U_STRINGIFY() is used in entry.c --- src/mapi/Makefile.sources | 1 - src/mapi/entry.c| 4 +++- src/mapi/entry_x86-64_tls.h | 1 - src/mapi/entry_x86_tls.h| 1 - src/mapi/entry_x86_tsd.h| 1 - src/mapi/u_macros.h | 12 6 files changed, 3

[Mesa-dev] [PATCH 08/12] st/xlib: include stdio.h

2015-03-04 Thread Brian Paul
--- src/gallium/state_trackers/glx/xlib/glx_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/glx/xlib/glx_api.c b/src/gallium/state_trackers/glx/xlib/glx_api.c index f59b0ba..d1bd760 100644 --- a/src/gallium/state_trackers/glx/xlib/glx_api.c +++

[Mesa-dev] [PATCH 07/12] st/mesa: include stdio.h where needed

2015-03-04 Thread Brian Paul
--- src/mesa/state_tracker/st_atom.c | 1 + src/mesa/state_tracker/st_cb_texture.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c index 8cc6af2..f0fe11f 100644 --- a/src/mesa/state_tracker/st_atom.c +++

[Mesa-dev] [PATCH 03/12] glsl: include stdio.h where needed

2015-03-04 Thread Brian Paul
--- src/glsl/s_expression.cpp | 1 + src/glsl/standalone_scaffolding.cpp | 1 + 2 files changed, 2 insertions(+) diff --git a/src/glsl/s_expression.cpp b/src/glsl/s_expression.cpp index 2928a4d..7eaa491 100644 --- a/src/glsl/s_expression.cpp +++ b/src/glsl/s_expression.cpp @@ -24,6

[Mesa-dev] [PATCH 04/12] dri/common: include stdio.h where needed

2015-03-04 Thread Brian Paul
--- src/mesa/drivers/dri/common/utils.c | 1 + src/mesa/drivers/dri/common/xmlconfig.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/utils.c index ccdc971..bb22107 100644 --- a/src/mesa/drivers/dri/common/utils.c +++

[Mesa-dev] [PATCH 10/12] st/osmesa: include stdio.h

2015-03-04 Thread Brian Paul
--- src/gallium/state_trackers/osmesa/osmesa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/osmesa/osmesa.c b/src/gallium/state_trackers/osmesa/osmesa.c index 4e2b2e0..2d5d096 100644 --- a/src/gallium/state_trackers/osmesa/osmesa.c +++

[Mesa-dev] [PATCH 01/12] mesa: include c11/threads.h in mtypes.h

2015-03-04 Thread Brian Paul
Let's directly include c11/threads.h instead of relying on glapi.h to provide it. --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 6e99773..efeee8b 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 09/12] st/xlib: include stdio.h

2015-03-04 Thread Brian Paul
--- src/gallium/state_trackers/glx/xlib/glx_usefont.c | 1 + src/gallium/state_trackers/glx/xlib/xm_api.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/gallium/state_trackers/glx/xlib/glx_usefont.c b/src/gallium/state_trackers/glx/xlib/glx_usefont.c index f7ee68b..b3e9c79 100644

[Mesa-dev] [PATCH 02/12] mesa: include stdio.h where needed

2015-03-04 Thread Brian Paul
Instead of relying on glapi.h or some other header to provide it. --- src/mesa/main/blit.c | 1 + src/mesa/main/debug.c | 1 + src/mesa/main/dlist.h | 2 +- src/mesa/main/errors.c| 1 + src/mesa/main/execmem.c | 1 +

[Mesa-dev] [PATCH 05/12] nouveau: include stdio.h where needed

2015-03-04 Thread Brian Paul
--- src/mesa/drivers/dri/nouveau/nouveau_context.c | 1 + src/mesa/drivers/dri/nouveau/nouveau_driver.c | 1 + src/mesa/drivers/dri/nouveau/nouveau_screen.c | 1 + 3 files changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_context.c

[Mesa-dev] [PATCH 06/12] swrast: include stdio.h where needed

2015-03-04 Thread Brian Paul
--- src/mesa/drivers/dri/swrast/swrast.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/swrast/swrast.c b/src/mesa/drivers/dri/swrast/swrast.c index b801476..fb29078 100644 --- a/src/mesa/drivers/dri/swrast/swrast.c +++ b/src/mesa/drivers/dri/swrast/swrast.c @@ -32,6

[Mesa-dev] [PATCH 2/7] mapi: fix preprocessor check in u_current_destroy()

2015-03-04 Thread Brian Paul
So it matches the preprocessor check around the u_current_init_tsd() code. --- src/mapi/u_current.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/u_current.c b/src/mapi/u_current.c index afa887e..eb77cc7 100644 --- a/src/mapi/u_current.c +++ b/src/mapi/u_current.c

[Mesa-dev] [PATCH 3/7] mapi: rewrite u_current_init() function without u_thread_self()

2015-03-04 Thread Brian Paul
Remove u_thread_self() since u_thread.h is going away soon. Create a simple thread ID abstraction which wraps WIN32 or c11 threads. This also gets rid of the questionable casting of thrd_t to an unsigned long. --- src/mapi/u_current.c | 43 ---

[Mesa-dev] [PATCH 11/12] xlib: include stdio.h

2015-03-04 Thread Brian Paul
--- src/mesa/drivers/x11/fakeglx.c | 2 +- src/mesa/drivers/x11/xfonts.c | 1 + src/mesa/drivers/x11/xm_api.c | 1 + src/mesa/drivers/x11/xm_tri.c | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/x11/fakeglx.c b/src/mesa/drivers/x11/fakeglx.c index

[Mesa-dev] [PATCH 6/7] mapi: use c11 call_once() instead of pthread_once()

2015-03-04 Thread Brian Paul
--- src/mapi/glapi/glapi_entrypoint.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mapi/glapi/glapi_entrypoint.c b/src/mapi/glapi/glapi_entrypoint.c index 53104ce..7facd8a 100644 --- a/src/mapi/glapi/glapi_entrypoint.c +++ b/src/mapi/glapi/glapi_entrypoint.c @@

[Mesa-dev] [PATCH 4/7] mesa: remove THREADS check, printf calls in debug.c

2015-03-04 Thread Brian Paul
THREADS is going away in the next commit. --- src/mesa/main/debug.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/mesa/main/debug.c b/src/mesa/main/debug.c index eda4937..b50d79e 100644 --- a/src/mesa/main/debug.c +++ b/src/mesa/main/debug.c @@ -118,11 +118,6 @@ void

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptrRTDyldMemoryManager'

2015-03-04 Thread Sedat Dilek
On Wed, Mar 4, 2015 at 3:00 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 27 February 2015 at 23:28, Sedat Dilek sedat.di...@gmail.com wrote: On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 07/02/15 21:44, Sedat Dilek wrote: Hi, I was building mesa

[Mesa-dev] [PATCH] i965/hsw: Implement end of batch workaround

2015-03-04 Thread Ben Widawsky
This patch can cause an infinite recursion if the previous patch titled, i965: Track finished batch state isn't present (backporters take notice). v2: Sent out the wrong patch originally. This patches switches the order of flushes, doing the generic flush before the CC_STATE, and the required

[Mesa-dev] [Bug 89364] c99_alloca.h:40:22: fatal error: alloca.h: No such file or directory

2015-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89364 Vinson Lee v...@freedesktop.org changed: What|Removed |Added Status|REOPENED|RESOLVED

[Mesa-dev] [PATCH 4/6] main: assert(texImage) in ARB_DSA texture cube map functions.

2015-03-04 Thread Laura Ekstrand
ARB_direct_state_access functions that deal with texture cube maps need to make sure that texture images are not NULL before operating on them. In the following cases, the error check functions already throw an error if texImage == NULL, so an assert can be raised instead. v2: Review from Anuj

[Mesa-dev] [PATCH 3/6] main: Remove redundant copy of cube map block comment in GetTextureImage.

2015-03-04 Thread Laura Ekstrand
The comment describing why ARB_direct_state_access texture cube map functions use _mesa_cube_level_complete is very long. To save room in the files, readers are now referred to one central comment on texturesubimage in teximage.c. v2: Review from Anuj Phogat - Remove redundant copies of the

[Mesa-dev] [PATCH 5/6] main: Add TEXTURE_CUBE_MAP support for glCompressedTextureSubImage3D.

2015-03-04 Thread Laura Ekstrand
v2: Review from Anuj Phogat - Remove redundant copies of the cube map block comment - Replace redundant if (!texImage) return; statements with assert(texImage) --- src/mesa/main/teximage.c | 158 +++ src/mesa/main/teximage.h | 3 +- 2 files

[Mesa-dev] [PATCH] Fix invalid extern C around header inclusion.

2015-03-04 Thread Mark Janes
System headers may contain C++ declarations, which cannot be given C linkage. For this reason, include statements should never occur inside extern C. This patch moves the C linkage statements to enclose only the declarations within a single header. --- src/gallium/auxiliary/util/u_math.h

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

2015-03-04 Thread Jason Ekstrand
On Wed, Mar 4, 2015 at 4:56 PM, Matt Turner matts...@gmail.com wrote: The SSSE3 swizzling code was written for fast uploads to the GPU and assumed the destination was always 16-byte aligned. When we began using this code for fast downloads as well we didn't do anything to account for the fact

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 5:07 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, Mar 4, 2015 at 4:56 PM, Matt Turner matts...@gmail.com wrote: @@ -357,16 +394,22 @@ linear_to_xtiled_faster(uint32_t x0, uint32_t x1, uint32_t x2, uint32_t x3, if (mem_copy == memcpy) return

Re: [Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

2015-03-04 Thread Jason Ekstrand
On Wed, Mar 4, 2015 at 4:19 PM, Matt Turner matts...@gmail.com wrote: The SSSE3 swizzling code was written for fast uploads to the GPU and assumed the destination was always 16-byte aligned. When we began using this code for fast downloads as well we didn't do anything to account for the fact

[Mesa-dev] [PATCH 3/7] main: Refactor _mesa_texture_buffer_range.

2015-03-04 Thread Laura Ekstrand
Changes how the caller is identified in error messages, moves a check for ARB_texture_buffer_object from the entry points to the shared code in _mesa_texture_buffer_range, and removes an unused argument (GLenum target). v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] ---

[Mesa-dev] [PATCH 5/7] main: Add check_texture_buffer_range.

2015-03-04 Thread Laura Ekstrand
Creates a shared function that TexBufferRange and TextureBufferRange can use to check the buffer range. This cleans up TexBufferRange considerably. v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] --- src/mesa/main/teximage.c | 73

[Mesa-dev] [PATCH 2/7] main: Use _mesa_lookup_bufferobj_err to simplify Tex[ture]Buffer[Range].

2015-03-04 Thread Laura Ekstrand
v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] - Closing curly brace on the same line as else --- src/mesa/main/teximage.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c

[Mesa-dev] [PATCH 4/7] main: Cosmetic changes for Texture Buffers.

2015-03-04 Thread Laura Ekstrand
Adds a useful comment and some whitespace. Fixes an error message. v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] --- src/mesa/main/teximage.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/teximage.c

[Mesa-dev] [PATCH 6/7] main: Add check_texture_buffer_target.

2015-03-04 Thread Laura Ekstrand
Creates a shared function to ensure that texture buffer target is GL_TEXTURE_BUFFER. Helps to clean up the Tex[ture]Buffer[Range] functions. v2: Review from Anuj Phogat - Split rebase of Tex[ture]Buffer[Range] --- src/mesa/main/teximage.c | 39 --- 1 file

[Mesa-dev] [PATCH 7/7] main: Add entry point for TextureBufferRange.

2015-03-04 Thread Laura Ekstrand
v2: Review by Martin Peres - Get rid of difficult-to-follow code copied and pasted from the original TexBufferRange --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 + src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/teximage.c | 46

[Mesa-dev] [PATCH 0/7] v2 of Tex[ture]Buffer[Range] functions

2015-03-04 Thread Laura Ekstrand
This divides a major rework of Tex[ture]Buffer[Range] into multiple patches as recommended by Anuj Phogat. Laura Ekstrand (7): main: Add utility function _mesa_lookup_bufferobj_err. main: Use _mesa_lookup_bufferobj_err to simplify Tex[ture]Buffer[Range]. main: Refactor

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 79098, which changed state. Bug 79098 Summary: x86/common_x86.c:51:19: error: cpuid.h: No such file or directory https://bugs.freedesktop.org/show_bug.cgi?id=79098 What|Removed |Added

[Mesa-dev] [Bug 79098] x86/common_x86.c:51:19: error: cpuid.h: No such file or directory

2015-03-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79098 Matt Turner matts...@gmail.com changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] i965: Split Gen4-5 BlitFramebuffer code; prefer BLT over Meta.

2015-03-04 Thread Kenneth Graunke
A while back I switched intel_blit_framebuffer to prefer Meta over the BLT. This meant that Gen8 platforms would start using the 3D engine for blits, just like we do on Gen6-7.5. However, I hadn't considered Gen4-5 when making that change. The BLT engine appears to be substantially faster on

Re: [Mesa-dev] [PATCH 1/3] Revert common: Fix PBOs for 1D_ARRAY.

2015-03-04 Thread Emil Velikov
On 4 March 2015 at 17:22, Neil Roberts n...@linux.intel.com wrote: This reverts commit 546aba143d13ba3f993ead4cc30b2404abfc0202. I think the changes to the calls to glBlitFramebuffer from this patch are no different to what it was doing previously because it used to set height to 1 before

[Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

2015-03-04 Thread Matt Turner
The SSSE3 swizzling code was written for fast uploads to the GPU and assumed the destination was always 16-byte aligned. When we began using this code for fast downloads as well we didn't do anything to account for the fact that the destination pointer given by glReadPixels() or glGetTexImage() is

[Mesa-dev] [PATCH] i965: Tell intel_get_memcpy() which direction the memcpy() is going.

2015-03-04 Thread Matt Turner
The SSSE3 swizzling code was written for fast uploads to the GPU and assumed the destination was always 16-byte aligned. When we began using this code for fast downloads as well we didn't do anything to account for the fact that the destination pointer given by glReadPixels() or glGetTexImage() is

Re: [Mesa-dev] [PATCH 2/7] mapi: fix preprocessor check in u_current_destroy()

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 8:18 PM, Matt Turner matts...@gmail.com wrote: Patches 1-2 are Reviewed-by: Matt Turner matts...@gmail.com As are patches 3-7. Thanks Brian! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 2/7] mapi: fix preprocessor check in u_current_destroy()

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 6:19 PM, Brian Paul bri...@vmware.com wrote: So it matches the preprocessor check around the u_current_init_tsd() code. --- src/mapi/u_current.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/u_current.c b/src/mapi/u_current.c index

Re: [Mesa-dev] [PATCH 01/12] mesa: include c11/threads.h in mtypes.h

2015-03-04 Thread Matt Turner
On Wed, Mar 4, 2015 at 6:18 PM, Brian Paul bri...@vmware.com wrote: Let's directly include c11/threads.h instead of relying on glapi.h to provide it. --- This one is Reviewed-by: Matt Turner matts...@gmail.com The rest are Acked-by: Matt Turner matts...@gmail.com

Re: [Mesa-dev] [PATCH] main/base_tex_format: Properly handle STENCIL_INDEX1/4/16

2015-03-04 Thread Pohjolainen, Topi
On Tue, Mar 03, 2015 at 05:08:23PM +, Neil Roberts wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Mon, Mar 2, 2015 at 11:33 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Mon, Mar 2, 2015 at 2:32 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Mon, Mar 2, 2015 at

Re: [Mesa-dev] egl dma-buf export extension again

2015-03-04 Thread Daniel Stone
Hi, On 3 March 2015 at 23:26, Kristian Høgsberg k...@bitplanet.net wrote: On Tue, Mar 3, 2015 at 10:43 AM, Chad Versace chad.vers...@intel.com wrote: Please use EGLImages as the import/export object. That provides consistency with existing similar EGL APIs. And it allows a clean separation

Re: [Mesa-dev] [PATCH] glsl: Fix GCC unused-variable warning in release build.

2015-03-04 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au On Tue, 2015-03-03 at 18:49 -0800, Vinson Lee wrote: CXX ast_array_index.lo ast_array_index.cpp: In function ‘void update_max_array_access(ir_rvalue*, int, YYLTYPE*, _mesa_glsl_parse_state*)’: ast_array_index.cpp:86:30: warning: unused

Re: [Mesa-dev] RFC: Prune stale components

2015-03-04 Thread Jose Fonseca
On 04/03/15 00:24, Emil Velikov wrote: On 03/03/15 22:04, Jose Fonseca wrote: On 03/03/15 18:39, Emil Velikov wrote: On 3 March 2015 at 17:16, Jose Fonseca jfons...@vmware.com wrote: ... I've prototyped this in

Re: [Mesa-dev] [PATCH excerpt] mesa: Wrap unlikely() around conditions leading to _mesa_error().

2015-03-04 Thread Kenneth Graunke
On Monday, March 02, 2015 03:03:00 PM Eric Anholt wrote: Kenneth Graunke kenn...@whitecape.org writes: Generated by the following Coccinelle semantic patch: @@ expression E; @@ if ( -E +unlikely(E) ) { ... _mesa_error(...) ... } Improves performance in OglBatch7 (a

Re: [Mesa-dev] RFC: Prune stale components

2015-03-04 Thread Emil Velikov
On 4 March 2015 at 08:31, Jose Fonseca jfons...@vmware.com wrote: On 04/03/15 00:24, Emil Velikov wrote: On 03/03/15 22:04, Jose Fonseca wrote: On 03/03/15 18:39, Emil Velikov wrote: On 3 March 2015 at 17:16, Jose Fonseca jfons...@vmware.com wrote: ... I've prototyped this in

[Mesa-dev] GSoC 2015 Proposal : Porting Glean tests to piglit

2015-03-04 Thread Juliet Fru
Hello, Here is my proposal for Adding Porting Glean tests to piglit. I'll like to get your comments and tweaks. Thanks, Juliet​ Porting Glean tests to Piglit framework OPW Proposal https://docs.google.com/document/d/1Y5flvgsJg5s6XUfTP955qKDbhG0ldXBCjGd-YROtTtM/edit?usp=drive_web ​

Re: [Mesa-dev] nesa-10.4.4: gallivm/lp_bld_misc.cpp:503:38: error: no viable conversion from 'ShaderMemoryManager *' to 'std::unique_ptrRTDyldMemoryManager'

2015-03-04 Thread Jose Fonseca
On 04/03/15 02:00, Emil Velikov wrote: On 27 February 2015 at 23:28, Sedat Dilek sedat.di...@gmail.com wrote: On Mon, Feb 9, 2015 at 6:30 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 07/02/15 21:44, Sedat Dilek wrote: Hi, I was building mesa v10.4.4 with my llvm-toolchain v3.6.0rc2.

  1   2   >