[Mesa-dev] [Bug 90466] arm: linker error ndefined reference to `nir_metadata_preserve'

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90466 Bug ID: 90466 Summary: arm: linker error ndefined reference to `nir_metadata_preserve' Product: Mesa Version: git Hardware: Other OS: All

[Mesa-dev] [RFC 05/16] glsl: Allow half float type to be used where-ever float is supported

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/glsl_types.h| 2 +- src/glsl/ir_validate.cpp | 36 2 files changed, 25 insertions(+), 13 deletions(-) diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h index

[Mesa-dev] [RFC 04/16] glsl: Add half float type generation

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/builtin_type_macros.h | 16 +++ src/glsl/builtin_types.cpp | 31 + src/glsl/glsl_types.cpp| 44 +++--- src/glsl/glsl_types.h |

[Mesa-dev] [RFC 07/16] glsl: Add ubo lowering support for half floats

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/lower_ubo_reference.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 4ea4ccb..15e783b 100644 ---

[Mesa-dev] [RFC 10/16] nir: Introduce half float opcodes

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_constant_expressions.py | 8 +++- src/glsl/nir/nir_opcodes.py | 78 +++- 3 files changed, 86 insertions(+), 2 deletions(-)

[Mesa-dev] [RFC 14/16] nir: Consider float precision when deciding between uint/float

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/nir/glsl_to_nir.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 5da4122..4cb250a 100644 --- a/src/glsl/nir/glsl_to_nir.cpp

[Mesa-dev] [RFC 11/16] nir: Consider float precision when deciding between int/float

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/nir/glsl_to_nir.cpp | 39 +-- 1 file changed, 13 insertions(+), 26 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 7a20e1a..1267475 100644 ---

[Mesa-dev] [RFC 01/16] glsl: Add tracking for GLSL precision qualifiers

2015-05-15 Thread Topi Pohjolainen
From: Iago Toral Quiroga ito...@igalia.com Currently, we only consider precision qualifiers at compile-time. This patch adds precision information to ir_variable so we can also do link time checks. Specifically, from the GLSL ES3 spec, 4.5.3 Precision Qualifiers: The same uniform declared in

[Mesa-dev] [RFC 12/16] nir: Consider float precision when deciding between int/float: part2

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/nir/glsl_to_nir.cpp | 61 ++-- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 1267475..5b3c2ad 100644

[Mesa-dev] [RFC 15/16] nir: Consider float precision when deciding opcode

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/nir/glsl_to_nir.cpp | 61 +--- 1 file changed, 35 insertions(+), 26 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 4cb250a..b4777aa 100644

[Mesa-dev] [RFC 03/16] mesa: Add half float uniform support

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/mesa/main/uniform_query.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/uniform_query.cpp b/src/mesa/main/uniform_query.cpp index 728bd1b..4cdb682 100644 ---

[Mesa-dev] [RFC 08/16] glsl: Add support for half float loop control

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/loop_controls.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/loop_controls.cpp b/src/glsl/loop_controls.cpp index 51804bb..4ba3049 100644 --- a/src/glsl/loop_controls.cpp +++ b/src/glsl/loop_controls.cpp @@

[Mesa-dev] [RFC 13/16] nir: Consider float precision when deciding between uint/int/float

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/nir/glsl_to_nir.cpp | 55 +++- 1 file changed, 13 insertions(+), 42 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 5b3c2ad..5da4122 100644

[Mesa-dev] [RFC 09/16] glsl/ast: Use half float type for medium and low precisions

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/ast_to_hir.cpp | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 332de5b..a8909ce 100644 --- a/src/glsl/ast_to_hir.cpp +++

[Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Topi Pohjolainen
I wanted to kick-off discussion on how to support floating point precision qualifiers in NIR. This is purely on optimization for GLES where one can reduce the number of GPU cycles. At the moment the compiler discards the qualifiers early when abstract syntax tree (AST) is transformed into

[Mesa-dev] [RFC 06/16] glsl: Add support for half floats in optimization passes

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/ir_print_visitor.cpp | 1 + src/glsl/opt_algebraic.cpp| 11 --- src/glsl/opt_constant_propagation.cpp | 1 + src/glsl/opt_minmax.cpp | 2 ++ 4 files changed, 12 insertions(+), 3

[Mesa-dev] [RFC 16/16] nir: Consider float precision when deciding opcode: part 2

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/nir/glsl_to_nir.cpp | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index b4777aa..14c4324 100644 ---

[Mesa-dev] [RFC 02/16] glsl: Add half float type

2015-05-15 Thread Topi Pohjolainen
Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/ast_to_hir.cpp| 1 + src/glsl/glsl_types.cpp| 2 ++ src/glsl/glsl_types.h | 9 + src/glsl/ir_clone.cpp | 1 +

Re: [Mesa-dev] [PATCH 04/15] egl: import headers from Khronos EGL registry

2015-05-15 Thread Daniel Stone
Hi, On 14 May 2015 at 23:33, Emil Velikov emil.l.veli...@gmail.com wrote: Hi Marek, On 12/05/15 22:54, Marek Olšák wrote: -#elif defined(__WINSCW__) || defined(__SYMBIAN32__) /* Symbian */ +#elif defined(__APPLE__) || defined(__WINSCW__) || defined(__SYMBIAN32__) /* Symbian */ typedef

[Mesa-dev] [Bug 90466] arm: linker error ndefined reference to `nir_metadata_preserve'

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90466 --- Comment #1 from Emil Velikov emil.l.veli...@gmail.com --- This issue is not ARM specific. It is present if one tries to use nir in their driver, but libnir is missing from the final link stage (i.e. targets/foo). I've had some patches that

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Brian Paul
Let's play it safe. Update your patch series and re-post it to the list for a final review, please. -Brian On 05/14/2015 06:01 PM, Alexander von Gluck IV wrote: Good evening Brian, Thanks, these were fixed. I just realized that I can drop os_thread.h from our C++ code as we no longer

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Rob Clark
On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen topi.pohjolai...@intel.com wrote: I wanted to kick-off discussion on how to support floating point precision qualifiers in NIR. This is purely on optimization for GLES where one can reduce the number of GPU cycles. At the moment the compiler

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Fredrik Höglund wrote: On Friday 15 May 2015, Michel Dänzer wrote: On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) wrote: URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5 Author: Laura

Re: [Mesa-dev] [PATCH 06/15] egl: fix setting context flags

2015-05-15 Thread Marek Olšák
Yes, I'll add the Cc note. Marek On Fri, May 15, 2015 at 12:40 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 12/05/15 22:54, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/egl/main/eglcontext.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: Restore functionality to dispatch sanity test

2015-05-15 Thread Brian Paul
On 05/04/2015 12:32 PM, Ian Romanick wrote: On 04/29/2015 02:44 PM, Brian Paul wrote: On 04/29/2015 02:53 PM, Ian Romanick wrote: On 04/29/2015 12:07 PM, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Along with a couple secondary goals, the dispatch sanity test had two

[Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Brian Paul
Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined (i.e. an ABI break) if the libGL used at runtime was older. For the time being, use

Re: [Mesa-dev] [RFC 02/16] glsl: Add half float type

2015-05-15 Thread Ilia Mirkin
On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen topi.pohjolai...@intel.com wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/ast_to_hir.cpp| 1 + src/glsl/glsl_types.cpp| 2 ++ src/glsl/glsl_types.h

Re: [Mesa-dev] [RFC 02/16] glsl: Add half float type

2015-05-15 Thread Roland Mainz
On Fri, May 15, 2015 at 5:43 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen topi.pohjolai...@intel.com wrote: Signed-off-by: Topi Pohjolainen topi.pohjolai...@intel.com --- src/glsl/ast_to_hir.cpp| 1 +

Re: [Mesa-dev] [PATCH 10/15] egl: add eglWaitSync

2015-05-15 Thread Marek Olšák
On Fri, May 15, 2015 at 1:23 AM, Emil Velikov emil.l.veli...@gmail.com wrote: On 12/05/15 22:54, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/egl/main/eglapi.c | 12 1 file changed, 12 insertions(+) diff --git a/src/egl/main/eglapi.c

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Emil Velikov
On 15/05/15 15:13, Brian Paul wrote: Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined (i.e. an ABI break) if the libGL used at

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Pohjolainen, Topi
On Fri, May 15, 2015 at 11:59:25AM -0400, Rob Clark wrote: On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen topi.pohjolai...@intel.com wrote: I wanted to kick-off discussion on how to support floating point precision qualifiers in NIR. This is purely on optimization for GLES where one can

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: On Fri, May 15, 2015 at 9:51 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: I haven't said much about this series up until now. I've mostly sat and watched and focused my time on other things. As I

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Add set_sechalf() method.

2015-05-15 Thread Francisco Jerez
Matt Turner matts...@gmail.com writes: Used in the next commit. --- src/mesa/drivers/dri/i965/brw_ir_fs.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_ir_fs.h b/src/mesa/drivers/dri/i965/brw_ir_fs.h index 7ac7ff8..a79713c 100644 ---

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Jason Ekstrand
On May 15, 2015 2:40 PM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: On Fri, May 15, 2015 at 9:51 AM, Francisco Jerez curroje...@riseup.net wrote: Jason Ekstrand ja...@jlekstrand.net writes: I haven't said much about this series up until now.

Re: [Mesa-dev] [PATCH 1/7] i965: Move texture buffer dispatch into single location

2015-05-15 Thread Matt Turner
On Thu, May 7, 2015 at 8:01 AM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: If Ken and Matt are happy with this series, so am I. I'm just glad if we can land it. I don't have a preference. ___ mesa-dev mailing list

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Ian Romanick wrote: On 05/15/2015 12:10 PM, Fredrik Höglund wrote: On Friday 15 May 2015, Ian Romanick wrote: On 05/15/2015 05:26 AM, Fredrik Höglund wrote: I'm also going to say that I'm quite pissed that this series landed without my objections being addressed.

Re: [Mesa-dev] [RFC: PATCH 4/4] i965: Refactor all upload_stage_prog functions up into brw_upload_programs

2015-05-15 Thread Carl Worth
Yes. That patch was severely broken in several ways. In its place, here is a pair of patches intending to do the same thing in two steps. Thanks to Ken for helpful review and guidance to get to this point. At this point, I'm quite confident that the logic of the code is undisturbed by the

[Mesa-dev] [PATCH 1/2] i965: Refactor brw_upload_programs by inlining per-stage upload functions

2015-05-15 Thread Carl Worth
In this commit, the function bodies of each of the brw_upload_stage_prog functions are manually inlined into brw_upload_programs. This commit is intended to have no functional change. The resulting function body of brw_upload_programs is fairly messy, and is expected to be cleaned up by

[Mesa-dev] [PATCH 2/2] i965: Refactor brw_upload_programs with a loop over each stage

2015-05-15 Thread Carl Worth
This refactor idetnfies as much common code as possible across the various stages within brw_upload_programs. The resulting code is a loop over all relevant stages and various accessory functions (per_stage_state_dirty, per_stage_populate_key, per_stage_codegen, and per_stage_vue_map_update),

[Mesa-dev] [Bug 90457] New Account Request

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90457 --- Comment #4 from Carl Worth cwo...@cworth.org --- (In reply to Brian Paul from comment #3) Normally we don't give git privileges until after the individual has some history of submitting some good patches. Right. Carl, is Nanley is a

Re: [Mesa-dev] [PATCH V2 01/22] meta: Enable _mesa_meta_pbo_GetTexSubImage() to read in to non-pbo buffers

2015-05-15 Thread Anuj Phogat
On Tue, Apr 21, 2015 at 3:20 PM, Neil Roberts n...@linux.intel.com wrote: Anuj Phogat anuj.pho...@gmail.com writes: This will allow Skylake to use _mesa_meta_pbo_GetTexSubImage() for reading YF/YS tiled surfaces. V2: Make changes suggested by Neil. Signed-off-by: Anuj Phogat

Re: [Mesa-dev] Glamor wiki page is obsolete

2015-05-15 Thread Emil Velikov
On 15 May 2015 at 21:09, Emil Velikov emil.l.veli...@gmail.com wrote: This page is obsolete, please update or remove it: http://www.freedesktop.org/wiki/Software/Glamor/ Haha, not sure who managed to spoof this one but well done sir. We're making improvements over the xorg-devel version [1]

Re: [Mesa-dev] [PATCH 00/74] ARB_shader_storage_buffer_object (mesa, i965)

2015-05-15 Thread Jordan Justen
On 2015-05-14 07:06:03, Iago Toral Quiroga wrote: Notice that NIR is not supported yet, so anyone wanting to test this on i965 needs to set INTEL_USE_NIR=0. We aren't going to get this feature in 10.6, and the non-nir support is planned to be removed shortly after the 10.6 branch. So, this is

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Emil Velikov
On 14/05/15 22:39, Alexander von Gluck IV wrote: We also reduce the amount of need-to-know information about st_api to require one less extern C in st_manager.h --- .../targets/haiku-softpipe/GalliumContext.cpp | 23 +++ .../targets/haiku-softpipe/GalliumContext.h

Re: [Mesa-dev] Problem with ___glapi_noop_table

2015-05-15 Thread Brian Paul
On 05/14/2015 11:26 AM, Shervin Sharifi wrote: Hi, I am trying to build Mesa for OpenGL ES (with llvmpipe) under windows with MSVC. I'm getting an error due to an unresolved external symbol (___glapi_noop_table). There is no definition of ___glapi_noop_table in the code. Am I missing

[Mesa-dev] [Bug 90457] New Account Request

2015-05-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=90457 --- Comment #3 from Brian Paul bri...@vmware.com --- Normally we don't give git privileges until after the individual has some history of submitting some good patches. Carl, is Nanley is a coworker of your's at Intel? -- You are receiving this

Re: [Mesa-dev] [PATCH 5/5] gallium/targets: Move api init into st code

2015-05-15 Thread Alexander von Gluck IV
can-do. I actually think I spotted one more extern C reduction I can do. Thanks! -- Alex On , Brian Paul wrote: Let's play it safe. Update your patch series and re-post it to the list for a final review, please. -Brian On 05/14/2015 06:01 PM, Alexander von Gluck IV wrote: Good evening

Re: [Mesa-dev] [PATCH 4/5] gallium/st: Move st_api creation to st and extern C it

2015-05-15 Thread Emil Velikov
On 14/05/15 22:39, Alexander von Gluck IV wrote: --- src/gallium/state_trackers/hgl/hgl.c | 16 src/gallium/state_trackers/hgl/hgl_context.h | 14 ++ 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/hgl/hgl.c

Re: [Mesa-dev] [PATCH 4/7] i965: Add gen8 surface state debug info

2015-05-15 Thread Ben Widawsky
On Thu, Apr 23, 2015 at 09:35:23PM -0700, Matt Turner wrote: On Thu, Apr 23, 2015 at 4:50 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: AFAICT, none of the old data was wrong (the gen7 decoder), but it wa smissing a bunch of stuff. Adds a tick (') to denote the beginning of the

Re: [Mesa-dev] [PATCH 5/7] i965: Add Gen9 surface state decoding

2015-05-15 Thread Ben Widawsky
On Fri, May 15, 2015 at 08:22:29PM -0700, Ben Widawsky wrote: On Fri, Apr 24, 2015 at 09:05:44PM +0300, Pohjolainen, Topi wrote: On Thu, Apr 23, 2015 at 04:50:02PM -0700, Ben Widawsky wrote: Gen9 surface state is very similar to the previous generation. The important changes here are

Re: [Mesa-dev] [PATCH:mesa] swrast: Build fix for Solaris

2015-05-15 Thread Jeremy Huddleston Sequoia
Looks right to me. I think this was also mentioned in the bugzilla ticket where this change was committed from. Reviewed-by: Jeremy Huddleston Sequoia jerem...@apple.com On May 15, 2015, at 19:05, Alan Coopersmith alan.coopersm...@oracle.com wrote: Fixes regression from commit

Re: [Mesa-dev] [PATCH 5/7] i965: Add Gen9 surface state decoding

2015-05-15 Thread Ben Widawsky
On Fri, Apr 24, 2015 at 09:05:44PM +0300, Pohjolainen, Topi wrote: On Thu, Apr 23, 2015 at 04:50:02PM -0700, Ben Widawsky wrote: Gen9 surface state is very similar to the previous generation. The important changes here are aux mode, and the way clear colors work. NOTE: There are some

[Mesa-dev] [PATCH 6/8] [v2] i965: Add Gen9 surface state decoding

2015-05-15 Thread Ben Widawsky
Gen9 surface state is very similar to the previous generation. The important changes here are aux mode, and the way clear colors work. NOTE: There are some things intentionally left out of this decoding. v2: Redo the string for the aux buffer type to address compressed variants. Signed-off-by:

[Mesa-dev] [PATCH 7/8] [v3] i965: Add renderbuffer surface indexes to debug

2015-05-15 Thread Ben Widawsky
This patch is optional in the series. It does make the output much cleaner, but there is some risk. Sample output (v3): 0x7e80: 0x231d7000: SURF000: 2D R8G8B8A8_UNORM VALIGN4 HALIGN4 Y-tiled 0x7e84: 0x0500: SURF000: MOCS: 0x5 Base MIP: 0.0 (0 mips) Surface QPitch: 0

[Mesa-dev] [PATCH 2/8] [v3] i965: Add all surface types to the batch decode

2015-05-15 Thread Ben Widawsky
It's true that not all surfaces apply for every gen, but for the most part this is what we want. (The unfortunate case is when we use an valid surface, but not for the specific GEN). This was automated with a vim macro. v2: Shortened common forms such as R8G8B8A8-RGBA8. Note that this makes some

[Mesa-dev] [PATCH 1/8] i965: Add string for surface format to table

2015-05-15 Thread Ben Widawsky
Recommended-by: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Ben Widawsky b...@bwidawsk.net --- src/mesa/drivers/dri/i965/brw_surface_formats.c | 436 1 file changed, 219 insertions(+), 217 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c

[Mesa-dev] [PATCH 3/8] [v2] i965: Add viewport extents (gen8) to batch decode

2015-05-15 Thread Ben Widawsky
0x7da0: 0xc1da740e: SF_CLIP VP: guardband xmin = -27.306667 0x7da4: 0x41da740e: SF_CLIP VP: guardband xmax = 27.306667 0x7da4: 0x41da740e: SF_CLIP VP: guardband ymin = -23.405714 0x7da8: 0xc1bb3ee7: SF_CLIP VP: guardband ymax = 23.405714 0x7db0:

[Mesa-dev] [PATCH 5/8] [v2] i965: Add gen8 surface state debug info

2015-05-15 Thread Ben Widawsky
AFAICT, none of the old data was wrong (the gen7 decoder), but it wa smissing a bunch of stuff. Adds a tick (') to denote the beginning of the surface state for easier reading. This will be replaced later with some better, but more risky code. OLD: 0x7980: 0x23016000: SURF: 2D

[Mesa-dev] [PATCH 4/8] [v2] i965: Add gen7+ sampler state to batch debug

2015-05-15 Thread Ben Widawsky
OLD: 0x7e00: 0x1000: WM SAMP0: filtering 0x7e04: 0x000d: WM SAMP0: wrapping, lod 0x7e08: 0x: WM SAMP0: default color pointer 0x7e0c: 0x0090: WM SAMP0: chroma key, aniso NEW: 0x7e00: 0x1000: SAMPLER_STATE 0: Disabled = no, Base

[Mesa-dev] [PATCH 8/8] [v2] i965: Add gen8 blend state

2015-05-15 Thread Ben Widawsky
OLD: 0x7340: 0x0080:BLEND: 0x7344: 0x84202100:BLEND: NEW: 0x7340: 0x0080:BLEND: Alpha blend/test 0x7344: 0x000b84202100: BLEND_ENTRY00: Color Buffer Blend factor ONE,ONE,ONE,ONE (src,dst,src alpha, dst alpha)

[Mesa-dev] [PATCH:mesa] swrast: Build fix for Solaris

2015-05-15 Thread Alan Coopersmith
Fixes regression from commit 5b2d3480f57168d50ad24cf0b8c9244414bd3701 Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com CC: Jeremy Huddleston Sequoia jerem...@apple.com --- configure.ac |1 + src/mesa/drivers/dri/swrast/swrast.c |4 +++- 2 files changed,

Re: [Mesa-dev] [PATCH 4/7] i965: Add gen8 surface state debug info

2015-05-15 Thread Ben Widawsky
On Fri, May 15, 2015 at 07:49:44PM -0700, Ben Widawsky wrote: On Thu, Apr 23, 2015 at 09:35:23PM -0700, Matt Turner wrote: On Thu, Apr 23, 2015 at 4:50 PM, Ben Widawsky benjamin.widaw...@intel.com wrote: AFAICT, none of the old data was wrong (the gen7 decoder), but it wa smissing a

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Ian Romanick
On 05/15/2015 12:10 PM, Fredrik Höglund wrote: On Friday 15 May 2015, Ian Romanick wrote: On 05/15/2015 05:26 AM, Fredrik Höglund wrote: On Friday 15 May 2015, Michel Dänzer wrote: On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) wrote: URL:

Re: [Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Fredrik Höglund
On Friday 15 May 2015, Brian Paul wrote: On 05/15/2015 12:10 PM, Fredrik Höglund wrote: With DSA we can no longer rely on this being done in st_validate_state in response to the framebuffer bindings having changed. This fixes the ext_framebuffer_multisample-bitmap piglit test. ---

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Rob Clark
On Fri, May 15, 2015 at 12:22 PM, Pohjolainen, Topi topi.pohjolai...@intel.com wrote: On Fri, May 15, 2015 at 11:59:25AM -0400, Rob Clark wrote: On Fri, May 15, 2015 at 5:39 AM, Topi Pohjolainen topi.pohjolai...@intel.com wrote: I wanted to kick-off discussion on how to support floating point

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Marek Olšák
Hi Fredrik, I'd prefer flushing the bitmap cache in st_BlitFramebuffer. We might have more bugs like this in st/mesa. Marek On Fri, May 15, 2015 at 5:59 PM, Fredrik Höglund fred...@kde.org wrote: On Friday 15 May 2015, Fredrik Höglund wrote: On Friday 15 May 2015, Michel Dänzer wrote: On

Re: [Mesa-dev] RFC: Supporting mediump in NIR

2015-05-15 Thread Jason Ekstrand
On Fri, May 15, 2015 at 2:39 AM, Topi Pohjolainen topi.pohjolai...@intel.com wrote: I wanted to kick-off discussion on how to support floating point precision qualifiers in NIR. This is purely on optimization for GLES where one can reduce the number of GPU cycles. At the moment the compiler

[Mesa-dev] [counter-RFC 2/3] nir: Add explicitly sized types

2015-05-15 Thread Jason Ekstrand
--- src/glsl/nir/nir.h | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index bc8f063..8dfc68d 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -644,9 +644,23 @@ typedef enum { nir_type_float,

Re: [Mesa-dev] [PATCH 5/5] target/haiku-softpipe: Move api init into st code

2015-05-15 Thread Brian Paul
Series looks OK to me (though I didn't look too closely at the specific Haiku changes). Reviewed-by: Brian Paul bri...@vmware.com On 05/15/2015 11:29 AM, Alexander von Gluck IV wrote: We also reduce the amount of need-to-know information about st_api to require one less extern C in

Re: [Mesa-dev] [PATCH] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-15 Thread Brian Paul
On 05/15/2015 11:31 AM, Brian Paul wrote: If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() error I'll s/error/call/ there. would generate GL_STACK_UNDERFLOW. Now push a dummy attribute in that case to prevent

[Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Fredrik Höglund
With DSA we can no longer rely on this being done in st_validate_state in response to the framebuffer bindings having changed. This fixes the ext_framebuffer_multisample-bitmap piglit test. --- src/mesa/state_tracker/st_cb_blit.c | 4 1 file changed, 4 insertions(+) diff --git

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Emil Velikov
On 15/05/15 17:29, Ian Romanick wrote: On 05/14/2015 03:01 PM, Emil Velikov wrote: On 13/05/15 19:44, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Comparing the output of nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL.so.1.2 |\ grep ' T gl[^X]' | sed

Re: [Mesa-dev] [PATCH 02/20] mesa: Remove all vestiges of glFramebufferTextureFaceARB

2015-05-15 Thread Emil Velikov
On 15/05/15 17:35, Ian Romanick wrote: On 05/14/2015 02:44 PM, Emil Velikov wrote: On 13/05/15 19:44, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Mesa does not (and probably never will) support GL_ARB_geometry_shader4, so this function will never exist. In the (very

Re: [Mesa-dev] Mesa (master): 57 new commits

2015-05-15 Thread Ian Romanick
On 05/15/2015 05:26 AM, Fredrik Höglund wrote: On Friday 15 May 2015, Michel Dänzer wrote: On 14.05.2015 22:52, fred...@kemper.freedesktop.org (Fredrik HXXglund) wrote: URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5 Author: Laura Ekstrand

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Ian Romanick
On 05/15/2015 12:11 PM, Emil Velikov wrote: On 15/05/15 17:29, Ian Romanick wrote: On 05/14/2015 03:01 PM, Emil Velikov wrote: On 13/05/15 19:44, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Comparing the output of nm -D

Re: [Mesa-dev] [PATCH 00/20] glapi yak shaving and GLES 3.1 enabling

2015-05-15 Thread Ian Romanick
On 05/14/2015 03:01 PM, Emil Velikov wrote: Hi Ian, On 13/05/15 19:44, Ian Romanick wrote: We've known for a long time that having all those tags in the function entries in the XML is bad. For example, people cut-and-paste for everything, and, as a result, we export a bunch of functions

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ian Romanick
On 05/14/2015 12:51 PM, Ilia Mirkin wrote: Don't you have to add the checks either way? And should these have just been if (ctx-API != CORE (ctx-API != COMPAT || ctx-Version 20)) { ... } And removing compat will just reduce these checks to if (ctx-API != CORE) ? No. If you

Re: [Mesa-dev] [PATCH] st/mesa: Flush the bitmap cache in st_BlitFramebuffer

2015-05-15 Thread Brian Paul
On 05/15/2015 12:10 PM, Fredrik Höglund wrote: With DSA we can no longer rely on this being done in st_validate_state in response to the framebuffer bindings having changed. This fixes the ext_framebuffer_multisample-bitmap piglit test. --- src/mesa/state_tracker/st_cb_blit.c | 4 1

Re: [Mesa-dev] i965 implementation of the ARB_shader_image_load_store built-ins. (v3)

2015-05-15 Thread Francisco Jerez
Jason Ekstrand ja...@jlekstrand.net writes: I haven't said much about this series up until now. I've mostly sat and watched and focused my time on other things. As I said in the meeting today, I think that part of the problem here is that there are at least 3 refactors in here besides the

Re: [Mesa-dev] [PATCH 12/15] egl: add eglCreateImage

2015-05-15 Thread Emil Velikov
On 12/05/15 22:54, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/egl/main/eglapi.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index 6457798..34a113b 100644 ---

Re: [Mesa-dev] CompressedTexImage3D spec bug?

2015-05-15 Thread Marek Olšák
From ARB_texture_cube_map_array: Accepted by the target parameter of TexImage3D, TexSubImage3D, CompressedTeximage3D, CompressedTexSubImage3D and CopyTexSubImage3D: TEXTURE_CUBE_MAP_ARRAY_ARB So the extension spec fixes the core spec. Marek On Fri, May 15, 2015 at 4:49 AM, Roland

[Mesa-dev] [RFC v2] Model INTEL perf query backend after query object BE

2015-05-15 Thread Robert Bragg
Instead of using the same backend interface as AMD_performance_monitor this defines a dedicated INTEL_performance_query interface that is based on the ARB_query_buffer_object interface (considering the similarity of the extensions) with the addition of vfuncs for enumerating queries and their

[Mesa-dev] [PATCH 4/5] st/hgl: Move st_api creation to st and extern C it

2015-05-15 Thread Alexander von Gluck IV
--- src/gallium/state_trackers/hgl/hgl.c | 16 src/gallium/state_trackers/hgl/hgl_context.h | 14 ++ 2 files changed, 22 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/hgl/hgl.c b/src/gallium/state_trackers/hgl/hgl.c index

Re: [Mesa-dev] [PATCH 11/20] glapi: Remove static dispatch for functions that didn't exist in fglrx

2015-05-15 Thread Ian Romanick
On 05/14/2015 03:01 PM, Emil Velikov wrote: On 13/05/15 19:44, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Comparing the output of nm -D arch/x86_64/usr/X11R6/lib64/fglrx/fglrx-libGL.so.1.2 |\ grep ' T gl[^X]' | sed 's/.* T //' between Catalyst 14.6 Beta

[Mesa-dev] [PATCH] mesa: fix glPushAttrib(0) / glPopAttrib() error

2015-05-15 Thread Brian Paul
If the glPushAttrib() mask value was zero we didn't actually push anything onto the attribute stack. A subsequent glPopAttrib() error would generate GL_STACK_UNDERFLOW. Now push a dummy attribute in that case to prevent the error. Mesa now matches nvidia's behavior. --- src/mesa/main/attrib.c

Re: [Mesa-dev] [PATCH 02/20] mesa: Remove all vestiges of glFramebufferTextureFaceARB

2015-05-15 Thread Ian Romanick
On 05/14/2015 02:44 PM, Emil Velikov wrote: On 13/05/15 19:44, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Mesa does not (and probably never will) support GL_ARB_geometry_shader4, so this function will never exist. In the (very unlikely) event that we do support the

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Brian Paul
On 05/15/2015 11:14 AM, Emil Velikov wrote: On 15/05/15 15:13, Brian Paul wrote: Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those functions from context.c would be undefined

Re: [Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-15 Thread Brian Paul
Has the patch also been tested with gcc? If these are now extern declarations, where's the actual definition of the symbols? The reason patches like this sit around for a while is because few people understand the ramifications or potential side effects and are hesitant to give an R-b.

Re: [Mesa-dev] [PATCH] mesa: do not use _glapi_new_nop_table() for DRI builds

2015-05-15 Thread Emil Velikov
On 15/05/15 17:58, Brian Paul wrote: On 05/15/2015 11:14 AM, Emil Velikov wrote: On 15/05/15 15:13, Brian Paul wrote: Commit 4bdbb588a9d38 introduced new _glapi_new_nop_table() and _glapi_set_nop_handler() functions in the glapi dispatcher (which live in libGL.so). The calls to those

Re: [Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-15 Thread Emil Velikov
On 15/05/15 20:25, Brian Paul wrote: Has the patch also been tested with gcc? If these are now extern declarations, where's the actual definition of the symbols? The reason patches like this sit around for a while is because few people understand the ramifications or potential side

[Mesa-dev] [PATCH 02/12] android: make the code be compatible with stlport

2015-05-15 Thread Chih-Wei Huang
The android's stlport doesn't have tr1/unordered_set but unordered_set. Signed-off-by: Chih-Wei Huang cwhu...@linux.org.tw --- src/egl/main/Android.mk | 5 +++-- src/gallium/drivers/nouveau/codegen/nv50_ir.h | 5 + 2 files changed, 8 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 06/12] android: add rules to build gallium_dri

2015-05-15 Thread Chih-Wei Huang
Signed-off-by: Chih-Wei Huang cwhu...@linux.org.tw --- src/gallium/Android.mk | 7 +- src/gallium/targets/dri/Android.mk | 110 +++ src/gallium/winsys/sw/dri/Android.mk | 35 ++ src/gallium/winsys/sw/kms-dri/Android.mk | 37

[Mesa-dev] [PATCH 01/12] nv50/ir: optimize the use of std::tr1::unordered_set

2015-05-15 Thread Chih-Wei Huang
Instead of using unordered_setuser-defined-type * directly, the patch changes to use unordered_setvoid * and adds a wrapper template class to convert the iterators to the expected user-defined type. This avoid instantiating the template multiple times and make it be more compatible with stlport.

Re: [Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

2015-05-15 Thread Ilia Mirkin
On Fri, May 15, 2015 at 2:29 PM, Ian Romanick i...@freedesktop.org wrote: On 05/14/2015 12:51 PM, Ilia Mirkin wrote: Don't you have to add the checks either way? And should these have just been if (ctx-API != CORE (ctx-API != COMPAT || ctx-Version 20)) { ... } And removing compat will

[Mesa-dev] [PATCH] Fix symbol 'x86_64_entry_start' is already defined when building with LLVM/clang

2015-05-15 Thread Yunlian Jiang
This is just a re-post of the patch submitted by Tomasz at https://bugs.freedesktop.org/show_bug.cgi?id=89599 Thanks diff -Naur mesa-10.5.2/src/mapi/entry_x86-64_tls.h mesa-10.5.2.tpg/src/mapi/entry_x86-64_tls.h --- mesa-10.5.2/src/mapi/entry_x86-64_tls.h 2015-03-28 18:20:39.0 + +++

Re: [Mesa-dev] [PATCH 02/20] t_dd_dmatmp: Allow flat shaded polygons with tri fans

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com We can allow rendering flat shaded polygons using tri fans if we check the provoking vertex convention. This sounds reasonable since it matches the DX behavior. Is there a piglit

Re: [Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Kenneth Graunke
On Friday, May 15, 2015 11:57:16 AM Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com Commit 3687d75 changed the fs_visitor constructors, but it didn't update all the users. As a result, 'make check' fails. I added the explicit cast to the gl_program* parameter to make it

Re: [Mesa-dev] [PATCH] i965: Fix FS unit tests

2015-05-15 Thread Matt Turner
On Fri, May 15, 2015 at 12:06 PM, Kenneth Graunke kenn...@whitecape.org wrote: Sorry! Reviewed-by: Kenneth Graunke kenn...@whitecape.org Capital W in your email. idr, please fix this before you commit. :) ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 03/20] t_dd_dmatmp: Disallow flat shading when rendering quad strips via tri strips

2015-05-15 Thread Ian Romanick
On 03/23/2015 05:47 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com When rendering quad strips via tri strips we can't get the provoking vertex right, so disallow flat shading. Same comments as for patch 2. Signed-off-by: Ville Syrjälä

Re: [Mesa-dev] [PATCH 03/20] glapi: Store static dispatch offsets in a separate table

2015-05-15 Thread Dylan Baker
On Wed, May 13, 2015 at 12:44:31PM -0700, Ian Romanick wrote: From: Ian Romanick ian.d.roman...@intel.com [snip] diff --git a/src/mapi/glapi/gen/static_data.py b/src/mapi/glapi/gen/static_data.py new file mode 100644 index 000..2ce093c --- /dev/null +++

  1   2   >