Re: [Mesa-dev] [PATCH 10/18] i965: Speculatively flush the batch after transform feedback

2015-07-07 Thread Kenneth Graunke
On Tuesday, July 07, 2015 04:46:22 PM Chris Wilson wrote: On Tue, Jul 07, 2015 at 10:12:20AM +0100, Chris Wilson wrote: On Mon, Jul 06, 2015 at 09:05:18PM -0700, Kristian Høgsberg wrote: On Mon, Jul 6, 2015 at 12:36 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, July 06,

[Mesa-dev] [PATCH 1/2] gallium/hud: replace byte units flag with pipe_driver_query_type

2015-07-07 Thread Brian Paul
Instead of using a boolean 'is bytes' value, use the pipe_driver_query_type enum type. This will let is add support for time values in the next patch. --- src/gallium/auxiliary/hud/hud_context.c | 20 src/gallium/auxiliary/hud/hud_driver_query.c | 9 +++--

[Mesa-dev] [PATCH] st/dri: don't set PIPE_BIND_SCANOUT for MSAA surfaces

2015-07-07 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index a8323a3..5aa785c 100644 ---

Re: [Mesa-dev] [PATCH] st/dri: don't set PIPE_BIND_SCANOUT for MSAA surfaces

2015-07-07 Thread Brian Paul
On 07/07/2015 10:29 AM, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index a8323a3..5aa785c

Re: [Mesa-dev] [Mesa-stable] [PATCH] opencl: use versioned .so in mesa.icd

2015-07-07 Thread Emil Velikov
Ccing Tom Thank you Igor ! On 07/07/15 11:05, Igor Gnatenko wrote: We must have versioned library in mesa.icd, because ICD loader would fail if the mesa-devel package wasn't installed. Reported-by: Fabian Deutsch fabian.deut...@gmx.de Reference:

Re: [Mesa-dev] [PATCH] i965/fs: Don't disable SIMD16 when using the pixel interpolator

2015-07-07 Thread Francisco Jerez
Matt Turner matts...@gmail.com writes: On Sun, Jul 5, 2015 at 4:45 PM, Francisco Jerez curroje...@riseup.net wrote: Hi Matt, Matt Turner matts...@gmail.com writes: On Fri, Jul 3, 2015 at 3:46 AM, Francisco Jerez curroje...@riseup.net wrote: Heh, I happened to come across this comment

Re: [Mesa-dev] [PATCH 0/8] Render node only opencl and pipe-loader cleanups

2015-07-07 Thread Emil Velikov
On 30/06/15 16:09, Emil Velikov wrote: Hello all, As mentioned over IRC a few weeks back, here is a series that removes support for non-render node devices. The two main motivations being: - Currently we force X/xcb onto everyone that wants to use OpenCL (headless OpenCL systems/farms

[Mesa-dev] [PATCH v3 5/6] i965: Upload binding tables in hw-generated binding table format.

2015-07-07 Thread Abdiel Janulgue
When hardware-generated binding tables are enabled, use the hw-generated binding table format when uploading binding table state. Normally, the CS will will just consume the binding table pointer commands as pipelined state. When the RS is enabled however, the RS flushes whatever edited surface

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 Tomasz C. toma...@o2.pl changed: What|Removed |Added CC||toma...@o2.pl -- You are

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 Bug ID: 91254 Summary: (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1 Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64)

[Mesa-dev] [PATCH v5 3/6] i965: Enable hardware-generated binding tables on render path.

2015-07-07 Thread Abdiel Janulgue
This patch implements the binding table enable command which is also used to allocate a binding table pool where where hardware-generated binding table entries are flushed into. Each binding table offset in the binding table pool is unique per each shader stage that are enabled within a batch.

Re: [Mesa-dev] [PATCH 10/18] i965: Speculatively flush the batch after transform feedback

2015-07-07 Thread Chris Wilson
On Mon, Jul 06, 2015 at 09:05:18PM -0700, Kristian Høgsberg wrote: On Mon, Jul 6, 2015 at 12:36 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, July 06, 2015 11:33:15 AM Chris Wilson wrote: Since the purpose of transform feedback tends to be for the client to act upon the

Re: [Mesa-dev] [PATCH 0/8] Render node only opencl and pipe-loader cleanups

2015-07-07 Thread Francisco Jerez
Emil Velikov emil.l.veli...@gmail.com writes: On 30/06/15 16:09, Emil Velikov wrote: Hello all, As mentioned over IRC a few weeks back, here is a series that removes support for non-render node devices. The two main motivations being: - Currently we force X/xcb onto everyone that

Re: [Mesa-dev] [PATCH 0/8] Render node only opencl and pipe-loader cleanups

2015-07-07 Thread Tom Stellard
On Tue, Jul 07, 2015 at 05:43:19PM +0100, Emil Velikov wrote: On 30/06/15 16:09, Emil Velikov wrote: Hello all, As mentioned over IRC a few weeks back, here is a series that removes support for non-render node devices. The two main motivations being: - Currently we force X/xcb

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

2015-07-07 Thread Anuj Phogat
On Tue, Jul 7, 2015 at 2:35 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Tuesday, June 23, 2015 01:23:05 PM Anuj Phogat wrote: In case of I915_TILING_{X,Y} we need to pass tiling format to libdrm using drm_intel_bo_alloc_tiled(). But, In case of YF/YS tiled buffers libdrm need not know

Re: [Mesa-dev] [PATCH 10/18] i965: Speculatively flush the batch after transform feedback

2015-07-07 Thread Chris Wilson
On Tue, Jul 07, 2015 at 10:31:07AM -0700, Kenneth Graunke wrote: On Tuesday, July 07, 2015 04:46:22 PM Chris Wilson wrote: On Tue, Jul 07, 2015 at 10:12:20AM +0100, Chris Wilson wrote: On Mon, Jul 06, 2015 at 09:05:18PM -0700, Kristian Høgsberg wrote: On Mon, Jul 6, 2015 at 12:36 PM,

Re: [Mesa-dev] [PATCH 17/18] loader: Look for any version of currently linked libudev.so

2015-07-07 Thread Emil Velikov
On 06/07/15 11:33, Chris Wilson wrote: Since there was an ABI break and linking twice against libudev.so.0 and libudev.so.1 causes the application to quickly crash, we first check if the application is currently linked against libudev before dlopening a local handle. However for

[Mesa-dev] [PATCH] glsl: fix Bug 85252 - Segfault in compiler while processing ternary operator with void arguments

2015-07-07 Thread Renaud Gaubert
This is done by returning an rvalue of type void in the ast_function_expression::hir function instead of a void expression. This produces (in the case of the ternary) an hir with a call to the void returning function and an assignement of a void variable which will be optimized out (the

Re: [Mesa-dev] [PATCH 2/2] gallium/hud: add PIPE_DRIVER_QUERY_TYPE_MICROSECONDS for HUD

2015-07-07 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Jul 7, 2015 at 5:37 PM, Brian Paul bri...@vmware.com wrote: This allows drivers to report queries in units of microseconds and have the HUD display us (microseconds), ms (milliseconds) or s (seconds) on the graph.

Re: [Mesa-dev] [PATCH] gallium/hud: display percentages with % suffix

2015-07-07 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Jul 7, 2015 at 9:17 PM, Brian Paul bri...@vmware.com wrote: --- src/gallium/auxiliary/hud/hud_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/hud/hud_context.c

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

2015-07-07 Thread Anuj Phogat
On Tue, Jul 7, 2015 at 12:11 PM, Anuj Phogat anuj.pho...@gmail.com wrote: On Tue, Jul 7, 2015 at 2:35 AM, Kenneth Graunke kenn...@whitecape.org wrote: On Tuesday, June 23, 2015 01:23:05 PM Anuj Phogat wrote: In case of I915_TILING_{X,Y} we need to pass tiling format to libdrm using

[Mesa-dev] [PATCHv2] i965/gen9: Use custom MOCS entries set up by the kernel.

2015-07-07 Thread Francisco Jerez
Instead of relying on hardware defaults the i915 kernel driver is going program custom MOCS tables system-wide on Gen9 hardware. The WT entry previously used for renderbuffers had a number of problems: It disabled caching on eLLC, it used a reserved L3 cacheability setting, and it used to

Re: [Mesa-dev] [PATCH 0/8] Render node only opencl and pipe-loader cleanups

2015-07-07 Thread Emil Velikov
On 07/07/15 19:42, Tom Stellard wrote: On Tue, Jul 07, 2015 at 05:43:19PM +0100, Emil Velikov wrote: On 30/06/15 16:09, Emil Velikov wrote: Hello all, As mentioned over IRC a few weeks back, here is a series that removes support for non-render node devices. The two main motivations being:

[Mesa-dev] [PATCH] gallium/hud: display percentages with % suffix

2015-07-07 Thread Brian Paul
--- src/gallium/auxiliary/hud/hud_context.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/hud/hud_context.c b/src/gallium/auxiliary/hud/hud_context.c index cb55220..bd57190 100644 --- a/src/gallium/auxiliary/hud/hud_context.c +++

Re: [Mesa-dev] [PATCH 10/18] i965: Speculatively flush the batch after transform feedback

2015-07-07 Thread Chris Wilson
On Tue, Jul 07, 2015 at 10:12:20AM +0100, Chris Wilson wrote: On Mon, Jul 06, 2015 at 09:05:18PM -0700, Kristian Høgsberg wrote: On Mon, Jul 6, 2015 at 12:36 PM, Kenneth Graunke kenn...@whitecape.org wrote: On Monday, July 06, 2015 11:33:15 AM Chris Wilson wrote: Since the purpose of

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Roland Scheidegger
Am 07.07.2015 um 22:35 schrieb Jose Fonseca: On 07/07/15 21:28, Ilia Mirkin wrote: On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca jfons...@vmware.com wrote: I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments.

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Jose Fonseca
I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments. But overall this looks good to me FWIW. On 05/07/15 14:25, Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Other approaches are being considered:

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Jose Fonseca
On 07/07/15 21:28, Ilia Mirkin wrote: On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca jfons...@vmware.com wrote: I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments. But overall this looks good to me FWIW. On

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Ilia Mirkin
On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca jfons...@vmware.com wrote: I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really make educated comments. But overall this looks good to me FWIW. On 05/07/15 14:25, Marek Olšák wrote: From:

Re: [Mesa-dev] [RFC] gallium: add interface for writable shader images

2015-07-07 Thread Ilia Mirkin
On Tue, Jul 7, 2015 at 4:35 PM, Jose Fonseca jfons...@vmware.com wrote: On 07/07/15 21:28, Ilia Mirkin wrote: On Tue, Jul 7, 2015 at 4:24 PM, Jose Fonseca jfons...@vmware.com wrote: I'm not experienced with the semantics around resources that can be read/written by shaders, so I can't really

[Mesa-dev] [PATCH 2/2] gallium/hud: add PIPE_DRIVER_QUERY_TYPE_MICROSECONDS for HUD

2015-07-07 Thread Brian Paul
This allows drivers to report queries in units of microseconds and have the HUD display us (microseconds), ms (milliseconds) or s (seconds) on the graph. --- src/gallium/auxiliary/hud/hud_context.c | 25 - src/gallium/include/pipe/p_defines.h| 11 ++- 2 files

[Mesa-dev] [PATCH] mesa: use implementation specified MAX_VERTEX_ATTRIBS rather than hardcoded value

2015-07-07 Thread Timothy Arceri
--- src/glsl/linker.cpp | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 6a69c15..2f5a36f 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker.cpp @@ -3084,12 +3084,7 @@ link_shaders(struct gl_context *ctx, struct

Re: [Mesa-dev] [PATCH] mesa: use implementation specified MAX_VERTEX_ATTRIBS rather than hardcoded value

2015-07-07 Thread Ilia Mirkin
Assuming the comment is correct, this is Reviewed-by: Ilia Mirkin imir...@alum.mit.edu src/mesa/main/get_hash_params.py: [ MAX_VERTEX_ATTRIBS_ARB, CONTEXT_INT(Const.Program[MESA_SHADER_VERTEX].MaxAttribs), extra_ARB_vertex_program_api_es2 ], Quickly looked over the code, and the comment does

Re: [Mesa-dev] [PATCH 10/18] i965: Speculatively flush the batch after transform feedback

2015-07-07 Thread Kenneth Graunke
On Tuesday, July 07, 2015 09:02:16 PM Chris Wilson wrote: On Tue, Jul 07, 2015 at 10:31:07AM -0700, Kenneth Graunke wrote: On Tuesday, July 07, 2015 04:46:22 PM Chris Wilson wrote: On Tue, Jul 07, 2015 at 10:12:20AM +0100, Chris Wilson wrote: On Mon, Jul 06, 2015 at 09:05:18PM -0700,

[Mesa-dev] [RFC] loader: libudev vs sysfs vs libdrm

2015-07-07 Thread Emil Velikov
Hello all, A recent patch by Chris, fixing some libudev fun in our loader, made me think if we can clear it up a bit. Having three different ways of retrieving the vendor/device ID does feel a bit excessive. Plus as one gets fixed others are likely to break - and they do. So here is a summary of

Re: [Mesa-dev] [PATCH] i965/vs: Fix matNxM vertex attributes where M != 4.

2015-07-07 Thread Chris Forbes
Reviewed-by: Chris Forbes chr...@ijw.co.nz On Thu, Jul 2, 2015 at 8:08 PM, Kenneth Graunke kenn...@whitecape.org wrote: Matrix vertex attributes have their columns padded out to vec4s, which I was failing to account for. Scalar NIR expects them to be packed, however. Cc:

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 --- Comment #2 from Tomasz C. toma...@o2.pl --- On: mesa-git 10.7.0_devel.71031 mesa-libgl-git 10.7.0_devel.71031 (compiled from git master) this problem still exists same as 10.6 and 10.6.1 If I go back this two packages to version 10.5.7 it

[Mesa-dev] Mesa 10.6.2 cut-off

2015-07-07 Thread Emil Velikov
Hi all, As requested by Ilia, a bit of a heads-up: Any patches sent to mesa-stable and/or landed in master after 12 PM (noon) GMT, on the 8th of July won't feature in 10.6.2. Cheers, Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 --- Comment #3 from Chris Wilson ch...@chris-wilson.co.uk --- You have two end points, a bisection would be very useful and only take a few minutes (maybe an hour at most?). -- You are receiving this mail because: You are the assignee for the

Re: [Mesa-dev] [PATCH 04/18] i965: Introduce a context-local batch manager

2015-07-07 Thread Chris Wilson
On Tue, Jul 07, 2015 at 01:14:53PM +0300, Abdiel Janulgue wrote: On 07/06/2015 01:33 PM, Chris Wilson wrote: @@ -600,7 +593,10 @@ brw_emit_null_surface_state(struct brw_context *brw, 1 BRW_SURFACE_WRITEDISABLE_B_SHIFT | 1 BRW_SURFACE_WRITEDISABLE_A_SHIFT);

Re: [Mesa-dev] [PATCH 01/18] i965: Query whether we have kernel support for the TIMESTAMP register once

2015-07-07 Thread Martin Peres
On 06/07/15 19:12, Chris Wilson wrote: On Mon, Jul 06, 2015 at 04:19:36PM +0300, Martin Peres wrote: On 06/07/15 16:15, Martin Peres wrote: On 06/07/15 16:13, Chris Wilson wrote: On Mon, Jul 06, 2015 at 03:10:48PM +0300, Martin Peres wrote: On 06/07/15 13:33, Chris Wilson wrote: Move the

Re: [Mesa-dev] [PATCH 10/18] i965: Speculatively flush the batch after transform feedback

2015-07-07 Thread Martin Peres
On 06/07/15 22:36, Kenneth Graunke wrote: On Monday, July 06, 2015 11:33:15 AM Chris Wilson wrote: Since the purpose of transform feedback tends to be for the client to act upon the results to change the geometry in the scene, it is likely that the client will soon be waiting upon the

Re: [Mesa-dev] [PATCH 2/5] i965/gen9: Plugin the code for selecting YF/YS tiling on skl+

2015-07-07 Thread Kenneth Graunke
On Wednesday, June 10, 2015 03:30:47 PM Anuj Phogat wrote: Buffers with Yf/Ys tiling end up using meta upload / download paths or the blitter for cases where they used tiled_memcpy paths in case of Y tiling. This has exposed some bugs in meta path. To avoid any piglit regressions on SKL this

[Mesa-dev] [PATCH] opencl: use versioned .so in mesa.icd

2015-07-07 Thread Igor Gnatenko
We must have versioned library in mesa.icd, because ICD loader would fail if the mesa-devel package wasn't installed. Reported-by: Fabian Deutsch fabian.deut...@gmx.de Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Cc: 10.6 mesa-sta...@lists.freedesktop.org Signed-off-by: Igor

[Mesa-dev] [Bug 91254] (regresion) video using VA-API on Intel slow and freeze system with mesa 10.6 or 10.6.1

2015-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91254 --- Comment #1 from Chris Wilson ch...@chris-wilson.co.uk --- I suspect this a dup of bug 90839. Do you see the regression remain on master or the 10.6 branch? -- You are receiving this mail because: You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 04/18] i965: Introduce a context-local batch manager

2015-07-07 Thread Abdiel Janulgue
On 07/06/2015 01:33 PM, Chris Wilson wrote: +/* + * Add a relocation entry for the target buffer into the current batch. + * + * This is the heart of performing fast relocations, both here and in + * the corresponding kernel relocation routines. + * + * - Instead of passing in handles

Re: [Mesa-dev] [PATCH v2 5/5] i965/gen9: Allocate YF/YS tiled buffer objects

2015-07-07 Thread Kenneth Graunke
On Tuesday, June 23, 2015 01:23:05 PM Anuj Phogat wrote: In case of I915_TILING_{X,Y} we need to pass tiling format to libdrm using drm_intel_bo_alloc_tiled(). But, In case of YF/YS tiled buffers libdrm need not know about the tiling format because these buffers don't have hardware support to

Re: [Mesa-dev] [PATCH 05/18] i965: Reuse our VBO for streaming fast-clear vertices

2015-07-07 Thread Martin Peres
On 06/07/15 19:43, Kenneth Graunke wrote: On Monday, July 06, 2015 11:33:10 AM Chris Wilson wrote: Rather than allocating a fresh page every time we clear a buffer, keep that page around between invocations by tracking the last used offset and only allocating a fresh page when we wrap.

Re: [Mesa-dev] [PATCH 04/18] i965: Introduce a context-local batch manager

2015-07-07 Thread Abdiel Janulgue
On 07/07/2015 01:19 PM, Chris Wilson wrote: On Tue, Jul 07, 2015 at 01:14:53PM +0300, Abdiel Janulgue wrote: On 07/06/2015 01:33 PM, Chris Wilson wrote: @@ -600,7 +593,10 @@ brw_emit_null_surface_state(struct brw_context *brw, 1 BRW_SURFACE_WRITEDISABLE_B_SHIFT |

Re: [Mesa-dev] [PATCH 04/18] i965: Introduce a context-local batch manager

2015-07-07 Thread Kenneth Graunke
Hi Chris, I made a genuine effort to review this patch, hoping to better understand the various changes and what you were trying to accomplish. I spent many hours reading and trying to enumerate changes - or potential changes I needed to look hard at to convince myself whether they were correct.

Re: [Mesa-dev] [PATCH] opencl: use versioned .so in mesa.icd

2015-07-07 Thread Michel Dänzer
On 07.07.2015 19:05, Igor Gnatenko wrote: We must have versioned library in mesa.icd, because ICD loader would fail if the mesa-devel package wasn't installed. Reported-by: Fabian Deutsch fabian.deut...@gmx.de Reference: https://bugs.freedesktop.org/show_bug.cgi?id=73512 Cc: 10.6

[Mesa-dev] [PATCH] clover: little OpenCL status code logging clean

2015-07-07 Thread EdB
s/build_error/compile_error in order to match the stored OpenCL status code. Make program::build catch and log every OpenCL error. Make tgsi error triggering uniform with the llvm one. --- Note that compile_error class is keep for later use .../state_trackers/clover/core/compiler.hpp| 3

[Mesa-dev] [Bug 91259] FS compile failed: Register spilling not supported with m14 used

2015-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91259 Bug ID: 91259 Summary: FS compile failed: Register spilling not supported with m14 used Product: Mesa Version: 10.6 Hardware: x86-64 (AMD64) OS: Linux

[Mesa-dev] [Bug 91259] FS compile failed: Register spilling not supported with m14 used

2015-07-07 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91259 --- Comment #1 from maxweiss.1...@googlemail.com --- Sorry I've failed to post the whole trace, here's the rest: java.lang.IllegalStateException: Operation requires resource lock at