[Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

Patch moves uniform calculation to happen during link_uniforms, this is possible with help of UniformRemapTable that has all the reserved locations. Location assignment for implicit locations is changed so that we utilize also the 'holes' that explicit uniform location assignment might have left

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: > On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: >> For 1-4, >> >> Reviewed-by: Marek Olšák >> >> I'm not very familiar with the code in 2, but the changes seem reasonable. >>

Re: [Mesa-dev] [PATCH v2 07/10] st/mesa: add support for memory barrier intrinsics

Reviewed-by: Marek Olšák Marek On Tue, Jan 19, 2016 at 3:30 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > > v1 -> v2: use TGSI_MEMBAR defines > --- > src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 45 >

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

This seem a bit suboptimal, since the same space is potentially searched multiple times. However, I believe that a better solution would be to use some other data structure which would probably require quite a big effort, so for now, this is: Reviewed-by: Marta Lofstedt

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

On Mon, Jan 18, 2016 at 6:12 PM, Eero Tamminen wrote: > Hi, > > On 18.01.2016 17:05, Kenneth Graunke wrote: >> >> This writes linked shader programs to .shader_test files to >> $MESA_SHADER_CAPTURE_PATH in the format used by shader-db >>

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

On Tue, Jan 19, 2016 at 5:49 AM, Marek Olšák wrote: > On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: >> On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: >>> For 1-4, >>> >>> Reviewed-by: Marek Olšák >>> >>>

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

The data structure is a (memory) heap... there appears to be one in mesa/main/mm.h. There's also one in nouveau_heap.h which is quite simple and totally unreliant on nouveau, just happens to be there. How hard would it be to integrate something like that? The trouble with adding slow things is

Re: [Mesa-dev] [PATCH v2] glsl: move uniform calculation to link_uniforms

On 01/19/2016 01:14 PM, Ilia Mirkin wrote: The data structure is a (memory) heap... there appears to be one in mesa/main/mm.h. There's also one in nouveau_heap.h which is quite simple and totally unreliant on nouveau, just happens to be there. How hard would it be to integrate something like

Re: [Mesa-dev] [RFC PATCH] mesa: Add MESA_SHADER_CAPTURE_PATH for writing .shader_test files.

Hi, On 19.01.2016 13:07, Marek Olšák wrote: On Mon, Jan 18, 2016 at 6:12 PM, Eero Tamminen On 18.01.2016 17:05, Kenneth Graunke wrote: [...] If one wants startup shaders not to be overwritten, one can just kill the program at that point. One could also somewhat differentiate shaders to

Re: [Mesa-dev] [PATCH 1/2] i965: Trigger CS state reemission when new sampler state is uploaded.

Thanks Curro, Reviewed-by: Marta Lofstedt > -Original Message- > From: Francisco Jerez [mailto:curroje...@riseup.net] > Sent: Monday, January 18, 2016 9:37 PM > To: mesa-dev@lists.freedesktop.org > Cc: Lofstedt, Marta; Justen, Jordan L > Subject: [PATCH 1/2]

Re: [Mesa-dev] [PATCH 2/2] i965: Implement compute sampler state atom.

Reviewed-by: Marta Lofstedt > -Original Message- > From: Francisco Jerez [mailto:curroje...@riseup.net] > Sent: Monday, January 18, 2016 9:37 PM > To: mesa-dev@lists.freedesktop.org > Cc: Lofstedt, Marta; Justen, Jordan L > Subject: [PATCH 2/2] i965: Implement

Re: [Mesa-dev] [PATCH] glsl: Restore Mesa-style to shader_enums.c/h.

On 01/15/2016 02:44 PM, Matt Turner wrote: On Fri, Jan 15, 2016 at 1:39 PM, Ilia Mirkin wrote: ? (Along with "extern" thrown in for no apparent reason.) Heh :) IIRC, many years ago there was some odd compiler that warned if function prototypes didn't have 'extern'

Re: [Mesa-dev] [PATCH 2/4] i965: Provide sse2 version for rgba8 <-> bgra8 swizzle

Ping? Am 17.01.2016 um 22:49 schrieb srol...@vmware.com: > From: Roland Scheidegger > > The existing code used ssse3, and because it isn't compiled in a separate > file compiled with that, it is usually not used (that, of course, could > be fixed...), whereas sse2 is always

Re: [Mesa-dev] [RFC 11/63] mesa/main: Add extension tracking bit for ARB_internalformat_query2

On Tue, Jan 19, 2016 at 05:41:51PM +0100, Eduardo Lima Mitev wrote: > From: Antia Puentes > > --- > src/mesa/main/extensions_table.h | 1 + > src/mesa/main/mtypes.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/mesa/main/extensions_table.h >

Re: [Mesa-dev] [PATCH 0/6] Move nir/glsl to src/compiler, take 2

On Mon, Jan 18, 2016 at 4:02 AM, Emil Velikov wrote: > Hi all, > > Here is another attempt at splitting up nir, glsl and the rest. > > The gist is that we have three independent static libraries - compiler, > nir and glsl. Thus we don't need to pull nir if working with

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

Marek Olšák writes: > On Tue, Jan 19, 2016 at 9:09 PM, Francisco Jerez > wrote: >> Marek Olšák writes: >> >>> On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák

Re: [Mesa-dev] [PATCH v2] mesa: remove link validation that should be done elsewhere

On 01/05/2016 05:40 PM, Timothy Arceri wrote: > Even if re-linking fails rendering shouldn't fail as the previous > succesfully linked program will still be available. It also shouldn't > be possible to have an unlinked program as part of the current rendering > state. > > This fixes a subtest

Re: [Mesa-dev] [PATCH v2] mesa: remove link validation that should be done elsewhere

On Fri, 2016-01-15 at 08:50 +0200, Tapani Pälli wrote: > > On 01/06/2016 03:40 AM, Timothy Arceri wrote: > > Even if re-linking fails rendering shouldn't fail as the previous > > succesfully linked program will still be available. It also > > shouldn't > > be possible to have an unlinked program

Re: [Mesa-dev] Allow duplicate layout qualifiers V2

On Mon, Jan 18, 2016 at 12:29 AM, Timothy Arceri wrote: > After sending out V1 where I didn't fix the global default > merging (just issued and error), I got motivated and fixed > it properly. > > There are two changes here. > > 1. ARB_enhanced_layouts > > Allows

Re: [Mesa-dev] [PATCH 2/7] radeonsi: use SPI_SHADER_COL_FORMAT fields instead of export_16bpc

On 19.01.2016 11:11, Marek Olšák wrote: From: Marek Olšák This does change the behavior slightly: If a shader writes COLOR[i] and that color buffer isn't bound, the shader will export MRT_NULL instead and discard the IR tree that calculates the output. The only

Re: [Mesa-dev] [PATCH] i965/vec4: Use UW type for multiply into accumulator on GEN8+

On Sat, Jan 16, 2016 at 7:31 PM, Jason Ekstrand wrote: > > On Jan 16, 2016 5:56 PM, "Matt Turner" wrote: >> >> On Thu, Jan 14, 2016 at 12:27 PM, Matt Turner wrote: >> > On Thu, Jan 14, 2016 at 12:08 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 7/7] radeonsi: disable SPI color outputs the shader doesn't write

Apart from two comments on patch #2, the series is Reviewed-by: Nicolai Hähnle On 19.01.2016 11:11, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.h| 4

Re: [Mesa-dev] [PATCH v2] mesa: remove link validation that should be done elsewhere

On Tue, 2016-01-19 at 14:09 -0800, Ian Romanick wrote: > On 01/05/2016 05:40 PM, Timothy Arceri wrote: > > Even if re-linking fails rendering shouldn't fail as the previous > > succesfully linked program will still be available. It also > > shouldn't > > be possible to have an unlinked program as

Re: [Mesa-dev] [PATCH 2/2] i965: Implement compute sampler state atom.

Ben Widawsky writes: > On Mon, Jan 18, 2016 at 12:37:18PM -0800, Francisco Jerez wrote: >> Fixes a number of GLES31 CTS failures and hangs on various hardware: >> >> ES31-CTS.texture_gather.plain-gather-depth-2d >> ES31-CTS.texture_gather.plain-gather-depth-2darray >>

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

On Tue, Jan 19, 2016 at 9:09 PM, Francisco Jerez wrote: > Marek Olšák writes: > >> On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: >>> On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: For 1-4,

Re: [Mesa-dev] [PATCH] radeonsi: fix discard-only fragment shaders

On Tue, Jan 19, 2016 at 9:13 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When a fragment shader is used that has no outputs but does conditional > discard (KILL_IF), all fragments are killed without this patch. > > By comparing various

Re: [Mesa-dev] [Mesa-stable] New stable-branch 11.0 candidate pushed

On Tue, Jan 19, 2016 at 2:48 PM, Emil Velikov wrote: > > Hello list, > > The candidate for the Mesa 11.0.9 is now available. Currently we have: > - 22 queued > - 20 nominated (outstanding) > - and 1 rejected/obsolete patches > > Current queue addressed a few important

Re: [Mesa-dev] [PATCH] mesa: Move sanity check of BindVertexBuffer for OpenGL ES 3.1

On 01/08/2016 05:55 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Sanity check of BindVertexBuffer for OpenGL ES in > _mesa_handle_bind_buffer_gen breaks OpenGL ES 2 conformance. What was previously broken, and why does this fix it? I think it's also worth

Re: [Mesa-dev] [PATCH 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

Marek Olšák writes: > On Tue, Jan 19, 2016 at 3:25 AM, Ilia Mirkin wrote: >> On Mon, Jan 18, 2016 at 6:06 AM, Marek Olšák wrote: >>> For 1-4, >>> >>> Reviewed-by: Marek Olšák >>> >>> I'm not very familiar with the

Re: [Mesa-dev] [PATCH] glx: don't force version == 2.0 for ES2 GLX context creation

On Tue, Jan 19, 2016 at 7:08 AM, Ilia Mirkin wrote: > dEQP tests request a specific version. The EXT spec has been updated to > allow other versions, so allow anything >= 2.0 to be requested. > > Signed-off-by: Ilia Mirkin > --- > > The X server was

Re: [Mesa-dev] [PATCH] gallium: make image views non-persistent objects

On Tue, Jan 19, 2016 at 10:42 AM, Nicolai Hähnle wrote: > On 18.01.2016 22:08, Ilia Mirkin wrote: >> >> Make them akin to shader buffers, with no refcounting/etc. Just used to >> pass data about the bound image in ->set_shader_images. >> >> Signed-off-by: Ilia Mirkin

[Mesa-dev] [PATCH] radeonsi: fix discard-only fragment shaders (11.1 version)

From: Nicolai Hähnle When a fragment shader is used that has no outputs but does conditional discard (KILL_IF), all fragments are killed without this patch. By comparing various register settings, my conclusion is that the exec mask is either not properly forwarded to

Re: [Mesa-dev] [PATCH] glsl: Restore Mesa-style to shader_enums.c/h.

On 01/15/2016 01:44 PM, Matt Turner wrote: > On Fri, Jan 15, 2016 at 1:39 PM, Ilia Mirkin wrote: >> On Fri, Jan 15, 2016 at 4:34 PM, Matt Turner wrote: >>> --- >>> src/glsl/nir/shader_enums.c | 24 >>>

Re: [Mesa-dev] [PATCH] arb_shader_subroutine: fix lowering reusing actual parmaters

On 01/16/2016 08:23 PM, Dave Airlie wrote: > From: Dave Airlie > > One of the oglconform tests was crashing here, and it was > due to not cloning the actual parameters before creating the > new call. This makes a call clone function that does the right > things to make sure

Re: [Mesa-dev] [PATCH v2 01/10] tgsi: add MEMBAR opcode to handle memoryBarrier* GLSL intrinsics

Am 19.01.2016 um 18:26 schrieb Ilia Mirkin: > This is designed to map the GLSL intrinsics. Should one have a desire > to also support d3d11, one could figure out what the overlap is and > rejigger the arguments so that both sets of desires are expressible. I > glanced at SM5 sync before doing

Re: [Mesa-dev] [PATCH] gallium: make image views non-persistent objects

On Tue, Jan 19, 2016 at 4:42 PM, Nicolai Hähnle wrote: > On 18.01.2016 22:08, Ilia Mirkin wrote: >> >> Make them akin to shader buffers, with no refcounting/etc. Just used to >> pass data about the bound image in ->set_shader_images. >> >> Signed-off-by: Ilia Mirkin

[Mesa-dev] [PATCH] radeonsi: fix discard-only fragment shaders

From: Nicolai Hähnle When a fragment shader is used that has no outputs but does conditional discard (KILL_IF), all fragments are killed without this patch. By comparing various register settings, my conclusion is that the exec mask is either not properly forwarded to

Re: [Mesa-dev] [PATCH 2/4] i965: Provide sse2 version for rgba8 <-> bgra8 swizzle

On Tue, Jan 19, 2016 at 3:05 PM, Roland Scheidegger wrote: > Ping? Yesterday was a holiday in the US. I'm planning to review this. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] i965/vec4: Use UW type for multiply into accumulator on GEN8+

On Tue, Jan 19, 2016 at 12:57 PM, Matt Turner wrote: > On Sat, Jan 16, 2016 at 7:31 PM, Jason Ekstrand > wrote: > > > > On Jan 16, 2016 5:56 PM, "Matt Turner" wrote: > >> > >> On Thu, Jan 14, 2016 at 12:27 PM, Matt Turner

Re: [Mesa-dev] [RFC 00/63] ARB_internalformat_query2 on Mesa and i965 backend

On Tue, Jan 19, 2016 at 05:41:40PM +0100, Eduardo Lima Mitev wrote: > Hello, > > This is an RFC series adding support for the ARB_internalformat-query2 > extension: > > https://www.opengl.org/registry/specs/ARB/internalformat_query2.txt > > The corresponding bug is being tracked at: > >

[Mesa-dev] [PATCH] llvmpipe: warn about illegal use of objects in different contexts

From: Roland Scheidegger Doing that is clearly a bug. We can't quite assert as st/mesa may hit this, but increase at least visibility of it a bit. (For the non-refcounted objects it would be illegal too, but we can't detect that unless we'd store the context ourselves. Plus,

[Mesa-dev] [Bug 85586] Draw module crashes in LLVM generated code since commit 60ec95fa1e0c42bd42358185970b20c9b81591fa

https://bugs.freedesktop.org/show_bug.cgi?id=85586 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

Fixes piglit regression after fixes to duplicate layout rules. Previously catching multiple layouts was relying on the code meant to catch duplicates within a single layout(...), this change triggers the rules for multiple layouts. Cc: Mark Janes ---

[Mesa-dev] [PATCH 4/4] radeonsi: enable late VS allocation (v2)

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index f005461..ca32f5c 100644 ---

[Mesa-dev] [PATCH 3/4] radeonsi: allow tessellation on CU1 and ES on CU0

From: Marek Olšák We don't use on-chip GS, so it's not required to reserve CU1 for ES. --- src/gallium/drivers/radeonsi/si_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c

[Mesa-dev] [PATCH 2/4] winsys/amdgpu: compute num_good_compute_units correctly

From: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c b/src/gallium/winsys/amdgpu/drm/amdgpu_winsys.c index 9835024..69df363

[Mesa-dev] [PATCH 1/4] gallium/radeon: rename max_compute_units -> num_good_compute_units

From: Marek Olšák radeon sets this correctly, but not amdgpu --- src/gallium/drivers/radeon/r600_pipe_common.c | 4 ++-- src/gallium/drivers/radeon/radeon_winsys.h| 2 +- src/gallium/drivers/radeonsi/si_compute.c | 4 ++--

[Mesa-dev] [PATCH 2/2] radeonsi: implement SAMPLEPOS system value without a constant buffer load

From: Marek Olšák We always get per-sample input position. --- src/gallium/drivers/radeonsi/si_shader.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH] glsl: Conditionalize atan2 math.

I wonder how you came across that. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

This patch fixes arb_shader_image_load_store.compiler.declaration-format-qualifier-duplicate tests. However, it regresses 17 other arb_shader_image_load_store other tests with: Failed to compile fragment shader: 0:20(1): error: storage qualifiers must come after precise, invariant,

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

On Tue, 2016-01-19 at 16:28 -0800, Mark Janes wrote: > This patch fixes > arb_shader_image_load_store.compiler.declaration-format-qualifier > -duplicate > tests. However, it regresses 17 other arb_shader_image_load_store > other > tests with: > > Failed to compile fragment shader: 0:20(1):

[Mesa-dev] [PATCH 2/2] nir: Lower ldexp to arithmetic.

This is a port of Matt's GLSL IR lowering pass to NIR. It's required because we translate SPIR-V directly to NIR, bypassing GLSL IR. I haven't introduced a lower_ldexp flag, as I believe all current NIR consumers would set the flag. i965 wants this, vc4 doesn't implement this feature, and

[Mesa-dev] [PATCH 1/2] nir: Let nir_opt_algebraic rules contain unsigned constants > INT_MAX.

struct.pack('i', val) interprets `val` as a signed integer, and dies if `val` > INT_MAX. For larger constants, we need to use 'I' which interprets it as an unsigned value. This patch makes us use 'I' for all values >= 0, and 'i' for negative values. This should work in all cases.

Re: [Mesa-dev] [PATCH] glsl: add missing explicit_image_format flag to has_layout()

Timothy Arceri writes: > Fixes piglit regression after fixes to duplicate layout rules. > > Previously catching multiple layouts was relying on the code > meant to catch duplicates within a single layout(...), this > change triggers the rules for multiple layouts. >

Re: [Mesa-dev] [PATCH 1/2] radeonsi: add max waves / CU to shader stats

This series is, Reviewed-by: Edward O'Callaghan On 2016-01-20 12:39, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 33 +--- 1 file changed, 30 insertions(+), 3

Re: [Mesa-dev] [PATCH v3] glapi: Build glapi_gentable.c only on Darwin

Thanks for reviewing! Oh, I was motivated to do this patch to remove an unneeded symbol on linux as we started tracking libGL's exported symbols in Debian. As a side effect it accelerates the build a bit and reduces the size of libGL significantly. From looking at these threads [1][2] I found

Re: [Mesa-dev] mesa: Reduce libGL.so binary size by about 15%

Jeremy, did you have a chance to test this patch? This patch would be still useful for OS X. For non-OS X this patch [1] reduces the size of libGL.so further more. Thanks, Andreas [1] https://patchwork.freedesktop.org/patch/70372/ 2015-09-28 19:46 GMT+02:00 Jeremy Huddleston Sequoia

[Mesa-dev] Mesa 11.2.0 release plan

Hi all, It's time to get the idea of where were are wrt the next Mesa release - 11.2.0. As usual here is the normal plan, although everyone interested in more than welcome to chime in February 19th 2016 - Feature freeze/Release candidate 1 February 26th 2016 - Release candidate 2 March 04th 2016

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

Because I got a ton of errors about how PROGRAM_BUFFER was out of bounds for the enum. I could add them to the enum, of course, but I think that enum was about ARB_vp/fp things? -ilia On Tue, Jan 19, 2016 at 9:23 AM, Brian Paul wrote: > Can you say why you're removing

[Mesa-dev] New stable-branch 11.0 candidate pushed

Hello list, The candidate for the Mesa 11.0.9 is now available. Currently we have: - 22 queued - 20 nominated (outstanding) - and 1 rejected/obsolete patches Current queue addressed a few important driver issues - nouveau (sluggish 4K decoding, pushbuf/bufctx management), i965 (EGL crash),

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

Can you say why you're removing gl_register_file? Enums are so much nicer when debugging. -Brian On 01/18/2016 07:30 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 21

Re: [Mesa-dev] Mesa for OpenVMS

Hi, On 19 January 2016 at 02:14, Timothy Arceri wrote: > On Mon, 2016-01-18 at 16:47 +0100, Jouk Jansen wrote: >> Can someone insert these patches in the git-repository. >> I cannot do it myself, because the git-client on my OpenVMS is very >> -very >> limited and

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

On Tue, Jan 19, 2016 at 9:34 AM, Brian Paul wrote: > I don't have any issue with simply adding PROGRAM_BUFFER to the enum type. > prog_src_register::File is a 4-bit field and we currently have 13 enum > values so we're safe there (not sure if that even matters). That's cutting

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

I don't have any issue with simply adding PROGRAM_BUFFER to the enum type. prog_src_register::File is a 4-bit field and we currently have 13 enum values so we're safe there (not sure if that even matters). I know I've used gdb to debug/trace something in st_glsl_to_tgsi.cpp at least twice

Re: [Mesa-dev] Mesa for OpenVMS

On 01/19/2016 06:24 AM, Daniel Stone wrote: Hi, On 19 January 2016 at 02:14, Timothy Arceri wrote: On Mon, 2016-01-18 at 16:47 +0100, Jouk Jansen wrote: Can someone insert these patches in the git-repository. I cannot do it myself, because the git-client on my

Re: [Mesa-dev] [PATCH v2 03/10] st/mesa: add PROGRAM_BUFFER, stop using gl_register_file

On 01/19/2016 07:37 AM, Ilia Mirkin wrote: On Tue, Jan 19, 2016 at 9:34 AM, Brian Paul wrote: I don't have any issue with simply adding PROGRAM_BUFFER to the enum type. prog_src_register::File is a 4-bit field and we currently have 13 enum values so we're safe there (not

[Mesa-dev] [PATCH] glx: don't force version == 2.0 for ES2 GLX context creation

dEQP tests request a specific version. The EXT spec has been updated to allow other versions, so allow anything >= 2.0 to be requested. Signed-off-by: Ilia Mirkin --- The X server was also blocking this... a patch has been sent (pending moderator approval).

Re: [Mesa-dev] [PATCH] gallium: make image views non-persistent objects

On 18.01.2016 22:08, Ilia Mirkin wrote: Make them akin to shader buffers, with no refcounting/etc. Just used to pass data about the bound image in ->set_shader_images. Signed-off-by: Ilia Mirkin --- I don't really see a reason why these were refcounted objects. It seems

[Mesa-dev] [PATCH 6/7] radeonsi: use all SPI color formats

From: Marek Olšák because not using SPI_SHADER_32_ABGR doubles fill rate. We should also get optimal performance if alpha isn't needed or blending isn't enabled. --- src/gallium/drivers/radeon/r600_pipe_common.h | 6 +- src/gallium/drivers/radeonsi/si_blit.c |

[Mesa-dev] [PATCH 4/7] radeonsi: add shader conversion code for all SPI color formats

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 153 --- src/gallium/drivers/radeonsi/si_shader.h | 1 + 2 files changed, 140 insertions(+), 14 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

Re: [Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

On 19.01.2016 10:45, Fredrik Höglund wrote: On Tuesday 19 January 2016, Nicolai Hähnle wrote: On 18.01.2016 18:50, Ilia Mirkin wrote: On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle wrote: diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c

[Mesa-dev] [PATCH 1/7] radeonsi: don't enable blending if colormask == 0

From: Marek Olšák most likely useless, but doesn't hurt --- src/gallium/drivers/radeonsi/si_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 2a6d2c6..ea441ac 100644 ---

Re: [Mesa-dev] [PATCH 1/9] gallium: Add PIPE_CAP_BUFFER_SAMPLER_VIEW_RGBA_ONLY

On Tuesday 19 January 2016, Nicolai Hähnle wrote: > > On 18.01.2016 18:50, Ilia Mirkin wrote: > > On Mon, Jan 18, 2016 at 5:22 PM, Nicolai Hähnle wrote: > >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_screen.c > >> b/src/gallium/drivers/nouveau/nv30/nv30_screen.c >

Re: [Mesa-dev] [PATCH 6/7] radeonsi: use all SPI color formats

On 19/01/2016 17:11, Marek Olšák wrote: From: Marek Olšák because not using SPI_SHADER_32_ABGR doubles fill rate. We should also get optimal performance if alpha isn't needed or blending isn't enabled. --- src/gallium/drivers/radeon/r600_pipe_common.h | 6 +-

[Mesa-dev] [PATCH 2/7] radeonsi: use SPI_SHADER_COL_FORMAT fields instead of export_16bpc

From: Marek Olšák This does change the behavior slightly: If a shader writes COLOR[i] and that color buffer isn't bound, the shader will export MRT_NULL instead and discard the IR tree that calculates the output. The only exception is alpha-to-coverage, which

[Mesa-dev] [PATCH 7/7] radeonsi: disable SPI color outputs the shader doesn't write

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.h| 4 src/gallium/drivers/radeonsi/si_state_shaders.c | 12 2 files changed, 16 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.h

[Mesa-dev] [PATCH 3/7] radeonsi: set CB_SHADER_MASK according to SPI color formats

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_shaders.c | 52 + 1 file changed, 35 insertions(+), 17 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c b/src/gallium/drivers/radeonsi/si_state_shaders.c index

[Mesa-dev] Using all PS export formats in RadeonSI

Hi, This series adds support for all pixel shader export formats. It should double the fill rate for these formats: - 1-4 channels of type S/UINT8, S/UINT16, S/UNORM16 - 1-2 channels of type S/UINT32, FLOAT32 Some of them have to fall back to the original slow mode depending on whether

[Mesa-dev] [PATCH 5/7] radeonsi: use 32_AR for alpha-to-coverage without a color buffer

From: Marek Olšák This avoids the fp16 packing instructions. --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH] glsl: Conditionalize atan2 math.

In the old hand-writen implementation of atan2, the calculation of atan(y/x) was performed conditionally in the "then" block of the outermost if statement. I believe I accidentally lifted this out into unconditional code when converting to IR builder. For reference, the original hand-written IR

[Mesa-dev] [PATCH 1/2] radeonsi: add max waves / CU to shader stats

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 33 +--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 0c5fd32..5c536f8

Re: [Mesa-dev] [PATCH] gallium: make image views non-persistent objects

FWIW why exactly are pipe_sampler_view and pipe_surface ref counted? These are all the same too from a high level perspective. I guess though there'd be significant effort to change that... Roland Am 19.01.2016 um 04:08 schrieb Ilia Mirkin: > Make them akin to shader buffers, with no

Re: [Mesa-dev] [PATCH 6/7] radeonsi: use all SPI color formats

On Tue, Jan 19, 2016 at 5:20 PM, Axel Davy wrote: > On 19/01/2016 17:11, Marek Olšák wrote: >> >> From: Marek Olšák >> >> because not using SPI_SHADER_32_ABGR doubles fill rate. >> >> We should also get optimal performance if alpha isn't needed or blending

[Mesa-dev] [RFC 00/63] ARB_internalformat_query2 on Mesa and i965 backend

Hello, This is an RFC series adding support for the ARB_internalformat-query2 extension: https://www.opengl.org/registry/specs/ARB/internalformat_query2.txt The corresponding bug is being tracked at: https://bugs.freedesktop.org/show_bug.cgi?id=92687 Why is this an RFC series instead of a

[Mesa-dev] [RFC 01/63] mesa: Add QueryInternalFormat to device driver virtual table

This new function queries different driver parameters for a particular target and texture format. It is basically a driver hook to support ARB_internalformat_query2. Since ARB_internalformat_query2 introduced several new query parameters over ARB_internalformat_query, having one driver hook for

[Mesa-dev] [RFC 02/63] mesa: Add a default QueryInternalFormat() function for drivers

This is a fallback function for drivers not implementing ARB_internalformat_query2. --- src/mesa/drivers/common/driverfuncs.c | 1 + src/mesa/main/formatquery.c | 16 src/mesa/main/formatquery.h | 5 + 3 files changed, 22 insertions(+) diff --git

[Mesa-dev] [RFC 18/63] mesa/teximage: make public is_renderable_texture_format

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to check if the 'internalformat' passed is supported by texture MULTISAMPLE 'targets'. --- src/mesa/main/teximage.c | 6 +++--- src/mesa/main/teximage.h | 3 +++ 2 files changed, 6

[Mesa-dev] [RFC 20/63] mesa/main: not fill mesa_error on _mesa_legal_texture_base_format_for_target

From: Alejandro Piñeiro This would allow to use this method if you are just querying if it is allowed, like for arb_internalformat_query2. --- src/mesa/main/teximage.c | 18 +- src/mesa/main/teximage.h | 4 +--- src/mesa/main/texstorage.c | 8

[Mesa-dev] [RFC 03/63] i965: Add boilerplate function for QueryInternalFormat driver hook

By default, we call back the driver's hook fallback function that has generic implementations for the all the queries. --- src/mesa/drivers/dri/i965/Makefile.sources | 1 + src/mesa/drivers/dri/i965/brw_context.c | 1 + src/mesa/drivers/dri/i965/brw_context.h | 5

[Mesa-dev] [RFC 23/63] mesa/formatquery: Added the INTERNALFORMAT_SUPPORTED query

From: Antia Puentes --- src/mesa/main/formatquery.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 11bf133..da65624 100644 --- a/src/mesa/main/formatquery.c +++

[Mesa-dev] [RFC 05/63] i965/formatquery: Respond queries SAMPLES and NUM_SAMPLE_COUNTS

This effectively disables old QuerySamplesForFormat driver hook, since it is never called by Mesa anymore. --- src/mesa/drivers/dri/i965/brw_context.c | 1 - src/mesa/drivers/dri/i965/brw_context.h | 2 -- src/mesa/drivers/dri/i965/brw_formatquery.c | 14 +- 3 files changed,

[Mesa-dev] [RFC 16/63] mesa: Add dispatch and extension XML for GL_ARB_internalformat_query2

From: Alejandro Piñeiro Equivalent to commit bda540 (that added GL_ARB_internalformat_query) --- src/mapi/glapi/gen/ARB_internalformat_query2.xml | 119 +++ src/mapi/glapi/gen/gl_API.xml| 2 +-

[Mesa-dev] [RFC 15/63] mesa/formatquery: Added boilerplate code to extend GetInternalformativ

From: Antia Puentes The goal is to extend the GetInternalformativ query to implement the ARB_internalformat_query2 specification, keeping the behaviour defined by the ARB_internalformat_query if ARB_internalformat_query2 is not supported. --- src/mesa/main/formatquery.c |

[Mesa-dev] [RFC 13/63] mesa/formatquery: Added function to set 'unsupported' responses

From: Antia Puentes The ARB_internalformat_query2 specification defines which is the reponse best representing "not supported" or "not applicable" for each . Queries for unsupported features, targets, internalformats, combinations of: target and internalformat, target and

[Mesa-dev] [RFC 22/63] mesa/formatquery: Added a func to check supported

From: Antia Puentes From the ARB_internalformat_query2 specification: "The INTERNALFORMAT_SUPPORTED can be used to determine if the internal format is supported, and the other are defined in terms of whether or not the format is supported." ---

[Mesa-dev] [RFC 09/63] mesa/formatquery: Use new driver hook QueryInternalFormat

Implements SAMPLES and NUM_SAMPLE_COUNTS queries using the new generic driver call QueryInternalFormat, which is being introduced as replacement of QuerySamplesForFormat to support ARB_internalformat_query2. --- src/mesa/main/formatquery.c | 42 ++ 1 file

[Mesa-dev] [RFC 17/63] mesa/main: Added empty skeleton of glGetInternalformati64v

From: Antia Puentes --- src/mesa/main/formatquery.c | 16 src/mesa/main/formatquery.h | 4 2 files changed, 20 insertions(+) diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c index 8d0cded..f9795ae 100644 ---

[Mesa-dev] [RFC 12/63] mesa/formatquery: Added function to validate parameters

From: Antia Puentes Handles the cases where an error should be returned according to the ARB_internalformat_query and ARB_internalformat_query2 specifications. --- src/mesa/main/formatquery.c | 228 1 file changed, 228

[Mesa-dev] [RFC 19/63] mesa/teximage: Make _mesa_format_no_online_compression public

From: Antia Puentes It will be used by the ARB_internalformat_query2 implementation to check if a certain compressed 'internalformat' is supported by texture 'targets'. --- src/mesa/main/teximage.c | 2 +- src/mesa/main/teximage.h | 3 +++ 2 files changed, 4 insertions(+),

[Mesa-dev] [RFC 04/63] i965: Move brw_query_samples_for_format() to brw_queryformat.c

Now that there is a dedicated source file for internal format queries, this function belongs there. --- src/mesa/drivers/dri/i965/brw_context.c | 38 src/mesa/drivers/dri/i965/brw_context.h | 2 ++ src/mesa/drivers/dri/i965/brw_formatquery.c | 39

  1   2   >