Re: [Mesa-dev] [PATCH v3] isl: Replace bash generator with python generator

2016-06-13 Thread Jason Ekstrand
On Mon, Jun 13, 2016 at 11:19 AM, Dylan Baker wrote: > This replaces the current bash generator with a python based generator > using mako. It's quite fast and works with both python 2.7 and python > 3.5, and should work with 3.3+ and maybe even 3.2. > > It produces an

[Mesa-dev] [PATCH 09/29] mesa: Track enabled lights in a bitmask

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich This enables some optimizations afterwards. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/enable.c | 2 ++ src/mesa/main/light.c | 1 + src/mesa/main/mtypes.h | 2 ++ 3

[Mesa-dev] [PATCH 27/29] mesa: Use bitmask/ffs to iterate the active_samplers bitmask.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 24/29] mesa: Use bitmask/ffs to iterate SamplersUsed

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 29/29] vbo: Use a bitmask to track the active arrays in vbo_save*.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich The use of a bitmask makes functions iterating only active attributes less visible in profiles. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 28/29] vbo: Use a bitmask to track the active arrays in vbo_exec*.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich The use of a bitmask makes functions iterating only active attributes less visible in profiles. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for ff shader keys.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of

[Mesa-dev] [PATCH 08/29] mesa: Rename CoordReplaceBits back to CoordReplace.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich It used to be called like that and fits better with 80 columns. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 07/29] mesa: Remove the now unused CoordsReplace array.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Now that all users are converted, remove the array. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/main/mtypes.h | 1 -

[Mesa-dev] [PATCH 26/29] mesa: Use bitmask/ffs to iterate the enabled textures.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 05/29] i915: Convert i915 to use CoordsReplaceBits.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 03/29] gallium: Convert the state_tracker to use CoordsReplaceBits.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 01/29] mesa: Add gl_point_attrib::CoordReplaceBits bitfield.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich The aim is to replace the CoordReplace array by a bitfield. Until all drivers are converted, establish the bitfield in parallel to the CoordReplace array. v2: Fix bitmask logic. Reviewed-by: Brian Paul Reviewed-by: Ian

[Mesa-dev] [PATCH 02/29] swrast: Convert swrast to use CoordsReplaceBits.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/swrast/s_points.c | 4 ++--

[Mesa-dev] [PATCH 06/29] i965: Convert i965 to use CoordsReplaceBits.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich --- src/mesa/drivers/dri/i965/brw_sf.c

[Mesa-dev] [PATCH 04/29] r200: convert r200 to use CoordsReplaceBits.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Switch over to use the CoordsReplaceBits bitmask. Reviewed-by: Brian Paul Reviewed-by: Ian Romanick Signed-off-by: Mathias Fröhlich ---

[Mesa-dev] [PATCH 15/29] mesa: Switch to bitmask based enabled lights in gen_matypes.c

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/x86/gen_matypes.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/x86/gen_matypes.c

[Mesa-dev] [PATCH 18/29] mesa: Use bitmask/ffs to build ff fragment shader keys.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. The bitmask used here for iteration is a combination of different enabled masks present for texture units. v2: Use _mesa_bit_scan{,64}

[Mesa-dev] [PATCH 16/29] mesa: Remove the linked list of enabled lights

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Clean up after conversion to bitmasks. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/context.c | 11 +-- src/mesa/main/enable.c | 4 src/mesa/main/light.c

[Mesa-dev] [PATCH 20/29] mesa: Use bitmask/ffs to iterate enabled clip planes.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 14/29] radeon/r200: Use bitmask/ffs to iterate enabled lights

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of

[Mesa-dev] [PATCH 17/29] mesa: Use bitmask/ffs to build ff vertex shader keys.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. The bitmask used here for iteration is a combination of different enabled masks present for texture units. v2: Use _mesa_bit_scan{,64}

[Mesa-dev] [PATCH 19/29] mesa: Use bitmask/ffs to iterate color material attributes.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 23/29] i965: Use bitmask/ffs to iterate used vertex attributes.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 21/29] radeon/r200: Use bitmask/ffs to iterate enabled clip planes.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 22/29] i965: Use bitmask/ffs to iterate enabled clip planes.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces an iterate and test bit in a bitmask loop by a loop only iterating over the bits set in the bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of _mesa_bit_scan{,64}. Reviewed-by: Brian Paul

[Mesa-dev] [PATCH 13/29] nouveau: Use bitmask/ffs to iterate enabled lights

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces a loop that iterates all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of

[Mesa-dev] [PATCH 25/29] mesa: Use designated bool value to check texture unit completeness.

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich The change helps to use the bitmask/ffs in the next change. Reviewed-by: Brian Paul Signed-off-by: Mathias Fröhlich --- src/mesa/main/texstate.c | 5 - 1 file changed, 4 insertions(+), 1

[Mesa-dev] [PATCH 10/29] mesa: Use bitmask/ffs to iterate enabled lights

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces loops that iterate all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of

[Mesa-dev] [PATCH 00/29] Make more use of bitmasks v3

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi all, following a series with performance improvements for cpu/draw bound applications. This part makes more use of the bitmask/ffs technique for iterating a set of enabled items. The gains are not huge but they are noticable for some of my

[Mesa-dev] [PATCH 12/29] tnl: Use bitmask/ffs to iterate enabled lights

2016-06-13 Thread Mathias . Froehlich
From: Mathias Fröhlich Replaces loops that iterate all lights and test which of them is enabled by a loop only iterating over the bits set in the enabled bitmask. v2: Use _mesa_bit_scan{,64} instead of open coding. v3: Use u_bit_scan{,64} instead of

Re: [Mesa-dev] [PATCH 0/2] Move u_bit_scan from gallium to util.

2016-06-13 Thread Mathias Fröhlich
Hi Brian, On Friday, June 10, 2016 12:41:29 Brian Paul wrote: > Long term, I'd like to get away from imports.h defining or including a > bunch of stuff that a lot of .c files don't need. So I'd prefer to > include bitscan.h where needed, but I agree with your concerns. In that case, ideally we

[Mesa-dev] [PATCH v2] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Ilia Mirkin
Previously we were only restricting based on ES/non-ES-ness and whether the overall enable bit had been flipped on. However we have been adding more fine-grained restrictions, such as based on compat profiles, as well as specific ES versions. Most of the time this doesn't matter, but it can create

Re: [Mesa-dev] [PATCH] clover: Include generated sources in AM_CPPFLAGS

2016-06-13 Thread Francisco Jerez
Michel Dänzer writes: > On 14.06.2016 11:46, Aaron Watry wrote: >> git_sha1.c is generated in $(top_builddir)/src. >> >> Fixes out-of-tree builds since 4825264f75c83576. >> >> Signed-off-by: Aaron Watry >> --- >>

Re: [Mesa-dev] [PATCH] clover: Include generated sources in AM_CPPFLAGS

2016-06-13 Thread Michel Dänzer
On 14.06.2016 11:46, Aaron Watry wrote: > git_sha1.c is generated in $(top_builddir)/src. > > Fixes out-of-tree builds since 4825264f75c83576. > > Signed-off-by: Aaron Watry > --- > src/gallium/state_trackers/clover/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > >

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Ilia Mirkin
On Mon, Jun 13, 2016 at 1:27 PM, Eric Engestrom wrote: > On Mon, Jun 13, 2016 at 09:39:39AM -0700, Nanley Chery wrote: >> You can add an entry to the end of the enum defined in extensions.h called >> "MESA_EXTENSION_COUNT" or similar. > > This is a good idea, but with

Re: [Mesa-dev] [PATCH] mesa/glsl: stop using GL shader type internally

2016-06-13 Thread Jan Vesely
On Tue, 2016-06-14 at 10:59 +1000, Timothy Arceri wrote: > Ping. just FYI, I occasionally find your patches posted to mesa-dev in spam (gmail) with message: "Why is this message in Spam? It has a from address in yahoo.com.au but has failed yahoo.com.au's required tests for authentication." Jan

Re: [Mesa-dev] [PATCH] Avoid ASan new-delete-type-mismatch

2016-06-13 Thread Ilia Mirkin
On Fri, Jun 10, 2016 at 11:34 AM, Stephan Bergmann wrote: > On 06/10/2016 05:20 PM, Ilia Mirkin wrote: >> >> It's pretty easy for me to fix up before I apply it too, but if I "git >> am" your email, it'll be attributed to the one you sent it from, >> unless that From line is

[Mesa-dev] [PATCH] clover: Include generated sources in AM_CPPFLAGS

2016-06-13 Thread Aaron Watry
git_sha1.c is generated in $(top_builddir)/src. Fixes out-of-tree builds since 4825264f75c83576. Signed-off-by: Aaron Watry --- src/gallium/state_trackers/clover/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/clover/Makefile.am

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 --- Comment #5 from Aaron Watry --- The issue manifests itself with an out-of-tree build that includes clover. I'll be sending a patch to the list momentarily. -- You are receiving this mail because: You are the QA Contact

[Mesa-dev] [Bug 50976] Fails to build with error: git_sha1.h: No such file or directory

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50976 Alexandre Demers changed: What|Removed |Added See Also|

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 Alexandre Demers changed: What|Removed |Added See Also|

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 --- Comment #3 from Alexandre Demers --- (In reply to Emil Velikov from comment #2) > Vedran friendly advice - changing assignee to yourself, limits notifications > to others as the bug evolves. Some people just

[Mesa-dev] [Bug 96518] [llvmpipe] piglit linestipple regression

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96518 --- Comment #1 from Roland Scheidegger --- I suppose I missed that when I did a piglit run... This is fairly interesting, it seems to be due to inaccurate float math. The stipple code gets for position x0,x1 10.5, 34.5

Re: [Mesa-dev] [PATCH] glsl/builtin_variables: Populate MaxCombinedShaderStorageBlocks on GLSL 4.40

2016-06-13 Thread Kenneth Graunke
On Monday, June 13, 2016 12:50:12 PM PDT Eduardo Lima Mitev wrote: > Built-in variable "MaxCombinedShaderStorageBlocks" was added to GLSL 4.40 > revision 9. > > Section "1.2.1 Changes since revision 8 of GLSL version 4.40", > page 3 of the PDF states: > > "Bug 11734: Add

[Mesa-dev] [PATCH] gallium/util: don't use blocksize for minify for assertions

2016-06-13 Thread sroland
From: Roland Scheidegger The previous assertions required for texture sizes smaller than block_size that src_box.x + src_box.width still be block size. (e.g. for a texture with width 3, and src_box.x = 0, src_box.width would have to be 4 to not assert.) This caused some

Re: [Mesa-dev] [PATCH] glsl: make sure UBO arrays are sized in ES

2016-06-13 Thread Dave Airlie
Oops, Reviewed-by: Dave Airlie On 14 June 2016 at 10:49, Timothy Arceri wrote: > This check was removed in 5b2675093e86 add it back in. > > Cc: Dave Airlie > https://bugs.freedesktop.org/show_bug.cgi?id=96349 > --- >

Re: [Mesa-dev] [PATCH v2] swr: automake: don't ship LLVM version specific generated sources

2016-06-13 Thread Rowley, Timothy O
A clean tree build works with this version, but distcheck fails: ... rm -f config.status config.cache config.log configure.lineno config.status.lineno rm -f Makefile ERROR: files left in build directory after distclean: ./src/gallium/drivers/swr/rasterizer/jitter/builder_gen.cpp

Re: [Mesa-dev] [PATCH] mesa/glsl: stop using GL shader type internally

2016-06-13 Thread Timothy Arceri
Ping. On Sun, 2016-06-05 at 13:17 +1000, Timothy Arceri wrote: > Instead use the internal gl_shader_stage enum everywhere. This > makes things more consistent and gets rid of unnecessary > conversions. > Ideally it would be nice to remove the Type field from gl_shader > altogether but currently

[Mesa-dev] [PATCH] glsl: make sure UBO arrays are sized in ES

2016-06-13 Thread Timothy Arceri
This check was removed in 5b2675093e86 add it back in. Cc: Dave Airlie https://bugs.freedesktop.org/show_bug.cgi?id=96349 --- src/compiler/glsl/ast_to_hir.cpp | 14 ++ 1 file changed, 14 insertions(+) diff --git a/src/compiler/glsl/ast_to_hir.cpp

Re: [Mesa-dev] [PATCH] fixup! genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE

2016-06-13 Thread Mauro Rossi
>The patch that I've sent was a "fixup" (i.e. is to be squashed with >the commit name that follows). That very same has the headers in the >Makefiles.sources Hi, I had missed that src/intel/genxml/Makefile.sources was already OK in original Jason's patch, so there's no need for changes there.

Re: [Mesa-dev] [PATCH 2/2] clover: fix getting struct args api size

2016-06-13 Thread Francisco Jerez
Serge Martin writes: > This fix getting the size of a struct arg. vec3 types still work ok. > Only buit-in args need to have power of two alignment, getTypeAllocSize > reports the correct size. > --- > src/gallium/state_trackers/clover/llvm/invocation.cpp | 3 ++- > 1 file

[Mesa-dev] [Bug 96519] radeon r400 GPU locks on ppc64

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96519 --- Comment #1 from herminio.hernande...@gmail.com --- Created attachment 124519 --> https://bugs.freedesktop.org/attachment.cgi?id=124519=edit xorg log -- You are receiving this mail because: You are the assignee for the bug. You are the QA

[Mesa-dev] [Bug 96519] radeon r400 GPU locks on ppc64

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96519 Bug ID: 96519 Summary: radeon r400 GPU locks on ppc64 Product: Mesa Version: 11.0 Hardware: PowerPC OS: Linux (All) Status: NEW Severity: normal

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 --- Comment #2 from Emil Velikov --- Vedran friendly advice - changing assignee to yourself, limits notifications to others as the bug evolves. Some people just state that they're working on it, without changing the

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 Vedran Miletić changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |ved...@miletic.net

[Mesa-dev] [Bug 96518] [llvmpipe] piglit linestipple regression

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96518 Bug ID: 96518 Summary: [llvmpipe] piglit linestipple regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Keywords:

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96517 --- Comment #4 from Ilia Mirkin --- \(In reply to Roland Scheidegger from comment #2) > (In reply to Ilia Mirkin from comment #1) > > This is a llvmpipe bug, see discussion starting with > > > >

[Mesa-dev] [PATCH v2] swr: automake: don't ship LLVM version specific generated sources

2016-06-13 Thread Emil Velikov
From: Emil Velikov Otherwise things will fail to build, if the builder is using another version of LLVM. v2: annotate all the dependencies of builder_gen.h Cc: "12.0" Cc: Tim Rowley Cc: Chuck Atkins

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96517 --- Comment #3 from Roland Scheidegger --- (In reply to Roland Scheidegger from comment #2) > tracker never did and other state trackers have to cope with it too. Sorry, that should have been drivers here. -- You are

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96517 --- Comment #2 from Roland Scheidegger --- (In reply to Ilia Mirkin from comment #1) > This is a llvmpipe bug, see discussion starting with > > https://lists.freedesktop.org/archives/mesa-dev/2016-June/119829.html Well

Re: [Mesa-dev] [PATCH] fixup! genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE

2016-06-13 Thread Mauro Rossi
> Jason, feel free to pick whichever patch you like - the annoyingly > verbose from me or the shorter (en route to victory) from Mauro. > > -Emil Hi, just one final warning my condensed PATCH 1/2 works, but I just noticed now that it produces the following Warnings including

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96517 Ilia Mirkin changed: What|Removed |Added CC|imir...@alum.mit.edu| --- Comment #1

[Mesa-dev] [Bug 96517] [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96517 Bug ID: 96517 Summary: [llvmpipe] piglit arb_uniform_buffer_object-rendering-dsa regression Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 Bug ID: 96516 Summary: [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h Product: Mesa

[Mesa-dev] [Bug 96516] [bisected: 482526] "clover: Update OpenCL version string to match OpenGL": clover's build fails because of missing git_sha1.h

2016-06-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96516 Alexandre Demers changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] fixup! genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE

2016-06-13 Thread Emil Velikov
Hi Mauro, On 13 June 2016 at 23:15, Mauro Rossi wrote: > Hi Jason, Emil, > > Jason patch equires additional changes to correctly complete the > builld as the new generated headers gen{4,45,5}_pack.h need also to be > added to src/intel/Makefile.sources in

Re: [Mesa-dev] [PATCH] mesa: Make TexSubImage check negative dimensions sooner.

2016-06-13 Thread Kenneth Graunke
On Wednesday, June 8, 2016 4:57:14 PM PDT Patrick Baggett wrote: > Sorry, didn't CC mesa-dev, trying again... > > On Wed, Jun 8, 2016 at 4:11 PM, Kenneth Graunke wrote: > > Two dEQP tests expect INVALID_VALUE errors for negative width/height > > parameters, but get

Re: [Mesa-dev] [PATCH] mesa: Make TexSubImage check negative dimensions sooner.

2016-06-13 Thread Anuj Phogat
On Mon, Jun 13, 2016 at 3:25 PM, Kenneth Graunke wrote: > On Monday, June 13, 2016 2:19:36 PM PDT Anuj Phogat wrote: >> On Wed, Jun 8, 2016 at 2:11 PM, Kenneth Graunke >> wrote: >> > Two dEQP tests expect INVALID_VALUE errors for negative

Re: [Mesa-dev] [PATCH] mesa: Make TexSubImage check negative dimensions sooner.

2016-06-13 Thread Kenneth Graunke
On Monday, June 13, 2016 2:19:36 PM PDT Anuj Phogat wrote: > On Wed, Jun 8, 2016 at 2:11 PM, Kenneth Graunke wrote: > > Two dEQP tests expect INVALID_VALUE errors for negative width/height > > parameters, but get INVALID_OPERATION because they haven't actually > > created a

Re: [Mesa-dev] [PATCH] fixup! genxml: Add enough XML for gens 4, 4.5, and 5 to get SURFACE_STATE

2016-06-13 Thread Mauro Rossi
Hi Jason, Emil, Jason patch equires additional changes to correctly complete the builld as the new generated headers gen{4,45,5}_pack.h need also to be added to src/intel/Makefile.sources in GENXML_GENERATED_FILES variable I've not been able to explore the reuse if autoconf rules, because it is

Re: [Mesa-dev] [PATCH] mesa: Make TexSubImage check negative dimensions sooner.

2016-06-13 Thread Anuj Phogat
On Wed, Jun 8, 2016 at 2:11 PM, Kenneth Graunke wrote: > Two dEQP tests expect INVALID_VALUE errors for negative width/height > parameters, but get INVALID_OPERATION because they haven't actually > created a destination image. This is arguably not a bug in Mesa, as >

Re: [Mesa-dev] [PATCH] Android: add missing u_math.h include path for libmesa_isl

2016-06-13 Thread Kenneth Graunke
On Monday, June 13, 2016 1:45:53 PM PDT Rob Herring wrote: > Commit 87d062a94080 ("i965: Fix shared local memory size for Gen9+.") > added u_math.h include which broke the Android build: > > In file included from external/mesa3d/src/intel/isl/isl_storage_image.c:25: > In file included from >

[Mesa-dev] [PATCH] Android: add missing u_math.h include path for libmesa_isl

2016-06-13 Thread Rob Herring
Commit 87d062a94080 ("i965: Fix shared local memory size for Gen9+.") added u_math.h include which broke the Android build: In file included from external/mesa3d/src/intel/isl/isl_storage_image.c:25: In file included from external/mesa3d/src/mesa/drivers/dri/i965/brw_compiler.h:29:

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Nanley Chery
On Mon, Jun 13, 2016 at 9:08 AM, Ilia Mirkin wrote: > On Mon, Jun 13, 2016 at 12:03 PM, Nanley Chery > wrote: > > > > > > On Sun, Jun 12, 2016 at 4:23 PM, Ilia Mirkin > wrote: > >> > >> Previously we were only restricting

[Mesa-dev] [PATCH v3] isl: Replace bash generator with python generator

2016-06-13 Thread Dylan Baker
This replaces the current bash generator with a python based generator using mako. It's quite fast and works with both python 2.7 and python 3.5, and should work with 3.3+ and maybe even 3.2. It produces an almost identical file except for a minor layout changes, and the addition of a "generated

Re: [Mesa-dev] [PATCH v2 1/2] vl: Fix trivial sign compare warnings

2016-06-13 Thread Jan Vesely
On Mon, 2016-06-13 at 15:55 +0100, Emil Velikov wrote: > Hi Jan, > > On 10 June 2016 at 04:01, Jan Vesely wrote: > > From: Jan Vesely > > > > v2: add whitepace fixes > I've squashed a couple more and pushed the patch to master. > > Can you please

[Mesa-dev] [PATCH] swr: automake: don't ship LLVM version specific generated sources

2016-06-13 Thread Emil Velikov
From: Emil Velikov Otherwise things will fail to build, if the builder is using another version of LLVM. Cc: "12.0" Cc: Tim Rowley Cc: Chuck Atkins Reported-by: Chuck Atkins

[Mesa-dev] [PATCH 1/2] gallium/util: import the multithreaded job queue from amdgpu winsys

2016-06-13 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/Makefile.sources| 2 + src/gallium/auxiliary/util/u_queue.c | 129 ++ src/gallium/auxiliary/util/u_queue.h | 80 src/gallium/winsys/amdgpu/drm/amdgpu_cs.c |

[Mesa-dev] [PATCH 2/2] winsys/radeon: use the common job queue for multithreaded command submission

2016-06-13 Thread Marek Olšák
From: Marek Olšák --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 22 src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 4 +- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 63 ++-

[Mesa-dev] [PATCH 2/2] radeonsi: use u_blitter for mipmap generation

2016-06-13 Thread Marek Olšák
From: Marek Olšák This reduces time spend in glGenerateMipmap by a half. --- src/gallium/drivers/radeonsi/si_blit.c | 37 +- src/gallium/drivers/radeonsi/si_pipe.c | 2 +- 2 files changed, 33 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] gallium/u_blitter: implement mipmap generation

2016-06-13 Thread Marek Olšák
From: Marek Olšák for pipe_context::generate_mipmap first move some of the blit code from util_blitter_blit_generic to a separate function, then use it from util_blitter_generate_mipmap --- src/gallium/auxiliary/util/u_blitter.c | 346 ++---

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Eric Engestrom
On Mon, Jun 13, 2016 at 09:39:39AM -0700, Nanley Chery wrote: > You can add an entry to the end of the enum defined in extensions.h called > "MESA_EXTENSION_COUNT" or similar. This is a good idea, but with one caveat: I've seen twice already bugs caused by people using ALL_CAPS counter entries

Re: [Mesa-dev] [Mesa-stable] [PATCH] swr: fix -march flag for AVX

2016-06-13 Thread Emil Velikov
On 13 June 2016 at 15:43, Rowley, Timothy O wrote: > >> On Jun 12, 2016, at 3:56 AM, Steven Newbury wrote: >> >> On Fri, 2016-06-10 at 16:05 -0400, Ilia Mirkin wrote: >>> On Fri, Jun 10, 2016 at 3:43 PM, Tim Rowley >>

Re: [Mesa-dev] [PATCH] util: update some assertions in util_resource_copy_region()

2016-06-13 Thread Jose Fonseca
On 13/06/16 17:35, Brian Paul wrote: To cope with copies of compressed images which are not multiples of the block size. Suggested by Jose. --- src/gallium/auxiliary/util/u_surface.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] util: update some assertions in util_resource_copy_region()

2016-06-13 Thread Roland Scheidegger
Am 13.06.2016 um 18:35 schrieb Brian Paul: > To cope with copies of compressed images which are not multiples of > the block size. Suggested by Jose. > --- > src/gallium/auxiliary/util/u_surface.c | 12 > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Ilia Mirkin
On Mon, Jun 13, 2016 at 12:39 PM, Nanley Chery wrote: > > > On Mon, Jun 13, 2016 at 9:16 AM, Ilia Mirkin wrote: >> >> On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov >> wrote: >> > Hi Ilia, >> > >> > On 13 June 2016 at 00:23,

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Emil Velikov
On 13 June 2016 at 17:16, Ilia Mirkin wrote: > On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov > wrote: >> Hi Ilia, >> >> On 13 June 2016 at 00:23, Ilia Mirkin wrote: >> >>> @@ -81,6 +81,7 @@ MAIN_FILES = \ >>>

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Nanley Chery
On Mon, Jun 13, 2016 at 9:16 AM, Ilia Mirkin wrote: > On Mon, Jun 13, 2016 at 12:11 PM, Emil Velikov > wrote: > > Hi Ilia, > > > > On 13 June 2016 at 00:23, Ilia Mirkin wrote: > > > >> @@ -81,6 +81,7 @@ MAIN_FILES = \ > >>

Re: [Mesa-dev] [PATCH] radeonsi: add a debug flag for unsafe math LLVM optimizations

2016-06-13 Thread Matt Arsenault
> On Jun 13, 2016, at 09:27, Marek Olšák wrote: > > + { "unsafemath", DBG_UNSAFE_MATH, "Enable unsafe math shader > optimizations" }, Perhaps one for each of the individual fast math options as well (no nans, no signed zeros

[Mesa-dev] [PATCH] util: update some assertions in util_resource_copy_region()

2016-06-13 Thread Brian Paul
To cope with copies of compressed images which are not multiples of the block size. Suggested by Jose. --- src/gallium/auxiliary/util/u_surface.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/util/u_surface.c

[Mesa-dev] [PATCH] radeonsi: add a debug flag for unsafe math LLVM optimizations

2016-06-13 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/drivers/radeonsi/si_shader.c | 16 3 files changed, 18 insertions(+) diff --git

Re: [Mesa-dev] [PATCH] radeonsi: don't generate "ret void undef"

2016-06-13 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Mon, Jun 13, 2016 at 6:17 PM, Marek Olšák wrote: > From: Marek Olšák > > Use LLVMBuildRetVoid in epilogs and the GS copy shader and > si_llvm_build_ret otherwise. > --- >

Re: [Mesa-dev] Mesa (master): st/mesa: use buffer usage history to set dirty flags for revalidation

2016-06-13 Thread Brian Paul
On 06/13/2016 10:04 AM, Marek Olšák wrote: On Mon, Jun 13, 2016 at 5:17 PM, Roland Scheidegger wrote: Am 13.06.2016 um 14:53 schrieb Marek Olšák: On Mon, Jun 13, 2016 at 1:14 PM, Jose Fonseca wrote: On 10/06/16 15:40, Roland Scheidegger wrote: Am

Re: [Mesa-dev] [PATCH] glsl: reuse main extension table to appropriate restrict extensions

2016-06-13 Thread Eric Engestrom
On Mon, Jun 13, 2016 at 12:08:24PM +0100, Eric Engestrom wrote: > > > diff --git a/src/mesa/main/extensions_table.c > > b/src/mesa/main/extensions_table.c > > new file mode 100644 > > index 000..1e37fbc > > --- /dev/null > > +++ b/src/mesa/main/extensions_table.c > > @@ -0,0 +1,51 @@ > > +/*

[Mesa-dev] [PATCH] gallium/radeon: num-cs-flushes query should display per-frame average

2016-06-13 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeon/r600_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/gallium/drivers/radeon/r600_query.c index f090f1c..2e06746 100644 ---

[Mesa-dev] [PATCH] gallium/radeon: add driver queries for compute/dma call stats and spills

2016-06-13 Thread Marek Olšák
From: Marek Olšák also print the average count per frame --- src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/radeon/r600_query.c | 30 ++- src/gallium/drivers/radeon/r600_query.h | 4

[Mesa-dev] [PATCH] radeonsi: don't generate "ret void undef"

2016-06-13 Thread Marek Olšák
From: Marek Olšák Use LLVMBuildRetVoid in epilogs and the GS copy shader and si_llvm_build_ret otherwise. --- src/gallium/drivers/radeonsi/si_shader.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git

[Mesa-dev] [PATCH 1/3] gallium/radeon: add micro_tile_mode to radeon_surf

2016-06-13 Thread Marek Olšák
From: Marek Olšák for easier access --- src/gallium/drivers/radeon/radeon_winsys.h | 1 + src/gallium/winsys/amdgpu/drm/amdgpu_surface.c | 15 +++ src/gallium/winsys/radeon/drm/radeon_drm_surface.c | 30 +++--- 3 files changed, 43

  1   2   >