Re: [Mesa-dev] [PATCH] docs: Add GL4.4 and ARB_enhanced_layouts to the release notes

2016-07-30 Thread Timothy Arceri
On Sat, 2016-07-30 at 18:04 +1000, Edward O'Callaghan wrote: > > On 07/30/2016 10:25 AM, Timothy Arceri wrote: > > --- > >  Not sure is we need to be more careful about mentioning we support > > 4.4 > >  thoughts? > s/is/if/ > > Well in fact, any reason why we can't actually claim 4.5 support

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-07-30 Thread Jan Vesely
On Sat, 2016-07-30 at 23:40 +0200, Marek Olšák wrote: > On Sat, Jul 30, 2016 at 8:33 PM, Grazvydas Ignotas > wrote: > > > > On Sat, Jul 30, 2016 at 6:22 PM, Marek Olšák > > wrote: > > > > > > From: Marek Olšák > > > > > > for

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-07-30 Thread Marek Olšák
On Sat, Jul 30, 2016 at 8:33 PM, Grazvydas Ignotas wrote: > On Sat, Jul 30, 2016 at 6:22 PM, Marek Olšák wrote: >> From: Marek Olšák >> >> for debugging >> --- >> src/gallium/auxiliary/os/os_process.c | 37 >>

Re: [Mesa-dev] [PATCH 3/3] glsl: be more strict on block qualifiers

2016-07-30 Thread Kenneth Graunke
On Saturday, July 30, 2016 4:38:06 PM PDT Timothy Arceri wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96528 > --- > src/compiler/glsl/ast_to_hir.cpp | 61 > > 1 file changed, 50 insertions(+), 11 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH] docs: Add GL4.4 and ARB_enhanced_layouts to the release notes

2016-07-30 Thread Kenneth Graunke
On Saturday, July 30, 2016 10:25:09 AM PDT Timothy Arceri wrote: > --- > Not sure is we need to be more careful about mentioning we support 4.4 > thoughts? Looks good to me. signature.asc Description: This is a digitally signed message part. ___

[Mesa-dev] [PATCH] gallium/util: fix error detection in s3tc init

2016-07-30 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/gallium/auxiliary/util/u_format_s3tc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c b/src/gallium/auxiliary/util/u_format_s3tc.c index

Re: [Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-07-30 Thread Grazvydas Ignotas
On Sat, Jul 30, 2016 at 6:22 PM, Marek Olšák wrote: > From: Marek Olšák > > for debugging > --- > src/gallium/auxiliary/os/os_process.c | 37 > +++ > src/gallium/auxiliary/os/os_process.h | 2 ++ > 2 files changed, 39

Re: [Mesa-dev] [PATCH] u_vbuf: fix potentially bogus assert

2016-07-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Jul 30, 2016 at 5:40 PM, Rob Clark wrote: > There are cases where we hit u_vbuf path due to alignment or pitch- > alignment restrictions, but for an output-format that u_vbuf does not > support translating (yet

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

2016-07-30 Thread Marek Olšák
On Sat, Jul 30, 2016 at 6:16 PM, Roland Scheidegger wrote: > This looks very bogus to me. > How is this supposed to work if you immediately close the library again? > The functions are still going to get used. > This just segfaults right, left and center. > > If you want to

[Mesa-dev] [Bug 96408] [PERF] SSO: dirty all stages when only one is updated. Trigger extra validations.

2016-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96408 gregory.hain...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

2016-07-30 Thread Roland Scheidegger
This looks very bogus to me. How is this supposed to work if you immediately close the library again? The functions are still going to get used. This just segfaults right, left and center. If you want to fix this for real, some util_format_s3tc_exit() is probably needed, albeit I'm not entirely

[Mesa-dev] [PATCH] u_vbuf: fix potentially bogus assert

2016-07-30 Thread Rob Clark
There are cases where we hit u_vbuf path due to alignment or pitch- alignment restrictions, but for an output-format that u_vbuf does not support translating (yet the driver does support natively). In which case we hit the memcpy() path and don't care that u_vbuf doesn't understand it. Fixes

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

2016-07-30 Thread Marek Olšák
Pushed, thanks. Marek On Sat, Jul 30, 2016 at 2:35 AM, Eric Engestrom wrote: > CovID: 401540 > Signed-off-by: Eric Engestrom > --- > src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[Mesa-dev] [PATCH 2/3] ddebug: print the command line to all logs

2016-07-30 Thread Marek Olšák
From: Marek Olšák for piglit with the pipelined hang detection mode --- src/gallium/drivers/ddebug/dd_draw.c | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/ddebug/dd_draw.c b/src/gallium/drivers/ddebug/dd_draw.c index d3c4e7f..716208a 100644

[Mesa-dev] [PATCH 3/3] radeonsi: print the command line to VM fault reports

2016-07-30 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_debug.c b/src/gallium/drivers/radeonsi/si_debug.c index e030f48..00a3b13 100644 ---

[Mesa-dev] [PATCH 1/3] gallium/os: add os_get_process_cmd_line

2016-07-30 Thread Marek Olšák
From: Marek Olšák for debugging --- src/gallium/auxiliary/os/os_process.c | 37 +++ src/gallium/auxiliary/os/os_process.h | 2 ++ 2 files changed, 39 insertions(+) diff --git a/src/gallium/auxiliary/os/os_process.c

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2016-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #41 from kilobug --- (In reply to Kai from comment #40) > Shouldn't this bug be closed as "NOTOURBUG", since it's clearly a game bug? > Or at least as "WONTFIX", since the hack is probably never going to land in

Re: [Mesa-dev] virglrenderer regression in commit ad4f0f1941677c

2016-07-30 Thread Rob Clark
On Fri, Jul 29, 2016 at 3:57 PM, Rob Herring wrote: > Hi, > > This commit in virglrenderer causes a regression in Android for me. > The parameters that get passed in are last_level = 8, width = 1. I'm > not really sure if this is valid (I'm guessing there should be some > min

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2016-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #40 from Kai --- Shouldn't this bug be closed as "NOTOURBUG", since it's clearly a game bug? Or at least as "WONTFIX", since the hack is probably never going to land in Mesa anyway? On a different note:

Re: [Mesa-dev] [PATCH v2 10/27] i965/blorp: Set up HiZ surfaces up-front

2016-07-30 Thread Jason Ekstrand
On Jul 30, 2016 2:01 AM, "Pohjolainen, Topi" wrote: > > On Fri, Jul 29, 2016 at 06:59:44AM -0700, Jason Ekstrand wrote: > >On Jul 29, 2016 2:26 AM, "Pohjolainen, Topi" > ><[1]topi.pohjolai...@intel.com> wrote: > >> > >> On Tue, Jul 26, 2016 at

[Mesa-dev] [Bug 97145] include/GL/*.h not installed when GLX is disabled (eg for OSMesa)

2016-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97145 Bug ID: 97145 Summary: include/GL/*.h not installed when GLX is disabled (eg for OSMesa) Product: Mesa Version: git Hardware: All OS: All

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2016-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #39 from kilobug --- (In reply to Iaroslav Andrusyak from comment #38) > > Did I miss something ? > > allow_glsl_extension_directive_midshader=true ? Thanks, that was it ! Here is how I can run the game :

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2016-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #38 from Iaroslav Andrusyak --- > Did I miss something ? allow_glsl_extension_directive_midshader=true ? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2016-07-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #37 from kilobug --- (In reply to Thomas J. Moore from comment #32) > Created attachment 125302 [details] > Simple LD_PRELOAD shim to apply necessary patches for divos > > Game works great for me with the above

Re: [Mesa-dev] [PATCH] gallium/util: fix align64

2016-07-30 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 07/30/2016 07:22 AM, Marek Olšák wrote: > From: Marek Olšák > > it cut off the upper 32 bits > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/gallium/auxiliary/util/u_math.h | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH] docs: Add GL4.4 and ARB_enhanced_layouts to the release notes

2016-07-30 Thread Edward O'Callaghan
On 07/30/2016 10:25 AM, Timothy Arceri wrote: > --- > Not sure is we need to be more careful about mentioning we support 4.4 > thoughts? s/is/if/ Well in fact, any reason why we can't actually claim 4.5 support now? The raw base requirements seem to be fulfilled at least. Reviewed-by: Edward

Re: [Mesa-dev] [PATCH mesa] gallium/util: fix resource leak

2016-07-30 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 07/30/2016 10:35 AM, Eric Engestrom wrote: > CovID: 401540 > Signed-off-by: Eric Engestrom > --- > src/gallium/auxiliary/util/u_format_s3tc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[Mesa-dev] [PATCH 3/3] freedreno/a4xx: fix comparison out of range warnings

2016-07-30 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a4xx/fd4_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/freedreno/a4xx/fd4_screen.c b/src/gallium/drivers/freedreno/a4xx/fd4_screen.c

[Mesa-dev] [PATCH 2/3] freedreno/a3xx: fix comparison out of range warnings

2016-07-30 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a3xx/fd3_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/freedreno/a3xx/fd3_screen.c b/src/gallium/drivers/freedreno/a3xx/fd3_screen.c

[Mesa-dev] [PATCH 1/3] freedreno/a2xx: fix comparison out of range warnings

2016-07-30 Thread Francesco Ansanelli
Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/a2xx/fd2_screen.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_screen.c b/src/gallium/drivers/freedreno/a2xx/fd2_screen.c index

Re: [Mesa-dev] [PATCH v2 08/27] i965/blorp: Stop using the miptree in state setup for tex/rt surfaces

2016-07-30 Thread Pohjolainen, Topi
On Fri, Jul 29, 2016 at 09:34:11AM -0700, Jason Ekstrand wrote: >On Jul 29, 2016 9:09 AM, "Jason Ekstrand" <[1]ja...@jlekstrand.net> >wrote: >> >> On Jul 29, 2016 1:47 AM, "Pohjolainen, Topi" ><[2]topi.pohjolai...@intel.com> wrote: >> > >> > On Thu, Jul 28, 2016 at

Re: [Mesa-dev] [PATCH v2 10/27] i965/blorp: Set up HiZ surfaces up-front

2016-07-30 Thread Pohjolainen, Topi
On Fri, Jul 29, 2016 at 06:59:44AM -0700, Jason Ekstrand wrote: >On Jul 29, 2016 2:26 AM, "Pohjolainen, Topi" ><[1]topi.pohjolai...@intel.com> wrote: >> >> On Tue, Jul 26, 2016 at 03:11:14PM -0700, Jason Ekstrand wrote: >> > --- >> > src/mesa/drivers/dri/i965/brw_blorp.c

[Mesa-dev] [PATCH 3/3] glsl: be more strict on block qualifiers

2016-07-30 Thread Timothy Arceri
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96528 --- src/compiler/glsl/ast_to_hir.cpp | 61 1 file changed, 50 insertions(+), 11 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index

[Mesa-dev] [PATCH 2/3] glsl: add name param to validate_flags()

2016-07-30 Thread Timothy Arceri
--- src/compiler/glsl/ast.h | 4 ++-- src/compiler/glsl/ast_to_hir.cpp | 7 +++ src/compiler/glsl/ast_type.cpp | 8 3 files changed, 9 insertions(+), 10 deletions(-) diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h index aa8c422..157895d 100644 ---

[Mesa-dev] [PATCH V2 1/3] glsl: add component to ast_type_qualifier::validate_flags

2016-07-30 Thread Timothy Arceri
This was added with ARB_enhanced_layouts. V2: Add an extra format specifier for the new qualifier. --- src/compiler/glsl/ast_type.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/glsl/ast_type.cpp b/src/compiler/glsl/ast_type.cpp index d34d641..1f8fb9c

[Mesa-dev] [PATCH] freedreno/ir3: init ir3_shader_key with memset()

2016-07-30 Thread Francesco Ansanelli
To silence missing initializers warning Signed-off-by: Francesco Ansanelli --- src/gallium/drivers/freedreno/ir3/ir3_shader.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/ir3/ir3_shader.c