[Mesa-dev] [Bug 97307] glsl/glcpp/tests/glcpp-test regression

https://bugs.freedesktop.org/show_bug.cgi?id=97307 Kenneth Graunke changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] glcpp: Update tests for new #undef of built-in macro rules.

On Sunday, August 14, 2016 9:07:59 PM PDT Kenneth Graunke wrote: > Ian recently changed the preprocessor to allow this in most GLSL > versions, but not GLSL ES 3.00+. This patch converts the existing > test that expects a failure to a #version 300 es shader, and adds > a #version 110 shader to

Re: [Mesa-dev] [PATCH] i965: Drop assertion about buffer offset at draw time.

On Monday, August 15, 2016 9:01:06 AM PDT Eric Anholt wrote: > Given robust access, we should just be returning zeroes if the user gives > us a base pointer that's too big, which is what was happens on a release > build. This was caught by a webgl conformance test for out-of-bounds > draws on

Re: [Mesa-dev] [PATCH] anv: fix writemask on blit fragment shader.

On Tuesday, August 16, 2016 10:01:47 AM PDT Dave Airlie wrote: > From: Dave Airlie > > I'm not sure if anything even uses this, but I found this on radv, so > just fix it on anv for consistency. > > Signed-off-by: Dave Airlie > --- >

Re: [Mesa-dev] [PATCH 2/4] i965: Turn not.nz x into cmp.z x,0.

On Monday, August 15, 2016 2:24:30 PM PDT Matt Turner wrote: > This allow conditional mod propagation to handle it. > > HSW: > >total instructions in shared programs: 8270006 -> 8269855 (-0.00%) >instructions in affected programs: 41552 -> 41401 (-0.36%) >helped: 136 > >total

Re: [Mesa-dev] [PATCH 3/6] gallium/u_blitter: split out a helper for common clear state

On Mon, Aug 15, 2016 at 10:44 AM, Marek Olšák wrote: > On Sat, Aug 13, 2016 at 8:57 PM, Rob Clark wrote: >> On Sat, Aug 13, 2016 at 2:23 PM, Rob Clark wrote: >>> Signed-off-by: Rob Clark >>> --- >>>

Re: [Mesa-dev] Mesa stopped passing make check on August 10th: FAIL: glsl/glcpp/tests/glcpp-test

On 16/08/16 08:42 AM, dar...@chaosreigns.com wrote: > Looks to me like src/compiler/glsl/glcpp/tests/120-undef-builtin.c.expected > just needs to be updated. > > > make check output includes: > > > Testsuite summary

Re: [Mesa-dev] [PATCH] anv: fix writemask on blit fragment shader.

Drp... Thanks! Cc: "12.0" Reviewed-by: Jason Ekstrand On Mon, Aug 15, 2016 at 5:01 PM, Dave Airlie wrote: > From: Dave Airlie > > I'm not sure if anything even uses this, but I found this on

[Mesa-dev] [PATCH] anv: fix writemask on blit fragment shader.

From: Dave Airlie I'm not sure if anything even uses this, but I found this on radv, so just fix it on anv for consistency. Signed-off-by: Dave Airlie --- src/intel/vulkan/anv_meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] Mesa stopped passing make check on August 10th: FAIL: glsl/glcpp/tests/glcpp-test

Looks to me like src/compiler/glsl/glcpp/tests/120-undef-builtin.c.expected just needs to be updated. make check output includes: Testsuite summary for Mesa 12.1.0-devel

Re: [Mesa-dev] [PATCH 1/3] gallium: change pipe_sampler_view::first_element/last_element -> offset/size

Am 15.08.2016 um 19:48 schrieb Marek Olšák: > On Sun, Aug 14, 2016 at 11:38 AM, Marek Olšák wrote: >> On Aug 12, 2016 8:49 PM, "Roland Scheidegger" wrote: >>> >>> I can't say I'm a big fan of this. >>> From an "api cleanness" point of view, defining things

Re: [Mesa-dev] [PATCH] glcpp: Update tests for new #undef of built-in macro rules.

On Sun, Aug 14, 2016 at 9:07 PM, Kenneth Graunke wrote: > Ian recently changed the preprocessor to allow this in most GLSL > versions, but not GLSL ES 3.00+. This patch converts the existing > test that expects a failure to a #version 300 es shader, and adds > a #version

Re: [Mesa-dev] [PATCH] svga: remove incorrect buffer invalidation code

Reviewed-by: Charmaine Lee From: Brian Paul Sent: Monday, August 15, 2016 3:43:22 PM To: mesa-dev@lists.freedesktop.org Cc: Charmaine Lee Subject: [PATCH] svga: remove incorrect buffer invalidation code Fixes

[Mesa-dev] [PATCH] egl: reset 'ViewportInitialized' when unbinding current context

'ViewportInitialized' flag in gl_context has to be reset to '0' when the current context is unbound via a eglMakeCurrent call with all of 'NULL' resources (surfaces and context). This is to make sure the viewport of the context is re-initialized when the same context is bound to new read and draw

[Mesa-dev] [PATCH] svga: remove incorrect buffer invalidation code

Fixes regression with team_fortress_2 trace. This change has been in our in-house tree for some time. --- src/gallium/drivers/svga/svga_screen_cache.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/svga/svga_screen_cache.c

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

A new patch, "[PATCH] egl/dri2: remove error checks on return values from mtx_lock and cnd_wait" containing additional clean-up has been submitted. Please disregard this one. On Thu, Jul 28, 2016 at 02:38:35PM -0700, Dongwon Kim wrote: > This removes unnecessary error checks on return result

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Emil, I just submitted a new patch "[PATCH] egl/dri2: remove error checks on return values from mtx_lock and cnd_wait" that replaces the old one. Please review the new one and disregard the original one, "egl/dri2: Do not need to check return value from mtx_lock". On Mon, Aug 15, 2016 at

[Mesa-dev] [PATCH] egl/dri2: remove error checks on return values from mtx_lock and cnd_wait

This removes unnecessary error checks on return result of mtx_lock and cnd_wait calls as in all other places in MESA source since there is no chance that any of these functions return any of error codes in current implementation. This patch also removes a redundent _eglError call that follows

[Mesa-dev] [PATCH 3/4] gallium: remove unused u_clear.h file

--- src/gallium/auxiliary/Makefile.sources | 1 - src/gallium/auxiliary/util/u_clear.h | 64 -- 2 files changed, 65 deletions(-) delete mode 100644 src/gallium/auxiliary/util/u_clear.h diff --git a/src/gallium/auxiliary/Makefile.sources

[Mesa-dev] [PATCH 4/4] st/mesa: use pipe var instead of st->pipe in st_create_context_priv()

As is done in most other places in the function. --- src/mesa/state_tracker/st_context.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 687ca19..ddc11a4 100644 ---

[Mesa-dev] [PATCH 1/4] gallium/util: minor reformatting in u_box.h

--- src/gallium/auxiliary/util/u_box.h | 42 -- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/src/gallium/auxiliary/util/u_box.h b/src/gallium/auxiliary/util/u_box.h index 00f231d..eb41f8a 100644 --- a/src/gallium/auxiliary/util/u_box.h +++

[Mesa-dev] [PATCH 2/4] gallium/i915: inline the util_clear() code into i915_clear_blitter()

This is the only place the util_clear() function was used. --- src/gallium/drivers/i915/i915_clear.c | 24 +--- 1 file changed, 21 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/i915/i915_clear.c b/src/gallium/drivers/i915/i915_clear.c index 57244a6..a1af789

[Mesa-dev] [PATCH 1/2] st/va: enable dual instances encode by sync surface

This patch improves the performance of Vaapi Encode by enabling dual instances encoding. flush function is not called after each end_frame call. radeon/vce will do flush whenever 2 frames are submitted for encoding. Implement sync surface function to flush only if the frame hasn't been flushed

[Mesa-dev] [PATCH 2/2] radeon/vce: set flag based on dual instance enablement

Set the flag on when dual instance encoding is supported, otherwise set it to off Signed-off-by: Boyuan Zhang --- src/gallium/drivers/radeon/radeon_vce_52.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Yes, you are right. It is duplicate EGL_FALSE check and _eglError call in the end of the function.. Also, I don't see any good reason to check return value of cnd_wait (though we still need to check it in timedwait case.). I will prepare a new patch with all of these taken into acocunt. On Mon,

Re: [Mesa-dev] [PATCH 1/2] llvmpipe: fix depth clamping wrt reversed near/far values

On 15/08/16 04:41, srol...@vmware.com wrote: From: Roland Scheidegger This wasn't handled before (the result was that no matter what value got clamped, it always ended up as the near value in this case) (if clamping actually happened). Fix this by using the util helper for

Re: [Mesa-dev] [PATCH 3/3] i965/fs: Estimate maximum sampler message execution size more accurately.

Kenneth Graunke writes: > On Friday, August 12, 2016 10:06:29 PM PDT Francisco Jerez wrote: >> The current logic used to determine the execution size of sampler >> messages was based on special-casing several argument and opcode >> combinations, which unsurprisingly missed

Re: [Mesa-dev] [PATCH] egl/x11: avoid using freed memory if dri2 init fails

On Mon, Aug 15, 2016 at 11:33 AM, ⚛ <0xe2.0x9a.0...@gmail.com> wrote: > On Mon, Aug 15, 2016 at 8:08 PM, Emil Velikov > wrote: >> >> On 4 August 2016 at 03:13, Nicolas Boichat wrote: >> > Thanks! See also related series here, which fixes the

Re: [Mesa-dev] [PATCH] egl/x11: avoid using freed memory if dri2 init fails

On Mon, Aug 15, 2016 at 8:08 PM, Emil Velikov wrote: > > On 4 August 2016 at 03:13, Nicolas Boichat wrote: > > Thanks! See also related series here, which fixes the other platforms: > >

Re: [Mesa-dev] [PATCH] egl/x11: avoid using freed memory if dri2 init fails

On 4 August 2016 at 03:13, Nicolas Boichat wrote: > Thanks! See also related series here, which fixes the other platforms: > https://lists.freedesktop.org/archives/mesa-dev/2016-August/125147.html > > On Sun, Jul 31, 2016 at 9:44 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com>

Re: [Mesa-dev] [PATCH 1/3] gallium: change pipe_sampler_view::first_element/last_element -> offset/size

On Sun, Aug 14, 2016 at 11:38 AM, Marek Olšák wrote: > On Aug 12, 2016 8:49 PM, "Roland Scheidegger" wrote: >> >> I can't say I'm a big fan of this. >> From an "api cleanness" point of view, defining things in elements makes >> more sense imho. >> This is

Re: [Mesa-dev] [PATCH 1/2] aubinator: Add a new tool called Aubinator to the src/intel/tools folder.

Thanks Emil/Jason/Ken/Matt/Kristian... for your time and review comments. Noted all the suggestions and I'll send out the updated patches soon. -Sirisha -Original Message- From: Emil Velikov [mailto:emil.l.veli...@gmail.com] Sent: Monday, August 15, 2016 5:41 AM To: Gandikota, Sirisha

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

Hi Nicolas, On 4 August 2016 at 02:51, Nicolas Boichat wrote: > On Thu, Aug 4, 2016 at 9:38 AM, Michel Dänzer wrote: >> On 04.08.2016 09:53, Nicolas Boichat wrote: >>> On Thu, Aug 4, 2016 at 12:22 AM, Martin Peres >>>

Re: [Mesa-dev] [PATCH 00/32] i965/blorp: Use genxml for state setup

On Sun, Aug 14, 2016 at 11:53 PM, Kenneth Graunke wrote: > On Thursday, August 11, 2016 2:14:57 PM PDT Jason Ekstrand wrote: > > This patch series is the next on the way towards generalizing blorp for > > usin in Vulkan. At this point, I'd say the project is about 80% >

Re: [Mesa-dev] [PATCH] anv/x11: Add support for Xlib platform

On Mon, Aug 15, 2016 at 4:05 AM, Emil Velikov wrote: > On 11 August 2016 at 23:26, Kevin Strasser > wrote: > > Some applications continue to use the Xlib client library and expect that > > VK_KHR_xlib_surface will be available in the driver.

Re: [Mesa-dev] [PATCH 25/32] i965: Move gen6_blorp.c to a file that gets recompiled per-gen

On Mon, Aug 15, 2016 at 5:58 AM, Emil Velikov wrote: > Hi Jason, > > On 11 August 2016 at 22:15, Jason Ekstrand wrote: > > At the moment, it's only used for gen6 but that will change soon. We use > > the genX prefix for recompiled things in the

[Mesa-dev] [PATCH] i965: Drop assertion about buffer offset at draw time.

Given robust access, we should just be returning zeroes if the user gives us a base pointer that's too big, which is what was happens on a release build. This was caught by a webgl conformance test for out-of-bounds draws on servo. --- src/mesa/drivers/dri/i965/brw_draw_upload.c | 11 ---

Re: [Mesa-dev] [PATCH v2 2/2] i915: remove unnecessary `if`

On Mon, Aug 15, 2016 at 03:51:21PM +0100, Eric Engestrom wrote: > if (x) return true; else return false; > can be simplified as: > return x; > since `x` is already a boolean expression. > > Signed-off-by: Eric Engestrom Both Reviewed-by: Chris Wilson

[Mesa-dev] [PATCH v2 1/2] i965: remove unnecessary `if`

if (x) return true; else return false; can be simplified as: return x; since both `x` are already boolean expressions. Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_screen.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[Mesa-dev] [PATCH v2 2/2] i915: remove unnecessary `if`

if (x) return true; else return false; can be simplified as: return x; since `x` is already a boolean expression. Signed-off-by: Eric Engestrom --- v2: replace `x == 0` with `!x` for consistency. src/mesa/drivers/dri/i915/intel_screen.c | 4 +--- 1

Re: [Mesa-dev] [PATCH 3/6] gallium/u_blitter: split out a helper for common clear state

On Sat, Aug 13, 2016 at 8:57 PM, Rob Clark wrote: > On Sat, Aug 13, 2016 at 2:23 PM, Rob Clark wrote: >> Signed-off-by: Rob Clark >> --- >> src/gallium/auxiliary/util/u_blitter.c | 38 >> ++ >>

Re: [Mesa-dev] [PATCH 1/2] i965: remove unnecessary `if`

On Mon, Aug 15, 2016 at 03:16:12PM +0100, Eric Engestrom wrote: > if (x) return true; else return false; > can be simplified as: > return x; > since both `x` are already boolean expressions. > > Signed-off-by: Eric Engestrom > --- >

[Mesa-dev] [PATCH 1/2] i965: remove unnecessary `if`

if (x) return true; else return false; can be simplified as: return x; since both `x` are already boolean expressions. Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/i965/intel_screen.c | 8 ++-- 1 file changed, 2 insertions(+), 6

Re: [Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.

On Mon, Aug 15, 2016 at 08:48:56PM +0800, Chuanbo Weng wrote: > The offset should not always be 0. For example, if EGLImage is > created from a 2D texture with EGL_GL_TEXTURE_LEVEL=1, then the > offset should be the actual start of miplevel 1 in drm bo. > > Signed-off-by: Chuanbo Weng

Re: [Mesa-dev] [PATCH] egl/dri2: Do not need to check return value from mtx_lock

Hi Kim, On 28 July 2016 at 22:38, Dongwon Kim wrote: > This removes unnecessary error checks on return result of mtx_lock > calls as in all other places in MESA source since there is no chance > that mtx_lock returns any of error codes in current implementation. > >

Re: [Mesa-dev] [PATCH 25/32] i965: Move gen6_blorp.c to a file that gets recompiled per-gen

Hi Jason, On 11 August 2016 at 22:15, Jason Ekstrand wrote: > At the moment, it's only used for gen6 but that will change soon. We use > the genX prefix for recompiled things in the Vulkan driver. It isn't > great, but it seems to have worked ok. Speaking of genX and

[Mesa-dev] [PATCH] Return corresponding offset of EGLImage instead of 0.

The offset should not always be 0. For example, if EGLImage is created from a 2D texture with EGL_GL_TEXTURE_LEVEL=1, then the offset should be the actual start of miplevel 1 in drm bo. Signed-off-by: Chuanbo Weng --- include/GL/internal/dri_interface.h | 2 ++

Re: [Mesa-dev] [PATCH 1/2] aubinator: Add a new tool called Aubinator to the src/intel/tools folder.

Hi Sirisha, A few misc suggestions all over on top of Matt's input. Please don't read too much into them ;-) On 10 August 2016 at 00:52, Sirisha Gandikota wrote: > From: Kristian Høgsberg Kristensen > > The Aubinator tool is designed to help the

Re: [Mesa-dev] [PATCH] anv/x11: Add support for Xlib platform

On 11 August 2016 at 23:26, Kevin Strasser wrote: > Some applications continue to use the Xlib client library and expect that > VK_KHR_xlib_surface will be available in the driver. Service these > applications by converting the Display pointer to xcb_connection_t and use

[Mesa-dev] [Bug 97291] Incorrect packing of struct

https://bugs.freedesktop.org/show_bug.cgi?id=97291 --- Comment #5 from Michel Dänzer --- (In reply to Matias N. Goldberg from comment #4) > [...] I don't have compute shaders. Googling around it appears for > Southern Island radeon it could be buggy so it was turned off. No,

[Mesa-dev] [Bug 97285] Darkness in Dota 2 after Patch "Make Gallium's BlitFramebuffer follow the GL 4.4 sRGB rules"

https://bugs.freedesktop.org/show_bug.cgi?id=97285 --- Comment #16 from Dmytro Zverev --- Sorry. Waiting for fix in master branch. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 00/32] i965/blorp: Use genxml for state setup

On Thursday, August 11, 2016 2:14:57 PM PDT Jason Ekstrand wrote: > This patch series is the next on the way towards generalizing blorp for > usin in Vulkan. At this point, I'd say the project is about 80% complete. > This series only applies on top of the last two blorp isl series which are >