Re: [Mesa-dev] [PATCH 09/23] glsl: Convert constant_expression to the util hash table

On Sat, 2016-09-10 at 13:19 +0200, Thomas Helland wrote: > 2016-09-09 0:20 GMT+02:00 Thomas Helland : > > > > 2016-08-16 22:10 GMT+02:00 Thomas Helland > m>: > > > > > > Signed-off-by: Thomas Helland > > > --- > >

Re: [Mesa-dev] [PATCH] st/clover: Define __OPENCL_VERSION__ on the device side

Niels Ole Salscheider writes: > On Wednesday, 31 August 2016, 15:53:05 CEST, Serge Martin wrote: >> On Wednesday 31 August 2016 12:39:23 Vedran Miletić wrote: >> > On 08/28/2016 04:42 PM, Niels Ole Salscheider wrote: >> > > This is required by the OpenCL

[Mesa-dev] [PATCH 1/2] i965: check for GL_TEXTURE_EXTERNAL_OES at miptree_create_for_teximage

Forgotten on commit "i965: Fix calculation of the image height at start level". Thanks to Ilia Mirkin for point it. Fixes the following regressions on Haswell and Broadwell: ES2-CTS.gtf.GL2ExtensionTests.egl_image_external.TestSimpleUnassociated (crash back to pass)

[Mesa-dev] [PATCH 2/2] i965: remove unused variable at intel_miptree_create_for_teximage

After commit "i965: Fix calculation of the image height at start level", it is not needed. This commit removes the "warning: unused variable ‘i’" warning. --- src/mesa/drivers/dri/i965/intel_tex_image.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_image.c

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

Alejandro Piñeiro writes: > On 09/09/16 07:33, Francisco Jerez wrote: >> Alejandro Piñeiro writes: >> >>> On 02/09/16 23:13, Kenneth Graunke wrote: On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: > This fixes a numerical

Re: [Mesa-dev] [PATCH] mesa: Implement ARB_shader_viewport_layer_array for i965

I like the easy way out in this case. Thanks for the pointer. On Fri, Sep 9, 2016, at 18:03, Ilia Mirkin wrote: > On Fri, Sep 9, 2016 at 8:59 PM, Dylan Baker wrote: > >> Some piglit tests to check the TES behaviour would be nice. > > > > Yeah, I figured. I'll have to go read

Re: [Mesa-dev] [PATCH v2 1/2] gm107/ir: AL2P writes to a predicate register

This series is: Reviewed-by: Samuel Pitoiset On 09/10/2016 06:58 PM, Ilia Mirkin wrote: We have to force it to write to predicate 7 (aka PT) in order for it not to mess up another predicate. Unclear what would be returned in the predicate, perhaps an error code for

[Mesa-dev] [PATCH v2 2/2] gm107/ir: allow indirect inputs to be loaded by frag shader

Looks like the GM107 IPA op does not allow a separate offset when using an indirect register. Instead we must use AL2P like we do for indirect vertex operations on Kepler+. Signed-off-by: Ilia Mirkin --- v1 -> v2: Use AL2P instead of an ADD. Also do this in a pre-SSA stage

[Mesa-dev] [PATCH v2 1/2] gm107/ir: AL2P writes to a predicate register

We have to force it to write to predicate 7 (aka PT) in order for it not to mess up another predicate. Unclear what would be returned in the predicate, perhaps an error code for out-of-bounds requests. Blob doesn't seem to check it. Signed-off-by: Ilia Mirkin Cc:

Re: [Mesa-dev] [PATCH v4] i965: Fix calculation of the image height at start level

This patch regresses es2-cts.gtf.gl2extensiontests.egl_image_external.testsimpleunassociated https://bugs.freedesktop.org/show_bug.cgi?id=97761 Antia Puentes writes: > - Fixes CTS tests: > > * GL44-CTS.shader_image_size.advanced-nonMS-cs-float > *

Re: [Mesa-dev] [PATCH] glsl: Make blend_colordodge compare against 1.0 - FLT_EPSILON.

On 09/09/16 07:33, Francisco Jerez wrote: > Alejandro Piñeiro writes: > >> On 02/09/16 23:13, Kenneth Graunke wrote: >>> On Friday, August 26, 2016 10:49:18 PM PDT Kenneth Graunke wrote: This fixes a numerical precision issue that was causing two CTS failures:

[Mesa-dev] [PATCH v2] tgsi: document semantics for compute shaders

Cc: Nicolai Hähnle Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/tgsi.rst | 28 1 file changed, 28 insertions(+) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index

Re: [Mesa-dev] [PATCH] tgsi: document semantics for compute shaders

On 09/10/2016 05:01 PM, Ilia Mirkin wrote: On Sat, Sep 10, 2016 at 10:05 AM, Samuel Pitoiset wrote: Cc: Nicolai Hähnle Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/tgsi.rst | 26

Re: [Mesa-dev] [PATCH] tgsi: document semantics for compute shaders

On Sat, Sep 10, 2016 at 10:05 AM, Samuel Pitoiset wrote: > Cc: Nicolai Hähnle > Signed-off-by: Samuel Pitoiset > --- > src/gallium/docs/source/tgsi.rst | 26 ++ > 1 file changed, 26

[Mesa-dev] [PATCH] tgsi: document semantics for compute shaders

Cc: Nicolai Hähnle Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/tgsi.rst | 26 ++ 1 file changed, 26 insertions(+) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index

Re: [Mesa-dev] [PATCH 3/7] mesa/st: support lowering multi-planar YUV

Am 09.09.2016 um 02:58 schrieb Rob Clark: > On Thu, Sep 8, 2016 at 8:28 PM, Roland Scheidegger wrote: >> Am 09.09.2016 um 02:19 schrieb Rob Clark: >>> On Thu, Sep 8, 2016 at 7:54 PM, Rob Clark wrote: On Thu, Sep 8, 2016 at 6:41 PM, Roland Scheidegger

[Mesa-dev] [PATCH 23/23] mesa/glsl: Move string_to_uint_map into the util folder

This clears the last bits of the usecases of the hash table located in mesa/program, allowing us to remove it. V2: Rebase on top of changes to Makefile.sources Signed-off-by: Thomas Helland --- src/compiler/glsl/link_uniform_initializers.cpp| 2 +-

Re: [Mesa-dev] [PATCH 07/11] glsl: add gl_LocalGroupSizeARB as a system value

On 09/09/2016 08:50 PM, Ilia Mirkin wrote: On Thu, Sep 8, 2016 at 4:31 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/builtin_variables.cpp | 2 ++ src/compiler/shader_enums.h | 1 + 2 files

Re: [Mesa-dev] [PATCH 05/11] glsl: reject compute shaders with fixed and variable local size

On 09/09/2016 08:46 PM, Ian Romanick wrote: On 09/08/2016 01:31 PM, Samuel Pitoiset wrote: The ARB_compute_variable_group_size specification explains that when a compute shader includes both a fixed and a variable local size, a compile-time error occurs. I probably would have squashed this

Re: [Mesa-dev] [PATCH 01/11] glapi: add entry points for GL_ARB_compute_variable_group_size

On 09/09/2016 08:22 PM, Ian Romanick wrote: On 09/09/2016 08:46 AM, Samuel Pitoiset wrote: On 09/08/2016 10:58 PM, Ian Romanick wrote: On 09/08/2016 01:31 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH] glsl: Convert constant_expression to the util hash table

V2: Fix incorrect argument ordering on hash table insert Signed-off-by: Thomas Helland --- src/compiler/glsl/ir_constant_expression.cpp | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 09/23] glsl: Convert constant_expression to the util hash table

2016-09-09 0:20 GMT+02:00 Thomas Helland : > 2016-08-16 22:10 GMT+02:00 Thomas Helland : >> Signed-off-by: Thomas Helland >> --- >> src/compiler/glsl/ir_constant_expression.cpp | 24 +--- >> 1

Re: [Mesa-dev] [PATCH 00/12] radeon/winsyses: various cleanups

On 09.09.2016 23:26, Marek Olšák wrote: On Fri, Sep 9, 2016 at 7:34 PM, Nicolai Hähnle wrote: Hi, this is a bunch of random cleanups in and related to radeon and amdgpu winsyses. There is one significant behavioral change, which is that amdgpu now only keeps a single

Re: [Mesa-dev] [PATCH] radeonsi: don't preload constants at the beginning of shaders

On 10.09.2016 00:40, Marek Olšák wrote: From: Marek Olšák LLVM can CSE the loads, thus we can always re-load constants before each use. The decrease in SGPR spilling is huge. The best improvements are the dumbest ones. Indeed :) Reviewed-by: Nicolai Hähnle

Re: [Mesa-dev] [PATCH] st/clover: Define __OPENCL_VERSION__ on the device side

On Wednesday, 31 August 2016, 15:53:05 CEST, Serge Martin wrote: > On Wednesday 31 August 2016 12:39:23 Vedran Miletić wrote: > > On 08/28/2016 04:42 PM, Niels Ole Salscheider wrote: > > > This is required by the OpenCL standard. > > > > > > Signed-off-by: Niels Ole Salscheider