Re: [Mesa-dev] [PATCH v2 2/3] egl: return corresponding offset of EGLImage instead of 0.

From functionality's perspective, version check is not necessary. And I think the queryImage returns false if attribute is unsupported, so I prefer to not use version Check. Thanks, Chuanbo Weng -Original Message- From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf

Re: [Mesa-dev] [PATCH 01/20] gallium/radeon: derive buffer placement and flags only at initialization

On 12/09/16 10:15 AM, Michel Dänzer wrote: > On 30/08/16 12:28 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> Invalidated buffers don't have to go through it. >> >> Split r600_init_resource into r600_init_resource_fields and >> r600_alloc_resource. > > This change caused

Re: [Mesa-dev] Check about recent changes in amdgpu

On 10 September 2016 at 09:30, Mauro Rossi wrote: > Hi Dave, > > while checking mesa-dev with android build, > I'm porting the necessary changes to to have amd/addrlib in Android build, > > but I have also encountered a building error related to commit >

Re: [Mesa-dev] [PATCH 01/20] gallium/radeon: derive buffer placement and flags only at initialization

On 30/08/16 12:28 AM, Marek Olšák wrote: > From: Marek Olšák > > Invalidated buffers don't have to go through it. > > Split r600_init_resource into r600_init_resource_fields and > r600_alloc_resource. This change caused Portal 2 to crash for me (with Kaveri using the

Re: [Mesa-dev] [PATCH 09/23] glsl: Convert constant_expression to the util hash table

On Sun, 2016-09-11 at 15:31 +0200, Thomas Helland wrote: > 2016-09-11 6:27 GMT+02:00 Timothy Arceri m>: > > > > On Sat, 2016-09-10 at 13:19 +0200, Thomas Helland wrote: > > > > > > 2016-09-09 0:20 GMT+02:00 Thomas Helland > > om>: > > > >

Re: [Mesa-dev] [PATCH 3/3] aubinator: only use program_invocation_short_name with glibc/cygwin

On Thu, 2016-09-08 at 18:39 +0100, Emil Velikov wrote: > On 1 September 2016 at 18:12, Jonathan Gray wrote: > > > > program_invocation_short_name is a gnu extension.  Limit use of it > > to glibc and cygwin and otherwise use getprogname() which is > > available > > on BSD and OS

[Mesa-dev] [PATCH] egl: fix gcc warning braces around scalar initializer

--- src/egl/main/eglcurrent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/egl/main/eglcurrent.c b/src/egl/main/eglcurrent.c index 345f4cc..2a225bc 100644 --- a/src/egl/main/eglcurrent.c +++ b/src/egl/main/eglcurrent.c @@ -38,7 +38,7 @@ /* This should be kept in sync

Re: [Mesa-dev] [PATCH] spirv/nir: Add support for OpAtomicLoad/Store

On Wed, 2016-09-07 at 19:28 +0100, Lionel Landwerlin wrote: > Hi Mark, > > Thanks for the report. > The assumption is that coord will be set on the image by a preceding > SpvOpImageTexelPointer opcode (see top of the > vtn_handle_image function). I don't see how that can be right. The image

Re: [Mesa-dev] [PATCH 2/2] i965: remove unused variable at intel_miptree_create_for_teximage

This patch is: Reviewed-by: Timothy Arceri On Sun, 2016-09-11 at 00:07 +0200, Alejandro Piñeiro wrote: > After commit "i965: Fix calculation of the image height at start > level", it is > not needed. This commit removes the "warning: unused variable ‘i’" > warning.

[Mesa-dev] [PATCH v2 10/14] st/mesa: add support for dispatching a variable local size

Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_cb_compute.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_compute.c

[Mesa-dev] [PATCH v2 12/14] nv50/ir: use 1024 threads/block for variable local size

When a variable local size is defined as specified by ARB_compute_variable_group_size, the fixed local size is set to 0 and a SIGFPE occurs when we compute the maximum number of regs. Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v2 08/14] gallium: add PIPE_COMPUTE_CAP_MAX_VARIABLE_THREADS_PER_BLOCK

Signed-off-by: Samuel Pitoiset --- src/gallium/docs/source/screen.rst | 4 src/gallium/drivers/ilo/ilo_screen.c | 2 ++ src/gallium/drivers/nouveau/nv50/nv50_screen.c | 2 ++ src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 2 ++

[Mesa-dev] [PATCH v2 11/14] st/mesa: expose ARB_compute_variable_group_size

This extension is only exposed if the underlying driver supports ARB_compute_shader and if PIPE_COMPUTE_MAX_VARIABLE_THREADS_PER_BLOCK is set. v2: - expose the ext based on that new cap Signed-off-by: Samuel Pitoiset --- src/mesa/state_tracker/st_extensions.c | 22

[Mesa-dev] [PATCH v2 02/14] mesa/main: add support for ARB_compute_variable_groups_size

v2: - update formatting spec quotations (Ian) - move the total_invocations check outside of the loop (Ian) Signed-off-by: Samuel Pitoiset --- src/mesa/main/api_validate.c | 96 src/mesa/main/api_validate.h | 4 ++

[Mesa-dev] [PATCH v2 09/14] st/mesa: add mapping for SYSTEM_VALUE_LOCAL_GROUP_SIZE

gl_LocalGroupSizeARB can be translated into TGSI_SEMANTIC_BLOCK_SIZE which represents the block size in threads. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 2 ++ 1 file changed, 2

[Mesa-dev] [PATCH v2 13/14] nvc0: expose ARB_compute_variable_group_size

Let's return the same number of threads per block for both fixed and variable sizes. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH v2 14/14] docs: mark ARB_compute_variable_group_size as done for nvc0

Signed-off-by: Samuel Pitoiset --- docs/features.txt | 2 +- docs/relnotes/12.1.0.html | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/features.txt b/docs/features.txt index 690c160..3825943 100644 --- a/docs/features.txt +++

[Mesa-dev] [PATCH v2 00/14] add support for ARB_compute_variable_group_size

v2: - update formatting spec quotations - add PIPE_COMPUTE_CAP_MAX_VARIABLE_THREADS_PER_BLOCK - expose the ext based on that new cap - add missing relnotes - various cosmetic changes From original cover-letter: Hi, This series implements ARB_compute_variable_group_size written

[Mesa-dev] [PATCH v2 05/14] glsl: reject compute shaders with fixed and variable local size

The ARB_compute_variable_group_size specification explains that when a compute shader includes both a fixed and a variable local size, a compile-time error occurs. v2: - update formatting spec quotations (Ian) Signed-off-by: Samuel Pitoiset ---

[Mesa-dev] [PATCH v2 07/14] glsl: add gl_LocalGroupSizeARB as a system value

v2: - only add it if the ext is enabled (Ilia) Signed-off-by: Samuel Pitoiset Reviewed-by: Ian Romanick --- src/compiler/glsl/builtin_variables.cpp | 6 ++ src/compiler/shader_enums.h | 1 + 2 files changed, 7 insertions(+)

[Mesa-dev] [PATCH v2 04/14] glsl: process local_size_variable input qualifier

This is the new layout qualifier introduced by ARB_compute_variable_group_size which allows to use a variable work group size. Signed-off-by: Samuel Pitoiset Reviewed-by: Ian Romanick --- src/compiler/glsl/ast.h | 5 +

[Mesa-dev] [PATCH v2 01/14] glapi: add entry points for GL_ARB_compute_variable_group_size

v2: - correctly sort that new extension (Ian) - fix up the comment (Ian) Signed-off-by: Samuel Pitoiset Reviewed-by: Ian Romanick --- .../glapi/gen/ARB_compute_variable_group_size.xml | 25 ++

[Mesa-dev] [PATCH v2 06/14] glsl/linker: handle errors when a variable local size is used

Compute shaders can now include a fixed local size as defined by ARB_compute_shader or a variable size as defined by ARB_compute_variable_group_size. v2: - update formatting spec quotations (Ian) - various cosmetic changes (Ian) Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v2 03/14] glsl: add enable flags for ARB_compute_variable_group_size

This also initializes the default values for the standalone compiler. Signed-off-by: Samuel Pitoiset Reviewed-by: Ian Romanick --- src/compiler/glsl/glsl_parser_extras.cpp | 1 + src/compiler/glsl/glsl_parser_extras.h | 2 ++

Re: [Mesa-dev] [PATCH 02/11] mesa/main: add support for ARB_compute_variable_groups_size

On 09/08/2016 10:58 PM, Ian Romanick wrote: On 09/08/2016 01:31 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/mesa/main/api_validate.c | 94 src/mesa/main/api_validate.h | 4 ++

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

Good questions, > 1. How can we minimize the effort of maintaining two repositories? (I don't > think anyone here would support dropping the HTML docs, as they feed into > the main Mesa website). I agree that maintaining two repos would be bad, but we don't need to do that. Sphinx can generate

Re: [Mesa-dev] Proposal: move the Mesa documentation to readthedocs.org

On 27 August 2016 at 01:09, Nicholas Bishop wrote: > Hi, > > I'd like to propose a conversion of Mesa's documentation to > reStructuredText (RST) and hosting the result on readthedocs.org. The > intent is to make Mesa's documentation more accessible, searchable, and >

[Mesa-dev] [PATCH] st/mesa: fix is_scissor_enabled when X/Y are negative

Similar to commit 49c24d8a24 ("i965: fix noop_scissor range issue on width/height") - take the X/Y into account to determine whether the scissor covers the whole area or not. Fixes the recently-added gl-1.0-scissor-depth-clear-negative-xy piglit test. Signed-off-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH 09/23] glsl: Convert constant_expression to the util hash table

2016-09-11 6:27 GMT+02:00 Timothy Arceri : > On Sat, 2016-09-10 at 13:19 +0200, Thomas Helland wrote: >> 2016-09-09 0:20 GMT+02:00 Thomas Helland : >> > >> > 2016-08-16 22:10 GMT+02:00 Thomas Helland > > m>: >> > >

[Mesa-dev] [Bug 97766] Multiple EGL displays with multiple window systems leads to a crash

https://bugs.freedesktop.org/show_bug.cgi?id=97766 Bug ID: 97766 Summary: Multiple EGL displays with multiple window systems leads to a crash Product: Mesa Version: 12.0 Hardware: All OS: All