Re: [Mesa-dev] [PATCH] gallium/drivers: initialize pipe_resource::next to NULL

2016-10-06 Thread Axel Davy
Hi, as of writing, there doesn't seem to be a concensus on the fix. Could one be found for Mesa 13 ? Gallium nine is apparently broken except on radeonsi which zeros out the next field... It'd need either the proposed patch of this thread merged, or to zero the next field everywhere. I guess

[Mesa-dev] [PATCH 1/2] glsl: prohibit lowp, mediump precision on atomic_uint

2016-10-06 Thread Tapani Pälli
Fixes following dEQP tests: dEQP-GLES31.functional.debug.negative_coverage.callbacks.atomic_counter.atomic_precision dEQP-GLES31.functional.debug.negative_coverage.get_error.atomic_counter.atomic_precision

[Mesa-dev] [PATCH 2/2] mesa: throw error if bufSize negative in GetSynciv on OpenGL ES

2016-10-06 Thread Tapani Pälli
Fixes following dEQP tests: dEQP-GLES31.functional.debug.negative_coverage.callbacks.state.get_synciv dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_synciv dEQP-GLES31.functional.debug.negative_coverage.log.state.get_synciv Signed-off-by: Tapani Pälli

[Mesa-dev] [Bug 98133] GetSynciv should raise an error if bufSize < 0

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98133 Tapani Pälli changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |lem...@gmail.com

[Mesa-dev] [Bug 98131] Compiler should reject lowp/mediump qualifiers on atomic_uints

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98131 Tapani Pälli changed: What|Removed |Added Status|NEW |ASSIGNED

Re: [Mesa-dev] [RADV] vk_format.h:147:1: unknown type name 'uint' - is my compiler overage?

2016-10-06 Thread Dave Airlie
On 7 October 2016 at 12:05, Dieter Nützel wrote: > gcc (SUSE Linux) 4.8.3 > > make[4]: Entering directory '/opt/mesa/src/amd/vulkan' Should already be fixed, must be compiler/libc mismatches or something. Dave. ___ mesa-dev

Re: [Mesa-dev] [PATCH] glsl: Let cache_test build when the shader cache is not enabled

2016-10-06 Thread Aaron Watry
Thanks for this. This at least lets me build a 32-bit mesa on 64-bit host again by disabling the cache. Tested-by: Aaron Watry Tim: Just FYI, I get test failures for 32-bit builds on my x86-64 host. With this patch, it no longer segfaults at least, just fails tests. If you

[Mesa-dev] [RADV] vk_format.h:147:1: unknown type name 'uint' - is my compiler overage?

2016-10-06 Thread Dieter Nützel
gcc (SUSE Linux) 4.8.3 make[4]: Entering directory '/opt/mesa/src/amd/vulkan' Updating radv_timestamp.h GEN radv_timestamp.h CC radv_device.lo CC vk_format_table.lo In file included from vk_format_table.c:31:0: vk_format.h:147:1: error: unknown type name 'uint'

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

2016-10-06 Thread Michel Dänzer
On 07/10/16 05:44 AM, Eric Anholt wrote: > Marek Olšák writes: > >> I'd like to have more feedback on the idea of using jemalloc for ralloc. >> >> Right now, I see these options: >> >> 1) Use jemalloc for ralloc and make it mandatory for all GL drivers. >> - Distributions have

[Mesa-dev] [Bug 98136] dEQP prohibits varying structs of arrays (and vice versa)?

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98136 Bug ID: 98136 Summary: dEQP prohibits varying structs of arrays (and vice versa)? Product: Mesa Version: git Hardware: Other OS: All Status:

[Mesa-dev] [Bug 98135] dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.transform_feedback_varyings wants a different GL error code

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98135 Bug ID: 98135 Summary: dEQP-GLES31.functional.debug.negative_coverage.get_err or.shader.transform_feedback_varyings wants a different GL error code Product: Mesa

[Mesa-dev] [Bug 98134] dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.draw_buffers wants a different GL error code

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98134 Bug ID: 98134 Summary: dEQP-GLES31.functional.debug.negative_coverage.get_err or.buffer.draw_buffers wants a different GL error code Product: Mesa Version: git Hardware:

[Mesa-dev] [Bug 98133] GetSynciv should raise an error if bufSize < 0

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98133 Bug ID: 98133 Summary: GetSynciv should raise an error if bufSize < 0 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [Bug 98132] #version 300 es compute shaders should not be possible

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98132 Bug ID: 98132 Summary: #version 300 es compute shaders should not be possible Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity:

[Mesa-dev] [Bug 98131] Compiler should reject lowp/mediump qualifiers on atomic_uints

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98131 Bug ID: 98131 Summary: Compiler should reject lowp/mediump qualifiers on atomic_uints Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

2016-10-06 Thread Jason Ekstrand
Nice and clean! R-b still applies. I think I've reviewed everything now. If there's still something missing, let me know. May also want to give Chad a chance. On Thu, Oct 6, 2016 at 3:21 PM, Nanley Chery wrote: > Provides an FPS increase of ~30% on the Sascha triangle

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Jason Ekstrand
On Thu, Oct 6, 2016 at 1:33 PM, Nanley Chery wrote: > On Thu, Oct 06, 2016 at 12:35:53PM -0700, Jason Ekstrand wrote: > > On Thu, Oct 6, 2016 at 12:30 PM, Nanley Chery > wrote: > > > > > On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand

Re: [Mesa-dev] [PATCH] anv/wsi: Advertise UNORM formats as well as sRGB

2016-10-06 Thread Lionel Landwerlin
Thanks, I was wondering why those weren't available. Reviewed-by: Lionel Landwerlin On 05/10/16 21:26, Jason Ekstrand wrote: Because WSI images are created with VkImageCreateInfo::flags explicitly set to 0, they don't ever have the

Re: [Mesa-dev] [PATCH] nv50/ir: start LocalCSE with getFirst to merge PHI instructions

2016-10-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Oct 6, 2016 at 5:33 PM, Karol Herbst wrote: > total instructions in shared programs : 2818606 -> 2818227 (-0.01%) > total gprs used in shared programs: 379273 -> 379238 (-0.01%) > total local used in shared

Re: [Mesa-dev] [PATCH] vbo: disable primitive restart when GL >= 4.5

2016-10-06 Thread Ian Romanick
On 10/06/2016 06:22 AM, Martina Kollarova wrote: > The OpenGL 4.5 spec updated the section on primitive restart, and now it > doesn't have to be performed on drawing commands not taking a parameter, > regardless of whether PRIMITIVE_RESTART_FIXED_INDEX is enabled or not. > > Bugzilla:

Re: [Mesa-dev] [PATCH] reviewers: Throw myself on the GLX grenade

2016-10-06 Thread Ian Romanick
Heh... I'm not there... well done. Reviewed-by: Ian Romanick On 10/06/2016 12:37 PM, Adam Jackson wrote: > Signed-off-by: Adam Jackson > --- > REVIEWERS | 4 > 1 file changed, 4 insertions(+) > > diff --git a/REVIEWERS b/REVIEWERS > index

Re: [Mesa-dev] [PATCH] nv50/ir: fix wrong check when optimizing MAD to SHLADD

2016-10-06 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Thu, Oct 6, 2016 at 7:11 PM, Samuel Pitoiset wrote: > Checking if MAD is supported is definitely wrong, and it's > more likely a typo I introduced few days ago which breaks > NV50 because SHLADD is not supported there.

[Mesa-dev] [PATCH] nv50/ir: fix wrong check when optimizing MAD to SHLADD

2016-10-06 Thread Samuel Pitoiset
Checking if MAD is supported is definitely wrong, and it's more likely a typo I introduced few days ago which breaks NV50 because SHLADD is not supported there. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/codegen/nv50_ir_peephole.cpp | 2 +- 1 file

Re: [Mesa-dev] [PATCH 08/10] nir: add a loop unrolling pass

2016-10-06 Thread Timothy Arceri
On Thu, 2016-10-06 at 10:33 -0700, Jason Ekstrand wrote: > > > > On Wed, Oct 5, 2016 at 7:25 PM, Timothy Arceri > abora.com> wrote: > > > Just  > > > > > > On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote: > > > > > > > > > > > > On Thu, Sep 15, 2016 at 12:03 AM,

[Mesa-dev] [PATCH 5/5] glsl: simplified ast_type_qualifier::merge_[in|out]_qualifier API

2016-10-06 Thread Andres Gomez
Since we modified the way in which multiple repetitions of the same layout-qualifier-name in a single declaration collapse into the ast_type_qualifier class, we can simplify the merge_[in|out]_qualifier APIs through removing the create_node parameter. Signed-off-by: Andres Gomez

[Mesa-dev] [PATCH 2/5] glsl: last duplicated layout-qualifier-name in multiple layout-qualifiers overrides the former

2016-10-06 Thread Andres Gomez
From page 46 (page 52 of the PDF) of the GLSL 4.20 spec: " More than one layout qualifier may appear in a single declaration. If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." Consider this

[Mesa-dev] [PATCH 4/5] glsl: by default, any ast_layout_expression variable value must match its previous appearances

2016-10-06 Thread Andres Gomez
Recently, we added code to check that any appearance of the "max_vertices" layout-qualifier-name in a program holds the same value. Now, we make this the default behavior for any layout-qualifier-name represented as a ast_layout_expression since, as it happens, the same constraint applies to all

[Mesa-dev] [PATCH 1/5] glsl: last duplicated layout-qualifier-name in a layout-qualifier overrides the former

2016-10-06 Thread Andres Gomez
In a declaration, when a layout qualifier appears and holds duplicated layout-qualifier-name, only the last occurrence should be taken into account. From page 59 (page 65 of the PDF) of the GLSL 4.40 spec: " More than one layout qualifier may appear in a single declaration. Additionally,

[Mesa-dev] [PATCH 0/5] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-10-06 Thread Andres Gomez
In the case of layout-qualifier-names that can appear multiple times in different declarations of the same shader or, even, the same program, we are using the ast_layout_expression class which holds a list to store all the appearances to be able to check later which is the overriding value and

[Mesa-dev] [PATCH 3/5] glsl: push layout-qualifier-name values from variable declarations to global

2016-10-06 Thread Andres Gomez
After the previous modifications in the merging of the layout-qualifier-name values, we no longer push the final value in a declaration to the global values. This regression happens because we don't call for merging on the right-most layout qualifier of a declaration which is also the overriding

[Mesa-dev] [Bug 98128] nir/tests/control_flow_tests.cpp:79:73: error: ‘nir_loop_first_cf_node’ was not declared in this scope

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98128 Jason Ekstrand changed: What|Removed |Added Resolution|--- |FIXED

[Mesa-dev] [PATCH] gallium: Fix install-gallium-links.mk on non-bash /bin/sh

2016-10-06 Thread Eric Anholt
Debian uses dash by default, which doesn't do '+='. Fixes servo's osmesa-based headless testing system, which was looking for libOSMesa in the lib/ directory. --- install-gallium-links.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/install-gallium-links.mk

Re: [Mesa-dev] [PATCH 20/75] st/nine: Initial ProcessVertices support

2016-10-06 Thread Axel Davy
On 06/10/2016 22:28, Ilia Mirkin wrote: On Thu, Oct 6, 2016 at 4:24 PM, Axel Davy wrote: On 05/10/2016 22:08, Axel Davy wrote: HRESULT NINE_WINAPI NineDevice9_ProcessVertices( struct NineDevice9 *This, UINT SrcStartIndex, @@ -3174,33

Re: [Mesa-dev] [PATCH v3 5/5] intel: aubinator: enable loading dumps from standard input

2016-10-06 Thread Gandikota, Sirisha
>-Original Message- >From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of >Lionel Landwerlin >Sent: Wednesday, October 05, 2016 8:56 AM >To: mesa-dev@lists.freedesktop.org >Cc: Landwerlin, Lionel G >Subject: [Mesa-dev] [PATCH v3 5/5]

Re: [Mesa-dev] [PATCH 4/5] intel: aubinator: enable loading xml files from a given directory

2016-10-06 Thread Gandikota, Sirisha
>-Original Message- >From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of >Lionel Landwerlin >Sent: Wednesday, October 05, 2016 8:55 AM >To: mesa-dev@lists.freedesktop.org >Cc: Landwerlin, Lionel G >Subject: [Mesa-dev] [PATCH 4/5]

[Mesa-dev] [PATCH v3 01/10] isl: Correct a comment in the isl_format enum

2016-10-06 Thread Nanley Chery
HiZ is not a color surface, but an auxiliary depth surface. Signed-off-by: Nanley Chery Reviewed-by: Chad Versace Reviewed-by: Jason Ekstrand --- src/intel/isl/isl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Mesa-dev] [PATCH v3 08/10] anv/cmd_buffer: Enable rendering to HiZ

2016-10-06 Thread Nanley Chery
From: Chad Versace Nanley Chery: (rebase) - Resolve conflicts with new anv_batch_emit macro (amend) - Handle a QPitch TODO - Emit 3DSTATE_HIER_DEPTH_BUFFER on pre-BDW systems - Only use HiZ for single-subpass renderpasses - Emit the HiZ instruction before the stencil

[Mesa-dev] [PATCH v3 03/10] anv: Add func anv_image_has_hiz()

2016-10-06 Thread Nanley Chery
From: Chad Versace Signed-off-by: Nanley Chery Reviewed-by: Jason Ekstrand --- src/intel/vulkan/anv_private.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH v3 10/10] anv/TODO: Update the HiZ task

2016-10-06 Thread Nanley Chery
Signed-off-by: Nanley Chery Reviewed-by: Jason Ekstrand --- src/intel/vulkan/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO index 8fac370..9ac63eb 100644 ---

[Mesa-dev] [PATCH v3 02/10] anv: Add anv_image::hiz_surface

2016-10-06 Thread Nanley Chery
From: Chad Versace Unused. Signed-off-by: Nanley Chery Reviewed-by: Jason Ekstrand --- src/intel/vulkan/anv_private.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_private.h

[Mesa-dev] [PATCH v3 06/10] anv/image: Memset hiz surfaces to 0 when binding memory

2016-10-06 Thread Nanley Chery
From: Jason Ekstrand Nanley Chery (amend): - Change memset value from 0xff to 0 (a defined value for HiZ). Signed-off-by: Nanley Chery Reviewed-by: Chad Versace Reviewed-by: Jason Ekstrand

[Mesa-dev] [PATCH v3 09/10] anv: Enable fast depth clears

2016-10-06 Thread Nanley Chery
Provides an FPS increase of ~30% on the Sascha triangle and multisampling demos. Signed-off-by: Nanley Chery Reviewed-by: Jason Ekstrand (v2) --- v3. Emit required clear_params packet (Chad) Share clear_params code path IVB+ (Jason)

[Mesa-dev] [PATCH v3 07/10] anv/cmd_buffer: Add code for performing HZ operations

2016-10-06 Thread Nanley Chery
Create a function that performs one of three HiZ operations - depth/stencil clears, HiZ resolve, and depth resolves. Signed-off-by: Nanley Chery Reviewed-by: Jason Ekstrand (v2) --- v3. Change do_hz to emit_hz (Chad) Always set XMin YMin

[Mesa-dev] [PATCH v3 05/10] anv: Move BindImageMemory to anv_image.c

2016-10-06 Thread Nanley Chery
From: Jason Ekstrand Signed-off-by: Nanley Chery Reviewed-by: Chad Versace Reviewed-by: Jason Ekstrand --- src/intel/vulkan/anv_device.c | 20 src/intel/vulkan/anv_image.c

[Mesa-dev] [PATCH v3 04/10] anv: Allocate hiz surface

2016-10-06 Thread Nanley Chery
From: Chad Versace Nanley Chery: (rebase) - Use isl_surf_get_hiz_surf() (amend) - Only add a HiZ surface onto a depth/stencil attachment - Add comment above HiZ surface addition - Hide HiZ behind INTEL_VK_HIZ prior to BDW - Disable HiZ for untested cases - Remove

[Mesa-dev] [PATCH v3 00/10] anv: Enable HiZ for basic cases

2016-10-06 Thread Nanley Chery
This work is a revision of this series: https://lists.freedesktop.org/archives/mesa-dev/2016-September/129845.html And is dependent on this series: https://patchwork.freedesktop.org/series/13360/ Cc: Chad Versace Cc: Jason Ekstrand Chad Versace

Re: [Mesa-dev] [PATCH 2/5] intel: aubinator: use getopt to parse arguments

2016-10-06 Thread Gandikota, Sirisha
>-Original Message- >From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of >Lionel Landwerlin >Sent: Wednesday, October 05, 2016 8:55 AM >To: mesa-dev@lists.freedesktop.org >Cc: Landwerlin, Lionel G >Subject: [Mesa-dev] [PATCH 2/5]

Re: [Mesa-dev] [PATCH v4 04/14] glsl: process local_size_variable input qualifier

2016-10-06 Thread Samuel Pitoiset
On 10/06/2016 09:27 AM, Nicolai Hähnle wrote: On 05.10.2016 20:48, Samuel Pitoiset wrote: This is the new layout qualifier introduced by ARB_compute_variable_group_size which allows to use a variable work group size. v4: - add missing '%s' in the monster format string Signed-off-by: Samuel

Re: [Mesa-dev] [PATCH v4 02/14] mesa/main: add support for ARB_compute_variable_groups_size

2016-10-06 Thread Samuel Pitoiset
On 10/06/2016 09:25 AM, Nicolai Hähnle wrote: On 05.10.2016 20:48, Samuel Pitoiset wrote: v4: - slightly indent spec quotes (Nicolai) - drop useless _mesa_has_compute_shaders() check (Nicolai) - move the fixed local size outside of the loop (Nicolai) - add missing check for

Re: [Mesa-dev] [PATCH 1/5] intel: aubinator: add missing return characters

2016-10-06 Thread Gandikota, Sirisha
>-Original Message- >From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of >Lionel Landwerlin >Sent: Wednesday, October 05, 2016 8:55 AM >To: mesa-dev@lists.freedesktop.org >Cc: Landwerlin, Lionel G >Subject: [Mesa-dev] [PATCH 1/5]

[Mesa-dev] [Bug 98128] nir/tests/control_flow_tests.cpp:79:73: error: ‘nir_loop_first_cf_node’ was not declared in this scope

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98128 Bug ID: 98128 Summary: nir/tests/control_flow_tests.cpp:79:73: error: ‘nir_loop_first_cf_node’ was not declared in this scope Product: Mesa Version: git

[Mesa-dev] [PATCH] nv50/ir: start LocalCSE with getFirst to merge PHI instructions

2016-10-06 Thread Karol Herbst
total instructions in shared programs : 2818606 -> 2818227 (-0.01%) total gprs used in shared programs: 379273 -> 379238 (-0.01%) total local used in shared programs : 9505 -> 9505 (0.00%) total bytes used in shared programs : 25837192 -> 25833736 (-0.01%) localgpr

Re: [Mesa-dev] [PATCH] anv: Return correct result in EnumeratePhysicalDevices

2016-10-06 Thread Anuj Phogat
On Thu, Oct 6, 2016 at 12:21 PM, Nicolas Koch wrote: > If pPhysicalDevices is too small for all physical devices, > the driver must return VK_INCOMPLETE. > Since only a single physical device is supported, this is only the case > when pPhysicalDeviceCount == 0 &&

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

2016-10-06 Thread Eric Anholt
Marek Olšák writes: > I'd like to have more feedback on the idea of using jemalloc for ralloc. > > Right now, I see these options: > > 1) Use jemalloc for ralloc and make it mandatory for all GL drivers. > - Distributions have shown that they are capable of doing anything >

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Nanley Chery
On Thu, Oct 06, 2016 at 12:35:53PM -0700, Jason Ekstrand wrote: > On Thu, Oct 6, 2016 at 12:30 PM, Nanley Chery wrote: > > > On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote: > > > Initially, we had intended set_subpass to be an interesting function that > >

Re: [Mesa-dev] [PATCH 20/75] st/nine: Initial ProcessVertices support

2016-10-06 Thread Ilia Mirkin
On Thu, Oct 6, 2016 at 4:24 PM, Axel Davy wrote: > On 05/10/2016 22:08, Axel Davy wrote: >> >> HRESULT NINE_WINAPI >> NineDevice9_ProcessVertices( struct NineDevice9 *This, >>UINT SrcStartIndex, >> @@ -3174,33 +3188,69 @@

Re: [Mesa-dev] [RFC] ralloc: use jemalloc for faster GLSL compilation

2016-10-06 Thread Marek Olšák
I'd like to have more feedback on the idea of using jemalloc for ralloc. Right now, I see these options: 1) Use jemalloc for ralloc and make it mandatory for all GL drivers. - Distributions have shown that they are capable of doing anything with the Mesa source code, so they don't need

Re: [Mesa-dev] [PATCH 20/75] st/nine: Initial ProcessVertices support

2016-10-06 Thread Axel Davy
On 05/10/2016 22:08, Axel Davy wrote: HRESULT NINE_WINAPI NineDevice9_ProcessVertices( struct NineDevice9 *This, UINT SrcStartIndex, @@ -3174,33 +3188,69 @@ NineDevice9_ProcessVertices( struct NineDevice9 *This,

[Mesa-dev] [PATCH] reviewers: Throw myself on the GLX grenade

2016-10-06 Thread Adam Jackson
Signed-off-by: Adam Jackson --- REVIEWERS | 4 1 file changed, 4 insertions(+) diff --git a/REVIEWERS b/REVIEWERS index f7574b3..f822421 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -104,3 +104,7 @@ F: src/egl/drivers/dri2/platform_wayland.c FREEDRENO R: Rob Clark

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Jason Ekstrand
On Thu, Oct 6, 2016 at 12:30 PM, Nanley Chery wrote: > On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote: > > Initially, we had intended set_subpass to be an interesting function that > > did whatever (presumably a lot) setup we needed for a subpass. In >

Re: [Mesa-dev] [PATCH 1/2] anv/cmd_buffer: Don't call set_subpass in a secondary

2016-10-06 Thread Nanley Chery
On Wed, Oct 05, 2016 at 05:36:43PM -0700, Jason Ekstrand wrote: > Initially, we had intended set_subpass to be an interesting function that > did whatever (presumably a lot) setup we needed for a subpass. In reality, > it just sets a pointer and a dirty bit and then emits depth and stencil >

[Mesa-dev] [PATCH] anv: Return correct result in EnumeratePhysicalDevices

2016-10-06 Thread Nicolas Koch
If pPhysicalDevices is too small for all physical devices, the driver must return VK_INCOMPLETE. Since only a single physical device is supported, this is only the case when pPhysicalDeviceCount == 0 && pPhysicalDevices != NULL. --- src/intel/vulkan/anv_device.c | 2 ++ 1 file changed, 2

Re: [Mesa-dev] [PATCH 04/75] st/nine: Fix some check flags

2016-10-06 Thread Axel Davy
On 06/10/2016 11:34, Emil Velikov wrote: On 5 October 2016 at 21:08, Axel Davy wrote: Uses the new defines introduced in previous commit. Please describe why the newly introduced flags are used over the present ones. Worth copying some of the in-source comment or

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Vedran Miletić
On 10/06/2016 07:15 PM, Jan Vesely wrote: > On Thu, 2016-10-06 at 16:26 +0200, Vedran Miletić wrote: >> CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version >> supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for >> OpenGL. >> CLOVER_CL_C_VERSION_OVERRIDE allows overridng

Re: [Mesa-dev] [PATCH 3/3] softpipe: Cap to 2 GB on 32 bits

2016-10-06 Thread Roland Scheidegger
Am 06.10.2016 um 19:51 schrieb Axel Davy: > On 32 bits system, application memory is quite limited. > softpipe uses application memory. To help prevent memory > exhaustion, limit reported memory availability to 2GB. > > Some gallium nine apps do check reported memory by allocating > resources

Re: [Mesa-dev] [PATCH 02/75] gallium/util: Really allow aliasing for u_box_union_*

2016-10-06 Thread Axel Davy
Sorry, ignore this, I sent a new one with the corrected title. On 06/10/2016 19:57, Axel Davy wrote: Gallium nine relies on aliasing to work with this function. Without this patch, dirty region tracking was incorrect, which could lead to incorrect textures or vertex buffers. Fixes several game

[Mesa-dev] [PATCH 02/75] gallium/util: Really allow aliasing of dst for u_box_union_*

2016-10-06 Thread Axel Davy
Gallium nine relies on aliasing to work with this function. Without this patch, dirty region tracking was incorrect, which could lead to incorrect textures or vertex buffers. Fixes several game bugs with nine. Fixes https://github.com/iXit/Mesa-3D/issues/234 Signed-off-by: Axel Davy

[Mesa-dev] [PATCH 02/75] gallium/util: Really allow aliasing for u_box_union_*

2016-10-06 Thread Axel Davy
Gallium nine relies on aliasing to work with this function. Without this patch, dirty region tracking was incorrect, which could lead to incorrect textures or vertex buffers. Fixes several game bugs with nine. Fixes https://github.com/iXit/Mesa-3D/issues/234 Signed-off-by: Axel Davy

[Mesa-dev] [PATCH 3/3] softpipe: Cap to 2 GB on 32 bits

2016-10-06 Thread Axel Davy
On 32 bits system, application memory is quite limited. softpipe uses application memory. To help prevent memory exhaustion, limit reported memory availability to 2GB. Some gallium nine apps do check reported memory by allocating resources until memory is full. Gallium nine refuses allocations

[Mesa-dev] [PATCH 1/3] gallium/os: Fix overflow on 32 bits

2016-10-06 Thread Axel Davy
On systems with more than 4GB of ram, os_get_total_physical_memory was triggering an integer overflow for the linux and haiku path, when on 32 bits. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94561 Signed-off-by: Axel Davy --- src/gallium/auxiliary/os/os_misc.c |

[Mesa-dev] [PATCH 2/3] llvmpipe: Cap to 2 GB on 32 bits

2016-10-06 Thread Axel Davy
On 32 bits system, application memory is quite limited. llvmpipe uses application memory. To help prevent memory exhaustion, limit reported memory availability to 2GB. Some gallium nine apps do check reported memory by allocating resources until memory is full. Gallium nine refuses allocations

[Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument. (v2)

2016-10-06 Thread Gustaw Smolarczyk
It's supposed to be how much at least we want to grow the cs, not the minimum size of the cs after growth. v2: Unbreak use_ib_bos. Don't mask the ib_size when !use_ib_bos, since it's not needed. --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 11 +++ 1 file changed, 7

Re: [Mesa-dev] [PATCH 08/10] nir: add a loop unrolling pass

2016-10-06 Thread Jason Ekstrand
On Thu, Oct 6, 2016 at 10:22 AM, Jason Ekstrand wrote: > > > On Wed, Oct 5, 2016 at 7:25 PM, Timothy Arceri < > timothy.arc...@collabora.com> wrote: > >> Just >> >> On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote: >> > >> > >> > On Thu, Sep 15, 2016 at 12:03 AM,

[Mesa-dev] [Bug 97952] /usr/include/string.h:518:12: error: exception specification in declaration does not match previous declaration

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97952 --- Comment #4 from Rob Clark --- (In reply to Timothy Arceri from comment #3) > I believe its because the ffs param in string.h is an int while the one in > bitscan.h is unsigned. oh, yeah, probably should be int in

Re: [Mesa-dev] [PATCH 01/75] llvmpipe: Fix overflow for 32 bits available memory computation

2016-10-06 Thread Axel Davy
On 06/10/2016 11:44, Emil Velikov wrote: Hi Axel, You seem to have forgotten/ignored virtually every suggestion for this patch from last time around. Did you send the wrong patch or ? Emil Well it was sitting on our repo, and I got persuaded I had addressed the issues. Looks like not.

Re: [Mesa-dev] [PATCH 1/6] st/mesa: simplify some code in get_texture_format_swizzle()

2016-10-06 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák Marek On Thu, Oct 6, 2016 at 2:42 AM, Brian Paul wrote: > There's no need to cast to st_texture_image. Just use gl_texture_image. > > Reviewed-by: Edward O'Callaghan > --- >

Re: [Mesa-dev] [PATCH 08/10] nir: add a loop unrolling pass

2016-10-06 Thread Jason Ekstrand
On Wed, Oct 5, 2016 at 7:25 PM, Timothy Arceri wrote: > Just > > On Wed, 2016-10-05 at 16:23 -0700, Jason Ekstrand wrote: > > > > > > On Thu, Sep 15, 2016 at 12:03 AM, Timothy Arceri > abora.com> wrote: > > > V2: > > > - tidy ups suggested by

Re: [Mesa-dev] [PATCH 1/2] clover: support CL_PROGRAM_BINARY_TYPE (CL1.2)

2016-10-06 Thread Jan Vesely
On Fri, 2014-12-19 at 16:42 +0100, EdB wrote: > CL_PROGRAM_BINARY_TYPE have been added to clGetProgramBuildInfo in > CL1.2 > --- >  src/gallium/state_trackers/clover/api/program.cpp  |  4 +++ >  src/gallium/state_trackers/clover/core/program.cpp | 31 > +- >  

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Jan Vesely
On Thu, 2016-10-06 at 16:26 +0200, Vedran Miletić wrote: > CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version > supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for > OpenGL. > CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C > version. WHat's the use of

Re: [Mesa-dev] [PATCH v4] intel: aubinator: generate a standalone binary

2016-10-06 Thread Jason Ekstrand
On Wed, Oct 5, 2016 at 3:56 PM, Lionel Landwerlin wrote: > Embed the xml files into the binary, so aubinator can be used from any > location. > > v2: Split generation packing into another patch (Jason) > Check for xxd (Jason) > > v3: Fix out of tree builds (Jason) >

Re: [Mesa-dev] [PATCH 1/3] nir: Add asserts to the casting functions

2016-10-06 Thread Jason Ekstrand
Pushed! Tim, this is going to cause you a bit of rebase trouble on loop unrolling but it should actually make your code simpler. On Wed, Oct 5, 2016 at 9:56 PM, Jason Ekstrand wrote: > On Oct 5, 2016 21:42, "Connor Abbott" wrote: > > > > Thanks for

Re: [Mesa-dev] [PATCH 1/3] i965: solve cubemap negative x/y/z faces buffer offset issue in dEQP.

2016-10-06 Thread Jason Ekstrand
On Wed, Oct 5, 2016 at 9:11 PM, Jason Ekstrand wrote: > On Wed, Oct 5, 2016 at 7:05 PM, Xu, Randy wrote: > >> Hi, Jason >> >> >> >> Do you want to add this assert in the patch? I did some test, no issue >> found, but I don’t see the case that we need

Re: [Mesa-dev] [PATCH 1/2] radv: Skip already signalled fences.

2016-10-06 Thread Bas Nieuwenhuizen
On Thu, Oct 6, 2016 at 1:09 AM, Gustaw Smolarczyk wrote: > If the user created a fence with VK_FENCE_CREATE_SIGNALED_BIT set, we > shouldn't fail to wait for a fence if it was not submitted since that is > not necessary. > --- > src/amd/vulkan/radv_device.c | 6 +++--- > 1

Re: [Mesa-dev] [PATCH 2/2] radv/winsys: Fix radv_amdgpu_cs_grow min_size argument.

2016-10-06 Thread Bas Nieuwenhuizen
On Thu, Oct 6, 2016 at 1:09 AM, Gustaw Smolarczyk wrote: > It's supposed to be how much at least we want to grow the cs, not the > minimum size of the cs after growth. > --- > src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 3 ++- > 1 file changed, 2 insertions(+), 1

[Mesa-dev] [Bug 98048] Mesa CANNOT use libpthread-stubs

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98048 Emil Velikov changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 98048] Mesa CANNOT use libpthread-stubs

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98048 Emil Velikov changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] gallium/hud: Remove superfluous debug

2016-10-06 Thread Emil Velikov
On 6 October 2016 at 16:26, Steven Toth wrote: > No longer required. > > Signed-off-by: Steven Toth > --- > src/gallium/auxiliary/hud/hud_cpufreq.c | 9 - > src/gallium/auxiliary/hud/hud_diskstat.c | 8 >

Re: [Mesa-dev] [PATCH 5/6] st/mesa: optimize pipe_sampler_view validation

2016-10-06 Thread Brian Paul
On 10/06/2016 01:45 AM, Nicolai Hähnle wrote: On 06.10.2016 02:42, Brian Paul wrote: Before, st_get_texture_sampler_view_from_stobj() did a lot of work to check if the texture parameters matched the sampler view (format, swizzle, min/max lod, first/last layer, etc). We did this every time we

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/4] i965/sync: Fix uninitalized usage and leak of mutex

2016-10-06 Thread Emil Velikov
Hi Chad, On 4 October 2016 at 23:37, Chad Versace wrote: > We locked an unitialized mutex in the callstack > glClientWaitSync > intel_gl_client_wait_sync > brw_fence_client_wait_sync > because we forgot to initialize it in intel_gl_fence_sync. > (The EGLSync

[Mesa-dev] [PATCH] gallium/hud: Remove superfluous debug

2016-10-06 Thread Steven Toth
No longer required. Signed-off-by: Steven Toth --- src/gallium/auxiliary/hud/hud_cpufreq.c | 9 - src/gallium/auxiliary/hud/hud_diskstat.c | 8 src/gallium/auxiliary/hud/hud_nic.c | 16

Re: [Mesa-dev] [PATCH] autoconf: Make header install distinct for various APIs (v2)

2016-10-06 Thread Emil Velikov
On 4 October 2016 at 16:05, Chuck Atkins wrote: > This fixes a problem where GL headers would only get installed if > glx was enabled. So if osmesa was enabled but not glx, then the > GL headers required by osmesa would be missing from the install. > > v2: Dropped

Re: [Mesa-dev] [PATCH 1/2] loader/dri3: add get_dri_screen() to the vtable

2016-10-06 Thread Emil Velikov
On 6 October 2016 at 15:13, Martin Peres wrote: > This allows querying the current active screen from the > loader's common code. > > Signed-off-by: Martin Peres > --- > src/egl/drivers/dri2/platform_x11_dri3.c | 12 >

Re: [Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Vedran Miletić
On 10/06/2016 04:26 PM, Vedran Miletić wrote: > CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version > supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. > CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C version. > --- > docs/envvars.html

[Mesa-dev] [PATCH v2] clover: assert struct argument is compiled usably

2016-10-06 Thread Vedran Miletić
Make sure that a struct argument did not get compiled into a pointer type with the byval attribute. If we try to handle the pointer with byval, we end up with the pointer size instead of the struct size. Struct arguments on AMD GPUs will work correctly on Clang versions containing

[Mesa-dev] [PATCH] clover: Allow OpenCL version override

2016-10-06 Thread Vedran Miletić
CLOVER_CL_VERSION_OVERRIDE allows overriding default OpenCL version supported by Clover, analogous to MESA_GL_VERSION_OVERRIDE for OpenGL. CLOVER_CL_C_VERSION_OVERRIDE allows overridng default OpenCL C version. --- docs/envvars.html | 12

Re: [Mesa-dev] [PATCH] vbo: disable primitive restart when GL >= 4.5

2016-10-06 Thread Daniel Scharrer
On 2016-10-06 15:22, Martina Kollarova wrote: > The OpenGL 4.5 spec updated the section on primitive restart, and now it > doesn't have to be performed on drawing commands not taking a parameter, > regardless of whether PRIMITIVE_RESTART_FIXED_INDEX is enabled or not. > > Bugzilla:

Re: [Mesa-dev] [PATCH] vbo: disable primitive restart when GL >= 4.5

2016-10-06 Thread Marek Olšák
That's funny, because Polaris is our first hardware that supports primitive restart with DrawArrays (including draw indirect), while OpenGL removed the support at the same time. Reviewed-by: Marek Olšák Marek On Thu, Oct 6, 2016 at 3:22 PM, Martina Kollarova

[Mesa-dev] [PATCH 1/2] loader/dri3: add get_dri_screen() to the vtable

2016-10-06 Thread Martin Peres
This allows querying the current active screen from the loader's common code. Signed-off-by: Martin Peres --- src/egl/drivers/dri2/platform_x11_dri3.c | 12 src/glx/dri3_glx.c | 11 +++ src/loader/loader_dri3_helper.h

[Mesa-dev] [PATCH 2/2] loader/dri3: import prime buffers in the currently-bound screen

2016-10-06 Thread Martin Peres
This tries to mirrors the codepath taken by DRI2 in IntelSetTexBuffer2() and fixes many applications when using DRI3: - Totem with libva on hw-accelerated decoding - obs-studio, using Window Capture (Xcomposite) as a Source - gstreamer with VAAPI v2: - introduce get_dri_screen() in the dri3

[Mesa-dev] [Bug 97524] Samplers referring to the same texture unit with different types should raise GL_INVALID_OPERATION

2016-10-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97524 Nicolai Hähnle changed: What|Removed |Added Summary|Invalid sampler settings|Samplers referring

  1   2   >