[Mesa-dev] [PATCH v2 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats (v2)

2016-11-09 Thread Tomasz Figa
There is an interface that can be used to query YUV buffers for their internal format. Specifically, if gralloc:lock_ycbcr() is given no SW usage flags, it's supposed to return plane offsets instead of pointers. Let's use this interface to implement support for YUV formats in Android EGL backend.

[Mesa-dev] [PATCH v2 0/2] egl/android: Support YUV formats in a gralloc-agnostic way

2016-11-09 Thread Tomasz Figa
Current EGL Android backend supports YUV format in a very limited form, with the only format supported being YV12 and plane strides and sizes calculated with hardcoded alignment assumptions. This series attempts to fix this by changing the backend to use the lock_ycbcr API available in Gralloc,

[Mesa-dev] [PATCH v2 1/2] egl/android: Get gralloc module in dri2_initialize_android() (v2)

2016-11-09 Thread Tomasz Figa
Currently droid_open_device() gets a reference to the gralloc module only for its own use and does not store it anywhere. To make it possible to call gralloc methods from code added in further patches, let's refactor current code to get gralloc module in dri2_initialize_android() and store it in

Re: [Mesa-dev] [PATCH] radv: fix texturesamples to handle single sample case

2016-11-09 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 10, 2016 at 1:33 AM, Dave Airlie wrote: > From: Dave Airlie > > We can only read the valid samples if this is an MSAA > texture, which means the type field must be 0x14 or 0x15. > > This

Re: [Mesa-dev] [PATCH] i965: miptree: prevent potential NULL pointer access

2016-11-09 Thread Pohjolainen, Topi
On Thu, Nov 10, 2016 at 07:30:17AM +, Chris Wilson wrote: > On Thu, Nov 10, 2016 at 09:21:40AM +0200, Pohjolainen, Topi wrote: > > On Wed, Nov 09, 2016 at 04:38:43PM +, Lionel Landwerlin wrote: > > > If the mcs buffer allocation fails we might get a NULL pointer. This > > > was reported by

Re: [Mesa-dev] [PATCH] i965: miptree: prevent potential NULL pointer access

2016-11-09 Thread Chris Wilson
On Thu, Nov 10, 2016 at 09:21:40AM +0200, Pohjolainen, Topi wrote: > On Wed, Nov 09, 2016 at 04:38:43PM +, Lionel Landwerlin wrote: > > If the mcs buffer allocation fails we might get a NULL pointer. This > > was reported by Coverity and should only happen if we run out of > > memory. > > > >

Re: [Mesa-dev] [PATCH] i965: miptree: prevent potential NULL pointer access

2016-11-09 Thread Pohjolainen, Topi
On Wed, Nov 09, 2016 at 04:38:43PM +, Lionel Landwerlin wrote: > If the mcs buffer allocation fails we might get a NULL pointer. This > was reported by Coverity and should only happen if we run out of > memory. > > CID: 1394290 > Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats

2016-11-09 Thread Tomasz Figa
On Thu, Nov 10, 2016 at 1:50 PM, Tomasz Figa wrote: > On Thu, Nov 10, 2016 at 5:14 AM, Emil Velikov > wrote: >> On 9 November 2016 at 08:33, Tomasz Figa wrote: >>> There is an interface that can be used to query YUV buffers for

[Mesa-dev] [Bug 98245] GLES3.1 link negative dEQP "expected linking to fail, but passed."

2016-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98245 Iago Toral changed: What|Removed |Added Status|NEW |RESOLVED

[Mesa-dev] [Bug 98245] GLES3.1 link negative dEQP "expected linking to fail, but passed."

2016-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98245 --- Comment #4 from Iago Toral --- (In reply to Iago Toral from comment #3) > I have just sent another patch that fixes the second case: > https://lists.freedesktop.org/archives/mesa-dev/2016-November/134315.html This should

Re: [Mesa-dev] [PATCH v3 0/8] deal with multiple appearances of the same layout-qualifier-name in a single declaration

2016-11-09 Thread Kenneth Graunke
On Wednesday, October 26, 2016 6:30:43 PM PST Andres Gomez wrote: [snip] > The main changes in this v3 series are: > Patch 2/8 has been modified to use an additional default_layout > variable instead of a layout_helper and the merges are done > directly on the layout one. > Old patch

Re: [Mesa-dev] Mesa (master): configure.ac: honour LLVM_LIBDIR when linking against LLVM

2016-11-09 Thread Michel Dänzer
On 10/11/16 06:47 AM, Emil Velikov wrote: > Module: Mesa > Branch: master > Commit: a39ad185932eab4f25a0cb2b112c10d8700ef242 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=a39ad185932eab4f25a0cb2b112c10d8700ef242 > > Author: Emil Velikov > Date: Mon

Re: [Mesa-dev] [PATCH] Revert "wayland: Block for the frame callback in get_back_bo not dri2_swap_buffers"

2016-11-09 Thread Jonas Ådahl
On Mon, Oct 24, 2016 at 08:42:59PM +0100, Daniel Stone wrote: > This reverts commit 25cc889004aad6d1cab9edd76db898658e347b97, though > since the code has changed, it was applied manually. > > The intent of moving blocking from SwapBuffers to get_back_bo, was to > avoid unnecessary

Re: [Mesa-dev] [PATCH 08/14] swr: [rasterizer core/jitter] fix alpha test bug

2016-11-09 Thread Rowley, Timothy O
Ah, yes, this patch missed the 8x2 tile path - I’ve fixed that now. I don’t see another path to using the blend jit functions. Thanks. On Nov 9, 2016, at 10:44 PM, Ilia Mirkin > wrote: I think a second instance of the blend func being called

Re: [Mesa-dev] [PATCH 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats

2016-11-09 Thread Tomasz Figa
On Thu, Nov 10, 2016 at 5:14 AM, Emil Velikov wrote: > On 9 November 2016 at 08:33, Tomasz Figa wrote: >> There is an interface that can be used to query YUV buffers for their >> internal format. Specifically, if gralloc:lock_ycbcr() is given no SW

Re: [Mesa-dev] [PATCH 08/14] swr: [rasterizer core/jitter] fix alpha test bug

2016-11-09 Thread Ilia Mirkin
I think a second instance of the blend func being called was missed in backend.h (the avx512 one). Also iirc there was so.e third place where it was called... Should grep for pfnBlendFunc and see if any other instances pop up. On Nov 9, 2016 10:19 PM, "Tim Rowley"

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-09 Thread Tomasz Figa
On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov wrote: > On 9 November 2016 at 08:32, Tomasz Figa wrote: >> It is currently completely broken, as it ends up using RGBX_ on >> hardware side, due to no way of distinguishing between these two in the

Re: [Mesa-dev] Next Mesa git build error wit latest LLVM version (4.0.0svn).

2016-11-09 Thread Jan Vesely
On Thu, 2016-11-10 at 03:30 +0100, Dieter Nützel wrote: > Tried LLVM version 4.0.0svn (after Tom's and Aaron's fixes), today. > I had to go back to version from 2. Nov. radv wasn't covered by those 2 patches. should be fixed now by 2fdaf38c0106d Jan > > Thanks, > Dieter > > make[3]: Entering

Re: [Mesa-dev] [PATCH] ac/nir/llvm: adopt to new LLVM attribute API.

2016-11-09 Thread Jan Vesely
On Thu, 2016-11-10 at 13:05 +1000, Dave Airlie wrote: > From: Dave Airlie > > Ported from corresponding changes to gallivm. > > Signed-off-by: Dave Airlie > --- > src/amd/common/ac_nir_to_llvm.c | 144 > ++-- > 1

Re: [Mesa-dev] [PATCH 01/14] swr: [rasterizer jitter] code style fix

2016-11-09 Thread Rowley, Timothy O
Oh, good spotting. I had incorporated the earlier version of your patch which had the other bracing “if () {“ bracing stye. I’ll remove this change from the push. > On Nov 9, 2016, at 9:38 PM, Ilia Mirkin wrote: > > What's the preferred style? It seems like every other

Re: [Mesa-dev] [PATCH 01/14] swr: [rasterizer jitter] code style fix

2016-11-09 Thread Ilia Mirkin
What's the preferred style? It seems like every other if () in this file has a { starting on the next line. That's why I ended up doing it that way as well.. On Wed, Nov 9, 2016 at 10:18 PM, Tim Rowley wrote: > --- >

Re: [Mesa-dev] [PATCH] ac/nir/llvm: adopt to new LLVM attribute API.

2016-11-09 Thread Dave Airlie
On 10 November 2016 at 13:05, Dave Airlie wrote: > From: Dave Airlie > > Ported from corresponding changes to gallivm. I've pushed this after build testing on llvm 3.9 + 4.0 git. Just to unblock the build. Dave.

[Mesa-dev] [PATCH 01/14] swr: [rasterizer jitter] code style fix

2016-11-09 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp b/src/gallium/drivers/swr/rasterizer/jitter/blend_jit.cpp index 46ea495..d69d503 100644 ---

[Mesa-dev] [PATCH 11/14] swr: [rasterizer common] don't bleed NOMINMAX definition after

2016-11-09 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/common/os.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/swr/rasterizer/common/os.h b/src/gallium/drivers/swr/rasterizer/common/os.h index ac52b60..28e7ff5 100644 ---

[Mesa-dev] [PATCH 05/14] swr: [rasterizer archrast] fix open file handle limit issue

2016-11-09 Thread Tim Rowley
Buffer events ourselves and then when that's full or we're destroying the context then write the contents to file. Previously, we're relying ofstream to buffer for us. --- .../templates/ar_eventhandlerfile_h.template | 50 +++--- 1 file changed, 44 insertions(+), 6

[Mesa-dev] [PATCH 09/14] swr: [rasterizer core] fix culling issues

2016-11-09 Thread Tim Rowley
- Do proper culling of wireframe triangles (including non-culling of degenerates) - Fix degenerate culling of CCW front-facing triangles in wireframe and conservative rast --- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 185 + 1 file changed, 119 insertions(+), 66

[Mesa-dev] [PATCH 02/14] swr: [rasterizer core] 16-wide tile store nearly completed

2016-11-09 Thread Tim Rowley
* All format combinations coded * Fully emulated on AVX2 and AVX * Known issue: the MSAA sample locations need to be adjusted for 8x2 Set ENABLE_AVX512_SIMD16 and USD_8x2_TILE_BACKEND to 1 in knobs.h to enable --- .../drivers/swr/rasterizer/common/simd16intrin.h | 61 +-

[Mesa-dev] [PATCH 14/14] swr: [rasterizer core] remove driverType

2016-11-09 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 40 ++- src/gallium/drivers/swr/rasterizer/core/api.h | 2 -- src/gallium/drivers/swr/rasterizer/core/context.h | 2 -- src/gallium/drivers/swr/rasterizer/core/state.h | 6

[Mesa-dev] [PATCH 08/14] swr: [rasterizer core/jitter] fix alpha test bug

2016-11-09 Thread Tim Rowley
Alpha from render target 0 should always be used for alpha test for all render targets, according to GL and DX9 specs. Previously we were using alpha from the current render target. --- src/gallium/drivers/swr/rasterizer/core/backend.h | 1 + src/gallium/drivers/swr/rasterizer/core/state.h

[Mesa-dev] [PATCH 12/14] swr: [rasterizer core] add mode for aux buffer in the SWR_SURFACE_STATE

2016-11-09 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/state.h | 16 1 file changed, 16 insertions(+) diff --git a/src/gallium/drivers/swr/rasterizer/core/state.h b/src/gallium/drivers/swr/rasterizer/core/state.h index 24927cd..062a1de 100644 ---

[Mesa-dev] [PATCH 13/14] swr: [rasterizer archrast] move to pass by value

2016-11-09 Thread Tim Rowley
Move to pass by value since most events are very small in size. We can look at pass by reference but will need to create multiple versions to handle temp objects. --- .../drivers/swr/rasterizer/scripts/templates/ar_eventhandler_h.template | 2 +-

[Mesa-dev] [PATCH 10/14] swr: [rasterizer archrast] add events

2016-11-09 Thread Tim Rowley
Added events for tracking early/late Depth and stencil events, TE patch info, GS prim info, and FrontEnd/BackEnd DrawEnd events. --- .../drivers/swr/rasterizer/archrast/archrast.cpp | 279 - .../drivers/swr/rasterizer/archrast/events.proto | 255 +++

[Mesa-dev] [PATCH 06/14] swr: [rasterizer archrast] don't generate empty files

2016-11-09 Thread Tim Rowley
Don't generate files when no events have been generated outside the header events. --- .../drivers/swr/rasterizer/archrast/archrast.cpp| 16 ++-- src/gallium/drivers/swr/rasterizer/archrast/archrast.h | 8 +++- src/gallium/drivers/swr/rasterizer/core/api.cpp | 6

[Mesa-dev] [PATCH 04/14] swr: [rasterizer archrast] fix double free issue

2016-11-09 Thread Tim Rowley
--- .../drivers/swr/rasterizer/archrast/archrast.cpp | 10 +- .../drivers/swr/rasterizer/archrast/archrast.h | 2 +- .../drivers/swr/rasterizer/archrast/eventmanager.h | 20 src/gallium/drivers/swr/rasterizer/core/api.cpp | 1 -

[Mesa-dev] [PATCH 00/14] swr: update rasterizer

2016-11-09 Thread Tim Rowley
Highlights include more 8x2 render work, fix for alphatest, and archrast updates. Tim Rowley (14): swr: [rasterizer jitter] code style fix swr: [rasterizer core] 16-wide tile store nearly completed swr: [rasterizer core] separate frontend/backend stats enables swr: [rasterizer archrast]

[Mesa-dev] [PATCH 07/14] swr: [rasterizer core] various code style changes

2016-11-09 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 15 ++- src/gallium/drivers/swr/rasterizer/core/api.h| 4 +++- src/gallium/drivers/swr/rasterizer/core/binner.cpp | 4 +++- src/gallium/drivers/swr/rasterizer/core/clip.h | 4 ++--

[Mesa-dev] [PATCH 03/14] swr: [rasterizer core] separate frontend/backend stats enables

2016-11-09 Thread Tim Rowley
--- src/gallium/drivers/swr/rasterizer/core/api.cpp | 18 -- src/gallium/drivers/swr/rasterizer/core/api.h | 10 +- src/gallium/drivers/swr/rasterizer/core/backend.cpp | 18 +- src/gallium/drivers/swr/rasterizer/core/context.h | 15

[Mesa-dev] [PATCH] ac/nir/llvm: adopt to new LLVM attribute API.

2016-11-09 Thread Dave Airlie
From: Dave Airlie Ported from corresponding changes to gallivm. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 144 ++-- 1 file changed, 108 insertions(+), 36 deletions(-) diff --git

[Mesa-dev] [PATCH v2] nvc0/ir: use levelZero flag when the lod is set to 0

2016-11-09 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- v1 -> v2: Move to handling this at SSA time. This is a lot more fragile since the texture arguments have been reordered already, but it's still easy enough to find the LOD argument. .../nouveau/codegen/nv50_ir_lowering_nvc0.cpp |

Re: [Mesa-dev] [PATCH 00/25] anv: A major rework of color attachment surface states

2016-11-09 Thread Jason Ekstrand
On Wed, Nov 9, 2016 at 5:09 PM, Nanley Chery wrote: > On Sat, Oct 22, 2016 at 10:50:31AM -0700, Jason Ekstrand wrote: > > This series does some fairly major surgery on color attachment surface > > state allocation and fill-out in the Intel Vulkan driver. This is in > >

[Mesa-dev] Next Mesa git build error wit latest LLVM version (4.0.0svn).

2016-11-09 Thread Dieter Nützel
Tried LLVM version 4.0.0svn (after Tom's and Aaron's fixes), today. I had to go back to version from 2. Nov. Thanks, Dieter make[3]: Entering directory '/opt/mesa/src/amd/common' CC ac_nir_to_llvm.lo ac_nir_to_llvm.c:145:43: error: unknown type name 'LLVMAttribute'

Re: [Mesa-dev] [PATCH] nv50/ir: make sure to erase src2 after optimizing to MOV

2016-11-09 Thread Ilia Mirkin
On Wed, Nov 9, 2016 at 10:35 AM, Samuel Pitoiset wrote: > > > On 11/09/2016 04:19 PM, Ilia Mirkin wrote: >> >> On Wed, Nov 9, 2016 at 10:10 AM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 11/09/2016 03:58 PM, Ilia Mirkin wrote:

Re: [Mesa-dev] [PATCH] swr: disallow luminance/intensity, bgr5x1, and bgr10x2 rt formats

2016-11-09 Thread Rowley, Timothy O
While more verbose and a little slower, I think using the util_is_intensity/luminance* functions would make it clearer to someone reading the code what’s being excluded. > On Nov 9, 2016, at 2:15 PM, Ilia Mirkin wrote: > > The rasterizer does not have StoreTile support

Re: [Mesa-dev] [PATCH 00/25] anv: A major rework of color attachment surface states

2016-11-09 Thread Nanley Chery
On Sat, Oct 22, 2016 at 10:50:31AM -0700, Jason Ekstrand wrote: > This series does some fairly major surgery on color attachment surface > state allocation and fill-out in the Intel Vulkan driver. This is in > preparation for doing color compression, fast-clears, and HiZ-capable input >

Re: [Mesa-dev] [PATCH] swr: correct setting of independentAlphaBlendEnable

2016-11-09 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Nov 9, 2016, at 1:38 PM, Ilia Mirkin > wrote: This setting is for whether color and alpha have different blend settings, not for whether blending is

Re: [Mesa-dev] [PATCH] swr: fix support for inverted depth scales

2016-11-09 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Nov 8, 2016, at 11:03 PM, Ilia Mirkin > wrote: Signed-off-by: Ilia Mirkin > --- This improves

[Mesa-dev] [PATCH] radv: fix texturesamples to handle single sample case

2016-11-09 Thread Dave Airlie
From: Dave Airlie We can only read the valid samples if this is an MSAA texture, which means the type field must be 0x14 or 0x15. This fixes: dEQP-VK.glsl.texture_functions.query.texturesamples.* Cc: "13.0" Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH] loader: use drmDeviceUseRevisionFile to prevent waking up the GPUs

2016-11-09 Thread Mauro Santos
On 09-11-2016 18:09, Emil Velikov wrote: > From: Emil Velikov > > Currently the drmGetDevice[s] API parses the config sysfs file to > retrieve the revision field. > > That is required since there's no separate file (nor a libudev call > afaict) that can be used. At

Re: [Mesa-dev] [PATCH v2] loader: use drmDeviceUseRevisionFile to prevent waking up the GPUs

2016-11-09 Thread Mauro Santos
On 09-11-2016 20:28, Emil Velikov wrote: > From: Emil Velikov > > Currently the drmGetDevice[s] API parses the config sysfs file to > retrieve the revision field. > > That is required since there's no separate file (nor a libudev call > afaict) that can be used. At

Re: [Mesa-dev] [PATCH 06/25] anv: Rework the way render target surfaces are allocated

2016-11-09 Thread Jason Ekstrand
On Wed, Nov 9, 2016 at 3:22 PM, Nanley Chery wrote: > On Tue, Nov 08, 2016 at 06:07:41PM -0800, Jason Ekstrand wrote: > > On Tue, Nov 8, 2016 at 5:16 PM, Nanley Chery > wrote: > > > > > On Tue, Nov 08, 2016 at 05:02:29PM -0800, Jason Ekstrand wrote:

Re: [Mesa-dev] [PATCH 00/25] anv: A major rework of color attachment surface states

2016-11-09 Thread Nanley Chery
On Tue, Nov 08, 2016 at 03:09:39PM -0800, Jason Ekstrand wrote: > On Tue, Nov 8, 2016 at 2:26 PM, Nanley Chery wrote: > > > On Tue, Nov 08, 2016 at 01:52:15PM -0800, Jason Ekstrand wrote: > > > On Tue, Nov 8, 2016 at 1:36 PM, Nanley Chery > > wrote:

Re: [Mesa-dev] [PATCH 06/25] anv: Rework the way render target surfaces are allocated

2016-11-09 Thread Nanley Chery
On Tue, Nov 08, 2016 at 06:07:41PM -0800, Jason Ekstrand wrote: > On Tue, Nov 8, 2016 at 5:16 PM, Nanley Chery wrote: > > > On Tue, Nov 08, 2016 at 05:02:29PM -0800, Jason Ekstrand wrote: > > > On Tue, Nov 8, 2016 at 5:00 PM, Nanley Chery > > wrote:

[Mesa-dev] [PATCH v2 2/8] scons: ignore .hpp files in parse_source_list()

2016-11-09 Thread George Kyriazis
Drivers that contain C++ .hpp files need to ignore them too, along with .h files, when building source file lists. --- scons/custom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scons/custom.py b/scons/custom.py index bdb4039..544b15d 100644 --- a/scons/custom.py +++

[Mesa-dev] [PATCH v2 5/8] gallium scons: Added swr driver to scons

2016-11-09 Thread George Kyriazis
Enable swr builds by "scons swr=1 libgl-gdi" (windows only) --- src/gallium/SConscript | 1 + src/gallium/drivers/swr/SConscript | 199 + 2 files changed, 200 insertions(+) create mode 100644 src/gallium/drivers/swr/SConscript diff --git

[Mesa-dev] [PATCH v2 7/8] swr: Added swr windows support

2016-11-09 Thread George Kyriazis
- moving some header files around for proper inclusion of windows.h - OS agnostic loading of arch-specific loadable modules - PUBLIC function declaration - better handling on NOMINMAX around windows.h inclusion. --- src/gallium/drivers/swr/rasterizer/common/os.h | 5 -

[Mesa-dev] [PATCH v2 6/8] gallium: Enable swr driver

2016-11-09 Thread George Kyriazis
--- src/gallium/targets/libgl-gdi/SConscript | 6 ++ src/gallium/targets/libgl-xlib/SConscript | 6 ++ src/gallium/targets/osmesa/SConscript | 6 ++ 3 files changed, 18 insertions(+) diff --git a/src/gallium/targets/libgl-gdi/SConscript

[Mesa-dev] [PATCH v2 8/8] swr: Fix linux build

2016-11-09 Thread George Kyriazis
Added compiler flags for libmesaswr, since it now includes core header files. --- src/gallium/drivers/swr/Makefile.am | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/gallium/drivers/swr/Makefile.am b/src/gallium/drivers/swr/Makefile.am index dd1c2e6..843d3b5 ---

[Mesa-dev] [PATCH v2 3/8] scons: added llvm 3.9 support.

2016-11-09 Thread George Kyriazis
--- scons/llvm.py | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/scons/llvm.py b/scons/llvm.py index 1fc8a3f..977e47a 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -106,7 +106,24 @@ def generate(env): ]) env.Prepend(LIBPATH =

[Mesa-dev] [PATCH v2 4/8] gallium: Added SWR support for gdi

2016-11-09 Thread George Kyriazis
Added hooks for screen creation and swap. Still keep llvmpipe the default software renderer. --- src/gallium/targets/libgl-gdi/libgl_gdi.c | 28 +++- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/src/gallium/targets/libgl-gdi/libgl_gdi.c

[Mesa-dev] [PATCH v2 0/8] Support windows builds for OpenSWR

2016-11-09 Thread George Kyriazis
Changes to support Windows scons builds for OpenSWR driver Build on windows using the following command line: scons swr=1 libgl-gdi This will produce 3 .dlls. The (main) opengl32.dll, and 2 swr-specific dlls that are loaded dynamically at runtime depending on the underlying CPU architecture

[Mesa-dev] [PATCH v2 1/8] mesa: removed redundant #else

2016-11-09 Thread George Kyriazis
--- src/util/macros.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/macros.h b/src/util/macros.h index 0563fa5..3730abe 100644 --- a/src/util/macros.h +++ b/src/util/macros.h @@ -178,7 +178,6 @@ do { \ # elif defined(_MSC_VER) && !defined(__INTEL_COMPILER)

Re: [Mesa-dev] [PATCH] radeonsi: fix/silence unused variable warnings in optimized builds

2016-11-09 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Nov 9, 2016 at 4:02 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > I'm leaving num_out_sgpr around since it's not in a fast path, and besides > the compiler should be able to

[Mesa-dev] [Bug 98595] glsl: ralloc assertion "info->canary == CANARY" failed

2016-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98595 --- Comment #11 from Jonathan Gray --- The proposed fix stops the assertion for me. With i965 I now hit a different problem that seems to be unrelated, the (OpenBSD) kernel logs error: [drm:pid19649:i915_context_is_banned]

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: expose EXT_texture_compression_s3tc for ES2

2016-11-09 Thread Kenneth Graunke
On Wednesday, November 9, 2016 10:49:51 PM PST Strasser, Kevin wrote: > On Wed, Nov 9, 2016 at 12:44 PM, Kenneth Graunke > wrote: > > On Wednesday, September 21, 2016 4:32:27 PM PST Kevin Strasser wrote: > > > The extension spec has been revised to include dependencies for

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: expose EXT_texture_compression_s3tc for ES2

2016-11-09 Thread Strasser, Kevin
On Wed, Nov 9, 2016 at 12:44 PM, Kenneth Graunke wrote: > On Wednesday, September 21, 2016 4:32:27 PM PST Kevin Strasser wrote: > > The extension spec has been revised to include dependencies for OpenGL ES 2 > > and 3. > > > > Signed-off-by: Kevin Strasser

Re: [Mesa-dev] [PATCH 1/2] gallivm: Fix build after removal of deprecated attribute API v3

2016-11-09 Thread Roland Scheidegger
Am 09.11.2016 um 16:22 schrieb Tom Stellard: > v2: > Fix adding parameter attributes with LLVM < 4.0. > > v3: > Fix typo. > Fix parameter index. > Add a gallivm enum for function attributes. > --- > src/gallium/auxiliary/draw/draw_llvm.c| 6 +- >

Re: [Mesa-dev] [PATCH v2] mesa/extensions: expose OES_vertex_half_float for ES2

2016-11-09 Thread Kenneth Graunke
On Monday, October 10, 2016 2:29:58 PM PST Kevin Strasser wrote: > Half float support already exists for desktop GL. Reuse the > ARB_half_float_vertex enable bit and account for the different enum to > enable the extension for ES2. > > Signed-off-by: Kevin Strasser >

[Mesa-dev] [PATCH 2/2] egl: Use pkg-config for Android NDK build

2016-11-09 Thread Gurchetan Singh
It's possible to build Mesa for Android using the traditional autotools workflow. To enable this, let's add the required pkg-config checks and link against them. v2: Bundle pkg-config checks together (Emil) --- configure.ac| 1 + src/egl/Makefile.am | 2 ++ 2 files changed, 3

Re: [Mesa-dev] [PATCH] egl: remove explicit config_id management from dri2_add_config()

2016-11-09 Thread Emil Velikov
On 20 October 2016 at 15:47, Eric Engestrom wrote: > On Friday, 2016-09-30 13:45:55 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Currently we only saved the id to memcpy the whole _EGLConfig to write >> back the exact same id

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-09 Thread Kyriazis, George
Alright, I won't include that particular change in my v2 of the other changes that I have, then. Thanks! George > -Original Message- > From: Brian Paul [mailto:bri...@vmware.com] > Sent: Wednesday, November 9, 2016 4:03 PM > To: Kyriazis, George ; Marek

[Mesa-dev] [Bug 98595] glsl: ralloc assertion "info->canary == CANARY" failed

2016-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98595 --- Comment #10 from Brian Paul --- I pushed 5b92008ae279962dc09bcf98c9e5511a325a2bd9, which is a tweaked version of George Kyriazis's patch. He says he has a v2 patch. And since this is still broken with older gcc, I'm

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-09 Thread Brian Paul
Sorry, I already pushed the modified patch. -Brian On 11/09/2016 02:57 PM, Kyriazis, George wrote: I'll be sending about v2 of my patches later today, and (pending review) I will check them in (actually, I'll ask Tim Rowley to check them in for me, since I don't have write access yet). I'll

Re: [Mesa-dev] [PATCH] anv: Make anv_finishme onl warn once per call-site

2016-11-09 Thread Jason Ekstrand
On Wed, Nov 9, 2016 at 11:52 AM, Kenneth Graunke wrote: > On Tuesday, November 8, 2016 8:50:43 PM PST Jason Ekstrand wrote: > > When you fire up Dota2 on Haswell you get spammed with thousands of > > "Implement Gen7 HZ ops" finishme's. The point of the finshme is as a > >

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-09 Thread Kyriazis, George
I'll be sending about v2 of my patches later today, and (pending review) I will check them in (actually, I'll ask Tim Rowley to check them in for me, since I don't have write access yet). I'll modify the check against _MSV_VER 1800 (instead of 1900), but it won't be tested on my end. Thanks,

Re: [Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to GCC i386

2016-11-09 Thread Emil Velikov
On 9 November 2016 at 20:54, Rob Herring wrote: > On Wed, Nov 2, 2016 at 10:42 PM, Rob Herring wrote: >> On Wed, Nov 2, 2016 at 10:32 AM, Emil Velikov >> wrote: >>> From: Emil Velikov >>> >>> The use of

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-09 Thread Marek Olšák
On Wed, Nov 9, 2016 at 9:58 PM, Brian Paul wrote: > On 11/07/2016 03:32 PM, George Kyriazis wrote: >> >> not having it on windows causes a CANARY assertion in >> src/util/ralloc.c:get_header() >> >> Tested only on MSVC 19.00 (DevStudio 14.0), so #ifdef guards reflect that. >>

[Mesa-dev] [PATCH 1/2] configure.ac: Don't set PTHREAD_LIBS when it is not present

2016-11-09 Thread Gurchetan Singh
AX_PTHREADS sets PTHREAD_CFLAGS and PTHREAD_LIBS, and we should not append to it. This breaks building EGL since PTHREAD_CFLAGS isn't specified, so let's add it here. I couldn't find any other places where this breaks the build in my configuration. If other configurations get broken, we should

[Mesa-dev] [PATCH] linker: Remove unnecessary overload of program_resource_visitor::visit_field

2016-11-09 Thread Ian Romanick
From: Ian Romanick It looks like I added this version as a short-hand for users that didn't need the fuller version. I don't think there's any real utility in that. I'm not sure what my thinking was there. Maybe if those users overloaded the recursion function could

Re: [Mesa-dev] [PATCH v2 1/3] vulkan/wsi: Add a thread-safe queue implementation

2016-11-09 Thread Strasser, Kevin
On Tue, Nov 8, 2016 at 5:00 PM, Jason Ekstrand wrote: > From: Kevin Strasser > > In order to support FIFO mode without blocking the application on calls > to vkQueuePresentKHR it is necessary to enqueue the request and defer > calling the server

Re: [Mesa-dev] [PATCH] ralloc: don't use ralloc_set_destructor() for linear allocations

2016-11-09 Thread Brian Paul
On 11/09/2016 12:39 PM, Francisco Jerez wrote: Francisco Jerez writes: Brian Paul writes: With older gcc versions and MSVC we were using _ralloc_destructor() in with the linear allocator. That led to a failed canary assertion. This patch prevents

Re: [Mesa-dev] [PATCH 2/3] mesa: added msvc HAS_TRIVIAL_DESTRUCTOR implementation

2016-11-09 Thread Brian Paul
On 11/07/2016 03:32 PM, George Kyriazis wrote: not having it on windows causes a CANARY assertion in src/util/ralloc.c:get_header() Tested only on MSVC 19.00 (DevStudio 14.0), so #ifdef guards reflect that. --- src/util/macros.h | 5 + 1 file changed, 5 insertions(+) diff --git

[Mesa-dev] [PATCH] gbm/drm: Pick the oldest available buffer in get_back_bo

2016-11-09 Thread Derek Foreman
We find the oldest backbuffer we can, on the grounds that clients are only going to keep a fixed history queue, so this gives them the greatest chance of being able to use that queue via making sure the age is ~always less than the depth of the swapchain Reviewed-by: Daniel Stone

Re: [Mesa-dev] [PATCH] amd/addrlib: limit fastcall/regparm to GCC i386

2016-11-09 Thread Rob Herring
On Wed, Nov 2, 2016 at 10:42 PM, Rob Herring wrote: > On Wed, Nov 2, 2016 at 10:32 AM, Emil Velikov > wrote: >> From: Emil Velikov >> >> The use of regparm causes an error on arm/arm64 builds with clang. >> fastcall is

Re: [Mesa-dev] [PATCH 1/2] mesa/extensions: expose EXT_texture_compression_s3tc for ES2

2016-11-09 Thread Kenneth Graunke
On Wednesday, September 21, 2016 4:32:27 PM PST Kevin Strasser wrote: > The extension spec has been revised to include dependencies for OpenGL ES 2 > and 3. > > Signed-off-by: Kevin Strasser > --- > src/mesa/main/extensions_table.h | 2 +- > 1 file changed, 1

[Mesa-dev] [PATCH v2] loader: use drmDeviceUseRevisionFile to prevent waking up the GPUs

2016-11-09 Thread Emil Velikov
From: Emil Velikov Currently the drmGetDevice[s] API parses the config sysfs file to retrieve the revision field. That is required since there's no separate file (nor a libudev call afaict) that can be used. At the same time doing so causes the device to be awaken,

[Mesa-dev] [Bug 98632] Fix build on Hurd without PATH_MAX

2016-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98632 --- Comment #2 from Emil Velikov --- As Ken mentioned please follow the instructions [1]. Also consider the most obvious suggestion/counter-proposal - can we have a local define with reasonable default for the platform

Re: [Mesa-dev] [PATCH 2/2] egl/android: Use gralloc::lock_ycbcr for resolving YUV formats

2016-11-09 Thread Emil Velikov
On 9 November 2016 at 08:33, Tomasz Figa wrote: > There is an interface that can be used to query YUV buffers for their > internal format. Specifically, if gralloc:lock_ycbcr() is given no SW > usage flags, it's supposed to return plane offsets instead of pointers. > Let's use

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-09 Thread Emil Velikov
On 9 November 2016 at 08:32, Tomasz Figa wrote: > It is currently completely broken, as it ends up using RGBX_ on > hardware side, due to no way of distinguishing between these two in the > DRI API, while HAL_PIXEL_FORMAT_RGB_888 is clearly defined to be the > 3-byte per

Re: [Mesa-dev] [PATCH] radv: Suffix the intel_icd file with the host CPU

2016-11-09 Thread Grazvydas Ignotas
On Wed, Nov 9, 2016 at 8:11 PM, Emil Velikov wrote: > From: Emil Velikov > > Port of the anv commit d96345de989 ("anv: Suffix the intel_icd file with > the host CPU"). I guess the subject of this patch should say radeon_icd instead of

[Mesa-dev] [PATCH] swr: disallow luminance/intensity, bgr5x1, and bgr10x2 rt formats

2016-11-09 Thread Ilia Mirkin
The rasterizer does not have StoreTile support for these, so just mark them as unsupported. They may still be used for texturing if necessary. Fixes fbo-blending-formats piglit test. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/swr/swr_screen.cpp | 14 ++

Re: [Mesa-dev] [PATCH v3] swr: [rasterizer core] allow an OpenGL driver to specify halfz clipping

2016-11-09 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley > On Nov 9, 2016, at 11:50 AM, Ilia Mirkin > wrote: With ARB_clip_control, GL may also do 0..1 depth clipping, not just -1..1. This removes clip's reliance on

Re: [Mesa-dev] [PATCH 2/2] i965: Advertise 8 subpixel bits always.

2016-11-09 Thread Kenneth Graunke
On Monday, November 7, 2016 2:22:56 PM PST Francisco Jerez wrote: > Chris Forbes writes: > > > Hi Curro, > > > > Thanks for being thorough about this -- I think there is still one area > > where things might be a bit wobbly; if we end up taking a sw fallback, > > swrast

Re: [Mesa-dev] [PATCH] anv: Make anv_finishme onl warn once per call-site

2016-11-09 Thread Kenneth Graunke
On Tuesday, November 8, 2016 8:50:43 PM PST Jason Ekstrand wrote: > When you fire up Dota2 on Haswell you get spammed with thousands of > "Implement Gen7 HZ ops" finishme's. The point of the finshme is as a > reminder that there is something left to implement. Printing it once > should be

Re: [Mesa-dev] [PATCH] Revert "wayland: Block for the frame callback in get_back_bo not dri2_swap_buffers"

2016-11-09 Thread Derek Foreman
On 31/10/16 09:30 AM, Daniel Stone wrote: On 24 October 2016 at 20:42, Daniel Stone wrote: This reverts commit 25cc889004aad6d1cab9edd76db898658e347b97, though since the code has changed, it was applied manually. The intent of moving blocking from SwapBuffers to

[Mesa-dev] [Bug 98632] Fix build on Hurd without PATH_MAX

2016-11-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98632 --- Comment #1 from Kenneth Graunke --- Please send this to mesa-dev. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 4/4] linker: Accurately track gl_uniform_block::stageref

2016-11-09 Thread Kenneth Graunke
On Monday, November 7, 2016 9:50:41 PM PST Ian Romanick wrote: > From: Ian Romanick > > As the linked per-stage shaders are processed, mark any block that has a > field that is accessed as referenced. When combining all the linked > shaders, combine the per-stage

Re: [Mesa-dev] [PATCH] ralloc: don't use ralloc_set_destructor() for linear allocations

2016-11-09 Thread Francisco Jerez
Francisco Jerez writes: > Brian Paul writes: > >> With older gcc versions and MSVC we were using _ralloc_destructor() in >> with the linear allocator. That led to a failed canary assertion. >> >> This patch prevents _ralloc_destructor() from being used

[Mesa-dev] [PATCH] swr: correct setting of independentAlphaBlendEnable

2016-11-09 Thread Ilia Mirkin
This setting is for whether color and alpha have different blend settings, not for whether blending is enabled on a per-RT basis. Signed-off-by: Ilia Mirkin --- This fixes gl-1.0-blend-func. Not 100% sure why this setting is a thing, as opposed to just looking at the

Re: [Mesa-dev] [PATCH] ralloc: don't use ralloc_set_destructor() for linear allocations

2016-11-09 Thread Francisco Jerez
Brian Paul writes: > With older gcc versions and MSVC we were using _ralloc_destructor() in > with the linear allocator. That led to a failed canary assertion. > > This patch prevents _ralloc_destructor() from being used in those cases. > > Bugzilla:

Re: [Mesa-dev] [PATCH v4 00/10] anv: Rework relocation handling

2016-11-09 Thread Jason Ekstrand
On Wed, Nov 9, 2016 at 11:26 AM, Kristian Høgsberg wrote: > On Mon, Nov 7, 2016 at 2:27 PM Jason Ekstrand > wrote: > >> This is the fourth iteration of my attempt to rework relocation handling >> and do relocations in userspace. I'm finally getting

  1   2   >