Re: [Mesa-dev] [PATCH] radv: fix texel fetch offset with 2d arrays.

2016-11-23 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 24, 2016 at 4:12 AM, Dave Airlie wrote: > From: Dave Airlie > > The code didn't limit the offsets to the number supplied, so > if we expected 3 but only got 2 we were accessing undefined memory. > > This fixes random failures in: > dEQP-VK.glsl.texture

Re: [Mesa-dev] [v2 11/17] i965: Track fast color clear state in level/layer granularity

2016-11-23 Thread Pohjolainen, Topi
On Wed, Nov 23, 2016 at 01:05:31PM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > v2: Added intel_resolve_map_clear() into intel_miptree_release() > Signed-off-by: Topi Pohjolainen <[2]topi.pohjolai...@i

[Mesa-dev] [st/omx/dec/h264] Handing negative POC

2016-11-23 Thread Namburu, Chandu-babu
Hi , I have been working on an issue where the for a particular stream playback is stuttering and there are lot of frame drops. That particular stream has negative POC value and as POC value is treated/read as unsigned, the frame is getting flushed out of DBP at the end of GOP instead of at st

Re: [Mesa-dev] [v2 14/17] i965: Use ISL for CCS layouts

2016-11-23 Thread Pohjolainen, Topi
On Wed, Nov 23, 2016 at 01:10:59PM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > One can now also delete intel_get_non_msrt_mcs_alignment(). > Signed-off-by: Topi Pohjolainen <[2]topi.pohjolai...@intel.

[Mesa-dev] [Bug 98842] mesa 13.0.1 build broken under debian8

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98842 Bug ID: 98842 Summary: mesa 13.0.1 build broken under debian8 Product: Mesa Version: 13.0 Hardware: Other OS: All Status: NEW Severity: normal P

Re: [Mesa-dev] [v2 08/17] i965: Add plumbing for fast clear layer/level details

2016-11-23 Thread Pohjolainen, Topi
On Wed, Nov 23, 2016 at 01:21:07PM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > Until now fast clear has been supported only for non-layered and > non-mipmapped buffers. However, from gen8 onwards ther

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98714 --- Comment #5 from langk...@tomblog.de --- Comment on attachment 128176 --> https://bugs.freedesktop.org/attachment.cgi?id=128176 screenshot cities skylines where now is white used to be walking citizens... -- You are receiving this mail bec

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98714 --- Comment #4 from langk...@tomblog.de --- Created attachment 128176 --> https://bugs.freedesktop.org/attachment.cgi?id=128176&action=edit screenshot cities skylines -- You are receiving this mail because: You are the assignee for the bug. Yo

[Mesa-dev] [Bug 98714] Weird whitish spots and green stuff mostly on black.

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98714 --- Comment #3 from langk...@tomblog.de --- Same here with cities skylines launched from steam on opensuse tumbleweed with pontostroys mesa llvm git repo (Mesa-13.1~git20161122 x64, kde, amd fury x, amd fx 8350) it did not depend on the ingame set

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-23 Thread Boyan Ding
2016-11-24 13:29 GMT+08:00 Derek Foreman : > On 23/11/16 07:18 PM, Boyan Ding wrote: >> >> 2016-11-24 7:01 GMT+08:00 Derek Foreman : >>> >>> This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e >>> except for i915. >>> >>> Original log for the i965 commit follows: >>> >>> Some applica

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-23 Thread Derek Foreman
On 23/11/16 07:18 PM, Boyan Ding wrote: 2016-11-24 7:01 GMT+08:00 Derek Foreman : This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e except for i915. Original log for the i965 commit follows: Some application, such as drm backend of weston, uses XRGB config as default. i96

Re: [Mesa-dev] EGL/android: pbuffer implementation.

2016-11-23 Thread Tomasz Figa
On Thu, Nov 24, 2016 at 12:18 PM, Long, Zhifang wrote: > Hi Tomasz, > > Got your requirement. So what you want is below behavior : > "droid_image_get_buffers() will not clear image_mask to 0, and only > set the bit when corresponding allocation succeed. > If some bit i

[Mesa-dev] [PATCH 4/4] intel/aubinator: Pull useful information from the AUB header

2016-11-23 Thread Jason Ekstrand
This commit does two things. One is to pull useful and/or interesting information from the AUB file header and display it as a header above your decoded batches. Second, it is now capable of pulling the PCI ID from the AUB file comment left by intel_aubdump. This removes the need to use the --ge

[Mesa-dev] [PATCH 3/4] intel/aubinator: Wait to setup decoders until we parse the aub header

2016-11-23 Thread Jason Ekstrand
This requires that a few more state bits become global. --- src/intel/tools/aubinator.c | 51 + 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index 276ea75..60aead8 100644 --- a/

[Mesa-dev] [PATCH 2/4] intel/aubinator: Rework handling of the --gen flag

2016-11-23 Thread Jason Ekstrand
This makes it just store the pci_id instead of a struct pointer --- src/intel/tools/aubinator.c | 36 1 file changed, 16 insertions(+), 20 deletions(-) diff --git a/src/intel/tools/aubinator.c b/src/intel/tools/aubinator.c index abade45..276ea75 100644 --- a/s

[Mesa-dev] [PATCH 1/4] intel/aubinator: Trust the packet size in the header for SUBOPCODE_HEADER

2016-11-23 Thread Jason Ekstrand
We were reading from the "comment size" dword and incrementing by that amount. This never caused a problem because that field was always zero. However, experimenting with actual aub file comments indicates, the simulator seems to include the comment size in the packet size provided in the header.

[Mesa-dev] [PATCH 3/3] aubdump: Add a PCI-ID= entry to the AUB file comment

2016-11-23 Thread Jason Ekstrand
--- tools/aubdump.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index b207aef..6715a5d 100644 --- a/tools/aubdump.c +++ b/tools/aubdump.c @@ -185,10 +185,16 @@ static void write_header(void) { char app_name[8 * 4]; +

[Mesa-dev] [PATCH 1/3] Revert "aubdump: Bump the GTT size to 256MB"

2016-11-23 Thread Jason Ekstrand
This reverts commit c6191a41f6c858cbdd4280e9ffcc91170e87ebeb. It turns out that having a GTT that large causes the simulator massive headaches. --- tools/aubdump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index 8904255..b1c46e2 10

[Mesa-dev] [PATCH 2/3] aubdump: Set the application name

2016-11-23 Thread Jason Ekstrand
This will help with identifying aub files --- tools/aubdump.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index b1c46e2..b207aef 100644 --- a/tools/aubdump.c +++ b/tools/aubdump.c @@ -184,14 +184,18 @@ gtt_size(void) static void w

Re: [Mesa-dev] EGL/android: pbuffer implementation.

2016-11-23 Thread Long, Zhifang
Hi Tomasz, Got your requirement. So what you want is below behavior : "droid_image_get_buffers() will not clear image_mask to 0, and only set the bit when corresponding allocation succeed. If some bit is not support, just silently ignore instead of directly return

[Mesa-dev] [PATCH] radv: fix texel fetch offset with 2d arrays.

2016-11-23 Thread Dave Airlie
From: Dave Airlie The code didn't limit the offsets to the number supplied, so if we expected 3 but only got 2 we were accessing undefined memory. This fixes random failures in: dEQP-VK.glsl.texture_functions.texelfetchoffset.sampler2darray_* Signed-off-by: Dave Airlie --- src/amd/common/ac_n

Re: [Mesa-dev] EGL/android: pbuffer implementation.

2016-11-23 Thread Tomasz Figa
On Thu, Nov 24, 2016 at 12:00 PM, Tomasz Figa wrote: > Hi Zhifang, > > On Thu, Nov 24, 2016 at 11:39 AM, Long, Zhifang > wrote: >>> >> > @@ -353,6 +353,18 @@ droid_destroy_surface(_EGLDriver *drv, >>> >> _EGLDisplay *disp, _EGLSurface *surf) >>> >> >dri2_surf->window->common.decRef(&dri2

Re: [Mesa-dev] EGL/android: pbuffer implementation.

2016-11-23 Thread Tomasz Figa
Hi Zhifang, On Thu, Nov 24, 2016 at 11:39 AM, Long, Zhifang wrote: >> >> > @@ -353,6 +353,18 @@ droid_destroy_surface(_EGLDriver *drv, >> >> _EGLDisplay *disp, _EGLSurface *surf) >> >> >dri2_surf->window->common.decRef(&dri2_surf->window- >> >common); >> >> > } >> >> > >> >> > + if

[Mesa-dev] [PATCH] anv/gen7: only enable dual-source blending when there are dual-source factors

2016-11-23 Thread Ilia Mirkin
Apparently the hw wedges otherwise, as mentioned in i965 comments. Reported-by: Emmanuel Gil Peyrot Signed-off-by: Ilia Mirkin --- src/intel/vulkan/genX_pipeline.c | 36 +--- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/genX_pip

Re: [Mesa-dev] [PATCH] util: fix memory leak from the fragment shaders for SINT <-> UINT blits

2016-11-23 Thread Brian Paul
Looks good. Reviewed-by: Brian Paul On Wed, Nov 23, 2016 at 6:33 PM, Charmaine Lee wrote: > This patch deletes those fragment shaders in util_blitter_destroy(). > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 3:32 PM, Rowley, Timothy O wrote: > Ah, didn’t notice that they were all shifted by arrayIndex. Fine to leave > the changes as they are, then. > > This series of four patches (or rather, the rebased versions in your repo) > are Reviewed-by: Tim Rowley Thanks, pushed! Yo

[Mesa-dev] [PATCH] util: fix memory leak from the fragment shaders for SINT <-> UINT blits

2016-11-23 Thread Charmaine Lee
This patch deletes those fragment shaders in util_blitter_destroy(). --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 98b5421..45dc033 100644 --- a/s

Re: [Mesa-dev] [PATCH] radv: enable sample shading

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 7:51 PM, Dave Airlie wrote: > From: Dave Airlie > > This calculates ps_iter_samples from the minSampleShading input > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_device.c | 2 +- > src/amd/vulkan/radv_pipeline.c | 6 -- > 2 files changed, 5 insertions(

Re: [Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-23 Thread Boyan Ding
2016-11-24 7:01 GMT+08:00 Derek Foreman : > This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e > except for i915. > > Original log for the i965 commit follows: > > Some application, such as drm backend of weston, uses XRGB config as > default. i965 doesn't provide this format,

[Mesa-dev] [PATCH] radv: enable sample shading

2016-11-23 Thread Dave Airlie
From: Dave Airlie This calculates ps_iter_samples from the minSampleShading input Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_device.c | 2 +- src/amd/vulkan/radv_pipeline.c | 6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_device.c b/src/a

Re: [Mesa-dev] [PATCH] radv/si: fix optimal micro tile selection

2016-11-23 Thread Edward O'Callaghan
Ah yes, Reviewed-by: Edward O'Callaghan On 11/24/2016 11:04 AM, Dave Airlie wrote: > From: Dave Airlie > > The same fix was posted for radeonsi, so port it here. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_image.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 delet

[Mesa-dev] [PATCH 2/2] radv: set spi_baryc_cntl.pos_float_location to 0

2016-11-23 Thread Dave Airlie
From: Dave Airlie This fixes: dEQP-VK.pipeline.multisample_interpolation.offset_interpolate_at_sample_position.* This should probably be 2 when sample shading is enabled, but I'm not sure. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+),

[Mesa-dev] [PATCH 1/2] radv: force persample shading when required.

2016-11-23 Thread Dave Airlie
From: Dave Airlie We need to force persample shading when a) shader uses sample_id b) shader uses sample_position c) shader uses sample qualifier. Also since ps_iter_samples can now change independently of the rasterizer samples we need to move setting the regs more often. This fixes: dEQP-VK.p

[Mesa-dev] [PATCH] radv/si: fix optimal micro tile selection

2016-11-23 Thread Dave Airlie
From: Dave Airlie The same fix was posted for radeonsi, so port it here. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_image.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index c3d125b..eb73f9

Re: [Mesa-dev] [PATCH 04/10] egl: add EGL_ANDROID_native_fence_sync

2016-11-23 Thread Chad Versace
On Fri 18 Nov 2016, Rob Clark wrote: > From: Rob Clark > > With fixes from Chad squashed in, plus fixes for issues that Rafael > found while writing piglit tests. > > Cc: Chad Versace > Cc: Rafael Antognolli > Signed-off-by: Rob Clark > --- > src/egl/drivers/dri2/egl_dri2.c | 58 > +

Re: [Mesa-dev] [PATCH 03/10] dri: extend fence extension to support native fd fences

2016-11-23 Thread Chad Versace
Patches 1-3 are Reviewed-by: Chad Versace Tested-by: Chad Versace I tested them with Rafael's Piglit tests and my in-flight i965 patches. However, patch 4 causes one of Rafael's tests to segfault. I've replied to patch 4 separately. ___ mesa-dev mailin

Re: [Mesa-dev] [PATCH 1/2] radv/meta: just local vars for src/dst subresources.

2016-11-23 Thread Bas Nieuwenhuizen
For the series: Reviewed-by: Bas Nieuwenhuizen On Thu, Nov 24, 2016 at 12:40 AM, Dave Airlie wrote: > From: Dave Airlie > > This is just a cleanup before I rework this code to fix mirrored > blits. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_meta_blit.c | 18 ++

[Mesa-dev] [PATCH 2/2] radv: fix flipped blits

2016-11-23 Thread Dave Airlie
From: Dave Airlie This fixes: dEQP-VK.api.copy_and_blit.blit_image.simple_tests.mirror* Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit.c | 168 ++-- 1 file changed, 111 insertions(+), 57 deletions(-) diff --git a/src/amd/vulkan/radv_meta_blit.

[Mesa-dev] [PATCH 1/2] radv/meta: just local vars for src/dst subresources.

2016-11-23 Thread Dave Airlie
From: Dave Airlie This is just a cleanup before I rework this code to fix mirrored blits. Signed-off-by: Dave Airlie --- src/amd/vulkan/radv_meta_blit.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/amd/vulkan/radv_meta_blit.c b/src/amd/vulkan/radv

[Mesa-dev] [PATCH] i915: Add XRGB8888 format to intel_screen_make_configs

2016-11-23 Thread Derek Foreman
This is a copy of commit 536003c11e4cb1172c540932ce3cce06f03bf44e except for i915. Original log for the i965 commit follows: Some application, such as drm backend of weston, uses XRGB config as default. i965 doesn't provide this format, but before commit 65c8965d, the drm platform of EGL t

[Mesa-dev] [PATCH v2] gbm/drm: Pick the oldest available buffer in get_back_bo

2016-11-23 Thread Derek Foreman
Applications may query the back buffer age to efficiently perform partial updates. Generally the application will keep a fixed length damage history, and use this to calculate what needs to be redrawn based on the age of the back buffer it's about to render to. If presented with a buffer that has

[Mesa-dev] [PATCH] radv: Simple inter stage shader optimization

2016-11-23 Thread Bas Nieuwenhuizen
Remove vs exports if the ps doesn't use them. Longer term we will probably want to do the optimizations between stages in nir, but this seems simple enough for the short term. Signed-off-by: Bas Nieuwenhuizen --- src/amd/common/ac_nir_to_llvm.c | 3 ++- src/amd/common/ac_nir_to_llvm.h | 1 +

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

2016-11-23 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 11:37 AM > To: Kyriazis, George ; Jose Fonseca > > Cc: ML mesa-dev > Subject: Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and > GALLIU

[Mesa-dev] [PATCH] nir: print var binding in dumps.

2016-11-23 Thread Dave Airlie
From: Dave Airlie This only useful for spir-v shaders, but I keep finding myself having to add it. Signed-off-by: Dave Airlie --- src/compiler/nir/nir_print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_print.c b/src/compiler/nir/nir_print.c index e

Re: [Mesa-dev] [PATCH] radv: Don't generate radv_timestamp.h

2016-11-23 Thread Dave Airlie
On 24 November 2016 at 05:07, Bas Nieuwenhuizen wrote: > Not needed anymore. > > Signed-off-by: Bas Nieuwenhuizen Reviewed-by: Dave Airlie ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-de

[Mesa-dev] [PATCH 4/5] radv: add support for VK_AMD_draw_indirect_count

2016-11-23 Thread Fredrik Höglund
--- src/amd/vulkan/radv_cmd_buffer.c | 94 ++-- src/amd/vulkan/radv_device.c | 4 ++ 2 files changed, 84 insertions(+), 14 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 824f9d8..d1e4deb 100644 --- a/src

[Mesa-dev] [PATCH 3/5] radv: add support for VK_AMD_negative_viewport_height

2016-11-23 Thread Fredrik Höglund
The driver already supports this extension in practice. --- src/amd/vulkan/radv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 0d79eee..58484bd 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_de

[Mesa-dev] [PATCH 5/5] radv: use the marketing name in the deviceName string

2016-11-23 Thread Fredrik Höglund
This bumps the libdrm requirement to 2.4.72. --- configure.ac | 2 +- src/amd/vulkan/radv_radeon_winsys.h | 2 +- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.c | 43 +-- 3 files changed, 26 insertions(+), 21 deletions(-)

[Mesa-dev] [PATCH 0/5] Random radv patches

2016-11-23 Thread Fredrik Höglund
These are some random patches for radv. The first adds support for anisotropic filtering on SI/CIK. Note that this patch has not been tested. Patches 2-4 add support for extensions; two of which are already supported in practice, and one that's trivial to implement. One thing I noticed is that

[Mesa-dev] [PATCH 1/5] radv: add support for anisotropic filtering on SI-CI

2016-11-23 Thread Fredrik Höglund
Ported from radeonsi. Note that si_make_texture_descriptor() already sets img7 to the mask value referred to in the comment. --- src/amd/common/ac_nir_to_llvm.c | 31 +++ src/amd/vulkan/radv_device.c| 11 ++- 2 files changed, 33 insertions(+), 9 deletions(-

[Mesa-dev] [PATCH 2/5] radv: add support for VK_KHR_sampler_mirror_clamp_to_edge

2016-11-23 Thread Fredrik Höglund
radv_tex_wrap() already supports VK_SAMPLER_ADDRESS_MODE_MIRROR_CLAMP_TO_EDGE, so all that's needed is to advertise support for the extension. --- src/amd/vulkan/radv_device.c | 4 1 file changed, 4 insertions(+) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index

Re: [Mesa-dev] [PATCH 2/6] intel/blorp_blit: Split blorp blits if they are too large

2016-11-23 Thread Jason Ekstrand
On Tue, Nov 22, 2016 at 7:03 PM, Jordan Justen wrote: > We rename do_blorp_blit() to try_blorp_blit(), and add a return error > if the surface size for the blit is too large. Now, do_blorp_blit() is > rewritten to try to split the blit into smaller operations if > try_blorp_blit() fails. > > Note

Re: [Mesa-dev] [v2 08/17] i965: Add plumbing for fast clear layer/level details

2016-11-23 Thread Jason Ekstrand
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Until now fast clear has been supported only for non-layered and > non-mipmapped buffers. However, from gen8 onwards there is hardware > support also for layered/mipmapped. Once this is enabled, fast clear > o

Re: [Mesa-dev] [PATCH] i965: Fix a mistake from porting the URB allocation code to arrays.

2016-11-23 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Fix a mistake from porting the URB allocation code to arrays.

2016-11-23 Thread Kenneth Graunke
Commit 6d416bcd846a49414f210cd761789156c37a7b3e (i965: Use arrays in Gen7+ URB code.) introduced a regression which caused us to fail to allocate all of our URB space. - total_wants -= ds_wants; + total_wants -= additional; The new line should have been total_wants -= wants[

Re: [Mesa-dev] [v2 14/17] i965: Use ISL for CCS layouts

2016-11-23 Thread Jason Ekstrand
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > One can now also delete intel_get_non_msrt_mcs_alignment(). > > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 138 > +++--- > src/mesa/drivers/dr

Re: [Mesa-dev] [v2 11/17] i965: Track fast color clear state in level/layer granularity

2016-11-23 Thread Jason Ekstrand
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > v2: Added intel_resolve_map_clear() into intel_miptree_release() > > Signed-off-by: Topi Pohjolainen > Reviewed-by: Jason Ekstrand (v1) > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 64 > +

Re: [Mesa-dev] [PATCH 0/2] A couple of fixes related to glGetTextureImage

2016-11-23 Thread Nicolai Hähnle
Series is: Reviewed-by: Nicolai Hähnle On 23.11.2016 17:10, Eduardo Lima Mitev wrote: This mini-series addresses a couple of issues I found while fixing CTS test 'GL45-CTS.direct_state_access.textures_image_query_errors' on i965/BDW, which currently crashes the driver. There is a little issue

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Rowley, Timothy O
Ah, didn’t notice that they were all shifted by arrayIndex. Fine to leave the changes as they are, then. This series of four patches (or rather, the rebased versions in your repo) are Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Nov 23, 2016, at 2:11 PM, Ilia Mirkin mailto

Re: [Mesa-dev] [PATCH v2] scons: Recognize LLVM_CONFIG environment variable.

2016-11-23 Thread Jose Fonseca
On 23/11/16 20:09, Vinson Lee wrote: Signed-off-by: Vinson Lee Reviewed-by: Emil Velikov --- v2 Use LLVM_CONFIG for swr too. Update common.py. Use local variable llvm_config instead of env['LLVM_CONFIG']. common.py | 2 +- scons/llvm.py | 17

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 3:02 PM, Rowley, Timothy O wrote: > This code seems to assume that all attached buffers have the same start > layer, and that start will be zero. Maybe it should construct the clearMask > inside the layer loop, which would also be a bit clearer than the code you > added

[Mesa-dev] [PATCH v2] scons: Recognize LLVM_CONFIG environment variable.

2016-11-23 Thread Vinson Lee
Signed-off-by: Vinson Lee Reviewed-by: Emil Velikov --- v2 Use LLVM_CONFIG for swr too. Update common.py. Use local variable llvm_config instead of env['LLVM_CONFIG']. common.py | 2 +- scons/llvm.py | 17 + src/gallium/drivers/swr/

Re: [Mesa-dev] [v2 02/17] i965/blorp: Skip redundant re-fast clear for non-compressed

2016-11-23 Thread Jason Ekstrand
On Wed, Nov 23, 2016 at 10:16 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Nov 23, 2016 at 09:05:39AM -0800, Jason Ekstrand wrote: > >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen > ><[1]topi.pohjolai...@gmail.com> wrote: > > > > Originally re-clears where

Re: [Mesa-dev] [PATCH 4/4] swr: clear every layer of the attached surfaces

2016-11-23 Thread Rowley, Timothy O
This code seems to assume that all attached buffers have the same start layer, and that start will be zero. Maybe it should construct the clearMask inside the layer loop, which would also be a bit clearer than the code you added to drop bits out of the mask? -Tim > On Nov 17, 2016, at 6:51 PM

Re: [Mesa-dev] [v2 04/17] i965: Provide slice details to color resolver

2016-11-23 Thread Jason Ekstrand
On Wed, Nov 23, 2016 at 10:13 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Wed, Nov 23, 2016 at 09:26:29AM -0800, Jason Ekstrand wrote: > >General comment: Does it make sense to squash this with the previous > >patch? I'm fine either way. > >On Wed, Nov 23, 2016 at

Re: [Mesa-dev] [PATCH 1/4] swr: [rasterizer core] actually perform clear before store in GetHotTile

2016-11-23 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Nov 17, 2016, at 6:51 PM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: When switching render target array indexes (as might happen in a GS, or in a future change, with layered clears), if the previous state is HOTTILE_CLEAR, we

Re: [Mesa-dev] [PATCH 3/4] swr: [rasterizer core] pipe renderTargetArrayIndex through to clears

2016-11-23 Thread Rowley, Timothy O
Reviewed-by: Tim Rowley mailto:timothy.o.row...@intel.com>> On Nov 17, 2016, at 6:51 PM, Ilia Mirkin mailto:imir...@alum.mit.edu>> wrote: Currently clears only operate on the 0th array index (ignoring surface layout parameters). Instead normalize to take a RTAI like all the load/store tile logi

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

2016-11-23 Thread Dave Airlie
On 23 November 2016 at 21:13, Mike Lothian wrote: > I think it would be good to keep the DRI_PRIME switch to allow for switching > between anvil and radv, handy for testing / comparing / benchmarking both > > It seems that Vulkan automatically uses the first card listed in vulkaninfo > (in my case

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

2016-11-23 Thread Dave Airlie
On 23 November 2016 at 20:46, Nicolai Hähnle wrote: > On 23.11.2016 06:28, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This is kind of a gross hacks, but vulkan doesn't specify anything >> but it would be nice to let people with prime systems at least >> see some stuff rendering for now. >>

Re: [Mesa-dev] [PATCH] scons: Recognize LLVM_CONFIG environment variable.

2016-11-23 Thread Jose Fonseca
On 23/11/16 01:23, Vinson Lee wrote: Signed-off-by: Vinson Lee --- scons/llvm.py | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/scons/llvm.py b/scons/llvm.py index 977e47a..a27bf00 100644 --- a/scons/llvm.py +++ b/scons/llvm.py @@ -194,11 +194,16 @@ def

[Mesa-dev] [PATCH] radv: Don't generate radv_timestamp.h

2016-11-23 Thread Bas Nieuwenhuizen
Not needed anymore. Signed-off-by: Bas Nieuwenhuizen --- src/amd/vulkan/Makefile.am | 6 +- src/amd/vulkan/Makefile.sources | 3 +-- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/amd/vulkan/Makefile.am b/src/amd/vulkan/Makefile.am index c559a95..3f9b53e 100644 --- a

Re: [Mesa-dev] [RFC PATCH] anv: implement pipeline statistics queries

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 1:52 PM, Ilia Mirkin wrote: > The strategy is to just keep n anv_query_pool_slot entries per query > instead of one. The available bit is only valid in the last one. > > Signed-off-by: Ilia Mirkin > --- > > This was lightly tested with this patch to the vulkan loader cube.

[Mesa-dev] [RFC PATCH] anv: implement pipeline statistics queries

2016-11-23 Thread Ilia Mirkin
The strategy is to just keep n anv_query_pool_slot entries per query instead of one. The available bit is only valid in the last one. Signed-off-by: Ilia Mirkin --- This was lightly tested with this patch to the vulkan loader cube.c: http://pastie.org/private/fe92867hwhxu7fzjw9pvzq Flipping it

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98831 --- Comment #6 from Christoph Haag --- This was my test case for the same problem: https://gist.github.com/ChristophHaag/661be992429b451218e9ee1fb0eacdec The problematic calls being ImageView.setTranslateX() and ImageView.setTranslateY() and per

Re: [Mesa-dev] [PATCH] [rfc] radv: add initial prime support.

2016-11-23 Thread Mike Lothian
It works with the Talos Principle and performs well, I'm seeing some artefacts in the grass which can be seen in https://imgur.com/a/3litB I'm not sure if that's caused by one of the LLVM bugs that have been mentioned On Wed, 23 Nov 2016 at 11:13 Mike Lothian wrote: > I think it would be good to

Re: [Mesa-dev] [PATCH 2/3] radv: Use library mtime for cache UUID.

2016-11-23 Thread Bas Nieuwenhuizen
On Tue, Nov 22, 2016 at 2:31 PM, Emil Velikov wrote: > On 22 November 2016 at 01:19, Bas Nieuwenhuizen > wrote: >> We want to also invalidate the cache when LLVM gets changed. As the >> specific LLVM revision is not fixed at build time, we will need to >> check at runtime. Computing a checksum f

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 Daniel Stone changed: What|Removed |Added CC||dan...@fooishbar.org --- Comment #1 from

Re: [Mesa-dev] [v2 04/17] i965: Provide slice details to color resolver

2016-11-23 Thread Pohjolainen, Topi
On Wed, Nov 23, 2016 at 09:26:29AM -0800, Jason Ekstrand wrote: >General comment: Does it make sense to squash this with the previous >patch? I'm fine either way. >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > Signed-off-by: Top

Re: [Mesa-dev] [v2 02/17] i965/blorp: Skip redundant re-fast clear for non-compressed

2016-11-23 Thread Pohjolainen, Topi
On Wed, Nov 23, 2016 at 09:05:39AM -0800, Jason Ekstrand wrote: >On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen ><[1]topi.pohjolai...@gmail.com> wrote: > > Originally re-clears where skipped but when lossless compression > was introduced the re-clears where errorneously enable

Re: [Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

2016-11-23 Thread Emil Velikov
On 23 November 2016 at 16:14, George Kyriazis wrote: > --- > src/gallium/targets/libgl-gdi/SConscript | 1 + > src/gallium/targets/libgl-gdi/libgl_gdi.c | 4 > 2 files changed, 5 insertions(+) > > diff --git a/src/gallium/targets/libgl-gdi/SConscript > b/src/gallium/targets/libgl-gdi/SCons

[Mesa-dev] [Bug 98833] [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98833 Bug ID: 98833 Summary: [REGRESSION, bisected] Wayland revert commit breaks fullscreen frame updates Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [v2 04/17] i965: Provide slice details to color resolver

2016-11-23 Thread Jason Ekstrand
General comment: Does it make sense to squash this with the previous patch? I'm fine either way. On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Signed-off-by: Topi Pohjolainen > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 15 +-- >

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98831 --- Comment #5 from Eero Tamminen --- (In reply to Itai from comment #3) > The problem disappears completely when using SW rendering in Java > (-Dprism.order=sw), which as far as I understand surpasses Mesa, but I'm not > sure. It's not using M

Re: [Mesa-dev] [v2 02/17] i965/blorp: Skip redundant re-fast clear for non-compressed

2016-11-23 Thread Jason Ekstrand
On Wed, Nov 23, 2016 at 1:16 AM, Topi Pohjolainen < topi.pohjolai...@gmail.com> wrote: > Originally re-clears where skipped but when lossless compression > was introduced the re-clears where errorneously enabled also for > non-compressed fast clears. > > Signed-off-by: Topi Pohjolainen > CC: Ben

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Kyriazis, George
Thanks, I'll update the docs explaining the *-By: a bit better and send it out for review. George > -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ilia Mirkin > Sent: Wednesday, November 23, 2016 10:59 AM > To: Kyriazis, George > Cc:

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 11:10 AM, Kyriazis, George wrote: > >> -Original Message- >> From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On >> Behalf Of Emil Velikov >> Sent: Wednesday, November 23, 2016 10:02 AM >> To: Ilia Mirkin >> Cc: Kyriazis, George ; ML mesa-dev > d...@l

Re: [Mesa-dev] [PATCH] gallium: create a debug screen wrapper around swrast screens

2016-11-23 Thread Emil Velikov
On 20 November 2016 at 16:28, Ilia Mirkin wrote: > Thanks Marek. > > Emil, I'd appreciate it if you could have a look as well. I believe > you were the last to touch these helpers. I'm highly confused by the > flow of things, and mainly want to ensure that we don't warp the same > screen *twice*.

[Mesa-dev] [PATCH] gdi: Add GALLIUM_TRACE and GALLIUM_RBUG to gdi

2016-11-23 Thread George Kyriazis
--- src/gallium/targets/libgl-gdi/SConscript | 1 + src/gallium/targets/libgl-gdi/libgl_gdi.c | 4 2 files changed, 5 insertions(+) diff --git a/src/gallium/targets/libgl-gdi/SConscript b/src/gallium/targets/libgl-gdi/SConscript index d3251ca..adb3581 100644 --- a/src/gallium/targets/libgl

Re: [Mesa-dev] [PATCH 3/3] glsl/cache/tests: Cast cache_get result to avoid compiler warning

2016-11-23 Thread Aaron Watry
On Tue, Nov 22, 2016 at 8:27 PM, Aaron Watry wrote: > > > On Tue, Nov 22, 2016 at 2:48 PM, Matt Turner wrote: > >> On 11/22, Aaron Watry wrote: >> >>> disk_cache_get returns void*, but we were storing/comparing a char*. >>> >>> Signed-off-by: Aaron Watry >>> --- >>> Note that this did, and stil

[Mesa-dev] [PATCH 0/2] A couple of fixes related to glGetTextureImage

2016-11-23 Thread Eduardo Lima Mitev
This mini-series addresses a couple of issues I found while fixing CTS test 'GL45-CTS.direct_state_access.textures_image_query_errors' on i965/BDW, which currently crashes the driver. There is a little issue with the test itself, for which I submitted a fix too, but these two patches should get ev

[Mesa-dev] [PATCH 2/2] mesa/getteximage: Add validation of target to glGetTextureImage

2016-11-23 Thread Eduardo Lima Mitev
There is an specific list of texture targets that can be used with glGetTextureImage. From OpenGL 4.5 spec, section '8.11 Texture Queries', page 234 of the PDF states: "An INVALID_ENUM error is generated if the effective target is not one of TEXTURE_1D , TEXTURE_2D , TEXTURE_3D , TEXTURE_1D

[Mesa-dev] [PATCH 1/2] main/texobj: Check that texture id > 0 before looking it up in hash-table

2016-11-23 Thread Eduardo Lima Mitev
_mesa_lookup_texture_err() is not currently checking that the texture-id can be zero, but _mesa_HashLookup() doesn't expect the key to be zero, and will fail an assertion (crashing the driver on debug mode). Considering that _mesa_lookup_texture_err() is called from _mesa_GetTextureImage and _mesa

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Kyriazis, George
> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Emil Velikov > Sent: Wednesday, November 23, 2016 10:02 AM > To: Ilia Mirkin > Cc: Kyriazis, George ; ML mesa-dev d...@lists.freedesktop.org> > Subject: Re: [Mesa-dev] [PATCH v4 09/10] ga

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Emil Velikov
On 23 November 2016 at 15:39, Ilia Mirkin wrote: > On Wed, Nov 23, 2016 at 10:20 AM, Kyriazis, George > wrote: >> Thanks Emil, >> >> One thing that I am clear about is: what is the difference between >> Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, >> however in the docu

[Mesa-dev] [PATCH] docs: fix minor edits and reviewer suggestions

2016-11-23 Thread George Kyriazis
--- docs/submittingpatches.html | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index 2d18c74..be49a2e 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -41,7 +41,7 @@ components. git bise

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Ilia Mirkin
On Wed, Nov 23, 2016 at 10:20 AM, Kyriazis, George wrote: > Thanks Emil, > > One thing that I am clear about is: what is the difference between > Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, however > in the documentation they are worded as if they mean different things.

Re: [Mesa-dev] [PATCH v4 09/10] gallium: swr: Added swr build for windows

2016-11-23 Thread Kyriazis, George
Thanks Emil, One thing that I am clear about is: what is the difference between Reviewed-by:, Acked-by:, etc. It sounds like they do the same thing, however in the documentation they are worded as if they mean different things. I will also suggest some edits and send out a diff for review. Ge

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98831 --- Comment #4 from Itai --- Replaying with Apitrace does not exhibit the problem. Additionally, it seems to perform altogether much better, hardly taxing my CPU, while the original seems to constantly use up a whole core (~24% CPU usage). Sin

Re: [Mesa-dev] [PATCH] anv: fix enumeration of properties

2016-11-23 Thread Emil Velikov
On 23 November 2016 at 07:51, Iago Toral wrote: > Hey Emil, > > On Thu, 2016-10-06 at 14:12 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> Driver should enumerate only up-to min2(num_available, num_requested) >> properties and return VK_INCOMPLETE if the # of requested props is >> smaller

[Mesa-dev] [Bug 98831] Constantly increasing memory consumption in JavaFX applications

2016-11-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98831 --- Comment #3 from Itai --- I'm running on Intel HD4000 graphics (i5-3210M integrated GPU). I believe I'm using the i965 driver, or whatever is the default on Debian systems. Here are what I believe to be the relevant lines from my Xorg.log fi

  1   2   >