This patch adds missing error-checking and fixes resource leak in
allocation failure path on anv_CreateDevice()
v2: Fixes from Jason Ekstrand's review
a) Add missing destructors for all of the state pools on allocation
failure path
b) Add missing destructor for batch bo pools on
This fixes a "discards const" warning since blend is const.
---
src/intel/vulkan/genX_pipeline.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c
index cb164ad..86dd647 100644
---
We add units to isl_surf_get_row_pitch, add a version that gets the pitch
in tiles, and assert that row and array pitch helpers that work in units of
surface elements only work on linear surfaces.
---
src/intel/isl/isl.h | 20 ++--
1 file changed, 18 insertions(+), 2 deletions(-)
---
src/intel/isl/isl_surface_state.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/intel/isl/isl_surface_state.c
b/src/intel/isl/isl_surface_state.c
index 3bb0abd..27468b3 100644
--- a/src/intel/isl/isl_surface_state.c
+++
It's not used on gen8+ so it causes unused function warnings.
---
src/intel/vulkan/genX_pipeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c
index 86dd647..845d020 100644
---
The 1-D special case doesn't actually apply to depth or HiZ. I discovered
this while converting BLORP over to genxml and ISL. The reason is that the
1-D special case only applies to the new Sky Lake 1-D layout which is only
used for LINEAR 1-D images. For tiled 1-D images, such as depth
drp... This should have been two patches... I'll resend
On Fri, Nov 25, 2016 at 10:13 PM, Jason Ekstrand
wrote:
> The 1-D special case doesn't actually apply to depth or HiZ. I discovered
> this while converting BLORP over to genxml and ISL. The reason is that the
> 1-D
The 1-D special case doesn't actually apply to depth or HiZ. I discovered
this while converting BLORP over to genxml and ISL. The reason is that the
1-D special case only applies to the new Sky Lake 1-D layout which is only
used for LINEAR 1-D images. For tiled 1-D images, such as depth
Reviewed-by: Jason Ekstrand
On Thu, Nov 24, 2016 at 12:30 PM, Emil Velikov
wrote:
> From: Emil Velikov
>
> brw_compiler_create() rzalloc-ates memory which we forgot to free.
>
> Cc: "13.0"
Reviewed-by: Jason Ekstrand
On Fri, Nov 25, 2016 at 6:34 AM, Mun Gwan-gyeong wrote:
> This updates releasing of resource in reverse order of the anv_CreateDevice
> to anv_DestroyDevice.
> And it fixes resource leak in pthread_mutex, pthread_cond,
On Fri, Nov 25, 2016 at 6:34 AM, Mun Gwan-gyeong wrote:
> This patch adds missing error-checking and fixes resource leak in
> allocation failure path on anv_CreateDevice()
>
> Signed-off-by: Mun Gwan-gyeong
> ---
> src/intel/vulkan/anv_device.c | 59
Reviewed-by: Jason Ekstrand
On Fri, Nov 25, 2016 at 6:34 AM, Mun Gwan-gyeong wrote:
> anv_queue_init() always returns VK_SUCCESS, so caller does not need
> to check return value of anv_queue_init().
>
> Signed-off-by: Mun Gwan-gyeong
Reviewed-by: Jason Ekstrand
On Fri, Nov 25, 2016 at 6:34 AM, Mun Gwan-gyeong wrote:
> When the memfd_create() and u_vector_init() fail on anv_block_pool_init(),
> this patch makes to return VK_ERROR_INITIALIZATION_FAILED.
> All of initialization
On 11/25/2016 03:38 PM, Francisco Jerez wrote:
> Edward O'Callaghan writes:
>
>> Signed-off-by: Edward O'Callaghan
>> ---
>> src/gallium/state_trackers/clover/api/memory.cpp | 17 -
>>
Hi Francisco, thanks for the review..
On 11/25/2016 03:39 PM, Francisco Jerez wrote:
> Edward O'Callaghan writes:
>
>> Signed-off-by: Edward O'Callaghan
>> ---
>> src/gallium/state_trackers/clover/api/memory.cpp | 9 -
>>
Among other things, blits would clear existing SO targets which would
cause a bunch of updates from u_blitter to be missed.
Fixes fbo-scissor-blit fbo, probably among many others.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/swr_state.cpp | 2 +-
1 file changed,
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/swr/rasterizer/core/api.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/swr/rasterizer/core/api.cpp
b/src/gallium/drivers/swr/rasterizer/core/api.cpp
index 383a7ad..6c0d5dd
On Fri, Nov 25, 2016 at 3:43 PM, Kenneth Graunke wrote:
> On Friday, November 25, 2016 3:19:57 PM PST Rob Clark wrote:
>> no worries.. I can keep the reverts locally (it is marginally easier
>> than rebuilding glmark2 and I only really care until I get far enough
>> with
On Friday, November 25, 2016 3:19:57 PM PST Rob Clark wrote:
> no worries.. I can keep the reverts locally (it is marginally easier
> than rebuilding glmark2 and I only really care until I get far enough
> with $new_hw to advertise desktop gl 2.0+.. otherwise I wouldn't be
> using glmark2-es)
>
>
On Thursday, November 24, 2016 6:18:13 PM PST Emil Velikov wrote:
> From: Emil Velikov
>
> Use the generic construct instead of the currect GCC specific one.
>
> Cc: Kenneth Graunke
> Suggested-by: Kenneth Graunke
>
no worries.. I can keep the reverts locally (it is marginally easier
than rebuilding glmark2 and I only really care until I get far enough
with $new_hw to advertise desktop gl 2.0+.. otherwise I wouldn't be
using glmark2-es)
BR,
-R
On Fri, Nov 25, 2016 at 3:10 PM, Ian Romanick
When I have a computer in front of me, I can look it up, but the GLSL ES
1.00 spec is quite clear on the topic. There was a bug a couple months ago
where we discussed this to death.
On November 25, 2016 9:44:10 AM Rob Clark wrote:
hmm, that is annoying.. but is it
hmm, that is annoying.. but is it required for gles2 as well? or just
glsl 300+ shaders?
maybe if CTS wasn't required in gles2 days, that is why ever other
driver let it slide..
BR,
-R
On Fri, Nov 25, 2016 at 12:39 PM, Ian Romanick wrote:
> The glmark tests are broken
The glmark tests are broken and not our problem. The spec has always
required that precision qualifiers match. This patch is required to pass
conformance. We absolutely cannot revert it.
On November 25, 2016 6:37:47 AM Rob Clark wrote:
hmm, actually looks like we need
On Nov 24, 2016 11:19 PM, "Iago Toral" wrote:
>
> On Thu, 2016-11-24 at 16:28 -0800, Jason Ekstrand wrote:
> >
> > On Nov 24, 2016 7:12 AM, "Iago Toral" wrote:
> > >
> > > On Thu, 2016-11-24 at 14:33 +0100, Iago Toral wrote:
> > > > Hi Lionel,
> > > >
> > >
On 23 November 2016 at 22:40, Derek Foreman wrote:
> Applications may query the back buffer age to efficiently perform
> partial updates. Generally the application will keep a fixed length
> damage history, and use this to calculate what needs to be redrawn
> based on the
Hi,
Please look at:
https://github.com/glmark2/glmark2/issues/25
https://bugs.freedesktop.org/show_bug.cgi?id=97532
https://bugs.freedesktop.org/show_bug.cgi?id=97804
- Eero
On 25.11.2016 16:37, Rob Clark wrote:
hmm, actually looks like we need to revert
https://bugs.freedesktop.org/show_bug.cgi?id=98833
--- Comment #7 from Eero Tamminen ---
(In reply to Eero Tamminen from comment #3)
> They were just options in the test-suite, I'll check whether they actually
> should do something on EGL/Wayland (test-suite supports
https://bugs.freedesktop.org/show_bug.cgi?id=98833
--- Comment #6 from Eero Tamminen ---
Wrong frame ordering issue doesn't happen with (Ubuntu 16.04 version of) Gnome
Wayland, only with Weston.
The difference between them is that gnome-shell does seem to do
https://bugs.freedesktop.org/show_bug.cgi?id=98842
Emil Velikov changed:
What|Removed |Added
URL|
On 11/25/2016 03:39 PM, Mun Gwan-gyeong wrote:
> It fixes leakage of pthread_condattr resource on wsi_queue_init()
>
Good catch.
Reviewed-by: Eduardo Lima Mitev
> Signed-off-by: Mun Gwan-gyeong
> ---
> src/vulkan/wsi/wsi_common_queue.h | 1 +
> 1 file
https://bugs.freedesktop.org/show_bug.cgi?id=98842
--- Comment #3 from Emil Velikov ---
libdrm_* files are irrelevant here. libdrm.so* is the ones of interest.
Are you sure your system does not have other libdrm.so* and libdrm.pc files ?
--
You are receiving this
Reviewed-by: Ilia Mirkin
On Fri, Nov 25, 2016 at 5:07 AM, Samuel Pitoiset
wrote:
> This is not allowed for indirect accesses because the source
> GPR might be erased by a subsequent instruction (WaR hazard)
> if we don't emit a read dep bar.
>
>
Reviewed-by: Ilia Mirkin
On Fri, Nov 25, 2016 at 5:07 AM, Samuel Pitoiset
wrote:
> This will allow to use MOV instead of LD. The main advantage is
> that MOV doesn't require a read dependency barrier while LD does,
> and so this will both reduce
It fixes leakage of pthread_condattr resource on wsi_queue_init()
Signed-off-by: Mun Gwan-gyeong
---
src/vulkan/wsi/wsi_common_queue.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/vulkan/wsi/wsi_common_queue.h
b/src/vulkan/wsi/wsi_common_queue.h
index
hmm, actually looks like we need to revert
259fc505454ea6a67aeacf6cdebf1398d9947759 ("glsl/linker: Fail linking
on ES if uniform precision qualifiers don't match") too
On Fri, Nov 25, 2016 at 9:32 AM, Rob Clark wrote:
> fwiw, issue is that a bunch (all) have "precision
radv_queue_init() always returns VK_SUCCESS, so caller does not need
to check return value of radv_queue_init().
Signed-off-by: Mun Gwan-gyeong
---
src/amd/vulkan/radv_device.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
This patch adds missing error-checking and fixes resource leak in
allocation failure path on anv_CreateDevice()
Signed-off-by: Mun Gwan-gyeong
---
src/intel/vulkan/anv_device.c | 59 ---
1 file changed, 50 insertions(+), 9 deletions(-)
This updates releasing of resource in reverse order of the anv_CreateDevice
to anv_DestroyDevice.
And it fixes resource leak in pthread_mutex, pthread_cond, anv_gem_context.
Signed-off-by: Mun Gwan-gyeong
---
src/intel/vulkan/anv_device.c | 23 ++-
1 file
anv_queue_init() always returns VK_SUCCESS, so caller does not need
to check return value of anv_queue_init().
Signed-off-by: Mun Gwan-gyeong
---
src/intel/vulkan/anv_device.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
When the memfd_create() and u_vector_init() fail on anv_block_pool_init(),
this patch makes to return VK_ERROR_INITIALIZATION_FAILED.
All of initialization success on anv_block_pool_init(), it makes to return
VK_SUCCESS.
CID 1394319
v2: Fixes from Emil's review:
a) Add the return type for
fwiw, issue is that a bunch (all) have "precision mediump float;" in
frag shader, and list some uniforms in both frag and vert shader. I'm
not a spec lawyer, but pretty sure we should allow that.
note that these are all gles2 shaders (not glsl 300 or 310)
BR,
-R
On Fri, Nov 25, 2016 at 9:30
This breaks a whole bunch of gles2 glmark2 "tests"..
This reverts commit b50b82b8a553f93b4ee9ace734e4c53d5a388a35.
---
src/compiler/glsl/link_interface_blocks.cpp | 7 ++-
src/compiler/glsl/linker.cpp| 10 +-
2 files changed, 3 insertions(+), 14 deletions(-)
diff
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #10 from Itai ---
Upgraded to X.org 1.18.4 => Problem still occurs.
Upgraded to X.org 1.19.0 => Problem still occurs.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #9 from Itai ---
I have found this line in the X.org 1.18.4 change list:
> glx: avoid memory leak when using indirect rendering
and some more searching yielded [1] which seems extremely relevant.
I'll
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #8 from Christoph Haag ---
(In reply to Michel Dänzer from comment #7)
> I can't seem to reproduce any of the problems described here with radeonsi
> from current Mesa Git master and OpenJDK 8u111-b14 & OpenJFX
https://bugs.freedesktop.org/show_bug.cgi?id=91724
--- Comment #7 from Frederic Devernay ---
> echo "* fixing gl_mangle.h...
look for the script in the githup directly, don't copy-paste the above text,
which is broken.
--
You are receiving this mail because:
You are
https://bugs.freedesktop.org/show_bug.cgi?id=91724
--- Comment #6 from Frederic Devernay ---
A script that builds a mangled osmesa up to the osmesa demo program is at:
https://github.com/devernay/osmesa-install
If you just want the swrast driver, set osmesadriver=1
On 25 November 2016 at 01:22, Jonathan Gray wrote:
> On Thu, Nov 24, 2016 at 05:25:26PM +, Emil Velikov wrote:
>> Hello list,
>>
>> The candidate for the Mesa 13.0.2 is now available. Currently we have:
>> - 49 queued
>> - 4 nominated (outstanding)
>> - and 1 rejected
This is not allowed for indirect accesses because the source
GPR might be erased by a subsequent instruction (WaR hazard)
if we don't emit a read dep bar.
Signed-off-by: Samuel Pitoiset
---
.../drivers/nouveau/codegen/nv50_ir_lowering_gm107.cpp | 16
This will allow to use MOV instead of LD. The main advantage is
that MOV doesn't require a read dependency barrier while LD does,
and so this will both reduce barriers pressure and the number of
stall counts needed to read data from constant memory.
This is currently only for user uniform
On Fri, 2016-11-25 at 11:07 +1100, Timothy Arceri wrote:
> Thanks.
Thanks for your patience with the review! ☺
> Patches 7 & 8 are:
>
> Reviewed-by: Timothy Arceri
Pushing!
--
Br,
Andres
___
mesa-dev mailing list
https://bugs.freedesktop.org/show_bug.cgi?id=98842
--- Comment #2 from yjd...@gmail.com ---
(In reply to Emil Velikov from comment #1)
> Can you search through your system for the following files libdrm.so and
> libdrm.pc.
> For both, provide the exact location. And the contents in for the
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/intel/vulkan/anv_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index
From: Samuel Iglesias Gonsálvez
Currently, gen8+ supports ARB_gpu_shader_fp64 in mesa master.
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/mesa/drivers/dri/i965/brw_compiler.c | 53 +---
1 file changed, 29
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
One difference between OpenGL and Vulkan regarding 64-bit vertex
attribute types is that dvec3 and dvec4 consumes just one location in
OpenGL, while in Vulkan it consumes two locations.
Thus, in OpenGL for each dvec3/dvec4 vertex attrib we mark just one bit
in our internal inputs_read bitmap (and
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 1 +
src/compiler/spirv/vtn_private.h | 1 +
2 files changed, 2 insertions(+)
diff --git a/src/compiler/spirv/spirv_to_nir.c
From: Samuel Iglesias Gonsálvez
We use *64*_PASSTHRU formats to upload vertex attributes of 64 bits
to avoid conversions. From the BDW PRM, Volume 2d, page 586
(VERTEX_ELEMENT_STATE):
"When SourceElementFormat is set to one of the *64*_PASSTHRU
formats, 64-bit
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/nir/nir.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h
index 3e6d168..1679d89 100644
---
---
src/intel/vulkan/anv_pipeline.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/intel/vulkan/anv_pipeline.c b/src/intel/vulkan/anv_pipeline.c
index 27217b9..7c26cce 100644
--- a/src/intel/vulkan/anv_pipeline.c
+++ b/src/intel/vulkan/anv_pipeline.c
@@ -476,6 +476,7 @@
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/amd/vulkan/radv_pipeline.c| 5 +++-
src/compiler/spirv/nir_spirv.h| 5 +++-
src/compiler/spirv/spirv_to_nir.c | 54 ++-
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/vtn_glsl450.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/compiler/spirv/vtn_glsl450.c b/src/compiler/spirv/vtn_glsl450.c
index
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/vtn_variables.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/spirv/vtn_variables.c
b/src/compiler/spirv/vtn_variables.c
index
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/spirv/spirv_to_nir.c
b/src/compiler/spirv/spirv_to_nir.c
index
forgot to also CC possible interested ppl!
On 11/24/2016 11:44 AM, Tapani Pälli wrote:
Oops, commit message missed the dEQP testing results. I can add these
when committing:
On Android (running dEQP with *buffer_age*):
102 passing tests, 0 failing and 84 not supported ones
On 11/24/2016
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/vtn_variables.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/spirv/vtn_variables.c
b/src/compiler/spirv/vtn_variables.c
index
From: Samuel Iglesias Gonsálvez
SPIR-V does not have special opcodes for DF conversions. We need to identify
them by checking the bit size of the operand and the result.
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/vtn_variables.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/spirv/vtn_variables.c
b/src/compiler/spirv/vtn_variables.c
index
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 20 +++-
1 file changed, 15 insertions(+), 5 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
From: Samuel Iglesias Gonsálvez
We need to pick two 32-bit values per component to perform the right shuffle
operation.
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 25 +
1 file changed,
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 24 +---
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
Hello,
This patch series implements support for Float64 capability to SPIR-V to NIR
pass and adds the needed bits to enable it in Intel's Vulkan driver. Float64
capability is only enabled in Intel's generations that support
ARB_gpu_shader_fp64 and ARB_vertex_attrib_64bit (currently Broadwell and
From: Samuel Iglesias Gonsálvez
Signed-off-by: Samuel Iglesias Gonsálvez
---
src/compiler/spirv/spirv_to_nir.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c
https://bugs.freedesktop.org/show_bug.cgi?id=98831
--- Comment #7 from Michel Dänzer ---
I can't seem to reproduce any of the problems described here with radeonsi from
current Mesa Git master and OpenJDK 8u111-b14 & OpenJFX 8u102-b14 packages from
Debian.
--
You are
Hi Tomasz,
I submitted a new patch to enhance the pbuffer implementation.
Please check if it satisfy your requirement.
https://patchwork.freedesktop.org/patch/123848/
Thanks,
Zhiquan,
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
On Wed, 23 Nov 2016 16:40:42 -0600
Derek Foreman wrote:
> Applications may query the back buffer age to efficiently perform
> partial updates. Generally the application will keep a fixed length
> damage history, and use this to calculate what needs to be redrawn
> based
80 matches
Mail list logo