Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-06 Thread Michel Dänzer
On 06/12/16 10:24 PM, Marek Olšák wrote: > On Mon, Dec 5, 2016 at 10:05 AM, Michel Dänzer wrote: >> On 03/12/16 05:38 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and >>>

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #3 from Igor Gnatenko --- (In reply to Michel Dänzer from comment #2) > Can you bisect which commit broke it? Unfortunately it's not my bugreport. In theory, I could build RPMs for reporter, but it would

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #2 from Michel Dänzer --- Can you bisect which commit broke it? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 --- Comment #1 from Igor Gnatenko --- 00:02.0 VGA compatible controller: Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor Integrated Graphics Controller (rev 06) 01:00.0 VGA compatible controller: Advanced

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 Igor Gnatenko changed: What|Removed |Added See Also|

[Mesa-dev] [Bug 99014] clover is broken in 12.0.4

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99014 Bug ID: 99014 Summary: clover is broken in 12.0.4 Product: Mesa Version: 12.0 Hardware: Other OS: All Status: NEW Keywords: regression

Re: [Mesa-dev] [PATCH v2] EGL/android: Enhance pbuffer implementation

2016-12-06 Thread Tomasz Figa
On Tue, Dec 6, 2016 at 5:49 PM, Liu Zhiquan wrote: > Some dri drivers will pass multiple bits in buffer_mask parameter > to droid_image_get_buffer(), more than the actual supported buffer > type combination. For such case, will go through all the bits, and > will not return

Re: [Mesa-dev] [PATCH] glsl: fix ldexp lowering if bitfield insert lowering is also requested

2016-12-06 Thread Michel Dänzer
On 07/12/16 01:50 AM, Roland Scheidegger wrote: > Oops sorry for that. Looks like I changed the type of a constant > accidentally - I probably copied that bit from the original code > instead, which might have had it wrong at that time without > consequences... Should hopefully be fixed now. Yep,

Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-06 Thread Michel Dänzer
On 07/12/16 05:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The spec actually says that calling EmitStreamVertex is undefined when > you exceed max_vertices. But we do need to avoid trampling over memory > outside the GSVS ring. Why "but"? It still works up

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #12 from Mark Janes --- David: please reopen this bug if it is not fixed by libdrm 2.4.74 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 --- Comment #11 from David Rosenstrauch --- Can you please clarify? If this is resolved, then what new package release provides the fixed behavior? I'm still seeing this issue today (also on Arch Linux) and had to downgrade

Re: [Mesa-dev] [PATCH v3 3/3] vulkan: use STATIC_ASSERT instead of static_assert

2016-12-06 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Tue, Dec 6, 2016 at 3:30 PM, Edward O'Callaghan < funfunc...@folklore1984.net> wrote: > Following the spirit of commit 23d1799f, fixes compilation > warnings on Android build due to lack of C11 features. > > Signed-off-by: Edward O'Callaghan

Re: [Mesa-dev] [PATCH] nir: Only float and double types can be matrices

2016-12-06 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand Might be worth adding something to nir_validate at some point. Doesn't have to be today though. --Jason On Tue, Dec 6, 2016 at 5:32 PM, Ian Romanick wrote: > From: Ian Romanick > > In 19a541f

[Mesa-dev] [PATCH] nir: Only float and double types can be matrices

2016-12-06 Thread Ian Romanick
From: Ian Romanick In 19a541f (nir: Get rid of nir_constant_data) a number of places that operated on nir_constant::values were mechanically converted to operate on the whole array without regard for the base type. Only GLSL_TYPE_FLOAT and GLSL_TYPE_DOUBLE can be

Re: [Mesa-dev] [PATCH v2 02/25] tgsi: add Stream{X, Y, Z, W} fields to tgsi_declaration_semantic

2016-12-06 Thread Marek Olšák
On Tue, Dec 6, 2016 at 11:48 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > This is for geometry shader outputs. Without it, drivers have no way of > knowing which stream each output is intended for, and have to > conservatively write all

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-06 Thread Anuj Phogat
On Tue, Dec 6, 2016 at 4:26 PM, Anuj Phogat wrote: > On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro > wrote: >> The FIXME suggest that the check should be removed. >> > Only if we see any performance or feature benefits in doing that. > Last I

Re: [Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-06 Thread Anuj Phogat
On Tue, Dec 6, 2016 at 10:58 AM, Alejandro Piñeiro wrote: > The FIXME suggest that the check should be removed. > Only if we see any performance or feature benefits in doing that. Last I checked I didn't see any performance benefits on Skylake. I also couldn't figure out the

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #11 from Tobias Droste --- Ok, I take a look at this tomorrow (it's late here). Sorry for the problems. For a quick workaround: Set the env variable LLVM_CONFIG to "no". e.g.: LLVM_CONFIG=no ./autogen.sh ... --

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #10 from Vinson Lee --- (In reply to Tobias Droste from comment #9) > Ok now I get it. > > It says "llvm: yes" as soon as it finds LLVM that does not automatically > mean it is used by something. So this works

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #9 from Tobias Droste --- Ok now I get it. It says "llvm: yes" as soon as it finds LLVM that does not automatically mean it is used by something. So this works as expected. Maybe the output can be improved. What

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #8 from Vinson Lee --- (In reply to Tobias Droste from comment #7) > What component? Auxiliary? > > If I look at src/gallium/auxiliary/Makefile I see this: > > #am__append_3 = \ > # $(LLVM_CFLAGS) > >

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #7 from Tobias Droste --- What component? Auxiliary? If I look at src/gallium/auxiliary/Makefile I see this: #am__append_3 = \ # $(LLVM_CFLAGS) #am__append_4 = \ # $(GALLIUM_CFLAGS) \ #

[Mesa-dev] [Bug 98563] Xorg segfaults with displaylink attached and mesa version >= 13.0

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98563 David Rosenstrauch changed: What|Removed |Added CC|

[Mesa-dev] [PATCH v3 2/3] svga: Fix a strict-aliasing violation in shader dumper

2016-12-06 Thread Edward O'Callaghan
As per the C spec, it is illegal to alias pointers to different types. This results in undefined behaviour after optimization passes, resulting in very subtle bugs that happen only on a full moon.. Use a memcpy() as a well defined coercion between the isomorphic bit-field interpretations of

[Mesa-dev] [PATCH v3 3/3] vulkan: use STATIC_ASSERT instead of static_assert

2016-12-06 Thread Edward O'Callaghan
Following the spirit of commit 23d1799f, fixes compilation warnings on Android build due to lack of C11 features. Signed-off-by: Edward O'Callaghan --- src/amd/vulkan/radv_private.h | 2 +- src/vulkan/wsi/wsi_common_wayland.c | 2 +-

[Mesa-dev] [PATCH v3 1/3] virgl: Fix a strict-aliasing violation in the encoder

2016-12-06 Thread Edward O'Callaghan
As per the C spec, it is illegal to alias pointers to different types. This results in undefined behaviour after optimization passes, resulting in very subtle bugs that happen only on a full moon.. Use a memcpy() as a well defined coercion between the double to uint64_t interpretations of the

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #6 from Vinson Lee --- (In reply to Tobias Droste from comment #4) > > What error do you see? It builds with llvm. -- You are receiving this mail because: You are the QA Contact for the bug. You are the

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #5 from Tobias Droste --- Does 'git clean -fdx' fix it? Maybe a stale Makefile. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #4 from Tobias Droste --- Seems to work fine here. Odd. It builds a lot of non gallium drivers and src/gallium/drivers/softpipe without any errors. What error do you see? -- You are receiving this mail because:

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #3 from Vinson Lee --- (In reply to Tobias Droste from comment #2) > > could you tell me what configure options you're using? > ./autogen.sh --disable-gallium-llvm --with-gallium-drivers=swrast -- You are

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 --- Comment #2 from Tobias Droste --- Hi Vinson, could you tell me what configure options you're using? Thanks, Tobias -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

2016-12-06 Thread Dave Airlie
On 7 December 2016 at 08:34, Edward O'Callaghan wrote: > > > On 12/07/2016 12:36 AM, Emil Velikov wrote: >> On 6 December 2016 at 11:30, Edward O'Callaghan >> wrote: >>> As per the C spec, it is illegal to alias pointers to different >>>

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

2016-12-06 Thread Edward O'Callaghan
On 12/07/2016 12:36 AM, Emil Velikov wrote: > On 6 December 2016 at 11:30, Edward O'Callaghan > wrote: >> As per the C spec, it is illegal to alias pointers to different >> types. This results in undefined behaviour after optimization >> passes, resulting in very

Re: [Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-06 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 12/07/2016 07:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > The spec actually says that calling EmitStreamVertex is undefined when > you exceed max_vertices. But we do need to avoid trampling

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 Vinson Lee changed: What|Removed |Added Keywords||bisected

[Mesa-dev] [Bug 99010] --disable-gallium-llvm no longer recognized

2016-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99010 Bug ID: 99010 Summary: --disable-gallium-llvm no longer recognized Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords:

Re: [Mesa-dev] [PATCH v2 3/7] intel/blorp_blit: Adjust blorp surface parameters for split blits

2016-12-06 Thread Jason Ekstrand
On Wed, Nov 30, 2016 at 8:12 PM, Jordan Justen wrote: > If try_blorp_blit() previously returned that a blit was too large, > shrink_surface_params() will be used to update the surface parameters > for the smaller blit so the blit operation can proceed. > > v2: > * Use

Re: [Mesa-dev] [PATCH v2 5/7] intel/blorp_blit: Enable splitting large blorp blits

2016-12-06 Thread Jason Ekstrand
On Wed, Nov 30, 2016 at 8:12 PM, Jordan Justen wrote: > Detect when the surface sizes are too large for a blorp blit. When it > is too large, the blorp blit will be split into a smaller operation > and attempted again. > > For gen7, this fixes the cts test: > >

Re: [Mesa-dev] [PATCH v2 5/7] intel/blorp_blit: Enable splitting large blorp blits

2016-12-06 Thread Jason Ekstrand
On Wed, Nov 30, 2016 at 8:12 PM, Jordan Justen wrote: > Detect when the surface sizes are too large for a blorp blit. When it > is too large, the blorp blit will be split into a smaller operation > and attempted again. > > For gen7, this fixes the cts test: > >

Re: [Mesa-dev] [PATCH] i965: Drop redundant key->outputs_written initialization.

2016-12-06 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] i965: Initialize "separate" flag in VUE maps.

2016-12-06 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Drop redundant key->outputs_written initialization.

2016-12-06 Thread Kenneth Graunke
This was already set to the same value earlier. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_tcs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_tcs.c b/src/mesa/drivers/dri/i965/brw_tcs.c index 95926db..76cd0a5

[Mesa-dev] [PATCH] i965: Initialize "separate" flag in VUE maps.

2016-12-06 Thread Kenneth Graunke
This was uninitialized, which resulted in weird looking printouts where it appeared that the TCS output and TES input patch URB entries differed in SSO/non-SSO layout. There is no "separable" layout for both, as they're tied together. It should have no other actual effect. Signed-off-by:

Re: [Mesa-dev] [PATCH 15/18] i965: Validate "General Restrictions on Regioning Parameters"

2016-12-06 Thread Matt Turner
Ken reviewed all the easy patches, up to this point in the series. Does anyone else want to review the rest? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/2] i965/miptree: Use intel_miptree_copy for maps

2016-12-06 Thread Jason Ekstrand
What we're really doing is copying a texture not blitting it in the sense of glBlitFramebuffers. Also, the intel_miptree_copy function is capable of properly handling compressed textures which intel_miptree_blit is not. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97473 Cc: "13.0"

Re: [Mesa-dev] [PATCH 1/4] i965/fs: Rename opt_copy_propagate -> opt_copy_propagation.

2016-12-06 Thread Matt Turner
Ping. This series fixes a real bug that affects multiple games. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] i965/blit: Fix the src dimension sanity check in miptree_copy

2016-12-06 Thread Jason Ekstrand
Cc: "13.0" --- src/mesa/drivers/dri/i965/intel_blit.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_blit.c b/src/mesa/drivers/dri/i965/intel_blit.c index 03a35ee..5f0cf74 100644 ---

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2016-12-06 Thread Ilia Mirkin
On Tue, Dec 6, 2016 at 3:00 PM, Rob Clark wrote: > On Tue, Dec 6, 2016 at 2:11 PM, Jason Ekstrand wrote: >> On Tue, Dec 6, 2016 at 8:39 AM, Rob Clark wrote: >>> >>> On Tue, Dec 6, 2016 at 8:42 AM, Emil Velikov

[Mesa-dev] [PATCH] radeonsi: fix an off-by-one error in the bounds check for max_vertices

2016-12-06 Thread Nicolai Hähnle
From: Nicolai Hähnle The spec actually says that calling EmitStreamVertex is undefined when you exceed max_vertices. But we do need to avoid trampling over memory outside the GSVS ring. Cc: mesa-sta...@lists.freedesktop.org -- One more thing I noticed on top of all the

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2016-12-06 Thread Rob Clark
On Tue, Dec 6, 2016 at 2:11 PM, Jason Ekstrand wrote: > On Tue, Dec 6, 2016 at 8:39 AM, Rob Clark wrote: >> >> On Tue, Dec 6, 2016 at 8:42 AM, Emil Velikov >> wrote: >> > On 6 December 2016 at 03:16, Edward O'Callaghan >> >

[Mesa-dev] [PATCH 2/2] i965: Add i965 plumbing for ARB_post_depth_coverage for i965 (gen9+).

2016-12-06 Thread Plamena Manolova
This extension allows the fragment shader to control whether values in gl_SampleMaskIn[] reflect the coverage after application of the early depth and stencil tests. Signed-off-by: Plamena Manolova --- docs/features.txt| 2 +-

[Mesa-dev] [PATCH 1/2] mesa: Add GL and GLSL plumbing for ARB_post_depth_coverage for i965 (gen9+).

2016-12-06 Thread Plamena Manolova
This extension allows the fragment shader to control whether values in gl_SampleMaskIn[] reflect the coverage after application of the early depth and stencil tests. Signed-off-by: Plamena Manolova --- src/compiler/glsl/ast.h | 5 +

Re: [Mesa-dev] [PATCH] radeonsi: fix isolines tess factor writes to control ring

2016-12-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Dec 6, 2016 at 2:45 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Fixes piglit arb_tessellation_shader/execution/isoline{_no_tcs}.shader_test. > > Cc:

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2016-12-06 Thread Jason Ekstrand
On Tue, Dec 6, 2016 at 8:39 AM, Rob Clark wrote: > On Tue, Dec 6, 2016 at 8:42 AM, Emil Velikov > wrote: > > On 6 December 2016 at 03:16, Edward O'Callaghan > > wrote: > >> This patch is to potentially remove ourself

[Mesa-dev] [PATCH] i965/blit: Remove Yf/Ys tiled check under a FIXME at can_fast_copy_blit

2016-12-06 Thread Alejandro Piñeiro
The FIXME suggest that the check should be removed. This change helps the following test: GL45-CTS.texture_cube_map_array.color_depth_attachments to pass consistently on Skylake GT3e. Without this patch, on Skylake GT3e that test has a ~76% pass rate, with some random intel_do_flush_locked

Re: [Mesa-dev] [PATCH 1/2] configure: enable glx-tls by default

2016-12-06 Thread Emil Velikov
On 6 December 2016 at 14:36, Andreas Boll wrote: > 2016-12-05 20:02 GMT+01:00 Emil Velikov : >> From: Emil Velikov >> >> In the (not too) distant future we'd want to remove this option and >> effectively drop the

Re: [Mesa-dev] [PATCH 7/7] glx: unify GLX_SGIX_pbuffer aliased declarations

2016-12-06 Thread Emil Velikov
On 6 December 2016 at 18:08, Jeremy Huddleston Sequoia wrote: > >> On Dec 6, 2016, at 06:04, Emil Velikov wrote: >> >> On 5 December 2016 at 22:50, Jeremy Huddleston Sequoia >> wrote: >>> On Dec 5, 2016, at 11:52 AM, Emil

Re: [Mesa-dev] [PATCH] gallivm: use getHostCPUFeatures on x86/llvm-4.0+.

2016-12-06 Thread Roland Scheidegger
Ok, here is the bug: https://llvm.org/bugs/show_bug.cgi?id=31296 Roland Am 06.12.2016 um 18:47 schrieb Roland Scheidegger: > Actually I've verified this quickly with llc. > With -mattr=xop, it produces > > fetch_r32_float_float: # @fetch_r32_float_float > .cfi_startproc

Re: [Mesa-dev] [PATCH 7/7] glx: unify GLX_SGIX_pbuffer aliased declarations

2016-12-06 Thread Jeremy Huddleston Sequoia
> On Dec 6, 2016, at 06:04, Emil Velikov wrote: > > On 5 December 2016 at 22:50, Jeremy Huddleston Sequoia > wrote: >> >>> On Dec 5, 2016, at 11:52 AM, Emil Velikov wrote: >>> >>> From: Emil Velikov

Re: [Mesa-dev] [PATCH 4/6] nir/lower_tex: add lowering for texture gradient on shadow samplers

2016-12-06 Thread Eric Anholt
Kenneth Graunke writes: > [ Unknown signature status ] > On Thursday, December 1, 2016 8:53:19 AM PST Iago Toral Quiroga wrote: >> This is ported from the Intel lowering pass that we use with GLSL IR. >> This takes care of lowering texture gradients on shadow samplers

Re: [Mesa-dev] [PATCH 3/3] gallivm: optimize gather a bit, by using supplied destination type

2016-12-06 Thread Jose Fonseca
On 03/12/16 16:12, srol...@vmware.com wrote: From: Roland Scheidegger By using a dst_type in the the gather interface, gather has some more knowledge about how values should be fetched. E.g. if this is a 3x32bit fetch and dst_type is 4x32bit vector gather will no longer do

Re: [Mesa-dev] [PATCH] gallivm: use getHostCPUFeatures on x86/llvm-4.0+.

2016-12-06 Thread Roland Scheidegger
Actually I've verified this quickly with llc. With -mattr=xop, it produces fetch_r32_float_float: # @fetch_r32_float_float .cfi_startproc # BB#0: # %entry vpermilps $65, .LCPI0_0(%rip), %xmm0 # xmm0 = mem[1,0,0,1]

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2016-12-06 Thread Eric Anholt
Alex Deucher writes: > On Tue, Dec 6, 2016 at 8:42 AM, Emil Velikov wrote: >> On 6 December 2016 at 03:16, Edward O'Callaghan >> wrote: >>> This patch is to potentially remove ourself from the maintaince >>> burden

Re: [Mesa-dev] [PATCH 2/2] anv: image: report correct depthPicth for 3d images

2016-12-06 Thread Jason Ekstrand
On Tue, Dec 6, 2016 at 3:05 AM, Lionel Landwerlin wrote: > With a 3d image of 2x2x3, vkGetImageSubresourceLayout currently reports : > VkSubresourceLayout = { offset = 0, > size = 160, > rowPitch = 16, >

Re: [Mesa-dev] [PATCH 1/2] isl: introduce depth pitch query function

2016-12-06 Thread Jason Ekstrand
On Tue, Dec 6, 2016 at 3:05 AM, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/Makefile.isl.am | 10 +- > src/intel/isl/isl.c| 25 +++ >

Re: [Mesa-dev] [PATCH] glsl: fix ldexp lowering if bitfield insert lowering is also requested

2016-12-06 Thread Roland Scheidegger
Oops sorry for that. Looks like I changed the type of a constant accidentally - I probably copied that bit from the original code instead, which might have had it wrong at that time without consequences... Should hopefully be fixed now. Roland Am 06.12.2016 um 08:51 schrieb Michel Dänzer: > On

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2016-12-06 Thread Rob Clark
On Tue, Dec 6, 2016 at 8:42 AM, Emil Velikov wrote: > On 6 December 2016 at 03:16, Edward O'Callaghan > wrote: >> This patch is to potentially remove ourself from the maintaince >> burden of the ilo driver that appears to now be essentially

Re: [Mesa-dev] [PATCH] gallivm: use getHostCPUFeatures on x86/llvm-4.0+.

2016-12-06 Thread Roland Scheidegger
Interesting. Can you show the IR / assembly? I don't get any failures here. I'm wondering if it's trying to use XOP and there's some bug there (or we're relying on undefined behavior which doesn't happen to work with it). Albeit since there's not actually any conversion involved in this case

[Mesa-dev] [PATCH v4 7/7] gallium: add pipe_screen::resource_changed callback wrappers

2016-12-06 Thread Philipp Zabel
Add resource_changed to the ddebug, rbug, and trace wrappers. Since it is optional, there is no need to add it to noop. Signed-off-by: Philipp Zabel Suggested-by: Nicolai Hähnle --- src/gallium/drivers/ddebug/dd_screen.c | 10 ++

[Mesa-dev] [PATCH v4 2/7] st/dri: ask the driver to update its internal copies on reimport

2016-12-06 Thread Philipp Zabel
For imported buffers that can't be used directly as a source to the texture samplers, the pipe driver might need to create an internal copy, for example in a different tiling layout. When buffers are reimported they may contain new image data, so the driver internal copies need to be recreated.

[Mesa-dev] [PATCH v4 4/7] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

2016-12-06 Thread Philipp Zabel
Implement the resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables. Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 13

[Mesa-dev] [PATCH v4 0/7] etnaviv: update derived texture resources of (re)imported buffers

2016-12-06 Thread Philipp Zabel
Hi, to get weston / wayland_egl working on etnaviv, we need to update the texture resources derived from imported buffers every time they are re-imported. This patchset is based on the github-etnaviv/for_mainline_v1 branch and adds a new pipe_screen::resource_changed callback that is called

[Mesa-dev] [PATCH v4 6/7] st/mesa: ask pipe driver to recreate derived internal resources when (re-)binding external textures

2016-12-06 Thread Philipp Zabel
Use the resource_changed callback to invalidate internal resources derived from external textures when they are (re-)bound. This is needed to comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return

[Mesa-dev] [PATCH v4 1/7] gallium: add pipe_screen::resource_changed

2016-12-06 Thread Philipp Zabel
Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel Reviewed-by: Roland Scheidegger --- src/gallium/docs/source/screen.rst | 14 ++

[Mesa-dev] [PATCH v4 3/7] etnaviv: initialize seqno of imported resources

2016-12-06 Thread Philipp Zabel
Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if it had already been rendered to. Signed-off-by: Philipp Zabel ---

[Mesa-dev] [PATCH v4 5/7] mesa: update external textures when (re-)binding

2016-12-06 Thread Philipp Zabel
To comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return values that correspond to the values in the external texture at or after the time that glBindTexture was called, do not bail out early from

Re: [Mesa-dev] [PATCH v3 1/6] gallium: add pipe_screen::resource_changed

2016-12-06 Thread Roland Scheidegger
Thanks for fixing docs. Reviewed-by: Roland Scheidegger Am 06.12.2016 um 14:57 schrieb Philipp Zabel: > Add a hook to tell drivers that an imported resource may have changed > and they need to update their internal derived resources. > > Signed-off-by: Philipp Zabel

Re: [Mesa-dev] [PATCH 00/27] Renderbuffer Decompression (and GBM modifiers)

2016-12-06 Thread Paulo Zanoni
2016-12-01 20:09 GMT-02:00 Ben Widawsky : > From: Ben Widawsky > > This patch series ultimately adds support within the i965 driver for > Renderbuffer Decompression with GBM. In short, this feature reduces memory > bandwidth by allowing the GPU to

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2016-12-06 Thread Alex Deucher
On Tue, Dec 6, 2016 at 8:42 AM, Emil Velikov wrote: > On 6 December 2016 at 03:16, Edward O'Callaghan > wrote: >> This patch is to potentially remove ourself from the maintaince >> burden of the ilo driver that appears to now be essentially

Re: [Mesa-dev] [ANNOUNCE] mesa 12.0.5

2016-12-06 Thread Marek Olšák
Hi, I'd like to announce that this release doesn't fix the worst GPU hangs/freezes it has. I'm talking about all Gallium drivers here. There was a bug recently discovered in shared code that leads to random GPU hangs with radeonsi, but all other Gallium drivers are also affected in "some negative

Re: [Mesa-dev] [PATCH 1/2] configure: enable glx-tls by default

2016-12-06 Thread Andreas Boll
2016-12-05 20:02 GMT+01:00 Emil Velikov : > From: Emil Velikov > > In the (not too) distant future we'd want to remove this option and > effectively drop the other codepath(s) we have in our dispatch. > > Linux distributions have been using

Re: [Mesa-dev] [PATCH] EGL/android: Enhance pbuffer implementation

2016-12-06 Thread Liu, Zhiquan
I upload v2 version, please review. https://patchwork.freedesktop.org/patch/125787/ Best Regards, Zhiquan ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH v2 1/6] gallium: add pipe_screen::resource_changed

2016-12-06 Thread Nicolai Hähnle
On 05.12.2016 16:49, Philipp Zabel wrote: Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. You should probably add this to the various wrapper drivers, like trace, ddebug, etc. Nicolai Signed-off-by: Philipp

Re: [Mesa-dev] [PATCH 7/7] glx: unify GLX_SGIX_pbuffer aliased declarations

2016-12-06 Thread Emil Velikov
On 5 December 2016 at 22:50, Jeremy Huddleston Sequoia wrote: > >> On Dec 5, 2016, at 11:52 AM, Emil Velikov wrote: >> >> From: Emil Velikov >> >> No point in having an identical code in two places. >> >> Not to mention

[Mesa-dev] [PATCH v3 2/6] st/dri: ask the driver to update its internal copies on reimport

2016-12-06 Thread Philipp Zabel
For imported buffers that can't be used directly as a source to the texture samplers, the pipe driver might need to create an internal copy, for example in a different tiling layout. When buffers are reimported they may contain new image data, so the driver internal copies need to be recreated.

[Mesa-dev] [PATCH v3 6/6] st/mesa: ask pipe driver to recreate derived internal resources when (re-)binding external textures

2016-12-06 Thread Philipp Zabel
Use the resource_changed callback to invalidate internal resources derived from external textures when they are (re-)bound. This is needed to comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return

[Mesa-dev] [PATCH v3 3/6] etnaviv: initialize seqno of imported resources

2016-12-06 Thread Philipp Zabel
Imported resources already have contents that we want to be copied to texture resources derived from them. Set initial seqno of imported resources to 1, just as if it had already been rendered to. Signed-off-by: Philipp Zabel ---

[Mesa-dev] [PATCH v3 4/6] etnaviv: implement resource_changed to invalidate internal resources derived from imported buffers

2016-12-06 Thread Philipp Zabel
Implement the resource_changed pipe callback to invalidate internal resources derived from imported buffers. This is needed to update the texture for re-imported renderables. Signed-off-by: Philipp Zabel --- src/gallium/drivers/etnaviv/etnaviv_resource.c | 13

[Mesa-dev] [PATCH v3 5/6] mesa: update external textures when (re-)binding

2016-12-06 Thread Philipp Zabel
To comply with the requirement from the GL_OES_EGL_image_external extension that a call to glBindTexture guarantees that all further sampling will return values that correspond to the values in the external texture at or after the time that glBindTexture was called, do not bail out early from

[Mesa-dev] [PATCH v3 0/6] etnaviv: update derived texture resources of (re)imported buffers

2016-12-06 Thread Philipp Zabel
Hi, to get weston / wayland_egl working on etnaviv, we need to update the texture resources derived from imported buffers every time they are re-imported. This patchset is based on the github-etnaviv/for_mainline_v1 branch and adds a new pipe_screen::resource_changed callback that is called

[Mesa-dev] [PATCH v3 1/6] gallium: add pipe_screen::resource_changed

2016-12-06 Thread Philipp Zabel
Add a hook to tell drivers that an imported resource may have changed and they need to update their internal derived resources. Signed-off-by: Philipp Zabel --- Changes since v2: - Added resource_changed paragraph to screen.rst --- src/gallium/docs/source/screen.rst |

[Mesa-dev] [PATCH] radeonsi: fix isolines tess factor writes to control ring

2016-12-06 Thread Nicolai Hähnle
From: Nicolai Hähnle Fixes piglit arb_tessellation_shader/execution/isoline{_no_tcs}.shader_test. Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_shader.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] Potentially EOL ilo gallium driver

2016-12-06 Thread Emil Velikov
On 6 December 2016 at 03:16, Edward O'Callaghan wrote: > This patch is to potentially remove ourself from the maintaince > burden of the ilo driver that appears to now be essentially > unmaintained? > > I am not sure of our policy here or if there are too many > users

Re: [Mesa-dev] [PATCH] gallivm: use getHostCPUFeatures on x86/llvm-4.0+.

2016-12-06 Thread Rowley, Timothy O
Interesting. My testing was done using piglit on an avx512 capable processor, where I didn’t see any regressions. llvmpipe’s “make check” also passes for me with this change on avx2 and avx512 machines. Was this the only regression you saw? -Tim > On Dec 6, 2016, at 12:27 AM, Michel Dänzer

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

2016-12-06 Thread Emil Velikov
On 6 December 2016 at 11:30, Edward O'Callaghan wrote: > As per the C spec, it is illegal to alias pointers to different > types. This results in undefined behaviour after optimization > passes, resulting in very subtle bugs that happen only on a > full moon.. > > Use

Re: [Mesa-dev] [Mesa-announce] Mesa 12.0.5 release candidate

2016-12-06 Thread Emil Velikov
On 6 December 2016 at 13:01, Marek Olšák wrote: > On Mon, Dec 5, 2016 at 4:48 PM, Emil Velikov wrote: >> On 2 December 2016 at 21:49, Marek Olšák wrote: >>> Hi Emil, >>> >>> 7 additional nominations for 12.0 are attached: >>> - the

Re: [Mesa-dev] [PATCH 1/3] cso: don't release sampler states that are bound

2016-12-06 Thread Marek Olšák
On Mon, Dec 5, 2016 at 10:05 AM, Michel Dänzer wrote: > On 03/12/16 05:38 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> This fixes random radeonsi GPU hangs in Batman Arkham: Origins (Wine) and >> probably many other games too. >> >> cso_cache deletes

Re: [Mesa-dev] [Mesa-announce] Mesa 12.0.5 release candidate

2016-12-06 Thread Nicolai Hähnle
On 06.12.2016 14:01, Marek Olšák wrote: On Mon, Dec 5, 2016 at 4:48 PM, Emil Velikov wrote: On 2 December 2016 at 21:49, Marek Olšák wrote: Hi Emil, 7 additional nominations for 12.0 are attached: - the CSO fix is very important - the 4th patch

Re: [Mesa-dev] [Mesa-announce] Mesa 12.0.5 release candidate

2016-12-06 Thread Marek Olšák
On Mon, Dec 5, 2016 at 4:48 PM, Emil Velikov wrote: > On 2 December 2016 at 21:49, Marek Olšák wrote: >> Hi Emil, >> >> 7 additional nominations for 12.0 are attached: >> - the CSO fix is very important >> - the 4th patch fixes dual-source blending on

Re: [Mesa-dev] [PATCH v2 1/2] virgl: Fix a strict-aliasing violation in the encoder

2016-12-06 Thread Eric Engestrom
On Tuesday, 2016-12-06 22:56:54 +1100, Edward O'Callaghan wrote: > > > On 12/06/2016 10:48 PM, Eric Engestrom wrote: > > On Tuesday, 2016-12-06 22:30:58 +1100, Edward O'Callaghan wrote: > >> As per the C spec, it is illegal to alias pointers to different > >> types. This results in undefined

  1   2   >