Re: [Mesa-dev] [PATCH] util/disk_cache: remove function stubs

On 02/10/2017 03:38 AM, Timothy Arceri wrote: The option to disable shader cache was removed from the build options when we imported a sha1 implementation into Mesa. Have the issues mentioned in 9f8dc3bf03ec825bae7041858dda6ca2e9a34363 been fixed? Cc: Emil Velikov

[Mesa-dev] [PATCH] nv50/ir: convert an ATOM.EXCH without a destination into a store

On SM35 there does not appear to be a way to emit a ATOM.EXCH with a null destination. This should be functionally equivalent to a plain store however, so just do that. Fixes GL45-CTS.compute_shader.atomic-case2 on SM35. Signed-off-by: Ilia Mirkin ---

Re: [Mesa-dev] [PATCH 3/4] util: Change util/set to use quadratic probing

On Thu, Feb 9, 2017 at 4:16 PM, Jan Ziak <0xe2.0x9a.0...@gmail.com> wrote: > Hello > > IMPORTANT NOTE: Using the uint32_t data type, quad_hash*quad_hash will > overflow as soon as the hash table has more than 2**16=65536=64K > elements. To enable more than 64K elements in hash table, the data >

Re: [Mesa-dev] [PATCH] radv: detect command buffers that do no work and drop them

On Feb 9, 2017 8:25 PM, "Dave Airlie" wrote: From: Dave Airlie If a buffer is just full of flushes we flush things on command buffer submission, so don't bother submitting these. This will reduce some CPU overhead on dota2, which submits a fair few

Re: [Mesa-dev] [PATCH 00/11] Gallium common uploaders (v2)

Series tested with vmware svga driver. Changes looks good. Tested-by: Charmaine Lee From: mesa-dev on behalf of Marek Olšák Sent: Wednesday, February 8, 2017 4:11:01 PM

[Mesa-dev] [PATCH] radv: detect command buffers that do no work and drop them

From: Dave Airlie If a buffer is just full of flushes we flush things on command buffer submission, so don't bother submitting these. This will reduce some CPU overhead on dota2, which submits a fair few command streams that don't end up drawing anything. Signed-off-by:

[Mesa-dev] [PATCH] tgsi: fix memory leak in tgsi sanity check

From: Dave Airlie This just fixes this without repeating the code. Reported-by: Li Qiang Signed-off-by: Dave Airlie --- src/gallium/auxiliary/tgsi/tgsi_sanity.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [Mesa-dev] [PATCHv3 09/20] i965/fs: Get 64-bit indirect moves working on IVB.

Francisco Jerez writes: > --- > This replaces "[PATCH v2 09/20] i965/fs: indirect addressing with > doubles is not supported in IVB/BYT". > Note that some of the fp64 indirect addressing test-cases still fail on IVB even with this patch applied, but the reason doesn't

Re: [Mesa-dev] [PATCH] virgl/vtest: disconnect on destroy

On 10 February 2017 at 00:35, wrote: > From: Marc-André Lureau > > Since vtest is currently only handling a context at a time, calling > disconnect in virgl_vtest_winsys_destroy() allows to pass tests such as > piglit

[Mesa-dev] [PATCHv3 09/20] i965/fs: Get 64-bit indirect moves working on IVB.

--- This replaces "[PATCH v2 09/20] i965/fs: indirect addressing with doubles is not supported in IVB/BYT". src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 27 -- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp

[Mesa-dev] [PATCH] util/radv/adv: move *_get_function_timestamp() to utils

--- src/amd/vulkan/radv_device.c | 22 +++--- src/intel/vulkan/anv_device.c | 20 ++-- src/util/disk_cache.h | 17 + 3 files changed, 22 insertions(+), 37 deletions(-) diff --git a/src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH v2 3/5] anv: Add support for the PMA fix on Broadwell

On Thu, Feb 09, 2017 at 11:38:31AM -0800, Jason Ekstrand wrote: > On Thu, Feb 9, 2017 at 10:33 AM, Nanley Chery wrote: > > > On Wed, Feb 08, 2017 at 06:27:52PM -0800, Jason Ekstrand wrote: > > > On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery > >

Re: [Mesa-dev] [PATCH 0/4] RFC: Quadratic probing for the win

On Wed, 2017-02-08 at 21:35 +0100, Thomas Helland wrote: > I was cleaning up my local git repo, and came across this series. > Last time it was discussed was all the way back in April 2015. > Things looked pretty good back then, but we where seeing a smaller > regression in CPU-bound scenarios as

[Mesa-dev] [PATCH] tgsi-dump: dump label if instruction has one

From: Marc-André Lureau The instruction has an associated label when Instruction.Label == 1, as can be seen in ureg_emit_label() or tgsi_build_full_instruction(). This fixes dump generating extra :0 labels on conditionals, and virgl parsing more than the expected

Re: [Mesa-dev] [PATCH v2] nir: delete magic number

On Wed, 2017-02-08 at 15:54 -0800, Jason Ekstrand wrote: > On Wed, Feb 8, 2017 at 2:20 PM, Elie Tournier m> wrote: > > Signed-off-by: Elie Tournier > > --- > >  src/compiler/nir/nir_opt_loop_unroll.c | 10 +- > >  1 file changed, 9

Re: [Mesa-dev] [PATCH 0/4] RFC: Quadratic probing for the win

On Wed, 2017-02-08 at 15:59 -0800, Jason Ekstrand wrote: > On Wed, Feb 8, 2017 at 3:01 PM, Marek Olšák wrote: > > I think this is good stuff. I'd gladly take it just for the shader- > > db > > improvement. > > > > Agreed.  If it really did hurt minecraft before, we should try

[Mesa-dev] [PATCH] virgl/vtest: disconnect on destroy

From: Marc-André Lureau Since vtest is currently only handling a context at a time, calling disconnect in virgl_vtest_winsys_destroy() allows to pass tests such as piglit egl-create-context-invalid-flag-gles. Signed-off-by: Marc-André Lureau

[Mesa-dev] [PATCH] tgsi: remove ureg_label_insn

From: Marc-André Lureau Unused since commit 2897cb3dba9287011f9c43cd2f214100952370c0. Signed-off-by: Marc-André Lureau --- src/gallium/auxiliary/tgsi/tgsi_ureg.c | 31 ---

[Mesa-dev] [Bug 99692] [radv] Mostly broken on Hawaii PRO/CIK ASICs

https://bugs.freedesktop.org/show_bug.cgi?id=99692 --- Comment #3 from Nicholas Disiere --- I can confirm that this visual corruption is present on my R9 290 when radeon is blacklisted on the current Arch kernel. It affects the desktop with and without the compositor, and causes

Re: [Mesa-dev] [PATCH 2/2] anv/blorp: Disable partial resolves for transparent black clears

On Fri, Feb 10, 2017 at 12:44:02AM +, Emil Velikov wrote: > On 24 January 2017 at 00:55, Nanley Chery wrote: > > Cc: "13.0 17.0" > Nanley please take a look at the nominations page [1] and especially > at the note in the end ;-) >

[Mesa-dev] [PATCH] util/disk_cache: remove function stubs

The option to disable shader cache was removed from the build options when we imported a sha1 implementation into Mesa. Cc: Emil Velikov --- src/util/disk_cache.h | 50 -- 1 file changed, 50 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Be smarter about depth/stencil state

On Wed, Feb 01, 2017 at 05:43:55PM -0800, Jason Ekstrand wrote: > This seemed to help Dota 2 by a percent or two. I wasn't able to reproduce this on SKL, could you qualify this with "on BDW"? > --- > src/intel/vulkan/genX_pipeline.c | 133 > +-- > 1 file

[Mesa-dev] [PATCH] nvc0: fix 64-bit integer query buffer writes

The former logic just plain didn't work at all. We need to write the subsequent dword to the next buffer location. Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nvc0/mme/com9097.mme | 22 - src/gallium/drivers/nouveau/nvc0/mme/com9097.mme.h |

Re: [Mesa-dev] [PATCH v2 07/17] configure.ac: Rework MESA_LLVM and LLVM detection

Reviewed-by: Tobias Droste Am Donnerstag, 9. Februar 2017, 20:54:26 CET schrieb Emil Velikov: > From: Tobias Droste > > Set FOUND_LLVM only when LLVM is present (checking for exact version/etc > is deferred) and use enable-gallium-llvm to indicate the global

Re: [Mesa-dev] [PATCH v2 14/17] configure.ac: correctly manage llvm auto-detection

Reviewed-by: Tobias Droste for v2, too Am Donnerstag, 9. Februar 2017, 20:57:45 CET schrieb Emil Velikov: > From: Emil Velikov > > Earlier refactoring commits changed from one, dare I say it, broken > behaviour to another. Namely: > > Before, as you

Re: [Mesa-dev] [PATCH v2 06/17] configure.ac: move enable-gallium-llvm dependency with-gallium-drivers

Am Donnerstag, 9. Februar 2017, 20:53:06 CET schrieb Emil Velikov: > From: Emil Velikov > > ... to where it's applicable. > > Since we effectively made --enable-gallium-llvm mean --enable-llvm with > earlier commits, we need to move the requirement to guard the

[Mesa-dev] [PATCH] radv: reduce CPU overhead merging bo lists.

From: Dave Airlie Just noticed we do a fair bit of unneeded searching here. Since we know that the buffers in a CS are unique already, the first time we get any buffers, we can just memcpy those into place, and when we are searching for subsequent CSes, we only have to

Re: [Mesa-dev] [PATCH] configure.ac: Drop LLVM compiler flags more radically

On 09/02/17 10:50 PM, Emil Velikov wrote: > On 9 February 2017 at 08:07, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Drop all -m*, -W*, -O*, -g* and -f* flags, with the exception of >> -fno-rtti, which must be used if it's part of the llvm-config

[Mesa-dev] [Bug 99747] Problems with mesa 13.0.x and ubuntu 17.04

https://bugs.freedesktop.org/show_bug.cgi?id=99747 APoliTech changed: What|Removed |Added Component|Other

[Mesa-dev] [Bug 99747] Problems with mesa 13.0.x and ubuntu 17.04

https://bugs.freedesktop.org/show_bug.cgi?id=99747 Bug ID: 99747 Summary: Problems with mesa 13.0.x and ubuntu 17.04 Product: Mesa Version: 13.0 Hardware: x86-64 (AMD64) OS: other Status: NEW Severity:

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On Thu, Feb 9, 2017 at 8:18 PM, Marek Olšák wrote: > On Thu, Feb 9, 2017 at 6:23 PM, Ian Romanick wrote: >> On 02/09/2017 03:03 PM, Marek Olšák wrote: >>> On Thu, Feb 9, 2017 at 1:52 PM, Ian Romanick wrote: On 02/08/2017 10:26

Re: [Mesa-dev] [PATCH 2/2] anv/blorp: Disable partial resolves for transparent black clears

On Thu, Feb 9, 2017 at 4:45 PM, Emil Velikov wrote: > On 10 February 2017 at 00:44, Emil Velikov > wrote: > > On 24 January 2017 at 00:55, Nanley Chery wrote: > >> Cc: "13.0 17.0" > >

Re: [Mesa-dev] [PATCH 2/2] anv/blorp: Disable partial resolves for transparent black clears

On 10 February 2017 at 00:44, Emil Velikov wrote: > On 24 January 2017 at 00:55, Nanley Chery wrote: >> Cc: "13.0 17.0" > Nanley please take a look at the nominations page [1] and especially > at the note in the

Re: [Mesa-dev] [PATCH 2/2] anv/blorp: Disable partial resolves for transparent black clears

On 24 January 2017 at 00:55, Nanley Chery wrote: > Cc: "13.0 17.0" Nanley please take a look at the nominations page [1] and especially at the note in the end ;-) That said, I've picked this for 13.0 and will do 17.0 in a few minutes.

Re: [Mesa-dev] [PATCH v2 15/20] i965/vec4: consider subregister offset in live variables

Samuel Iglesias Gonsálvez writes: > From: "Juan A. Suarez Romero" > > Take in account the offset value when getting the var from register. > > This is required when dealing with an operation that writes half of the > register (like one d2x in IVB/BYT,

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

Ian Romanick writes: > [ Unknown signature status ] > On 02/09/2017 05:14 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: On 07.02.2017 23:54, Matt Turner wrote: > On Tue, Feb 7, 2017 at

[Mesa-dev] [PATCH] util/disk_cache: use stat() to check if entry is a directory

d_type is not supported on all systems. Tested-by: Vinson Lee Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97967 --- src/util/disk_cache.c | 33 - 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/src/util/disk_cache.c

[Mesa-dev] [PATCH 1/2] intel/blorp: Swizzle clear colors on the CPU

It's trivial to swizzle clear colors on the CPU, easily deals with the hardware restrictions for render target swizzles, and makes swizzled clears work on all hardware as opposed to just HSW+. --- src/intel/blorp/blorp_clear.c | 48 +++ 1 file changed, 30

[Mesa-dev] [PATCH 2/2] anv/blorp: Don't sanitize the swizzle for blorp_clear

BLORP is now smart enough to handle any swizzle (even those that contain ZERO or ONE) in a reasonable manner. Just let BLORP handle it. This fixes the following Vulkan CTS tests on Haswell: - dEQP-VK.api.image_clearing.clear_color_image.1d_b4g4r4a4_unorm_pack16 -

[Mesa-dev] [Bug 97967] glsl/tests/cache-test regression

https://bugs.freedesktop.org/show_bug.cgi?id=97967 --- Comment #19 from Vinson Lee --- Applied attachment 129406. make check passes. Mesa 17.1.0-devel: src/compiler/test-suite.log

[Mesa-dev] [PATCH] loader: unconditionally include unistd.h and stdlib.h

From: Nicolai Hähnle Otherwise we would fail with "implicit declaration of function" geteuid and getenv respectively. To trigger (re)move the libdrm.pc file and use the following: $ ./autogen.sh --disable-egl --disable-gbm --disable-dri \ --with-dri-drivers=swrast

[Mesa-dev] [Bug 99701] loader.c:353:8: error: implicit declaration of function 'geteuid' is invalid in C99 [-Werror, -Wimplicit-function-declaration]

https://bugs.freedesktop.org/show_bug.cgi?id=99701 --- Comment #3 from Vinson Lee --- Applied attachment 129378. The build still fails. $ ./autogen.sh --disable-egl --disable-gbm --disable-dri --with-dri-drivers=swrast --with-gallium-drivers=swrast $ make [...] CC

Re: [Mesa-dev] [PATCH 3/4] util: Change util/set to use quadratic probing

Hello IMPORTANT NOTE: Using the uint32_t data type, quad_hash*quad_hash will overflow as soon as the hash table has more than 2**16=65536=64K elements. To enable more than 64K elements in hash table, the data types need to be changed to uint64_t - unfortunately uint64_t arithmetic operations will

[Mesa-dev] [PATCH v2 14/17] configure.ac: correctly manage llvm auto-detection

From: Emil Velikov Earlier refactoring commits changed from one, dare I say it, broken behaviour to another. Namely: Before, as you explicitly --enable-gallium-llvm your selection was ignored when llvm-config was not present/detected. Today, the "auto" heuristics

[Mesa-dev] [PATCH v2 07/17] configure.ac: Rework MESA_LLVM and LLVM detection

From: Tobias Droste Set FOUND_LLVM only when LLVM is present (checking for exact version/etc is deferred) and use enable-gallium-llvm to indicate the global LLVM status. Renaming the latter is not appropriate for stable patches, so we'll address it with a later commit. Loosely

[Mesa-dev] [PATCH v2 06/17] configure.ac: move enable-gallium-llvm dependency with-gallium-drivers

From: Emil Velikov ... to where it's applicable. Since we effectively made --enable-gallium-llvm mean --enable-llvm with earlier commits, we need to move the requirement to guard the compnents added for the LLVM draw. Otherwise we'll error (as below) when building

Re: [Mesa-dev] [PATCH] nvc0/ir: fix ubo max clamp, reset file index

Nice catch. Reviewed-by: Samuel Pitoiset On 02/09/2017 09:37 PM, Ilia Mirkin wrote: We just increased the max UBO, so we should also increase the clamp that we do for robustness. Similarly, as we're including the fileIndex in the new indirect value, we should reset

[Mesa-dev] [PATCH] nvc0/ir: fix ubo max clamp, reset file index

We just increased the max UBO, so we should also increase the clamp that we do for robustness. Similarly, as we're including the fileIndex in the new indirect value, we should reset fileIndex to 0 so that it is not added in a second time. Signed-off-by: Ilia Mirkin Cc:

Re: [Mesa-dev] [PATCH v2 09/20] i965/fs: indirect addressing with doubles is not supported in IVB/BYT

Samuel Iglesias Gonsálvez writes: > It is tested empirically that IVB/BYT don't support indirect addressing > with doubles but it is not documented in the PRM. > > This patch applies the same solution than for Cherryview/Broxton and > takes into account that we cannot

Re: [Mesa-dev] [PATCH v2 3/5] anv: Add support for the PMA fix on Broadwell

On Thu, Feb 9, 2017 at 10:33 AM, Nanley Chery wrote: > On Wed, Feb 08, 2017 at 06:27:52PM -0800, Jason Ekstrand wrote: > > On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery > wrote: > > > > > On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On Thu, Feb 9, 2017 at 6:23 PM, Ian Romanick wrote: > On 02/09/2017 03:03 PM, Marek Olšák wrote: >> On Thu, Feb 9, 2017 at 1:52 PM, Ian Romanick wrote: >>> On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: On 07.02.2017 23:54, Matt Turner wrote: >

Re: [Mesa-dev] [PATCH 4/5] anv/pipeline: Make a copy of VkPipelineDepthStencilStateCreateinfo

On Wed, Feb 01, 2017 at 05:43:54PM -0800, Jason Ekstrand wrote: > --- > src/intel/vulkan/genX_pipeline.c | 34 ++ > 1 file changed, 18 insertions(+), 16 deletions(-) This patch is Reviewed-by: Nanley Chery > > diff --git

Re: [Mesa-dev] [PATCH v2 3/5] anv: Add support for the PMA fix on Broadwell

On Wed, Feb 08, 2017 at 09:38:52PM -0800, Jason Ekstrand wrote: > On Wed, Feb 8, 2017 at 8:11 PM, Jason Ekstrand wrote: > > > On Wed, Feb 8, 2017 at 6:27 PM, Jason Ekstrand > > wrote: > > > >> On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery

Re: [Mesa-dev] [PATCH v2 3/5] anv: Add support for the PMA fix on Broadwell

On Wed, Feb 08, 2017 at 06:27:52PM -0800, Jason Ekstrand wrote: > On Wed, Feb 8, 2017 at 5:34 PM, Nanley Chery wrote: > > > On Thu, Feb 02, 2017 at 01:26:05PM -0800, Jason Ekstrand wrote: > > > In order to get good performance numbers for this, I had to hack up the > > >

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

2017-02-09 18:06 GMT+01:00 Eero Tamminen : My personal feeling is that minimal merging criteria should be: > * no known segfaults > I bet that glmark2 just does something that's not allowed. Mesa can't prevent all application bugs? Seems like it has a very buggy

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On Thursday, February 9, 2017 5:23:47 PM PST Ian Romanick wrote: [snip] > Not achieving the desired performance is vastly different from > segfaults. Does the threaded mode in NVIDIA's driver crash? I'd wager > not. Sadly, yes it does. A while back, I tried running some Steam games on Linux

Re: [Mesa-dev] [PATCH 26/26] gallium: implement the backend of threaded GL dispatch

On Wed, Feb 8, 2017 at 6:03 PM, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/include/state_tracker/st_api.h | 19 +++ > src/gallium/state_trackers/dri/dri_context.c| 10 ++ >

Re: [Mesa-dev] features.txt & EXT_debug_label extension

On 02/09/2017 05:19 PM, Eero Tamminen wrote: > Hi, > > When checking GL errors for "Unturned" (Steam top-20 Unity3D based > game), I noticed that it uses functions from extension unsupported by > Mesa, and missing from "features.txt": >

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On 02/09/2017 05:26 PM, Ian Romanick wrote: > On 02/09/2017 05:14 PM, Eric Anholt wrote: >> Ian Romanick writes: >> >>> On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: On 07.02.2017 23:54, Matt Turner wrote: > On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

> Okay.. I will add the id member in a later patch to etna_shader > object. For the moment > I will pass it as an argument to dump_shader_info(..). Will send a V2 > of that series later the day. To be honest I think it's nonsense to change this now, if you need an id in the shader object then add

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On 02/09/2017 05:14 PM, Eric Anholt wrote: > Ian Romanick writes: > >> On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: >>> On 07.02.2017 23:54, Matt Turner wrote: On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák wrote: > On Tue, Feb 7, 2017 at 2:57 AM,

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

Hi, On 09.02.2017 19:14, Eric Anholt wrote: Ian Romanick writes: ... No, it absolutely is not fine to merge. We have never allowed such a thing, and I'll be damned if I'll allow this project to start. Things that land that are known to be broken never actually get

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On 02/09/2017 03:03 PM, Marek Olšák wrote: > On Thu, Feb 9, 2017 at 1:52 PM, Ian Romanick wrote: >> On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: >>> On 07.02.2017 23:54, Matt Turner wrote: On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák wrote: > On

Re: [Mesa-dev] features.txt & EXT_debug_label extension

On Thu, Feb 9, 2017 at 12:19 PM, Eero Tamminen wrote: > Hi, > > When checking GL errors for "Unturned" (Steam top-20 Unity3D based game), I > noticed that it uses functions from extension unsupported by Mesa, and > missing from "features.txt": >

[Mesa-dev] features.txt & EXT_debug_label extension

Hi, When checking GL errors for "Unturned" (Steam top-20 Unity3D based game), I noticed that it uses functions from extension unsupported by Mesa, and missing from "features.txt": https://www.khronos.org/registry/OpenGL/extensions/EXT/EXT_debug_label.txt Could it be added to "features.txt"

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

Ian Romanick writes: > On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: >> On 07.02.2017 23:54, Matt Turner wrote: >>> On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák wrote: On Tue, Feb 7, 2017 at 2:57 AM, Kenneth Graunke

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On Thu, Feb 9, 2017 at 3:03 PM, Marek Olšák wrote: > On Thu, Feb 9, 2017 at 1:52 PM, Ian Romanick wrote: >> On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: >>> On 07.02.2017 23:54, Matt Turner wrote: On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

Hi, On 09.02.2017 17:03, Marek Olšák wrote: On Thu, Feb 9, 2017 at 1:52 PM, Ian Romanick wrote: ... No, it absolutely is not fine to merge. We have never allowed such a thing, and I'll be damned if I'll allow this project to start. Things that land that are known to

Re: [Mesa-dev] www.mesa3d.org moving to freedesktop.org

On 02/08/2017 10:01 AM, Jason Ekstrand wrote: Brian, While we're on the topic of websites, how do you feel about having it generated by Sphinx? A couple of people have already gone to the effort to convert the raw HTML to RST (automatically in the case of release notes). I guess I don't

Re: [Mesa-dev] [PATCH 1/2] anv: allow blue in alpha component in swizzle for render

On Thu, Feb 09, 2017 at 09:41:11AM +0100, Juan A. Suarez Romero wrote: > On Wed, 2017-02-08 at 10:53 -0800, Nanley Chery wrote: > > On Wed, Feb 08, 2017 at 06:42:44PM +0100, Juan A. Suarez Romero wrote: > > > On Wed, 2017-02-08 at 09:27 -0800, Nanley Chery wrote: > > > > On Wed, Feb 08, 2017 at

Re: [Mesa-dev] [PATCH 04/10] vl: remove DRI2DriverPrimeShift compile guards

On 9 February 2017 at 15:23, Matt Turner wrote: > On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> Macro will always be defined as of earlier commit. > > How about something like > >

[Mesa-dev] [Bug 99730] Metro Redux game(s) needs override for midshader extension declaration

https://bugs.freedesktop.org/show_bug.cgi?id=99730 --- Comment #3 from Eero Tamminen --- Thanks! I guess this is one of the use-cases that actually *requires* shader compiler cache to work, so that user can (on second try) actually exit from the gfx options. Should I

Re: [Mesa-dev] [PATCH 2/3] etnaviv: move pctx initialisation to avoid a null dereference

Hi Eric 2017-02-09 11:59 GMT+01:00 Eric Engestrom : > On Thursday, 2017-02-09 08:19:39 +0100, Christian Gmeiner wrote: >> In case ctx->stream == NULL the fail label gets executed where >> pctx gets dereferenced - too bad pctx is NULL in that case. >> >> Caught by

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

Hi Lucas 2017-02-09 10:26 GMT+01:00 Lucas Stach : > Am Mittwoch, den 08.02.2017, 20:47 +0100 schrieb Christian Gmeiner: >> Hi Lucas, >> >> 2017-02-08 12:36 GMT+01:00 Lucas Stach : >> > Am Mittwoch, den 08.02.2017, 12:10 +0100 schrieb Christian

Re: [Mesa-dev] [PATCH 3/3] etnaviv: shader-db traces

Hi all 2017-02-09 13:50 GMT+01:00 Wladimir J. van der Laan : >> > >> /* shader object, for linking */ >> > >> struct etna_shader { >> > >> + uint32_t id; /* for debug */ >> > > >> > > Do you need this? It can certainly be removed from this patch, but I >> > > don't know if

[Mesa-dev] [PATCH 1/2] spirv: Add support for SpvCapabilityStorageImageWriteWithoutFormat

Allow that capability if the driver indicates that it is supported, and flag whether images are read-only/write-only in the nir_variable (based on the NonReadable and NonWritable decorations), which drivers may need to implement this. Signed-off-by: Alex Smith ---

[Mesa-dev] [PATCH 2/2] anv: Add support for shaderStorageImageWriteWithoutFormat

This allows shaders to write to storage images declared with unknown format if they are decorated with NonReadable ("writeonly" in GLSL). Previously an image view would always use a lowered format for its surface state, however when a shader declares a write-only image, we should use the real

Re: [Mesa-dev] [Freedreno] WebProcess crash on DB410c

Hi, I'm not sure exactly what mechanism you're using to implement the WPE interfaces, so I'll just list a few options. Focusing on wpe_renderer_backend_egl_offscreen_target_interface that's used as the basis for the sharing context and WebGL contexts, the simplest implementation would just

Re: [Mesa-dev] [PATCH 01/10] glx: remove always true ifdef guards

On Thu, Feb 9, 2017 at 3:22 PM, Matt Turner wrote: > On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote: >> From: Emil Velikov >> >> The two symbols referenced were introduced with v2.2 and 2.3 of >> the dri2proto

Re: [Mesa-dev] [PATCH 05/10] glx: remove DRI2DriverPrimeShift compile guards

On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote: > From: Emil Velikov > > Macro will always be defined as of earlier commit. Same comment as 04/10. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 04/10] vl: remove DRI2DriverPrimeShift compile guards

On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote: > From: Emil Velikov > > Macro will always be defined as of earlier commit. How about something like DRI2DriverPrimeShift was added in dri2proto-2.8, which we now require as of the

Re: [Mesa-dev] [PATCH 01/10] glx: remove always true ifdef guards

On Thu, Feb 9, 2017 at 1:35 PM, Emil Velikov wrote: > From: Emil Velikov > > The two symbols referenced were introduced with v2.2 and 2.3 of > the dri2proto package. ... and we require dri2proto >= 2.6. Reviewed-by: Matt Turner

Re: [Mesa-dev] [PATCH 7/7] i965/fs: add support for int64 to bool conversion

These all need to go into 17.0 On Feb 8, 2017 06:59, "Samuel Iglesias Gonsálvez" wrote: > Signed-off-by: Samuel Iglesias Gonsálvez > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99660 > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 15

Re: [Mesa-dev] [PATCH] intel/blorp: Swizzle clear colors on the CPU

On Feb 9, 2017 02:23, "Juan A. Suarez Romero" wrote: On Wed, 2017-02-08 at 13:35 -0800, Jason Ekstrand wrote: > This fixes the following Vulkan CTS tests on Haswell: > > - dEQP-VK.api.image_clearing.clear_color_image.1d_b4g4r4a4_unorm_pack16 > -

Re: [Mesa-dev] [PATCH] glsl: Allow compatibility shaders with MESA_GL_VERSION_OVERRIDE=...

Reviewed-by: Ian Romanick On 02/01/2017 12:20 AM, Matt Turner wrote: > Previously if you used MESA_GL_VERSION_OVERRIDE=3.3COMPAT, Mesa exposed > an OpenGL 3.3 compatibility profile context (with various unimplemented > features and bugs), but still refused to compile

Re: [Mesa-dev] Time to merge threaded GL dispatch? (aka glthread)

On Thu, Feb 9, 2017 at 1:52 PM, Ian Romanick wrote: > On 02/08/2017 10:26 AM, Nicolai Hähnle wrote: >> On 07.02.2017 23:54, Matt Turner wrote: >>> On Tue, Feb 7, 2017 at 10:56 AM, Marek Olšák wrote: On Tue, Feb 7, 2017 at 2:57 AM, Kenneth Graunke

Re: [Mesa-dev] [PATCH] swr: [rasterizer common/core/jitter] fetch support for GL_FIXED

On 7 December 2016 at 23:58, Tim Rowley wrote: > --- > .../drivers/swr/rasterizer/common/formats.cpp | 104 > ++--- > .../drivers/swr/rasterizer/common/formats.h| 7 +- > .../drivers/swr/rasterizer/core/format_traits.h| 90

Re: [Mesa-dev] [PATCH mesa 1/4] docs: add a note about the new version scheme

On 8 February 2017 at 11:27, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > docs/download.html | 8 > 1 file changed, 8 insertions(+) > > diff --git a/docs/download.html b/docs/download.html > index

Re: [Mesa-dev] [PATCH mesa 4/4] docs: update package contents

On 8 February 2017 at 11:27, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom > --- > > Do we want to list all the modules under src/ ? > The current list seems a bit arbitrary: > src/- source code for libraries > src/mesa

Re: [Mesa-dev] [PATCH 2/2] docs: update intro.html to mention new APIs, etc

Thanks Brian, A couple of small additions below, if you've not pushed the series. On 8 February 2017 at 19:31, Brian Paul wrote: > +http://www.khronos.org/opengles/;>OpenGL ES (versions 1, 2, 3), > +http://www.khronos.org/opencl/;>OpenCL,

[Mesa-dev] [PATCH 2/2] glsl: refactor get_variable_being_redeclared() to return always an ir_variable pointer

It will return the current variable ('var') or the earlier declaration ('earlier') in case of redeclaration of that variable. In order to distinguish between both, 'is_redeclaration' boolean will indicate in which case we are. Signed-off-by: Samuel Iglesias Gonsálvez ---

[Mesa-dev] [PATCH 1/2] glsl: fix heap-use-after-free in ast_declarator_list::hir()

The get_variable_being_redeclared() function can free 'var' because a re-declaration of an unsized array variable can establish the size, so we set the array type to the 'earlier' declaration and free 'var' as it is not needed anymore. However, the same 'var' is referenced later in

Re: [Mesa-dev] [PATCH v2] glsl: fix heap-use-after-free in ast_declarator_list::hir()

On Thu, 2017-02-09 at 13:34 +0100, Ian Romanick wrote: > NAK. > > The way the code is currently architected, if earlier is non-NULL, > var > should not be used.  There are quite a few places where the callees > do > things like 'const glsl_type *const t = (earlier == NULL) ? var->type > : >

[Mesa-dev] [Bug 99730] Metro Redux game(s) needs override for midshader extension declaration

https://bugs.freedesktop.org/show_bug.cgi?id=99730 --- Comment #2 from Grigori Goronzy --- > At least on Intel SKL with latest Mesa, something weird happens when > switching between gfx quality levels. Trying e.g. to switch to "Very high" > level (by exiting the video

Re: [Mesa-dev] [Mesa-stable] [PATCH 3/3] gallivm: Reenable PPC VSX (v3)

Hi Ben, On 19 January 2017 at 01:44, Ben Crocker wrote: > Reenable the PPC64LE Vector-Scalar Extension for LLVM versions >= 3.8.1, > now that LLVM bug 26775 and its corollary, 25503, are fixed. > > Amendment: remove extraneous spaces in macro def & invocations. > > We would

Re: [Mesa-dev] [PATCH 04/21] mesa: implement sparse buffer commitment

Patches 1, 2, and 4 are Reviewed-by: Ian Romanick I sent some comments on patch 3, and I'll leave review of the Gallium patches to people who actually know Gallium. :) On 02/08/2017 01:42 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > >

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] gallivm: Override getHostCPUName() "generic" w/ "pwr8" (v3)

Hi Ben, On 19 January 2017 at 01:43, Ben Crocker wrote: > If llvm::sys::getHostCPUName() returns "generic", override > it with "pwr8" (on PPC64LE). > > This is a work-around for a bug in LLVM: a table entry for "POWER8NVL" > is missing, resulting in (big-endian) "generic"

Re: [Mesa-dev] [PATCH] configure.ac: Drop LLVM compiler flags more radically

On 9 February 2017 at 08:07, Michel Dänzer wrote: > From: Michel Dänzer > > Drop all -m*, -W*, -O*, -g* and -f* flags, with the exception of > -fno-rtti, which must be used if it's part of the llvm-config --cxxflags > output. We don't want LLVM to

[Mesa-dev] [PATCH 09/10] xlib: remove always true ifdef GLX_EXTENSION guards

From: Emil Velikov Signed-off-by: Emil Velikov --- src/mesa/drivers/x11/fakeglx.c | 6 -- src/mesa/drivers/x11/glxapi.c | 20 2 files changed, 26 deletions(-) diff --git a/src/mesa/drivers/x11/fakeglx.c

[Mesa-dev] [PATCH 10/10] st/xlib: remove always true ifdef GLX_EXTENSION guards

From: Emil Velikov Signed-off-by: Emil Velikov --- src/gallium/state_trackers/glx/xlib/glx_api.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/gallium/state_trackers/glx/xlib/glx_api.c

  1   2   >