Re: [Mesa-dev] [PATCH] egl: Partially revert 23c86c74, fix eglMakeCurrent

On 05/16/2017 02:04 AM, Chad Versace wrote: Fixes regressions in Android CtsVerifier.apk on Intel Chrome OS devices due to incorrect error handling in eglMakeCurrent. See below on how to confirm the regression is fixed. This partially reverts commit

Re: [Mesa-dev] [PATCH 4/4] glsl: simplify link_assign_uniform_storage() a bit

On 15/05/17 20:55, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/compiler/glsl/link_uniforms.cpp | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/compiler/glsl/link_uniforms.cpp

Re: [Mesa-dev] [PATCH 2/7] mesa: add compressed_tex_sub_image() helper

On 16/05/17 00:12, Nicolai Hähnle wrote: On 12.05.2017 06:12, Timothy Arceri wrote: This reduces duplication between the dsa and non-dsa function and will also be used in the following commit to add KHR_no_error support. --- src/mesa/main/teximage.c | 82

Re: [Mesa-dev] [PATCH 3/4] glsl: Merge if-simplification and conditional discard optimization

On Mon, Apr 24, 2017 at 4:50 PM, Matt Turner wrote: > On Thu, Apr 6, 2017 at 12:49 PM, Thomas Helland > wrote: >> The conditional discard pass follows the same pattern, so merge the >> two, and avoid running the visitor two times. >> --- >>

[Mesa-dev] [PATCH V4 7/9] mesa: add *FramebufferTexture() support to frame_buffer_texture helper

V2: call check_layered_texture_target() even for no_error --- src/mesa/main/fbobject.c | 141 ++- 1 file changed, 41 insertions(+), 100 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 8e25dfa..adebf60 100644 ---

Re: [Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

On 16/05/17 10:47, Kenneth Graunke wrote: On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote: On 16/05/17 08:13, Ian Romanick wrote: On 04/23/2017 10:28 PM, Timothy Arceri wrote: diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

On 05/15/2017 02:27 AM, Nicolai Hähnle wrote: > Hi all, > > This series aims to simplify how we handle unnamed struct types and fix some > bugs on the way. Some of the patches should be uncontroversial, and all of > them align with my understanding of the GLSL spec, but the spec isn't > exactly

Re: [Mesa-dev] [PATCH] st/dri: Add fence extension to SW path

Ping On Mon, May 8, 2017 at 3:29 PM, Gurchetan Singh wrote: > Chrome is going to use EGLSync a lot to synchronize between EGL/KMS (along > with the flush image external extension). VM's are used for testing, so > adding this path would be helpful. > > On Fri, May

Re: [Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

On 05/15/2017 05:51 PM, Timothy Arceri wrote: > On 16/05/17 10:47, Kenneth Graunke wrote: >> On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote: >>> On 16/05/17 08:13, Ian Romanick wrote: On 04/23/2017 10:28 PM, Timothy Arceri wrote: > diff --git

Re: [Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

On 05/15/2017 04:06 PM, Timothy Arceri wrote: > On 16/05/17 08:13, Ian Romanick wrote: >> On 04/23/2017 10:28 PM, Timothy Arceri wrote: >> >>> diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml >>> b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml >>> deleted file mode 100644 >>> index

Re: [Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

On 16/05/17 10:47, Kenneth Graunke wrote: On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote: On 16/05/17 08:13, Ian Romanick wrote: On 04/23/2017 10:28 PM, Timothy Arceri wrote: diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml

Re: [Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

On Monday, May 15, 2017 4:06:31 PM PDT Timothy Arceri wrote: > On 16/05/17 08:13, Ian Romanick wrote: > > On 04/23/2017 10:28 PM, Timothy Arceri wrote: > > > >> diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml > >> b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml > >> deleted file

Re: [Mesa-dev] [PATCH v3 7/9] mesa: add *FramebufferTexture() support to frame_buffer_texture helper

On 16/05/17 00:06, Nicolai Hähnle wrote: On 11.05.2017 14:29, Timothy Arceri wrote: --- src/mesa/main/fbobject.c | 138 +-- 1 file changed, 38 insertions(+), 100 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index

Re: [Mesa-dev] [PATCH 2/9] glsl: do not lookup struct types by typename

On 16/05/17 09:24, Timothy Arceri wrote: On 15/05/17 19:27, Nicolai Hähnle wrote: From: Nicolai Hähnle This changes the logic during the conversion of the declaration list struct S { ... } v; from AST to IR, but should not change the end result. When

Re: [Mesa-dev] [PATCH 6/9] glsl: remove redundant record_compare check when linking globals

On 15/05/17 19:27, Nicolai Hähnle wrote: From: Nicolai Hähnle Unnamed struct types are now equal across stages based on the fields they contain, so this additional check has become unnecessary. I was a little confused by this change. Maybe change the above sentence

Re: [Mesa-dev] [PATCH 2/9] glsl: do not lookup struct types by typename

On 16.05.2017 01:24, Timothy Arceri wrote: On 15/05/17 19:27, Nicolai Hähnle wrote: From: Nicolai Hähnle This changes the logic during the conversion of the declaration list struct S { ... } v; from AST to IR, but should not change the end result.

Re: [Mesa-dev] [PATCH 1/9] glsl: fix a race condition when inserting new types

On 16.05.2017 01:32, Timothy Arceri wrote: On 15/05/17 19:27, Nicolai Hähnle wrote: From: Nicolai Hähnle By splitting glsl_type::mutex into two, we can avoid dropping the hash mutex while creating the new type instance (e.g. struct/record, interface). This fixes a

Re: [Mesa-dev] [PATCH 1/9] glsl: fix a race condition when inserting new types

On 15/05/17 19:27, Nicolai Hähnle wrote: From: Nicolai Hähnle By splitting glsl_type::mutex into two, we can avoid dropping the hash mutex while creating the new type instance (e.g. struct/record, interface). This fixes a time-of-check/time-of-use race where two

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

On 16 May 2017 at 08:21, Thomas Helland wrote: > 2017-05-15 21:08 GMT+00:00 Marek Olšák : >> On Mon, May 15, 2017 at 10:00 PM, Thomas Helland >> wrote: >>> Would this be a win for a game limited by the winsys/buffer

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

2017-05-16 1:05 GMT+02:00 Marek Olšák : > On Tue, May 16, 2017 at 12:21 AM, Thomas Helland > wrote: >> 2017-05-15 21:08 GMT+00:00 Marek Olšák : >>> On Mon, May 15, 2017 at 10:00 PM, Thomas Helland >>>

Re: [Mesa-dev] [PATCH 2/9] glsl: do not lookup struct types by typename

On 15/05/17 19:27, Nicolai Hähnle wrote: From: Nicolai Hähnle This changes the logic during the conversion of the declaration list struct S { ... } v; from AST to IR, but should not change the end result. When assigning the type of v, instead of

Re: [Mesa-dev] [PATCH 0/4] radeonsi: move TGSI memory/texture opcode handling out of si_shader.c

Do you have a branch somewhere so that I can see the last patch? Thanks, Marek On Mon, May 15, 2017 at 11:43 PM, Nicolai Hähnle wrote: > Hi all, > > This series is only moving code around. si_shader.c has become pretty > unwieldy over time, and handling of memory/texture

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

On Tue, May 16, 2017 at 12:21 AM, Thomas Helland wrote: > 2017-05-15 21:08 GMT+00:00 Marek Olšák : >> On Mon, May 15, 2017 at 10:00 PM, Thomas Helland >> wrote: >>> Would this be a win for a game limited by the winsys/buffer

Re: [Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

On 16/05/17 08:13, Ian Romanick wrote: On 04/23/2017 10:28 PM, Timothy Arceri wrote: diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml deleted file mode 100644 index 7312f9b..000 ---

[Mesa-dev] [PATCH] egl: Partially revert 23c86c74, fix eglMakeCurrent

Fixes regressions in Android CtsVerifier.apk on Intel Chrome OS devices due to incorrect error handling in eglMakeCurrent. See below on how to confirm the regression is fixed. This partially reverts commit 23c86c74cc450a23848b85cfe914376caede1cdf Author: Chad Versace

Re: [Mesa-dev] [PATCH] st/dri: Add fence extension to SW path

Ping. On Mon, May 8, 2017 at 3:25 PM, Gurchetan Singh wrote: > Use the same fence implementation for drisw.c as dri2.c by making > dri2FenceExtension an external variable. Since the fence implementation > is not dri2.c specific, put it in a separate file. This is

Re: [Mesa-dev] [PATCH 1/4] glsl: Merge opt_noop_swizzle, and opt_swizzle_swizzle

2017-05-16 0:24 GMT+02:00 Ian Romanick : > On 04/06/2017 12:49 PM, Thomas Helland wrote: >> The pass to optimize two swizzles in a row can be interpreted as >> a noop swizzle optimization. Merge the two passes, and avoid having >> the extra pass that runs a visitor pattern.

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On 2017-05-15 06:04 PM, Ian Romanick wrote: On 05/12/2017 06:39 AM, John Brooks wrote: Since release, Dying Light and Dead Island Definitive Edition have been broken on Mesa, producing at best only a black screen after loading. I found that the root of the problem is that their vertex shaders

Re: [Mesa-dev] [PATCH 1/4] glsl: Merge opt_noop_swizzle, and opt_swizzle_swizzle

On 04/06/2017 12:49 PM, Thomas Helland wrote: > The pass to optimize two swizzles in a row can be interpreted as > a noop swizzle optimization. Merge the two passes, and avoid having > the extra pass that runs a visitor pattern. > --- > src/compiler/Makefile.sources | 1 - >

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

2017-05-15 21:08 GMT+00:00 Marek Olšák : > On Mon, May 15, 2017 at 10:00 PM, Thomas Helland > wrote: >> Would this be a win for a game limited by the winsys/buffer handling? >> I played some Hitman the other day, and noticed my gpu-utilization >> was

Re: [Mesa-dev] [PATCH V2 12/24] i965/cnl: Add cnl bits in aubinator

Reviewed-by: Jason Ekstrand On Mon, May 15, 2017 at 3:11 PM, Anuj Phogat wrote: > V2: Leave a trailing comma for cnl entry in the table. (Jason) > > Signed-off-by: Anuj Phogat > Cc: Jason Ekstrand > ---

Re: [Mesa-dev] [PATCH 2/4] mesa: drop APPLE_vertex_array_object support

On 04/23/2017 10:28 PM, Timothy Arceri wrote: > diff --git a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml > b/src/mapi/glapi/gen/APPLE_vertex_array_object.xml > deleted file mode 100644 > index 7312f9b..000 > --- a/src/mapi/glapi/gen/APPLE_vertex_array_object.xml > +++ /dev/null > @@

[Mesa-dev] [PATCH V2 12/24] i965/cnl: Add cnl bits in aubinator

V2: Leave a trailing comma for cnl entry in the table. (Jason) Signed-off-by: Anuj Phogat Cc: Jason Ekstrand --- src/intel/tools/aubinator.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/intel/tools/aubinator.c

[Mesa-dev] [PATCH V2 9/24] i965/cnl: Wire up Mesa build files for gen10

V2: Remove isl_gen10.c and isl_gen10.h Signed-off-by: Anuj Phogat Cc: Jason Ekstrand --- src/intel/Makefile.isl.am | 4 src/intel/Makefile.sources | 10 -- src/intel/Makefile.vulkan.am |

Re: [Mesa-dev] [PATCH V2 07/24] i965/cnl: Update the script generating genX_bits.h

Maybe tweak the commit message: intel/genxml: Update genx_bits for gen10+ This commit adds a gen10 case to the switch statement and drops some unneeded code for handling gen numbers which doesn't work on gen10 and above. On Mon, May 15, 2017 at 3:04 PM, Jason Ekstrand

Re: [Mesa-dev] [PATCH 0/2] Allow redeclaration of GLSL builtins; fixes Dying Light and Dead Island Definitive Edition

On 05/12/2017 06:39 AM, John Brooks wrote: > Since release, Dying Light and Dead Island Definitive Edition have been broken > on Mesa, producing at best only a black screen after loading. I found that the > root of the problem is that their vertex shaders redeclare the GLSL builtin > gl_VertexID,

Re: [Mesa-dev] [PATCH V2 07/24] i965/cnl: Update the script generating genX_bits.h

Reviewed-by: Jason Ekstrand On Mon, May 15, 2017 at 3:02 PM, Anuj Phogat wrote: > V2: Drop "z = float(z)" and the "z *= 10" lines > > Signed-off-by: Anuj Phogat > Reviewed-by: Jason Ekstrand > --- >

[Mesa-dev] [PATCH V2 07/24] i965/cnl: Update the script generating genX_bits.h

V2: Drop "z = float(z)" and the "z *= 10" lines Signed-off-by: Anuj Phogat Reviewed-by: Jason Ekstrand --- src/intel/genxml/gen_bits_header.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH 3/4] radeonsi: make const_array externally accessible

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 26 +++ src/gallium/drivers/radeonsi/si_shader_internal.h | 2 ++ 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 1/4] radeonsi: make emit_waitcnt externally accessible

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 15 +-- src/gallium/drivers/radeonsi/si_shader_internal.h | 7 +++ 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 2/4] radeonsi: make get_bounded_indirect_index externally accessible

From: Nicolai Hähnle --- src/gallium/drivers/radeonsi/si_shader.c | 32 +++ src/gallium/drivers/radeonsi/si_shader_internal.h | 4 +++ 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c

[Mesa-dev] [PATCH 0/4] radeonsi: move TGSI memory/texture opcode handling out of si_shader.c

Hi all, This series is only moving code around. si_shader.c has become pretty unwieldy over time, and handling of memory/texture opcodes is a big chunk that can be nicely extracted elsewhere without a lot of dependencies. It is analogous to the ALU ops that are already separate. Even after this

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

On Mon, May 15, 2017 at 10:00 PM, Thomas Helland wrote: > Would this be a win for a game limited by the winsys/buffer handling? > I played some Hitman the other day, and noticed my gpu-utilization > was hovering at about 80%. Some profiling later and I concluded > that

Re: [Mesa-dev] [PATCH 2/2] nir/lower-atomics-to-ssbo: remove atomic_uint arrays too

On Mon, May 15, 2017 at 4:06 PM, Rob Clark wrote: > Maybe there is a better way to do this. But by the time we get to > assigning uniform locs, we want the atomic_uint's to all be gone, > otherwise we assert in st_glsl_attrib_type_size(). > > Signed-off-by: Rob Clark

[Mesa-dev] [PATCH] intel/isl/gen6: Fix combined depth stencil alignment

All combined depth stencil buffers (even those with just stencil) require a 4x4 alignment on Sandy Bridge. The only depth/stencil buffer type that requires 4x2 is separate stencil. --- src/intel/isl/isl_gen6.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [Mesa-dev] [PATCH v2 3/6] vulkan/wsi/wayland: Use per-display event queue

Hi Lionel, On 12 May 2017 at 10:52, Lionel Landwerlin wrote: > On 05/05/17 17:47, Daniel Stone wrote: >> @@ -535,7 +555,7 @@ wsi_wl_swapchain_acquire_next_image(struct >> wsi_swapchain *wsi_chain, >> { >> struct wsi_wl_swapchain *chain = (struct

Re: [Mesa-dev] [PATCH 3/4] intel/isl: Refactor gen6_choose_image_alignment_el

On Sat 13 May 2017, Jason Ekstrand wrote: > On Fri, May 12, 2017 at 3:35 PM, Chad Versace > wrote: > > > On Thu 11 May 2017, Jason Ekstrand wrote: > > > On Thu, May 11, 2017 at 9:08 PM, Chad Versace > > > wrote: > > > > > > > On Thu 11 May

Re: [Mesa-dev] [PATCH] swr: don't use AttributeSet with llvm >= 5

Reviewed-by: Bruce Cherniak > On May 11, 2017, at 12:59 PM, Tim Rowley wrote: > > This change fixes the build break with llvm-svn. > > r301981 of llvm-svn made add/remove of function attributes > use AttrBuilder instead of AttributeList.

[Mesa-dev] [PATCH 2/2] nir/lower-atomics-to-ssbo: remove atomic_uint arrays too

Maybe there is a better way to do this. But by the time we get to assigning uniform locs, we want the atomic_uint's to all be gone, otherwise we assert in st_glsl_attrib_type_size(). Signed-off-by: Rob Clark --- Are there any other cases? If atomic_uint is an opaque type,

[Mesa-dev] [PATCH 1/2] nir/lower-atomics-to-ssbo: fix num_components

Fixes some piglits like arb_shader_atomic_counters-active-counters Signed-off-by: Rob Clark --- src/compiler/nir/nir_lower_atomics_to_ssbo.c | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/nir/nir_lower_atomics_to_ssbo.c

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

Would this be a win for a game limited by the winsys/buffer handling? I played some Hitman the other day, and noticed my gpu-utilization was hovering at about 80%. Some profiling later and I concluded that one thread was pegged at 100% doing buffer handling work. amdgpu_cs_add_buffer,

Re: [Mesa-dev] [PATCH 11/11] intel/aubinator_error_decode: Disassemble shader programs

On Mon, May 1, 2017 at 1:54 PM, Matt Turner wrote: > --- > src/intel/Makefile.tools.am | 6 +- > src/intel/tools/aubinator_error_decode.c | 178 > ++- > 2 files changed, 180 insertions(+), 4 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 11/11] intel/aubinator_error_decode: Disassemble shader programs

On Fri, May 5, 2017 at 12:44 AM, Pohjolainen, Topi wrote: > On Mon, May 01, 2017 at 01:54:55PM -0700, Matt Turner wrote: >> --- >> src/intel/Makefile.tools.am | 6 +- >> src/intel/tools/aubinator_error_decode.c | 178 >> ++-

Re: [Mesa-dev] [PATCH 0/3] few tgsi_to_nir fixes

Rob Clark writes: > Looks like somewhere along the way nir_validate got more thorough about > checking src/dst sizes. > > Rob Clark (3): > ttn: fix txs dest size > ttn: fix txd src sizes > ttn: fix dest size for some texture instructions Reviewed-by: Eric Anholt

Re: [Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

With this patch I applied, I still see this bit used in several places, including the i915 driver. Did you test that? rc/compiler/shader_enums.h:#define VARYING_BIT_FOGC BITFIELD64_BIT(VARYING_SLOT_FOGC) src/mesa/swrast/s_context.c:VARYING_BIT_FOGC | VARYING_BITS_TEX_ANY;

Re: [Mesa-dev] [PATCH 05/14] mesa/main/ff_frag: Don't bother with VARYING_BIT_FOGC.

2017-05-15 20:28 GMT+02:00 Ian Romanick : > With this patch I applied, I still see this bit used in several > places, including the i915 driver. Did you test that? > > rc/compiler/shader_enums.h:#define VARYING_BIT_FOGC > BITFIELD64_BIT(VARYING_SLOT_FOGC) >

[Mesa-dev] [PATCH 2/3] ttn: fix txd src sizes

Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 3b8e321..bdcf218 100644 ---

[Mesa-dev] [PATCH 3/3] ttn: fix dest size for some texture instructions

Some, like lod, don't return 4 components. Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index

[Mesa-dev] [PATCH 1/3] ttn: fix txs dest size

Signed-off-by: Rob Clark --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/nir/tgsi_to_nir.c b/src/gallium/auxiliary/nir/tgsi_to_nir.c index 1d68c22..3b8e321 100644 ---

[Mesa-dev] [PATCH 0/3] few tgsi_to_nir fixes

Looks like somewhere along the way nir_validate got more thorough about checking src/dst sizes. Rob Clark (3): ttn: fix txs dest size ttn: fix txd src sizes ttn: fix dest size for some texture instructions src/gallium/auxiliary/nir/tgsi_to_nir.c | 17 +++-- 1 file changed, 11

Re: [Mesa-dev] [PATCH 24/24] i965: Simplify get_l3_way_size() function

On Sat, May 13, 2017 at 11:59 AM, Francisco Jerez wrote: > Anuj Phogat writes: > > > Cherryview and Broxton are always gt1. So, remove the redundant checks. > > > > Signed-off-by: Anuj Phogat > > --- > >

Re: [Mesa-dev] [PATCH 13/13] gbm: don't manage our set of DRI extensions

On 15 May 2017 at 17:50, Rob Herring wrote: > On Mon, May 15, 2017 at 11:23 AM, Emil Velikov > wrote: >> On 11 May 2017 at 19:57, Emil Velikov wrote: >>> From: Emil Velikov >>> >>> Don't

Re: [Mesa-dev] [PATCH 14/24] i965/cnl: Handle gen10 in switch cases across the driver

On Sat, May 13, 2017 at 9:47 AM, Jason Ekstrand wrote: > Most of these still point to gen9 functions even though we have gen10 > versions now. We should point to the gen10 versions. Yes, I know some of > that is in a later patch but I see no reason why we can't roll those

Re: [Mesa-dev] [PATCH 08/24] i965/cnl: Add isl_gen10 header and source files

On Sat, May 13, 2017 at 9:37 AM, Jason Ekstrand wrote: > If everything truely is the same here, I see no reason why we should add a > gen10 version. I know this appears to contradict what I said before but > the difference is that this file is handwritten and not just a

Re: [Mesa-dev] [PATCH 21/24] i965/cnl: Make URB {VS, GS, HS, DS} sizes non multiple of 3

On Sat, May 13, 2017 at 12:18 PM, Kenneth Graunke wrote: > On Friday, May 12, 2017 4:38:25 PM PDT Anuj Phogat wrote: > > v1: By Ben Widawsky > > v2: Add the restriction for GS, HS and DS and make sure > > the allocated sizes are not

Re: [Mesa-dev] [PATCH 13/24] i965/cnl: Update few assertions

​​ On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand wrote: > On May 12, 2017 4:41:36 PM Anuj Phogat wrote: > > Signed-off-by: Anuj Phogat >> --- >> src/intel/compiler/brw_compiler.h | 2 +- >>

Re: [Mesa-dev] [PATCH 13/13] gbm: don't manage our set of DRI extensions

On Mon, May 15, 2017 at 11:23 AM, Emil Velikov wrote: > On 11 May 2017 at 19:57, Emil Velikov wrote: >> From: Emil Velikov >> >> Don't fetch/manage our set of extensions apart from __DRI_CORE, >> __DRI_DRI2 and

Re: [Mesa-dev] [PATCH 13/13] gbm: don't manage our set of DRI extensions

On 11 May 2017 at 19:57, Emil Velikov wrote: > From: Emil Velikov > > Don't fetch/manage our set of extensions apart from __DRI_CORE, > __DRI_DRI2 and __DRI_SWRAST. We require these to setup a screen and > context (in case of bo map/unmap). >

[Mesa-dev] [PATCH 4.5/13] egl: check for driver_configs in dri2_display_release

From: Tapani Pälli With later commits we'll split and reuse the destroy side of the function for the initialize_foo error path. In such cases, driver_configs may be NULL leading to a crash. Signed-off-by: Tapani Pälli [Emil Velikov: reword

Re: [Mesa-dev] [PATCH 10/13] egl/x11: make use of the dri2_display_destroy() helper

On 12 May 2017 at 13:19, Emil Velikov wrote: > On 12 May 2017 at 09:20, Tapani Pälli wrote: >> this patch causes a crash with egl-create-surface Piglit test >> > Seems like we have a bunch of missing NULL checks throughout. > Please ignore the

Re: [Mesa-dev] [PATCH 12/24] i965/cnl: Add cnl bits in aubinator

On Sat, May 13, 2017 at 9:39 AM, Jason Ekstrand wrote: > On May 12, 2017 4:41:22 PM Anuj Phogat wrote: > >> Signed-off-by: Anuj Phogat >> --- >> src/intel/tools/aubinator.c | 8 +--- >> 1 file changed, 5 insertions(+), 3

Re: [Mesa-dev] [PATCH 07/24] i965/cnl: Update the script generating genX_bits.h

On Sat, May 13, 2017 at 9:31 AM, Jason Ekstrand wrote: > On May 12, 2017 4:41:26 PM Anuj Phogat wrote: > >> Signed-off-by: Anuj Phogat >> Reviewed-by: Jason Ekstrand >> --- >>

Re: [Mesa-dev] [PATCH] i965/blorp: Do and end-of-pipe sync on both sides of fast-clear ops

On Mon, May 15, 2017 at 8:12 AM, Pohjolainen, Topi < topi.pohjolai...@gmail.com> wrote: > On Mon, May 15, 2017 at 07:55:46AM -0700, Jason Ekstrand wrote: > > We've discovered in the Vulkan driver that simply doing the end-of-pipe > > sync afterwards is insufficient. The specific requirement

Re: [Mesa-dev] [PATCH 3/3] egl: annotate dri2_egl_display_vtbl as const data

On Monday, 2017-05-15 16:14:17 +0100, Emil Velikov wrote: > From: Emil Velikov > > With the final place that modifies the vtbl removed as of last commit we > can annotate the symbols accordingly. > > Signed-off-by: Emil Velikov Nice!

Re: [Mesa-dev] [PATCH] gallium/radeon: use a top-of-pipe timestamp for the start of TIME_ELAPSED

Reviewed-by: Nicolai Hähnle On 15.05.2017 17:33, Marek Olšák wrote: From: Marek Olšák --- src/amd/common/r600d_common.h | 11 +++ src/gallium/drivers/radeon/r600_query.c | 21 +++-- 2 files changed, 30

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

On 15.05.2017 16:57, Erik Faye-Lund wrote: On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote: Hi all, This series aims to simplify how we handle unnamed struct types and fix some bugs on the way. Some of the patches should be uncontroversial, and all of them align

[Mesa-dev] [PATCH] gallium/radeon: use a top-of-pipe timestamp for the start of TIME_ELAPSED

From: Marek Olšák --- src/amd/common/r600d_common.h | 11 +++ src/gallium/drivers/radeon/r600_query.c | 21 +++-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/src/amd/common/r600d_common.h b/src/amd/common/r600d_common.h

[Mesa-dev] [PATCH 4/7] egl/surfaceless: use the image_driver for image_loader

Analogous to previous commit. Cc: Chad Versace Cc: Gurchetan Singh Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 5/7] egl/wayland: select the format based on the interface used

From: Emil Velikov Rather than misleadingly depending on DRI2 for the WL_DRM vs WL_SHM formats, use the wl_drm and wl_shm interface respectively. Fixes: a1727aa75ed ("egl/wayland: Don't use DRM format codes for SHM") Signed-off-by: Emil Velikov

[Mesa-dev] [PATCH 6/7] egl/wayland: set the resize_callback if the flush extension is available

From: Emil Velikov Strictly speaking __DRI_DRI2 implies __DRI2_FLUSH. Although since we're using the latter in the callback, we want to use the correct guard. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 6

[Mesa-dev] [PATCH 2/7] egl/x11: check for dri2_dpy->flush before using the flush extension

From: Emil Velikov Analogous to previous commit. Signed-off-by: Emil Velikov --- If people prefer I can split the whitespace/indent changes in this/previous path from the rest. Don't feel too strongly either way.

[Mesa-dev] [PATCH 7/7] egl/wayland: use the image_driver alongside the image_loader

From: Emil Velikov Analogous to earlier commits - image_driver and image_loader are meant to be used hand in hand. v2: Rebase Cc: Derek Foreman Signed-off-by: Emil Velikov --- Derek, can you try the v2 of the

[Mesa-dev] [PATCH 1/7] egl/drm: check for dri2_dpy->flush before using the flush extension

From: Emil Velikov The current __DRI_DRI2 imples __DRI2_FLUSH. At the same time, one can use __DRI_IMAGE_DRIVER alongside the latter, so the current check is confusing at best. Check for what we use. Signed-off-by: Emil Velikov ---

[Mesa-dev] [PATCH 3/7] egl/android: use the image_driver alongside the image_loader

From: Emil Velikov They are meant to be used together. Otherwise we'll need workarounds like egl/wayland. Namely register an image_loader_extension even thought we should be using only DRI2. v2: Add missing the bracket to fix the build (Tapani). Signed-off-by: Emil

[Mesa-dev] [PATCH 2/3] egl/wayland: don't modify the vtbl if an extension is not available

From: Emil Velikov With previous commit we'll error out should one be using the extension when it's not available. Thus we no longer need to modify the vtbl. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_wayland.c | 7

[Mesa-dev] [PATCH 3/3] egl: annotate dri2_egl_display_vtbl as const data

From: Emil Velikov With the final place that modifies the vtbl removed as of last commit we can annotate the symbols accordingly. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_android.c | 2 +-

[Mesa-dev] [PATCH 1/3] egl: error out on eglCreateWaylandBufferFromImageWL

From: Emil Velikov Currently f one does the silly thing by probing the entry point w/o checking the extension they will attempt to use the extension even though it cannot work. That is due our of of an assert which gets removed in release builds. Simply error out if

Re: [Mesa-dev] [PATCH] i965/blorp: Do and end-of-pipe sync on both sides of fast-clear ops

On Mon, May 15, 2017 at 07:55:46AM -0700, Jason Ekstrand wrote: > We've discovered in the Vulkan driver that simply doing the end-of-pipe > sync afterwards is insufficient. The specific requirement stated in the > PRM is that you have to do one every time you transition between the > tree modes

Re: [Mesa-dev] [PATCH v2] egl: fix android logger compilation

On 12 May 2017 at 07:32, Tapani Pälli wrote: > 1ce5853 broken compilation since LOG_ERROR is not defined and also > macro expansion won't work as planned (expands to 'ANDROID_egl2alog[level]') > > v2: append 'ANDROID' to egl2alog table and use LOG_PRI > (suggested by

Re: [Mesa-dev] [PATCH v2 07/27] configure: error out when building GLX w/o the X11 platform

On Monday, 2017-05-15 15:41:44 +0100, Emil Velikov wrote: > On 8 May 2017 at 01:35, Eric Engestrom wrote: > > I don't seem to have received patches 12-27 of this series though? > > > Git send-email tripped on a malformed email in 12. The rest of the > series is was sent shortly

[Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_get_surface_capabilities2

--- src/intel/vulkan/anv_device.c | 4 src/intel/vulkan/anv_entrypoints_gen.py | 1 + src/intel/vulkan/anv_wsi.c | 27 +++ 3 files changed, 32 insertions(+) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c index

[Mesa-dev] [PATCH 3/6] vulkan/wsi: Ad get_capabilities2 and get_formats2d interface pointers

--- src/vulkan/wsi/wsi_common.h | 8 1 file changed, 8 insertions(+) diff --git a/src/vulkan/wsi/wsi_common.h b/src/vulkan/wsi/wsi_common.h index 5e77518..8aee9c7 100644 --- a/src/vulkan/wsi/wsi_common.h +++ b/src/vulkan/wsi/wsi_common.h @@ -87,10 +87,18 @@ struct wsi_interface {

[Mesa-dev] [PATCH 2/6] vulkan/wsi: Use vk_outarray for surface_get_formats

--- src/vulkan/wsi/wsi_common_wayland.c | 28 +--- src/vulkan/wsi/wsi_common_x11.c | 23 --- 2 files changed, 21 insertions(+), 30 deletions(-) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index

[Mesa-dev] [PATCH 4/6] vulkan/wsi/x11: Add support for VK_KHR_get_surface_capabilities2

--- src/vulkan/wsi/wsi_common_x11.c | 32 1 file changed, 32 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_x11.c b/src/vulkan/wsi/wsi_common_x11.c index 3580194..5be56f1 100644 --- a/src/vulkan/wsi/wsi_common_x11.c +++ b/src/vulkan/wsi/wsi_common_x11.c @@

[Mesa-dev] [PATCH 5/6] vulkan/wsi/wayland: Add support for VK_KHR_get_surface_capabilities2

--- src/vulkan/wsi/wsi_common_wayland.c | 38 + 1 file changed, 38 insertions(+) diff --git a/src/vulkan/wsi/wsi_common_wayland.c b/src/vulkan/wsi/wsi_common_wayland.c index 5c72c8a..cb6dd79 100644 --- a/src/vulkan/wsi/wsi_common_wayland.c +++

[Mesa-dev] [PATCH 1/6] vulkan: Update registry and headers to 1.0.49

--- include/vulkan/vulkan.h| 111 -- src/vulkan/registry/vk.xml | 167 + 2 files changed, 262 insertions(+), 16 deletions(-) diff --git a/include/vulkan/vulkan.h b/include/vulkan/vulkan.h index ef0c246..51e5e9e 100644

Re: [Mesa-dev] [PATCH 0/9] glsl: cleanup and fix handling of unnamed struct types

On Mon, May 15, 2017 at 11:27 AM, Nicolai Hähnle wrote: > Hi all, > > This series aims to simplify how we handle unnamed struct types and fix some > bugs on the way. Some of the patches should be uncontroversial, and all of > them align with my understanding of the GLSL spec,

[Mesa-dev] [PATCH] i965/blorp: Do and end-of-pipe sync on both sides of fast-clear ops

We've discovered in the Vulkan driver that simply doing the end-of-pipe sync afterwards is insufficient. The specific requirement stated in the PRM is that you have to do one every time you transition between the tree modes of "clear", "render", and "resolve". This is GL, so we could track it

Re: [Mesa-dev] [PATCH v2 13/27] st/va: move variable declaration to where its used

On 5 May 2017 at 12:44, Christian König wrote: > Am 04.05.2017 um 18:33 schrieb Emil Velikov: >> >> From: Emil Velikov >> >> ... and make it const, since we shouldn't tinker with it. >> >> Signed-off-by: Emil Velikov

Re: [Mesa-dev] [PATCH 3/3] mesa: don't check mapped buffers in every draw call if drivers allow it

On 15.05.2017 16:41, Marek Olšák wrote: From: Marek Olšák Before: DrawElements (16 VBOs) w/ no state change: 4.34 million/s After: DrawElements (16 VBOs) w/ no state change: 8.80 million/s This inefficiency was uncovered by Timothy Arceri's no_error work. Nice one!

  1   2   3   >