[Mesa-dev] [RFC PATCH] st/mesa: skip texture validation logic when nothing has changed

Based on the same logic in the i965 driver 2f225f61451abd51 and 16060c5adcd4. perf reports st_finalize_texture() going from 0.60% -> 0.16% with this change when running the Xonotic benchmark from PTS. --- A full run of piglit on radeonsi produced no regressions. No other drivers have been

Re: [Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

Hi Eric, On 06/09/2017 08:59 PM, Eric Engestrom wrote: On Friday, 2017-06-09 20:13:34 +0530, Harish Krupo wrote: This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. 1 test not supported. v2: add

[Mesa-dev] [PATCH] st/mesa: unmap the stream_uploader buffer before drawing

Some drivers require that the vertex buffers be unmapped prior to drawing. This change unmaps the stream_uploader buffer after we've uploaded the zero-stride attributes (unless the driver supports rendering with mapped buffers). This fixes a regression in the VMware driver since

[Mesa-dev] [PATCH] gallium/util: whitespace, formatting fixes in u_upload_mgr.c

--- src/gallium/auxiliary/util/u_upload_mgr.c | 54 +-- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/src/gallium/auxiliary/util/u_upload_mgr.c b/src/gallium/auxiliary/util/u_upload_mgr.c index 9528495..4bb14d6 100644 ---

Re: [Mesa-dev] [PATCH 09/17] ac: add i32_0 convenience member to ac_llvm_context

Sure. On Fri, Jun 9, 2017 at 5:04 PM, Bas Nieuwenhuizen wrote: > Merge this with patch 14? > > On Sat, Jun 10, 2017 at 1:47 AM, Connor Abbott > wrote: >> From: Connor Abbott >> >> To match si_shader_context. >> >>

Re: [Mesa-dev] [PATCH 17/17] radv/ac: enable EXT_shader_subgroup_ballot and EXT_shader_subgroup_vote

On Fri, Jun 9, 2017 at 5:04 PM, Bas Nieuwenhuizen wrote: > On Sat, Jun 10, 2017 at 1:50 AM, Connor Abbott > wrote: >> From: Connor Abbott >> >> Signed-off-by: Connor Abbott >> --- >>

Re: [Mesa-dev] [PATCH 09/17] ac: add i32_0 convenience member to ac_llvm_context

Merge this with patch 14? On Sat, Jun 10, 2017 at 1:47 AM, Connor Abbott wrote: > From: Connor Abbott > > To match si_shader_context. > > Signed-off-by: Connor Abbott > --- > src/amd/common/ac_llvm_build.c | 2 ++ >

Re: [Mesa-dev] [PATCH 17/17] radv/ac: enable EXT_shader_subgroup_ballot and EXT_shader_subgroup_vote

On Sat, Jun 10, 2017 at 1:50 AM, Connor Abbott wrote: > From: Connor Abbott > > Signed-off-by: Connor Abbott > --- > src/amd/common/ac_nir_to_llvm.c | 75 > + >

[Mesa-dev] [PATCH 16/17] ac: enable the AMDGPU asm parser

From: Connor Abbott Ported from radeonsi. Needed for emitting optimization barriers, which contain inline asm. Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_util.c | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 17/17] radv/ac: enable EXT_shader_subgroup_ballot and EXT_shader_subgroup_vote

From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_nir_to_llvm.c | 75 + src/amd/vulkan/radv_device.c| 8 + src/amd/vulkan/radv_pipeline.c | 2 ++ 3 files changed, 85 insertions(+)

[Mesa-dev] [PATCH 15/17] radeonsi: move the guts of ARB_shader_group_vote emission to ac

From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 30 ++ src/amd/common/ac_llvm_build.h | 6 ++ src/gallium/drivers/radeonsi/si_shader.c | 24

[Mesa-dev] [PATCH 12/17] ac: add i64 type to ac_llvm_context

From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [PATCH 13/17] radeonsi: move si_emit_ballot() to ac

From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 26 ++ src/amd/common/ac_llvm_build.h | 4 src/gallium/drivers/radeonsi/si_shader.c | 38

[Mesa-dev] [PATCH 11/17] radeonsi: move emit_optimization_barrier() to ac

From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 43 ++ src/amd/common/ac_llvm_build.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 45

[Mesa-dev] [PATCH 14/17] ac: add i32_1 convenience member to ac_llvm_context

From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 1 + src/amd/common/ac_llvm_build.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

[Mesa-dev] [PATCH 10/17] radeonsi: move llvm_get_type_size() to ac

From: Connor Abbott Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 24 +++ src/amd/common/ac_llvm_build.h | 2 ++ src/gallium/drivers/radeonsi/si_shader.c | 41 +++- 3

[Mesa-dev] [PATCH 09/17] ac: add i32_0 convenience member to ac_llvm_context

From: Connor Abbott To match si_shader_context. Signed-off-by: Connor Abbott --- src/amd/common/ac_llvm_build.c | 2 ++ src/amd/common/ac_llvm_build.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/amd/common/ac_llvm_build.c

[Mesa-dev] [PATCH 06/17] compiler: add new system values for SPV_KHR_shader_ballot

From: Connor Abbott For SPIR-V, Khronos decided to make the SubGroup*Mask system values consist of 4 32-bit components rather than one 64-bit component. Although we'll lower away the difference in nir_lower_system_values so drivers won't have to deal with them, adding these

[Mesa-dev] [PATCH 05/17] mesa: fix 64-bit issues with system_values_read

From: Connor Abbott We're about to bump the number of system values above 32. The system_values_read bitfield itself is 64 bits, but some users weren't taking that into account. Fix the ones I could find by grepping for "system_values_read". This prevents regressions at

[Mesa-dev] [PATCH 08/17] nir/spirv: add plumbing for KHR_shader_ballot and KHR_subgroup_vote

From: Connor Abbott Signed-off-by: Connor Abbott --- src/compiler/spirv/nir_spirv.h | 2 + src/compiler/spirv/spirv_to_nir.c | 80 ++ src/compiler/spirv/vtn_variables.c | 28 + 3 files changed, 110

[Mesa-dev] [PATCH 07/17] nir/lower_system_values: handle SPIR-V shader_ballot system values

From: Connor Abbott Lower them to the GL version. Signed-off-by: Connor Abbott --- src/compiler/nir/nir_lower_system_values.c | 38 ++ 1 file changed, 38 insertions(+) diff --git

[Mesa-dev] [PATCH 01/17] nir: introduce new convergent and cross-thread attributes

From: Connor Abbott These are properties of the instruction that must be respected when moving it around, in addition to the usual SSA dominance guarantee. Previously, we only had special handling for fddx and fddy, in a very ad-hoc way. But with arb_shader_ballot and

[Mesa-dev] [PATCH 02/17] nir/gcm: use the new cross-thread attribute

From: Connor Abbott Signed-off-by: Connor Abbott --- src/compiler/nir/nir_opt_gcm.c | 72 ++ 1 file changed, 23 insertions(+), 49 deletions(-) diff --git a/src/compiler/nir/nir_opt_gcm.c

[Mesa-dev] [PATCH 03/17] nir: take cross-thread operations into account into a few places

From: Connor Abbott These optimizations happened to work with derivatives, but they won't with upcoming shader_ballot and group_vote instructions. Signed-off-by: Connor Abbott --- src/compiler/nir/nir_instr_set.c | 22 ++

[Mesa-dev] [PATCH 00/17] radv: Support for subgroup_vote and shader_ballot

From: Connor Abbott This series adds all the bits to enable EXT_shader_subgroup_vote and EXT_shader_subgroup_ballot for radv. It's based on my previous series to fix some 64-bit bugs in radv and anv, since nothing would work without them. Patches 1-4 are a resend of my

[Mesa-dev] [PATCH 04/17] nir: add ARB_shader_ballot and ARB_shader_group_vote instructions

From: Connor Abbott v2: make every instruction an intrinsic, add missing subgroup_size, also add system value translation stuff Signed-off-by: Connor Abbott --- src/compiler/nir/nir.c| 28

[Mesa-dev] [PATCH 3/3] mesa/st: glsl_to_tgsi: tie in the new register renaming approach

This patch replaces the old register livetime estimation with the new approach. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH 2/3] mesa/st: glsl_to_tgsi Implement a new lifetime tracker for temporaries

This patch adds new classes and tests to implement a tracker for the life time of temporary registers for the register renaming stage of glsl_to_tgsi. The tracker aims at estimating the shortest possible life time for each register. The code base requires c++11, the flag is propagated from the

[Mesa-dev] [PATCH 1/3] mesa/st: glsl_to_tgsi move some helper classes to extra files

To prepare the implementation of a temp register lifetime tracker some of the classes are moved into seperate header/implementation files to make them accessible from other files. --- src/mesa/Makefile.sources | 2 + src/mesa/state_tracker/st_glsl_to_tgsi.cpp |

[Mesa-dev] [PATCH 0/3] [RFC] mesa/st: glsl_to_tgsi: improved temp-reg lifetime estimation

Dear all, as I wrote before, I was looking into the temporary register renaming. This series of patches implements a new approach that achieves a tigher estimation of the life time of the temporaries, and as a result the Piano and Voloplosion benchmarks implemented in gputest [1] now work.

Re: [Mesa-dev] [PATCH 2/3] i965/miptree: Separate src and dst slice specifiers in slice copy

The existence of this software fallback makes me sad . On June 9, 2017 7:05:33 AM Topi Pohjolainen wrote: Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 60 --- 1 file

Re: [Mesa-dev] [PATCH 1/2] i965: include gen4_blorp_exec.h into EXTRA_DIST

Reviewed-by: Jason Ekstrand On June 9, 2017 9:01:38 AM "Juan A. Suarez Romero" wrote: Otherwise, `make distcheck` will fail. --- src/mesa/drivers/dri/i965/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 13/24] i965/cnl: Update few assertions

On June 9, 2017 2:41:46 PM Anuj Phogat wrote: On Thu, Jun 8, 2017 at 5:07 PM, Jason Ekstrand wrote: On Mon, May 15, 2017 at 10:05 AM, Anuj Phogat wrote: On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

https://bugs.freedesktop.org/show_bug.cgi?id=101334 John changed: What|Removed |Added CC||airl...@freedesktop.org

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #4 from John --- Alright, after bisecting here's the problematic commit: https://cgit.freedesktop.org/mesa/mesa/commit/?id=bcae3274692954ad2cd6dfc253579ec98d50856f Thanks! -- You are receiving this mail

Re: [Mesa-dev] [PATCH V2 00/24] Add Cannonlake support

On Thu, Jun 8, 2017 at 5:23 PM, Jason Ekstrand wrote: > I think I've now reviewed everything except 2 patches. For the "Update a > few assertions" patch, you said you would run a test but never reported back > the results. The other is the patch for re-enabling sRGB

Re: [Mesa-dev] [PATCH 13/24] i965/cnl: Update few assertions

On Thu, Jun 8, 2017 at 5:07 PM, Jason Ekstrand wrote: > On Mon, May 15, 2017 at 10:05 AM, Anuj Phogat wrote: >> >> >> >> On Sat, May 13, 2017 at 9:43 AM, Jason Ekstrand >> wrote: >>> >>> On May 12, 2017 4:41:36 PM Anuj Phogat

[Mesa-dev] [PATCH] i965: Call intel_prepare_render() from intel_update_state()

The resolve code looks at the current color draw buffers. These are not valid until intel_prepare_render() is called. You can end up with one color buffer bound, but where the renderbuffer has zero width/height and no miptree allocated. You can get a call chain like: _mesa_Clear ->

[Mesa-dev] [Bug 101338] Mesa software rendering draws incompletely on Raspberry Pi

https://bugs.freedesktop.org/show_bug.cgi?id=101338 --- Comment #5 from Lloyd Wood --- Brian, Thanks for checking this out. Which versions of Geomview and SaVi did you install? Seeing a solid blue sphere on your Intel system suggests either that texturemapping is not

[Mesa-dev] [Bug 101338] Mesa software rendering draws incompletely on Raspberry Pi

https://bugs.freedesktop.org/show_bug.cgi?id=101338 --- Comment #4 from Roland Scheidegger --- The original Raspberry Pi IIRC doesn't even support NEON. Theoretically, llvm should still support all the vector instructions by decomposing them into scalar ones, but if that

Re: [Mesa-dev] [PATCH 3/2] r600g, compute: provide local copy of ac_binary.{h, c}

On Fri, 2017-06-09 at 13:44 -0500, Aaron Watry wrote: > On Fri, Jun 9, 2017 at 12:36 PM, Jan Vesely wrote: > > On Fri, 2017-06-09 at 10:12 -0500, Aaron Watry wrote: > > > On Fri, Jun 9, 2017 at 8:20 AM, Jan Vesely wrote: > > > > This is a verbatim

Re: [Mesa-dev] [PATCH 3/2] r600g, compute: provide local copy of ac_binary.{h, c}

On Fri, Jun 9, 2017 at 12:36 PM, Jan Vesely wrote: > On Fri, 2017-06-09 at 10:12 -0500, Aaron Watry wrote: >> On Fri, Jun 9, 2017 at 8:20 AM, Jan Vesely wrote: >> > This is a verbatim copy of the code. The functions can be cleaned up since >> >

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

Reviewed-by: Connor Abbott On Tue, Jun 6, 2017 at 4:25 PM, Grazvydas Ignotas wrote: > This will allow to constify other things. > > Signed-off-by: Grazvydas Ignotas > --- > src/compiler/nir/nir.h | 25

Re: [Mesa-dev] [PATCH 3/2] r600g, compute: provide local copy of ac_binary.{h, c}

On Fri, 2017-06-09 at 10:12 -0500, Aaron Watry wrote: > On Fri, Jun 9, 2017 at 8:20 AM, Jan Vesely wrote: > > This is a verbatim copy of the code. The functions can be cleaned up since > > r600 does not use all the stuff that gcn does. > > The symbol names have been

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

On Friday, 2017-06-09 20:23:04 +0300, Grazvydas Ignotas wrote: > Ping. Boring patch, should be easy to review or NAK. Don't know anything about NIR, so no clue if it's a good idea, but I personally like `const` (I think it should've been the default :P) and this patch looks good to me:

[Mesa-dev] [PATCH v2 3/3] r600g, compute: provide local copy of functions from ac_binary.c

This is a verbatim copy of the code. The functions can be cleaned up since r600 does not use all the stuff that gcn does. The symbol names have been changed since we still use ac_binary.h header (for struct definition) v2: Add ifdef guard around r600_binary_clean call (Aaron) Remove stray

[Mesa-dev] [Bug 101334] Any vulkan app seems to freeze the system

https://bugs.freedesktop.org/show_bug.cgi?id=101334 --- Comment #3 from Eric Engestrom --- (In reply to John from comment #2) > Would anything else help? It would be really helpful if you could bisect the issue. This means picking an app (game) that was working and

Re: [Mesa-dev] [PATCH] nir: make various getters take const pointers

Ping. Boring patch, should be easy to review or NAK. On Wed, Jun 7, 2017 at 2:25 AM, Grazvydas Ignotas wrote: > This will allow to constify other things. > > Signed-off-by: Grazvydas Ignotas > --- > src/compiler/nir/nir.h | 25

[Mesa-dev] [PATCH 2/2] r600/eg: distribute egd_tables.py in the dist file

Otherwise, `make distcheck` will fail. --- src/gallium/drivers/r600/Makefile.am | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/Makefile.am b/src/gallium/drivers/r600/Makefile.am index 44fd51d..2b1ffb5 100644 --- a/src/gallium/drivers/r600/Makefile.am +++

[Mesa-dev] [PATCH 1/2] i965: include gen4_blorp_exec.h into EXTRA_DIST

Otherwise, `make distcheck` will fail. --- src/mesa/drivers/dri/i965/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/dri/i965/Makefile.am b/src/mesa/drivers/dri/i965/Makefile.am index 762aefc..e2d5992 100644 --- a/src/mesa/drivers/dri/i965/Makefile.am +++

Re: [Mesa-dev] [PATCH 2/2] RFC: radeon/compute: Limit allocations for VRAM-based chips to 3/4 VRAM

On Wed, Jun 7, 2017 at 11:12 PM, Aaron Watry wrote: > On Wed, Jun 7, 2017 at 9:15 PM, Michel Dänzer wrote: >> On 08/06/17 03:42 AM, Marek Olšák wrote: >>> On Wed, Jun 7, 2017 at 4:10 PM, Aaron Watry wrote: On Mon, Jun 5, 2017 at 3:07

Re: [Mesa-dev] [PATCH 4/4] egl/dri2: add image extension to swrast_core_extensions

Actually, these are the only patches that are required. We're trying to run the Android Studio emulator using the host's GLES implementation. The emulator uses the image extension in that case: https://android.googlesource.com/platform/sdk/+/emu-2.4-

Re: [Mesa-dev] [PATCH 24.5/24] i965/cnl: Add a preliminary device for Cannonlake

On Thu, Jun 8, 2017 at 5:19 PM, Jason Ekstrand wrote: > I sent out a Vulkan patch (and CCd you) that needs to land before this one > so that we don't accidentally start advertising Vulkan support once the PCI > IDs land. > I'll land the vulkan patch before this one. Thanks.

Re: [Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

On Friday, 2017-06-09 20:13:34 +0530, Harish Krupo wrote: > This patch adds support for the EGL_KHR_partial_update extension for > android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. > 1 test not supported. > > v2: add fallback for eglSetDamageRegionKHR (Tapani) > > v3:

Re: [Mesa-dev] [PATCH 3/2] r600g, compute: provide local copy of ac_binary.{h, c}

On Fri, Jun 9, 2017 at 8:20 AM, Jan Vesely wrote: > This is a verbatim copy of the code. The functions can be cleaned up since > r600 does not use all the stuff that gcn does. > The symbol names have been changed since we still use ac_binary.h header > (for struct

[Mesa-dev] [Bug 101338] Mesa software rendering draws incompletely on Raspberry Pi

https://bugs.freedesktop.org/show_bug.cgi?id=101338 --- Comment #3 from Brian Paul --- I don't have a Raspberry Pi to test with. I installed geomview/savi on my Intel deskside system and tested with both NVIDIA's driver and llvmpipe. With both I see a shaded blue sphere with

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

On Fri, Jun 9, 2017 at 4:31 PM, Samuel Pitoiset wrote: > > > On 06/09/2017 04:26 PM, Marek Olšák wrote: >> >> On Fri, Jun 9, 2017 at 4:00 PM, Samuel Pitoiset >> wrote: >>> >>> >>> >>> On 06/09/2017 03:49 PM, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 2/4] configure.ac: remove explicit -lpthread link

On 9 June 2017 at 14:16, Rowley, Timothy O wrote: > With this patch series applied, the build fails for me on ubuntu 16.04. > Thanks Tim - I can see what's going wrong. I'll double-check things and send v2 in a bit. Emil ___

Re: [Mesa-dev] [Mesa-stable] [PATCH] Reduce zlib requirement from 1.2.8 to 1.2.3.

Hi Emil, Did you test the upstream versions or the distribution ones which tend > to be patched? > Both. I build 17.1.1 against the system supplied zlib-devel packages for 1.2.3 in EL6 and 1.2.7 on EL7. I then swapped out the zlib version at runtime via LD_LIBRARY_PATH with ones build from the

Re: [Mesa-dev] [PATCH] anv: Don't advertise support on anything above gen9

On Thu, Jun 8, 2017 at 5:10 PM, Jason Ekstrand wrote: > This will prevent the driver from even trying to work on Cannon Lake > until we get actual support added. > > Cc: Anuj Phogat > --- > src/intel/vulkan/anv_device.c | 2 +- > 1 file changed, 1

[Mesa-dev] [Bug 101326] gallium/wgl: Allow context creation without prior SetPixelFormat()

https://bugs.freedesktop.org/show_bug.cgi?id=101326 Brian Paul changed: What|Removed |Added Resolution|--- |FIXED

Re: [Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter

Let's not impose behavior that would burden drivers (for example: "idiv by zero must result in ~0u"). Just updating the docs to say the results of div/mod by zero is undefined (unless we know something specific is needed) would be fine. As it is now, some div/mod operations are documented to

[Mesa-dev] [PATCH v5] egl/android: support for EGL_KHR_partial_update

This patch adds support for the EGL_KHR_partial_update extension for android platform. It passes 36/37 tests in dEQP for EGL_KHR_partial_update. 1 test not supported. v2: add fallback for eglSetDamageRegionKHR (Tapani) v3: The native_window_set_surface_damage call is available only from

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

On 06/09/2017 04:26 PM, Marek Olšák wrote: On Fri, Jun 9, 2017 at 4:00 PM, Samuel Pitoiset wrote: On 06/09/2017 03:49 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2

Re: [Mesa-dev] [PATCH] tgsi: clarify TGSI_SEMANTIC_SAMPLEMASK documentation

Reviewed-by: Marek Olšák Marek On Fri, Jun 9, 2017 at 3:56 PM, Brian Paul wrote: > --- > src/gallium/docs/source/tgsi.rst | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/docs/source/tgsi.rst >

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

On Fri, Jun 9, 2017 at 4:00 PM, Samuel Pitoiset wrote: > > > On 06/09/2017 03:49 PM, Marek Olšák wrote: >> >> From: Marek Olšák >> >> --- >> src/gallium/drivers/radeonsi/si_state.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >>

Re: [Mesa-dev] [PATCH v3 57/63] radeonsi: track use of bindless samplers/images from tgsi_shader_info

On Fri, Jun 9, 2017 at 3:35 PM, Samuel Pitoiset wrote: > This adds some new helper functions to know if the current draw > call (or dispatch compute) is using bindless samplers/images, > based on TGSI analysis. > > v3: - add si_context::uses_bindless_{samplers,images} >

[Mesa-dev] [PATCH 2/3] i965/miptree: Separate src and dst slice specifiers in slice copy

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 60 --- 1 file changed, 35 insertions(+), 25 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

[Mesa-dev] [PATCH 3/3] i965/gen4: Add support for single layer in alignment workaround

On gen < 6 one doesn't have level or layer specifiers available for render and depth targets. In order to support rendering to specific level/layer, driver needs to manually offset the surface to the desired slice. There are, however, alignment restrictions to respect as well and in come cases the

[Mesa-dev] [PATCH 1/3] i965/miptree: Clarify face/level/layer in slice copy

Signed-off-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 39 ++- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c

Re: [Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

On 06/09/2017 03:49 PM, Marek Olšák wrote: From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index

Re: [Mesa-dev] [PATCH v3 52/63] radeonsi: implement ARB_bindless_texture

On Fri, Jun 9, 2017 at 3:35 PM, Samuel Pitoiset wrote: > This implements the Gallium interface. Decompression of resident > textures/images will follow in the next patches. > > v3: - do not unmap bindless descriptors > - remove unnecessary util_copy_image_view() >

[Mesa-dev] [PATCH] tgsi: clarify TGSI_SEMANTIC_SAMPLEMASK documentation

--- src/gallium/docs/source/tgsi.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index eceaa6d..7fb963f 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src/gallium/docs/source/tgsi.rst @@ -3298,8

[Mesa-dev] [Bug 101326] gallium/wgl: Allow context creation without prior SetPixelFormat()

https://bugs.freedesktop.org/show_bug.cgi?id=101326 --- Comment #3 from Brian Paul --- Thanks for the info. The patch looks good. I'll push it soon with minor reformatting. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for

[Mesa-dev] [PATCH 2/3] radeonsi: fix missing num_L2_invalidates increment

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 8508259..ec564c1 100644 ---

[Mesa-dev] [PATCH 3/3] radeonsi: don't emit DB_STENCIL_CONTROL if it has no effect

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c index 53f66ac..a8255f2 100644 ---

[Mesa-dev] [PATCH 2/2] gallium/noop: fix sampler views

From: Marek Olšák --- src/gallium/drivers/noop/noop_state.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/noop/noop_state.c b/src/gallium/drivers/noop/noop_state.c index 46d99ab..80cfae8 100644 --- a/src/gallium/drivers/noop/noop_state.c +++

[Mesa-dev] [PATCH 1/3] radeonsi: get rid of more compressed_colortex_mask names

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_blit.c| 4 ++-- src/gallium/drivers/radeonsi/si_descriptors.c | 28 +-- src/gallium/drivers/radeonsi/si_pipe.h| 2 +- src/gallium/drivers/radeonsi/si_state.h | 2 +- 4

[Mesa-dev] [PATCH] st/mesa: call check_program_state only when needed

From: Marek Olšák --- src/mesa/state_tracker/st_atom.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_atom.c b/src/mesa/state_tracker/st_atom.c index cbac762..bcfbcf8 100644 --- a/src/mesa/state_tracker/st_atom.c +++

[Mesa-dev] [PATCH 1/2] gallium/docs: clarify gen_name/get_vendor/get_device_vendor behavior

From: Marek Olšák --- src/gallium/docs/source/screen.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/screen.rst index 852c31b..288fb5c 100644 --- a/src/gallium/docs/source/screen.rst +++

[Mesa-dev] [PATCH v3 63/63] radeonsi: enable ARB_bindless_texture

This has only been tested on RX480. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- docs/features.txt | 2 +- docs/relnotes/17.2.0.html | 1 + src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- 3

[Mesa-dev] [PATCH v3 62/63] radeonsi: add support for loading bindless images

v2: - removed use of the Bindless flags after rebasing - make use of tgsi_is_bindless_image_file() Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 28 +--

[Mesa-dev] [PATCH v3 60/63] radeonsi: invalidate buffers which are made resident if needed

When a buffer becomes resident, check if it has been invalidated, if so update the descriptor and the dirty flag. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/radeonsi/si_descriptors.c | 34

[Mesa-dev] [PATCH v3 48/63] radeonsi: add si_init_descriptor_list() helper

This will be used in order to initialize resident descriptors for bindless textures/images. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 15 +++ 1 file changed, 15

[Mesa-dev] [PATCH v3 61/63] radeonsi: add support for loading bindless samplers

v2: - removed use of the Bindless flags after rebasing Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff

[Mesa-dev] [PATCH] gallium: fixed modulo zero crashes in tgsi interpreter (v2)

softpipe throws integer division by zero exceptions on windows when using % with integers in a geometry shader. v2: Made error results consistent with existing div/mod zero handling in tgsi. 64 bit signed integer division by zero returns zero like in micro_idiv, unsigned returns ~0u like

[Mesa-dev] [PATCH v3 53/63] radeonsi: add all resident buffers to the current CS

Resident buffers have to be added to every new command stream. Though, this could be slightly improved when current shaders don't use any bindless textures/images but usually applications tend to use bindless for almost every draw call, and the winsys thread might help when buffers are added

[Mesa-dev] [PATCH v3 49/63] radeonsi: add si_set_sampler_view_desc() helper

To share some common code between bound and bindless textures. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák --- src/gallium/drivers/radeonsi/si_descriptors.c | 95 +++ 1 file changed, 52 insertions(+), 43

[Mesa-dev] [PATCH v3 59/63] radeonsi: upload new descriptors when resident buffers are invalidated

When texture buffers are invalidated the addr in the resident descriptor has to be updated but we can't create a new descriptor because the resident handle has to be the same. Instead, use the WRITE_DATA packet which allows to update memory directly but graphics/compute have to be idle in case

[Mesa-dev] [PATCH v3 56/63] radeonsi: decompress resident textures/images before graphics/compute

Similar to the existing decompression code path except that it loops over the list of resident textures/images. v3: - move the blitter check back to si_decompress_textures() - decompress resident textures directly in si_decompress_textures() - depth_texture -> needs_depth_decompress -

[Mesa-dev] [PATCH v3 46/63] st/mesa: disable per-context seamless cubemap when using texture handles

The ARB_bindless_texture spec say: "If ARB_seamless_cubemap (or OpenGL 4.0, which includes it) is supported, the per-context seamless cubemap enable is ignored and treated as disabled when using texture handles." "If AMD_seamless_cubemap_per_texture is supported, the seamless

[Mesa-dev] [PATCH v3 54/63] radeonsi: only add descriptors in presence of resident handles

This won't help much except for applications that use a ton of resident handles. Though, this will reduce the winsys overhead a little bit. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) ---

[Mesa-dev] [PATCH v3 58/63] radeonsi: only decompress resident textures/images when used

When the current bound shaders don't use any bindless textures or images, it's useless to decompress the resident resources. v3: - rebased and updated check for compute Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) ---

[Mesa-dev] [PATCH v3 57/63] radeonsi: track use of bindless samplers/images from tgsi_shader_info

This adds some new helper functions to know if the current draw call (or dispatch compute) is using bindless samplers/images, based on TGSI analysis. v3: - add si_context::uses_bindless_{samplers,images} - add si_bind_shader_common() to limit code duplication Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v3 55/63] radeonsi: decompress DCC for resident textures/images

Analogous to bound textures/images. We should also update the resident descriptors and disable COMPRESSION_EN for avoiding useless DCC fetches, but I postpone this optimization for a separate series. v3: - remove use of si_update_check_render_feedback() v2: - store pipe_sampler_view instead of

[Mesa-dev] [PATCH v3 39/63] st/mesa: implement ARB_bindless_texture

v2: - remove "texture" parameter from create_texture_handle() Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle (v1) Reviewed-by: Marek Olšák (v2) --- src/mesa/state_tracker/st_cb_texture.c | 84

[Mesa-dev] [PATCH v3 51/63] radeonsi: add a slab allocator for bindless descriptors

For each texture/image handles, we need to allocate a new buffer for the bindless descriptor. But when the number of buffers added to the current CS becomes high, the overhead in the winsys (and in the kernel) is important. To reduce this bottleneck, the idea is to suballocate the bindless

[Mesa-dev] [PATCH v3 50/63] radeonsi: add si_set_shader_image_desc() helper

To share some common code between bound and bindless images. v3: - use vi_dcc_enabled() instead of dcc_offset for images Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák (v2) --- src/gallium/drivers/radeonsi/si_descriptors.c | 79

[Mesa-dev] [PATCH v3 52/63] radeonsi: implement ARB_bindless_texture

This implements the Gallium interface. Decompression of resident textures/images will follow in the next patches. v3: - do not unmap bindless descriptors - remove unnecessary util_copy_image_view() - use READON_USAGE_READWRITE because of the WRITE_DATA packet - replace

[Mesa-dev] [PATCH v3 42/63] st/mesa: add st_convert_image_from_unit() helper

Signed-off-by: Samuel Pitoiset Reviewed-by: Nicolai Hähnle Reviewed-by: Marek Olšák --- src/mesa/state_tracker/st_atom_image.c | 33 ++--- src/mesa/state_tracker/st_texture.h| 5 + 2

  1   2   >