Re: [Mesa-dev] [PATCH 2/4] intel/compiler: Don't propagate cmod into integer multiplies

On Wed, Oct 4, 2017 at 4:58 PM, Jason Ekstrand wrote: > No shader-db change on Sky Lake. > > Cc: mesa-sta...@lists.freedesktop.org > --- > src/intel/compiler/brw_fs_cmod_propagation.cpp | 17 + > src/intel/compiler/brw_vec4_cmod_propagation.cpp | 17

Re: [Mesa-dev] [PATCH] i965/fs: Extend the live ranges of VGRFs which leave loops

Bah! This one's bogus too. I think it messes up register coalesce but I'm not 100% sure... On Wed, Oct 4, 2017 at 8:22 PM, Jason Ekstrand wrote: > Cc: mesa-sta...@lists.freedesktop.org > --- > src/intel/compiler/brw_fs_live_variables.cpp | 55 >

Re: [Mesa-dev] [PATCH 4/4] i965/gen10: Implement Wa3DStateMode

On Wed, Oct 4, 2017 at 3:11 PM, Anuj Phogat wrote: > On Mon, Oct 2, 2017 at 7:46 PM, Jason Ekstrand > wrote: > > On Mon, Oct 2, 2017 at 4:08 PM, Anuj Phogat > wrote: > >> > >> Cc: mesa-sta...@lists.freedesktop.org > >>

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

This should be good for radeonsi to implement the feature as well. FWIW: Reviewed-by: Andres Rodriguez Little bikeshed comment. I'm a little iffy about using a mask instead of an enum for priority values. It limits the flexibility on the number of levels drastically.

Re: [Mesa-dev] [PATCH 3/4] intel/cfg: Always add both successors to a break

New patch on the list. On Wed, Oct 4, 2017 at 7:42 PM, Jason Ekstrand wrote: > On Wed, Oct 4, 2017 at 5:35 PM, Jason Ekstrand > wrote: > >> On Wed, Oct 4, 2017 at 5:29 PM, Connor Abbott >> wrote: >> >>> This won't completely

[Mesa-dev] [PATCH] i965/fs: Extend the live ranges of VGRFs which leave loops

Cc: mesa-sta...@lists.freedesktop.org --- src/intel/compiler/brw_fs_live_variables.cpp | 55 1 file changed, 55 insertions(+) diff --git a/src/intel/compiler/brw_fs_live_variables.cpp b/src/intel/compiler/brw_fs_live_variables.cpp index c449672..23ec280 100644 ---

Re: [Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

> On Oct 4, 2017, at 12:50, Marek Olšák wrote: > > The LLVM backends selects MAD (unfused) for fmuladd, and FMA (fused) for fma. For f64 and f16 by default it will emit an FMA since mad doesn’t support denorms.___ mesa-dev mailing

Re: [Mesa-dev] [PATCH 3/4] intel/cfg: Always add both successors to a break

On Wed, Oct 4, 2017 at 5:35 PM, Jason Ekstrand wrote: > On Wed, Oct 4, 2017 at 5:29 PM, Connor Abbott wrote: > >> This won't completely solve the problem. For example, what if you >> hoist the assignment to color2 outside the loop? >> >> vec4 color2;

Re: [Mesa-dev] [PATCH 10/21] i965: Only add the wpos state reference if we lowered something

On 2017-09-29 14:25:10, Jason Ekstrand wrote: > Otherwise, in the ARB program case _mesa_add_state_reference may grow > the parameter array which will cause brw_nir_setup_arb_uniforms to write > past the end of the param array because it only looks at the parameter > list length but the parma

Re: [Mesa-dev] [PATCH 06/21] i965: Store image_param in brw_context instead of prog_data

On 2017-09-29 14:25:06, Jason Ekstrand wrote: > This burns an extra 10k of memory or so in the case where you don't have > any images. However, if you have several shaders which use images, this > should be much less memory. It also gets rid of a part of prog_data > that really has nothing to do

Re: [Mesa-dev] [PATCH 3/4] intel/cfg: Always add both successors to a break

On Wed, Oct 4, 2017 at 8:35 PM, Jason Ekstrand wrote: > On Wed, Oct 4, 2017 at 5:29 PM, Connor Abbott wrote: >> >> This won't completely solve the problem. For example, what if you >> hoist the assignment to color2 outside the loop? >> >> vec4 color2;

Re: [Mesa-dev] [PATCH 3/4] intel/cfg: Always add both successors to a break

On Wed, Oct 4, 2017 at 5:29 PM, Connor Abbott wrote: > This won't completely solve the problem. For example, what if you > hoist the assignment to color2 outside the loop? > > vec4 color2; > while (1) { >vec4 color = texture(); >color2 = color * 2; >if (...) { >

Re: [Mesa-dev] [PATCH 3/4] intel/cfg: Always add both successors to a break

This won't completely solve the problem. For example, what if you hoist the assignment to color2 outside the loop? vec4 color2; while (1) { vec4 color = texture(); color2 = color * 2; if (...) { break; } } gl_FragColor = color2; Now the definition still dominates the use, even

Re: [Mesa-dev] [PATCH 4/6] meson: build gbm

Quoting Eric Anholt (2017-10-04 15:04:28) > Dylan Baker writes: > > > This doesn't include egl support, just dri support. > > > > Signed-off-by: Dylan Baker > > --- > > meson.build | 49 +--- > >

[Mesa-dev] [PATCH 2/4] intel/compiler: Don't propagate cmod into integer multiplies

No shader-db change on Sky Lake. Cc: mesa-sta...@lists.freedesktop.org --- src/intel/compiler/brw_fs_cmod_propagation.cpp | 17 + src/intel/compiler/brw_vec4_cmod_propagation.cpp | 17 + 2 files changed, 34 insertions(+) diff --git

[Mesa-dev] [PATCH 3/4] intel/cfg: Always add both successors to a break

Shader-db results on Sky Lake: total instructions in shared programs: 12955125 -> 12953698 (-0.01%) instructions in affected programs: 55956 -> 54529 (-2.55%) helped: 6 HURT: 38 All of the hurt programs were hurt by exactly one instruction because this patch affects copy

[Mesa-dev] [PATCH 4/4] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

From: Francisco Jerez Currently the liveness analysis pass would extend a live interval up to the top of the program when no unconditional and complete definition of the variable is found that dominates all of its uses. This can lead to a serious performance problem in

[Mesa-dev] [PATCH 1/4] intel/compiler: Don't cmod propagate into a saturated operation

Shader-db results on Sky Lake: total instructions in shared programs: 12954445 -> 12955125 (0.01%) instructions in affected programs: 141862 -> 142542 (0.48%) helped: 0 HURT: 626 Cc: mesa-sta...@lists.freedesktop.org --- src/intel/compiler/brw_fs_cmod_propagation.cpp | 8

Re: [Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

Reviewed-by: Connor Abbott On Wed, Oct 4, 2017 at 4:04 PM, Dave Airlie wrote: > From: Dave Airlie > > As pointed out by Connor we still need to use fma if nir wants > exact (precise) behaviour. > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] [PATCH] gallium: remove TGSI_OPCODE_KILL

I didn't like this when it was proposed a couple weeks ago, and unsurprisingly I still don't like it now. The reason is that KILL is a simple opcode which even maps to what both glsl and d3d10 actually need, whereas KILL_IF is a complicated mess including combined per-channel comparisons. I

Re: [Mesa-dev] [PATCH 2/6] meson: build glx

Quoting Eric Anholt (2017-10-04 14:57:23) > Dylan Baker writes: > > > This gets GLX and the loader building. The resulting GLX and i965 have > > been tested on piglit and seem to work fine. This patch leaves a lot of > > todo's in it's wake, GLX is quite complicated, and the

Re: [Mesa-dev] [PATCH] mesa: Use a 565 format for GL_RGB and GL_UNSIGNED_SHORT_5_6_5 textures.

Kenneth Graunke writes: > Found while trying to optimize an application. > > Not observed to help performance on i965, but should at least reduce > the memory usage of such textures a bit. Reviewed-by: Eric Anholt signature.asc Description: PGP

Re: [Mesa-dev] [PATCH 4/4] i965/gen10: Implement Wa3DStateMode

On Mon, Oct 2, 2017 at 7:46 PM, Jason Ekstrand wrote: > On Mon, Oct 2, 2017 at 4:08 PM, Anuj Phogat wrote: >> >> Cc: mesa-sta...@lists.freedesktop.org >> Signed-off-by: Anuj Phogat >> --- >>

Re: [Mesa-dev] [PATCH 6/6] meson: build classic swrast

Dylan Baker writes: > This adds support for building the classic swrast implementation. This > driver has been tested with glxinfo and glxgears. > > Signed-off-by: Dylan Baker > --- > meson.build | 2 ++ >

Re: [Mesa-dev] [PATCH 4/6] meson: build gbm

Dylan Baker writes: > This doesn't include egl support, just dri support. > > Signed-off-by: Dylan Baker > --- > meson.build | 49 +--- > meson_options.txt | 14 + > src/{loader

Re: [Mesa-dev] [PATCH 3/6] meson: Add support for configuring dri drivers directory.

Dylan Baker writes: > Signed-off-by: Dylan Baker > --- > meson.build | 6 ++ > meson_options.txt| 14 -- > src/glx/meson.build | 2 +- > src/mesa/drivers/dri/meson.build | 2 +- >

Re: [Mesa-dev] [PATCH 1/6] meson: Build i965 and dri stack

Quoting Eric Anholt (2017-10-04 14:34:40) > Dylan Baker writes: > > > This gets pretty much the entire classic tree building, as well as > > i965, including the various glapis. There are some workarounds for bugs > > that are fixed in meson 0.43.0, which is due out on

Re: [Mesa-dev] [PATCH 1/6] meson: Build i965 and dri stack

Quoting Eric Anholt (2017-10-04 14:25:30) > Dylan Baker writes: > > > This gets pretty much the entire classic tree building, as well as > > i965, including the various glapis. There are some workarounds for bugs > > that are fixed in meson 0.43.0, which is due out on

Re: [Mesa-dev] [PATCH 2/6] meson: build glx

Dylan Baker writes: > This gets GLX and the loader building. The resulting GLX and i965 have > been tested on piglit and seem to work fine. This patch leaves a lot of > todo's in it's wake, GLX is quite complicated, and the build options > involved are many, and the goal at

Re: [Mesa-dev] [PATCH 1/6] meson: Build i965 and dri stack

Dylan Baker writes: > This gets pretty much the entire classic tree building, as well as > i965, including the various glapis. There are some workarounds for bugs > that are fixed in meson 0.43.0, which is due out on October 8th. > > I have tested this with piglit using glx.

Re: [Mesa-dev] [PATCH v3 10/12] anv: add nir lowering pass for ycrcb textures

On Wed, Oct 4, 2017 at 10:34 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > This pass implements all the implicit conversions required by the > VK_KHR_sampler_ycbcr_conversion specification. > > It also inserts plane sources onto sampling instructions that we then > let the

Re: [Mesa-dev] [PATCH 1/6] meson: Build i965 and dri stack

Dylan Baker writes: > This gets pretty much the entire classic tree building, as well as > i965, including the various glapis. There are some workarounds for bugs > that are fixed in meson 0.43.0, which is due out on October 8th. > > I have tested this with piglit using glx.

Re: [Mesa-dev] [PATCH v3 06/12] anv: modify the internal concept of format to express multiple planes

All my comments below are on chunks that are no longer needed now that anv_get_isl_format hasn't had it's name changed. Take or leave them as your personal level of pedantry dictates. :) On Wed, Oct 4, 2017 at 10:34 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > A given Vulkan

[Mesa-dev] [PATCH] gallium: remove TGSI_OPCODE_KILL

From: Marek Olšák It can be recognized from KILL_IF by checking if the src operand is IMM. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi_action.c | 11 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_aos.c| 3 -- src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c| 42

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

On Wed, Oct 4, 2017 at 3:33 PM, Roland Scheidegger wrote: > Am 04.10.2017 um 17:44 schrieb Rob Clark: >> Signed-off-by: Rob Clark >> --- >> src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + >> src/gallium/drivers/freedreno/freedreno_screen.c

Re: [Mesa-dev] [PATCH 1/2] radv: check that pipeline is different before binding it

Series is Reviewed-by: Bas Nieuwenhuizen On Wed, Oct 4, 2017 at 10:27 PM, Samuel Pitoiset wrote: > We only need to dirty the descriptors when the pipeline is > a new one, because user SGPRs can be potentially different. > > Signed-off-by:

[Mesa-dev] [PATCH 1/2] radv: check that pipeline is different before binding it

We only need to dirty the descriptors when the pipeline is a new one, because user SGPRs can be potentially different. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radv: remove useless checks around radv_CmdBindPipeline()

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_blit.c | 6 ++-- src/amd/vulkan/radv_meta_blit2d.c | 18 -- src/amd/vulkan/radv_meta_bufimage.c | 65 +++ src/amd/vulkan/radv_meta_clear.c | 12 +++

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #4 from sergio.calleg...@gmail.com --- @Brian thanks for testing! Indeed, I think that Matlab 2016 is fine with the NVIDIA proprietary driver. However, I cannot use it because I have a KDE desktop and the nvidia proprietary drivers

[Mesa-dev] [PATCH] ac/nir: use llvm fma intrinsic if nir instruction is exact.

From: Dave Airlie As pointed out by Connor we still need to use fma if nir wants exact (precise) behaviour. Signed-off-by: Dave Airlie --- src/amd/common/ac_nir_to_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

What others said, and yes radeonsi shouldn't expose the extension. Other than those: Reviewed-by: Marek Olšák Marek On Wed, Oct 4, 2017 at 5:44 PM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- >

Re: [Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

On Wed, Oct 4, 2017 at 7:35 PM, Ilia Mirkin wrote: > Ah OK. So llvm.fmuladd is more like llvm.fmadontcare. Wrong assumption > on my part. The LLVM backends selects MAD (unfused) for fmuladd, and FMA (fused) for fma. Personally I would prefer having separate fmul and fadd

Re: [Mesa-dev] [PATCH 5/6] freedreno: context priority support

Am 04.10.2017 um 17:44 schrieb Rob Clark: > For devices (and kernels) which support different priority ringbuffers, > expose context priority support. > > Signed-off-by: Rob Clark > --- > src/gallium/drivers/freedreno/freedreno_context.c | 9 - >

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

Am 04.10.2017 um 17:44 schrieb Rob Clark: > Signed-off-by: Rob Clark > --- > src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + > src/gallium/drivers/freedreno/freedreno_screen.c| 1 + > src/gallium/drivers/i915/i915_screen.c | 1 + >

Re: [Mesa-dev] [PATCH v3 08/22] egl/tizen: add support of dri2_loader (v2)

On 4 October 2017 at 15:28, Rob Herring wrote: > On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: >> It adds support of dri2_loader to egl dri2 tizen backend. >> - referenced a basic buffer flow and management implementation from >> android. >> >>

[Mesa-dev] [Bug 102488] radv_handle_depth_image_transition() wrongly clearing depth data when transitioning to htile.

https://bugs.freedesktop.org/show_bug.cgi?id=102488 --- Comment #3 from Bas Nieuwenhuizen --- Note that we are only setting the metadata though. 0x30f should be the metadata that means "data is uncompressed, just take the value from data", 0x is probably "clear

Re: [Mesa-dev] [PATCH 1/2] wayland-drm: use a copy of the wayland_drm_callbacks struct

On 4 October 2017 at 11:46, Daniel Stone wrote: > Hi Emil, > > On 27 September 2017 at 19:49, Emil Velikov wrote: >> The callbacks may be called even when they are no longer valid. >> Say, the user is dlclose(ing) libEGL while the buffers are being

[Mesa-dev] [Bug 103078] MATLAB broken with mesa software rendering

https://bugs.freedesktop.org/show_bug.cgi?id=103078 --- Comment #3 from Brian Paul --- Sergio, I installed the 30-day trial of Matlab r2017b and typed 'opengl info' in the command window. I did not get a java exception. I got an error message that reads: """ MATLAB has

[Mesa-dev] [PATCH v3 12/12] anv: enable VK_KHR_sampler_ycbcr_conversion

Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_device.c | 51 ++-- src/intel/vulkan/anv_extensions.py | 1 + src/intel/vulkan/anv_formats.c | 59 ++ src/intel/vulkan/anv_image.c

Re: [Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

Ah OK. So llvm.fmuladd is more like llvm.fmadontcare. Wrong assumption on my part. On Wed, Oct 4, 2017 at 1:00 PM, Connor Abbott wrote: > No. From the LLVM langref: > > The ‘llvm.fmuladd.*‘ intrinsic functions represent multiply-add > expressions that can be fused if the

[Mesa-dev] [PATCH v3 09/12] anv: prepare sampler emission code for multiplanar images

New settings from the KHR_sampler_ycbcr_conversion specifications might require different sampler settings for luma and chroma planes. This change makes the sampler table emission ready to handle multiple planes. Signed-off-by: Lionel Landwerlin ---

[Mesa-dev] [PATCH v3 10/12] anv: add nir lowering pass for ycrcb textures

This pass implements all the implicit conversions required by the VK_KHR_sampler_ycbcr_conversion specification. It also inserts plane sources onto sampling instructions that we then let the pipeline layout pass deal with, when mapping things correctly to descriptors. v2: Add new file to meson

[Mesa-dev] [PATCH v3 06/12] anv: modify the internal concept of format to express multiple planes

A given Vulkan format can now be decomposed into a set of planes. We now use 'struct anv_format_plane' to represent the format of those planes. v2: by Jason Rename anv_get_plane_format() to anv_get_format_plane() Don't rename anv_get_isl_format() Replace ds_fmt() by fmt2()

[Mesa-dev] [PATCH v3 05/12] anv: prepare formats to handle disjoints sets

Newer format enums start at offset 10, making it impossible to have them all in one table. This change splits the formats into sets that we then access through indirection. v2: rename format_extract to vk_to_anv_format (Chad/Jason) Signed-off-by: Lionel Landwerlin

[Mesa-dev] [PATCH v3 08/12] anv: add descriptor support for multiplanar image/sampler

v2: Drop a memset by using zalloc (Jason) Decouple vulkan descriptors from the underlying binding table (Jason) Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_descriptor_set.c| 24 -

[Mesa-dev] [PATCH v3 07/12] anv: add new formats KHR_sampler_ycbcr_conversion

Adding new downsampling factors for each planes. Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/anv_formats.c| 158 -- src/intel/vulkan/anv_private.h| 10 +++ src/intel/vulkan/vk_format_info.h | 27 +++ 3

[Mesa-dev] [PATCH v3 04/12] isl: fill out layout descriptions for yuv formats

Some description was missing. Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl_format_layout.csv | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/intel/isl/isl_format_layout.csv b/src/intel/isl/isl_format_layout.csv index

[Mesa-dev] [PATCH v3 01/12] vulkan: util: add macros to extract extension/offset number from enums

v2: Simplify offset enum computation (Jason) v3: capitalize macros (Chad) Signed-off-by: Lionel Landwerlin --- src/vulkan/util/vk_util.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/vulkan/util/vk_util.h b/src/vulkan/util/vk_util.h index

[Mesa-dev] [PATCH v3 00/12] anv: implement KHR_sampler_ycbcr_conversion

Hi, A quick update following the comments for the first patches. I suppose newer comments will appear but probably from patch 7 onwards. Cheers, Lionel Landwerlin (12): vulkan: util: add macros to extract extension/offset number from enums isl: make format layout channels accessible by

[Mesa-dev] [PATCH v3 02/12] isl: make format layout channels accessible by index

Signed-off-by: Lionel Landwerlin Reviewed-by: Chad Versace --- src/intel/isl/isl.h | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index

[Mesa-dev] [PATCH v3 03/12] isl: check whether a format is rgb if colorspace is yuv

Suggested by Chad. Signed-off-by: Lionel Landwerlin --- src/intel/isl/isl.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/isl/isl.h b/src/intel/isl/isl.h index 98de4c0f57f..e3acb0ec280 100644 --- a/src/intel/isl/isl.h +++ b/src/intel/isl/isl.h @@

Re: [Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

No. From the LLVM langref: The ‘llvm.fmuladd.*‘ intrinsic functions represent multiply-add expressions that can be fused if the code generator determines that (a) the target instruction set has support for a fused operation, and (b) that the fused operation is more efficient than the equivalent,

[Mesa-dev] [Bug 101397] [EGL] Surfaceless lacks swrast support

https://bugs.freedesktop.org/show_bug.cgi?id=101397 --- Comment #2 from Eric Engestrom --- Initial support has landed yesterday, but might need further work and testing: commit 9d9a46d4efc00b256d2c0d04dda6c4ee3f0dc47a Author: Gurchetan Singh

Re: [Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

On 10/04/2017 09:44 AM, Rob Clark wrote: Signed-off-by: Rob Clark --- src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + src/gallium/drivers/freedreno/freedreno_screen.c| 1 + src/gallium/drivers/i915/i915_screen.c | 1 +

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

On 4 October 2017 at 15:10, Jan Vesely wrote: > On Wed, 2017-10-04 at 14:59 +0100, Emil Velikov wrote: >> On 3 October 2017 at 19:19, Jan Vesely wrote: >> > On Tue, 2017-10-03 at 17:51 +0100, Emil Velikov wrote: >> > > From: Emil Velikov

Re: [Mesa-dev] [PATCH 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

On Mon, Oct 02, 2017 at 07:39:04PM -0700, Jason Ekstrand wrote: > On Mon, Oct 2, 2017 at 4:07 PM, Anuj Phogat wrote: > > WaFlushHangWhenNonPipelineStateAndMarkerStalled goes along > with WaSampleOffsetIZ. Both recommends the same. > > Cc:

Re: [Mesa-dev] [PATCH 1/4] i965/gen10: Implement WaSampleOffsetIZ workaround

Hi Anuj, On Mon, Oct 02, 2017 at 04:07:57PM -0700, Anuj Phogat wrote: > WaFlushHangWhenNonPipelineStateAndMarkerStalled goes along > with WaSampleOffsetIZ. Both recommends the same. > > Cc: mesa-sta...@lists.freedesktop.org > Signed-off-by: Anuj Phogat > --- >

Re: [Mesa-dev] [PATCH 2/6] meson: build glx

Meson does in most cases, just apparently not in options. I'm going to write a patch for it right now. Dylan Quoting Nicholas Miell (2017-10-03 18:38:26) > On 10/03/2017 05:26 PM, Dylan Baker wrote: > > > diff --git a/meson_options.txt b/meson_options.txt > > index 568903f1a0a..62d6b593f88

[Mesa-dev] [PATCH 5/6] freedreno: context priority support

For devices (and kernels) which support different priority ringbuffers, expose context priority support. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 9 - src/gallium/drivers/freedreno/freedreno_screen.c | 12 +++-

[Mesa-dev] [PATCH 4/6] freedreno: per-context fd_pipe

To enable per-context priorities, we need to have per-context pipe's. Unfortunately we still need to keep the global screen pipe, mostly just for screen->get_timestamp(). Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a5xx/fd5_draw.c | 2 +-

[Mesa-dev] [PATCH 6/6] freedreno: add debug flag to force high priority context

Mainly for testing, FD_MESA_DEBUG=hiprio will force high priority contexts. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/freedreno_context.c | 4 +++- src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/freedreno/freedreno_util.h|

[Mesa-dev] [PATCH 3/6] freedreno: rename pipe -> vsc_pipe

To add context priority support we need to have an fd_pipe per context, rather than per-screen. Which conflicts with existing ctx->pipe (which is actually a visibility stream pipe (hw resource). So just rename it. Signed-off-by: Rob Clark ---

[Mesa-dev] [PATCH 2/6] freedreno: pass context flags through to fd_context_init()

Prep work for later patch. Signed-off-by: Rob Clark --- src/gallium/drivers/freedreno/a2xx/fd2_context.c | 2 +- src/gallium/drivers/freedreno/a3xx/fd3_context.c | 2 +- src/gallium/drivers/freedreno/a4xx/fd4_context.c | 2 +-

[Mesa-dev] [PATCH 1/6] gallium: plumb context priority through to driver

Signed-off-by: Rob Clark --- src/gallium/drivers/etnaviv/etnaviv_screen.c| 1 + src/gallium/drivers/freedreno/freedreno_screen.c| 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c| 1 +

[Mesa-dev] [PATCH 0/6] gallium/freedreno support for context priority

These apply on top of Chris Wilson's patches which add the corresponding EGL/core bits for IMG_context_priority[1] and add the gallium and freedreno bits. The freedreno parts depend on some libdrm_freedreno patches that are WIP (need updating for some last minute changes we made to the kernel

Re: [Mesa-dev] [PATCH v3 22/22] docs: add a high level info about Tizen / Tizen Porting Layer (TPL) for EGL / Tizen Buffer Manager (TBM) / etc

On Wednesday, 2017-10-04 06:50:34 +, Gwan-gyeong Mun wrote: > It gives a quick overview and references of developing OpenGLES / EGL > Driver for Tizen. Thanks for that; haven't read through it, but it should be quite useful :) One request below. > > Signed-off-by: Mun Gwan-gyeong

Re: [Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

Wouldn't this guarantee that nothing is fused (and thus fine)? Presumably fmuladd always does mul+add either as 1 or 2 instructions? On Wed, Oct 4, 2017 at 10:57 AM, Connor Abbott wrote: > If the fma has the exact flag, then we need to use the llvm.fma > intrinsic. These

Re: [Mesa-dev] [PATCH v2 01/11] vulkan: util: add macros to extract extension/offset number from enums

On 04/10/17 00:40, Chad Versace wrote: On Tue 03 Oct 2017, Jason Ekstrand wrote: On Tue, Oct 3, 2017 at 3:18 PM, Lionel Landwerlin <[1] lionel.g.landwer...@intel.com> wrote: On 03/10/17 21:21, Chad Versace wrote: On Tue 03 Oct 2017, Lionel Landwerlin wrote: On

Re: [Mesa-dev] [PATCH v2 09/11] anv: add nir lowering pass for ycrcb textures

On 04/10/17 00:58, Jason Ekstrand wrote: +   struct ycbcr_state state = { +      .builder = builder, +      .origin_tex = tex, +      .conversion = sampler->conversion, What about arrays of samplers?  You're not allowed to indirect on them but they can, in

Re: [Mesa-dev] [PATCH v2 09/11] anv: add nir lowering pass for ycrcb textures

On 04/10/17 00:54, Jason Ekstrand wrote: On Tue, Oct 3, 2017 at 9:29 AM, Lionel Landwerlin > wrote: This pass implements all the implicit conversions required by the VK_KHR_sampler_ycbcr_conversion specification.

Re: [Mesa-dev] [PATCH] radv: emit fmuladd instead of fma to llvm.

If the fma has the exact flag, then we need to use the llvm.fma intrinsic. These come from fma() calls with the precise or invariant qualifiers in GLSL, where you basically have to fuse everything or fuse nothing consistently, and llvm.fmuladd doesn't guarantee that. On Tue, Oct 3, 2017 at 10:10

Re: [Mesa-dev] [PATCH v3 05/22] egl: add dri2_egl_surface_free_outdated_buffers_and_update_size() helper

On Wednesday, 2017-10-04 06:50:17 +, Gwan-gyeong Mun wrote: > To share common free outdated buffers and update size code. > This compares width and height arguments with current egl surface dimension, > if the compared surface dimension is differ, then it free local buffers and > updates

Re: [Mesa-dev] [PATCH v3 13/22] egl: add dri2_egl_surface_destroy_image_front() helper

On Wed, Oct 4, 2017 at 9:02 AM, Rob Herring wrote: > On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: >> To share common destroy dri_image_front code. >> >> Signed-off-by: Mun Gwan-gyeong >> --- >> src/egl/drivers/dri2/egl_dri2.c |

Re: [Mesa-dev] [PATCH v3 08/22] egl/tizen: add support of dri2_loader (v2)

On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: > It adds support of dri2_loader to egl dri2 tizen backend. > - referenced a basic buffer flow and management implementation from android. > > And it implements a query buffer age extesion for tizen and turn on >

Re: [Mesa-dev] [PATCH v3 07/22] egl: add dri2_egl_surface_update_buffer_age() helper

On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: > To share common update buffer age code. > This updates old buffer's age and sets current back buffer's age to 1. > > Signed-off-by: Mun Gwan-gyeong > --- > src/egl/drivers/dri2/egl_dri2.c | 19

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

On Wed, 2017-10-04 at 14:59 +0100, Emil Velikov wrote: > On 3 October 2017 at 19:19, Jan Vesely wrote: > > On Tue, 2017-10-03 at 17:51 +0100, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > The only driver that utilises Clover already

Re: [Mesa-dev] [PATCH v3 13/22] egl: add dri2_egl_surface_destroy_image_front() helper

On Wed, Oct 4, 2017 at 1:50 AM, Gwan-gyeong Mun wrote: > To share common destroy dri_image_front code. > > Signed-off-by: Mun Gwan-gyeong > --- > src/egl/drivers/dri2/egl_dri2.c | 14 ++ > src/egl/drivers/dri2/egl_dri2.h | 3 +++ > 2 files

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

On 3 October 2017 at 19:19, Jan Vesely wrote: > On Tue, 2017-10-03 at 17:51 +0100, Emil Velikov wrote: >> From: Emil Velikov >> >> The only driver that utilises Clover already depends on LLVM 3.9. >> Additionally close to every supported

Re: [Mesa-dev] [PATCH] wayland-egl: redistribute the wayland.egl.h include

On 10/4/17 3:47 PM, Emil Velikov wrote: > On 3 October 2017 at 14:45, Tobias Klausmann > wrote: >> Starting with commit ab0589c6ed ("wayland-egl: remove no longer needed >> wayland-client dependency") the wayland-egl.h include was missing leading to >> a >>

Re: [Mesa-dev] [Libclc-dev] opencl-example: didn't compile (run) with latest LLVM git (for some days)

[dropping the libclc-devel list, which annoying rejects people who are not subscribed] On 3 October 2017 at 13:48, Emil Velikov wrote: > On 20 September 2017 at 18:26, Jan Vesely wrote: >> adding mesa-dev. This is not really related to libclc.

Re: [Mesa-dev] [PATCH 2/2] swr/rast: use proper alignment for debug transposedPrims

Reviewed-by: Bruce Cherniak > On Oct 3, 2017, at 3:23 PM, Tim Rowley wrote: > > Causing a crash in ParaView waveletcontour.py test when > _DEBUG defined due to vector aligned copy with unaligned > address. > --- >

Re: [Mesa-dev] [PATCH] configure.ac: bump Clover LLVM requirement to 3.9

On 10/03/2017 06:51 PM, Emil Velikov wrote: > From: Emil Velikov > > The only driver that utilises Clover already depends on LLVM 3.9. > Additionally close to every supported distribution has said version. > > Additionally libclc requires LLVM 4.0 these days. > >

Re: [Mesa-dev] [PATCH] wayland-egl: redistribute the wayland.egl.h include

On 3 October 2017 at 14:45, Tobias Klausmann wrote: > Starting with commit ab0589c6ed ("wayland-egl: remove no longer needed > wayland-client dependency") the wayland-egl.h include was missing leading to a > build failure: > > CC wayland-egl.lo >

Re: [Mesa-dev] [PATCH mesa] travis: move include path from $CC to $CFLAGS

On Wednesday, 2017-10-04 14:23:46 +0100, Emil Velikov wrote: > On 4 October 2017 at 14:10, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > Considering things still work (I'll push the wayland fix in a second) Yeah, it worked for

[Mesa-dev] [PATCH] i965: pass wanted format to intel_miptree_create_for_dri_image

Change b3a44ae7a4 caused regressions on Android where DRI and renderbuffer can disagree on the format being used. This patch removes the colorspace parameter and instead we pass renderbuffer format. For non-winsys images we still do srgb/linear modification in same manner as change b3a44ae7a4

Re: [Mesa-dev] [PATCH mesa] travis: move include path from $CC to $CFLAGS

On 4 October 2017 at 14:10, Eric Engestrom wrote: > Signed-off-by: Eric Engestrom Considering things still work (I'll push the wayland fix in a second) Reviewed-by: Emil Velikov -Emil

[Mesa-dev] [PATCH mesa] travis: move include path from $CC to $CFLAGS

Signed-off-by: Eric Engestrom --- .travis.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2c87f60ec12c7a287a2c..19fd6acf3b9e4d6d9a8e 100644 --- a/.travis.yml +++ b/.travis.yml @@ -507,7 +507,7 @@ script:

[Mesa-dev] [PATCH] vulkan/wsi/wayland: Extend matching between vk and wl_drm formats

Extend the matching from vk to wl_drm formats and vice-versa, to include all supported RGB(A) formats. Since the memory layout of many Vulkan formats depends on system endianness, take endianness into account when performing the matching. --- src/vulkan/wsi/wsi_common_wayland.c | 166

Re: [Mesa-dev] [PATCH] radv: enable tc compatible htile for d32s8 also.

This totally breaks DOW3, I have to retract my Rb. On 10/04/2017 02:13 PM, Samuel Pitoiset wrote: Reviewed-by: Samuel Pitoiset On 10/04/2017 04:41 AM, Dave Airlie wrote: From: Dave Airlie This enables tc compatible htile for stencil surfaces

Re: [Mesa-dev] [PATCH] radv: enable tc compatible htile for d32s8 also.

Reviewed-by: Samuel Pitoiset On 10/04/2017 04:41 AM, Dave Airlie wrote: From: Dave Airlie This enables tc compatible htile for stencil surfaces as well. This gives a 3-5fps boost on Mad Max on high@4k. It also depends on Bas's tc-compat htile

  1   2   >