Re: [Mesa-dev] Build fail since configure.ac: rework llvm libs handling for 3.9+

2017-10-15 Thread Jan Vesely
On Sun, 2017-10-15 at 00:00 +0100, Andy Furniss wrote: > Andy Furniss wrote: > > Since > > > > commit 13a53c4f5cdd664fd155c9e78fb46a4387af006c > > Author: Emil Velikov > > Date: Thu Oct 5 11:19:05 2017 +0100 > > > > configure.ac: rework llvm libs handling for

Re: [Mesa-dev] Build fail since configure.ac: rework llvm libs handling for 3.9+

2017-10-15 Thread Jan Vesely
On Mon, 2017-10-16 at 02:55 +0200, Dieter Nützel wrote: > Am 15.10.2017 01:00, schrieb Andy Furniss: > > Andy Furniss wrote: > > > Since > > > > > > commit 13a53c4f5cdd664fd155c9e78fb46a4387af006c > > > Author: Emil Velikov > > > Date: Thu Oct 5 11:19:05 2017 +0100

[Mesa-dev] [PATCH v2 1/3] mesa: Add new fast mtx_t mutex type for basic use cases

2017-10-15 Thread Timothy Arceri
While modern pthread mutexes are very fast, they still incur a call to an external DSO and overhead of the generality and features of pthread mutexes. Most mutexes in mesa only needs lock/unlock, and the idea here is that we can inline the atomic operation and make the fast case just two

[Mesa-dev] [PATCH v2 2/3] mesa: use simple mtx in core mesa

2017-10-15 Thread Timothy Arceri
Results from x11perf -copywinwin10 on Eric's SKL: 4.8% ± 0.905054% (n=40) Reviewed-by: Marek Olšák --- src/gallium/state_trackers/dri/dri2.c | 22 +++--- src/mesa/main/bufferobj.c | 14 +++--- src/mesa/main/debug_output.c

[Mesa-dev] [PATCH v2 3/3] amdgpu: use simple mtx

2017-10-15 Thread Timothy Arceri
Reviewed-by: Marek Olšák --- src/gallium/winsys/amdgpu/drm/amdgpu_bo.c | 34 +-- src/gallium/winsys/amdgpu/drm/amdgpu_bo.h | 2 +- src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 20

Re: [Mesa-dev] Build fail since configure.ac: rework llvm libs handling for 3.9+

2017-10-15 Thread Dieter Nützel
Am 15.10.2017 01:00, schrieb Andy Furniss: Andy Furniss wrote: Since commit 13a53c4f5cdd664fd155c9e78fb46a4387af006c Author: Emil Velikov Date: Thu Oct 5 11:19:05 2017 +0100 configure.ac: rework llvm libs handling for 3.9+ I am getting 00s of

Re: [Mesa-dev] Testing out Kristian's fast mtx patch

2017-10-15 Thread Timothy Arceri
On 10/10/17 23:38, Marek Olšák wrote: On Oct 10, 2017 4:46 AM, "Timothy Arceri" > wrote: After a recent discussion about this code from 2015 I was curious to give it a try. The outstanding review item was that we shouldn't

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-10-15 Thread Timothy Arceri
On 16/10/17 04:10, Miklós Máté wrote: Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowing the texture targets until the draw call. When an

Re: [Mesa-dev] [PATCH] main: remove redundant NULL check

2017-10-15 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 16/10/17 04:46, Miklós Máté wrote: update_single_program_texture() never returns NULL. Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] configure.ac: set -O0 on --enable-debug

2017-10-15 Thread Jason Ekstrand
I'm not sure what I think of this patch. On the one hand, I'm constantly setting CFLAGS="-O0 -ggdb3" when I configure and it seems like a nicer default. On the other hand, this is changing the default to something that is different both from what mesa has done for a long time and from the

Re: [Mesa-dev] [PATCH] docs: Add EXT_memory_objects extensions to features.txt

2017-10-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Oct 15, 2017 at 7:03 PM, Jakob Bornecrantz wrote: > These extensions are important for Vulkan interop and various > other use cases. So it would be nice if we tracked them. > > Cheers, Jakob. > >

[Mesa-dev] [PATCH] st/va: Disable vaExportSurfaceHandle()

2017-10-15 Thread Mark Thompson
This is not in libva 2.0, so it shouldn't be enabled yet. Signed-off-by: Mark Thompson --- On 15/10/17 20:06, Leo Liu wrote: > On 2017-10-15 07:23 AM, Mark Thompson wrote: >> This reverts commit c4ed39f85b1ebd062eaa51880fcc79cfbcb4e5c3. > > Can we just leave the code there, and

Re: [Mesa-dev] [PATCH 1/2] Revert "st/va: Implement vaExportSurfaceHandle()"

2017-10-15 Thread Leo Liu
On 2017-10-15 07:23 AM, Mark Thompson wrote: This reverts commit c4ed39f85b1ebd062eaa51880fcc79cfbcb4e5c3. Can we just leave the code there, and gated by "#if 0" for now? so it would be easier for testing purpose. Thanks, Leo --- Apparently the feature set of libva 2.0 was finalised

[Mesa-dev] [PATCH] configure.ac: set -O0 on --enable-debug

2017-10-15 Thread Miklós Máté
Autoconf sets CFLAGS="-g -O2" by default. Signed-off-by: Miklós Máté --- configure.ac | 4 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 62d33a1941..c833d258ed 100644 --- a/configure.ac +++ b/configure.ac @@ -522,6 +522,8 @@ if test

[Mesa-dev] [PATCH] st/mesa: set dimension for constants in ATI_fragment_shader

2017-10-15 Thread Miklós Máté
This fixes an assertion failure introduced by 30a2f0dfd46de. Signed-off-by: Miklós Máté --- src/mesa/state_tracker/st_atifs_to_tgsi.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/state_tracker/st_atifs_to_tgsi.c b/src/mesa/state_tracker/st_atifs_to_tgsi.c

[Mesa-dev] [PATCH] main: remove redundant NULL check

2017-10-15 Thread Miklós Máté
update_single_program_texture() never returns NULL. Signed-off-by: Miklós Máté --- src/mesa/main/texstate.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/mesa/main/texstate.c b/src/mesa/main/texstate.c index edd2253731..776806d632 100644 ---

Re: [Mesa-dev] [PATCH] mesa: fix texture updates for ATI_fragment_shader

2017-10-15 Thread Miklós Máté
Hi, I'd like to ask you to revert this change. As Ian Romanick pointed out this makes ATI_fs behave like ARB_fp, however there is a major difference between the two: with ATI_fs there is no way of knowing the texture targets until the draw call. When an ATI_fs is created,

[Mesa-dev] [PATCH] docs: Add EXT_memory_objects extensions to features.txt

2017-10-15 Thread Jakob Bornecrantz
These extensions are important for Vulkan interop and various other use cases. So it would be nice if we tracked them. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz --- docs/features.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git

[Mesa-dev] [Bug 103283] drm_get_device_name_for_fd is broken on FreeBSD

2017-10-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103283 Bug ID: 103283 Summary: drm_get_device_name_for_fd is broken on FreeBSD Product: Mesa Version: 17.2 Hardware: Other OS: FreeBSD Status: NEW Severity:

[Mesa-dev] [PATCH 2/2] st/va: Implement vaExportSurfaceHandle()

2017-10-15 Thread Mark Thompson
This is a new interface in libva 2.1 to support wider use-cases of passing surfaces to external APIs. In particular, this allows export of NV12 and P010 surfaces. v2: Convert surfaces to progressive before exporting them (Christian). v3: Set destination rectangle to match source when converting

[Mesa-dev] [PATCH 1/2] Revert "st/va: Implement vaExportSurfaceHandle()"

2017-10-15 Thread Mark Thompson
This reverts commit c4ed39f85b1ebd062eaa51880fcc79cfbcb4e5c3. --- Apparently the feature set of libva 2.0 was finalised inside Intel several weeks ago without communicating it externally, and this was not included. Therefore revert support for it here. This should be applied before the Mesa

Re: [Mesa-dev] [PATCH v3 2/2] meson: build freedreno

2017-10-15 Thread Rob Clark
On Sat, Oct 14, 2017 at 11:10 PM, Dylan Baker wrote: > Quoting Rob Clark (2017-10-14 11:41:49) >> Signed-off-by: Rob Clark >> --- >> v1: actually build freedreno >> v2: corrected installed ${driver}_dri.so name >> >> meson.build

Re: [Mesa-dev] [PATCH v3 29/43] i965/fs: Unpack 16-bit from 32-bit components in VS load_input

2017-10-15 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:38:18PM +0200, Jose Maria Casanova Crespo wrote: > The VS load input for 16-bit values receives pairs of 16-bit values > packed in 32-bit values. Because of the adjusted format used at: > > anv/pipeline: Use 32-bit surface formats for 16-bit formats > > v2: Removed

Re: [Mesa-dev] [PATCH v3 28/43] anv/cmd_buffer: Add a padding to the vertex buffer

2017-10-15 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:38:17PM +0200, Jose Maria Casanova Crespo wrote: > From: Alejandro Piñeiro > > As we are using 32-bit surface formats with 16-bit elements we can be > on a situation where a vertex element can poke over the buffer by 2 > bytes. To avoid that we

Re: [Mesa-dev] [PATCH v3 27/43] anv/pipeline: Use 32-bit surface formats for 16-bit formats

2017-10-15 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:38:16PM +0200, Jose Maria Casanova Crespo wrote: > From: Alejandro Piñeiro > > From Vulkan 1.0.50 spec, Section 3.30.1. Format Definition: > VK_FORMAT_R16G16_SFLOAT > > A two-component, 32-bit signed floating-point format that has a >

Re: [Mesa-dev] [PATCH v3 25/43] compiler: Mark when input/ouput attribute at VS uses 16-bit

2017-10-15 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:38:14PM +0200, Jose Maria Casanova Crespo wrote: > New shader attribute to mark when a location has 16-bit > value. This patch includes support on mesa glsl and nir. > --- > src/compiler/glsl_types.h | 24 >

Re: [Mesa-dev] [PATCH v3 23/43] i965/fs: Add byte scattered read message and fs support

2017-10-15 Thread Pohjolainen, Topi
On Thu, Oct 12, 2017 at 08:38:12PM +0200, Jose Maria Casanova Crespo wrote: > --- > src/intel/compiler/brw_eu.h| 7 + > src/intel/compiler/brw_eu_defines.h| 2 ++ > src/intel/compiler/brw_eu_emit.c | 41 > ++ >