Re: [Mesa-dev] [PATCH] nir: Don't print swizzles when there are more than 4 components

On October 27, 2017 18:21:45 Matt Turner wrote: ... as can happen with various types like mat4, or else we'll smash the stack writing past the end of components_local[]. Ugh... Ideally, I think you'd want without_matrix() because a matrix is just an array as far as

[Mesa-dev] [PATCH] nir: Don't print swizzles when there are more than 4 components

... as can happen with various types like mat4, or else we'll smash the stack writing past the end of components_local[]. Fixes: 5a0d3e1129b7 ("nir: Print the components referenced for split or packed shader in/outs.") --- Reproduce with INTEL_DEBUG=vs and

Re: [Mesa-dev] [Mesa-stable] [PATCH v3 14/48] i965/fs: Extend the live ranges of VGRFs which leave loops

I've submitted an alternative to this approach here [1], more along the lines of the v1 patch you borrowed from my jenkins branch. Most of the reasons for that we have discussed already in the office (except for the last point), but FTR: - This patch only works around the problem by tweaking

Re: [Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

On Fri, Oct 27, 2017 at 3:16 PM, Nanley Chery wrote: > On Fri, Oct 27, 2017 at 12:52:30PM -0700, Jason Ekstrand wrote: > > On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery > > wrote: > > > > > Only use CCS_E to render to a texture that is

[Mesa-dev] [PATCH 2/3] intel/fs: Don't let undefined values prevent copy propagation.

This makes the dataflow propagation logic of the copy propagation pass more intelligent in cases where the destination of a copy is known to be undefined for some incoming CFG edges, building upon the definedness information provided by the last patch. Helps a few programs, and avoids a handful

[Mesa-dev] [PATCH 1/3] intel/fs: Restrict live intervals to the subset possibly reachable from any definition.

Currently the liveness analysis pass would extend a live interval up to the top of the program when no unconditional and complete definition of the variable is found that dominates all of its uses. This can lead to a serious performance problem in shaders containing many partial writes, like

[Mesa-dev] [PATCH 3/3] intel/cfg: Represent divergent control flow paths caused by non-uniform loop execution.

This addresses a long-standing back-end compiler bug that could lead to cross-channel data corruption in loops executed non-uniformly. In some cases live variables extending through a loop divergence point (e.g. a non-uniform break) into a convergence point (e.g. the end of the loop) wouldn't be

Re: [Mesa-dev] [PATCH v2] wayland-drm: static inline wayland_drm_buffer_get

On 24 October 2017 at 17:14, Emil Velikov wrote: > From: Emil Velikov > > The function is effectively a direct function call into > libwayland-server.so. > > Thus GBM no longer depends on the wayland-drm static library, making the > build

Re: [Mesa-dev] [PATCH v2] clover/llvm: Drop support for LLVM < 3.9.

Vedran Miletić writes: > v2: remove/inline compat stuff > > Reviewed-by: Francisco Jerez > --- > .../state_trackers/clover/llvm/codegen/native.cpp | 8 +- > src/gallium/state_trackers/clover/llvm/compat.hpp | 109 > + >

Re: [Mesa-dev] [PATCH 1/7] util: move futex helpers into futex.h

On 23/10/17 05:33, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/util/Makefile.sources | 1 + src/util/futex.h | 51 +++ src/util/meson.build | 1 + src/util/simple_mtx.h | 20

Re: [Mesa-dev] [PATCH V2 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

On Fri, Oct 27, 2017 at 4:00 PM, Kenneth Graunke wrote: > On Friday, October 27, 2017 3:17:20 PM PDT Anuj Phogat wrote: >> V2: Use _NEW_BUFFERS in place of _NEW_MULTISAMPLE >> >> Signed-off-by: Anuj Phogat >> Cc: Kenneth Graunke

Re: [Mesa-dev] [PATCH V2 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

On Friday, October 27, 2017 3:17:20 PM PDT Anuj Phogat wrote: > V2: Use _NEW_BUFFERS in place of _NEW_MULTISAMPLE > > Signed-off-by: Anuj Phogat > Cc: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 13 - > 1

Re: [Mesa-dev] [PATCH] scons: fix OSMesa driver build

Looks alright too. Reviewed-by: Roland Scheidegger Am 28.10.2017 um 00:35 schrieb Brian Paul: > Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" > --- > src/mesa/drivers/osmesa/SConscript | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [Mesa-dev] [PATCH] scons: fix OSMesa driver build

Ah, I see that you fixed that already, Reviewed-by: Dylan Baker Quoting Brian Paul (2017-10-27 15:35:09) > Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" > --- > src/mesa/drivers/osmesa/SConscript | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [Mesa-dev] [PATCH] scons: fix OSMesa driver build

I sent almost the same patch at exactly the same time. I also needed to add this path to src/map/glapi/Sconscript to get scons building. Maybe that's unrelated? Dylan Quoting Brian Paul (2017-10-27 15:35:09) > Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" > --- >

[Mesa-dev] [PATCH] scons: fix OSMesa driver build

Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" --- src/mesa/drivers/osmesa/SConscript | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/drivers/osmesa/SConscript b/src/mesa/drivers/osmesa/SConscript index 7280314..9391dc3 100644 ---

[Mesa-dev] [AppVeyor] mesa master #5970 completed

Build mesa 5970 completed Commit 05592cebd4 by Brian Paul on 10/27/2017 9:14 PM: scons: fix scons build to find generated glapitable.h\n\nFixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path"\n\nReviewed-by: Roland Scheidegger

[Mesa-dev] [PATCH] scons: Fix glapi include path changes

fixes: 5daed06da2c0aaa4 ("osmesa: Include generated headers without path") cc: Mark Janes Signed-off-by: Dylan Baker --- src/mapi/glapi/SConscript | 1 + src/mesa/drivers/osmesa/SConscript | 4 +++- 2 files changed, 4 insertions(+), 1

[Mesa-dev] [PATCH V2 2/2] i965/gen10: Don't set Antialiasing Enable in 3DSTATE_RASTER if num_samples > 1

V2: Use _NEW_BUFFERS in place of _NEW_MULTISAMPLE. Fix indentation. Signed-off-by: Anuj Phogat Cc: Kenneth Graunke Cc: Matt Turner --- src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ 1 file changed, 10

Re: [Mesa-dev] [PATCH v3.5] intel/compiler: Add union types for prog_data and prog_key stages

On Thu, Oct 26, 2017 at 11:14 PM, Jordan Justen wrote: > Signed-off-by: Jordan Justen > Reviewed-by: Jason Ekstrand > Cc: Jason Ekstrand > Cc: Kenneth Graunke > --- > > *

Re: [Mesa-dev] [RFC 1/2] intel/isl: Disable some gen10 CCS_E formats for now

On Fri, Oct 27, 2017 at 12:50:45PM -0700, Jason Ekstrand wrote: > Thanks for doing this in isl_format_supports_ccs_e instead of changing the > table! > > Reviewed-by: Jason Ekstrand > Thank you for the review! > On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery

[Mesa-dev] [PATCH V2 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

V2: Use _NEW_BUFFERS in place of _NEW_MULTISAMPLE Signed-off-by: Anuj Phogat Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/genX_state_upload.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

On Fri, Oct 27, 2017 at 12:52:30PM -0700, Jason Ekstrand wrote: > On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery > wrote: > > > Only use CCS_E to render to a texture that is CCS_E-compatible with the > > original texture's miptree (linear) format. This prevents render > >

Re: [Mesa-dev] [PATCH 3/3] st/mesa: guard sampler views changes with a mutex

For the series: Reviewed-by: Marek Olšák Marek On Sun, Oct 22, 2017 at 8:39 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Some locking is unfortunately required, because well-formed GL programs > can have multiple

Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

On Fri, Oct 27, 2017 at 2:50 PM, Matt Turner wrote: > On Fri, Oct 27, 2017 at 10:50 AM, Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ >> 1 file changed,

Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

On Fri, Oct 27, 2017 at 2:44 PM, Kenneth Graunke wrote: > On Friday, October 27, 2017 10:50:23 AM PDT Anuj Phogat wrote: >> Signed-off-by: Anuj Phogat >> --- >> src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ >> 1 file changed, 10

Re: [Mesa-dev] [PATCH] scons: fix scons build to find generated glapitable.h

Am 27.10.2017 um 23:16 schrieb Brian Paul: > Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" > --- > src/mapi/glapi/SConscript | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/mapi/glapi/SConscript b/src/mapi/glapi/SConscript > index 994778a..08fed6c 100644 >

Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

On Fri, Oct 27, 2017 at 10:50 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

On Friday, October 27, 2017 10:50:23 AM PDT Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c >

Re: [Mesa-dev] [PATCH] gallium; s/unsigned/enum pipe_prim_type/

Reviewed-by: Roland Scheidegger Am 27.10.2017 um 23:16 schrieb Brian Paul: > In the vbuf_render::set_primitive() functions. > --- > src/gallium/auxiliary/draw/draw_vbuf.h | 3 ++- > src/gallium/drivers/i915/i915_prim_vbuf.c| 2 +- >

Re: [Mesa-dev] [PATCH v2] i965 : optimized bucket index calculation

On 10/24/2017 02:42 AM, Muthukumar, Aravindan wrote: >> -Original Message- >> From: Ian Romanick [mailto:i...@freedesktop.org] >> Sent: Friday, October 20, 2017 9:51 AM >> To: Muthukumar, Aravindan ; mesa- >> d...@lists.freedesktop.org >> Cc: J Karanje,

[Mesa-dev] [PATCH] scons: fix scons build to find generated glapitable.h

Fixes: ea53d9a8eb5d4b2 "glapi: include generated headers without path" --- src/mapi/glapi/SConscript | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mapi/glapi/SConscript b/src/mapi/glapi/SConscript index 994778a..08fed6c 100644 --- a/src/mapi/glapi/SConscript +++

[Mesa-dev] [PATCH] gallium; s/unsigned/enum pipe_prim_type/

In the vbuf_render::set_primitive() functions. --- src/gallium/auxiliary/draw/draw_vbuf.h | 3 ++- src/gallium/drivers/i915/i915_prim_vbuf.c| 2 +- src/gallium/drivers/llvmpipe/lp_setup_vbuf.c | 2 +- src/gallium/drivers/nouveau/nv30/nv30_draw.c | 2 +-

[Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor (v2)

Having moved gallium_dri.so library to /vendor/lib/dri also symlinks need to be coherently created using TARGET_OUT_VENDOR instead of TARGET_OUT or all non Intel drivers will not be loaded with Android N and earlier, thus causing SurfaceFlinger SIGABRT (v2) simplification of post install command

Re: [Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery wrote: > Only use CCS_E to render to a texture that is CCS_E-compatible with the > original texture's miptree (linear) format. This prevents render > operations from writing data that can't be decoded with the original >

Re: [Mesa-dev] [PATCH] intel: common: silence compiler warning

Reviewed-by: Jordan Justen On 2017-10-27 09:44:14, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin > --- > src/intel/common/gen_decoder.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Mesa-dev] [RFC 1/2] intel/isl: Disable some gen10 CCS_E formats for now

Thanks for doing this in isl_format_supports_ccs_e instead of changing the table! Reviewed-by: Jason Ekstrand On Fri, Oct 27, 2017 at 12:24 PM, Nanley Chery wrote: > CannonLake additionally supports R11G11B10_FLOAT and four 10-10-10-2 > formats

Re: [Mesa-dev] [PATCH 1/2] intel/genxml: Fix decoding of groups with fields smaller than a DWord.

On 2017-10-25 21:17:13, Kenneth Graunke wrote: > Groups containing fields smaller than a DWord were not being decoded > correctly. For example: > > > > > > gen_field_iterator_next would properly walk over each element of the > array, incrementing group_iter, and calling

Re: [Mesa-dev] [PATCH v3 31/48] intel/cs: Re-run final NIR optimizations for each SIMD size

On Fri, Oct 27, 2017 at 3:03 AM, Iago Toral wrote: > This should be squashed into the previous commit > Oops... Fixed. > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > With the advent of SPIR-V subgroup operations, compute shaders will > > have > > to be

Re: [Mesa-dev] [PATCH v3 38/48] intel/fs: Don't use automatic exec size

On Fri, Oct 27, 2017 at 4:47 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > The automatic exec size inference can accidentally mess things up if > > we're not careful. For instance, if we have > > > > add(4)g38.2<4>Dg38.1<8,2,4>D

Re: [Mesa-dev] [PATCH v3 23/48] intel/fs: Assign constant locations if they haven't been assigned

On Fri, Oct 27, 2017 at 12:35 AM, Iago Toral wrote: > This sounds good to me, but I guess it is not really fixing anything, > right? I ask because the subject claims that this patch does something > that the original code was already supposed to be doing. > This patch is a

Re: [Mesa-dev] [PATCH v3 29/48] intel/cs: Rework the way thread local ID is handled

On Fri, Oct 27, 2017 at 2:11 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > > Previously, brw_nir_lower_intrinsics added the param and then emitted > > a > > load_uniform intrinsic to load it directly. This commit switches > > things > >

Re: [Mesa-dev] [PATCH v3 25/48] intel/cs: Drop max_dispatch_width checks from compile_cs

On Fri, Oct 27, 2017 at 1:18 AM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > The only things that adjust fs_visitor::max_dispatch_width are render > > target writes which don't happen in compute shaders so they're > > pointless. > > --- > >

[Mesa-dev] [PATCH v2 1/3] glsl_parser_extra: Add utility to copy symbols between symbol tables

From: Eduardo Lima Mitev Some symbols gathered in the symbols table during parsing are needed later for the compile and link stages, so they are moved along the process. Currently, only functions and non-temporary variables are copied between symbol tables. However, the

[Mesa-dev] [PATCH v2 3/3] glsl/linker: Check that re-declared, inter-shader built-in blocks match

From: Eduardo Lima Mitev >From GLSL 4.5 spec, section "7.1 Built-In Language Variables", page 130 of the PDF states: "If multiple shaders using members of a built-in block belonging to the same interface are linked together in the same program, they must all

[Mesa-dev] [PATCH v2 2/3] glsl: Use the utility function to copy symbols between symbol tables

From: Eduardo Lima Mitev This effectively factorizes a couple of similar routines. v2 (Neil Roberts): Non-trivial rebase on master Signed-off-by: Eduardo Lima Mitev Signed-off-by: Neil Roberts ---

[Mesa-dev] [PATCH v2 0/3] Fix for PerVertexValidation CTS test

Hi, Here is a v2 of Eduardo’s patches to fix the PerVertexValidation CTS test. They were originally posted here: https://lists.freedesktop.org/archives/mesa-dev/2017-March/146667.html The patches needed a non-trivial rebase. The previous discussion was left with a note saying that there are

Re: [Mesa-dev] [PATCH v3 20/48] intel/fs: Protect opt_algebraic from OOB BROADCAST indices

On Fri, Oct 27, 2017 at 12:09 AM, Iago Toral wrote: > > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > --- > > src/intel/compiler/brw_fs.cpp | 10 -- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/src/intel/compiler/brw_fs.cpp >

[Mesa-dev] [RFC 1/2] intel/isl: Disable some gen10 CCS_E formats for now

CannonLake additionally supports R11G11B10_FLOAT and four 10-10-10-2 formats with CCS_E. None of these formats fit within the current blorp_copy framework so disable them until support is added. Signed-off-by: Nanley Chery Cc: Jason Ekstrand ---

[Mesa-dev] [PATCH 2/2] i965: Check CCS_E compatibility for texture view rendering

Only use CCS_E to render to a texture that is CCS_E-compatible with the original texture's miptree (linear) format. This prevents render operations from writing data that can't be decoded with the original miptree format. On Gen10, with the new CCS_E-enabled formats handled, this enables the

Re: [Mesa-dev] [PATCH v3 19/48] i965/fs/nir: Don't stomp 64-bit values to D in get_nir_src

On Thu, Oct 26, 2017 at 11:53 PM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > --- > > src/intel/compiler/brw_fs_nir.cpp | 33 +-- > > -- > > 1 file changed, 21 insertions(+), 12 deletions(-) > > > > diff --git

Re: [Mesa-dev] [PATCH v3 18/48] i965/fs/nir: Minor refactor of store_output

On Thu, Oct 26, 2017 at 11:35 PM, Iago Toral wrote: > On Wed, 2017-10-25 at 16:25 -0700, Jason Ekstrand wrote: > > Stop retyping the output of shuffle_64bit_data_for_32bit_write. It's > > always BRW_REGISTER_TYPE_D which is perfectly fine for writing out. > > Also, when we

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

Well, I went to push this, apparently this was in one of the osmesa patches as an unrelated change.. :/ So it's fixed. Dylan Quoting Dylan Baker (2017-10-27 10:25:33) > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc:

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor

2017-10-27 14:28 GMT+02:00 Rob Herring : > On Fri, Oct 27, 2017 at 6:41 AM, Emil Velikov > wrote: > > On 26 October 2017 at 23:48, Mauro Rossi wrote: > >> Having moved gallium_dri.so library to /vendor/lib/dri > >> also symlinks

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

On Fri, Oct 27, 2017 at 7:25 PM, Dylan Baker wrote: > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc: Erik Faye-Lund > cc: Eric Engestrom > Signed-off-by:

[Mesa-dev] [AppVeyor] mesa master #5967 failed

Build mesa 5967 failed Commit f121a669c7 by Dylan Baker on 10/24/2017 10:52 PM: meson: build gallium based osmesa\n\nThis has been tested with the osdemo from mesa-demos\n\nv2: - Add SELinux dependency\n- fix typo GALLIUM_LLVM ->

[Mesa-dev] [PATCH] meson: Add threads dependencies to glsl_compiler executable

Fixes compiling the optional standalone glsl compiler. Reported-by: DrNick (on irc) Signed-off-by: Dylan Baker --- This is not compiled by default, but can be built by: meson build ninja -C build src/compiler/glsl/glsl_compiler src/compiler/glsl/meson.build | 2 +- 1

Re: [Mesa-dev] Mesa 17.2.4 release candidate

On Fri, Oct 27, 2017 at 1:43 PM, Andres Gomez wrote: > Rejected (6) > > > Ilia Mirkin (1): > glsl: fix derived cs variables > > Reason: Commit is too big for stable at this point. The issue it fixes in regular compute shaders is slightly difficult to hit

Re: [Mesa-dev] [PATCH 9/9] meson: build gallium based osmesa

Quoting Eric Engestrom (2017-10-27 02:28:05) > On Thursday, 2017-10-26 13:55:35 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2017-10-26 02:40:20) > > > On Wednesday, 2017-10-25 15:58:23 -0700, Dylan Baker wrote: > > > > +if with_shared_glapi > > > > + osmesa_link_with += libglapi > > > >

Re: [Mesa-dev] [PATCH 2/2] i965/gen10: Don't set Antialiasing Enable in 3DSTATE_RASTER if num_samples > 1

On Fri, Oct 27, 2017 at 10:50 AM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH] meson: declare an empty xcb dependency

On Friday, 2017-10-27 10:25:33 -0700, Dylan Baker wrote: > This is needed in cases where xcb isn't actually needed as a dependency, > but may still be included somewhere. > > cc: Erik Faye-Lund > cc: Eric Engestrom better indeed :) Reviewed-by:

[Mesa-dev] [PATCH 2/2] i965/gen10: Don't set Antialiasing Enable in 3DSTATE_RASTER if num_samples > 1

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index b6e800aa90..2fb6420cee 100644

[Mesa-dev] [PATCH 1/2] i965/gen10: Don't set Smooth Point Enable in 3DSTATE_SF if num_samples > 1

Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/i965/genX_state_upload.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/drivers/dri/i965/genX_state_upload.c b/src/mesa/drivers/dri/i965/genX_state_upload.c index 4ccfd48919..b6e800aa90 100644

Re: [Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

On Fri, Oct 27, 2017 at 5:03 PM, Andres Gomez wrote: > Bas, this patch looks like it should have been marked as fixing > 6ce550453f1 instead of e38685cc62e (?). Well my reasoning was that the bug got "visible" when we enabled Vega. The patch you refer to fixed part of it, but

[Mesa-dev] Mesa 17.2.4 release candidate

Hello list, The candidate for the Mesa 17.2.4 is now available. Currently we have: - 21 queued - 10 nominated (outstanding) - and 6 rejected patches In the current queue we have: In Mesa Core we have included a change to prevent KOTOR from breaking when in combination with the ATI fragment

Re: [Mesa-dev] [PATCH] meson: Add a dependency on nir_opcodes_h for freedreno

Reviewed-by: Mark Janes Dylan Baker writes: > This fixes a race condition in the build. > > cc: Rob Clark > Signed-off-by: Dylan Baker > --- > src/gallium/drivers/freedreno/meson.build | 2 +- > 1

Re: [Mesa-dev] [PATCH mesa] meson: wire up egl/android

Whooo! Thanks for doing this! Quoting Eric Engestrom (2017-10-27 07:40:17) > Cc: Rob Herring > Cc: Tomasz Figa > Signed-off-by: Eric Engestrom > --- > Completely untested! > It's a step in the right direction though; doesn't hurt

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

Yeah, I kinda got that feeling. Your approach seems better. On Oct 27, 2017 19:22, "Dylan Baker" wrote: This just papers over the actual problem, that dep_xcb isn't declared as an empty list with the other glx dependencies. Dylan Quoting Erik Faye-Lund (2017-10-27

[Mesa-dev] [PATCH] meson: declare an empty xcb dependency

This is needed in cases where xcb isn't actually needed as a dependency, but may still be included somewhere. cc: Erik Faye-Lund cc: Eric Engestrom Signed-off-by: Dylan Baker --- meson.build | 1 + 1 file changed, 1

Re: [Mesa-dev] [PATCH v5 00/10] new series of Mesa for Tizen

On Thursday, October 26, 2017 11:16:06 AM PDT Eric Anholt wrote: > Gwan-gyeong Mun writes: > > > Hi, > > > > These Patch v5 series modified with new helper function series [1]. > > > > These series only have mesa for tizen feature. > > > > [1]

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

This just papers over the actual problem, that dep_xcb isn't declared as an empty list with the other glx dependencies. Dylan Quoting Erik Faye-Lund (2017-10-27 04:55:25) > This avoids the following build-error when building with emtpy > vulkan-drivers and without glx=dri: > > Meson encountered

[Mesa-dev] [PATCH] meson: Add a dependency on nir_opcodes_h for freedreno

This fixes a race condition in the build. cc: Rob Clark Signed-off-by: Dylan Baker --- src/gallium/drivers/freedreno/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/meson.build

Re: [Mesa-dev] [PATCH] util: hashtable: make hashing prototypes match

On Friday, October 27, 2017 9:43:45 AM PDT Lionel Landwerlin wrote: > It seems nobody's using the string hashing function. If you try to > pass it directly to the hashtable creation function, you'll get > compiler warning for non matching prototypes. Let's make them match. > > Signed-off-by:

Re: [Mesa-dev] [PATCH] radv: disable depth writes when depth test is not enabled

On 10/27/2017 06:49 PM, Marek Olšák wrote: The hw disables depth writes automatically. Okay, good to know. Thanks! Marek On Fri, Oct 27, 2017 at 6:27 PM, Samuel Pitoiset wrote: Found by inspection. Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] [PATCH] radv: disable depth writes when depth test is not enabled

The hw disables depth writes automatically. Marek On Fri, Oct 27, 2017 at 6:27 PM, Samuel Pitoiset wrote: > Found by inspection. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_pipeline.c | 8 +++- > 1 file changed, 7

[Mesa-dev] [PATCH] util: hashtable: make hashing prototypes match

It seems nobody's using the string hashing function. If you try to pass it directly to the hashtable creation function, you'll get compiler warning for non matching prototypes. Let's make them match. Signed-off-by: Lionel Landwerlin --- src/util/hash_table.c | 3

[Mesa-dev] [PATCH] intel: common: silence compiler warning

Signed-off-by: Lionel Landwerlin --- src/intel/common/gen_decoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/common/gen_decoder.c b/src/intel/common/gen_decoder.c index 395ff02908a..55e7305117c 100644 ---

Re: [Mesa-dev] [PATCH 1/7] util: move futex helpers into futex.h

For patches 1-4, 6, 7, assuming you fix the double unlock in patch 7: Reviewed-by: Marek Olšák Marek On Sun, Oct 22, 2017 at 8:33 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/util/Makefile.sources | 1 + >

[Mesa-dev] [PATCH] radv: disable depth writes when depth test is not enabled

Found by inspection. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pipeline.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index c25642c966..f5ebcda883 100644 ---

Re: [Mesa-dev] [PATCH 1/7] svga: Use __asm__ instead of asm

On 10/27/2017 05:21 AM, Emil Velikov wrote: On 27 October 2017 at 00:57, Dylan Baker wrote: Which allows the code to be compiled with c99 instead of gnu99. A little history. This code is guarded by #ifdef __GNUC__, so it's only compiled with autotools on *nix, SCons with

Re: [Mesa-dev] [PATCH] meson: drop vulkan if no drivers are built

On Friday, 2017-10-27 13:55:25 +0200, Erik Faye-Lund wrote: > This avoids the following build-error when building with emtpy > vulkan-drivers and without glx=dri: > > Meson encountered an error in file src/vulkan/wsi/meson.build, line 30, > column 2: > Unknown variable "dep_xcb". > >

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

On Fri, Oct 27, 2017 at 11:07 AM, Juan A. Suarez Romero wrote: > On Fri, 2017-10-27 at 10:27 -0400, Ilia Mirkin wrote: >> On Fri, Oct 27, 2017 at 10:03 AM, Juan A. Suarez Romero >> wrote: >> > This patch is mostly a patch done by Ilia Mirkin. >> > >> >

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

On Fri, 2017-10-27 at 10:27 -0400, Ilia Mirkin wrote: > On Fri, Oct 27, 2017 at 10:03 AM, Juan A. Suarez Romero > wrote: > > This patch is mostly a patch done by Ilia Mirkin. > > > > It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. > > > > CC: Ilia Mirkin

Re: [Mesa-dev] [PATCH 2/2] radv: Disallow indirect outputs for GS on GFX9 as well.

Bas, this patch looks like it should have been marked as fixing 6ce550453f1 instead of e38685cc62e (?). In any case, I was wondering whether it would be interesting to bring them both to the 17.2 stable queue and whether we would also want Timothy's preceding patch:

[Mesa-dev] [PATCH mesa] meson: wire up egl/android

Cc: Rob Herring Cc: Tomasz Figa Signed-off-by: Eric Engestrom --- Completely untested! It's a step in the right direction though; doesn't hurt non-android, and gets android closer to building on meson :) --- meson.build |

Re: [Mesa-dev] [PATCH mesa 1/2] buildsys: move file regeneration logic to the script itself

On Thursday, 2017-10-26 10:10:19 -0700, Dylan Baker wrote: > I have a few tiny nits, but otherwise this seems fine: > Reviewed-by: Dylan Baker > > Quoting Eric Engestrom (2017-10-26 08:40:56) > > Suggested-by: Jordan Justen > > Signed-off-by: Eric

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On 27 October 2017 at 14:53, Lionel Landwerlin wrote: > On 27/10/17 14:46, Emil Velikov wrote: >> >> On 27 October 2017 at 13:55, Tapani Pälli wrote: >>> >>> Patch uses mem_ctx for allocation to ensure param array gets freed >>> later, in

Re: [Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

On Fri, Oct 27, 2017 at 10:03 AM, Juan A. Suarez Romero wrote: > This patch is mostly a patch done by Ilia Mirkin. > > It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. > > CC: Ilia Mirkin > Bugzilla:

[Mesa-dev] [PATCH] glsl: add varying resources for arrays of complex types

This patch is mostly a patch done by Ilia Mirkin. It fixes KHR-GL45.enhanced_layouts.varying_structure_locations. CC: Ilia Mirkin Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103098 Signed-off-by: Juan A. Suarez Romero ---

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On 27/10/17 14:46, Emil Velikov wrote: On 27 October 2017 at 13:55, Tapani Pälli wrote: Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

On 27 October 2017 at 13:55, Tapani Pälli wrote: > Patch uses mem_ctx for allocation to ensure param array gets freed > later, in blorp clear case this happens in blorp_params_get_clear_kernel. > > ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193

[Mesa-dev] [PATCH v3] radv: Implement VK_AMD_shader_info

This allows an app to query shader statistics and get a disassembly of a shader. RenderDoc git has support for it, so this allows you to view shader disassembly from a capture. When this extension is enabled on a device (or when tracing), we now disable pipeline caching, since we don't get the

Re: [Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

Reviewed-by: Lionel Landwerlin On 27/10/17 13:55, Tapani Pälli wrote: Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are definitely lost

[Mesa-dev] [PATCH] i965: fix blorp stage_prog_data->param leak

Patch uses mem_ctx for allocation to ensure param array gets freed later, in blorp clear case this happens in blorp_params_get_clear_kernel. ==6164== 48 bytes in 1 blocks are definitely lost in loss record 61 of 193 ==6164==at 0x4C2EB6B: malloc (vg_replace_malloc.c:299) ==6164==by

Re: [Mesa-dev] [PATCH] formatquery: use correct target check for IMAGE_FORMAT_COMPATIBILITY_TYPE

On Fri, Oct 27, 2017 at 5:18 AM, Alejandro Piñeiro wrote: > From the spec: >"IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the > resource when used as an image textures is returned in > . This is equivalent to calling GetTexParameter" > > So we

Re: [Mesa-dev] [PATCH] Android: egl: add dependency on libnativewindow

On 26 October 2017 at 20:18, Rob Herring wrote: > system/window.h is no longer available by default and is part of > libnativewindow, so add it to the shared libraries. It has to be conditional > because the library is only present in O and later. > > Really, we should only be

Re: [Mesa-dev] [PATCH] formatquery: use correct target check for IMAGE_FORMAT_COMPATIBILITY_TYPE

Reviewed-by: Marek Olšák Marek On Fri, Oct 27, 2017 at 11:18 AM, Alejandro Piñeiro wrote: > From the spec: >"IMAGE_FORMAT_COMPATIBILITY_TYPE: The matching criteria use for the > resource when used as an image textures is returned in > .

Re: [Mesa-dev] [PATCH] Android: move drivers' symlinks to /vendor

On Fri, Oct 27, 2017 at 6:41 AM, Emil Velikov wrote: > On 26 October 2017 at 23:48, Mauro Rossi wrote: >> Having moved gallium_dri.so library to /vendor/lib/dri >> also symlinks need to be coherently created using TARGET_OUT_VENDOR insted >> of

Re: [Mesa-dev] [PATCH v3 35/48] intel/eu: Make automatic exec sizes a configurable option

On Wed, 2017-10-25 at 16:26 -0700, Jason Ekstrand wrote: > We have had a feature in codegen for some time that tries to > automatically infer the execution size of an instruction from the > width > of its destination.  For things such as fixed function GS, clipper, > and > SF programs, this is

Re: [Mesa-dev] [PATCH v3 00/48] nir, intel: Prerequisites for subgroups

I dropped a few more comments on patches 18-20, 23, 25, 29-31, 34 and 38 but nothing major in general. I have doubts that patch 20 isn't working around some other bug and 38 scares me a little bit but I guess if Jenkins is happy I shouldn't worry too much. Otherwise, patches 16-38 are:

  1   2   >