Re: [Mesa-dev] [PATCH] drirc: set allow_glsl_cross_stage_interpolation_mismatch for more games

2017-12-19 Thread Kenneth Graunke
On Tuesday, December 19, 2017 11:30:32 PM PST Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > Suggested-by: Darius Spitznagel > https://bugs.freedesktop.org/show_bug.cgi?id=104288 Bugzilla: ^ Acked-by: Kenneth Graunke

[Mesa-dev] [PATCH] drirc: set allow_glsl_cross_stage_interpolation_mismatch for more games

2017-12-19 Thread Tapani Pälli
Signed-off-by: Tapani Pälli Suggested-by: Darius Spitznagel https://bugs.freedesktop.org/show_bug.cgi?id=104288 --- src/util/drirc | 8 1 file changed, 8 insertions(+) diff --git a/src/util/drirc b/src/util/drirc index

[Mesa-dev] [PATCH] gm107/ir: use lane 0 for manual textureGrad handling

2017-12-19 Thread Ilia Mirkin
This is parallel to the pre-SM50 change which does this. Adjusts the shuffles / quadops to make the values correct relative to lane 0, and then splat the results to all lanes for the final move into the target register. Signed-off-by: Ilia Mirkin --- Entirely untested

Re: [Mesa-dev] [PATCH] intel/fs: Optimize and simplify the copy propagation dataflow logic.

2017-12-19 Thread Francisco Jerez
Matt Turner writes: > There's a comment near the top of the file describing the algorithm > and referencing Muchnick. I think with your changes both of those are > no longer accurate? I don't have a copy of Muchnick's book at hand right now, but the paragraph at the top of

Re: [Mesa-dev] [PATCH] intel/fs: Optimize and simplify the copy propagation dataflow logic.

2017-12-19 Thread Matt Turner
On Tue, Dec 19, 2017 at 9:19 PM, Francisco Jerez wrote: There's a comment near the top of the file describing the algorithm and referencing Muchnick. I think with your changes both of those are no longer accurate? ___ mesa-dev

[Mesa-dev] [PATCH] intel/fs: Optimize and simplify the copy propagation dataflow logic.

2017-12-19 Thread Francisco Jerez
Previously the dataflow propagation algorithm would calculate the ACP live-in and -out sets in a two-pass fixed-point algorithm. The first pass would update the live-out sets of all basic blocks of the program based on their live-in sets, while the second pass would update the live-in sets based

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

2017-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104302 Adam Bolte changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

2017-12-19 Thread Ian Romanick
On 12/19/2017 03:45 AM, Tapani Pälli wrote: > > > On 12/19/2017 01:39 PM, Tapani Pälli wrote: >> >> >> On 12/19/2017 02:14 AM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> Light-weight glBindTexture for internal use. >>> >>> Signed-off-by: Ian Romanick

Re: [Mesa-dev] [PATCH] Android: gallium_dri: add include to get "xmlpool/options.h"

2017-12-19 Thread Rob Herring
On Mon, Dec 18, 2017 at 8:45 PM, Yu, Qiang wrote: > I met this problem when upgrade mesa 17.2 to 17.3, and build without > a make clean. A clean build won't have this problem. I think I'm seeing a similar problem on CI builds with current master, but with intel_screen.c:

Re: [Mesa-dev] [PATCH] anv: disallow VK_REMAINING_ARRAY_LAYERS in vkCmdClearAttachments()

2017-12-19 Thread Jason Ekstrand
Rb On December 19, 2017 04:24:48 Samuel Iglesias Gonsálvez wrote: Vulkan spec doesn't specify that VK_REMAINING_ARRAY_LAYERS is allowed in the passed VkClearRect struct. Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH] spirv: consider bitsize when handling OpSwitch cases

2017-12-19 Thread Jason Ekstrand
Oops, thanks. Rb On December 19, 2017 12:05:43 "Juan A. Suarez Romero" wrote: When walking over all the cases in a OpSwitch, take in account the bitsize of the literals to avoid getting wrong cases. --- src/compiler/spirv/vtn_cfg.c | 14 +++--- 1 file

Re: [Mesa-dev] [PATCH] radv: Use a sort for rebuilding the sparse buffer bo list.

2017-12-19 Thread Bas Nieuwenhuizen
Yep, funny that it did not hang during my testing. Thanks! On Tue, Dec 19, 2017 at 7:50 PM, Eric Engestrom wrote: > On Tuesday, 2017-12-19 09:02:57 +0100, Bas Nieuwenhuizen wrote: >> It uses slightly more memory (though still bounded by the number >> of mapped

Re: [Mesa-dev] [PATCH 1/7] radv: create pipeline layout objects for all meta operations

2017-12-19 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Mon, Dec 18, 2017 at 7:38 PM, Samuel Pitoiset wrote: > They are dummy objects but the spec requires layout to not be > NULL, this just makes sure we are creating valid pipeline layout >

Re: [Mesa-dev] [PATCH] mapi: explicitly annotate the shared glapi as such

2017-12-19 Thread Emil Velikov
On 19 December 2017 at 16:26, Eric Engestrom wrote: > On Tuesday, 2017-12-19 13:31:59 +, Emil Velikov wrote: >> From: Emil Velikov >> >> slibtool seems to get confused otherwise - producing both shared and >> static library, and even

Re: [Mesa-dev] [PATCH] radv: Use a sort for rebuilding the sparse buffer bo list.

2017-12-19 Thread Eric Engestrom
On Tuesday, 2017-12-19 09:02:57 +0100, Bas Nieuwenhuizen wrote: > It uses slightly more memory (though still bounded by the number > of mapped ranges), but gives less quadratic behavior. > > Cuts 4 minutes from the runtime of the CTS *.sparse.* tests. > --- >

Re: [Mesa-dev] [PATCH mesa] radeon: remove left over dead code

2017-12-19 Thread Eric Anholt
Eric Engestrom writes: > Fixes: 4e0d99a63588c67a955f "r100: Use shared debug code" > Cc: Pauli Nieminen > Signed-off-by: Eric Engestrom Reviewed-by: Eric Anholt signature.asc Description: PGP

Re: [Mesa-dev] [PATCH] spirv: consider bitsize when handling OpSwitch cases

2017-12-19 Thread Juan A. Suarez Romero
Sorry, sent twice the same patch. J.A. On Tue, 2017-12-19 at 19:05 +0100, Juan A. Suarez Romero wrote: > When walking over all the cases in a OpSwitch, take in account the bitsize > of the literals to avoid getting wrong cases. > --- > src/compiler/spirv/vtn_cfg.c | 14 +++--- >

[Mesa-dev] [PATCH] spirv: consider bitsize when handling OpSwitch cases

2017-12-19 Thread Juan A. Suarez Romero
When walking over all the cases in a OpSwitch, take in account the bitsize of the literals to avoid getting wrong cases. --- src/compiler/spirv/vtn_cfg.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c

[Mesa-dev] [PATCH] spirv: consider bitsize when handling OpSwitch cases

2017-12-19 Thread Juan A. Suarez Romero
When walking over all the cases in a OpSwitch, take in account the bitsize of the literals to avoid getting wrong cases. --- src/compiler/spirv/vtn_cfg.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/compiler/spirv/vtn_cfg.c b/src/compiler/spirv/vtn_cfg.c

[Mesa-dev] [PATCH] etnaviv: disable in-place resolve for non-supertiled surfaces

2017-12-19 Thread Lucas Stach
The in-place resolve probably has some additional restrictions when not operating on a super tiled surface. Disable it on non-supertiled surfaces for now to work around a GPU hang. Signed-off-by: Lucas Stach --- src/gallium/drivers/etnaviv/etnaviv_rs.c | 1 + 1 file

Re: [Mesa-dev] [PATCH] mapi: explicitly annotate the shared glapi as such

2017-12-19 Thread Eric Engestrom
On Tuesday, 2017-12-19 13:31:59 +, Emil Velikov wrote: > From: Emil Velikov > > slibtool seems to get confused otherwise - producing both shared and > static library, and even linking the static one. I don't think it works; EGL still ends up with its own copy: $

[Mesa-dev] [PATCH mesa] radeon: remove left over dead code

2017-12-19 Thread Eric Engestrom
Fixes: 4e0d99a63588c67a955f "r100: Use shared debug code" Cc: Pauli Nieminen Signed-off-by: Eric Engestrom --- src/mesa/drivers/dri/radeon/radeon_context.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[Mesa-dev] [PATCH] mapi: explicitly annotate the shared glapi as such

2017-12-19 Thread Emil Velikov
From: Emil Velikov slibtool seems to get confused otherwise - producing both shared and static library, and even linking the static one. Cc: Cc: Brendan King Cc: Eric Engestrom

[Mesa-dev] [Bug 99116] Wine DirectDraw programs showing only a blackscreen when using Mesa Gallium drivers

2017-12-19 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99116 Józef Kucia changed: What|Removed |Added Summary|Wine program showing only a |Wine DirectDraw

Re: [Mesa-dev] [PATCH 05/16] meta/blit: Don't restore state of the temporary texture

2017-12-19 Thread Tapani Pälli
patches 4,5 Reviewed-by: Tapani Pälli On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick It's about to be destroyed, so there's no point. Signed-off-by: Ian Romanick ---

Re: [Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

2017-12-19 Thread Tapani Pälli
On 12/19/2017 01:39 PM, Tapani Pälli wrote: On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Light-weight glBindTexture for internal use. Signed-off-by: Ian Romanick ---   src/mesa/main/texobj.c | 17 -  

Re: [Mesa-dev] [PATCH 03/16] mesa: Add _mesa_bind_texture method

2017-12-19 Thread Tapani Pälli
On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Light-weight glBindTexture for internal use. Signed-off-by: Ian Romanick --- src/mesa/main/texobj.c | 17 - src/mesa/main/texobj.h | 4 +++- 2 files

Re: [Mesa-dev] [PATCH 3/9] glsl: minor simplification in assign_varying_locations()

2017-12-19 Thread Tapani Pälli
On 12/19/2017 11:14 AM, Timothy Arceri wrote: On 19/12/17 19:47, Tapani Pälli wrote: On 12/18/2017 10:47 PM, Brian Paul wrote: ---   src/compiler/glsl/link_varyings.cpp | 8 +++-   1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-19 Thread Emil Velikov
On 19 December 2017 at 08:46, Brendan King wrote: > > > On 18/12/17 16:42, Emil Velikov wrote: >> >> On 18 December 2017 at 16:33, Eric Engestrom >> wrote: >>> >>> From: Brendan King >>> >>> DRI modules store the

[Mesa-dev] [PATCH] anv: disallow VK_REMAINING_ARRAY_LAYERS in vkCmdClearAttachments()

2017-12-19 Thread Samuel Iglesias Gonsálvez
Vulkan spec doesn't specify that VK_REMAINING_ARRAY_LAYERS is allowed in the passed VkClearRect struct. Signed-off-by: Samuel Iglesias Gonsálvez --- src/intel/vulkan/anv_blorp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/intel/vulkan/anv_blorp.c

Re: [Mesa-dev] [PATCH] docs: update 17.3 and 18.0 cycles for the release calendar

2017-12-19 Thread Juan A. Suarez Romero
Reviewed-by: Juan A. Suarez On Mon, 2017-12-18 at 21:31 +0200, Andres Gomez wrote: > Cc: Emil Velikov > Cc: Juan A. Suarez Romero > Signed-off-by: Andres Gomez > --- > docs/release-calendar.html | 63 >

Re: [Mesa-dev] [PATCH 3/9] glsl: minor simplification in assign_varying_locations()

2017-12-19 Thread Timothy Arceri
On 19/12/17 19:47, Tapani Pälli wrote: On 12/18/2017 10:47 PM, Brian Paul wrote: ---   src/compiler/glsl/link_varyings.cpp | 8 +++-   1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index

Re: [Mesa-dev] [PATCH 08/16] meta/blit: Since _mesa_meta_bind_rb_as_tex_image has only one output, return it

2017-12-19 Thread Tapani Pälli
Nice cleanup, patches 6,7,8 Reviewed-by: Tapani Pälli On 12/19/2017 02:14 AM, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 5 ++---

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-19 Thread Brendan King
On 18/12/17 19:14, Dylan Baker wrote: Quoting Eric Engestrom (2017-12-18 08:33:18) From: Brendan King DRI modules store the address of the dispatch table in a TLS variable, _glapi_tls_Dispatch. Changes to the way libEGL is built in d884d8d0077c16d459b1 resulted in

Re: [Mesa-dev] [PATCH 3/9] glsl: minor simplification in assign_varying_locations()

2017-12-19 Thread Tapani Pälli
On 12/18/2017 10:47 PM, Brian Paul wrote: --- src/compiler/glsl/link_varyings.cpp | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/glsl/link_varyings.cpp b/src/compiler/glsl/link_varyings.cpp index 9039c3b..6d74f9a 100644 ---

Re: [Mesa-dev] [PATCH] egl: link libEGL against the dynamic version of libglapi

2017-12-19 Thread Brendan King
On 18/12/17 16:42, Emil Velikov wrote: On 18 December 2017 at 16:33, Eric Engestrom wrote: From: Brendan King DRI modules store the address of the dispatch table in a TLS variable, _glapi_tls_Dispatch. Changes to the way libEGL is built

Re: [Mesa-dev] [PATCH 1/9] glsl: trivial comment fix in lower_packed_varyings.cpp

2017-12-19 Thread Tapani Pälli
On 12/18/2017 10:47 PM, Brian Paul wrote: --- src/compiler/glsl/lower_packed_varyings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/glsl/lower_packed_varyings.cpp b/src/compiler/glsl/lower_packed_varyings.cpp index 1aec7ee..b840d26 100644 ---

[Mesa-dev] [PATCH] radv: Use a sort for rebuilding the sparse buffer bo list.

2017-12-19 Thread Bas Nieuwenhuizen
It uses slightly more memory (though still bounded by the number of mapped ranges), but gives less quadratic behavior. Cuts 4 minutes from the runtime of the CTS *.sparse.* tests. --- src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c | 45 ++- 1 file changed, 24