Re: [Mesa-dev] [PATCH] nir: fix msvc build

2018-07-13 Thread Jason Ekstrand
On July 13, 2018 19:51:33 wrote: From: Roland Scheidegger Empty initializer braces aren't valid c (it's a gnu extension, and it's valid in c++). Hopefully fixes appveyor / msvc build... Fixes a3150c1d06ae7766c3d3fe3b33432e55c3c7527e --- src/compiler/nir/nir_format_convert.h | 2 +- 1 file

[Mesa-dev] [PATCH] nir: fix msvc build

2018-07-13 Thread sroland
From: Roland Scheidegger Empty initializer braces aren't valid c (it's a gnu extension, and it's valid in c++). Hopefully fixes appveyor / msvc build... Fixes a3150c1d06ae7766c3d3fe3b33432e55c3c7527e --- src/compiler/nir/nir_format_convert.h | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Mesa-dev] [AppVeyor] mesa master #8296 failed

2018-07-13 Thread Roland Scheidegger
Am 13.07.2018 um 23:07 schrieb AppVeyor: > > Build mesa 8296 failed > >

Re: [Mesa-dev] [PATCH] intel: tools: Fix uninitialized variable warnings in intel_dump_gpu.

2018-07-13 Thread Rafael Antognolli
Reviewed-by: Rafael Antognolli On Thu, Jul 12, 2018 at 11:46:12AM -0700, Eric Anholt wrote: > --- > src/intel/tools/intel_dump_gpu.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/intel/tools/intel_dump_gpu.c > b/src/intel/tools/intel_dump_gpu.c > index

Re: [Mesa-dev] [PATCH 1/2] intel/fs: New method for register_byte_use_pattern for fs_inst

2018-07-13 Thread Francisco Jerez
Jose Maria Casanova Crespo writes: > For a register source/destination of an instruction the function returns > the read/write byte pattern of a 32-byte registers as a unsigned int. > > The returned pattern takes into account the exec_size of the instruction, > the type bitsize, the stride and

[Mesa-dev] [Bug 107169] [regression] Upgrade from 18.0.4 to 18.1.0 causes severe stuttering in games

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107169 --- Comment #5 from almos --- Can't confirm on radeonsi. System Shock 2 from GOG runs smoothly with mesa 18.1.2. Are you sure you also have 32 bit gl libraries? -- You are receiving this mail because: You are the QA Contact for the bug. You

[Mesa-dev] [PATCH] radeonsi: reduce LDS stalls by 40% for tessellation

2018-07-13 Thread Marek Olšák
From: Marek Olšák 40% is the decrease in the LGKM counter (which includes SMEM too) for the GFX9 LSHS stage. This will make the LDS size slightly larger, but I wasn't able to increase the patch stride without corruption, so I'm increasing the vertex stride. ---

[Mesa-dev] [AppVeyor] mesa master #8296 failed

2018-07-13 Thread AppVeyor
Build mesa 8296 failed Commit a3150c1d06 by Jason Ekstrand on 7/13/2018 1:23 AM: nir/lower_tex: Use nir_format_srgb_to_linear\n\nA while ago, we added a bunch of format conversion helpers; we should\nuse them instead of hand-rolling sRGB

Re: [Mesa-dev] [PATCH] radv: winsys/amdgpu: include missing pthread.h header

2018-07-13 Thread Dylan Baker
Quoting Mauro Rossi (2018-07-13 09:09:50) > Hi, > > Il giorno lun 9 lug 2018 alle ore 09:48 Bas Nieuwenhuizen < > b...@basnieuwenhuizen.nl> ha scritto: > > I'd like to nominate this for 18.1 stable releases. > > > Me too, but I haven't seen it picked in staging/18.1 yet > > Please Dylan

[Mesa-dev] [ANNOUNCE] mesa 18.1.4

2018-07-13 Thread Dylan Baker
Hi list, Mesa 18.1.4 is now available for download. In this release we have: - Several fixes for i965 - Several fixes for anv - A few fixes each for radeonsi, glx, the glsl compiler, the autotools build, nir, st/dri, and r600 Dylan Shortlog Adam Jackson (1): glx: Don't

Re: [Mesa-dev] [PATCH 1/9] intel/compiler: grf127 can not be dest when src and dest overlap in send

2018-07-13 Thread Matt Turner
On Fri, Jul 13, 2018 at 11:10 AM, Matt Turner wrote: > On Sun, Jul 8, 2018 at 5:27 PM, Jose Maria Casanova Crespo > wrote: >> Implement at brw_eu_validate the restriction from Intel Broadwell PRM, >> vol 07, section "Instruction Set Reference", subsection "EUISA >> Instructions", Send Message

Re: [Mesa-dev] [PATCH 0/9] RadeonSI on AMDGPU: Command submission optimizations

2018-07-13 Thread Marek Olšák
https://pastebin.com/raw/itNDpPv0 Cleanups only: +10.85% Total: +11.8% Marek On Fri, Jul 13, 2018 at 11:05 AM, Michel Dänzer wrote: > On 2018-07-12 07:26 AM, Marek Olšák wrote: >> >> The maximum glxgears FPS improves as follows. >> >> Initially: 13285 >> 8 patches: 14403 (+8.4% vs initial) >>

Re: [Mesa-dev] [PATCH 1/9] intel/compiler: grf127 can not be dest when src and dest overlap in send

2018-07-13 Thread Matt Turner
On Sun, Jul 8, 2018 at 5:27 PM, Jose Maria Casanova Crespo wrote: > Implement at brw_eu_validate the restriction from Intel Broadwell PRM, > vol 07, section "Instruction Set Reference", subsection "EUISA > Instructions", Send Message (page 990): > > "r127 must not be used for return address when

Re: [Mesa-dev] [PATCH] radv: winsys/amdgpu: include missing pthread.h header

2018-07-13 Thread Mauro Rossi
Hi, Il giorno lun 9 lug 2018 alle ore 09:48 Bas Nieuwenhuizen < b...@basnieuwenhuizen.nl> ha scritto: > I'd like to nominate this for 18.1 stable releases. > Me too, but I haven't seen it picked in staging/18.1 yet Please Dylan could you have a look, in case I am supposed to do something,

Re: [Mesa-dev] [PATCH] nir/lower_tex: Use nir_format_srgb_to_linear

2018-07-13 Thread Jason Ekstrand
On Fri, Jul 13, 2018 at 10:08 AM Jason Ekstrand wrote: > On Fri, Jul 13, 2018 at 9:41 AM Eric Anholt wrote: > >> Jason Ekstrand writes: >> >> > Eric, I can't test this patch because it only affects your driver. >> >> I tried a piglit run last night, and all the sRGB lowering looks like it >>

[Mesa-dev] [PATCH] vc4: Tell NIR to lower fdiv instructions

2018-07-13 Thread Jason Ekstrand
This should allow us to use them in nir_lower_tex Cc: Eric Anholt --- src/gallium/drivers/vc4/vc4_program.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/vc4/vc4_program.c b/src/gallium/drivers/vc4/vc4_program.c index 367613130bb..13c3b7678b2 100644 ---

Re: [Mesa-dev] [PATCH] nir/lower_tex: Use nir_format_srgb_to_linear

2018-07-13 Thread Jason Ekstrand
On Fri, Jul 13, 2018 at 9:41 AM Eric Anholt wrote: > Jason Ekstrand writes: > > > Eric, I can't test this patch because it only affects your driver. > > I tried a piglit run last night, and all the sRGB lowering looks like it > crashes now due to fdivs in the NIR. > Do you not run

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: emit a dummy ZPASS_DONE to prevent GPU hangs on GFX9

2018-07-13 Thread Dylan Baker
Quoting Samuel Pitoiset (2018-07-13 03:30:01) > > > On 07/13/2018 12:05 PM, Samuel Pitoiset wrote: > > > > > > On 07/12/2018 09:43 PM, Dylan Baker wrote: > >> Quoting Samuel Pitoiset (2018-07-11 02:55:55) > >>> A ZPASS_DONE or PIXEL_STAT_DUMP_EVENT (of the DB occlusion > >>> counters) must

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.4 release candidate

2018-07-13 Thread Dylan Baker
No, thank you for pointing this out, as 18.1.4 would have shipped with that regression. When the announce email goes out I sync the 18.1 branch with the staging/18.1 branch, and any additional patches pulled into staging/18.1 will be for the next release at that point. I've gone ahead and pulled

Re: [Mesa-dev] [PATCH] nir/lower_tex: Use nir_format_srgb_to_linear

2018-07-13 Thread Eric Anholt
Jason Ekstrand writes: > Eric, I can't test this patch because it only affects your driver. I tried a piglit run last night, and all the sRGB lowering looks like it crashes now due to fdivs in the NIR. signature.asc Description: PGP signature ___

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.4 release candidate

2018-07-13 Thread Mark Janes
Oops -- sorry, I was looking at the 18.1 branch, which is already updated with most (but not all) of the commits in the staging/18.1 branch. Mark Janes writes: > I think you've included a patch that caused a regression, but not the fix > > https://bugs.freedesktop.org/show_bug.cgi?id=107193 > >

Re: [Mesa-dev] [ANNOUNCE] Mesa 18.1.4 release candidate

2018-07-13 Thread Mark Janes
I think you've included a patch that caused a regression, but not the fix https://bugs.freedesktop.org/show_bug.cgi?id=107193 Dylan Baker writes: > Hi List, > > Mesa 18.1.4 is planned for release this Friday, July 13th, at or around 10 AM > PDT. > > There are currently: > - 27 queued > - 1

[Mesa-dev] [PATCH] radv: reduce number of CB/DB meta flushes for VK_ACCESS_TRANSFER_WRITE_BIT

2018-07-13 Thread Samuel Pitoiset
If we know that the given image doesn't have any metadata, we don't need to flush. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c

Re: [Mesa-dev] [PATCH v2] i965/miptree: Init r8stencil_needs_update to false

2018-07-13 Thread Nanley Chery
On Fri, Jul 13, 2018 at 01:01:27PM +0300, Pohjolainen, Topi wrote: > On Wed, Jul 11, 2018 at 09:27:23PM -0700, Nanley Chery wrote: > > The current behavior masked two bugs where the flag was not set to true > > after modifying the stencil texture. One case was a regression > > introduced with

Re: [Mesa-dev] [PATCH 0/9] RadeonSI on AMDGPU: Command submission optimizations

2018-07-13 Thread Michel Dänzer
On 2018-07-12 07:26 AM, Marek Olšák wrote: > > The maximum glxgears FPS improves as follows. > > Initially: 13285 > 8 patches: 14403 (+8.4% vs initial) > + patch 9: 15498 (+16.6% vs initial) Those are nice numbers, but I'm afraid they're almost meaningless without more information about how you

[Mesa-dev] [PATCH v3] vulkan: Fix compilation on older platforms

2018-07-13 Thread Danylo Piliaiev
Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use sequence_handler. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107170

[Mesa-dev] [PATCH 2/2] intel/fs: Improve liveness range calculation for partial writes

2018-07-13 Thread Jose Maria Casanova Crespo
We use the information of the registers read/write patterns to improve variable liveness analysis avoiding extending the liveness range of a variable to the beginning of the block so it always reaches the beginning of the shader. This optimization analyses inside each block that if a partial

[Mesa-dev] [PATCH 1/2] intel/fs: New method for register_byte_use_pattern for fs_inst

2018-07-13 Thread Jose Maria Casanova Crespo
For a register source/destination of an instruction the function returns the read/write byte pattern of a 32-byte registers as a unsigned int. The returned pattern takes into account the exec_size of the instruction, the type bitsize, the stride and if the register is source or destination. The

[Mesa-dev] [PATCH 0/2] intel/fs: Liveness range improvements with partial writes

2018-07-13 Thread Jose Maria Casanova Crespo
This series deal with the main performance issue in shader compilation performance when 8/16-bit types are used. This series avoid extending the liveness range of variables that use a partial register. We track in the liveness analysis which bytes of the register are defined and not used before

[Mesa-dev] [PATCH] mesa/virgl: Fix off-by-one and copy-paste error in multisample position evaluation

2018-07-13 Thread Gert Wollny
Fixes: 91f48cdfe5c817158c533a8f67c60e9aabbe4479 virgl: Add support for glGetMultisample Signed-off-by: Gert Wollny --- src/gallium/drivers/virgl/virgl_context.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/virgl/virgl_context.c

[Mesa-dev] [PATCH] radv: fix implementation of VK_KHR_create_renderpass2 for multiviews

2018-07-13 Thread Samuel Pitoiset
The Vulkan 1.1.80 spec says: "viewMask has the same effect for the described subpass as VkRenderPassMultiviewCreateInfo::pViewMasks has on each corresponding subpass." Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_pass.c | 13 + 1 file changed, 1 insertion(+), 12

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: emit a dummy ZPASS_DONE to prevent GPU hangs on GFX9

2018-07-13 Thread Samuel Pitoiset
On 07/13/2018 12:05 PM, Samuel Pitoiset wrote: On 07/12/2018 09:43 PM, Dylan Baker wrote: Quoting Samuel Pitoiset (2018-07-11 02:55:55) A ZPASS_DONE or PIXEL_STAT_DUMP_EVENT (of the DB occlusion counters) must immediately precede every timestamp event to prevent a GPU hang on GFX9.

Re: [Mesa-dev] [PATCH v2 4/4] radv: add support for VK_EXT_conditional_rendering

2018-07-13 Thread Samuel Pitoiset
On 07/11/2018 10:53 AM, Bas Nieuwenhuizen wrote: Don't we need to disable predication too for the PipelineBarriers when a layout change happens? I don't think. Shouldn't the app handle this correctly? If a CmdPipelineBarrier() is between Begin()/End() it will be skipped, that's it? Also

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: emit a dummy ZPASS_DONE to prevent GPU hangs on GFX9

2018-07-13 Thread Samuel Pitoiset
On 07/12/2018 09:43 PM, Dylan Baker wrote: Quoting Samuel Pitoiset (2018-07-11 02:55:55) A ZPASS_DONE or PIXEL_STAT_DUMP_EVENT (of the DB occlusion counters) must immediately precede every timestamp event to prevent a GPU hang on GFX9. Signed-off-by: Samuel Pitoiset Cc: 18.1 ---

Re: [Mesa-dev] [PATCH v2] i965/miptree: Init r8stencil_needs_update to false

2018-07-13 Thread Pohjolainen, Topi
On Wed, Jul 11, 2018 at 09:27:23PM -0700, Nanley Chery wrote: > The current behavior masked two bugs where the flag was not set to true > after modifying the stencil texture. One case was a regression > introduced with commit bdbb527a65fc729e7a9319ae67de60d03d06c3fd and > another was a bug in the

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 Samuel Pitoiset changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

[Mesa-dev] [Bug 107156] earth tessellation bug

2018-07-13 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107156 --- Comment #9 from ximik --- this problem appeared in the git version of the driver in early June. before that I used version 18.0 stable. but DXVK stopped working with it, so I updated to version git. in the middle of May everything was

Re: [Mesa-dev] [PATCH v2] vulkan: Fix compilation on older platforms

2018-07-13 Thread Danylo Piliaiev
On 12.07.18 21:49, Dylan Baker wrote: Quoting Danylo Piliaiev (2018-07-12 06:09:57) Make xlease automatically enabled only if xcb-randr >= 1.13, check its version if manually enabled. Enable VK_EXT_display_control only when libdrm >= 2.4.89 Check for DRM_EVENT_CONTEXT_VERSION >= 4 to use

Re: [Mesa-dev] [PATCH 1/2] intel/blorp: Fix blits to R8G8B8_UNORM_SRGB

2018-07-13 Thread Samuel Iglesias Gonsálvez
Assuming Jenkins is happy with them, this series is Reviewed-by: Samuel Iglesias Gonsálvez Sam On 13/07/18 00:48, Jason Ekstrand wrote: > In this case, the surface faking will give us a R8_UNORM surface and we > need to do an sRGB conversion in the shader. > > cc: