[Mesa-dev] [RFC][PATCH] util: Android.mk: Convert implicit rules to static pattern rules

From: Dan Willemsen This is a partial cherry-pick from AOSP's mesa3d tree: https://android.googlesource.com/platform/external/mesa3d/+/a88dcf769eb00a4ffc7183a0396d881a28b5a29b%5E%21/ "We're deprecating make implicit rules, preferring static pattern rules, or just regular rules." Without this

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

On Tue, 2018-07-17 at 15:22 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > On Tue, 2018-07-17 at 14:17 -0700, Francisco Jerez wrote: > > > Jan Vesely writes: > > > > > > > Abort all dependent events. > > > > Signed-off-by: Jan Vesely > > > > --- > > > >

[Mesa-dev] [Bug 100916] Multiple definition of `glwMDrawingAreaWidgetClass'

https://bugs.freedesktop.org/show_bug.cgi?id=100916 Stefan Dirsch changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED

Re: [Mesa-dev] [PATCH] libGLw: Use newly introduced GLAPIVAR for variables

On Tue, Jul 17, 2018 at 04:57:26PM -0600, Brian Paul wrote: > Reviewed-by: Brian Paul > > Do you need me to push this for you? I'm afraid the answer is yes. Tried it but push hangs forever after this # git push --verbose Pushing to ssh://git.freedesktop.org/git/mesa/glw.git Counting objects:

[Mesa-dev] [Bug 100916] Multiple definition of `glwMDrawingAreaWidgetClass'

https://bugs.freedesktop.org/show_bug.cgi?id=100916 --- Comment #5 from Timothy Arceri --- (In reply to Stefan Dirsch from comment #4) > https://lists.freedesktop.org/archives/mesa-dev/2018-July/200329.html > > Closing as fixed. Just FYI we don't normally close bugs until that patch has been

[Mesa-dev] [PATCH v2 1/2] egl/surfaceless: Define DRI_SWRastLoader extension when using swrast.

Signed-off-by: David Riley --- src/egl/drivers/dri2/platform_surfaceless.c | 28 + 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/src/egl/drivers/dri2/platform_surfaceless.c b/src/egl/drivers/dri2/platform_surfaceless.c index a0348a5e95..f5fe7119c6 100644 ---

[Mesa-dev] [PATCH v2 2/2] egl/surfaceless: Allow DRMless fallback.

Allow platform_surfaceless to use swrast even if DRM is not available. To be used to allow a fuzzer for virgl to be run on a jailed VM without hardware GL or DRM support. Signed-off-by: David Riley --- src/egl/drivers/dri2/platform_surfaceless.c | 19 +++ 1 file changed, 19

[Mesa-dev] [PATCH v2 0/2] Add DRMless surfaceless fallback path.

Allow platform_surfaceless to use swrast even if DRM is not available. To be used to allow a fuzzer for virgl to be run on a jailed VM without hardware GL or DRM support. v2: Comment style fixes and remove redundant assignment. David Riley (2): egl/surfaceless: Define DRI_SWRastLoader

[Mesa-dev] [PATCH 1/4] intel/dump_gpu: Fix corner cases in PPGTT range calculations

For large buffers which span an entire l1 page table, we got the range calculations wrong. In this case, we end up with an l1_start which is the first byte represented by the given l1 table and an l1_end which is the first byte after the range represented by the l1 table. Then l2_start_index ==

[Mesa-dev] [PATCH 3/4] intel/tools: Break aub file writing into a helper

--- src/intel/tools/aub_write.c | 764 +++ src/intel/tools/aub_write.h | 96 src/intel/tools/intel_dump_gpu.c | 762 +- src/intel/tools/meson.build | 2 +- 4 files changed, 862 insertions(+), 762 deletions(-) create

[Mesa-dev] [PATCH 2/4] intel/tools: Refactor aub dumping to remove singletons

Instead of having quite so many singletons, we use a struct aub_file to organize the bits we need for writing an aub file. --- src/intel/tools/intel_dump_gpu.c | 498 ++- 1 file changed, 287 insertions(+), 211 deletions(-) diff --git a/src/intel/tools/intel_dump_gpu.c

[Mesa-dev] [PATCH 4/4] intel/tools: Add an error state to aub translator

--- src/intel/tools/error2aub.c | 332 src/intel/tools/meson.build | 11 ++ 2 files changed, 343 insertions(+) create mode 100644 src/intel/tools/error2aub.c diff --git a/src/intel/tools/error2aub.c b/src/intel/tools/error2aub.c new file mode 100644 index

Re: [Mesa-dev] [PATCH] libGLw: Use newly introduced GLAPIVAR for variables

On 07/17/2018 12:40 PM, Stefan Dirsch wrote: GLAPI doesn't have an 'extern' in some circumstances. This way, variable declarations become definitions (fdo #100916). Signed-off-by: Stefan Dirsch --- GLwDrawA.h | 10 -- GLwDrawAP.h | 4 ++-- 2 files changed, 10 insertions(+), 4

[Mesa-dev] Mesa 18.2.0 release plan

Hi all, Here is the tentative release plan for 18.2.0. Although the initial plan was to have the first release candidate by the end of this week, a slip of mind in my side on sending this plan is shifting the current schedule at mesa3d.org. We'll update the release schedule there soon. Aug 01

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

Jan Vesely writes: > On Tue, 2018-07-17 at 14:17 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > Abort all dependent events. >> > Signed-off-by: Jan Vesely >> > --- >> > src/gallium/state_trackers/clover/core/event.cpp | 7 ++- >> > 1 file changed, 6 insertions(+), 1

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

On Tue, 2018-07-17 at 14:17 -0700, Francisco Jerez wrote: > Jan Vesely writes: > > > Abort all dependent events. > > Signed-off-by: Jan Vesely > > --- > > src/gallium/state_trackers/clover/core/event.cpp | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git

Re: [Mesa-dev] [PATCH 2/2] intel/isl/gen4: Make depth/stencil buffers Y-Tiled

On Tue, Jul 17, 2018 at 01:29:26PM -0700, Kenneth Graunke wrote: > On Tuesday, July 17, 2018 10:45:28 AM PDT Nanley Chery wrote: > > On Tue, Jul 17, 2018 at 08:19:30AM -0700, Kenneth Graunke wrote: > > > Wow, I had no idea we were actually using linear depth buffers. > > > > Neither did I until

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

On Tue, 2018-07-17 at 16:15 -0500, Aaron Watry wrote: > Question: How'd you run across this? CTS, an application? It's a part of the 3 patch series I posted: 1.) fail to create compute state if code has relocations 2.) throw exception if pipe driver failed to create compute state 3.) catch

Re: [Mesa-dev] [PATCH 2/2] clover: Report error when pipe driver fails to create compute state

Jan Vesely writes: > Signed-off-by: Jan Vesely Reviewed-by: Francisco Jerez > --- > src/gallium/state_trackers/clover/core/kernel.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp >

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

Jan Vesely writes: > Abort all dependent events. > Signed-off-by: Jan Vesely > --- > src/gallium/state_trackers/clover/core/event.cpp | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/state_trackers/clover/core/event.cpp >

Re: [Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

Question: How'd you run across this? CTS, an application? I saw this and had hoped that it finally fixed a CTS hang I've been experiencing when running: test_conformance/events/test_events test_userevents But at least when SSH'd into my R600-based box, it still seems to pause waiting for an

[Mesa-dev] [PATCH v2 11/26] python: Fix rich comparisons

Python 3 doesn't call objects __cmp__() methods any more to compare them. Instead, it requires implementing the rich comparison methods explicitly: __eq__(), __ne(), __lt__(), __le__(), __gt__() and __ge__(). Fortunately Python 2 also supports those. This commit only implements the comparison

Re: [Mesa-dev] [PATCH 2/2] intel/isl/gen4: Make depth/stencil buffers Y-Tiled

On Tuesday, July 17, 2018 10:45:28 AM PDT Nanley Chery wrote: > On Tue, Jul 17, 2018 at 08:19:30AM -0700, Kenneth Graunke wrote: > > Wow, I had no idea we were actually using linear depth buffers. > > Neither did I until Mark let me know that I regressed some tests after > landing commit

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #38 from erhar...@mailbox.org --- mesa 18.1.4 - ppc64 BE, standard build: make check-TESTS make[5]: Verzeichnis „/root/build/mesa-18.1.4/src/gallium/drivers/llvmpipe“ wird betreten make[6]: Verzeichnis

Re: [Mesa-dev] [PATCH v4] mesa: handle a bunch of formats in IMPLEMENTATION_COLOR_READ_*

Tomeu Vizoso writes: > Virgl could save a lot of work converting buffers in the host side > between formats if Mesa supported a bunch of other formats when reading > pixels. > > This commit adds cases to handle specific formats so that the values > reported by the two calls match more closely

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 --- Comment #37 from erhar...@mailbox.org --- Created attachment 140674 --> https://bugs.freedesktop.org/attachment.cgi?id=140674=edit test-suite.log (ppc64) GALLIVM_MATTRS="-vsx" & GALLIVM_VSX=0 build Last time I built mesa on ppc64 BE I

Re: [Mesa-dev] [PATCH] gm107/ir: use CS2R for SV_CLOCK

After some testing and looking at traces of the blob or nvcc output, it seems the only system value CS2R is useful for is SV_CLOCK. On Tue, Jul 17, 2018 at 1:09 PM, Karol Herbst wrote: > that seems like a good enough improvement. I think looking onto other > sysvals would be worthwhile as

[Mesa-dev] [Bug 106644] [llvmpipe] Mesa 18.1.2 fails lp_test_format, lp_test_arit, lp_test_blend, lp_test_printf, lp_test_conv tests

https://bugs.freedesktop.org/show_bug.cgi?id=106644 erhar...@mailbox.org changed: What|Removed |Added Attachment #140430|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 2/3] gallium/u_vbuf: split u_vbuf_get_minmax_index function

Eric Anholt writes: > [ Unknown signature status ] > Marek Olšák writes: > >> From: Marek Olšák >> >> This will be used by indirect multidraws. >> --- >> src/gallium/auxiliary/util/u_vbuf.c | 54 + >> 1 file changed, 31 insertions(+), 23 deletions(-) >> >> diff

Re: [Mesa-dev] [PATCH 3/3] gallium/u_vbuf: handle indirect multidraws correctly and efficiently

Marek Olšák writes: > From: Marek Olšák > > --- > src/gallium/auxiliary/util/u_vbuf.c | 189 > 1 file changed, 165 insertions(+), 24 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_vbuf.c > b/src/gallium/auxiliary/util/u_vbuf.c > index

Re: [Mesa-dev] [PATCH 2/3] gallium/u_vbuf: split u_vbuf_get_minmax_index function

Marek Olšák writes: > From: Marek Olšák > > This will be used by indirect multidraws. > --- > src/gallium/auxiliary/util/u_vbuf.c | 54 + > 1 file changed, 31 insertions(+), 23 deletions(-) > > diff --git a/src/gallium/auxiliary/util/u_vbuf.c >

Re: [Mesa-dev] [PATCH 1/3] egl/android: Delete set_damage_region from egl dri vtbl

Harish Krupo writes: > Eric Anholt writes: > >> Harish Krupo writes: >> >>> Hi Eric, >>> >>> Eric Anholt writes: >>> Harish Krupo writes: > The intension of the KHR_partial_update was not to send the damage back > to the platform but to send the damage to the driver to

Re: [Mesa-dev] [PATCH] libGLw: Use newly introduced GLAPIVAR for variables

On Tue, Jul 17, 2018 at 08:21:10AM -0600, Brian Paul wrote: > On 07/17/2018 07:31 AM, Stefan Dirsch wrote: > > GLAPI doesn't have an 'extern' in some circumstances. This way, > > variable declarations become definitions (fdo #100916). > > > > Signed-off-by: Stefan Dirsch > > --- > > GLwDrawA.h

[Mesa-dev] [PATCH] libGLw: Use newly introduced GLAPIVAR for variables

GLAPI doesn't have an 'extern' in some circumstances. This way, variable declarations become definitions (fdo #100916). Signed-off-by: Stefan Dirsch --- GLwDrawA.h | 10 -- GLwDrawAP.h | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/GLwDrawA.h b/GLwDrawA.h

Re: [Mesa-dev] [PATCH mesa] anv: remove unnecessary runtime copy of static string

I didn't know that worked. Neat! Reviewed-by: Jason Ekstrand On Tue, Jul 17, 2018 at 9:41 AM Eric Engestrom wrote: > It's actually also a bit safer, since now the compiler will warn if > the string is larger than the `.name` array. > > Signed-off-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH] radv: optimize radv_stage_flush() for pre fragment shader stages

Reviewed-by: Bas Nieuwenhuizen On Tue, Jul 17, 2018 at 5:03 PM, Samuel Pitoiset wrote: > We don't need to emit PS_PARTIAL_FLUSH for the pre fragment shader > stages (ie. geometry/tessellation). Emitting VS_PARTIAL_FLUSH > is enough for these stages. Note that PS_PARTIAL_FLUSH also >

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Tue, Jul 17, 2018 at 11:09 AM, Eric Engestrom wrote: > On Tuesday, 2018-07-17 10:26:49 -0400, robdcl...@gmail.com wrote: >> On Tue, Jul 17, 2018 at 10:05 AM, Eric Engestrom >> wrote: >> > On Tuesday, 2018-07-17 09:01:46 -0400, >> > mesa-dev-boun...@lists.freedesktop.org wrote: >> >> On Mon,

Re: [Mesa-dev] [PATCH 2/2] intel/isl/gen4: Make depth/stencil buffers Y-Tiled

On Tue, Jul 17, 2018 at 08:19:30AM -0700, Kenneth Graunke wrote: > On Monday, July 16, 2018 4:57:40 PM PDT Nanley Chery wrote: > > Rendering to a linear depth buffer on gen4 is causing a GPU hang in the > > CI system. Until a better explanation is found, assume that errata is > > applicable to all

Re: [Mesa-dev] [PATCH] glsl: Allow ES2 function parameters to be hidden by variable declarations.

On Tue, Jul 17, 2018 at 1:33 PM, Eric Anholt wrote: > Ilia Mirkin writes: > >> On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt wrote: >>> Ilia Mirkin writes: >>> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a drive-by comment, not a real review, sorry] >>> >>> That

Re: [Mesa-dev] [PATCH] glsl: Allow ES2 function parameters to be hidden by variable declarations.

Ilia Mirkin writes: > On Mon, Jul 16, 2018 at 7:51 PM, Eric Anholt wrote: >> Ilia Mirkin writes: >> >>> Perhaps use state->es_shader instead of is_version(0, 100)? [Just a >>> drive-by comment, not a real review, sorry] >> >> That doesn't respect the version overrides and such that is_version

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Tue, Jul 17, 2018 at 12:40 PM, Dylan Baker wrote: > Quoting Eric Engestrom (2018-07-17 07:05:32) >> On Tuesday, 2018-07-17 09:01:46 -0400, >> mesa-dev-boun...@lists.freedesktop.org wrote: >> > On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: >> > > Quoting Jan Alexander Steffens (heftig)

[Mesa-dev] [PATCH v5 1/3] r600: Delay emission of texture gradients and lookup offsets

From: Gert Wollny Gradients used in texture lookups and the offsets must reside in the same fetch clause (the first is imposed by the hardware and the second is expected by sb). In order to ensure that no ALU clause is inserted between emission and use of these, delay the emission of these

[Mesa-dev] [PATCH v5 0/3] r600: Fix array texture slice index evaluation

From: Gert Wollny Dear all, v5: replace ADD+0.5/FLOOR by RNDNE as suggested by Ilia Mirkin. post from v4 follows: This is a 90% rewrite of the earlier series. - I removed the changes to the texture state and handle everything in the shader. Since this was needed for cube arrays anyway,

[Mesa-dev] [PATCH v5 3/3] r600: Correct evaluation of cube array index and face

From: Gert Wollny The array index needs to be corrected and it must be insured that it is rounded and its value is non-negative before it is combined with the face id. v5: Use RNDNE instead of ADD 0.5 and FLOOR (Ilia Mirkin) Fixes 182 from android/cts/master/gles31-master.txt:

[Mesa-dev] [PATCH v5 2/3] r600: correct texture offset for array index lookup

From: Gert Wollny Correct the array index for TEXTURE_*1D_ARRAY, and TEXTURE_*2D_ARRAY The standard says the array index is evaluated according to floor(z + 0.5) but RNDNE is sufficient also for the test cases were z is close to 1.5 and it is likely to hit 1.5, the corner case were RNDNE

[Mesa-dev] [PATCH mesa] anv: remove unnecessary runtime copy of static string

It's actually also a bit safer, since now the compiler will warn if the string is larger than the `.name` array. Signed-off-by: Eric Engestrom --- src/intel/vulkan/anv_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/intel/vulkan/anv_gem.c

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

Quoting Eric Engestrom (2018-07-17 07:05:32) > On Tuesday, 2018-07-17 09:01:46 -0400, mesa-dev-boun...@lists.freedesktop.org > wrote: > > On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: > > > Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20) > > >> This is for parity with

Re: [Mesa-dev] [PATCH 2/2] intel: Make the decoder handle STATE_BASE_ADDRESS not being a buffer.

On 11/07/18 19:25, Kenneth Graunke wrote: Normally, i965 programs STATE_BASE_ADDRESS every batch, and puts all state for a given base in a single buffer. I'm working on a prototype which emits STATE_BASE_ADDRESS only once at startup, where each base address is a fixed 4GB region of the PPGTT.

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

Quoting Michel Dänzer (2018-07-17 07:29:49) > On 2018-07-17 03:07 PM, Rob Clark wrote: > > On Tue, Jul 17, 2018 at 9:01 AM, Rob Clark wrote: > >> On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: > >>> Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20) > This is for parity with

Re: [Mesa-dev] [PATCH 1/2] intel: Make the disassembler take a const pointer to the assembly.

Reviewed-by: Lionel Landwerlin On 11/07/18 19:25, Kenneth Graunke wrote: Disassembling doesn't modify the assembly. --- src/intel/common/gen_disasm.c | 7 --- src/intel/common/gen_disasm.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Tuesday, 2018-07-17 16:09:33 +0100, Eric Engestrom wrote: > On Tuesday, 2018-07-17 10:26:49 -0400, robdcl...@gmail.com wrote: > > On Tue, Jul 17, 2018 at 10:05 AM, Eric Engestrom > > wrote: > > > On Tuesday, 2018-07-17 09:01:46 -0400, > > > mesa-dev-boun...@lists.freedesktop.org wrote: > > >>

Re: [Mesa-dev] [PATCH] i965: batchbuffer: write correct canonical offset with softpin

On 17/07/18 16:01, Lionel Landwerlin wrote: Addresses in the command streams should be in canonical form (i.e bit[63:48] == bit[47]). If the [bo->gtt_offset, bo->gtt_offset + target_offset] range contains the address 0x8000, the current code will fail that criteria. Fixes:

[Mesa-dev] [Bug 106465] No test for Image Load/Store on format-incompatible texture buffer

https://bugs.freedesktop.org/show_bug.cgi?id=106465 Danylo changed: What|Removed |Added CC||danylo.pilia...@gmail.com --- Comment #2 from

[Mesa-dev] Broken Tags

Hi Is there any change the following tags could be deleted (and recreated if required) from the git repo: R300_DRIVER_0 before_upgrade_03_01_05 blended_fountain embedded-1-20030120 embedded-1-20030224 embedded-1-20030305 embedded-1-20030324 embedded-1-20030417 embedded-1-20030502 gliding_penguin

Re: [Mesa-dev] [PATCH 2/2] intel/isl/gen4: Make depth/stencil buffers Y-Tiled

On Monday, July 16, 2018 4:57:40 PM PDT Nanley Chery wrote: > Rendering to a linear depth buffer on gen4 is causing a GPU hang in the > CI system. Until a better explanation is found, assume that errata is > applicable to all gen4 platforms. > > Fixes fbe01625f6bf2cef6742e1ff0d3d44a2afec003e >

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Tuesday, 2018-07-17 10:26:49 -0400, robdcl...@gmail.com wrote: > On Tue, Jul 17, 2018 at 10:05 AM, Eric Engestrom > wrote: > > On Tuesday, 2018-07-17 09:01:46 -0400, > > mesa-dev-boun...@lists.freedesktop.org wrote: > >> On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: > >> > Quoting Jan

[Mesa-dev] [PATCH] radv: optimize radv_stage_flush() for pre fragment shader stages

We don't need to emit PS_PARTIAL_FLUSH for the pre fragment shader stages (ie. geometry/tessellation). Emitting VS_PARTIAL_FLUSH is enough for these stages. Note that PS_PARTIAL_FLUSH also synchronizes all vertex stages. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 10

[Mesa-dev] [PATCH] i965: batchbuffer: write correct canonical offset with softpin

Addresses in the command streams should be in canonical form (i.e bit[63:48] == bit[47]). If the [bo->gtt_offset, bo->gtt_offset + target_offset] range contains the address 0x8000, the current code will fail that criteria. Fixes: 1c9053d0765dc6 ("i965: Prepare batchbuffer module for

Re: [Mesa-dev] [PATCH 1/2] i965/misc: Use depth/stencil surf's tiling on gen4-5

Tested-by: Mark Janes Nanley Chery writes: > Make the 3D engine aware of the depth/stencil surface's tiling before > doing any render operations. > > Fixes fbe01625f6bf2cef6742e1ff0d3d44a2afec003e > ("i965/miptree: Share tiling_flags in miptree_create"). > > Reported-by: Mark Janes > --- >

[Mesa-dev] [PATCH 2/2] clover: Report error when pipe driver fails to create compute state

Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/kernel.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp b/src/gallium/state_trackers/clover/core/kernel.cpp index 4716705323..dab7ef8683 100644 ---

[Mesa-dev] [PATCH 1/2] clover: Catch errors from executing event action

Abort all dependent events. Signed-off-by: Jan Vesely --- src/gallium/state_trackers/clover/core/event.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/clover/core/event.cpp b/src/gallium/state_trackers/clover/core/event.cpp index

[Mesa-dev] [PATCH] radeonsi: Refuse to accept code with unhandled relocations

They might lead to unrecoverable GPU hang. Signed-off-by: Jan Vesely --- src/gallium/drivers/radeonsi/si_compute.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_compute.c b/src/gallium/drivers/radeonsi/si_compute.c index 5d3341ff61..2349be9584 100644

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On 2018-07-17 03:07 PM, Rob Clark wrote: > On Tue, Jul 17, 2018 at 9:01 AM, Rob Clark wrote: >> On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: >>> Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20) This is for parity with autotools. We were suddenly getting assertion

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Tue, Jul 17, 2018 at 10:05 AM, Eric Engestrom wrote: > On Tuesday, 2018-07-17 09:01:46 -0400, mesa-dev-boun...@lists.freedesktop.org > wrote: >> On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: >> > Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20) >> >> This is for parity

[Mesa-dev] [PATCH mesa] meson: disable asserts by default on release builds

Cc: Rob Clark Cc: Jan Alexander Steffens (heftig) Cc: Dylan Baker Signed-off-by: Eric Engestrom --- meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index c62cdd0e395259ec984e..eb90f4cf9b265435fb19 100644 --- a/meson.build +++

[Mesa-dev] [PATCH 3/3] radeonsi: emit_spi_map packets optimization

Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_build_pm4.h | 23 +++ src/gallium/drivers/radeonsi/si_gfx_cs.c| 2 ++ src/gallium/drivers/radeonsi/si_state.h | 1 + src/gallium/drivers/radeonsi/si_state_shaders.c | 20

[Mesa-dev] [PATCH 2/3] radeonsi: emit_guardband packets optimization

Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_build_pm4.h | 33 src/gallium/drivers/radeonsi/si_gfx_cs.c | 4 +++ src/gallium/drivers/radeonsi/si_state.h | 5 src/gallium/drivers/radeonsi/si_state_viewport.c | 16 ++--

[Mesa-dev] [PATCH 1/3] radeonsi: Save CLEAR_STATE initial values for optimization

Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_gfx_cs.c b/src/gallium/drivers/radeonsi/si_gfx_cs.c index 09f0d3b..ac4909a 100644 ---

Re: [Mesa-dev] [PATCH] libGLw: Use newly introduced GLAPIVAR for variables

On 07/17/2018 07:31 AM, Stefan Dirsch wrote: GLAPI doesn't have an 'extern' in some circumstances. This way, variable declarations become definitions (fdo #100916). Signed-off-by: Stefan Dirsch --- GLwDrawA.h | 12 ++-- GLwDrawAP.h | 4 ++-- 2 files changed, 12 insertions(+), 4

Re: [Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

On 07/17/2018 04:32 AM, Robert Foss wrote: This failure mode is a bit tricky to debug and manifests itself later as a null pointer dereference, for which finding the origin is needlessly tricky. Signed-off-by: Robert Foss --- Changes since v1: - Patch added

Re: [Mesa-dev] [PATCH v2 1/3] i965: Sweep NIR after linking phase to free held memory

Could it be pushed? The commit is independent from other in series. - Danil On 12.07.18 00:27, Jason Ekstrand wrote: Reviewed-by: Jason Ekstrand > On Wed, Jul 11, 2018 at 5:29 AM Danylo Piliaiev mailto:danylo.pilia...@gmail.com>> wrote: After optimization

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Tuesday, 2018-07-17 09:01:46 -0400, mesa-dev-boun...@lists.freedesktop.org wrote: > On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: > > Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20) > >> This is for parity with autotools. We were suddenly getting assertion > >> failures

Re: [Mesa-dev] [PATCH] gallium: surface remove width/height removal comment

Initially, width/height were actually needed because not all pipe_surface objects were backed by pipe_resource objects (that was ages ago...). Hence the comment when that was fixed, since it was always actually possible to derive this from the resource (but a bit too complex to change all the

[Mesa-dev] [Bug 92987] DRI2: fails to determine screen refresh rate when rendering is offloaded

https://bugs.freedesktop.org/show_bug.cgi?id=92987 Stefan Dirsch changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Mesa-dev] [Bug 92987] DRI2: fails to determine screen refresh rate when rendering is offloaded

https://bugs.freedesktop.org/show_bug.cgi?id=92987 Stefan Dirsch changed: What|Removed |Added Summary|fails to determine screen |DRI2: fails to determine

[Mesa-dev] [Bug 104926] swrast: Mesa 17.3.3 produces: HW cursor for format 875713089 not supported

https://bugs.freedesktop.org/show_bug.cgi?id=104926 --- Comment #6 from Stefan Dirsch --- Hmm. Fix is not yet in git master. :-( -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev

[Mesa-dev] [Bug 100916] Multiple definition of `glwMDrawingAreaWidgetClass'

https://bugs.freedesktop.org/show_bug.cgi?id=100916 Stefan Dirsch changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH] libGLw: Use newly introduced GLAPIVAR for variables

GLAPI doesn't have an 'extern' in some circumstances. This way, variable declarations become definitions (fdo #100916). Signed-off-by: Stefan Dirsch --- GLwDrawA.h | 12 ++-- GLwDrawAP.h | 4 ++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/GLwDrawA.h b/GLwDrawA.h

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Tue, Jul 17, 2018 at 9:01 AM, Rob Clark wrote: > On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: >> Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20) >>> This is for parity with autotools. We were suddenly getting assertion >>> failures after switching to meson, see [1]. >>>

Re: [Mesa-dev] [PATCH 1/3] meson: Define NDEBUG for non-debug-builds

On Mon, Apr 16, 2018 at 5:19 PM, Dylan Baker wrote: > Quoting Jan Alexander Steffens (heftig) (2018-04-14 10:23:20) >> This is for parity with autotools. We were suddenly getting assertion >> failures after switching to meson, see [1]. >> >> [1]: https://bugs.archlinux.org/task/58218 >> >>

[Mesa-dev] [PATCH mesa] vk/wsi: avoid reading uninitialised memory

It will be ignored by x11_swapchain_result() anyway (because reaching the `fail` label without setting `result` means the swapchain status was already a hard error), but the compiler still complains about reading uninitialised memory. While at it, drop the unused assignment right before

Re: [Mesa-dev] [PATCH v2 3/4] platform/android: Enable kms_swrast fallback

Hey Eric, Thanks for the review, adding you r-b. On 2018-07-17 12:48, Eric Engestrom wrote: On Tuesday, 2018-07-17 12:32:59 +0200, Robert Foss wrote: Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a

Re: [Mesa-dev] [PATCH v2 3/4] platform/android: Enable kms_swrast fallback

Hey Eric, On 2018-07-17 12:48, Eric Engestrom wrote: On Tuesday, 2018-07-17 12:32:59 +0200, Robert Foss wrote: Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero value. kms_swrast is also

Re: [Mesa-dev] [PATCH] gm107/ir: use CS2R for SV_CLOCK

that seems like a good enough improvement. I think looking onto other sysvals would be worthwhile as SV_CLOCK isn't used that often. The invocation ID and related ones would be interesting to look into as they are much more common. On Tue, Jul 17, 2018 at 1:59 PM, Rhys Perry wrote: > I'm getting

Re: [Mesa-dev] [PATCH] gm107/ir: use CS2R for SV_CLOCK

I'm getting ~28 cycles for the S2R and ~6 cycles (unsurprisingly) for the CS2R. nvcc with SM30 seems to use the same instruction as the nvc0 emission code. The SV_LANE* system values don't work with CS2R and I haven't looked too deeply into the others. On Tue, Jul 17, 2018 at 12:13 PM, Karol

Re: [Mesa-dev] [PATCH 2/2] egl/surfaceless: Allow DRMless fallback.

On Thursday, 2018-07-12 16:13:55 -0700, David Riley wrote: > Allow platform_surfaceless to use swrast even if DRM is not available. > To be used to allow a fuzzer for virgl to be run on a jailed VM without > hardware GL or DRM support. > > Signed-off-by: David Riley > --- >

Re: [Mesa-dev] [PATCH v2 2/2] nv50/ir: move LateAlgebraicOpt back to right after ConstantFolding

can it be moved after Split64BitOpPreRA? The problem we want to fix here is that LoadPropagation can potentially do some optimizations after running LateAlgebraicOpt. On Tue, Jun 12, 2018 at 3:30 PM, Rhys Perry wrote: > Reverts 3072bbe ("nv50/ir: move LateAlgebraicOpt to the very end") since >

Re: [Mesa-dev] [PATCH] nv50/ir: fix use of getUniqueInsn() in loadProjTexCoords

the big problem with all that is, that the code was correct and turned out to do the right thing. Last time I was looking into that, the projection value was overwritten with the newest projection and this turned out to be returned into insn and just ended up doing the right thing. I would expect

Re: [Mesa-dev] [PATCH] gm107/ir: use CS2R for SV_CLOCK

interesting, do you have some numbers on that? Wondering if we could switch more sysvals over to it and what about older gens? On Tue, Jul 17, 2018 at 12:46 PM, Rhys Perry wrote: > This instruction seems to be faster than S2R and requires no barrier, > though the range of special registers it

Re: [Mesa-dev] [PATCH] radv: reduce number of CB/DB meta flushes for VK_ACCESS_TRANSFER_WRITE_BIT

Reviewed-by: Bas Nieuwenhuizen On Fri, Jul 13, 2018 at 5:35 PM, Samuel Pitoiset wrote: > If we know that the given image doesn't have any metadata, > we don't need to flush. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 20 ++-- > 1 file

Re: [Mesa-dev] [PATCH v2 3/4] platform/android: Enable kms_swrast fallback

On Tuesday, 2018-07-17 12:32:59 +0200, Robert Foss wrote: > Add support for the ForceSoftware option, which is togglable > on the Android platform through setting the "drm.gpu.force_software" > property to a non-zero value. > > kms_swrast is also enabled as a fallback for when a driver is not >

[Mesa-dev] [PATCH] gm107/ir: use CS2R for SV_CLOCK

This instruction seems to be faster than S2R and requires no barrier, though the range of special registers it can read from is limited. Signed-off-by: Rhys Perry --- src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gm107.cpp | 14 +-

Re: [Mesa-dev] [PATCH v2 2/4] egl/android: Add Android property for forcing software rendering

On Tuesday, 2018-07-17 12:32:58 +0200, Robert Foss wrote: > In order to simplify Android bringup on new devices, > provide the property "drm.gpu.force_software" which > forces kms_swrast to be used. > > Signed-off-by: Robert Foss > Reviewed-by: Emil Velikov Reviewed-by: Eric Engestrom > ---

[Mesa-dev] [Bug 92987] fails to determine screen refresh rate when rendering is offloaded

https://bugs.freedesktop.org/show_bug.cgi?id=92987 --- Comment #4 from Michel Dänzer --- This works as expected with DRI3, will probably never be fixed with DRI2. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 92987] fails to determine screen refresh rate when rendering is offloaded

https://bugs.freedesktop.org/show_bug.cgi?id=92987 Stefan Dirsch changed: What|Removed |Added Severity|minor |enhancement --- Comment #3 from Stefan

[Mesa-dev] [PATCH v2 1/4] softpipe: Add assert verifying successful pipe_transfer_map

This failure mode is a bit tricky to debug and manifests itself later as a null pointer dereference, for which finding the origin is needlessly tricky. Signed-off-by: Robert Foss --- Changes since v1: - Patch added src/gallium/drivers/softpipe/sp_tile_cache.c | 1 + 1 file changed, 1

[Mesa-dev] [PATCH v2 0/4] Android kms_swrast support

This series implements kms_swrast support for the Android platform. And since having to debug a null pointer dereference, simplify that process for the next guy. As it stands now, any kernel must have the following ioctls flagged with DRM_RENDER_ALLOW[1], which isn't the case in the mainline

[Mesa-dev] [PATCH v2 4/4] android: Build kms_swrast for the Android platform

From: Rob Herring Signed-off-by: Rob Herring Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since RFC: - Added r-b src/gallium/Android.mk | 2 +- src/gallium/auxiliary/pipe-loader/Android.mk | 1 + src/gallium/drivers/softpipe/Android.mk |

[Mesa-dev] [PATCH v2 3/4] platform/android: Enable kms_swrast fallback

Add support for the ForceSoftware option, which is togglable on the Android platform through setting the "drm.gpu.force_software" property to a non-zero value. kms_swrast is also enabled as a fallback for when a driver is not able to be loaded for for a drm node that was opened. Signed-off-by:

[Mesa-dev] [PATCH v2 2/4] egl/android: Add Android property for forcing software rendering

In order to simplify Android bringup on new devices, provide the property "drm.gpu.force_software" which forces kms_swrast to be used. Signed-off-by: Robert Foss Reviewed-by: Emil Velikov --- Changes since RFC: - Fixed EGLBoolean comparison - Added r-b src/egl/main/egldriver.c | 10

  1   2   >