Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

2018-09-18 Thread Iago Toral
On Tue, 2018-09-18 at 07:27 -0500, Jason Ekstrand wrote: > On Tue, Sep 18, 2018 at 4:11 AM Iago Toral wrote: > > Hi Jason, > > > > > > > > I left a few comments in patches 1 and 4, feel free to ignore them > > if > > > > you think they are not relevant. Either way the series is: > > I would

Re: [Mesa-dev] [PATCH 19/26] nir/linker: use only the array element type for array of ssbo/ubo

2018-09-18 Thread Timothy Arceri
On 16/9/18 2:18 am, Alejandro Piñeiro wrote: For this interfaces, the inner members are added only once as uniforms or resources, in opposite to other cases, like a uniform array of structs. --- src/compiler/glsl/gl_nir_link_uniforms.c | 26 -- 1 file changed, 24

Re: [Mesa-dev] shader cache backward compatibility

2018-09-18 Thread Timothy Arceri
On 3/9/18 6:53 pm, Alexander Larsson wrote: On Mon, Sep 3, 2018 at 10:41 AM Alexander Larsson wrote: On Fri, Aug 31, 2018 at 4:05 PM Emil Velikov wrote: Valid point - I forgot about that. A couple of ideas come to mind: - static link LLVM (Flatpak already does it) No LLVM changes

[Mesa-dev] [PATCH 1/6] util: rename timestamp param in disk_cache_create()

2018-09-18 Thread Timothy Arceri
Only some drivers use a timestamp here. Others use things such as build-id, or even a combination of build-ids from Mesa and LLVM. --- src/util/disk_cache.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/disk_cache.c b/src/util/disk_cache.c index

[Mesa-dev] [PATCH 4/6] nouveau: use build-id when available for disk cache

2018-09-18 Thread Timothy Arceri
--- src/gallium/drivers/nouveau/nouveau_screen.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/nouveau_screen.c b/src/gallium/drivers/nouveau/nouveau_screen.c index c97b707955c..eb184d3559b 100644 ---

[Mesa-dev] [PATCH 6/6] util: disable cache if we have no build-id and timestamp is zero

2018-09-18 Thread Timothy Arceri
Timestamp can be zero for example when Flatpack is used. In this case just disable the cache rather then segfaulting when incompatible cache items are loaded. --- src/amd/vulkan/radv_device.c | 4 src/util/disk_cache.h| 6 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH 5/6] r600: use build-id when available for disk cache

2018-09-18 Thread Timothy Arceri
--- src/gallium/drivers/r600/r600_pipe_common.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe_common.c b/src/gallium/drivers/r600/r600_pipe_common.c index f7cfd0d46a6..6b581242a18 100644 ---

[Mesa-dev] [PATCH 3/6] radeonsi: use build-id when available for disk cache

2018-09-18 Thread Timothy Arceri
--- src/gallium/drivers/radeonsi/si_pipe.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 82af9dd1de7..c38b754bf20 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 2/6] util: add disk_cache_get_function_identifier()

2018-09-18 Thread Timothy Arceri
This can be used as a drop in replacement for disk_cache_get_function_timestamp(). Here we use build-id to generate a driver-id rather than build timestamp if available. This should resolve issues such as distros using reproducable builds and flatpack not having real build timestamps. ---

[Mesa-dev] [Bug 107986] Black window when HiZ enabled

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107986 --- Comment #3 from Bas Nieuwenhuizen --- Well, can reproduce here using the provided application. I'll look into this later this week. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 107986] Black window when HiZ enabled

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107986 --- Comment #2 from programmerj...@gmail.com --- note that the trace plays just fine using AMDVLK -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] radv: Set the user SGPR MSB for Vega.

2018-09-18 Thread Bas Nieuwenhuizen
On Wed, Sep 19, 2018 at 1:46 AM Dylan Baker wrote: > > Quoting Bas Nieuwenhuizen (2018-09-16 03:30:55) > > Otherwise using 32 user SGPRs would be broken. > > > > CC: > > --- > > src/amd/vulkan/radv_shader.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH 1/2] radv: Set the user SGPR MSB for Vega.

2018-09-18 Thread Dylan Baker
Quoting Bas Nieuwenhuizen (2018-09-16 03:30:55) > Otherwise using 32 user SGPRs would be broken. > > CC: > --- > src/amd/vulkan/radv_shader.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c > index e05961339ca..51e0b7d65fc

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 Bas Nieuwenhuizen changed: What|Removed |Added Resolution|NOTOURBUG |FIXED --- Comment #16 from Bas

[Mesa-dev] [Bug 107986] Black window when HiZ enabled

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107986 --- Comment #1 from programmerj...@gmail.com --- My code seems to be causing a crash in NVidia's Vulkan driver, see https://github.com/programmerjake/hashlife3d/issues/1#issuecomment-421829804 -- You are receiving this mail because: You are

[Mesa-dev] [Bug 107986] Black window when HiZ enabled

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107986 programmerj...@gmail.com changed: What|Removed |Added CC||programmerj...@gmail.com --

[Mesa-dev] [Bug 107986] Black window when HiZ enabled

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107986 Bug ID: 107986 Summary: Black window when HiZ enabled Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW Severity: normal

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Adam Jackson (2018-09-18 13:57:18) > On Tue, 2018-09-18 at 13:50 -0700, Dylan Baker wrote: > > > > It would be nice if meson would act like autotools in that regard by > > > creating the drivers and libraries in specific directories (also as a > > > configure option if there is concern

[Mesa-dev] [PATCH 2/2] radv: Support VK_EXT_inline_uniform_block.

2018-09-18 Thread Bas Nieuwenhuizen
Basically just reserve the memory in the descriptor sets. On the shader side we construct a buffer descriptor, since AFAIU VGPR indexing on 32-bit pointers in LLVM is still broken. This fully supports update after bind and variable descriptor set sizes. However, the limits are somewhat arbitrary

[Mesa-dev] [PATCH 1/2] amd/common: Rework buffer resource loading for uniform blocks.

2018-09-18 Thread Bas Nieuwenhuizen
Pointer to descriptor becomes hard if the set does not contain a descriptor. Furthermore we have no extra channel to pass whether the given pointer points to a descriptor or not. --- src/amd/common/ac_nir_to_llvm.c | 98 +-- src/amd/common/ac_shader_abi.h

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Adam Jackson
On Tue, 2018-09-18 at 13:50 -0700, Dylan Baker wrote: > > It would be nice if meson would act like autotools in that regard by > > creating the drivers and libraries in specific directories (also as a > > configure option if there is concern about compilation speed). > > This is impossible by

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: fix descriptor pool allocation size

2018-09-18 Thread Bas Nieuwenhuizen
+Dylan as 18.1 Release Manager Hi Dylan, Please be advised that the above patch has been reverted on master in 95bb7d82ca8abf514af2575e3b9f4babfbb034c4 and should not be included in the 18.1.9 release. Thanks, Bas On Tue, Sep 18, 2018 at 8:19 PM Samuel Pitoiset wrote: > > > > On 9/18/18 8:07

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Gert Wollny (2018-09-18 12:16:01) > Am Montag, den 17.09.2018, 17:07 -0400 schrieb Marek Ol\u0161ák: > > I don't see radeonsi_dri.so. How/where is radeonsi_dri.so created? > +1 > > With autotools I can use an uninstalled but compiled version of meson > (e.g. for testing) by pointing

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Kai Wasserbäch (2018-09-18 11:14:19) > Dylan Baker wrote on 9/18/18 6:40 PM: > > Quoting Kai Wasserbäch (2018-09-18 08:56:30) > >> Dylan Baker wrote on 9/18/18 5:35 PM: > >>> [...] > >>> > >>> This is something we've discussed upstream several times. I will freely > >>> admit > >>> that

[Mesa-dev] [PATCH 2/6] radeonsi:optimizing SET_CONTEXT_REG for shaders GS

2018-09-18 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 15 ++- src/gallium/drivers/radeonsi/si_state.h | 19 ++- .../drivers/radeonsi/si_state_shaders.c | 112 -- 3 files changed, 109 insertions(+), 37 deletions(-) diff --git

[Mesa-dev] [PATCH 5/6] radeonsi:optimizing SET_CONTEXT_REG for shaders Tessellation

2018-09-18 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 + src/gallium/drivers/radeonsi/si_state.h | 1 + .../drivers/radeonsi/si_state_shaders.c | 51 ++- 3 files changed, 29 insertions(+), 24 deletions(-) diff --git

[Mesa-dev] [PATCH 6/6] radeonsi:optimizing SET_CONTEXT_REG for shaders vgt_vertex_reuse

2018-09-18 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 + src/gallium/drivers/radeonsi/si_state.h | 1 + .../drivers/radeonsi/si_state_shaders.c | 25 +-- 3 files changed, 14 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 3/6] radeonsi:optimizing SET_CONTEXT_REG for shaders VS

2018-09-18 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 6 + src/gallium/drivers/radeonsi/si_state.h | 6 + .../drivers/radeonsi/si_state_shaders.c | 133 +++--- 3 files changed, 93 insertions(+), 52 deletions(-) diff --git

[Mesa-dev] [PATCH 4/6] radeonsi:optimizing SET_CONTEXT_REG for shaders PS

2018-09-18 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 7 + src/gallium/drivers/radeonsi/si_state.h | 11 ++ .../drivers/radeonsi/si_state_shaders.c | 144 ++ 3 files changed, 98 insertions(+), 64 deletions(-) diff --git

[Mesa-dev] [PATCH 1/6] radeonsi: optimizing SET_CONTEXT_REG for shaders ES

2018-09-18 Thread Sonny Jiang
Signed-off-by: Sonny Jiang --- src/gallium/drivers/radeonsi/si_gfx_cs.c | 1 + src/gallium/drivers/radeonsi/si_pm4.c | 3 +++ src/gallium/drivers/radeonsi/si_pm4.h | 11 ++ src/gallium/drivers/radeonsi/si_state.h | 9 ++--

Re: [Mesa-dev] Bug introduced with Mesa 18.0.0: Star Trek Voyager Elite Force shadow glitches

2018-09-18 Thread Roland Scheidegger
Am 18.09.2018 um 20:04 schrieb Federico Dossena: > The problem is caused by this commit: > [3d81e11b49366b5636b8524ba0f8c7076e3fdf34] mesa: remove unnecessary > 'sort by year' for the GL extensions >

[Mesa-dev] [Bug 107777] No 3D in "Vampire: The Masquerade - Bloodlines" when d3d-nine enabled

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=10 --- Comment #15 from Axel Davy --- "HKEY_CURRENT_USER/Software/Wine/DirectDrawRenderer="gdi"" did actually change something to the behaviour with nine ? It looks bad, because it only affects wined3d, and it could indicate that both are used,

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Gert Wollny
Am Montag, den 17.09.2018, 17:07 -0400 schrieb Marek Olšák: > I don't see radeonsi_dri.so. How/where is radeonsi_dri.so created? +1 With autotools I can use an uninstalled but compiled version of meson (e.g. for testing) by pointing LD_LIBRARY_PATH and LIBGL_DRIVERS_PATH to the $BUILDDIR/lib and

Re: [Mesa-dev] [PATCH 5/5] docs/meson: Add note about llvm-config$version and llvm-config-$version

2018-09-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-09-18 11:16:25) > On Tuesday, 2018-09-18 09:13:04 -0700, Dylan Baker wrote: > > These are how FreeBSD and Debian handle multiple versions of LLVM > > installed at the same time, respectively. > > --- > > docs/meson.html | 3 ++- > > 1 file changed, 2 insertions(+), 1

Re: [Mesa-dev] [PATCH 4/5] docs/meson: Update notes on using CFLAGS and -Dc_args

2018-09-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-09-18 11:12:49) > On Tuesday, 2018-09-18 09:13:03 -0700, Dylan Baker wrote: > > bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107313 > > --- > > docs/meson.html | 28 ++-- > > 1 file changed, 14 insertions(+), 14 deletions(-) > > > >

Re: [Mesa-dev] [PATCH 1/5] meson: Don't compile pipe loader with dri support when not using dri

2018-09-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-09-18 11:07:57) > On Tuesday, 2018-09-18 19:02:55 +0100, Eric Engestrom wrote: > > On Tuesday, 2018-09-18 09:13:00 -0700, Dylan Baker wrote: > > > Corrects building glx as gallium-xlib without any dri targets. > > > > > > Fixes:

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #15 from Gustaw Smolarczyk --- It turns out it really was a problem on mesa side. I think we should change the resolution of the bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

Re: [Mesa-dev] [PATCH] meson: add option to statically link llvm

2018-09-18 Thread Christoph Haag
On 9/18/18 6:56 PM, Dylan Baker wrote: > I can't say I'm entirely thrilled, but: > Reviewed-by: Dylan Baker > > Do you need me to push this for you? > > > ___ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org >

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: fix descriptor pool allocation size

2018-09-18 Thread Samuel Pitoiset
On 9/18/18 8:07 PM, Juan A. Suarez Romero wrote: On Tue, 2018-09-18 at 17:20 +0200, Gustaw Smolarczyk wrote: pt., 14 wrz 2018 o 15:00 Bas Nieuwenhuizen napisał(a): Reviewed-by: Bas Nieuwenhuizen On Fri, Sep 14, 2018 at 2:55 PM Samuel Pitoiset wrote: The size has to be multiplied by

Re: [Mesa-dev] [PATCH 5/5] docs/meson: Add note about llvm-config$version and llvm-config-$version

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 09:13:04 -0700, Dylan Baker wrote: > These are how FreeBSD and Debian handle multiple versions of LLVM > installed at the same time, respectively. > --- > docs/meson.html | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/docs/meson.html

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Kai Wasserbäch
Dylan Baker wrote on 9/18/18 6:40 PM: > Quoting Kai Wasserbäch (2018-09-18 08:56:30) >> Dylan Baker wrote on 9/18/18 5:35 PM: >>> [...] >>> >>> This is something we've discussed upstream several times. I will freely >>> admit >>> that llvm-config is a huge pain in the ass to deal with for a ton

Re: [Mesa-dev] [PATCH 4/5] docs/meson: Update notes on using CFLAGS and -Dc_args

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 09:13:03 -0700, Dylan Baker wrote: > bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107313 > --- > docs/meson.html | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/docs/meson.html b/docs/meson.html > index

Re: [Mesa-dev] [PATCH 3/5] docs: update meson docs to reflect the current status

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 09:13:02 -0700, Dylan Baker wrote: > --- > docs/meson.html | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/docs/meson.html b/docs/meson.html > index 29907a60a9c..e419d13e76d 100644 > --- a/docs/meson.html > +++ b/docs/meson.html > @@ -21,10

Re: [Mesa-dev] [Mesa-stable] [PATCH] radv: fix descriptor pool allocation size

2018-09-18 Thread Juan A. Suarez Romero
On Tue, 2018-09-18 at 17:20 +0200, Gustaw Smolarczyk wrote: > pt., 14 wrz 2018 o 15:00 Bas Nieuwenhuizen > napisał(a): > > > > Reviewed-by: Bas Nieuwenhuizen > > On Fri, Sep 14, 2018 at 2:55 PM Samuel Pitoiset > > wrote: > > > > > > The size has to be multiplied by the number of sets. > > >

Re: [Mesa-dev] [PATCH 1/5] meson: Don't compile pipe loader with dri support when not using dri

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 19:02:55 +0100, Eric Engestrom wrote: > On Tuesday, 2018-09-18 09:13:00 -0700, Dylan Baker wrote: > > Corrects building glx as gallium-xlib without any dri targets. > > > > Fixes: 66c94b9313a697ce8f2b222f4ba353035e4b8726 > >("meson: build gallium winsys for dri,

Re: [Mesa-dev] [PATCH 2/5] meson: Don't force libva to required from auto

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 09:13:01 -0700, Dylan Baker wrote: > We already correctly handle va being auto, but we force it to being > true, which is bad. > > Fixes 94cf3970925ec87d913a1549a42cdb03713fc4bb > ("meson: Fix auto option for va") Reviewed-by: Eric Engestrom > --- > meson.build |

Re: [Mesa-dev] [PATCH 1/5] meson: Don't compile pipe loader with dri support when not using dri

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 09:13:00 -0700, Dylan Baker wrote: > Corrects building glx as gallium-xlib without any dri targets. > > Fixes: 66c94b9313a697ce8f2b222f4ba353035e4b8726 >("meson: build gallium winsys for dri, null, and wrapper") Reviewed-by: Eric Engestrom > --- >

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-09-18 09:59:22) > On Tuesday, 2018-09-18 09:35:20 -0700, Dylan Baker wrote: > > Quoting Eric Engestrom (2018-09-18 09:00:49) > > > On Tuesday, 2018-09-18 08:24:52 -0700, Dylan Baker wrote: > > > > Quoting Kenneth Graunke (2018-09-18 01:40:48) > > > > > On Monday,

Re: [Mesa-dev] [PATCH] radv: fix descriptor pool allocation size

2018-09-18 Thread Samuel Pitoiset
On 9/18/18 5:20 PM, Gustaw Smolarczyk wrote: pt., 14 wrz 2018 o 15:00 Bas Nieuwenhuizen napisał(a): Reviewed-by: Bas Nieuwenhuizen On Fri, Sep 14, 2018 at 2:55 PM Samuel Pitoiset wrote: The size has to be multiplied by the number of sets. This gets rid of the OUT_OF_POOL_KHR error and

Re: [Mesa-dev] [PATCH] radv: fix descriptor pool allocation size

2018-09-18 Thread Bas Nieuwenhuizen
On Tue, 18 Sep 2018, 17:21 Gustaw Smolarczyk, wrote: > pt., 14 wrz 2018 o 15:00 Bas Nieuwenhuizen > napisał(a): > > > > Reviewed-by: Bas Nieuwenhuizen > > On Fri, Sep 14, 2018 at 2:55 PM Samuel Pitoiset > > wrote: > > > > > > The size has to be multiplied by the number of sets. > > > > > >

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 09:35:20 -0700, Dylan Baker wrote: > Quoting Eric Engestrom (2018-09-18 09:00:49) > > On Tuesday, 2018-09-18 08:24:52 -0700, Dylan Baker wrote: > > > Quoting Kenneth Graunke (2018-09-18 01:40:48) > > > > On Monday, September 17, 2018 3:24:56 PM PDT Dylan Baker wrote: > > > >

Re: [Mesa-dev] [PATCH] meson: add option to statically link llvm

2018-09-18 Thread Dylan Baker
Quoting Christoph Haag (2018-09-17 16:08:07) > From: Christoph Haag > > --- > meson.build | 4 > meson_options.txt | 6 ++ > 2 files changed, 10 insertions(+) > > diff --git a/meson.build b/meson.build > index 0588ebf8e7a..5e250470ed1 100644 > --- a/meson.build > +++

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Eric Engestrom (2018-09-18 09:00:49) > On Tuesday, 2018-09-18 08:24:52 -0700, Dylan Baker wrote: > > Quoting Kenneth Graunke (2018-09-18 01:40:48) > > > On Monday, September 17, 2018 3:24:56 PM PDT Dylan Baker wrote: > > > > Quoting Marek Ol\u0161ák (2018-09-17 15:14:11) > > > > > How do I

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Kai Wasserbäch (2018-09-18 08:56:30) > Dylan Baker wrote on 9/18/18 5:35 PM: > > Quoting Kai Wasserbäch (2018-09-18 07:43:08) > >> Hey, > >> Dylan Baker wrote on 9/17/18 6:44 PM: > >>> I feel like for !windows meson is in good enough shape at this point that > >>> we > >>> can start

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Chuck Atkins (2018-09-18 08:00:44) > First, I'm fully in support of killing off autotools woo-hoo to that.  And > given the substantial investment already put into the meson build that > certainly seems like a good direction to go. > > That being said, the way "auto" is currently

[Mesa-dev] [PATCH 4/5] docs/meson: Update notes on using CFLAGS and -Dc_args

2018-09-18 Thread Dylan Baker
bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107313 --- docs/meson.html | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index e419d13e76d..1640e577d16 100644 --- a/docs/meson.html +++ b/docs/meson.html

[Mesa-dev] [PATCH 3/5] docs: update meson docs to reflect the current status

2018-09-18 Thread Dylan Baker
--- docs/meson.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/meson.html b/docs/meson.html index 29907a60a9c..e419d13e76d 100644 --- a/docs/meson.html +++ b/docs/meson.html @@ -21,10 +21,10 @@ The Meson build system is generally considered stable and ready

[Mesa-dev] [PATCH 1/5] meson: Don't compile pipe loader with dri support when not using dri

2018-09-18 Thread Dylan Baker
Corrects building glx as gallium-xlib without any dri targets. Fixes: 66c94b9313a697ce8f2b222f4ba353035e4b8726 ("meson: build gallium winsys for dri, null, and wrapper") --- src/gallium/auxiliary/pipe-loader/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

[Mesa-dev] [PATCH 5/5] docs/meson: Add note about llvm-config$version and llvm-config-$version

2018-09-18 Thread Dylan Baker
These are how FreeBSD and Debian handle multiple versions of LLVM installed at the same time, respectively. --- docs/meson.html | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/meson.html b/docs/meson.html index 1640e577d16..d9148e44671 100644 --- a/docs/meson.html +++

[Mesa-dev] [PATCH 2/5] meson: Don't force libva to required from auto

2018-09-18 Thread Dylan Baker
We already correctly handle va being auto, but we force it to being true, which is bad. Fixes 94cf3970925ec87d913a1549a42cdb03713fc4bb ("meson: Fix auto option for va") --- meson.build | 2 -- 1 file changed, 2 deletions(-) diff --git a/meson.build b/meson.build index

[Mesa-dev] [Bug 104843] Mesa version not updated for rebuild

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104843 Dylan Baker changed: What|Removed |Added Resolution|--- |NOTABUG Status|NEEDINFO

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Eric Engestrom
On Tuesday, 2018-09-18 08:24:52 -0700, Dylan Baker wrote: > Quoting Kenneth Graunke (2018-09-18 01:40:48) > > On Monday, September 17, 2018 3:24:56 PM PDT Dylan Baker wrote: > > > Quoting Marek Olšák (2018-09-17 15:14:11) > > > > How do I build 32-bit Mesa with meson? > > > > > > > > Thanks, > >

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Kai Wasserbäch
Dylan Baker wrote on 9/18/18 5:35 PM: > Quoting Kai Wasserbäch (2018-09-18 07:43:08) >> Hey, >> Dylan Baker wrote on 9/17/18 6:44 PM: >>> I feel like for !windows meson is in good enough shape at this point that we >>> can start having the discussion about deleting the autotools build. So, is >>>

[Mesa-dev] [Bug 101405] x.org/wiki/GalliumStatus/: Add description for DEPRECATED

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101405 --- Comment #3 from Adam Jackson --- (In reply to David Hedlund from comment #2) > Thank you. Can you please add a disclaimer on > https://www.x.org/wiki/GalliumStatus/ to make this clear? Done:

Re: [Mesa-dev] Bug introduced with Mesa 18.0.0: Star Trek Voyager Elite Force shadow glitches

2018-09-18 Thread Roland Scheidegger
Am 18.09.2018 um 17:09 schrieb Federico Dossena: > Weapon fire doesn't generate shadows in this game, just a light. > > cg_shadow is set to 3.  Other values don't seem to change anything > except for 2 making the game sluggish. > r_stencilbits is already set to 8. > r_dynamiclights is set to 1;

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Brian Paul (2018-09-17 20:02:21) > Hi Dylan, > > I have my 32-bit cross-compile working, but "ninja -C builddir install" > isn't putting the 32-bit libs and drivers in the right place. > > I've been playing with the meson --prefix option and the > -Ddri-drivers-path=foo option but

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Kai Wasserbäch (2018-09-18 07:43:08) > Hey, > Dylan Baker wrote on 9/17/18 6:44 PM: > > I feel like for !windows meson is in good enough shape at this point that we > > can start having the discussion about deleting the autotools build. So, is > > there > > anything left that autotools

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Ilia Mirkin (2018-09-17 17:56:15) > On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > > I feel like for !windows meson is in good enough shape at this point that we > > can start having the discussion about deleting the autotools build. So, is > > there > > anything left that

[Mesa-dev] [PATCH] gallium/util: Clarify comment in util_init_thread_pinning

2018-09-18 Thread Michel Dänzer
From: Michel Dänzer As discussed in the review of the patch which added the comment: Nothing happens when a thread is created, because pthread_atfork doesn't affect creating threads. However, spawning a child process will likely crash. Signed-off-by: Michel Dänzer ---

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Dylan Baker
Quoting Kenneth Graunke (2018-09-18 01:40:48) > On Monday, September 17, 2018 3:24:56 PM PDT Dylan Baker wrote: > > Quoting Marek Olšák (2018-09-17 15:14:11) > > > How do I build 32-bit Mesa with meson? > > > > > > Thanks, > > > Marek > > > > > > > Some people get away with just adding

Re: [Mesa-dev] [PATCH] radv: fix descriptor pool allocation size

2018-09-18 Thread Gustaw Smolarczyk
pt., 14 wrz 2018 o 15:00 Bas Nieuwenhuizen napisał(a): > > Reviewed-by: Bas Nieuwenhuizen > On Fri, Sep 14, 2018 at 2:55 PM Samuel Pitoiset > wrote: > > > > The size has to be multiplied by the number of sets. > > > > This gets rid of the OUT_OF_POOL_KHR error and fixes > > the Tangrams demo.

Re: [Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Sergii Romantsov
> > Isn't x guaranteed to be 0.0F here? Yes, it will 0.0f but its not used in any computation anywhere. So new 'else'-block should be treated as (1,0,0) on input - its optimized computation of rotation only by x. On Tue, Sep 18, 2018 at 5:56 PM, Gustaw Smolarczyk wrote: > wt., 18 wrz 2018 o

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Chuck Atkins
First, I'm fully in support of killing off autotools woo-hoo to that. And given the substantial investment already put into the meson build that certainly seems like a good direction to go. That being said, the way "auto" is currently implemented leaves quite a bit to be desired. One of the

Re: [Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Gustaw Smolarczyk
wt., 18 wrz 2018 o 15:59 Sergii Romantsov napisał(a): > > Specification doesn't define behaviour for rotation of 0-vector. > Windows and Nvidia drivers have a workaround for that. > For compatibility proposed that for 0-vector a rotation will be > done around x-axis. > > -v2: logic moved to

Re: [Mesa-dev] Bug introduced with Mesa 18.0.0: Star Trek Voyager Elite Force shadow glitches

2018-09-18 Thread Roland Scheidegger
I don't see any shadows at all with the 17.3.7 video? Whereas the 18.0.0 one look quite bogus to me, but I think shadows are known to be glitchy with id tech 3? It should be possible to tweak shadows via cg_shadow (0-3), r_stencilbits 8 might be necessary for some modes, r_dynamiclights 0 might

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Kai Wasserbäch
Hey, Dylan Baker wrote on 9/17/18 6:44 PM: > I feel like for !windows meson is in good enough shape at this point that we > can start having the discussion about deleting the autotools build. So, is > there > anything left that autotools can do that meson cannot (that we actually want > to >

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] radv: use a 64-bit unsigned integer when allocating a descriptor pool

2018-09-18 Thread Samuel Pitoiset
pool->size is a 64-bit unsigned integer too. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_descriptor_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index 49d0811bb0..143881fb6e

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #13 from kyle.de...@mykolab.com --- Your patch doesn't help, unfortunately. Probably best if I report this bug to dolphin-emu, then. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact

Re: [Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Sergii Romantsov
Uploaded new version. Seems that waiting for any response on https://github.com/KhronosGroup/OpenGL-API/issues/41 may take much more time On Tue, Sep 18, 2018 at 4:57 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > Specification doesn't define behaviour for rotation of 0-vector.

[Mesa-dev] [PATCH v2] mesa: rotation of 0-vector

2018-09-18 Thread Sergii Romantsov
Specification doesn't define behaviour for rotation of 0-vector. Windows and Nvidia drivers have a workaround for that. For compatibility proposed that for 0-vector a rotation will be done around x-axis. -v2: logic moved to _math_matrix_rotate Bugzilla:

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #12 from Samuel Pitoiset --- Created attachment 141640 --> https://bugs.freedesktop.org/attachment.cgi?id=141640=edit possible fix Well, dolphin tries to allocate a TON of memory for one descriptor pool. It allocates 16262320

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #11 from kyle.de...@mykolab.com --- I ran dolphin-emu, and decided to log any errors (why didn't I think of this previously...): 43:00:797 VideoBackends/Vulkan/VulkanLoader.cpp:314 E[Video]: (CreateCommandBuffers)

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #10 from kyle.de...@mykolab.com --- Is this potentially a dolphin-emu bug, then? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #9 from kyle.de...@mykolab.com --- No change... :/ -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug.___ mesa-dev mailing list

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #8 from Gustaw Smolarczyk --- Hi, I am just passing by. I have found the following piece of code in Dolphin source code [1]: VkDescriptorPoolCreateInfo pool_create_info = {VK_STRUCTURE_TYPE_DESCRIPTOR_POOL_CREATE_INFO,

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #7 from Samuel Pitoiset --- Created attachment 141639 --> https://bugs.freedesktop.org/attachment.cgi?id=141639=edit test Please try this patch. Does it abort? -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #6 from kyle.de...@mykolab.com --- Backtrace: https://paste.kde.org/pnt3dlvpx -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 1/3] mesa: use GLsizeiptrARB, GLintptrARB in bufferobj.c

2018-09-18 Thread Brian Paul
On 09/17/2018 10:32 PM, Mathias Fröhlich wrote: > Good Morning, > > On Tuesday, 18 September 2018 05:10:04 CEST Brian Paul wrote: >> The function pointer declarations in dd.h for the BufferData() and >> BufferSubData() use the ARB-suffixed datatypes. This patch changes >> the

[Mesa-dev] [PATCH] radv: enable VK_SUBGROUP_FEATURE_ARITHMETIC_BIT

2018-09-18 Thread Samuel Pitoiset
All CTS pass on Polaris/Vega with LLVM 6, 7 and master, so I think it's safe to enable the feature. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_device.c | 1 + src/amd/vulkan/radv_shader.c | 1 + 2 files changed, 2 insertions(+) diff --git a/src/amd/vulkan/radv_device.c

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #5 from Samuel Pitoiset --- I meant what commit. Are you sure it's 90819abb56f6b1a0cd4946b13b6caf24fb46e500 ? That seems quite weird. Yes, please attach a backtrace. -- You are receiving this mail because: You are the assignee

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #4 from kyle.de...@mykolab.com --- As soon as I click play for any of the games in dolphin-emu's game list, which is when it starts the renderer. I can provide a backtrace from dolphin-emu, if it helps any. -- You are receiving

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #3 from Samuel Pitoiset --- So, when does the problem start exactly? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.___

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #2 from kyle.de...@mykolab.com --- > It is 6521d4a659b911bb86d979564de03665616a671e that cause problems with > dolphin-emu initializing Vulkan in the first place. Actually, no, ignore this... -- You are receiving this mail

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #1 from kyle.de...@mykolab.com --- Actually, 90819abb56f6b1a0cd4946b13b6caf24fb46e500 ~ `radv: fix descriptor pool allocation size` is where the fun starts. It crashes dolphin-emu with "Failed to create Vulkan command buffers" It

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 kyle.de...@mykolab.com changed: What|Removed |Added Summary|Commit |Commit

[Mesa-dev] [PATCH] radv: do not support blitting surfaces with depth and stencil

2018-09-18 Thread Samuel Pitoiset
Fixes: dEQP-VK.api.copy_and_blit.core.blit_image.all_formats.depth_stencil.d32_sfloat_s8_uint_d32_sfloat_s8_uint.optimal_optimal_nearest And all friends that try to blit a surface with different depth and stencil formats. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_formats.c | 4

Re: [Mesa-dev] Lets talk about autotools

2018-09-18 Thread Eric Engestrom
On Monday, 2018-09-17 17:25:36 -0400, Marek Olšák wrote: > Where do I find default values for meson configure options? If you mean the project's options, they're in meson_options.txt; currently not printed in the output of `meson configure` though. If you mean Meson's own options (like

[Mesa-dev] [Bug 107977] Commit 6521d4a659b911bb86d979564de03665616a671e breaks dolphin-emu Vulkan initialization on at least RX580

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 kyle.de...@mykolab.com changed: What|Removed |Added Summary|Commit `Revert "radv: |Commit

[Mesa-dev] [Bug 107977] Commit `Revert "radv: Optimize rebinding the same descriptor set."` breaks dolphin-emu Vulkan initialization on at least RX580

2018-09-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107977 kyle.de...@mykolab.com changed: What|Removed |Added CC||kyle.de...@mykolab.com,

  1   2   >