[Mesa-dev] [Bug 107994] driinfo_gallium.h:32:72: error: expected '; ' after top level declarator

https://bugs.freedesktop.org/show_bug.cgi?id=107994 Bug ID: 107994 Summary: driinfo_gallium.h:32:72: error: expected ';' after top level declarator Product: Mesa Version: git Hardware: x86-64 (AMD64) OS:

[Mesa-dev] [Bug 107870] Undefined symbols for architecture x86_64: "_util_cpu_caps"

https://bugs.freedesktop.org/show_bug.cgi?id=107870 Vinson Lee changed: What|Removed |Added Keywords||bisected --- Comment #2 from Vinson Lee

[Mesa-dev] [PATCH 2/4] freedreno: don't do flush unless needed.

The commit 4b847b38 introduced some crashes of deqp gles31 cts, since it always tries to flush if the flag flushed is false, which is the initial state. This sometimes makes it trying unnecessary drawing when context is being destroyed for example. Fixes:

[Mesa-dev] [PATCH 2/4] freedreno: don't do flush unless needed.

The commit 4b847b38 introduced some crashes of deqp gles31 cts, since it always tries to flush if the flag flushed is false, which is the initial state. This sometimes makes it trying unnecessary drawing when context is being destroyed for example. Fixes:

[Mesa-dev] [PATCH] pci_ids: add new polaris pci id

Signed-off-by: Alex Deucher Cc: mesa-sta...@lists.freedesktop.org --- include/pci_ids/radeonsi_pci_ids.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/pci_ids/radeonsi_pci_ids.h b/include/pci_ids/radeonsi_pci_ids.h index c8d30597230..dd2fc3b8f25 100644 ---

[Mesa-dev] [PATCH 4/4] freedreno: fix a typo in launch_grid

--- src/gallium/drivers/freedreno/freedreno_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/freedreno_draw.c b/src/gallium/drivers/freedreno/freedreno_draw.c index 0a472c78b1..0b7f9ffe5e 100644 ---

[Mesa-dev] [PATCH 3/4] freedreno: synchronize when flushing batches in launch_grid

Since the commit 4b847b38 landed, there has been a race condition in launch_grid, which is between fdX_launch_grid and rendering in batch flush. This leads many cts to unstable results, especially for those using compute shader. Fixes: many cts for compute shader including

[Mesa-dev] [PATCH 1/4] freedreno/ir3: fix the param order of cmpxchg

According to the following definition, int AtomicCompSwap(inout int mem, uint compare, uint data); the preceding one in atomic_comp_swap of NIR is compare and data is followed, while src0 for cmpxchg needs vec2(data, compare) So for ssbo/image deref comp_swap, that should be reversed. Fixes:

[Mesa-dev] [PATCH 2/4] freedreno: don't do flush unless needed.

The commit 4b847b38 introduced some crashes of deqp gles31 cts, since it always tries to flush if the flag flushed is false, which is the initial state. This sometimes makes it trying unnecessary drawing when context is being destroyed for example. Fixes:

[Mesa-dev] [PATCH 0/4] fix crashes and failures of deqp gles31

This series fixes crashes/failures of tests from deqp gles31 on freedreno. Thanks for review. Hyunjun Ko (4): freedreno/ir3: fix the param order of cmpxchg freedreno: don't do flush unless needed. freedreno: synchronize when flushing batches in launch_grid freedreno: fix a typo in

[Mesa-dev] [Bug 106996] Compiler diagnostic for sampler declared as "out" parameter of function is terrible

https://bugs.freedesktop.org/show_bug.cgi?id=106996 --- Comment #3 from Ilia Mirkin --- (In reply to Ian Romanick from comment #2) > sampler variables cannot be assigned, so it's impossible for it to be an out > parameter. FWIW they can be with bindless. But then the expectation would be that

Re: [Mesa-dev] [PATCH V2 6/6] util: disable cache if we have no build-id and timestamp is zero

R-b On Thu, 20 Sep 2018, 00:54 Timothy Arceri, wrote: > Timestamp can be zero for example when Flatpak is used. In this > case just disable the cache rather then segfaulting when > incompatible cache items are loaded. > > V2: actually return false when mtime is 0. > --- >

[Mesa-dev] [PATCH V2 6/6] util: disable cache if we have no build-id and timestamp is zero

Timestamp can be zero for example when Flatpak is used. In this case just disable the cache rather then segfaulting when incompatible cache items are loaded. V2: actually return false when mtime is 0. --- src/amd/vulkan/radv_device.c | 4 src/util/disk_cache.h| 8 2 files

[Mesa-dev] [Bug 107547] shader crashing glsl_compiler (uniform block assigned to vec2, then component substraced by 1)

https://bugs.freedesktop.org/show_bug.cgi?id=107547 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 19/26] nir/linker: use only the array element type for array of ssbo/ubo

On 19/9/18 11:10 pm, Alejandro Piñeiro wrote: On 19/09/18 14:09, Timothy Arceri wrote: On 19/9/18 7:59 pm, Alejandro Piñeiro wrote: On 19/09/18 07:20, Timothy Arceri wrote: On 16/9/18 2:18 am, Alejandro Piñeiro wrote: For this interfaces, the inner members are added only once as uniforms

Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

Looks good On September 19, 2018 22:18:56 "Juan A. Suarez Romero" wrote: On Mon, 2018-09-17 at 09:43 -0500, Jason Ekstrand wrote: This pass re-materializes deref instructions on a per-block basis to ensure that every use of a deref occurs in the same block as the instruction which uses it.

Re: [Mesa-dev] [PATCH] docs: Update FAQ with respect to s3tc support

On Wed, 2018-09-19 at 18:28 +1000, Stuart Young wrote: > -4.3 Why isn't GL_EXT_texture_compression_s3tc implemented in Mesa? > +4.3 The GL_EXT_texture_compression_s3tc feature and Mesa? This isn't really a question, so probably shouldn't end with a question mark. I would leave the original

[Mesa-dev] [ANNOUNCE] Mesa 18.2.1 release candidate

Hello list, The candidate for the Mesa 18.2.1 is now available. Currently we have: - 57 queued (+1 squashed) - 0 nominated (outstanding) - and 2 rejected patches The current queue consists of: Vulkan headers are now updated to 1.1.84. Lot of fixes for Vulkan drivers. In RADV driver there

[Mesa-dev] [PATCH 2/2] gallium/ttn: Convert inputs and outputs to derefs of variables.

This means that TTN shaders more closely resemble GTN shaders: they have inputs and outputs as variable derefs, with the variables having their .driver_location already set up for you. This will be useful for v3d to do input variable DCE in NIR, which we can't do when the TTN shaders never have a

[Mesa-dev] [PATCH 1/2] gallium/ttn: Fix the type of gl_FragDepth.

In TGSI we have a vec4 of which only .z is used, but for NIR we should be using a float the same as other NIR IR. We were already moving TGSI's .z to the .x channel. --- src/gallium/auxiliary/nir/tgsi_to_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [Mesa-dev] [PATCH 1/4] nir: Add a small pass to rematerialize derefs per-block

On Mon, 2018-09-17 at 09:43 -0500, Jason Ekstrand wrote: > This pass re-materializes deref instructions on a per-block basis to > ensure that every use of a deref occurs in the same block as the > instruction which uses it. Hello! This patch was commited CCing to 18.2 stable branch. This patch

[Mesa-dev] [Bug 104926] swrast: Mesa 17.3.3 produces: HW cursor for format 875713089 not supported

https://bugs.freedesktop.org/show_bug.cgi?id=104926 Adam Jackson changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 104926] swrast: Mesa 17.3.3 produces: HW cursor for format 875713089 not supported

https://bugs.freedesktop.org/show_bug.cgi?id=104926 --- Comment #8 from Adam Williamson --- Confirmed the patch fixes the error message flood, makes my VM cursor move much more smoothly, and somehow seems to fix paste from the host system into the VM too. Maybe I should see if it can pick my

[Mesa-dev] [Bug 104926] swrast: Mesa 17.3.3 produces: HW cursor for format 875713089 not supported

https://bugs.freedesktop.org/show_bug.cgi?id=104926 --- Comment #7 from Adam Williamson --- I'm seeing exactly these same message floods running Fedora 29 images in VMs, and indeed the fix seems to have got lost - there was one reply to the message, then crickets after that, and it's still

[Mesa-dev] [Bug 107989] GLES 3.x context: GL_INVALID_OPERATION in glGenerateMipmap(invalid internal format GL_RED)

https://bugs.freedesktop.org/show_bug.cgi?id=107989 Andrei Alexeyev <0x416b617...@gmail.com> changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] Lets talk about autotools

Quoting Kai Wasserbäch (2018-09-19 08:04:35) > Hey Dylan, > Dylan Baker wrote on 9/18/18 10:43 PM: > > Quoting Kai Wasserbäch (2018-09-18 11:14:19) > >> Dylan Baker wrote on 9/18/18 6:40 PM: > >>> Quoting Kai Wasserbäch (2018-09-18 08:56:30) > Dylan Baker wrote on 9/18/18 5:35 PM: > >

Re: [Mesa-dev] Lets talk about autotools

Quoting Ilia Mirkin (2018-09-17 17:56:15) > On Mon, Sep 17, 2018 at 12:44 PM, Dylan Baker wrote: > > I feel like for !windows meson is in good enough shape at this point that we > > can start having the discussion about deleting the autotools build. So, is > > there > > anything left that

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

This patch broke all the intel systems also. Ilia Mirkin writes: > On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz > wrote: >> This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full >> setup is dEQP running on virgl with vtest that is running RadeonSI. So >> QEMU is not in the

[Mesa-dev] [PATCH v2] anv/skylake: disable ForceThreadDispatchEnable

On Skylake enabling of ForceThreadDispatchEnable causes gpu-hang. -v2: enabling of ForceThreadDispatchEnable is only for gen8, for gen9 and higher reverted enabling of PixelShaderHasUAV. CC: Jason Ekstrand Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107941 Fixes: 79270d2140ec

Re: [Mesa-dev] [PATCH v1] anv/skylake: disable ForceThreadDispatchEnable

Probably there should be some much more complex conditions for doing that, but as initial solution... On Wed, Sep 19, 2018 at 6:55 PM, Sergii Romantsov < sergii.romant...@gmail.com> wrote: > On Skylake enabling of ForceThreadDispatchEnable causes gpu-hang. > > CC: Jason Ekstrand > Bugzilla:

[Mesa-dev] [PATCH v1] anv/skylake: disable ForceThreadDispatchEnable

On Skylake enabling of ForceThreadDispatchEnable causes gpu-hang. CC: Jason Ekstrand Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107941 Fixes: 79270d2140ec (anv: Stop setting 3DSTATE_PS_EXTRA::PixelShaderHasUAV) Signed-off-by: Sergii Romantsov --- src/intel/vulkan/genX_pipeline.c |

Re: [Mesa-dev] Lets talk about autotools

On 09/18/2018 10:38 AM, Dylan Baker wrote: > Quoting Eric Engestrom (2018-09-18 09:59:22) >> On Tuesday, 2018-09-18 09:35:20 -0700, Dylan Baker wrote: >>> Quoting Eric Engestrom (2018-09-18 09:00:49) On Tuesday, 2018-09-18 08:24:52 -0700, Dylan Baker wrote: > Quoting Kenneth Graunke

Re: [Mesa-dev] Lets talk about autotools

On 09/18/2018 12:16 PM, Gert Wollny wrote: > Am Montag, den 17.09.2018, 17:07 -0400 schrieb Marek Olšák: >> I don't see radeonsi_dri.so. How/where is radeonsi_dri.so created? > +1 > > With autotools I can use an uninstalled but compiled version of meson > (e.g. for testing) by pointing

Re: [Mesa-dev] [PATCH 2/2] .travis: Drop note about Clover builds being slow

On Wed, 2018-09-12 at 18:20 -0400, Jan Vesely wrote: > SWR takes 17+ minutes to build. Clover builds take ~6-7 minutes. > > Signed-off-by: Jan Vesely > --- > .travis.yml | 4 > 1 file changed, 4 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 4035a729ff..78e6d251ae 100644

[Mesa-dev] [Bug 106996] Compiler diagnostic for sampler declared as "out" parameter of function is terrible

https://bugs.freedesktop.org/show_bug.cgi?id=106996 Ian Romanick changed: What|Removed |Added Summary|Compute shader compiling|Compiler diagnostic for

Re: [Mesa-dev] [PATCH 1/3] mesa: use GLsizeiptrARB, GLintptrARB in bufferobj.c

Hi Brian, > gl.xml doesn't seem relevant to this. In GL/glext.h we have: I thought that somewere at khronos the headers are generated from the xml. And the new headers are usually imported then together with the matching xml into mesa? > typedef khronos_ssize_t GLsizeiptr; > [...] > typedef

Re: [Mesa-dev] Lets talk about autotools

Hey Dylan, Dylan Baker wrote on 9/18/18 10:43 PM: > Quoting Kai Wasserbäch (2018-09-18 11:14:19) >> Dylan Baker wrote on 9/18/18 6:40 PM: >>> Quoting Kai Wasserbäch (2018-09-18 08:56:30) Dylan Baker wrote on 9/18/18 5:35 PM: > [...] > > The other option you have it to set the

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

On 2018-09-19 1:10 p.m., Erik Faye-Lund wrote: > On on., sep. 19, 2018 at 1:04 PM, Jakob Bornecrantz > wrote: >> This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full >> setup is dEQP running on virgl with vtest that is running RadeonSI. So >> QEMU is not in the picture. All

Re: [Mesa-dev] [PATCH 1/4] anv/so_memcpy: Don't consider src/dst_offset when computing block size

Reviewed-by: Lionel Landwerlin On 12/09/2018 06:06, Jason Ekstrand wrote: The only thing that matters is the size since we never specify any offsets in terms of blocks. --- src/intel/vulkan/genX_gpu_memcpy.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

On Wed, Sep 19, 2018 at 1:48 PM Ilia Mirkin wrote: > > On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz > wrote: > > This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full > > setup is dEQP running on virgl with vtest that is running RadeonSI. So > > QEMU is not in the picture.

[Mesa-dev] [PATCH] radeon/uvd: use bitstream coded number for symbols of Huffman tables

Signed-off-by: Leo Liu Fixes: 130d1f456(radeon/uvd: reconstruct MJPEG bitstream) Cc: "18.2" --- src/gallium/drivers/radeon/radeon_uvd.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_uvd.c

Re: [Mesa-dev] [PATCH 19/26] nir/linker: use only the array element type for array of ssbo/ubo

On 19/09/18 14:09, Timothy Arceri wrote: > On 19/9/18 7:59 pm, Alejandro Piñeiro wrote: >> On 19/09/18 07:20, Timothy Arceri wrote: >>> On 16/9/18 2:18 am, Alejandro Piñeiro wrote: For this interfaces, the inner members are added only once as uniforms or resources, in opposite to other

Re: [Mesa-dev] [PATCH 6/6] util: disable cache if we have no build-id and timestamp is zero

On 19/9/18 9:32 pm, Bas Nieuwenhuizen wrote: On Wed, Sep 19, 2018 at 4:14 AM Timothy Arceri wrote: Timestamp can be zero for example when Flatpack is used. In this case just disable the cache rather then segfaulting when incompatible cache items are loaded. ---

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

On Wed, Sep 19, 2018 at 7:04 AM, Jakob Bornecrantz wrote: > This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full > setup is dEQP running on virgl with vtest that is running RadeonSI. So > QEMU is not in the picture. All instances of the Mesa driver is from > the same tree and have

Re: [Mesa-dev] Bug introduced with Mesa 18.0.0: Star Trek Voyager Elite Force shadow glitches

Am 19.09.2018 um 07:55 schrieb Federico Dossena: > I tried setting MESA_EXTENSION_YEAR=2002 but the glitch still occurs. > Same with 2000 and 2001. What about 1999? Can you provide the complete console output so we can see what extension it's looking for (if it prints that out like q3 does)? >

Re: [Mesa-dev] [PATCH 19/26] nir/linker: use only the array element type for array of ssbo/ubo

On 19/9/18 7:59 pm, Alejandro Piñeiro wrote: On 19/09/18 07:20, Timothy Arceri wrote: On 16/9/18 2:18 am, Alejandro Piñeiro wrote: For this interfaces, the inner members are added only once as uniforms or resources, in opposite to other cases, like a uniform array of structs. ---  

[Mesa-dev] [Bug 107939] Commit 888b7fc causes performance regression

https://bugs.freedesktop.org/show_bug.cgi?id=107939 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

Re: [Mesa-dev] [PATCH 6/6] util: disable cache if we have no build-id and timestamp is zero

On 19/9/18 9:32 pm, Bas Nieuwenhuizen wrote: On Wed, Sep 19, 2018 at 4:14 AM Timothy Arceri wrote: Timestamp can be zero for example when Flatpack is used. In this case just disable the cache rather then segfaulting when incompatible cache items are loaded. --- src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH 6/6] util: disable cache if we have no build-id and timestamp is zero

On Wed, Sep 19, 2018 at 4:14 AM Timothy Arceri wrote: > > Timestamp can be zero for example when Flatpack is used. In this > case just disable the cache rather then segfaulting when > incompatible cache items are loaded. > --- > src/amd/vulkan/radv_device.c | 4 > src/util/disk_cache.h

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

On on., sep. 19, 2018 at 1:04 PM, Jakob Bornecrantz wrote: This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full setup is dEQP running on virgl with vtest that is running RadeonSI. So QEMU is not in the picture. All instances of the Mesa driver is from the same tree and have

Re: [Mesa-dev] [PATCH] mesa: only update framebuffer-state for clears

This patch regresses about 3000 dEQP [2,3,3.1] tests on virgl. Full setup is dEQP running on virgl with vtest that is running RadeonSI. So QEMU is not in the picture. All instances of the Mesa driver is from the same tree and have the patch applied. Cheers, Jakob. On Wed, Sep 12, 2018 at 12:05 PM

[Mesa-dev] [Bug 107989] GLES 3.x context: GL_INVALID_OPERATION in glGenerateMipmap(invalid internal format GL_RED)

https://bugs.freedesktop.org/show_bug.cgi?id=107989 --- Comment #1 from Tapani Pälli --- For me it seems this behavior is according to the OpenGL ES spec: "An INVALID_OPERATION error is generated if the level base array was not specified with an unsized internal format from table 8.3 or a sized

Re: [Mesa-dev] [PATCH 19/26] nir/linker: use only the array element type for array of ssbo/ubo

On 19/09/18 07:20, Timothy Arceri wrote: > On 16/9/18 2:18 am, Alejandro Piñeiro wrote: >> For this interfaces, the inner members are added only once as uniforms >> or resources, in opposite to other cases, like a uniform array of >> structs. >> --- >>   src/compiler/glsl/gl_nir_link_uniforms.c |

Re: [Mesa-dev] [PATCH] nir: add initializer data to fix MSVC compile error

On Wed, 2018-09-19 at 11:40 +0200, Juan A. Suarez Romero wrote: > CC: Jason Ekstrand > Fixes: 82799a5d1b8 ("nir: Add a small pass to rematerialize derefs ^^^ 7d1d1208c2b I've committed a mistake when referring the commit it fixes. > per-block") > --- >

[Mesa-dev] [AppVeyor] mesa master #8903 completed

Build mesa 8903 completed Commit 0c82e3603e by Juan A. Suarez Romero on 9/19/2018 9:27 AM: nir: add initializer data to fix MSVC compile error\n\nCC: Jason Ekstrand \nFixes: 82799a5d1b8 ("nir: Add a small pass to rematerialize derefs\nper-block")\nReviewed-by:

Re: [Mesa-dev] [PATCH] nir: add initializer data to fix MSVC compile error

Reviewed-by: Samuel Iglesias Gonsálvez On 19/09/18 11:40, Juan A. Suarez Romero wrote: > CC: Jason Ekstrand > Fixes: 82799a5d1b8 ("nir: Add a small pass to rematerialize derefs > per-block") > --- > src/compiler/nir/nir_deref.c | 2 +- > 1 file changed, 1

[Mesa-dev] [PATCH] nir: add initializer data to fix MSVC compile error

CC: Jason Ekstrand Fixes: 82799a5d1b8 ("nir: Add a small pass to rematerialize derefs per-block") --- src/compiler/nir/nir_deref.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_deref.c b/src/compiler/nir/nir_deref.c index 1a3bf4ad206..4a87ee84d8a 100644

[Mesa-dev] [Bug 107989] GLES 3.x context: GL_INVALID_OPERATION in glGenerateMipmap(invalid internal format GL_RED)

https://bugs.freedesktop.org/show_bug.cgi?id=107989 Bug ID: 107989 Summary: GLES 3.x context: GL_INVALID_OPERATION in glGenerateMipmap(invalid internal format GL_RED) Product: Mesa Version: 18.2 Hardware: All

[Mesa-dev] [PATCH] docs: Update FAQ with respect to s3tc support

It's just over 10 months since 17.3.0 was released with s3tc support enabled. Probably a good idea to update the FAQ page. CC: --- docs/faq.html | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/docs/faq.html b/docs/faq.html index 1f2fd66034..3d0010885a

[Mesa-dev] [AppVeyor] mesa master #8902 failed

Build mesa 8902 failed Commit 976046a8d8 by Jason Ekstrand on 9/11/2018 6:06 PM: nir: Add some asserts that we don't put derefs in phis\n\nThe lcssa and phis_to_regs passes are used by various NIR optimizations\nthat modify the CFG. Putting a couple of

[Mesa-dev] [Bug 107977] Commit 90819abb56f6b1a0cd4946b13b6caf24fb46e500 crashes dolphin-emu with "Failed to create Vulkan command buffers"

https://bugs.freedesktop.org/show_bug.cgi?id=107977 --- Comment #17 from kyle.de...@mykolab.com --- Can you explain why it was a bug in Mesa? Just trying to understand why the change broke things. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee