Re: [Mesa-dev] [PATCH 5/6] nir/algebraic: Losten a restriction on variables

Subject: s/Losten/Loosen/ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/9] nir/search: Use nir_src_is_const and friends

On Sat, Oct 20, 2018 at 12:55 PM Jason Ekstrand wrote: > --- > src/compiler/nir/nir_search.c | 70 +++ > 1 file changed, 13 insertions(+), 57 deletions(-) > > diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c > index

[Mesa-dev] [PATCH 9/9] anv: Use nir_src_is_const and friends in lowering code

--- src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 15 ++- src/intel/vulkan/anv_nir_lower_ycbcr_textures.c | 6 +++--- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c

[Mesa-dev] [PATCH 8/9] intel/analyze_ubo_ranges: Use nir_src_is_const and friends

--- src/intel/compiler/brw_nir_analyze_ubo_ranges.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/intel/compiler/brw_nir_analyze_ubo_ranges.c b/src/intel/compiler/brw_nir_analyze_ubo_ranges.c index cfa531675fc..9008e4e7afd 100644 ---

[Mesa-dev] [PATCH 6/6] nir/algebraic: Provide descriptive asserts for bit size checks

This will hopefully make debugging opt_algebraic bit-size compile failures easier. --- src/compiler/nir/nir_algebraic.py | 51 +-- 1 file changed, 42 insertions(+), 9 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py

[Mesa-dev] [PATCH 2/6] nir/algebraic: Generalize an optimization

There's nothing boolean about (a | ~a) ~> -1 --- src/compiler/nir/nir_opt_algebraic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index cc747250ba5..8b24daddfdc 100644 ---

[Mesa-dev] [PATCH 4/6] nir/algebraic: A bit of validation refactoring'

We rename some local variables in validate() to be more readable and plumb the var through to get/set_var_bit_class instead of the var index. --- src/compiler/nir/nir_algebraic.py | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[Mesa-dev] [PATCH 3/6] nir/algebraic: Make internal classes str-able

--- src/compiler/nir/nir_algebraic.py | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index eccef0d2c97..39b85089b1e 100644 --- a/src/compiler/nir/nir_algebraic.py +++

[Mesa-dev] [PATCH 5/6] nir/algebraic: Losten a restriction on variables

Previously, we would fail if a variable had an assigned but unknown bit size X and we tried to assign it an actual bit size. However, this is ok because, at the time we do the search, the variable does have an actual bit size and it will match X because of the NIR rules. ---

[Mesa-dev] [PATCH 0/6] nir: Cleanups for opt_algebraic

This little series provides some cleanups for opt_algebraic. The most important of which is adding descriptions to a bunch of the asserts in the bit-size checker. I've only gotten through about half of it so there's still more work to do but it should make the error messages printed out much

[Mesa-dev] [PATCH 1/6] nir/algebraic: Use bool internally instead of bool32

--- src/compiler/nir/nir_algebraic.py | 4 ++-- src/compiler/nir/nir_search.c | 6 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/compiler/nir/nir_algebraic.py b/src/compiler/nir/nir_algebraic.py index 3055937029c..eccef0d2c97 100644 ---

[Mesa-dev] [PATCH 1/9] nir: Add some new helpers for working with const sources

--- src/compiler/nir/nir.c | 92 ++ src/compiler/nir/nir.h | 16 2 files changed, 108 insertions(+) diff --git a/src/compiler/nir/nir.c b/src/compiler/nir/nir.c index 402fd2c7725..0be40d257f5 100644 --- a/src/compiler/nir/nir.c +++

[Mesa-dev] [PATCH 0/9] nir: Add better helpers for handling constant sources

Previously, the only thing we had was nir_src_as_const_value which returns a pointer to a nir_const_value which was NULL if the source wasn't actually a constant. This was great except that almost none of the users considered anything other than 32-bit values. With 8, 16, and 64-bit values

[Mesa-dev] [PATCH 2/9] nir/search: Use nir_src_is_const and friends

--- src/compiler/nir/nir_search.c | 70 +++ 1 file changed, 13 insertions(+), 57 deletions(-) diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c index 21fcbe7aaec..559cc893583 100644 --- a/src/compiler/nir/nir_search.c +++

[Mesa-dev] [PATCH 6/9] intel/fs: Use the new nir_src_is_const and friends

As of this commit, all uses of const sources either go through a nir_src_as_ helper which handles bit sizes correctly or else are accompanied by a nir_src_bit_size() == 32 assertion to assert that we have the size we think we have. --- src/intel/compiler/brw_fs_nir.cpp | 200

[Mesa-dev] [PATCH 4/9] nir: Use nir_src_is_const and nir_src_as_* in core code

--- src/compiler/glsl/gl_nir_lower_samplers.c | 7 ++- src/compiler/nir/nir_deref.c| 14 ++ src/compiler/nir/nir_gather_info.c | 6 ++ src/compiler/nir/nir_gs_count_vertices.c| 7 +++ src/compiler/nir/nir_lower_clip.c

[Mesa-dev] [PATCH 3/9] nir/search_helpers: Use nir_src_is_const and friends

This not only makes them safe for more bit sizes but it also fixes a bug in is_zero_to_one where it would return true for constant NaN. --- src/compiler/nir/nir_search_helpers.h | 49 --- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git

[Mesa-dev] [PATCH 5/9] intel/fs, vec4: Clean up a repeated pattern with SSBOs

Everywhere we handle SSBO intrinsics, we have exactly the same pattern for computing the index so we may as well make a helper for it. We also add a get_nir_src_imm to vec4 and use it for SSBO offsets. --- src/intel/compiler/brw_fs.h | 2 + src/intel/compiler/brw_fs_nir.cpp | 123

[Mesa-dev] [PATCH mesa 1/2] util: use C99 declaration in the for-loop hash_table_foreach() macro

Signed-off-by: Eric Engestrom --- src/amd/common/ac_nir_to_llvm.c| 1 - src/broadcom/compiler/vir_live_variables.c | 2 -- src/broadcom/compiler/vir_lower_uniforms.c | 1 - src/compiler/glsl/ast_to_hir.cpp | 1 -

[Mesa-dev] [PATCH mesa 2/2] util: use C99 declaration in the for-loop set_foreach() macro

Signed-off-by: Eric Engestrom --- src/compiler/glsl/opt_copy_propagation_elements.cpp | 1 - src/compiler/glsl/standalone.cpp | 2 -- src/compiler/nir/nir_control_flow.c | 1 - src/compiler/nir/nir_dominance.c | 4

Re: [Mesa-dev] [RFC] docs: Add a copyright.c template we can copy when making new files.

On Friday, 2018-10-19 20:43:44 +0100, Chris Wilson wrote: > Quoting Kenneth Graunke (2018-10-19 18:51:36) > > Usually when making a new file, people copy some random other file > > to get the copyright header comments. Unfortunately, some of them > > are commented in a decades-old style, are word

Re: [Mesa-dev] [PATCH] i965: consider a 'base level' when calculating width0, height0, depth0

Hello, On Fri, Oct 12, 2018 at 01:52 Ian Romanick wrote: > On 10/11/2018 12:12 PM, Kenneth Graunke wrote: > > On Thursday, October 11, 2018 11:58:40 AM PDT Kenneth Graunke wrote: > >> On Tuesday, October 2, 2018 9:16:01 AM PDT asimiklit.w...@gmail.com > wrote: > >>> From: Andrii Simiklit > >>>

Re: [Mesa-dev] [PATCH] i965: consider a 'base level' when calculating width0, height0, depth0

Hello, On Fri, Oct 19, 2018 at 15:14 Kenneth Graunke wrote: > On Thursday, October 11, 2018 12:12:38 PM PDT Kenneth Graunke wrote: > > On Thursday, October 11, 2018 11:58:40 AM PDT Kenneth Graunke wrote: > > > On Tuesday, October 2, 2018 9:16:01 AM PDT asimiklit.w...@gmail.com > wrote: > > > >

[Mesa-dev] [Bug 107022] [RADV] The Witcher 3: Trembling of trees

https://bugs.freedesktop.org/show_bug.cgi?id=107022 Jan Ziak <0xe2.0x9a.0...@gmail.com> changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH 3/3] Revert "radv: disable VK_SUBGROUP_FEATURE_VOTE_BIT"

Can you wait until the CTS fix is upstream before pushing this please? On 10/18/18 4:13 PM, Connor Abbott wrote: This reverts commit 647c2b90e96a9ab8571baf958a7c67c1e816911a. There was one recently-introduced bug in ac for dvec3 loads, but the other test failures were actually bugs in the