Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On 10/31/18 7:03 PM, Ilia Mirkin wrote: On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund wrote: On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: I had to do a double (or triple) take on this logic as well. Part of the subtlety is that the fallback only applies for ES when there's a

[Mesa-dev] [PATCH] mapi: avoid text relocation in x86 tsd stubs

Make similiar changes to libglvnd to avoid a text relocation in x86 tsd stubs fixing the build with lld. Signed-off-by: Jonathan Gray Cc: mesa-sta...@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108541 --- src/mapi/entry_x86_tsd.h | 14 +- 1 file

[Mesa-dev] [PATCH] intel/tools: include stdarg.h in error2aub

Include stdarg.h in error2aub.c otherwise it fails to build on OpenBSD due to not finding definitions for va_list va_start va_end. Signed-off-by: Jonathan Gray Cc: mesa-sta...@lists.freedesktop.org --- src/intel/tools/error2aub.c | 1 + 1 file changed, 1 insertion(+) diff --git

[Mesa-dev] [PATCH] intel/aubinator_error_decode: link libm

aubinator_error_decode needs to link libm to build on OpenBSD/i386 ../../src/util/.libs/libmesautil.a(libmesautil_la-half_float.o): In function `_mesa_float_to_half': half_float.c:(.text+0x91): undefined reference to `lrintf' half_float.c:(.text+0xc1): undefined reference to `lrintf'

[Mesa-dev] [PATCH] util/xmlpool: avoid using a GNU make pattern rule

% pattern rules are a GNU extension. Convert the use of one to a inference rule to allow this to build on OpenBSD. Signed-off-by: Jonathan Gray --- src/util/xmlpool/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/xmlpool/Makefile.am

Re: [Mesa-dev] [PATCH 2/2] nir: allow propagation of if evaluation to all alu instructions

On Wed, Oct 31, 2018 at 5:21 PM Timothy Arceri wrote: > On 1/11/18 1:28 am, Jason Ekstrand wrote: > > On Tue, Oct 30, 2018 at 9:17 PM Timothy Arceri > > wrote: > > > > With the simplifications to this pass in a3b4cb34589e2f1a68 we > > can allow any alu

[Mesa-dev] [PATCH] radv: apply xfb buffer offset at buffer binding time not later. (v2)

From: Dave Airlie In order to handle pause/resume properly, the offset should be added to the buffer binding not to the begin/end paths. v2: don't add offset to size Fixes ext_transform_feedback-alignment* under zink Fixes: b4eb029062 (radv: implement VK_EXT_transform_feedback) ---

[Mesa-dev] [PATCH] i965: Lift restriction in external textures for EGLImage support

For Intel platforms, we support external textures only for EGLImages created with EGL_EXT_image_dma_buf_import. This restriction seems to be Intel specific and not present for other platforms. While running SKQP test - unitTest_EGLImageTest, GL_INVALID is sent to the test because of this

Re: [Mesa-dev] [PATCH 1/3] radv: use radeon_info::num_good_cu_per_sh

For all 3, Reviewed-by: Dave Airlie On Mon, 29 Oct 2018 at 20:35, Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_device.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/amd/vulkan/radv_device.c

Re: [Mesa-dev] [PATCH 2/3] uac/nir: add get_cache_policy() helper and use it

On Tue, 30 Oct 2018 at 02:04, Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 38 ++--- > 1 file changed, 26 insertions(+), 12 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH 1/3] ac/nir: make use of i1false in few more places

For this one: Reviewed-by: Dave Airlie On Tue, 30 Oct 2018 at 02:04, Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset > --- > src/amd/common/ac_nir_to_llvm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/amd/common/ac_nir_to_llvm.c

Re: [Mesa-dev] [PATCH] radv: add support for Raven2

On Tue, 30 Oct 2018 at 20:52, Samuel Pitoiset wrote: > > Signed-off-by: Samuel Pitoiset Looks good, Reviewed-by: Dave Airlie > --- > src/amd/vulkan/radv_device.c | 10 +++--- > src/amd/vulkan/radv_pipeline.c | 1 + > src/amd/vulkan/si_cmd_buffer.c | 1 + > 3 files changed, 9

[Mesa-dev] [PATCH] radv: fix begin/end transform feedback with 0 counter buffers.

From: Dave Airlie If the user gives 0 counterBuffers then the driver should still enable transform feedback on all targets. This changes the driver to always enable xfb, and use counter buffers where one is defined for the target in question. Fixes: b4eb029062 (radv: implement

[Mesa-dev] [PATCH] radv: apply xfb buffer offset at buffer binding time not later.

From: Dave Airlie In order to handle pause/resume properly, the offset should be added to the buffer binding not to the begin/end paths. Fixes: ext_transform_feedback-alignment* under zink --- src/amd/vulkan/radv_cmd_buffer.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [Bug 108601] gen_xmlpool.py fails if LANG=C.*

https://bugs.freedesktop.org/show_bug.cgi?id=108601 Dylan Baker changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

https://bugs.freedesktop.org/show_bug.cgi?id=108530 Bug 108530 depends on bug 108601, which changed state. Bug 108601 Summary: gen_xmlpool.py fails if LANG=C.* https://bugs.freedesktop.org/show_bug.cgi?id=108601 What|Removed |Added

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

On Wed, 2018-10-31 at 16:14 -0700, Dylan Baker wrote: > Quoting Jan Vesely (2018-10-31 11:37:19) > > On Wed, 2018-10-31 at 11:22 -0700, Francisco Jerez wrote: > > > I don't object removing the pre-LLVM 5.0 paths, nor keeping them around > > > in order to make r600 happy. What would it take to

Re: [Mesa-dev] [PATCH v2 3/3] i965/gen9: Add workarounds for object preemption.

On Wednesday, October 31, 2018 11:15:28 AM PDT Rafael Antognolli wrote: > On Tue, Oct 30, 2018 at 04:32:54PM -0700, Kenneth Graunke wrote: > > On Monday, October 29, 2018 10:19:54 AM PDT Rafael Antognolli wrote: > > Do we need any stalling when whacking CS_CHICKEN1...? > > Hmmm... there's this: >

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

Quoting Jan Vesely (2018-10-31 11:37:19) > On Wed, 2018-10-31 at 11:22 -0700, Francisco Jerez wrote: > > I don't object removing the pre-LLVM 5.0 paths, nor keeping them around > > in order to make r600 happy. What would it take to forward-port the > > r600 image support code to more recent LLVM

Re: [Mesa-dev] [PATCH 02/12] meson: bump the minimum LLVM version to 5.0.1

Quoting Emil Velikov (2018-10-31 06:29:54) > From: Emil Velikov > > Currently the minimal version is 3.3 with 3.9 for r600+opencl. > > We kept it as low, since transitioning to newer ones is pain on Windows. > With issues ranging from build problems, memory leaks and various other > small

[Mesa-dev] [PATCH] r600/sb: Fix constant logical operand in assert.

Fixes: da977ad90747 ("r600/sb: start adding GDS support") Signed-off-by: Vinson Lee --- src/gallium/drivers/r600/sb/sb_bc_builder.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/sb/sb_bc_builder.cpp b/src/gallium/drivers/r600/sb/sb_bc_builder.cpp

Re: [Mesa-dev] [PATCH 12/14] mesa/vbo: Move src/mesa/vbo/vbo_exec_array.c -> src/mesa/main/draw.c

On 10/30/2018 11:48 PM, Mathias Fröhlich wrote: > Hi Brian, > > On Tuesday, 30 October 2018 13:06:50 CET Brian Paul wrote: >> The series looks great, Mathias. >> >> Reviewed-by: Brian Paul > > Thanks for that one! > >>> @@ -2072,7 +2073,7 @@ vbo_initialize_exec_dispatch(const struct gl_context

Re: [Mesa-dev] [PATCH 2/2] nir: allow propagation of if evaluation to all alu instructions

On 1/11/18 1:28 am, Jason Ekstrand wrote: On Tue, Oct 30, 2018 at 9:17 PM Timothy Arceri > wrote: With the simplifications to this pass in a3b4cb34589e2f1a68 we can allow any alu instruction to be processed. For one this can potentially help with

[Mesa-dev] [Bug 108530] [Tracker] Mesa 18.3 Release Tracker

https://bugs.freedesktop.org/show_bug.cgi?id=108530 Vinson Lee changed: What|Removed |Added Depends on||108595 Referenced Bugs:

Re: [Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

If we are going to start tightening up this stuff I would really really like to see CTS tests (not piglit tests) to go along with this stuff. We are already way stricter with these type of things than the closed source drivers and this leads to some apps not working. Before we go ahead and

Re: [Mesa-dev] [PATCH] gallium/util: don't let children of fork & exec inherit our thread affinity

On Wed, Oct 31, 2018 at 11:26 AM Michel Dänzer wrote: > On 2018-10-31 12:39 a.m., Gustaw Smolarczyk wrote: > > śr., 31 paź 2018 o 00:23 Marek Olšák napisał(a): > >> On Tue, Oct 30, 2018 at 7:11 PM Gustaw Smolarczyk > wrote: > >>> wt., 30 paź 2018 o 23:55 Marek Olšák napisał(a): > On Tue,

[Mesa-dev] [Bug 108508] Graphic glitches with stream output support on OLAND AMD GPU GCN 1.0

https://bugs.freedesktop.org/show_bug.cgi?id=108508 --- Comment #19 from Ahmed Elsayed --- RenderDoc (OpenGL) record of The Witcher 3 https://drive.google.com/open?id=19lmkh1v7LfkdMELU98DnituhF3Rj-Za7 -- You are receiving this mail because: You are the assignee for the bug. You are the QA

Re: [Mesa-dev] [PATCH 12/14] util/gen_xmlpool: Don't write via shell redirection

On Fri, Oct 26, 2018 at 1:24 PM Dylan Baker wrote: > > This is bad for a couple of reasons, but the worst is that it gets the > shell involved. When the shell gets involved we can start running into > problems with LANG, namely LANG=C. This is particularly obnoxious for > translation files, since

Re: [Mesa-dev] [PATCH 12/14] util/gen_xmlpool: Don't write via shell redirection

On Wed, 31 Oct 2018 at 18:53, Dylan Baker wrote: > > Quoting Emil Velikov (2018-10-31 11:18:18) > > On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > > > > > This is bad for a couple of reasons, but the worst is that it gets the > > > shell involved. When the shell gets involved we can start

Re: [Mesa-dev] [PATCH] android: gallium/auxiliary: add include to get u_debug.h header

Quoting Mauro Rossi (2018-10-31 10:34:53) > To avoid build error in u_debug_stack_android.cpp > due to now missing u_debug.h header: > > external/mesa/src/gallium/auxiliary/util/u_debug_stack_android.cpp:26:10: > fatal error: 'u_debug.h' file not found > #include "u_debug.h" > ^ > 1

[Mesa-dev] [ANNOUNCE] mesa 18.2.4

Mesa 18.2.4 is now available. In this release we have: Different fixes for different drivers: freedreno, radeonsi, swr, anv and radv. Also there are fixes for ac, gallium, spirv and blorp. Alex Smith (2): ac/nir: Use context-specific LLVM types anv: Fix sanitization of stencil

Re: [Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

Quoting Emil Velikov (2018-10-31 11:32:29) > On Wed, 31 Oct 2018 at 18:11, Dylan Baker wrote: > > > > Quoting Emil Velikov (2018-10-31 10:47:53) > > > On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > > > > > > > This is a little cleaner than just looking at sys.argv, but it's also > > > >

Re: [Mesa-dev] [PATCH 12/14] util/gen_xmlpool: Don't write via shell redirection

Quoting Emil Velikov (2018-10-31 11:18:18) > On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > > > This is bad for a couple of reasons, but the worst is that it gets the > > shell involved. When the shell gets involved we can start running into > > problems with LANG, namely LANG=C. This is

Re: [Mesa-dev] [PATCH mesa] meson: hide warnings from external project `gtest`

On Wed, 31 Oct 2018 at 18:20, Eric Engestrom wrote: > > On Wednesday, 2018-10-31 10:15:40 -0700, Dylan Baker wrote: > > gtest doesn't generate any warnings, but this seems fine, > > It does for me, because I have more warnings enabled locally :P > Nothing special enabled here, gtest is fairly

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

On Wed, 31 Oct 2018 at 17:41, Jan Vesely wrote: > > On Wed, 2018-10-31 at 17:22 +, Emil Velikov wrote: > > On Wed, 31 Oct 2018 at 16:24, Michel Dänzer wrote: > > > On 2018-10-31 5:19 p.m., Jan Vesely wrote: > > > > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > > > > > From: Emil

[Mesa-dev] [PATCH v2] glsl: Correct several built-in functions availability

In GLSL versions 1.00 ES, 1.10 and 1.20, Mesa includes some built-in functions which shouldn't be present in that version, namely: genIType abs(genIType x) genIType sign(genIType x) genIType min(genIType x, genIType y) genIType min(genIType x, int y) genIType max(genIType x,

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

On Wed, 2018-10-31 at 11:22 -0700, Francisco Jerez wrote: > I don't object removing the pre-LLVM 5.0 paths, nor keeping them around > in order to make r600 happy. What would it take to forward-port the > r600 image support code to more recent LLVM versions? Converting the llvm pass to the new

Re: [Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

On Wed, 31 Oct 2018 at 18:11, Dylan Baker wrote: > > Quoting Emil Velikov (2018-10-31 10:47:53) > > On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > > > > > This is a little cleaner than just looking at sys.argv, but it's also > > > going to allow us to handle the differences in the way

Re: [Mesa-dev] [PATCH 14/14] util/gen_xmlpool: Make use of python's foreach loop

On Fri, 26 Oct 2018 at 18:24, Dylan Baker wrote: > > Instead of using a while loop with indexing. This is much cleaner. This > requires some other small changes. Looks better indeed. Assuming you've checked that Python2 still works (I feel dirty saying it) Acked-by: Emil Velikov Thanks Emil

Re: [Mesa-dev] [PATCH 10/14] util/gen_xmlpool: use a main function

Quoting Emil Velikov (2018-10-31 11:05:44) > On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > > > Again, just good style > > One could have added the main function to begin with and then add the > args/etc. > Either way, things are starting to read a bit easier. Thanks Historical

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

I don't object removing the pre-LLVM 5.0 paths, nor keeping them around in order to make r600 happy. What would it take to forward-port the r600 image support code to more recent LLVM versions? Jan Vesely writes: > On Wed, 2018-10-31 at 17:02 +, Emil Velikov wrote: >> On Wed, 31 Oct 2018

Re: [Mesa-dev] [PATCH 13/14] util/gen_xmlpool: Don't use len to test for container emptiness

On Fri, 26 Oct 2018 at 18:24, Dylan Baker wrote: > > This is a very common python anti-pattern. Not using length allows us to > go through faster C paths, but has the same meaning. Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 07/14] docs/meson: Add note about update translations

Quoting Emil Velikov (2018-10-31 10:54:08) > On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > > > --- > > docs/meson.html | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/docs/meson.html b/docs/meson.html > > index ece64673107..51f661b6e0a 100644 > > ---

Re: [Mesa-dev] [PATCH mesa] meson: hide warnings from external project `gtest`

On Wednesday, 2018-10-31 10:15:40 -0700, Dylan Baker wrote: > gtest doesn't generate any warnings, but this seems fine, It does for me, because I have more warnings enabled locally :P One that I'd like to eventually enable (and as an error if possible) is -Wundef to warn when undefined macros

Re: [Mesa-dev] [PATCH 12/14] util/gen_xmlpool: Don't write via shell redirection

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > This is bad for a couple of reasons, but the worst is that it gets the > shell involved. When the shell gets involved we can start running into > problems with LANG, namely LANG=C. This is particularly obnoxious for > translation files, since

Re: [Mesa-dev] [PATCH v2 00/13] Engine parameter for instructions

On Wed, Oct 31, 2018 at 9:34 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > On 31/10/2018 14:20, Jason Ekstrand wrote: > > Toni, > > I'm a bit curious where you're going with this. I started on a similar > project a couple of years ago: > >

Re: [Mesa-dev] [PATCH v2 00/13] Engine parameter for instructions

On Wed, Oct 31, 2018 at 11:10 AM Toni Lönnberg wrote: > When we debug media or 3d+media workloads, we'd like to be able to see > what is > in the aub dumps for those workloads. At the moment the decoder can't > distinguish instructions which share the same opcode between the render > and > video

Re: [Mesa-dev] [PATCH v2 3/3] i965/gen9: Add workarounds for object preemption.

On Tue, Oct 30, 2018 at 04:32:54PM -0700, Kenneth Graunke wrote: > On Monday, October 29, 2018 10:19:54 AM PDT Rafael Antognolli wrote: > > Gen9 hardware requires some workarounds to disable preemption depending > > on the type of primitive being emitted. > > > > We implement this by adding a new

Re: [Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

Quoting Emil Velikov (2018-10-31 10:47:53) > On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > > > This is a little cleaner than just looking at sys.argv, but it's also > > going to allow us to handle the differences in the way meson and > > autotools handle translations more cleanly. > > > >

Re: [Mesa-dev] [PATCH 11/14] util/gen_xmlpool: use with statement to open file

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > Which ensures it is closed at the end of the scope. Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 10/14] util/gen_xmlpool: use a main function

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > Again, just good style One could have added the main function to begin with and then add the args/etc. Either way, things are starting to read a bit easier. Thanks Reviewed-by: Emil Velikov -Emil

Re: [Mesa-dev] [PATCH 09/14] util/gen_xmlpool: Use print function instad of sys.stderr.write

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > This ensures that stderr is flushed, unlike writing Reviewed-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 08/14] util/gen_xmlpool: Use more standard style

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > gen_xmlpool uses a style unlike the rest of mesa, spaces between > function/method calls and the parens, strange whitespace to force lining > up method calls, and some other whitespace stuff. Since I'm going to be > doing some work in the file,

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

On Wed, 2018-10-31 at 17:02 +, Emil Velikov wrote: > On Wed, 31 Oct 2018 at 15:57, Jan Vesely wrote: > > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > LLVM versions earlier than 5.0.1 are no longer supported. > > > > I'd prefer to keep

Re: [Mesa-dev] [PATCH 07/14] docs/meson: Add note about update translations

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > --- > docs/meson.html | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/docs/meson.html b/docs/meson.html > index ece64673107..51f661b6e0a 100644 > --- a/docs/meson.html > +++ b/docs/meson.html > @@ -95,6 +95,13 @@ each

Re: [Mesa-dev] [PATCH 06/14] util/gen_xmlpool: Remove --meson option for gen_xmlpool

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > Autotools now uses the same layout as meson, and scons doesn't care, so > remove the separate paths. Squash patches 3-6. It makes little sense to introduce the toggle only to remove it with later patch. Reviewed-by: Emil Velikov -Emil

Re: [Mesa-dev] [PATCH 02/14] meson: add support for generating translation mo files

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > Meson has handy a handy built-in module for handling gettext called > i18n, this module works a bit differently than our autotools build does, > namely it doesn't automatically generate translations instead it creates > 3 new top level targets

Re: [Mesa-dev] [PATCH 01/14] util/gen_xmlpool: use argparse for argument handling

On Fri, 26 Oct 2018 at 18:25, Dylan Baker wrote: > > This is a little cleaner than just looking at sys.argv, but it's also > going to allow us to handle the differences in the way meson and > autotools handle translations more cleanly. > > Reviewed-by: Eric Engestrom > --- >

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

On Wed, 2018-10-31 at 17:22 +, Emil Velikov wrote: > On Wed, 31 Oct 2018 at 16:24, Michel Dänzer wrote: > > On 2018-10-31 5:19 p.m., Jan Vesely wrote: > > > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > > > > From: Emil Velikov > > > > > > > > The option has been long superseded

[Mesa-dev] [PATCH] android: gallium/auxiliary: add include to get u_debug.h header

To avoid build error in u_debug_stack_android.cpp due to now missing u_debug.h header: external/mesa/src/gallium/auxiliary/util/u_debug_stack_android.cpp:26:10: fatal error: 'u_debug.h' file not found #include "u_debug.h" ^ 1 error generated. Fixes: 37db383abb ("util: Move u_debug to

Re: [Mesa-dev] [PATCH v2 1/2] configure: allow building with python3

On Wed, 31 Oct 2018 at 16:18, Dylan Baker wrote: > > Quoting Emil Velikov (2018-10-31 04:22:41) > > From: Emil Velikov > > > > Pretty much all of the scripts are python2+3 compatible. > > Check and allow using python3, while adjusting the PYTHON2 refs. > > > > Note: > > - python3.4 is used as

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

On Wed, 31 Oct 2018 at 16:24, Michel Dänzer wrote: > > On 2018-10-31 5:19 p.m., Jan Vesely wrote: > > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > >> From: Emil Velikov > >> > >> The option has been long superseded with LLVM_CONFIG. > >> Distributions have been using it for a couple

Re: [Mesa-dev] [PATCH mesa] meson: hide warnings from external project `gtest`

gtest doesn't generate any warnings, but this seems fine, Reviewed-by: Dylan Baker Quoting Eric Engestrom (2018-10-31 09:43:03) > gtest is an external project that is copied in this tree for technical > reasons, but isn't maintained by us, so its warnings are irrelevant. > > Cc: Emil Velikov >

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On Wed, Oct 31, 2018 at 12:37 PM Erik Faye-Lund wrote: > > On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: > > I had to do a double (or triple) take on this logic as well. Part of > > the subtlety is that the fallback only applies for ES when there's a > > match but no exact match. Probably

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

On Wed, 31 Oct 2018 at 15:57, Jan Vesely wrote: > > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > > From: Emil Velikov > > > > LLVM versions earlier than 5.0.1 are no longer supported. > > I'd prefer to keep llvm-3.9, since it's the last version that supports > images for r600, but

Re: [Mesa-dev] [PATCH mesa 2/3] REVIEWERS: add Emil as EGL reviewer

On Wed, 31 Oct 2018 at 14:54, Eric Engestrom wrote: > > Cc: Emil Velikov > Signed-off-by: Eric Engestrom Acked-by: Emil Velikov -Emil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH mesa] meson: hide warnings from external project `gtest`

gtest is an external project that is copied in this tree for technical reasons, but isn't maintained by us, so its warnings are irrelevant. Cc: Emil Velikov Signed-off-by: Eric Engestrom --- src/gtest/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gtest/meson.build

Re: [Mesa-dev] [PATCH 09/12] gallivm: remove workarounds for pre LLVM 5.0

Am 31.10.18 um 14:30 schrieb Emil Velikov: > From: Emil Velikov > > With LLVM 5.0.1 the minimum required version, we can drop all the dead > code. > > Cc: Roland Scheidegger > Cc: Jose Fonseca > Signed-off-by: Emil Velikov > --- > Gents this is a quick and dirty grep job. A couple of places

[Mesa-dev] [Bug 108160] GLSL version >=1.30 built-in functions present in version <1.30

https://bugs.freedesktop.org/show_bug.cgi?id=108160 --- Comment #1 from vadym --- Patch: https://patchwork.freedesktop.org/patch/259519/ -- You are receiving this mail because: You are the assignee for the bug.___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On Wed, 2018-10-31 at 12:01 -0400, Ilia Mirkin wrote: > I had to do a double (or triple) take on this logic as well. Part of > the subtlety is that the fallback only applies for ES when there's a > match but no exact match. Probably good to mention this. Yeah, that makes sense. I thought I

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

On 2018-10-31 5:19 p.m., Jan Vesely wrote: > On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: >> From: Emil Velikov >> >> The option has been long superseded with LLVM_CONFIG. >> Distributions have been using it for a couple of years now. > > I've been using it in my configure setup. Same

Re: [Mesa-dev] [PATCH 08/12] configure.ac: deprecate --with-llvm-prefix

On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > From: Emil Velikov > > The option has been long superseded with LLVM_CONFIG. > Distributions have been using it for a couple of years now. I've been using it in my configure setup. This might be a stupid question; is the LLVM_CONFIG env

Re: [Mesa-dev] [PATCH v2 1/2] configure: allow building with python3

Quoting Emil Velikov (2018-10-31 04:22:41) > From: Emil Velikov > > Pretty much all of the scripts are python2+3 compatible. > Check and allow using python3, while adjusting the PYTHON2 refs. > > Note: > - python3.4 is used as it's the earliest supported version > - python2 chosen prior to

Re: [Mesa-dev] Meson windows v5 (10/19/2018) review

Quoting Liviu Prodea (2018-10-31 01:50:25) > --default_library=static indeed solves the zlib and expat dependency so I > tweaked my build script to do just that, As for the LLVM linking problems I > think I finally understand what's going on. llvm-wrap option always links LLVM > dynamically and

Re: [Mesa-dev] [PATCH v2 00/13] Engine parameter for instructions

When we debug media or 3d+media workloads, we'd like to be able to see what is in the aub dumps for those workloads. At the moment the decoder can't distinguish instructions which share the same opcode between the render and video pipe, and thus aubinator outputs garbage on media instructions.

[Mesa-dev] [PATCH] glsl: Correct several built-in functions availability

In GLSL versions 1.00 ES, 1.10 and 1.20, Mesa includes some built-in functions which shouldn't be present in that version, namely: genIType abs(genIType x) genIType sign(genIType x) genIType min(genIType x, genIType y) genIType min(genIType x, int y) genIType max(genIType x,

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

I had to do a double (or triple) take on this logic as well. Part of the subtlety is that the fallback only applies for ES when there's a match but no exact match. Probably good to mention this. On Wed, Oct 31, 2018 at 11:13 AM Erik Faye-Lund wrote: > > On Wed, 2018-10-31 at 15:46 +0200, Tapani

Re: [Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

On Wed, 2018-10-31 at 13:30 +, Emil Velikov wrote: > From: Emil Velikov > > LLVM versions earlier than 5.0.1 are no longer supported. I'd prefer to keep llvm-3.9, since it's the last version that supports images for r600, but I'd leave the final decision to Francisco. Jan > > Cc: Jan

[Mesa-dev] [Bug 106980] Basemark GPU vulkan benchmark hangs on GFX9

https://bugs.freedesktop.org/show_bug.cgi?id=106980 Samuel Pitoiset changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On Wed, 2018-10-31 at 15:46 +0200, Tapani Pälli wrote: > > On 10/30/18 7:11 PM, Erik Faye-Lund wrote: > > In GLES, we currently either need an exact match with a local > > function, > > or an exact match with a builtin. > > > > However, if we add support for implicit conversions for GLES > >

[Mesa-dev] [PATCH mesa 2/3] REVIEWERS: add Emil as EGL reviewer

Cc: Emil Velikov Signed-off-by: Eric Engestrom --- REVIEWERS | 1 + 1 file changed, 1 insertion(+) diff --git a/REVIEWERS b/REVIEWERS index a1b63b55503c2ff870f2..4751c36d9db73453fed0 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -64,6 +64,7 @@ F: src/loader/ EGL R: Eric Engestrom +R: Emil

[Mesa-dev] [PATCH mesa 3/3] REVIEWERS: add Vulkan reviewer group

Signed-off-by: Eric Engestrom --- REVIEWERS | 5 + 1 file changed, 5 insertions(+) diff --git a/REVIEWERS b/REVIEWERS index 4751c36d9db73453fed0..9024510d303fc647399b 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -134,3 +134,8 @@ F: src/gallium/drivers/freedreno/ GLX R: Adam Jackson F:

[Mesa-dev] [PATCH mesa 1/3] REVIEWERS: add include path for EGL

Signed-off-by: Eric Engestrom --- REVIEWERS | 1 + 1 file changed, 1 insertion(+) diff --git a/REVIEWERS b/REVIEWERS index e61f4ba96934fea97837..a1b63b55503c2ff870f2 100644 --- a/REVIEWERS +++ b/REVIEWERS @@ -65,6 +65,7 @@ F: src/loader/ EGL R: Eric Engestrom F: src/egl/ +F: include/EGL/

[Mesa-dev] [Bug 108105] [DXVK] Dauntless Helmets rendering incorrectly on Vega, works in AMDVLK

https://bugs.freedesktop.org/show_bug.cgi?id=108105 Samuel Pitoiset changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH v2 00/13] Engine parameter for instructions

On 31/10/2018 14:20, Jason Ekstrand wrote: Toni, I'm a bit curious where you're going with this.  I started on a similar project a couple of years ago: https://gitlab.freedesktop.org/jekstrand/mesa/commits/wip/genxml-engines Mine took a different (not necessarily better) approach of

[Mesa-dev] [Bug 108611] [radv] [regression, bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda

https://bugs.freedesktop.org/show_bug.cgi?id=108611 Michel Dänzer changed: What|Removed |Added CC||nhaeh...@gmail.com -- You are

Re: [Mesa-dev] [PATCH 2/2] nir: allow propagation of if evaluation to all alu instructions

On Tue, Oct 30, 2018 at 9:17 PM Timothy Arceri wrote: > With the simplifications to this pass in a3b4cb34589e2f1a68 we > can allow any alu instruction to be processed. For one this can > potentially help with bcsels. > Do we want to? I believe that this patch is correct and I agree that we now

Re: [Mesa-dev] [PATCH 1/2] nir: fix if condition propagation for alu use

Reviewed-by: Jason Ekstrand Thanks for figuring this out. This probably explains some of the hurt I was seeing with my series as well. --Jason On Tue, Oct 30, 2018 at 9:17 PM Timothy Arceri wrote: > From: Timothy Arceri > > We need to update the cursor before we check if the alu use is >

Re: [Mesa-dev] [PATCH] glspirv: no need to force entrypoint name to "main"

Sorry I missed that one. Reviewed-by: Jason Ekstrand On Wed, Oct 31, 2018 at 5:57 AM Alejandro Piñeiro wrote: > Since commit "intel/compiler: Stop assuming the entrypoint is called > "main"" there is no need to force the entrypoint name to be "main". > --- > src/mesa/main/glspirv.c | 1 - >

Re: [Mesa-dev] [PATCH v2 00/13] Engine parameter for instructions

Toni, I'm a bit curious where you're going with this. I started on a similar project a couple of years ago: https://gitlab.freedesktop.org/jekstrand/mesa/commits/wip/genxml-engines Mine took a different (not necessarily better) approach of surrounding the instructions in an tag. I'm not sure

[Mesa-dev] [Bug 104302] Wolfenstein 2 (2017) under wine graphical artifacting on RADV

https://bugs.freedesktop.org/show_bug.cgi?id=104302 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH RFC] egl: Add a 565 pbuffer-only EGL config under X11.

On Tue, 2018-10-30 at 16:38 -0700, Eric Anholt wrote: > Eric Anholt writes: > > > The CTS requires a 565-no-depth-no-stencil config for ES 3.0, but at depth > > 24 of X11 we wouldn't do so. We can satisfy that bad requirement using a > > pbuffer-only visual with whatever other buffers the

[Mesa-dev] [PATCH v3] intel/decoder: tools: gen_engine to drm_i915_gem_engine_class

Removed the gen_engine enum and changed the involved functions to use the drm_i915_gem_engine_class enum from UAPI instead. v3: Wrong engine was being used for blocks in video ring --- src/intel/tools/aub_read.c | 22 +++--- src/intel/tools/aub_read.h | 11 +++

[Mesa-dev] [Bug 108611] [radv] [regression, bisected]: LLVM 8.0 breaks lighting in Mass Effect Andromeda

https://bugs.freedesktop.org/show_bug.cgi?id=108611 Samuel Pitoiset changed: What|Removed |Added Summary|radv: LLVM 8.0 breaks |[radv] |lighting

Re: [Mesa-dev] [PATCH 0/5] add support for EXT_shader_implicit_conversions

LGTM, series is: Reviewed-by: Tapani Pälli On 10/30/18 7:11 PM, Erik Faye-Lund wrote: EXT_shader_implicit_conversions is a useful extension that adds implicit conversions to OpenGL ES 3.1. Since it's tested excensively in dEQP, and Mesa already has support for implicit conversions, it seems

Re: [Mesa-dev] [PATCH v2 01/13] intel/decoder: tools: gen_engine to drm_i915_gem_engine_class

Seems I screwed up with the engine for video and accidentally left *_RENDER as the engine. Will follow up with v3. On Wed, Oct 31, 2018 at 03:12:48PM +0200, Toni Lönnberg wrote: > Removed the gen_engine enum and changed the involved functions to use the > drm_i915_gem_engine_class enum from UAPI

Re: [Mesa-dev] [PATCH 3/5] glsl: fall back to inexact function-match

On 10/30/18 7:11 PM, Erik Faye-Lund wrote: In GLES, we currently either need an exact match with a local function, or an exact match with a builtin. However, if we add support for implicit conversions for GLES shaders, we also need to fall back to a non-exact match in the case where there

[Mesa-dev] [PATCH 11/12] swr: remove pre LLVM 5.0 codepaths

From: Emil Velikov LLVM versions earlier than 5.0.1 are no longer supported. Cc: Alok Hota Cc: Bruce Cherniak Cc: George Kyriazis Signed-off-by: Emil Velikov --- Hi all, I know the team does some back and forth import of the codebase elsewhere. So if this patch causes grief let me know and

[Mesa-dev] [PATCH 12/12] clover: remove pre LLVM 5.0 codepaths

From: Emil Velikov LLVM versions earlier than 5.0.1 are no longer supported. Cc: Jan Vesely Cc: Francisco Jerez Cc: Aaron Watry Signed-off-by: Emil Velikov --- I guess some of compat.hpp can be cleaned-up, but I'd suggest sticking with that as a follow-up. ---

[Mesa-dev] [PATCH 07/12] configure.ac: deprecate --with-clang-libdir

From: Emil Velikov The options allows you to specify custom location of clang and friends. That may have been required for old and buggy llvm-config, which could produce the wrong path. This isn't the case with LLVM 5.0.1 at least, so we no longer need this hack. Signed-off-by: Emil Velikov

  1   2   >