Re: [Mesa-dev] XSync/XReply take too much CPU

Hi; On 11/23/18 9:06 AM, yanhua wrote: Hi, Tapani:   Recently I come into a problem. I have a opengl program, if the program run, it can take up almost one core, and the Xorg takes almost one core too.   I found this program continuously recvmsg from the Xorg. I'm sure the CPU is ta

[Mesa-dev] XSync/XReply take too much CPU

Hi, Tapani: Recently I come into a problem. I have a opengl program, if the program run, it can take up almost one core, and the Xorg takes almost one core too. I found this program continuously recvmsg from the Xorg. I'm sure the CPU is takeing by too much sendmsg/recvmsg. Followi

Re: [Mesa-dev] [PATCH mesa] mesa: use binary search for MESA_EXTENSION_OVERRIDE

Reviewed-by: Tapani Pälli On 11/22/18 8:18 PM, Eric Engestrom wrote: Not a hot path obviously, but the table still has 425 extensions, which you can go through in just 9 steps with a binary search. The table is already sorted, as required by other parts of the code and enforced by mesa's `main

Re: [Mesa-dev] [PATCH v2 00/13] query validation fixes

Ping, this series has not landed yet, planning to land it soon? On 11/9/18 7:58 AM, Tapani Pälli wrote: Thanks, _mesa_has makes things a lot cleaner and simpler to manage; Reviewed-by: Tapani Pälli On 11/8/18 2:42 PM, Erik Faye-Lund wrote: Here's v2 of this series. Changes are as follows: -

Re: [Mesa-dev] [PATCH] anv: allow exporting an imported SYNC_FD semaphore type

Hi; On 11/22/18 6:20 PM, Emil Velikov wrote: On 2018/11/22, Tapani Pälli wrote: Fixes issues with following SkQP tests: unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs Signed-off-by: Tapani Pälli --- src/intel/vulkan/anv_queue.c | 3

[Mesa-dev] [PATCH] draw: fix infinite loop in line stippling

From: Roland Scheidegger The calculated length of a line may be infinite, if the coords we get are bogus. This leads to an infinite loop in line stippling. To prevent this test for this explicitly (although technically on at least x86 sse it would actually work without the explicit test, as long

Re: [Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

On 23/11/18 11:49 am, Timothy Arceri wrote: shader-db results radeonsi (VEGA): Totals from affected shaders: SGPRS: 7272 -> 7488 (2.97 %) VGPRS: 4168 -> 4160 (-0.19 %) Spilled SGPRs: 328 -> 327 (-0.30 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0

[Mesa-dev] [PATCH] nir: propagate known constant values into the if-then branch

shader-db results radeonsi (VEGA): Totals from affected shaders: SGPRS: 7272 -> 7488 (2.97 %) VGPRS: 4168 -> 4160 (-0.19 %) Spilled SGPRs: 328 -> 327 (-0.30 %) Spilled VGPRs: 0 -> 0 (0.00 %) Private memory VGPRs: 0 -> 0 (0.00 %) Scratch size: 0 -> 0 (0.00 %) dwords per thread Code Size: 268212 ->

Re: [Mesa-dev] [PATCH 1/2] radv: add a predicate for reflecting DCC decompression state

So to complicate things, drawing with DCC enabled also compresses things again. (maybe set it on framebuffer CB emit time?) On Thu, Nov 22, 2018 at 1:47 PM Samuel Pitoiset wrote: > > It's somehow similar to the FCE predicate. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_bu

[Mesa-dev] [Bug 108841] [RADV] SPIRV's control flow attributes do not propagate to LLVM

https://bugs.freedesktop.org/show_bug.cgi?id=108841 Bug ID: 108841 Summary: [RADV] SPIRV's control flow attributes do not propagate to LLVM Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [Mesa-dev] [PATCH] meson: Bump version to 0.46 for python module

On Wed, Nov 21, 2018 at 10:48 AM Matt Turner wrote: > > Thanks Arfrever and Dylan. > > Acked-by: Matt Turner Hmm, actually this doesn't seem to work for me. With it applied I get: src/mesa/drivers/dri/meson.build:59:8: ERROR: Python object does not have method path. which comes from: meson

Re: [Mesa-dev] [RFC 2/5] nir: Add unordered comparisons and ordered fne

On November 22, 2018 13:48:48 Bas Nieuwenhuizen wrote: On Thu, Nov 22, 2018 at 7:47 PM Jason Ekstrand wrote: --- src/compiler/nir/nir.h| 8 src/compiler/nir/nir_loop_analyze.c | 12 src/compiler/nir/nir_opcodes.py | 4 src/compiler/nir/nir_

Re: [Mesa-dev] [RFC 2/5] nir: Add unordered comparisons and ordered fne

On Thu, Nov 22, 2018 at 7:47 PM Jason Ekstrand wrote: > > --- > src/compiler/nir/nir.h| 8 > src/compiler/nir/nir_loop_analyze.c | 12 > src/compiler/nir/nir_opcodes.py | 4 > src/compiler/nir/nir_opt_algebraic.py | 5 + > 4 files changed,

Re: [Mesa-dev] [PATCH 1/2] i965: Explicitely handle swizzles for MESA_FORMAT_R_SRGB8

Hi Gert, On 2018/11/22, Gert Wollny wrote: > The format is emulated by using ISL_FORMAT_L8_SRGB, therefore we need to > force swizzles for the GBA channels. However, doing this only based on the > data type GL_RED breaks other formats, therefore, test specifically for the > format. > > Fixes: 536

[Mesa-dev] [RFC 4/5] intel/compiler: Implement unordered comparisons

The vec4 path has only been compile-tested as there's no easy way to generate a vec4 shader with an unordered equality. --- src/intel/compiler/brw_compiler.c | 3 +++ src/intel/compiler/brw_fs_nir.cpp | 20 +--- src/intel/compiler/brw_vec4_nir.cpp | 21 + 3

[Mesa-dev] [RFC 1/5] nir: Rename nir_op_fne to nir_op_fneu

This way, it's explicit in the opcode name that it's an unordered comparison. --- src/amd/common/ac_nir_to_llvm.c | 2 +- src/compiler/glsl/glsl_to_nir.cpp | 4 +- src/compiler/nir/nir.h| 2 +- src/compiler/nir/nir_builder.h| 2

[Mesa-dev] [RFC 5/5] spirv: Emit the correct ordered/unordered NIR opcodes directly

--- src/compiler/spirv/vtn_alu.c | 61 1 file changed, 6 insertions(+), 55 deletions(-) diff --git a/src/compiler/spirv/vtn_alu.c b/src/compiler/spirv/vtn_alu.c index cff8c76b2a3..0dff64e66f0 100644 --- a/src/compiler/spirv/vtn_alu.c +++ b/src/compiler/spirv/v

[Mesa-dev] [RFC 2/5] nir: Add unordered comparisons and ordered fne

--- src/compiler/nir/nir.h| 8 src/compiler/nir/nir_loop_analyze.c | 12 src/compiler/nir/nir_opcodes.py | 4 src/compiler/nir/nir_opt_algebraic.py | 5 + 4 files changed, 25 insertions(+), 4 deletions(-) diff --git a/src/compiler/nir/nir.

[Mesa-dev] [RFC 3/5] amd/nir: Implement the new ordered/unordered comparisons

They map directly to LLVM opcodes so it's really easy. --- src/amd/common/ac_nir_to_llvm.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index c82c2ab548d..97a553505bc 100644 --- a/src/amd/com

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] mesa 18.3.0-rc4

Also this one is probably a blocker: https://patchwork.freedesktop.org/patch/262760/ Without it, the computer may run out of memory depending on the window system. Marek On Thu, Nov 22, 2018 at 8:38 AM Emil Velikov wrote: > The fourth release candidate for Mesa 18.3.0 is now available. > > As

Re: [Mesa-dev] [PATCH 12/22] nir: add type alignment support to lower_io

On Wed, Nov 21, 2018 at 4:53 PM Jason Ekstrand wrote: > > On Tue, Nov 13, 2018 at 9:48 AM Karol Herbst wrote: >> >> From: Rob Clark >> >> For cl we can have structs with 8/16/32/64 bit scalar types (as well as, >> ofc, arrays/structs/etc), which are padded according to 'C' rules. So >> for lowe

[Mesa-dev] [Bug 108829] [meson] libglapi exports internal API

https://bugs.freedesktop.org/show_bug.cgi?id=108829 Eric Engestrom changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [PATCH mesa] mesa: use binary search for MESA_EXTENSION_OVERRIDE

Not a hot path obviously, but the table still has 425 extensions, which you can go through in just 9 steps with a binary search. The table is already sorted, as required by other parts of the code and enforced by mesa's `main-test`. Signed-off-by: Eric Engestrom --- src/mesa/main/extensions.c |

[Mesa-dev] [PATCH mesa] meson: remove unused include_directories(vulkan)

The correct include path is "vulkan/…". Signed-off-by: Eric Engestrom --- include/meson.build | 1 - src/vulkan/util/meson.build | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/meson.build b/include/meson.build index 081c1bc00088c956d47e..389fde9fd9a5193f259

Re: [Mesa-dev] [PATCH 1/3] radv: implement some SW counters

Oops. I was not planning to send this one. Please ignore. On 11/22/18 7:10 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 23 +++ src/amd/vulkan/radv_device.c | 4 ++ src/amd/vulkan/radv_meta.c| 2 + src/amd

[Mesa-dev] [PATCH 3/3] radv: drop few useless state changes when doing color/depth decompressions

Viewport/scissor don't need to be updated for array textures. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_decompress.c | 47 +-- src/amd/vulkan/radv_meta_fast_clear.c | 55 +++ 2 files changed, 41 insertions(+), 61 deletions(-) diff --

[Mesa-dev] [PATCH 2/3] radv: remove unused pending_clears param in the transition path

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 7367e24fd28..1e7954434fe 100644 --- a/src/amd/vulkan/radv_cmd_buffer

[Mesa-dev] [PATCH 1/3] radv: implement some SW counters

Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 23 +++ src/amd/vulkan/radv_device.c | 4 ++ src/amd/vulkan/radv_meta.c| 2 + src/amd/vulkan/radv_meta_buffer.c | 6 ++ src/amd/vulkan/radv_meta_clear.c | 11 src/amd/vulkan/radv_m

[Mesa-dev] [PATCH 1/2] i965: Explicitely handle swizzles for MESA_FORMAT_R_SRGB8

The format is emulated by using ISL_FORMAT_L8_SRGB, therefore we need to force swizzles for the GBA channels. However, doing this only based on the data type GL_RED breaks other formats, therefore, test specifically for the format. Fixes: 5363869d4971780401b21bb75083ef2518c12be 965: Force zero s

[Mesa-dev] [PATCH 2/2] i965: Set the FBO error state INCOMPLETE_ATTACHMENT only for SRGB_R8

Originally the driver reported GL_FRAMEBUFFER_UNSUPPORTED in all cases, adding more specific error messages was not correct and broke many tests. Mostly revert this and only report GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT for MESA_FORMAT_R_SRGB8. Fixes: ebcde3454552adc6d3fea8af2207aafaba857796 i965:

[Mesa-dev] [PATCH 0/6] glGetTexImage fixes

I was recently investigating a gl-error that appears some times while using virgl, where I got a pretty nonsensical GL-error: Mesa: User error: GL_INVALID_VALUE in glGetnTexImageARB(depth = 0) Now, the reason why this is nonsensical, is that glGetnTexImage doesn't have a 'depth'-argument, this v

[Mesa-dev] [PATCH 3/6] mesa/main: factor out tex-image error-checking

This will be useful when we split error-checking for getteximage and gettexsubimage later. Signed-off-by: Erik Faye-Lund --- src/mesa/main/texgetimage.c | 110 +--- 1 file changed, 64 insertions(+), 46 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/m

[Mesa-dev] [PATCH 2/6] mesa/main: remove bogus error for zero-sized images

The explanation quotes the spec on the following wording to justify the error: "An INVALID_VALUE error is generated if xoffset + width is greater than the texture’s width, yoffset + height is greater than the texture’s height, or zoffset + depth is greater than the texture’s depth." However, t

[Mesa-dev] [PATCH 1/6] mesa/main: remove ARB suffix from glGetnTexImage

This function has been core since OpenGL 4.3, so naming the implementation and reporting erros using an ARB-suffix can be confusing. Signed-off-by: Erik Faye-Lund --- src/mapi/glapi/gen/ARB_robustness.xml | 2 +- src/mapi/glapi/gen/gl_API.xml | 9 + src/mesa/main/texgetimage.c

[Mesa-dev] [PATCH 4/6] mesa/main: factor out common error-checking

This error checking is the same for teximage and texsubimage getters, so let's factor it out to its own function. This will be useful when getteximage and gettexsubimage gets their own error checking routines a bit later. --- src/mesa/main/texgetimage.c | 46 +++--

[Mesa-dev] [PATCH 6/6] mesa/main: fix incorrect detph-error

If glGetTexImage or glGetnTexImage is called with a level that doesn't exist, we get an error message on this form: Mesa: User error: GL_INVALID_VALUE in glGetTexImage(depth = 0) This is clearly nonsensical, because these APIs don't even have a depth-parameter. The reason is that get_texture_imag

[Mesa-dev] [PATCH 5/6] mesa/main: check cube-completeness in common code

This check is the only part of dimensions_error_check that isn't about error-checking the offset and size arguments of glGet[Compressed]TextureSubImage(), so it doesn't really belong in here. This doesn't make a difference right now, apart for changing the presedence of this error. But it will mak

Re: [Mesa-dev] [PATCH 2/5] anv/pipeline: Hash shader modules and spec constants separately

On 13/10/2018 01:08, Jason Ekstrand wrote: The stuff hashed by anv_pipeline_hash_shader is exactly the inputs to anv_shader_compile_to_nir so it can be used for NIR caching. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline.c | 54 - 1 file

Re: [Mesa-dev] [PATCH] anv: allow exporting an imported SYNC_FD semaphore type

On 2018/11/22, Tapani Pälli wrote: > Fixes issues with following SkQP tests: > >unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs >unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs > > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/anv_queue.c | 3 ++- > 1 file changed, 2 insertions(

Re: [Mesa-dev] [PATCH 5/5] anv/pipeline: Cache the pre-lowered NIR

On 13/10/2018 01:08, Jason Ekstrand wrote: This adds a second level of caching for the pre-lowered NIR that's only based off of the shader module, entrypoint and specialization constants. This is enough for spirv_to_nir as well as our first round of lowering and optimization. Caching at this lev

Re: [Mesa-dev] [PATCH 4/5] anv/pipeline_cache: Add support for caching NIR

On 13/10/2018 01:08, Jason Ekstrand wrote: Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline_cache.c | 100 ++ src/intel/vulkan/anv_private.h| 18 + 2 files changed, 118 insertions(+) diff --git a/src/intel/vulkan/anv_pipeline_cache.c b

Re: [Mesa-dev] [PATCH 1/5] anv/pipeline: Move wpos and input attachment lowering to lower_nir

On 13/10/2018 01:08, Jason Ekstrand wrote: This lets us make anv_pipeline_compile_to_nir take a device instead of a pipeline. Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/src/i

Re: [Mesa-dev] [PATCH 3/5] compiler/types: Serialize/deserialize subpass input types correctly

On 13/10/2018 01:08, Jason Ekstrand wrote: They have glsl_sampler_dim enum values of 8 and 9 which don't work when you & them with 0x7. Fortunately, we have plenty of bits. I think this needs a Cc stable right? Reviewed-by: Lionel Landwerlin --- src/compiler/glsl_types.cpp | 4 ++--

Re: [Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

On 2018/11/22, Eric Engestrom wrote: > On Thursday, 2018-11-22 13:15:05 +, Eric Engestrom wrote: > > More or less any of this issue pointed out by the compiler is > > a coding error. Make sure we flag it and bail loudly. > > > > v2: - apply the change to autotools and scons as well (Emil) > >

Re: [Mesa-dev] [PATCH] anv: allow exporting an imported SYNC_FD semaphore type

Should work. Reviewed-by: Jason Ekstrand On Thu, Nov 22, 2018 at 1:41 AM Tapani Pälli wrote: > Fixes issues with following SkQP tests: > >unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs >unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs > > Signed-off-by: Tapani Pälli > --- > src/inte

Re: [Mesa-dev] [PATCH 1/2] anv: Put robust buffer access in the pipeline hash

Thanks! On Thu, Nov 22, 2018 at 1:06 AM Iago Toral wrote: > For both patches: > > Reviewed-by: Iago Toral Quiroga > > On Wed, 2018-11-21 at 17:20 -0600, Jason Ekstrand wrote: > > It affects apply_pipeline_layout. Shaders compiled with the wrong > > value > > will work but they may not be robus

Re: [Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

On Thursday, 2018-11-22 13:15:05 +, Eric Engestrom wrote: > More or less any of this issue pointed out by the compiler is > a coding error. Make sure we flag it and bail loudly. > > v2: - apply the change to autotools and scons as well (Emil) > - C++ doesn't need this, it's already an erro

[Mesa-dev] [ANNOUNCE] mesa 18.3.0-rc4

The fourth release candidate for Mesa 18.3.0 is now available. As per the issue tracker [1] we have one outstanding bug blocking the release. [1] https://bugs.freedesktop.org/show_bug.cgi?id=108530 Andrii Simiklit (1): i965/batch: avoid reverting batch buffer if saved state is an empty Em

[Mesa-dev] [PATCH mesa] glapi: add missing visibility args

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108829 Cc: Emil Velikov Fixes: 3218056e0eb375eeda470 "meson: Build i965 and dri stack" Signed-off-by: Eric Engestrom --- src/mapi/shared-glapi/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mapi/shared-gl

[Mesa-dev] [Bug 32211] [GLSL] lower_jumps with continue-statements in for-loops prevents loop unrolling

https://bugs.freedesktop.org/show_bug.cgi?id=32211 --- Comment #15 from Danylo --- Created attachment 142567 --> https://bugs.freedesktop.org/attachment.cgi?id=142567&action=edit Removing unnecessary continue Optimization in question. -- You are receiving this mail because: You are the assig

[Mesa-dev] [Bug 32211] [GLSL] lower_jumps with continue-statements in for-loops prevents loop unrolling

https://bugs.freedesktop.org/show_bug.cgi?id=32211 --- Comment #14 from Danylo --- (In reply to Timothy Arceri from comment #13) > > None of that should matter. If the continue if removed there should be > nothing stopping the loop from unrolling, and if the loop is unrolled the > both ifs shoul

[Mesa-dev] [PATCH mesa] build: make passing an incorrect pointer type a hard error

More or less any of this issue pointed out by the compiler is a coding error. Make sure we flag it and bail loudly. v2: - apply the change to autotools and scons as well (Emil) - C++ doesn't need this, it's already an error and the flag doesn't exist (Gert) Signed-off-by: Eric Engestrom

Re: [Mesa-dev] [PATCH] build: enable -Werror=incompatible-pointer-types

On Wednesday, 2018-11-21 13:14:48 +, Emil Velikov wrote: > From: Emil Velikov > > More or less any issue pointed out by the compiler is an error. Make > sure we flag and bail loudly. > > Cc: Eric Engestrom > Signed-off-by: Emil Velikov > --- > Eric, feel free to squash this with your patch

Re: [Mesa-dev] [PATCH] build: enable -Werror=incompatible-pointer-types

On Thursday, 2018-11-22 12:07:03 +, Emil Velikov wrote: > On 2018/11/21, Gert Wollny wrote: > > Am Mittwoch, den 21.11.2018, 13:14 + schrieb Emil Velikov: > > > > +AX_CHECK_COMPILE_FLAG([-Werror=incompatible-pointer- > > > types],[CFXXLAGS="$CXXFLAGS -Werror=incompatible-pointer-types"

[Mesa-dev] [PATCH 2/2] radv: allow to skip DCC decompressions with the new predicate

Feral games aren't affected because they don't decompress DCC. F1 2018 has one DCC decompression per frame, but I don't see any performance improvements. This new predicate will be probably more useful for DCC/MSAA. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_meta_fast_clear.c | 19 ++

[Mesa-dev] [PATCH 1/2] radv: add a predicate for reflecting DCC decompression state

It's somehow similar to the FCE predicate. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 23 +++ src/amd/vulkan/radv_image.c | 3 ++- src/amd/vulkan/radv_meta_clear.c | 3 +++ src/amd/vulkan/radv_meta_fast_clear.c | 7 +++ sr

Re: [Mesa-dev] [PATCH 1/2] virgl: avoid large inline transfers

I think Erik already pointed out the little problems with this series and "virgl: quadruple command buffer size". I've tested the impact on performance of these tree patches and the results look great: Unigine Valley went from ~9 fps to 20 (Host 50) and Unigine Heaven (no tesselation) from 12 fps

Re: [Mesa-dev] [PATCH 29/30] mesa/main: do not require float-texture filtering for es3

Hi Erik, The series looks very reasonable and I could not spot loosing any negating ! in the query logic. Even if I have not been able time wise to double checked every move when which texture format got introduced in which ES GL version. So, what can I tell now? Is that already a reviewed by?

Re: [Mesa-dev] [PATCH] st/xvmc: Add X11 include path.

On 2018/11/21, Vinson Lee wrote: > This patch fixes this build error. > > CC tests/xvmc_bench.o > In file included from tests/xvmc_bench.c:35: > tests/testlib.h:38:10: fatal error: 'X11/Xlib.h' file not found > ^~~~ > > Signed-off-by: Vinson Lee Cc: mesa-sta...@lists.fr

Re: [Mesa-dev] [PATCH] build: enable -Werror=incompatible-pointer-types

On 2018/11/21, Gert Wollny wrote: > Am Mittwoch, den 21.11.2018, 13:14 + schrieb Emil Velikov: > > +AX_CHECK_COMPILE_FLAG([-Werror=incompatible-pointer- > > types],[CFXXLAGS="$CXXFLAGS -Werror=incompatible-pointer-types"]) > For C++ this shoudn't be needed, because there this is already an

Re: [Mesa-dev] [PATCH 30/30] mesa/st: require linear interpolation for ARB_texture_float

Hi, On Monday, 19 November 2018 20:17:38 CET Roland Scheidegger wrote: > FWIW this looks like a rather similar incident to me what happened when mesa > began to verify the max vertex stride (which needs to be 2048 with GL 4.4 > whereas r600 can only do 2047) where I argued it's a much better ide

[Mesa-dev] [Bug 108829] [meson] libglapi exports internal API

https://bugs.freedesktop.org/show_bug.cgi?id=108829 Emil Velikov changed: What|Removed |Added CC||baker.dyla...@gmail.com,

[Mesa-dev] [Bug 108829] [meson] libglapi exports internal API

https://bugs.freedesktop.org/show_bug.cgi?id=108829 Bug ID: 108829 Summary: [meson] libglapi exports internal API Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

[Mesa-dev] [PATCH v2] winsys/amdgpu: explicitly declare whether buffer_map is permanent or not

From: Nicolai Hähnle Introduce a new driver-private transfer flag RADEON_TRANSFER_TEMPORARY that specifies whether the caller will use buffer_unmap or not. The default behavior is set to permanent maps, because that's what drivers do for Gallium buffer maps. This should eliminate the need for ha

Re: [Mesa-dev] [PATCH 2/2] winsys/amdgpu: explicitly declare whether buffer_map is permanent or not

On 21.11.18 21:27, Marek Olšák wrote: On Wed, Nov 21, 2018 at 12:57 PM Nicolai Hähnle > wrote: From: Nicolai Hähnle mailto:nicolai.haeh...@amd.com>> Introduce a new driver-private transfer flag RADEON_TRANSFER_TEMPORARY that specifies whether the caller wi

Re: [Mesa-dev] [PATCH 1.5/2] ac/surface/gfx9: let addrlib choose the preferred swizzle kind

Thanks. Any comments on the addrlib change itself? Cheers, Nicolai On 21.11.18 21:32, Marek Olšák wrote: > See what Gustaw said. Other than that: > > Reviewed-by: Marek Olšák mailto:marek.ol...@amd.com>> > > Marek > > On Wed, Nov 21, 2018 at 10:21 AM Nicolai Hähnle

Re: [Mesa-dev] [PATCH 2/2] virgl: don't mark buffers as unclean after a write

On Wed, 2018-11-21 at 20:08 -0800, Gurchetan Singh wrote: > We can mark the buffer unclean if it's ever bound as a TBO, > SSBO, ABO, or image. > > This improves > > dEQP- > GLES3.performance.buffer.data_upload.function_call.map_buffer_range.n > ew_specified_buffer.flag_write_full.stream_draw > >

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

Hi Nicolai, On Thu, Nov 22, 2018 at 6:19 PM Haehnle, Nicolai wrote: > > On 22.11.18 06:40, Tomasz Figa wrote: > > Hi Brian, Keith, > > > > +Some more Chromium folks for visibility. > > > > On Wed, Aug 22, 2018 at 4:21 PM Tomasz Figa wrote: > >> > >> Hi Michel, > >> > >> On Thu, Aug 16, 2018 at 6

Re: [Mesa-dev] [PATCH] llvmpipe: Always return some fence in flush

On 22.11.18 06:40, Tomasz Figa wrote: > Hi Brian, Keith, > > +Some more Chromium folks for visibility. > > On Wed, Aug 22, 2018 at 4:21 PM Tomasz Figa wrote: >> >> Hi Michel, >> >> On Thu, Aug 16, 2018 at 6:43 PM Michel Dänzer wrote: >>> >>> On 2018-08-16 11:34 AM, Tomasz Figa wrote: If th

Re: [Mesa-dev] [PATCH] virgl: quadruple command buffer size

On Wed, 2018-11-21 at 15:26 -0800, Gurchetan Singh wrote: > Tested running WebGL aquarium on Nvidia host (10,000 fishes) > > This moves us from 7 fps to 9 fps. After quadrupling, performance > gains diminish. > > Change-Id: Iba3a9929ba2d17cf5a38233b92391dd413b79bc2 What's this Change-Id thing?

Re: [Mesa-dev] [PATCH 1/2] vulkan: Update the XML and headers to 1.1.93

Patch series is, Reviewed-by: Samuel Iglesias Gonsálvez Sam On 19/11/2018 16:39, Jason Ekstrand wrote: > --- > include/vulkan/vulkan_core.h | 35 --- > src/vulkan/registry/vk.xml | 84 +--- > 2 files changed, 98 insertions(+), 21 deletions(-) > >

Re: [Mesa-dev] [PATCH] anv: allow exporting an imported SYNC_FD semaphore type

Reviewed-by: Samuel Iglesias Gonsálvez On 22/11/2018 08:41, Tapani Pälli wrote: > Fixes issues with following SkQP tests: > >unitTest_VulkanHardwareBuffer_Vulkan_EGL_Syncs >unitTest_VulkanHardwareBuffer_Vulkan_Vulkan_Syncs > > Signed-off-by: Tapani Pälli > --- > src/intel/vulkan/anv_q