[Mesa-dev] [PATCH] spirv: Emit switch conditions on-the-fly

2019-01-11 Thread Jason Ekstrand
Instead of emitting all of the conditions for the cases of a switch statement up-front, emit them on-the-fly as we emit the code for each case. The original justification for this was that we were going to have to build a default case anyway which would need them all. However, we can just trust

Re: [Mesa-dev] [PATCH 1/7] mesa: implement ARB/KHR_parallel_shader_compile

2019-01-11 Thread Marek Olšák
On Thu, Jan 3, 2019 at 2:40 PM Ian Romanick wrote: > On 11/28/18 6:59 PM, Marek Olšák wrote: > > From: Marek Olšák > > > > Tested by piglit. > > It doesn't look like there are any piglit test > > > --- > > docs/features.txt | 2 +- > > docs/relnotes/19.0.0.html

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Karol Herbst
On Fri, Jan 11, 2019 at 8:50 PM Kenneth Graunke wrote: > > On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote: > > Jason Ekstrand writes: > > > > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke > > > wrote: > > > > > >> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand

Re: [Mesa-dev] [PATCH] st/dri: fix dri2_format_table for argb1555 and rgb565

2019-01-11 Thread Rob Clark
On Fri, Jan 11, 2019 at 6:19 PM Marek Olšák wrote: > > From: Marek Olšák > > The bug caused that rgb565 framebuffers used argb1555. > > Fixes: 433ca3127a3b94bfe9a513e7c7ce594e09e1359f > --- > src/gallium/state_trackers/dri/dri2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [Mesa-dev] [PATCH] st/dri: fix dri2_format_table for argb1555 and rgb565

2019-01-11 Thread Kristian Høgsberg
Reviewed-by: Kristian H. Kristensen On Fri, Jan 11, 2019 at 3:19 PM Marek Olšák wrote: > > From: Marek Olšák > > The bug caused that rgb565 framebuffers used argb1555. > > Fixes: 433ca3127a3b94bfe9a513e7c7ce594e09e1359f > --- > src/gallium/state_trackers/dri/dri2.c | 2 +- > 1 file changed, 1

Re: [Mesa-dev] [PATCH 2/6] radeonsi: fix rendering to tiny viewports where the viewport center is > 8K

2019-01-11 Thread Marek Olšák
On Fri, Jan 11, 2019 at 6:53 PM Marek Olšák wrote: > From: Marek Olšák > > This fixes an assertion failure with GLCTX when cts-runner is used. > (not a specific test) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108877 > Cc: 18.3 > --- > .../drivers/radeonsi/si_state_viewport.c

[Mesa-dev] [MR] Script to extract meson command line

2019-01-11 Thread Dylan Baker
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/106 Dylan signature.asc Description: signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 5/6] radeonsi: compile clear and copy buffer compute shaders on demand

2019-01-11 Thread Marek Olšák
From: Marek Olšák same as all other shaders --- src/gallium/drivers/radeonsi/si_compute_blit.c | 14 ++ src/gallium/drivers/radeonsi/si_pipe.c | 8 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_compute_blit.c

[Mesa-dev] [PATCH 3/6] radeonsi: use buffer_store_format_x & xy

2019-01-11 Thread Marek Olšák
From: Marek Olšák --- .../drivers/radeonsi/si_shader_tgsi_mem.c | 25 +-- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c b/src/gallium/drivers/radeonsi/si_shader_tgsi_mem.c index 6decedc4cce..727def56f65

[Mesa-dev] [PATCH 2/6] radeonsi: fix rendering to tiny viewports where the viewport center is > 8K

2019-01-11 Thread Marek Olšák
From: Marek Olšák This fixes an assertion failure with GLCTX when cts-runner is used. (not a specific test) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108877 Cc: 18.3 --- .../drivers/radeonsi/si_state_viewport.c | 21 --- 1 file changed, 18 insertions(+), 3

[Mesa-dev] [PATCH 1/6] radeonsi: fix a u_blitter crash after a shader with FBFETCH

2019-01-11 Thread Marek Olšák
From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108877 Cc: 18.3 --- src/gallium/drivers/radeonsi/si_state_shaders.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c

[Mesa-dev] [PATCH 6/6] ac: use llvm.amdgcn.s.buffer.load

2019-01-11 Thread Marek Olšák
From: Marek Olšák --- src/amd/common/ac_llvm_build.c | 18 +- .../drivers/radeonsi/si_shader_tgsi_mem.c | 4 ++-- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/src/amd/common/ac_llvm_build.c b/src/amd/common/ac_llvm_build.c index

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Dylan Baker
Quoting Ilia Mirkin (2019-01-11 14:43:26) > On Fri, Jan 11, 2019 at 5:38 PM Matt Turner wrote: > > > > On Fri, Jan 11, 2019 at 2:28 PM Ilia Mirkin wrote: > > > > > > On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > > > > > > > From: Gert Wollny > > > > > > > > Since Meson will eventually

[Mesa-dev] [PATCH 4/6] radeonsi: remove redundant call to emit_cache_flush in compute clear/copy

2019-01-11 Thread Marek Olšák
From: Marek Olšák launch_grid calls it. --- src/gallium/drivers/radeonsi/si_compute_blit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_compute_blit.c b/src/gallium/drivers/radeonsi/si_compute_blit.c index 086793637f0..11da04bed85 100644 ---

[Mesa-dev] [Bug 109138] [KBL-G][GL-CTS]KHR-GL31.texture_size_promotion.functional test failed

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109138 Marek Olšák changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] st/dri: fix dri2_format_table for argb1555 and rgb565

2019-01-11 Thread Marek Olšák
From: Marek Olšák The bug caused that rgb565 framebuffers used argb1555. Fixes: 433ca3127a3b94bfe9a513e7c7ce594e09e1359f --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Kristian Høgsberg
On Fri, Jan 11, 2019 at 2:28 PM Ilia Mirkin wrote: > > On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > > > From: Gert Wollny > > > > Since Meson will eventually be the only build system deprecate autotools > > now. It can still be used by invoking configure with the flag > >

[Mesa-dev] [Bug 109324] mesa: Need ability to reconfigure on upgrade of Meson

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109324 Dylan Baker changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 109324, which changed state. Bug 109324 Summary: mesa: Need ability to reconfigure on upgrade of Meson https://bugs.freedesktop.org/show_bug.cgi?id=109324 What|Removed |Added

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Ilia Mirkin
On Fri, Jan 11, 2019 at 5:38 PM Matt Turner wrote: > > On Fri, Jan 11, 2019 at 2:28 PM Ilia Mirkin wrote: > > > > On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > > > > > From: Gert Wollny > > > > > > Since Meson will eventually be the only build system deprecate autotools > > > now. It

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Matt Turner
On Fri, Jan 11, 2019 at 2:28 PM Ilia Mirkin wrote: > > On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > > > From: Gert Wollny > > > > Since Meson will eventually be the only build system deprecate autotools > > now. It can still be used by invoking configure with the flag > >

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Matt Turner changed: What|Removed |Added Alias|autotools-removal |mesa-autotools-removal -- You are

[Mesa-dev] [Bug 109326] mesa: Meson configuration summary should be printed

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109326 Bug ID: 109326 Summary: mesa: Meson configuration summary should be printed Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Matt Turner changed: What|Removed |Added Depends on||109326 Referenced Bugs:

[Mesa-dev] [Bug 109325] mesa: Need ability to retrieve command line of Meson configuration

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109325 Bug ID: 109325 Summary: mesa: Need ability to retrieve command line of Meson configuration Product: Mesa Version: unspecified Hardware: Other OS: All

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Matt Turner changed: What|Removed |Added Depends on||109325 Referenced Bugs:

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Ilia Mirkin
On Fri, Jan 11, 2019 at 5:12 PM Matt Turner wrote: > > From: Gert Wollny > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > NAKed-by: Ilia Mirkin [nouveau] > Acked-by: Eric

[Mesa-dev] [Bug 109324] mesa: Need ability to reconfigure on upgrade of Meson

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109324 Bug ID: 109324 Summary: mesa: Need ability to reconfigure on upgrade of Meson Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Matt Turner changed: What|Removed |Added Depends on||109324 Referenced Bugs:

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Matt Turner
On Fri, Jan 11, 2019 at 2:17 PM Jason Ekstrand wrote: > > On Fri, Jan 11, 2019 at 4:11 PM Matt Turner wrote: >> >> From: Gert Wollny >> >> Since Meson will eventually be the only build system deprecate autotools >> now. It can still be used by invoking configure with the flag >>

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Matt Turner changed: What|Removed |Added Alias||autotools-removal -- You are receiving

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug ID: 109323 Summary: [TRACKER] mesa: Remove autotools Product: Mesa Version: unspecified Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 4:11 PM Matt Turner wrote: > From: Gert Wollny > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > NAKed-by: Ilia Mirkin > Acked-by: Eric Engestrom >

[Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Matt Turner
From: Gert Wollny Since Meson will eventually be the only build system deprecate autotools now. It can still be used by invoking configure with the flag --enable-autotools NAKed-by: Ilia Mirkin Acked-by: Eric Engestrom Acked-by: Kenneth Graunke Acked-by: Lionel Landwerlin Acked-by: Jason

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #20 from mirh --- A couple of devs are working into reinventing the wheel so that you could basically have r600 cards work and be supported almost like they had been released in 2018 (well, sans vulkan) And you have been already

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Eric Anholt
Gert Wollny writes: > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > Signed-off-by: Gert Wollny Reviewed-by: Eric Anholt signature.asc Description: PGP signature

[Mesa-dev] [Bug 105371] r600_shader_from_tgsi - GPR limit exceeded - shader requires 360 registers

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105371 --- Comment #19 from amonpaike --- is not there anyone who can give a view to what happens in what I reported in the previous comment? are these GPUs really old enough to be abandoned? on windows blender on these gpu runs that is a beauty ...

[Mesa-dev] [PATCH 1/3] spirv: Whack sampler/image pointers to uniform

2019-01-11 Thread Jason Ekstrand
A long time in a galaxy far far away, there was a GLSLang bug with how it handled samplers passed in as function parameters. (The bug can be found here: https://github.com/KhronosGroup/glslang/issues/179.) Unfortunately, that version was shipped in several apps and has been causing heartburn for

[Mesa-dev] [PATCH 3/3] intel/nir: Call nir_opt_deref in brw_nir_optimize

2019-01-11 Thread Jason Ekstrand
It's an optimization so we should probably be calling it in the optimization loop. --- src/intel/compiler/brw_nir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 749c00ebcc6..92d7fe4bede 100644 ---

[Mesa-dev] [PATCH 2/3] spirv: Contain the GLSLang issue #179 workaround to old GLSLang

2019-01-11 Thread Jason Ekstrand
Instead of applying the workaround universally, detect semi-old GLSLang via the generator ID and only enable the workaround on old GLSLang. This isn't nearly as precise as one would like it to be because the first GLSLang generator id version bump was on October 7, 2017 which is about 1.5 years

[Mesa-dev] [PATCH v3] etnaviv: fix resource usage tracking across different pipe_context's

2019-01-11 Thread Marek Vasut
From: Christian Gmeiner A pipe_resource can be shared by all the pipe_context's hanging off the same pipe_screen. Signed-off-by: Christian Gmeiner Signed-off-by: Marek Vasut To: mesa-dev@lists.freedesktop.org Cc: etna...@lists.freedesktop.org --- Changes from v1 -> v2: - to remove the

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 1:55 PM Kenneth Graunke wrote: > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > I think I kind of like having "mem" be on external things. Shared is a > > little weird there because it never leaves the chip so is it mem or > shader? > > On Intel

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > I think I kind of like having "mem" be on external things. Shared is a > little weird there because it never leaves the chip so is it mem or shader? On Intel GPUs, "shared" maps to a concept called "Shared Local Memory". So I

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 1:50 PM Kenneth Graunke wrote: > On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote: > > Jason Ekstrand writes: > > > > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke < > kenn...@whitecape.org> > > > wrote: > > > > > >> On Friday, January 11, 2019 8:33:41

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Friday, January 11, 2019 9:32:20 AM PST Eric Anholt wrote: > Jason Ekstrand writes: > > > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke > > wrote: > > > >> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > >> > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > >>

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Kai changed: What|Removed |Added Depends on||109319 Referenced Bugs:

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Christian Gmeiner
Am So., 16. Dez. 2018 um 12:24 Uhr schrieb Gert Wollny : > > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > Signed-off-by: Gert Wollny Reviewed-by: Christian Gmeiner > --- > IMO

[Mesa-dev] [MR] util: Helper to create sets and hashes with pointer keys

2019-01-11 Thread Caio Marcelo de Oliveira Filho
Just a small convenience patch I had sitting here for a while. https://gitlab.freedesktop.org/mesa/mesa/merge_requests/104 ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 6/6] anv: Implement VK_KHR_depth_stencil_resolve

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 3:21 AM Iago Toral wrote: > On Mon, 2019-01-07 at 09:39 -0600, Jason Ekstrand wrote: > > --- > > src/intel/vulkan/anv_device.c | 28 ++ > > src/intel/vulkan/anv_extensions.py | 1 + > > src/intel/vulkan/anv_pass.c| 37 +++- > >

Re: [Mesa-dev] [PATCH 4/6] anv/blorp: Refactor MSAA resolves into an exportable helper function

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 2:19 AM Iago Toral wrote: > On Mon, 2019-01-07 at 09:39 -0600, Jason Ekstrand wrote: > > This function is modeled after the aux_op functions except that it > > has a > > lot more parameters because it deals with two images as well as > > source > > and destination

[Mesa-dev] [MR] anv: Implement SSBOs bindings with GPU addresses in a descriptor BO

2019-01-11 Thread Jason Ekstrand
This merge request, which I've marked WIP, is trying to push ANV in a more modern direction. Whereas most other drivers have abandon binding tables in favour of descriptor buffers, we've been holding on to binding tables like our lives depended on it. This MR attempts to start moving us into the

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Matt Turner
On Fri, Jan 11, 2019 at 9:11 AM Kenneth Graunke wrote: > > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > > > Those names (nir_var_func_local, nir_var_thread_local, and > > > nir_var_thread_global) make more sense to

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Caio Marcelo de Oliveira Filho
On Fri, Jan 11, 2019 at 10:57:16AM -0600, Jason Ekstrand wrote: > All, > > The mesa project has now hit 100 merge requests (36 are still open). I > (and I'm sure others) would be curious to hear people's initial thoughts on > the process. What's working well? What's not working? Is it total

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Samuel Pitoiset
I haven't played with merge requests yet, except for reviewing some small RADV patches from Bas. From my point of view, the main problem now is that we have to look both at the mailing list and at the merge requests page and that's quite annoying. I don't think it's really a win to have two

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 11:23 AM Danylo Piliaiev wrote: > My small thoughts/questions: > > - First of all discussions are really much more convenient. > - Several (mine) merge requests were "Closed" and merged (not just merged, > they are under "Closed" category), am I missing something? > It

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Eric Anholt
Jason Ekstrand writes: > On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke > wrote: > >> On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: >> > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: >> > > Those names (nir_var_func_local, nir_var_thread_local, and >> > >

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Dylan Baker
Quoting Jason Ekstrand (2019-01-11 09:05:21) > I'm putting my own thoughts in a reply for some reason.  Here's what I've > seen. > >  1. I really like GitLab "discussions".  It provides a very good way for both > the author and the reviewers to keep track of what review comments have been >

Re: [Mesa-dev] Please bring back __GL_FSAA_MODE

2019-01-11 Thread Henri Verbeet
On Fri, 11 Jan 2019 at 13:05, Tom Butler wrote: > In particular I'm looking to get FSAA working in older games via wine, mostly > they don't support antialiasing which is a shame because there's plenty of > GPU power going to waste which could be fixing the jaggles. On nvidia > __GL_FSAA_MODE

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Danylo Piliaiev
My small thoughts/questions: - First of all discussions are really much more convenient. - Several (mine) merge requests were "Closed" and merged (not just merged, they are under "Closed" category), am I missing something? - Is there a way to grant rights to creator of merge request to

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 11:11 AM Kenneth Graunke wrote: > On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > > > Those names (nir_var_func_local, nir_var_thread_local, and > > > nir_var_thread_global) make more sense to

[Mesa-dev] [Bug 106595] [RADV] Rendering distortions only when MSAA is enabled

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106595 --- Comment #24 from Rhys Perry --- I seem to be able to reproduce the problem (alpha-tested geometry not visible) but only when Multi-sample Alpha-Test is enabled and WineD3D is used. After disabling Multi-sample Alpha-Test or using DXVK,

Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 9:13 AM Iago Toral Quiroga wrote: > We had defined MAX_IMAGES as 8, which we used to size the array for > image push constant data. The comment there stated that this was for > gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes > that array, asserting

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Friday, January 11, 2019 8:33:41 AM PST Jason Ekstrand wrote: > On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > > Those names (nir_var_func_local, nir_var_thread_local, and > > nir_var_thread_global) make more sense to me than private/function. > > > > Another option is

Re: [Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Jason Ekstrand
I'm putting my own thoughts in a reply for some reason. Here's what I've seen. 1. I really like GitLab "discussions". It provides a very good way for both the author and the reviewers to keep track of what review comments have been dealt with and what comments are still outstanding. 2.

[Mesa-dev] Thoughts after hitting 100 merge requests?

2019-01-11 Thread Jason Ekstrand
All, The mesa project has now hit 100 merge requests (36 are still open). I (and I'm sure others) would be curious to hear people's initial thoughts on the process. What's working well? What's not working? Is it total fail and should we go back to mailing lists? --Jason

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Karol Herbst
" On Fri, Jan 11, 2019 at 5:19 PM Kenneth Graunke wrote: > > On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote: > > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > >> the naming is a bit confusing no matter how

[Mesa-dev] [PATCH v3 3/3] egl: add config debug printout (v3)

2019-01-11 Thread Silvestrs Timofejevs
Feature to print out EGL returned configs for debug purposes. 'eglChooseConfig' and 'eglGetConfigs' debug information printout is enabled when the log level equals '_EGL_DEBUG'. The configs are printed, and if any of them are "chosen" they are marked with their index in the chosen configs array.

[Mesa-dev] debug feature to dump "get configs" and "chosen configs" (v3)

2019-01-11 Thread Silvestrs Timofejevs
This patch series provides an easy way to see what configs have been returned by the 'eglGetConfigs' and 'eglChooseConfig' functions, and give an overview of config attributes. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] [PATCH v3 2/3] egl: introduce a log level getter function

2019-01-11 Thread Silvestrs Timofejevs
Being able to retrieve the log level can be useful to enable/disable debug code. The alternative, which is calling 'getenv' function every time to retrieve the log level, is more "expensive". Signed-off-by: Silvestrs Timofejevs Reviewed-by: Eric Engestrom --- src/egl/main/egllog.c | 9

[Mesa-dev] [PATCH v3 1/3] util: introduce the util_strnappend function (v2)

2019-01-11 Thread Silvestrs Timofejevs
This function is similar to strncat, but unlike strncat it allows to concatenate the buffer with a formatted string. The alternative would be to have an intermediate string that is formated first, and then appended via strncat. v2: revert accidentally introduced blank line removal

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Jason Ekstrand
On Fri, Jan 11, 2019 at 10:19 AM Kenneth Graunke wrote: > On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote: > > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > > >> the naming is a bit confusing no matter how you

Re: [Mesa-dev] [PATCH 05/12] nir: rename global/local to private/function memory

2019-01-11 Thread Kenneth Graunke
On Wednesday, January 9, 2019 5:33:22 PM PST Ian Romanick wrote: > On 1/8/19 9:57 PM, Kenneth Graunke wrote: > > On Tuesday, December 4, 2018 10:26:43 AM PST Karol Herbst wrote: > >> the naming is a bit confusing no matter how you look at it. Within SPIR-V > >> "global" memory is memory accessible

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Emil Velikov
On 2019/01/11, Andres Gomez wrote: > "--summary" will also print extended header information such as > creations, renames and mode changes. > I might be missing some settings - cannot see any of those here. Regardless, I have slight inclination towards --no-patch (as Eric suggested) but either

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

2019-01-11 Thread Emil Velikov
On 2019/01/11, Andres Gomez wrote: > "&>" is bash specific. > > Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid > sha") > Cc: Juan A. Suarez > Cc: Eric Engestrom > Cc: Dylan Baker > Cc: Emil Velikov Reviewed-by: Emil Velikov Out of curiosity, are you using

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Andres Gomez
On Fri, 2019-01-11 at 15:22 +, Emil Velikov wrote: > Hi Andres, > > On Fri, 11 Jan 2019 at 15:05, Andres Gomez wrote: > > > > I'll start with the 18.3.2 release process and keep with the the > > following bugfix releases by now. > > > > I was going through it earlier today and was going

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Emil Velikov
On Fri, 11 Jan 2019 at 15:22, Emil Velikov wrote: > > Hi Andres, > > On Fri, 11 Jan 2019 at 15:05, Andres Gomez wrote: > > > > I'll start with the 18.3.2 release process and keep with the the > > following bugfix releases by now. > > > I was going through it earlier today and was going to send

Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Iago Toral
On Fri, 2019-01-11 at 15:24 +, Lionel Landwerlin wrote: > On 11/01/2019 15:12, Iago Toral Quiroga wrote: > > We had defined MAX_IMAGES as 8, which we used to size the array for > > image push constant data. The comment there stated that this was > > for > > gen8, but

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Emil Velikov
Hi Andres, On Fri, 11 Jan 2019 at 15:05, Andres Gomez wrote: > > I'll start with the 18.3.2 release process and keep with the the > following bugfix releases by now. > I was going through it earlier today and was going to send it out in the next couple of hours. For anyone wondering "lucky" me

Re: [Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Lionel Landwerlin
On 11/01/2019 15:12, Iago Toral Quiroga wrote: We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes that array, asserting that we don't exceed

[Mesa-dev] [PATCH v3] anv/device: fix maximum number of images supported

2019-01-11 Thread Iago Toral Quiroga
We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes that array, asserting that we don't exceed that number of images, which imposes a limit of

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

2019-01-11 Thread Eric Engestrom
On Friday, 2019-01-11 16:43:27 +0200, Andres Gomez wrote: > "&>" is bash specific. > > Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid > sha") > Cc: Juan A. Suarez > Cc: Eric Engestrom > Cc: Dylan Baker > Cc: Emil Velikov > Signed-off-by: Andres Gomez Reviewed-by:

Re: [Mesa-dev] [ANNOUNCE] mesa 18.3.1

2019-01-11 Thread Andres Gomez
I'll start with the 18.3.2 release process and keep with the the following bugfix releases by now. On Mon, 2019-01-07 at 15:33 +0200, Andres Gomez wrote: > Emil, the 18.3.2 should have already happened by the 19th of December. > > Is there anything stopping you from going ahead with it? > >

Re: [Mesa-dev] [RFC 1/6] dri: Support 64 bit rgba masks

2019-01-11 Thread Emil Velikov
Hi Kevin, Thanks for that massive undertaking in addressing this. On 2019/01/04, Kevin Strasser wrote: > The dri core api was written with the assumption that all attribute values > would fit into 32 bits. This limitation means the config handlers can't > accept 64 bpp formats. Reserve 64 bits

Re: [Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Eric Engestrom
On Friday, 2019-01-11 16:42:25 +0200, Andres Gomez wrote: > "--summary" will also print extended header information such as > creations, renames and mode changes. > > Let's just use "-s", which suppresses the diff output. > > Fixes: 559c32d2412 ("bin/get-pick-list.sh: simplify git oneline

Re: [Mesa-dev] [PATCH 2/2] egl/drivers/haiku: Fix reference to disp vs dpy

2019-01-11 Thread Eric Engestrom
On Friday, 2019-01-11 14:20:38 +, Emil Velikov wrote: > On Wed, 2 Jan 2019 at 13:48, Eric Engestrom wrote: > > > > On Thursday, 2018-12-27 20:41:47 +, Alexander von Gluck IV wrote: > > > --- > > > src/egl/drivers/haiku/egl_haiku.cpp | 3 ++- > > > 1 file changed, 2 insertions(+), 1

[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix redirection in sh

2019-01-11 Thread Andres Gomez
"&>" is bash specific. Fixes: e0dbfc99537 ("bin/get-pick-list.sh: warn when commit lists invalid sha") Cc: Juan A. Suarez Cc: Eric Engestrom Cc: Dylan Baker Cc: Emil Velikov Signed-off-by: Andres Gomez --- bin/get-pick-list.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH] bin/get-pick-list.sh: fix the oneline printing

2019-01-11 Thread Andres Gomez
"--summary" will also print extended header information such as creations, renames and mode changes. Let's just use "-s", which suppresses the diff output. Fixes: 559c32d2412 ("bin/get-pick-list.sh: simplify git oneline printing") Cc: Juan A. Suarez Cc: Eric Engestrom Cc: Dylan Baker Cc: Emil

Re: [Mesa-dev] [PATCH mesa 1/2] docs: fix the meson aarch64 cross-file

2019-01-11 Thread Emil Velikov
On 2019/01/03, Eric Engestrom wrote: > `gcc-ar` is preferred over the generic `ar`, and the `arm` family is > for 32-bit ARM [1]. > > [1] https://mesonbuild.com/Reference-tables.html#cpu-families > > Signed-off-by: Eric Engestrom Nice. For the series Reviewed-by: Emil Velikov -Emil

Re: [Mesa-dev] [PATCH mesa] travis: avoid using unset llvm-config

2019-01-11 Thread Emil Velikov
On 2019/01/02, Eric Engestrom wrote: > Fixes the following errors: > usage: which [-as] program ... > /Users/travis/.travis/job_stages: line 110: --version: command not found > > ... caused by the use of an undefined $LLVM_CONFIG > > Signed-off-by: Eric Engestrom Reviewed-by: Emil Velikov

Re: [Mesa-dev] [PATCH 2/2] egl/drivers/haiku: Fix reference to disp vs dpy

2019-01-11 Thread Emil Velikov
On Wed, 2 Jan 2019 at 13:48, Eric Engestrom wrote: > > On Thursday, 2018-12-27 20:41:47 +, Alexander von Gluck IV wrote: > > --- > > src/egl/drivers/haiku/egl_haiku.cpp | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/src/egl/drivers/haiku/egl_haiku.cpp > >

Re: [Mesa-dev] [PATCH 1/2] egl/egldevice: Fix broken reference to dev->device without LIBDRM

2019-01-11 Thread Emil Velikov
On Sat, 29 Dec 2018 at 16:05, Ilia Mirkin wrote: > > On Sat, Dec 29, 2018 at 6:17 AM Mathias Fröhlich > wrote: > > In Emils patches building on top, _eglGetDRMDeviceRenderNode is only called > > from > > code paths guarded with HAVE_LIBDRM. > > OK, so we could also guard the function's

Re: [Mesa-dev] [PATCH] EGL/mesa: Initial write up fot MESA_query_driver

2019-01-11 Thread Emil Velikov
Hi Veluri, On 2018/12/23, Veluri Mithun wrote: > - Try to retrieve driver name from dri2_egl_display > I would add a note that GLVND based Mesa and GLVND itself aren't updated. Might be a good idea to add an inline comment or two. > Signed-off-by: Veluri Mithun > --- >

Re: [Mesa-dev] [PATCH] autotools: Deprecate the use of autotools

2019-01-11 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Sun, Dec 16, 2018 at 6:24 AM Gert Wollny wrote: > Since Meson will eventually be the only build system deprecate autotools > now. It can still be used by invoking configure with the flag > --enable-autotools > > Signed-off-by: Gert Wollny > --- > IMO

Re: [Mesa-dev] [PATCH v2] anv/device: fix maximum number of images supported

2019-01-11 Thread Lionel Landwerlin
On 11/01/2019 12:40, Iago Toral wrote: On Fri, 2019-01-11 at 12:31 +, Lionel Landwerlin wrote: On 11/01/2019 12:12, Iago Toral Quiroga wrote: We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but

Re: [Mesa-dev] [PATCH v2] anv/device: fix maximum number of images supported

2019-01-11 Thread Iago Toral
On Fri, 2019-01-11 at 12:31 +, Lionel Landwerlin wrote: > On 11/01/2019 12:12, Iago Toral Quiroga wrote: > > We had defined MAX_IMAGES as 8, which we used to size the array for > > image push constant data. The comment there stated that this was > > for > > gen8, but

Re: [Mesa-dev] [PATCH v2] anv/device: fix maximum number of images supported

2019-01-11 Thread Lionel Landwerlin
On 11/01/2019 12:12, Iago Toral Quiroga wrote: We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes that array, asserting that we don't exceed

Re: [Mesa-dev] [PATCH] anv/pipeline_cache: free NIR shader cache

2019-01-11 Thread Lionel Landwerlin
On 11/01/2019 12:05, Iago Toral Quiroga wrote: Fixes: f6aa9f718516 'anv/pipeline_cache: Add support for caching NIR' Thanks a bunch : Reviewed-by: Lionel Landwerlin --- src/intel/vulkan/anv_pipeline_cache.c | 7 +++ 1 file changed, 7 insertions(+) diff --git

[Mesa-dev] [PATCH v2] anv/device: fix maximum number of images supported

2019-01-11 Thread Iago Toral Quiroga
We had defined MAX_IMAGES as 8, which we used to size the array for image push constant data. The comment there stated that this was for gen8, but anv_nir_apply_pipeline_layout runs for all gens and writes that array, asserting that we don't exceed that number of images, which imposes a limit of

[Mesa-dev] [Bug 109131] cc1plus: error: unrecognized command line option "-std=c++11"

2019-01-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109131 --- Comment #4 from Emil Velikov --- AFAICT we probe if the compiler supports -std... before using it. If somehow that's not the case we ought to fix that, or fallback to one that owrks. Patches welcome :-) -- You are receiving this mail

[Mesa-dev] [PATCH] anv/pipeline_cache: free NIR shader cache

2019-01-11 Thread Iago Toral Quiroga
Fixes: f6aa9f718516 'anv/pipeline_cache: Add support for caching NIR' --- src/intel/vulkan/anv_pipeline_cache.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/intel/vulkan/anv_pipeline_cache.c b/src/intel/vulkan/anv_pipeline_cache.c index f9733c5309..d96102c287 100644 ---

  1   2   >