Re: [Mesa-dev] [PATCH 09/19] radv: use the new attachments array in CmdEndRenderPass()

2019-01-31 Thread Samuel Pitoiset
On 1/31/19 11:16 AM, Bas Nieuwenhuizen wrote: On Tue, Jan 29, 2019 at 10:16 PM Samuel Pitoiset wrote: That shouldn't change anything as we check if the last subpass id is the final subpass. Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 16 +--- 1 file

[Mesa-dev] [MR] NIR shaders for st/mesa

2019-01-31 Thread Kenneth Graunke
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/189 Here's a series that ports st/mesa's built-in shaders for various things from TGSI to NIR. For drivers which prefer NIR, we use the new direct versions rather than using tgsi_to_nir. I've tested Piglit on radeonsi using R600_DEBUG=nir,

[Mesa-dev] [Bug 109391] LTO Build fails

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109391 Hi-Angel changed: What|Removed |Added CC||hi-an...@yandex.ru -- You are receiving

Re: [Mesa-dev] [PATCH 23/25] radeonsi: factor si_query_buffer logic out of si_query_hw

2019-01-31 Thread Timothy Arceri
On 26/1/19 11:56 am, Marek Olšák wrote: Timothy, can you please test the attached fix? I'm having trouble compiling 32bit mesa on my machine at the moment so haven't been able to test Batman. But this commit also causes No Mans Sky to lock up my machine and the attached patch does not fix

[Mesa-dev] [Bug 109258] Weston drm-backend.so seems to fail with Mesa master and LIBGL_ALWAYS_SOFTWARE=1

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109258 --- Comment #9 from n3rdopolis --- IIRC, EGL_SOFTWARE=1 stopped working a while ago, sometime in 2015 it appears LIBGL_ALWAYS_SOFTWARE was what was working since then, until this change -- You are receiving this mail because: You are the QA

Re: [Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

2019-01-31 Thread Alyssa Rosenzweig
> Doing merge commits for new drivers is not unheard of and preserves > history (if the history is something you want to preserve). The history downstream is a total mess (read: probably not bisectable), and a lot of it was committed sloppily knowing it would get squished. So thank you for

[Mesa-dev] [MR] intel: Skip bit6 swizzle test in Gen8+

2019-01-31 Thread Caio Marcelo de Oliveira Filho
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/188 Per Broadwell PRM, we can skip the bit6 swizzle check and just assume false. "Tiled Channel Select Decision Before Gen8, there was a historical configuration control field to swizzle address bit[6] for in X/Y tiling modes.

Re: [Mesa-dev] [PATCH] radeonsi/nir: remove dead local variables

2019-01-31 Thread Timothy Arceri
On 1/2/19 5:04 am, Emil Velikov wrote: On Thu, 31 Jan 2019 at 01:01, Timothy Arceri wrote: Without this we do not end up with a deterministic NIR. NIR must be deterministic here because we use it to produce a sha for the radeonsi backends disk cache. This fixes the shader cache for a bunch

[Mesa-dev] [Bug 109391] LTO Build fails

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109391 --- Comment #3 from Hi-Angel --- (In reply to Eric Engestrom from comment #2) > That file is generated by src/mapi/mapi_abi.py > The exact command line used to generate src/glapi/gen/glapi_mapi_tmp.h is: > $ python3 src/mapi/mapi_abi.py

[Mesa-dev] 2019 X.Org Board of Directors Elections Nomination period is NOW

2019-01-31 Thread Wentland, Harry
We are seeking nominations for candidates for election to the X.Org Foundation Board of Directors. All X.Org Foundation members are eligible for election to the board. Nominations for the 2019 election are now open and will remain open until 23:59 UTC on 14 February 2019. The Board consists

[Mesa-dev] [PATCH 2/5] radeonsi: clear allocator_zeroed_memory with SDMA

2019-01-31 Thread Marek Olšák
From: Marek Olšák so that it can be used in parallel IBs. This also removes the SO_FILLED_SIZE hack. --- src/gallium/drivers/radeonsi/si_buffer.c | 4 src/gallium/drivers/radeonsi/si_compute_blit.c | 9 + src/gallium/drivers/radeonsi/si_pipe.c | 6 +++---

[Mesa-dev] [PATCH 1/5] radeonsi: initialize textures using DCC to black when possible

2019-01-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_clear.c | 9 src/gallium/drivers/radeonsi/si_pipe.h| 10 src/gallium/drivers/radeonsi/si_texture.c | 57 +-- 3 files changed, 63 insertions(+), 13 deletions(-) diff --git

[Mesa-dev] [PATCH 4/5] radeonsi: don't leak an index buffer if draw_vbo fails

2019-01-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index c7c02d20d15..9c968e39c2c 100644 ---

[Mesa-dev] [PATCH 3/5] radeonsi: make allocator_zeroed_memory unmappable and use bigger buffers

2019-01-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_pipe.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index 98059ddbf8b..c6f93e7b15e 100644 --- a/src/gallium/drivers/radeonsi/si_pipe.c

[Mesa-dev] [PATCH 5/5] radeonsi: use local ws variable in si_need_dma_space

2019-01-31 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_dma_cs.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_dma_cs.c b/src/gallium/drivers/radeonsi/si_dma_cs.c index 33177a9e4ad..2aafc1f09a0 100644 ---

Re: [Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

2019-01-31 Thread Rob Clark
On Wed, Jan 30, 2019 at 12:43 AM Alyssa Rosenzweig wrote: > > This patch adds an initial stub for the Gallium driver, containing > simple screen functions and the majority of the driver headers but no > actual functionality. It further adds the winsys glue for linking in > this stub driver via

Re: [Mesa-dev] [PATCH] radeonsi/nir: remove dead local variables

2019-01-31 Thread Emil Velikov
On Thu, 31 Jan 2019 at 01:01, Timothy Arceri wrote: > > Without this we do not end up with a deterministic NIR. NIR must > be deterministic here because we use it to produce a sha for the > radeonsi backends disk cache. > > This fixes the shader cache for a bunch of shaders. I guess we'll need

[Mesa-dev] [Bug 109523] meson requires libdrm_amdgpu even when not needed

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109523 Matt Turner changed: What|Removed |Added Blocks|109323 | Referenced Bugs:

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Matt Turner changed: What|Removed |Added Depends on|109523 | Referenced Bugs:

[Mesa-dev] [Bug 109523] meson requires libdrm_amdgpu even when not needed

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109523 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 109523, which changed state. Bug 109523 Summary: meson requires libdrm_amdgpu even when not needed https://bugs.freedesktop.org/show_bug.cgi?id=109523 What|Removed |Added

[Mesa-dev] [Bug 109523] meson requires libdrm_amdgpu even when not needed

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109523 --- Comment #1 from Ilia Mirkin --- I believe you also need to empty out vulkan-drivers. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

[Mesa-dev] [Bug 109523] meson requires libdrm_amdgpu even when not needed

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109523 Bug ID: 109523 Summary: meson requires libdrm_amdgpu even when not needed Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [Bug 109523] meson requires libdrm_amdgpu even when not needed

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109523 Vinson Lee changed: What|Removed |Added Blocks||109323 Referenced Bugs:

Re: [Mesa-dev] [PATCH] gallium: allow more PIPE_RESOURCE_ driver flags

2019-01-31 Thread Roland Scheidegger
Looks ok to me, there's still a few bits left luckily... Reviewed-by: Roland Scheidegger Am 30.01.19 um 20:21 schrieb Marek Olšák: > From: Marek Olšák > > radeonsi has 8 and will probably have 9 soon. > --- > src/gallium/include/pipe/p_defines.h | 2 +- > 1 file changed, 1 insertion(+), 1

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Vinson Lee changed: What|Removed |Added Depends on||109523 Referenced Bugs:

Re: [Mesa-dev] [PATCH] anv: update TODO

2019-01-31 Thread Jason Ekstrand
Just delete the whole file. The few bits remaining are tracked in JIRA. The only utility I could immagine to having a TODO in the repo these days would be if we wanted to have a gen7 TODO. --Jason On Thu, Jan 31, 2019 at 9:21 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: >

Re: [Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

2019-01-31 Thread Jason Ekstrand
On Thu, Jan 31, 2019 at 10:36 AM Eric Anholt wrote: > Alyssa Rosenzweig writes: > > >> There's u_pipe_screen_get_param_defaults() that you really want to be > >> using to avoid regressions when people add new pipe caps. You can get > >> rid of a lot of your switch statement that way, too. > >

Re: [Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

2019-01-31 Thread Eric Anholt
Alyssa Rosenzweig writes: >> There's u_pipe_screen_get_param_defaults() that you really want to be >> using to avoid regressions when people add new pipe caps. You can get >> rid of a lot of your switch statement that way, too. > > Oh, good to know. Is that newer? I'm pretty sure that whole

Re: [Mesa-dev] [PATCH 2/2] panfrost: Implement Midgard shader toolchain

2019-01-31 Thread Eric Anholt
Alyssa Rosenzweig writes: > This patch implements the free Midgard shader toolchain: the assembler, > the disassembler, and the NIR-based compiler. The assembler is a > standalone inaccessible Python script for reference purposes. The > disassembler and the compiler are implemented in C,

Re: [Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

2019-01-31 Thread Alyssa Rosenzweig
> There's u_pipe_screen_get_param_defaults() that you really want to be > using to avoid regressions when people add new pipe caps. You can get > rid of a lot of your switch statement that way, too. Oh, good to know. Is that newer? I'm pretty sure that whole block was copied from vc4 at some

[Mesa-dev] [Bug 109242] [RADV] The Witcher 3 system freeze

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109242 --- Comment #33 from Roman Elshin --- I think so (mesa from git works fine for me here). -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH 0/2] Initial Panfrost driver

2019-01-31 Thread Alyssa Rosenzweig
> As you pointed out, the CS of the driver is not included, so I wonder > if we cannot add link to instructions in panfrost_create_screen() > Reading the current fprintf is fairly discouraging. We could probably add a link to downstream there, yes. Ideally, we could just get the cmdstream code

[Mesa-dev] [Bug 109325] mesa: Need ability to retrieve command line of Meson configuration

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109325 Eric Engestrom changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 109323] [TRACKER] mesa: Remove autotools

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109323 Bug 109323 depends on bug 109325, which changed state. Bug 109325 Summary: mesa: Need ability to retrieve command line of Meson configuration https://bugs.freedesktop.org/show_bug.cgi?id=109325 What|Removed

Re: [Mesa-dev] [PATCH 01/13] egl/dri: Avoid out of bounds array access

2019-01-31 Thread Emil Velikov
On Wed, 30 Jan 2019 at 23:07, Strasser, Kevin wrote: > > Emile Velikov wrote: > > JFYI: > > Checking the offending commit (like below) allows us to better track > > where the patch is need plus it gives you a few automatic reviewers > > ;-) > > > > Cc: Chad Versace > > Cc: Eric Engestrom > >

[Mesa-dev] [Bug 109391] LTO Build fails

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109391 Fabio Pedretti changed: What|Removed |Added CC||pedretti.fa...@gmail.com -- You are

Re: [Mesa-dev] [PATCH 1/2] panfrost: Initial stub for Panfrost driver

2019-01-31 Thread Eric Anholt
Alyssa Rosenzweig writes: > This patch adds an initial stub for the Gallium driver, containing > simple screen functions and the majority of the driver headers but no > actual functionality. It further adds the winsys glue for linking in > this stub driver via kmsro on Rockchip/Amlogic boards.

[Mesa-dev] [PATCH] anv: update TODO

2019-01-31 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- src/intel/vulkan/TODO | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/intel/vulkan/TODO b/src/intel/vulkan/TODO index b4da05de2b1..5b27cb2bd63 100644 --- a/src/intel/vulkan/TODO +++ b/src/intel/vulkan/TODO @@ -7,7 +7,4 @@ Missing Features:

[Mesa-dev] [Bug 109391] LTO Build fails

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109391 --- Comment #2 from Eric Engestrom --- That file is generated by src/mapi/mapi_abi.py The exact command line used to generate src/glapi/gen/glapi_mapi_tmp.h is: $ python3 src/mapi/mapi_abi.py --printer glapi src/mapi/glapi/gen/gl_and_es_API.xml

[Mesa-dev] [Bug 108823] [Bisected]. Autotools. Installing mesa fails with error "error: relink 'libEGL.la' with the above command before installing it"

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108823 Denis changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

Re: [Mesa-dev] [PATCH 0/2] Initial Panfrost driver

2019-01-31 Thread Emil Velikov
Hi Alyssa, On Wed, 30 Jan 2019 at 05:43, Alyssa Rosenzweig wrote: > > Panfrost is a community-led, free software driver for Mali Midgard and > Bifrost GPUs. This patchset contains the initial changes for upstreaming > the driver. On the command stream side, for now only a stub and winsys >

Re: [Mesa-dev] [PATCH v2 04/29] nir: add support for flushing to zero denorm constants

2019-01-31 Thread Samuel Iglesias Gonsálvez
On 30/01/2019 16:18, Connor Abbott wrote: > > > On Tue, Dec 18, 2018 at 11:35 AM Samuel Iglesias Gonsálvez > mailto:sigles...@igalia.com>> wrote: > > v2: > - Refactor conditions and shared function (Connor) > - Move code to nir_eval_const_opcode() (Connor) > - Don't flush to

Re: [Mesa-dev] [PATCH v2 14/29] nir: fix constant expressions for rounding mode conversions

2019-01-31 Thread Samuel Iglesias Gonsálvez
On 30/01/2019 16:29, Connor Abbott wrote: > I think maybe it would be better if we put all this in nir_opcodes.py > instead. Again, I'd like to make sure that for every opcode, what it > does is right next to the definition instead of buried in > nir_constant_expressions.py. > OK, I'll do it.

Re: [Mesa-dev] [Mesa-announce] [ANNOUNCE] Mesa 18.3.3 release candidate

2019-01-31 Thread Emil Velikov
On Wed, 30 Jan 2019 at 18:48, Matt Turner wrote: > > On Wed, Jan 30, 2019 at 10:37 AM Emil Velikov > wrote: > > > > Hello list, > > > > The candidate for the Mesa 18.3.3 is now available. Currently we have: > > - 45 queued > > - 4 nominated (outstanding) > > - and 3 rejected patches > >

[Mesa-dev] [Bug 109391] LTO Build fails

2019-01-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109391 --- Comment #1 from Hi-Angel --- I just researched the problem, and it comes down to function declarations using assembly. Maybe there some __attribute__ needs to be added and what not, but I kind of stuck ATM, because the assembly code is in a

Re: [Mesa-dev] [PATCH 09/19] radv: use the new attachments array in CmdEndRenderPass()

2019-01-31 Thread Bas Nieuwenhuizen
On Tue, Jan 29, 2019 at 10:16 PM Samuel Pitoiset wrote: > > That shouldn't change anything as we check if the last > subpass id is the final subpass. > > Signed-off-by: Samuel Pitoiset > --- > src/amd/vulkan/radv_cmd_buffer.c | 16 +--- > 1 file changed, 13 insertions(+), 3