On Fri, Feb 8, 2019 at 8:27 PM Alyssa Rosenzweig wrote:
>
> The previous code for handling viewport changes and scissors was ad hoc
> and subject to edge cases. This patch unifies and streamlines these
> routines, improving code quality and partially fixing the scissor test.
>
> Signed-off-by:
On Fri, Feb 8, 2019 at 8:24 PM Alyssa Rosenzweig wrote:
>
> Midgard has native support for QUADS and POLYGONS; Bifrost seemingly
> does not. Thus, Midgard generally skips prim_convert whereas Bifrost
> needs the pass; this patch allows the setting of allowed primitives to
> occur on a per-context
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/midgard/midgard_compile.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/src/gallium/drivers/panfrost/pan_context.c
b/src/gallium/drivers/panfrost/pan_context.c
index 31c0029ac1a..2daa2a56b82 100644
---
The previous code for handling viewport changes and scissors was ad hoc
and subject to edge cases. This patch unifies and streamlines these
routines, improving code quality and partially fixing the scissor test.
Signed-off-by: Alyssa Rosenzweig
---
src/gallium/drivers/panfrost/pan_context.c |
Via the prototyping cycle, a substantial amount of dead code and other
cruft has accumulated in the Panfrost tree, which is a burden for both
maintenance and aesthetic.
This patch series removes dead code when it's trivial to do so, or
refactors in order to remove dead code when nontrivial to do
Signed-off-by: Alyssa Rosenzweig
---
.../drivers/panfrost/midgard/cmdline.c| 11 --
src/gallium/drivers/panfrost/pan_assemble.c | 14 ---
.../drivers/panfrost/pan_blend_shaders.c | 16
src/gallium/drivers/panfrost/pan_context.c| 5 ---
Midgard has native support for QUADS and POLYGONS; Bifrost seemingly
does not. Thus, Midgard generally skips prim_convert whereas Bifrost
needs the pass; this patch allows the setting of allowed primitives to
occur on a per-context basis (for runtime hardware selection).
Signed-off-by: Alyssa
https://bugs.freedesktop.org/show_bug.cgi?id=109597
Bug ID: 109597
Summary: wreckfest issues with transparent objects & skybox
Product: Mesa
Version: 18.3
Hardware: Other
OS: All
Status: NEW
Severity:
https://bugs.freedesktop.org/show_bug.cgi?id=109596
Bug ID: 109596
Summary: Crashes on glXBindTexImageEXT call on surface whose
Window got destroyed
Product: Mesa
Version: 18.3
Hardware: Other
OS: Linux
On 2/8/19 2:33 PM, Andy Ritger wrote:
On Fri, Feb 08, 2019 at 03:01:33PM -0500, Adam Jackson wrote:
On Fri, 2019-02-08 at 10:19 -0800, Andy Ritger wrote:
(1) If configured for PRIME GPU offloading (environment variable or
application profile), client-side libglvnd could load the possible
It doesn't matter what we use as the MCS fetch will ignore it. Using
zero means we'll naver trigger a header because of it. We have an
optimization in the indirect message case for when the texture and
sampler are the same but we also have one for when the texture is
indirect and the sampler is
https://bugs.freedesktop.org/show_bug.cgi?id=109532
--- Comment #18 from Ian Romanick ---
(In reply to asimiklit from comment #7)
> (In reply to Ilia Mirkin from comment #2)
> > Looks like this is happening in link_uniform_blocks. The type gets updated:
> >
> > if (b->array != NULL &&
> >
On Fri, Feb 8, 2019 at 7:15 AM Juan A. Suarez Romero
wrote:
> This can happen when we record a VkCmdDraw in a secondary buffer that
> was created inheriting from the primary buffer, but with the framebuffer
> set to NULL in the VkCommandBufferInheritanceInfo.
>
> Vulkan 1.1.81 spec says that
I had a chat with Caio about this and I'm skeptical. In general, users of
the CF manipulation code shouldn't be stitching two blocks together where
the first contains a jump and the second is non-empty. If the caller knows
that this case is ok, then they can check for it and empty out the one
On Fri, Feb 08, 2019 at 03:01:33PM -0500, Adam Jackson wrote:
> On Fri, 2019-02-08 at 10:19 -0800, Andy Ritger wrote:
>
> > (1) If configured for PRIME GPU offloading (environment variable or
> > application profile), client-side libglvnd could load the possible
> > libGLX_${vendor}.so
https://bugs.freedesktop.org/show_bug.cgi?id=109532
--- Comment #17 from Ian Romanick ---
(In reply to asimiklit from comment #6)
> Created attachment 143288 [details]
> this simple program helps me to reproduce this issue.
>
> just share my simple reproducer)
>
> Run it in this way:
>
>
On Thu, Feb 07, 2019 at 06:00:19PM +0200, Eleni Maria Stea wrote:
> GPUs Gen < 8 cannot sample ETC2 formats. So far, they converted the
> compressed EAC/ETC2 images to non-compressed RGBA images. When
> GetCompressed* functions were called, the pixels were returned in this
> RGBA format and not
https://bugs.freedesktop.org/show_bug.cgi?id=107767
--- Comment #2 from Ian Romanick ---
I'm not surprised. The --dump-builder option of the stand-alone compiler was
added to support generating int64 lowering functions from GLSL. I had no
expectation that anyone would use that option for
On Fri, 2019-02-08 at 10:19 -0800, Andy Ritger wrote:
> (1) If configured for PRIME GPU offloading (environment variable or
> application profile), client-side libglvnd could load the possible
> libGLX_${vendor}.so libraries it finds, and call into each to
> find which vendor (and
On Thu, Feb 07, 2019 at 06:00:19PM +0200, Eleni Maria Stea wrote:
> GPUs Gen < 8 cannot sample ETC2 formats. So far, they converted the
> compressed EAC/ETC2 images to non-compressed RGBA images. When
> GetCompressed* functions were called, the pixels were returned in this
> RGBA format and not
On Fri, Feb 08, 2019 at 12:55:20PM +0200, Eleni Maria Stea wrote:
> Hi Nanley,
>
> On Thu, 7 Feb 2019 15:46:29 -0800
> Nanley Chery wrote:
> >
> > > @@ -3825,10 +3849,20 @@ intel_miptree_unmap(struct brw_context *brw,
> > > DBG("%s: mt %p (%s) level %d slice %d\n", __func__,
> > >
This patch is
Reviewed-by: Boyuan Zhang
-Original Message-
From: mesa-dev On Behalf Of Liu, Leo
Sent: February 8, 2019 10:11 AM
To: mesa-dev@lists.freedesktop.org
Cc: 19 . 0
Subject: [Mesa-dev] [PATCH 2/2] st/va/vp9: set max reference as default of VP9
reference number
If there is
This patch is
Reviewed-by: Boyuan Zhang
-Original Message-
From: mesa-dev On Behalf Of Liu, Leo
Sent: February 8, 2019 10:11 AM
To: mesa-dev@lists.freedesktop.org
Cc: 19 . 0
Subject: [Mesa-dev] [PATCH 1/2] st/va: fix the incorrect max profiles report
Add "PIPE_VIDEO_PROFILE_MAX" to
Add compute shader initilization, assign and cleanup in vl_compositor API.
Set video compositor compute shader render as default when pipe support it.
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 105 ++-
On Fri, Feb 8, 2019, 2:09 PM James Zhu I combined patch5 and 6 into one patch. create compute shader only when
> pipe support it.
>
That's fine. I only requested additional changes.
Marek
James.
> On 2019-02-08 12:29 p.m., Marek Olšák wrote:
>
> If compute is used, graphics shaders don't need
Add compute shader initilization, assign and cleanup in vl_compositor API.
Set vl_compositor compute shader render as default when pipe support it.
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 105 ++-
I combined patch5 and 6 into one patch. create compute shader only when pipe
support it.
James.
On 2019-02-08 12:29 p.m., Marek Olšák wrote:
If compute is used, graphics shaders don't need to be created.
Marek
On Fri, Feb 8, 2019 at 9:02 AM James Zhu
mailto:jam...@amd.com>> wrote:
On
Add compute shader initilization, assign and cleanup in vl_compositor API.
Set vl_compositor compute shader render as default when pipe support it.
Signed-off-by: James Zhu
Reviewed-by: Christian König
---
src/gallium/auxiliary/vl/vl_compositor.c | 105 ++-
On 2/8/19 5:21 AM, Juan A. Suarez Romero wrote:
> On Sat, 2019-01-26 at 08:37 -0800, Jason Ekstrand wrote:
>> This makes me a bit nervous. I'll have to look at it in more detail.
>>
>
> Did you have time to take a look at this?
Is there a test case that hits this? Was it found by inspection?
(I'll omit EGL and Vulkan for the moment, for the sake of focus, and those
APIs have programmatic ways to enumerate and select GPUs. Though, some
of what we decide here for GLX we may want to leverage for other APIs.)
Today, GLX implementations loaded into the X server register themselves
on a
https://bugs.freedesktop.org/show_bug.cgi?id=108596
--- Comment #2 from Shmerl ---
(In reply to Samuel Pitoiset from comment #1)
> I have an experimental branch but it still requires a bunch of work, and I
> wouldn't recommend you to use it currently. Anyway, this is on our todolist
> for a long
On Fri, Feb 8, 2019 at 8:33 AM Alejandro Piñeiro
wrote:
> Although on GLSL those are set using a layout qualifier to
> gl_FragCoord builtin, they are basically a global mode. In fact, on
> SPIR-V they are set as an global ExecutionMode, not as a decoration
> for the builtin. With this change, we
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #11 from v...@tuta.io ---
Unfortunately no. Nothing's changed.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #10 from Michel Dänzer ---
One difference between the glxinfo outputs is that there are no 10 bit per
component FBConfigs with the HD 2600 Pro. Does running blender like this:
allow_rgb10_configs=false blender
avoid the problem?
If compute is used, graphics shaders don't need to be created.
Marek
On Fri, Feb 8, 2019 at 9:02 AM James Zhu wrote:
>
> On 2019-02-08 6:33 a.m., Emil Velikov wrote:
> > On Thu, 7 Feb 2019 at 16:37, Zhu, James wrote:
> >> Add compute shader initilization, assign and cleanup in vl_compositor
>
https://bugs.freedesktop.org/show_bug.cgi?id=109574
Michel Dänzer changed:
What|Removed |Added
Attachment #143340|text/x-log |text/plain
mime type|
https://bugs.freedesktop.org/show_bug.cgi?id=109574
Michel Dänzer changed:
What|Removed |Added
Attachment #143343|text/x-log |text/plain
mime type|
This reverts commit 1aa5738e666a9534c7e5b46f077327e6d647c64f.
This patch incorrectly asumed that for SSOs no inner interface
matching check was needed.
From the ARB_separate_shader_objects spec v.25:
" With separable program objects, interfaces between shader stages
may involve the
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #9 from v...@tuta.io ---
Blender version: 2.80 (sub 44), commit date: 2019-02-07 23:15, hash:
3d16a268ee68
Mr. Wollny,
I tried R600_DEBUG=nosb blender but nothing's changed. I added the log files
you asked.
Mr. Michel,
I also
Reviewed-by: Marek Olšák
Marek
On Tue, Feb 5, 2019 at 3:44 AM Nicolai Hähnle wrote:
> From: Nicolai Hähnle
>
> This field was added in a recent addrlib update, and while there
> currently seems to be no issue with skipping it, we will have to
> set it correctly in the future.
> ---
>
FYI, the latest Mesa skips further command submissions (CS) only if you set
{GLX_CONTEXT_RESET_NOTIFICATION_STRATEGY_ARB,
GLX_LOSE_CONTEXT_ON_RESET_ARB} and the CS ioctl fails.
Previous Mesa versions always stopped further command submissions after a
failure and ignored the GLX (and EGL) flags.
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #8 from v...@tuta.io ---
Created attachment 143343
--> https://bugs.freedesktop.org/attachment.cgi?id=143343=edit
xorg log files hd2600pro
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #7 from v...@tuta.io ---
Created attachment 143342
--> https://bugs.freedesktop.org/attachment.cgi?id=143342=edit
R600_DUMP_SHADERS_hd2600pro
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #6 from v...@tuta.io ---
Created attachment 143341
--> https://bugs.freedesktop.org/attachment.cgi?id=143341=edit
glxinfo HD2600pro
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #5 from v...@tuta.io ---
Created attachment 143340
--> https://bugs.freedesktop.org/attachment.cgi?id=143340=edit
Xorg Logs of HD4850
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #4 from v...@tuta.io ---
Created attachment 143339
--> https://bugs.freedesktop.org/attachment.cgi?id=143339=edit
r600dumpsshaders_HD4850_output
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are
https://bugs.freedesktop.org/show_bug.cgi?id=109574
--- Comment #3 from v...@tuta.io ---
Created attachment 143338
--> https://bugs.freedesktop.org/attachment.cgi?id=143338=edit
glxinfo HD 4850
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact
https://bugs.freedesktop.org/show_bug.cgi?id=109201
--- Comment #13 from Alexander ---
Created attachment 143337
--> https://bugs.freedesktop.org/attachment.cgi?id=143337=edit
The Bug (Video)
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for
Add "PIPE_VIDEO_PROFILE_MAX" to enum, so it will make sure here will
be correct when adding more profiles in the future.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109107
Signed-off-by: Leo Liu
Cc: 19.0
---
src/gallium/include/pipe/p_video_enums.h | 3 ++-
If there is no information about number of render targets
Signed-off-by: Leo Liu
Cc: 19.0
---
src/gallium/state_trackers/va/picture_vp9.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/gallium/state_trackers/va/picture_vp9.c
Those builtins need to fill origin_upper_left and pixel_center_integer
on the nir variable. Those depends on the execution mode, that moved
recently to be handled after creating the variables. This commit adds
a pass over the fragment shader inputs to set the proper value once we
have all the
Note that the two patches are independent. Are two possible solutions
for the same problem. Details below.
As mentioned on the following MR:
https://gitlab.freedesktop.org/mesa/mesa/merge_requests/144
changing the order of how ExecutionModes are handled affected handling
OriginUpperLeft and
Although on GLSL those are set using a layout qualifier to
gl_FragCoord builtin, they are basically a global mode. In fact, on
SPIR-V they are set as an global ExecutionMode, not as a decoration
for the builtin. With this change, we are just mapping them more
similar to SPIR-V, instead of more
Those builtins need to fill origin_upper_left and pixel_center_integer
on the nir variable. Those depends on the execution mode, that moved
recently to be handled after creating the variables. This commit adds
a pass over the fragment shader inputs to set the proper value once we
have all the
On 2019-02-08 6:33 a.m., Emil Velikov wrote:
> On Thu, 7 Feb 2019 at 16:37, Zhu, James wrote:
>> Add compute shader initilization, assign and cleanup in vl_compositor API.
>>
>> Signed-off-by: James Zhu
>> Reviewed-by: Christian König
>> ---
>> src/gallium/auxiliary/vl/vl_compositor.c | 31
Hi,
On Fri, 20 Jul 2018 at 19:32, Eric Anholt wrote:
> Harish Krupo writes:
> > Thank you, understood it. I should have read the spec better :(.
> > Also, generalizing Android/deqp's usage seems to be wrong. Android's
> > deqp passed previously even when the driver wasn't restricting the
> >
https://patchwork.freedesktop.org/series/56400/
On Thu, 2019-02-07 at 07:53 +1100, Timothy Arceri wrote:
> Before reviewing this can we get a piglit test for the following scenario
>
> Two "program" objects say:
>
> 1. vs->gs
> 2. fs
>
> Where the interface between vs and gs has a used input
On Sat, 2019-01-26 at 08:37 -0800, Jason Ekstrand wrote:
> This makes me a bit nervous. I'll have to look at it in more detail.
>
Did you have time to take a look at this?
J.A.
> On January 25, 2019 09:37:52 "Juan A. Suarez Romero"
> wrote:
>
> > When stitching two blocks A and B,
This can happen when we record a VkCmdDraw in a secondary buffer that
was created inheriting from the primary buffer, but with the framebuffer
set to NULL in the VkCommandBufferInheritanceInfo.
Vulkan 1.1.81 spec says that "the application must ensure (using scissor
if neccesary) that all
On Mon, 2019-02-04 at 10:01 -0600, Jason Ekstrand wrote:
> On Mon, Feb 4, 2019 at 3:02 AM Juan A. Suarez Romero
> wrote:
> > On Fri, 2019-02-01 at 15:33 -0600, Jason Ekstrand wrote:
> >
> > > On Fri, Feb 1, 2019 at 10:14 AM Juan A. Suarez Romero
> > > wrote:
> >
> > > > This can happen when
The variable is not static? (initializing a static member in the
constructor would be nonsense ...)
With that word remove from the title:
Reviewed-by: Bas Nieuwenhuizen
On Fri, Feb 8, 2019 at 6:26 AM Dave Airlie wrote:
>
> From: Dave Airlie
>
> Fixes coverity warning
> ---
>
On Thu, 7 Feb 2019 at 16:37, Zhu, James wrote:
>
> Add compute shader initilization, assign and cleanup in vl_compositor API.
>
> Signed-off-by: James Zhu
> Reviewed-by: Christian König
> ---
> src/gallium/auxiliary/vl/vl_compositor.c | 31 ++-
>
Hi,
This MR is part of our ongoing work to support NIR in nine. We are
currently testing on radeonsi, but our ultimate goal with this is to
make it possible for nine to run with iris (and eventually zink).
These patches give some polish to tgsi_to_nir (aka. TTN), so that it
can handle the TGSI
Hi Nanley,
On Thu, 7 Feb 2019 15:46:29 -0800
Nanley Chery wrote:
>
> > @@ -3825,10 +3849,20 @@ intel_miptree_unmap(struct brw_context *brw,
> > DBG("%s: mt %p (%s) level %d slice %d\n", __func__,
> > mt, _mesa_get_format_name(mt->format), level, slice);
> >
> > + level_w =
Reviewed-by: Alejandro Piñeiro
On 8/2/19 6:24, Dave Airlie wrote:
From: Dave Airlie
The constructor should init this to NULL
---
src/compiler/glsl/glsl_to_nir.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/glsl/glsl_to_nir.cpp
b/src/compiler/glsl/glsl_to_nir.cpp
Thanks a lot)
Andrii.
On Fri, Feb 8, 2019 at 9:39 AM Kenneth Graunke
wrote:
> On Thursday, February 7, 2019 3:35:01 AM PST andrey simiklit wrote:
> > ping. the piglit test was pushed)
> >
> > Thanks,
> > Andrii.
>
> I landed this today. Thanks!
>
> --Ken
>
On 2/8/19 11:39 AM, Michel Dänzer wrote:
On 2019-02-08 10:30 a.m., Tapani Pälli wrote:
On 2/6/19 7:40 PM, Michel Dänzer wrote:
On 2019-02-06 12:55 p.m., Tapani Pälli wrote:
On 2/6/19 1:16 PM, Michel Dänzer wrote:
On 2019-02-05 11:30 p.m., Marek Olšák wrote:
Hi,
Video players request
https://bugs.freedesktop.org/show_bug.cgi?id=109543
--- Comment #11 from Igor Gnatenko ---
https://www.gnu.org/software/gcc/gcc-9/porting_to.html
Block scope compound literal's lifetime
The C standard says that compound literals which occur inside of the body of a
function have automatic
On 2019-02-08 10:30 a.m., Tapani Pälli wrote:
> On 2/6/19 7:40 PM, Michel Dänzer wrote:
>> On 2019-02-06 12:55 p.m., Tapani Pälli wrote:
>>> On 2/6/19 1:16 PM, Michel Dänzer wrote:
On 2019-02-05 11:30 p.m., Marek Olšák wrote:
> Hi,
>
> Video players request fbconfigs with these
On 1.2.2019 13.08, Emil Velikov wrote:
> Hi Carsten,
>
> On 2019/01/31, Carsten Haitzler wrote:
>> On Wed, 30 Jan 2019 18:33:35 + Emil Velikov
>> said:
>>
>> You might want to hold off on this. My bugfix was actually patched out by
>> partly
>> removing some of it. The void ptr math should
On 2/6/19 7:40 PM, Michel Dänzer wrote:
On 2019-02-06 12:55 p.m., Tapani Pälli wrote:
On 2/6/19 1:16 PM, Michel Dänzer wrote:
On 2019-02-05 11:30 p.m., Marek Olšák wrote:
Hi,
Video players request fbconfigs with these attributes:
GLX_RED_SIZE = 8
GLX_GREEN_SIZE = 8
GLX_BLUE_SIZE = 8
This patch will return VA_STATUS_ERROR_OPERATION_FAILED incase vaDeriveImage()
failed for non-contiguous planes.This error string is required to support
indirect manner i.e. vaCreateImage()+vaPutImage() incase vaDeriveImage()
failed with VA_STATUS_ERROR_OPERATION_FAILED.
Signed-off-by: suresh
73 matches
Mail list logo
