Re: [Mesa-dev] [PATCH 1/6] st/mesa: fix sampler view context mismatch issue

2019-03-14 Thread Mathias Fröhlich
Hi Brian, On Thursday, 14 March 2019 15:04:28 CET Brian Paul wrote: > > Ok, so basically you are saying that you improve the current situation with > > this > > current series, still leaving a race condition open. But a good final fix > > to the race > > condition is underway. > > Yeah, I can

Re: [Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

2019-03-14 Thread Mathias Fröhlich
Hi Brian, the full package looks great and makes a lot of sense! Reviewed-by: Mathias Fröhlich best Mathias On Thursday, 14 March 2019 20:37:09 CET Brian Paul wrote: > When st_texture_release_all_sampler_views() is called the texture may > have sampler views belonging to several contexts.

[Mesa-dev] [PATCH 4/5] panfrost/decode: Respect primitive size pointers

2019-03-14 Thread Alyssa Rosenzweig
Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pandecode/decode.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c b/src/gallium/drivers/panfrost/pandecode/decode.c index e6932744939..28bc0509feb

[Mesa-dev] [PATCH 1/5] panfrost: Workaround buffer overrun with mip level

2019-03-14 Thread Alyssa Rosenzweig
Mipmaps are still broken, but at least this way we don't crash on some apps using mipmaps. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_resource.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_resource.c

[Mesa-dev] [PATCH 5/5] panfrost: Replay more varying buffers

2019-03-14 Thread Alyssa Rosenzweig
This is required for gl_PointCoord to show up on decodes. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pandecode/decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c

[Mesa-dev] [PATCH 2/5] panfrost: Fix primconvert check

2019-03-14 Thread Alyssa Rosenzweig
In addition to fixing actual primconvert bugs, this prevents an infinite loop when trying to draw POINTS. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 3/5] panfrost: Disable PIPE_CAP_TGSI_TEXCOORD

2019-03-14 Thread Alyssa Rosenzweig
I don't know why this was on to begin with...? Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/pan_screen.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c index

[Mesa-dev] [Bug 110116] Neverball particles are broken (GL_POINT_SPRITE)

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110116 QwertyChouskie changed: What|Removed |Added OS|All |Linux (All) CC|

[Mesa-dev] [Bug 110116] Neverball particles are broken (GL_POINT_SPRITE)

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110116 Bug ID: 110116 Summary: Neverball particles are broken (GL_POINT_SPRITE) Product: Mesa Version: 18.3 Hardware: Other OS: All Status: NEW Severity:

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 9:58 PM Roland Scheidegger wrote: > > Am 15.03.19 um 02:18 schrieb Rob Clark: > > On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger > > wrote: > >> > >> Am 14.03.19 um 22:06 schrieb Rob Clark: > >>> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger > >>> wrote: >

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Roland Scheidegger
Am 15.03.19 um 02:18 schrieb Rob Clark: > On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote: >> >> Am 14.03.19 um 22:06 schrieb Rob Clark: >>> On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger >>> wrote: Am 14.03.19 um 14:13 schrieb Rob Clark: > On Tue, Mar 12, 2019 at

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 8:28 PM Roland Scheidegger wrote: > > Am 14.03.19 um 22:06 schrieb Rob Clark: > > On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger > > wrote: > >> > >> Am 14.03.19 um 14:13 schrieb Rob Clark: > >>> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger > >>> wrote: >

Re: [Mesa-dev] [PATCH 8/8] gallium/util: remove pipe_sampler_view_release()

2019-03-14 Thread Roland Scheidegger
This looks all good to me. For the series: Reviewed-by: Roland Scheidegger Am 14.03.19 um 20:37 schrieb Brian Paul: > It's no longer used. > --- > src/gallium/auxiliary/util/u_inlines.h | 20 > 1 file changed, 20 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH v5 08/11] anv: Added support for dynamic sample locations

2019-03-14 Thread Jason Ekstrand
On Thu, Mar 14, 2019 at 7:08 PM Jason Ekstrand wrote: > From: Eleni Maria Stea > > Added support for setting the locations when the pipeline has been > created with the dynamic state bit enabled according to the Vulkan > Specification section [26.5. Custom Sample Locations] for the function: >

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Roland Scheidegger
Am 14.03.19 um 22:06 schrieb Rob Clark: > On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote: >> >> Am 14.03.19 um 14:13 schrieb Rob Clark: >>> On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger >>> wrote: Am 12.03.19 um 16:16 schrieb Rob Clark: > This previously was not

Re: [Mesa-dev] [PATCH v5 00/11] anv: Implement VK_EXT_sample_locations

2019-03-14 Thread Jason Ekstrand
On Thu, Mar 14, 2019 at 7:08 PM Jason Ekstrand wrote: > Eleni, > > I made a comment on one of your patches and then I started getting lost in > the churn. It's easier to see what's going on if things are reordered and > refactored a bit. Unfortunately, what needed to be done was hard to >

[Mesa-dev] [PATCH v5 02/11] anv: Set the values for the VkPhysicalDeviceSampleLocationsPropertiesEXT

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea The VkPhysicalDeviceSampleLocationPropertiesEXT struct is filled with implementation dependent values and according to the table from the Vulkan Specification section [36.1. Limit Requirements]: pname | max | min pname:sampleLocationSampleCounts |-

[Mesa-dev] [PATCH v5 03/11] anv: Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT according to the Vulkan Specification section [36.2. Additional Multisampling Capabilities]. v2: 1- Moved the vkGetPhysicalDeviceMultisamplePropertiesEXT from the anv_sample_locations.c to the anv_device.c

[Mesa-dev] [PATCH v5 10/11] anv: Removed unused header file

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea In src/intel/vulkan/genX_blorp_exec.c we included the file: common/gen_sample_positions.h but not use it. Removed. Reviewed-by: Sagar Ghuge Reviewed-by: Jason Ekstrand --- src/intel/vulkan/genX_blorp_exec.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] [PATCH v5 05/11] anv: Break SAMPLE_PATTERN and MULTISAMPLE emit into helpers

2019-03-14 Thread Jason Ekstrand
--- src/intel/vulkan/anv_genX.h | 4 ++ src/intel/vulkan/genX_pipeline.c | 40 +-- src/intel/vulkan/genX_state.c| 84 3 files changed, 70 insertions(+), 58 deletions(-) diff --git a/src/intel/vulkan/anv_genX.h b/src/intel/vulkan/anv_genX.h

[Mesa-dev] [PATCH v5 09/11] anv: Optimized the emission of the default locations on Gen8+

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea We only emit sample locations when the extension is enabled by the user. In all other cases the default locations are emitted once when the device is initialized to increase performance. --- src/intel/vulkan/genX_cmd_buffer.c | 1 + src/intel/vulkan/genX_pipeline.c | 3

[Mesa-dev] [PATCH v5 07/11] anv: Add support for non-dynamic sample locations

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea Allowing the user to set custom sample locations non-dynamically, by filling the extension structs and chaining them to the pipeline structs according to the Vulkan specification section [26.5. Custom Sample Locations] for the following structures:

[Mesa-dev] [PATCH v5 01/11] anv: Added the VK_EXT_sample_locations extension to the anv_extensions list

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea Added the VK_EXT_sample_locations to the anv_extensions.py list to generate the related entrypoints. Reviewed-by: Sagar Ghuge --- src/intel/vulkan/anv_extensions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_extensions.py

[Mesa-dev] [PATCH v5 00/11] anv: Implement VK_EXT_sample_locations

2019-03-14 Thread Jason Ekstrand
Eleni, I made a comment on one of your patches and then I started getting lost in the churn. It's easier to see what's going on if things are reordered and refactored a bit. Unfortunately, what needed to be done was hard to explain and it was easier for me to just do the code motion and re-send

[Mesa-dev] [PATCH v5 11/11] anv: Enabled the VK_EXT_sample_locations extension

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea Enabled the VK_EXT_sample_locations for Intel Gen >= 7. v2: Replaced device.info->gen >= 7 with True, as Anv doesn't support anything below Gen7. (Lionel Landwerlin) Reviewed-by: Sagar Ghuge --- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1

[Mesa-dev] [PATCH v5 06/11] anv/state: Take explicit sample locations in emit helpers

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea This commit adds a "locations" parameter to emit_multisample and emit_sample_pattern which, if provided, will override the default sample locations. --- src/intel/common/gen_sample_positions.h | 57 + src/intel/vulkan/anv_genX.h | 6 +-

[Mesa-dev] [PATCH v5 08/11] anv: Added support for dynamic sample locations

2019-03-14 Thread Jason Ekstrand
From: Eleni Maria Stea Added support for setting the locations when the pipeline has been created with the dynamic state bit enabled according to the Vulkan Specification section [26.5. Custom Sample Locations] for the function: 'vkCmdSetSampleLocationsEXT' The reason that we preferred to

[Mesa-dev] [PATCH v5 04/11] anv/pipeline: Refactor 3DSTATE_SAMPLE_MASK setup

2019-03-14 Thread Jason Ekstrand
--- src/intel/vulkan/genX_pipeline.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/src/intel/vulkan/genX_pipeline.c b/src/intel/vulkan/genX_pipeline.c index 975052deb79..8ba206ed8c4 100644 --- a/src/intel/vulkan/genX_pipeline.c +++

[Mesa-dev] [Bug 100316] Linking GLSL 1.30 shaders with invariant and deprecated variables triggers an 'mismatching invariant qualifiers' error

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100316 --- Comment #4 from Jordan Justen --- (In reply to Danylo from comment #3) > I've sent the patch for more general manifestation of the issue: > https://patchwork.freedesktop.org/patch/247067/ Just noting that Danylo submitted a merge request

Re: [Mesa-dev] [PATCH 8/8] gallium/util: remove pipe_sampler_view_release()

2019-03-14 Thread Neha Bhende
Looks great! For series, Reviewed-by: Neha Bhende Regards, Neha From: Brian Paul Sent: Thursday, March 14, 2019 12:37 PM To: mesa-dev@lists.freedesktop.org Cc: Neha Bhende; Jose Fonseca; Roland Scheidegger; Mathias Fröhlich Subject: [PATCH 8/8]

Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-14 Thread Eric Anholt
Rob Clark writes: > On Thu, Mar 14, 2019 at 3:35 PM Eric Anholt wrote: >> >> Rob Clark writes: >> >> > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner >> > wrote: >> >> >> >> Use u_transfer_helper_resource_create(..) instead which uses the >> >> resource_create(..) function specified in

Re: [Mesa-dev] [PATCH v4 4/9] anv: Added support for non-dynamic sample locations on Gen8+

2019-03-14 Thread Jason Ekstrand
On Thu, Mar 14, 2019 at 2:52 PM Eleni Maria Stea wrote: > Allowing the user to set custom sample locations non-dynamically, by > filling the extension structs and chaining them to the pipeline structs > according to the Vulkan specification section [26.5. Custom Sample > Locations] for the

[Mesa-dev] 2019 X.Org Foundation Election Delayed

2019-03-14 Thread Wentland, Harry
To all X.Org Foundation Members: In order to give members more time to process the proposed changes to the bylaw the elections committee decided to delay the start of voting by one week. Updated Schedule: Nomination period Start: Jan 31 00:00 UTC Nomination period End: Feb 28 23:59 UTC

[Mesa-dev] Bylaw Changes Vote

2019-03-14 Thread Wentland, Harry
To all X.Org Foundation Members: My previous emails about the 2019 X.Org elections failed to mention on important ballot items that we'd like to vote on, in addition to the new board members: the Bylaw change The updated Bylaws to be voted on can be found here:

Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 3:35 PM Eric Anholt wrote: > > Rob Clark writes: > > > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner > > wrote: > >> > >> Use u_transfer_helper_resource_create(..) instead which uses the > >> resource_create(..) function specified in u_transfer_vtbl. > >> > >>

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 3:58 PM Roland Scheidegger wrote: > > Am 14.03.19 um 14:13 schrieb Rob Clark: > > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger > > wrote: > >> > >> Am 12.03.19 um 16:16 schrieb Rob Clark: > >>> This previously was not called out clearly, but based on a survey of

Re: [Mesa-dev] 2019 X.Org Foundation Election Candidates

2019-03-14 Thread Wentland, Harry
On 2019-03-14 4:40 p.m., Luc Verhaegen wrote: > On Thu, Mar 14, 2019 at 08:36:13PM +, Wentland, Harry wrote: >> On 2019-03-12 6:49 a.m., Luc Verhaegen wrote: >>> >>> Are these candidates the only thing we will be voting on? >>> >> >> You're right. The FDO question totally slipped me mind. >>

Re: [Mesa-dev] 2019 X.Org Foundation Election Candidates

2019-03-14 Thread Luc Verhaegen
On Thu, Mar 14, 2019 at 08:36:13PM +, Wentland, Harry wrote: > On 2019-03-12 6:49 a.m., Luc Verhaegen wrote: > > > > Are these candidates the only thing we will be voting on? > > > > You're right. The FDO question totally slipped me mind. > > We'll also be voting on the bylaw change I sent

Re: [Mesa-dev] 2019 X.Org Foundation Election Candidates

2019-03-14 Thread Wentland, Harry
On 2019-03-12 6:49 a.m., Luc Verhaegen wrote: > On Tue, Mar 12, 2019 at 12:24:00AM +, Wentland, Harry wrote: >> To all X.Org Foundation Members: >> >> The election for the X.Org Foundation Board of Directors will begin on >> 14 March 2019. We have 6 candidates who are running for 4 seats.

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Roland Scheidegger
Am 14.03.19 um 14:13 schrieb Rob Clark: > On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: >> >> Am 12.03.19 um 16:16 schrieb Rob Clark: >>> This previously was not called out clearly, but based on a survey of the >>> code, it seems the expected behavior is to release the reference to

[Mesa-dev] [PATCH v4 3/9] anv: Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT

2019-03-14 Thread Eleni Maria Stea
Implemented the vkGetPhysicalDeviceMultisamplePropertiesEXT according to the Vulkan Specification section [36.2. Additional Multisampling Capabilities]. v2: 1- Moved the vkGetPhysicalDeviceMultisamplePropertiesEXT from the anv_sample_locations.c to the anv_device.c (Jason Ekstrand) 2-

[Mesa-dev] [PATCH v4 7/9] anv: Optimized the emission of the default locations on Gen8+

2019-03-14 Thread Eleni Maria Stea
We only emit sample locations when the extension is enabled by the user. In all other cases the default locations are emitted once when the device is initialized to increase performance. --- src/intel/vulkan/anv_genX.h| 3 ++- src/intel/vulkan/genX_cmd_buffer.c | 2 +-

[Mesa-dev] [PATCH v4 8/9] anv: Removed unused header file

2019-03-14 Thread Eleni Maria Stea
In src/intel/vulkan/genX_blorp_exec.c we included the file: common/gen_sample_positions.h but not use it. Removed. Reviewed-by: Sagar Ghuge Reviewed-by: Jason Ekstrand --- src/intel/vulkan/genX_blorp_exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/vulkan/genX_blorp_exec.c

[Mesa-dev] [PATCH v4 6/9] anv: Added support for dynamic and non-dynamic sample locations on Gen7

2019-03-14 Thread Eleni Maria Stea
Allowing setting dynamic and non-dynamic sample locations on Gen7. v2: Similarly to the previous patches, removed structs and functions that were used to sort and store the sorted sample positions (Jason Ekstrand) --- src/intel/vulkan/anv_genX.h| 13 ++---

[Mesa-dev] [PATCH v4 9/9] anv: Enabled the VK_EXT_sample_locations extension

2019-03-14 Thread Eleni Maria Stea
Enabled the VK_EXT_sample_locations for Intel Gen >= 7. v2: Replaced device.info->gen >= 7 with True, as Anv doesn't support anything below Gen7. (Lionel Landwerlin) Reviewed-by: Sagar Ghuge --- src/intel/vulkan/anv_extensions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Mesa-dev] [PATCH v4 4/9] anv: Added support for non-dynamic sample locations on Gen8+

2019-03-14 Thread Eleni Maria Stea
Allowing the user to set custom sample locations non-dynamically, by filling the extension structs and chaining them to the pipeline structs according to the Vulkan specification section [26.5. Custom Sample Locations] for the following structures: 'VkPipelineSampleLocationsStateCreateInfoEXT'

[Mesa-dev] [PATCH v4 5/9] anv: Added support for dynamic sample locations on Gen8+

2019-03-14 Thread Eleni Maria Stea
Added support for setting the locations when the pipeline has been created with the dynamic state bit enabled according to the Vulkan Specification section [26.5. Custom Sample Locations] for the function: 'vkCmdSetSampleLocationsEXT' The reason that we preferred to store the boolean valid

[Mesa-dev] [PATCH v4 0/9] Implementation of the VK_EXT_sample_locations

2019-03-14 Thread Eleni Maria Stea
Implemented the requirements from the VK_EXT_sample_locations extension specification to allow setting custom sample locations on Intel Gen >= 7. Some decisions explained: The grid size was set to 1x1 because the hardware only supports a single set of sample locations for the whole framebuffer.

[Mesa-dev] [PATCH v4 2/9] anv: Set the values for the VkPhysicalDeviceSampleLocationsPropertiesEXT

2019-03-14 Thread Eleni Maria Stea
The VkPhysicalDeviceSampleLocationPropertiesEXT struct is filled with implementation dependent values and according to the table from the Vulkan Specification section [36.1. Limit Requirements]: pname | max | min pname:sampleLocationSampleCounts |-|ename:VK_SAMPLE_COUNT_4_BIT

[Mesa-dev] [PATCH v4 1/9] anv: Added the VK_EXT_sample_locations extension to the anv_extensions list

2019-03-14 Thread Eleni Maria Stea
Added the VK_EXT_sample_locations to the anv_extensions.py list to generate the related entrypoints. Reviewed-by: Sagar Ghuge --- src/intel/vulkan/anv_extensions.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/vulkan/anv_extensions.py b/src/intel/vulkan/anv_extensions.py index

[Mesa-dev] [PATCH 2/8] st/mesa: implement "zombie" shaders list

2019-03-14 Thread Brian Paul
As with the preceding patch for sampler views, this patch does basically the same thing but for shaders. However, reference counting isn't needed here (instead of calling cso_delete_XXX_shader() we call st_save_zombie_shader(). The Redway3D Watch is one app/demo that needs this change.

[Mesa-dev] [PATCH 6/8] swr: remove call to pipe_sampler_view_release()

2019-03-14 Thread Brian Paul
As with svga, llvmpipe drivers in previous patches. Compile tested only. --- src/gallium/drivers/swr/swr_state.cpp | 5 - 1 file changed, 5 deletions(-) diff --git a/src/gallium/drivers/swr/swr_state.cpp b/src/gallium/drivers/swr/swr_state.cpp index d7baa71..42d196f 100644 ---

[Mesa-dev] [PATCH 5/8] llvmpipe: stop using pipe_sampler_view_release()

2019-03-14 Thread Brian Paul
This was used to avoid freeing a sampler view which was created by a context that was already deleted. But the state tracker does not allow that. --- src/gallium/drivers/llvmpipe/lp_state_sampler.c | 6 -- 1 file changed, 6 deletions(-) diff --git

[Mesa-dev] [PATCH 3/8] st/mesa: stop using pipe_sampler_view_release()

2019-03-14 Thread Brian Paul
In all instances here we can replace pipe_sampler_view_release(pipe, view) with pipe_sampler_view_reference(view, NULL) because the views in question are private to the state tracker context. So there's no danger of freeing a sampler view with the wrong context. Testing done: google chrome, misc

[Mesa-dev] [PATCH 1/8] st/mesa: implement "zombie" sampler views

2019-03-14 Thread Brian Paul
When st_texture_release_all_sampler_views() is called the texture may have sampler views belonging to several contexts. If we unreference a sampler view and its refcount hits zero, we need to be sure to destroy the sampler view with the same context which created it. This was not the case with

[Mesa-dev] [PATCH 8/8] gallium/util: remove pipe_sampler_view_release()

2019-03-14 Thread Brian Paul
It's no longer used. --- src/gallium/auxiliary/util/u_inlines.h | 20 1 file changed, 20 deletions(-) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index fa1e920..567d3d0 100644 --- a/src/gallium/auxiliary/util/u_inlines.h +++

[Mesa-dev] [PATCH 4/8] svga: stop using pipe_sampler_view_release()

2019-03-14 Thread Brian Paul
This function was used in the past to avoid deleting a sampler view for a context that no longer exists. But the Mesa state tracker ensures that cannot happen. Use the standard refcounting function instead. Also, remove the code which checked for context mis-matches in

[Mesa-dev] [PATCH 7/8] i915g: remove calls to pipe_sampler_view_release()

2019-03-14 Thread Brian Paul
As with previous patches for svga, llvmpipe, swr drivers. Compile tested only. --- src/gallium/drivers/i915/i915_state.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/gallium/drivers/i915/i915_state.c b/src/gallium/drivers/i915/i915_state.c index

Re: [Mesa-dev] [PATCH] gallium/u_transfer_helper: do not call resource_create(..) directly

2019-03-14 Thread Eric Anholt
Rob Clark writes: > On Fri, Mar 1, 2019 at 10:54 AM Christian Gmeiner > wrote: >> >> Use u_transfer_helper_resource_create(..) instead which uses the >> resource_create(..) function specified in u_transfer_vtbl. >> >> Signed-off-by: Christian Gmeiner >> --- >>

Re: [Mesa-dev] [virglrenderer-devel] virglrenderer on gles, format conversion

2019-03-14 Thread Erik Faye-Lund
On Wed, 2019-03-06 at 13:39 +1000, Dave Airlie wrote: > On Wed, 6 Mar 2019 at 01:01, Erik Faye-Lund > wrote: > > When we try to do a vrend transfer from a renderable texture, we > > end up > > using glReadPixels to read the data. However, OpenGL ES has > > restrictions on what formats are allowed

Re: [Mesa-dev] [PATCH] i965/blorp: Remove unused parameter from blorp_surf_for_miptree.

2019-03-14 Thread Jason Ekstrand
Yup. Not getting used at all. Reviewed-by: Jason Ekstrand On Thu, Mar 14, 2019 at 12:10 PM Rafael Antognolli < rafael.antogno...@intel.com> wrote: > It seems pretty useless nowadays. > --- > src/mesa/drivers/dri/i965/brw_blorp.c | 36 +-- > 1 file changed, 12

[Mesa-dev] [PATCH] i965/blorp: Remove unused parameter from blorp_surf_for_miptree.

2019-03-14 Thread Rafael Antognolli
It seems pretty useless nowadays. --- src/mesa/drivers/dri/i965/brw_blorp.c | 36 +-- 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c b/src/mesa/drivers/dri/i965/brw_blorp.c index 97a5f6a9937..e09a8cef762 100644 ---

Re: [Mesa-dev] [PATCH 1/6] st/mesa: fix sampler view context mismatch issue

2019-03-14 Thread Jose Fonseca
On 08/03/2019 22:52, Brian Paul wrote: After a while of running google-chrome and viewing Bing maps, we'd see "context mismatch in svga_sampler_view_destroy()" messages and eventually crash because we leaked too many sampler views (the kernel module would have too many sampler views). When a

[Mesa-dev] [Bug 109159] [KBL-G][vulkan] dEQP-VK.api.version_check.entry_points test failed.

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109159 --- Comment #4 from Samuel Pitoiset --- Any news on this? This test always pass on my side. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the

Re: [Mesa-dev] [PATCH] nir/spirv: short-circuit when conditional branch contains end block

2019-03-14 Thread Jason Ekstrand
Looking at this a bit more, I'm not sure that just short-circuiting actually covers all the cases. Unfortunately, we don't know what all the cases are because the SPIR-V spec doesn't say. I'm trying to work towards fixing that right now. --Jason On Wed, Mar 6, 2019 at 5:25 AM Juan A. Suarez

[Mesa-dev] [Bug 107563] [RADV] Broken rendering in Unity demos

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107563 Samuel Pitoiset changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Eric Anholt
Alyssa Rosenzweig writes: > This function is replicated across vc4/v3d/freedreno and is needed in > Panfrost; let's make this shared code. > > Signed-off-by: Alyssa Rosenzweig > --- > src/util/u_drm.h | 46 ++ > 1 file changed, 46 insertions(+) >

Re: [Mesa-dev] [PATCH 9/9] mesa: Add assert to _mesa_primitive_restart_index.

2019-03-14 Thread Mathias Fröhlich
Hi Brian, On Thursday, 14 March 2019 14:55:11 CET Brian Paul wrote: > yeah, looks good. Thanks. > > Reviewed-by: Brian Paul > > I don't remember- do you need me to push your patches for you? Thanks for the review! I have rights to push. Thanks for asking!! best Mathias

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Alyssa Rosenzweig
> hmm, I guess there are already two or three other places that already > copy/pasta'd this specifically for modifiers.. so I'm ok with the less > generic name, since it (IMHO) makes the code calling it more clear. This was my reasoning, yeah... I'm not sure why it is so generic, honestly (should

Re: [Mesa-dev] [PATCH] panfrost: Adapt to uapi changes

2019-03-14 Thread Alyssa Rosenzweig
Reviewed-by: Alyssa Rosenzweig ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 109929] tgsi_to_nir.c:2111: undefined reference to `gl_nir_lower_samplers_as_deref'

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109929 --- Comment #5 from Timur Kristóf --- Okay, I think I got it. Can you please try with this patch: https://gitlab.freedesktop.org/Venemo/mesa/commit/c1efd5b26d210b017118d29ecf16aaaeeb34a420 It gets rid of the problem for me. -- You are

[Mesa-dev] [PATCH] panfrost: Adapt to uapi changes

2019-03-14 Thread Tomeu Vizoso
Two ioctls had wrong DRM_IO* flags. Signed-off-by: Tomeu Vizoso --- include/drm-uapi/panfrost_drm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm-uapi/panfrost_drm.h b/include/drm-uapi/panfrost_drm.h index a0ead4979ccc..508b9621d9db 100644 ---

Re: [Mesa-dev] [PATCH] nir/spirv: short-circuit when conditional branch contains end block

2019-03-14 Thread Jason Ekstrand
On Thu, Mar 14, 2019 at 4:09 AM Juan A. Suarez Romero wrote: > On Fri, 2019-03-08 at 13:29 -0600, Jason Ekstrand wrote: > > On Fri, Mar 8, 2019 at 9:30 AM Juan A. Suarez Romero > wrote: > > On Thu, 2019-03-07 at 07:15 -0600, Jason Ekstrand wrote: > > Woah, is this legal SPIR-V? I think a second

Re: [Mesa-dev] [PATCH 1/6] st/mesa: fix sampler view context mismatch issue

2019-03-14 Thread Brian Paul
On 03/14/2019 12:24 AM, Mathias Fröhlich wrote: Hi Brian, On Sunday, 10 March 2019 21:32:39 CET Brian Paul wrote: On Friday, 8 March 2019 23:52:09 CET Brian Paul wrote: After a while of running google-chrome and viewing Bing maps, we'd see "context mismatch in svga_sampler_view_destroy()"

Re: [Mesa-dev] [PATCH] radv: always initialize HTILE when the src layout is UNDEFINED

2019-03-14 Thread Bas Nieuwenhuizen
r-b On Thu, Mar 14, 2019 at 2:24 PM Samuel Pitoiset wrote: > > HTILE should always be initialized when transitioning from > VK_IMAGE_LAYOUT_UNDEFINED to other image layouts. Otherwise, > if an app does a transition from UNDEFINED to GENERAL, the > driver doesn't initialize HTILE and it tries to

Re: [Mesa-dev] [PATCH 9/9] mesa: Add assert to _mesa_primitive_restart_index.

2019-03-14 Thread Brian Paul
On 03/14/2019 06:33 AM, mathias.froehl...@gmx.net wrote: From: Mathias Fröhlich Hi Brian, You mean an assert like this? yeah, looks good. Thanks. Reviewed-by: Brian Paul I don't remember- do you need me to push your patches for you? -Brian This patch also made it together with the

[Mesa-dev] [PATCH] radv: always initialize HTILE when the src layout is UNDEFINED

2019-03-14 Thread Samuel Pitoiset
HTILE should always be initialized when transitioning from VK_IMAGE_LAYOUT_UNDEFINED to other image layouts. Otherwise, if an app does a transition from UNDEFINED to GENERAL, the driver doesn't initialize HTILE and it tries to decompress the depth surface. For some reasons, this results in VM

Re: [Mesa-dev] [PATCH] gallium/docs: clarify set_sampler_views

2019-03-14 Thread Rob Clark
On Tue, Mar 12, 2019 at 1:59 PM Roland Scheidegger wrote: > > Am 12.03.19 um 16:16 schrieb Rob Clark: > > This previously was not called out clearly, but based on a survey of the > > code, it seems the expected behavior is to release the reference to any > > sampler views beyond the new range

Re: [Mesa-dev] [PATCH 2/4] freedreno: Use shared drm_find_modifier util

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 12:19 AM Alyssa Rosenzweig wrote: > > Signed-off-by: Alyssa Rosenzweig > Cc: Rob Clark thanks, r-b > --- > .../drivers/freedreno/freedreno_resource.c| 20 --- > 1 file changed, 4 insertions(+), 16 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 5:51 AM Eric Engestrom wrote: > > On Thursday, 2019-03-14 04:19:02 +, Alyssa Rosenzweig wrote: > > This function is replicated across vc4/v3d/freedreno and is needed in > > Panfrost; let's make this shared code. > > > > Signed-off-by: Alyssa Rosenzweig > > --- > >

[Mesa-dev] [PATCH 9/9] mesa: Add assert to _mesa_primitive_restart_index.

2019-03-14 Thread Mathias . Froehlich
From: Mathias Fröhlich Hi Brian, You mean an assert like this? This patch also made it together with the rest of the series through intels CI. best Mathias Make sure the inde_size parameter is meant to be in bytes. Signed-off-by: Mathias Fröhlich --- src/mesa/main/varray.h | 3 +++ 1

[Mesa-dev] [PATCH 1/9] mesa: Implement helper functions to map and unmap a VAO.

2019-03-14 Thread Mathias . Froehlich
From: Mathias Fröhlich Brian, For reference the v2 with the updated comments. Thanks and best Mathias Provide a set of functions that maps or unmaps all VBOs held in a VAO. The functions will be used in the following patches. v2: Update comments. Signed-off-by: Mathias Fröhlich ---

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/3] glsl: TCS outputs can not be transform feedback candidates on GLES

2019-03-14 Thread Chema Casanova
On 13/3/19 23:17, Emil Velikov wrote: > Hi Jose, > > On Wed, 21 Nov 2018 at 18:45, Jose Maria Casanova Crespo > wrote: >> >> Fixes: >> KHR-GLES*.core.tessellation_shader.single.xfb_captures_data_from_correct_stage >> > This and the follow-up patch "glsl: fix recording of variables for XFB > in

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Eric Engestrom
On Thursday, 2019-03-14 04:19:02 +, Alyssa Rosenzweig wrote: > This function is replicated across vc4/v3d/freedreno and is needed in > Panfrost; let's make this shared code. > > Signed-off-by: Alyssa Rosenzweig > --- > src/util/u_drm.h | 46 ++ >

Re: [Mesa-dev] [PATCH] nir/spirv: short-circuit when conditional branch contains end block

2019-03-14 Thread Juan A. Suarez Romero
On Fri, 2019-03-08 at 13:29 -0600, Jason Ekstrand wrote: > On Fri, Mar 8, 2019 at 9:30 AM Juan A. Suarez Romero > wrote: > > On Thu, 2019-03-07 at 07:15 -0600, Jason Ekstrand wrote: > > > > > Woah, is this legal SPIR-V? I think a second OpSelectionMerge is required. > > > > > > > > I'd say

[Mesa-dev] [Bug 109764] [radv] Enable framerate capping

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109764 soredake changed: What|Removed |Added CC||fds...@krutt.org -- You are receiving this

[Mesa-dev] [Bug 108596] [RADV] Implement a HUD for monitoring GPU/CPU loads, FPS, temperature and more

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108596 soredake changed: What|Removed |Added CC||fds...@krutt.org -- You are receiving this

[Mesa-dev] [Bug 110078] rtg

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110078 Michel Dänzer changed: What|Removed |Added Status|NEW |RESOLVED Product|Mesa

[Mesa-dev] [Bug 105904] Needed to delete mesa shader cache after driver upgrade for 32 bit wine vulkan programs to work.

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105904 Andre Klapper changed: What|Removed |Added QA Contact|dani.ta...@outlook.com |mesa-dev@lists.freedesktop.

[Mesa-dev] [Bug 98135] dEQP-GLES31.functional.debug.negative_coverage.get_error.shader.transform_feedback_varyings wants a different GL error code

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98135 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98243] dEQP mismatched UBO precision qualifiers

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98243 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 99076] dEQP-GLES3.functional.negative_api.texture#teximage3d fails due to wrong Error code

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99076 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98223] dEQP GLES3.1 program_interface_query failures w/ error "could not find target resource"

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98223 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98133] GetSynciv should raise an error if bufSize < 0

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98133 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98241] dEQP GLES3.1 failure "Compute Shader should not have compiled with #version 300 es."

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98241 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98245] GLES3.1 link negative dEQP "expected linking to fail, but passed."

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98245 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98242] dEQP mandates preprocessor tests for #line expressions

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98242 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98132] #version 300 es compute shaders should not be possible

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98132 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 94116] program interface queries not returning right data for UBO / GL_BLOCK_INDEX

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=94116 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

[Mesa-dev] [Bug 98134] dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.draw_buffers wants a different GL error code

2019-03-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98134 Andre Klapper changed: What|Removed |Added Blocks|110097 | -- You are receiving this mail

  1   2   >